)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1bf7edc8978b7ffa5d33a4202d950ffdd691f5b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6bd7da9_be878b0f","updated":"2022-03-08 14:40:04.000000000","message":"It makes sense. That was implemented to limit the type of ports that could have, in DVR mode, a FIP associated (for example, SRIOV can\u0027t have connectivity to the FIP namespace in the same compute node).\n\nNow with this new vnic type we should allow it. Of course, that implies the OVS service runs all in the NIC.","commit_id":"e2f05ffabccda1a8a213cbc2e27c2bf910e5766c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4aefdcb02bd966d9938e99d34ac6a93eb7ca0f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6683b558_d05c8d13","updated":"2022-03-08 11:41:17.000000000","message":"Sounds good for me but I saw that Brian wants to discuss it during the Neutron team meeting first","commit_id":"e2f05ffabccda1a8a213cbc2e27c2bf910e5766c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"aa7383e256e791f1f74abecd9a4ff0ff7de342ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"50385f98_be557395","updated":"2022-03-08 14:38:37.000000000","message":"We talked about this in the meeting a minute ago and Lajos agreed it looked ok to him. And I guess since there is no unit test there is nothing else required.","commit_id":"e2f05ffabccda1a8a213cbc2e27c2bf910e5766c"},{"author":{"_account_id":31769,"name":"Jacy Lee","email":"yajiemango@163.com","username":"yjmango"},"change_message_id":"b076a3a431899c273cad0983f547c61586e1a675","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81f2710a_3ed21bcf","updated":"2022-03-09 01:22:46.000000000","message":"recheck","commit_id":"e2f05ffabccda1a8a213cbc2e27c2bf910e5766c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"197f204b8cd18a0e6d68a133c5b75271a9b1aa65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c37e53bb_ff9ac9e9","updated":"2022-03-08 17:18:50.000000000","message":"recheck","commit_id":"e2f05ffabccda1a8a213cbc2e27c2bf910e5766c"}],"neutron_lib/plugins/utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f94f83dd154d89eed6543f0b8101b63d31a9a48b","unresolved":true,"context_lines":[{"line_number":391,"context_line":"    \"\"\"Returns if port can be bound to a virtual bridge (e.g.: LB, OVS)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    :param port: (dict) A port dictionary."},{"line_number":394,"context_line":"    :returns: True if the port VNIC type is \u0027normal\u0027; False in any other case."},{"line_number":395,"context_line":"    \"\"\""},{"line_number":396,"context_line":"    return port[pb.VNIC_TYPE] in [pb.VNIC_NORMAL, pb.VNIC_SMARTNIC]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f9df3fe_45e05c08","line":394,"updated":"2022-03-03 17:33:10.000000000","message":"This comment will need to be updated.","commit_id":"0c5afb83f4d32a28cccd04626f1b6598249fcc98"},{"author":{"_account_id":31769,"name":"Jacy Lee","email":"yajiemango@163.com","username":"yjmango"},"change_message_id":"3e01835e3fba6025e346fe9aeec1d903d4445316","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    \"\"\"Returns if port can be bound to a virtual bridge (e.g.: LB, OVS)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    :param port: (dict) A port dictionary."},{"line_number":394,"context_line":"    :returns: True if the port VNIC type is \u0027normal\u0027; False in any other case."},{"line_number":395,"context_line":"    \"\"\""},{"line_number":396,"context_line":"    return port[pb.VNIC_TYPE] in [pb.VNIC_NORMAL, pb.VNIC_SMARTNIC]"}],"source_content_type":"text/x-python","patch_set":1,"id":"e752ac30_91277eaf","line":394,"in_reply_to":"7f9df3fe_45e05c08","updated":"2022-03-04 06:09:57.000000000","message":"Done","commit_id":"0c5afb83f4d32a28cccd04626f1b6598249fcc98"}]}