)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"b5f640846eeb69723e29240ce6c8a42ae0872e80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4b237df8_39a3ed1d","updated":"2022-03-18 15:55:25.000000000","message":"Looking good.","commit_id":"754939e40fd2607598707a5a87f0e90ba929a368"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1ceda7e7dc577a4b4a9183380e49eb03aba2a038","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f8a1c44f_1db04fa5","updated":"2022-03-24 12:25:36.000000000","message":"Let\u0027s wait if Bence or Slawek has any more comments","commit_id":"b5f0a2642794a3855097bb1a5221076849ab675f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"082a4b9abfd56f41035b2dffa7502fa8b0d409c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"60aa5c5e_11a6a31f","updated":"2022-03-24 12:56:00.000000000","message":"Looking good. Wondering if one more paragraph would be useful in the api-ref.","commit_id":"b5f0a2642794a3855097bb1a5221076849ab675f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"046153302e731514064428bc730b440b9c3b1c44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"445a2e53_1d5da5a3","updated":"2022-03-25 17:56:08.000000000","message":"recheck","commit_id":"b5f0a2642794a3855097bb1a5221076849ab675f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4fecdf6d1ad1669802e5190a77440dd21e4a6195","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16ad38ed_ab110711","updated":"2022-04-21 08:53:34.000000000","message":"recheck retry limits","commit_id":"b5f0a2642794a3855097bb1a5221076849ab675f"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"b5f640846eeb69723e29240ce6c8a42ae0872e80","unresolved":true,"context_lines":[{"line_number":4556,"context_line":"  description: |"},{"line_number":4557,"context_line":"    The MAC address of the port. If the port uses the ``direct-physical``"},{"line_number":4558,"context_line":"    ``vnic_type`` then the value of this field is overwritten with the MAC"},{"line_number":4559,"context_line":"    address provided in the active binding:profile if any."},{"line_number":4560,"context_line":"  in: body"},{"line_number":4561,"context_line":"  required: true"},{"line_number":4562,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"44eff678_c2b48af4","line":4559,"updated":"2022-03-18 15:55:25.000000000","message":"Can we also have (not neccessarily here) a sentence about what format we expect in the binding:profile?","commit_id":"754939e40fd2607598707a5a87f0e90ba929a368"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b2e753e5be94ac7bdd865d6f53c9d51735f8fdc1","unresolved":false,"context_lines":[{"line_number":4556,"context_line":"  description: |"},{"line_number":4557,"context_line":"    The MAC address of the port. If the port uses the ``direct-physical``"},{"line_number":4558,"context_line":"    ``vnic_type`` then the value of this field is overwritten with the MAC"},{"line_number":4559,"context_line":"    address provided in the active binding:profile if any."},{"line_number":4560,"context_line":"  in: body"},{"line_number":4561,"context_line":"  required: true"},{"line_number":4562,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bad5f4a7_72c3652d","line":4559,"in_reply_to":"44eff678_c2b48af4","updated":"2022-03-18 16:06:14.000000000","message":"Done","commit_id":"754939e40fd2607598707a5a87f0e90ba929a368"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"88847e469dc3a8ed511d0324986b39ce035d30b2","unresolved":true,"context_lines":[{"line_number":2660,"context_line":"    Since the port-mac-address-override extension the ``mac_address`` field of"},{"line_number":2661,"context_line":"    the binding:profile can be used to provide the MAC address of the physical"},{"line_number":2662,"context_line":"    device a direct-physical port is being bound to. If provided, then the"},{"line_number":2663,"context_line":"    ``mac_address`` field of the port resource will return the MAC from the"},{"line_number":2664,"context_line":"    active binding."},{"line_number":2665,"context_line":"  in: body"},{"line_number":2666,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"57884467_80c88666","line":2663,"range":{"start_line":2663,"start_character":47,"end_line":2663,"end_character":58},"updated":"2022-03-21 09:36:45.000000000","message":"not just return but actually change port\u0027s mac address in DB, right?","commit_id":"70ff3f384aa19775b4866247b55580fe82781b94"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c3b96f0713d69ba895bbfb1255445cc86ae36d82","unresolved":false,"context_lines":[{"line_number":2660,"context_line":"    Since the port-mac-address-override extension the ``mac_address`` field of"},{"line_number":2661,"context_line":"    the binding:profile can be used to provide the MAC address of the physical"},{"line_number":2662,"context_line":"    device a direct-physical port is being bound to. If provided, then the"},{"line_number":2663,"context_line":"    ``mac_address`` field of the port resource will return the MAC from the"},{"line_number":2664,"context_line":"    active binding."},{"line_number":2665,"context_line":"  in: body"},{"line_number":2666,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ce145f02_c2e75bf1","line":2663,"range":{"start_line":2663,"start_character":47,"end_line":2663,"end_character":58},"in_reply_to":"57884467_80c88666","updated":"2022-03-23 12:44:29.000000000","message":"good point. fixed.","commit_id":"70ff3f384aa19775b4866247b55580fe82781b94"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1ceda7e7dc577a4b4a9183380e49eb03aba2a038","unresolved":true,"context_lines":[{"line_number":2657,"context_line":"    The networking API does not define a specific format of this field."},{"line_number":2658,"context_line":"    The default is an empty dictionary."},{"line_number":2659,"context_line":"    If you update it with null then it is treated like {} in the response."},{"line_number":2660,"context_line":"    Since the port-mac-address-override extension the ``device_mac_address``"},{"line_number":2661,"context_line":"    field of the binding:profile can be used to provide the MAC address of the"},{"line_number":2662,"context_line":"    physical device a direct-physical port is being bound to. If provided, then"},{"line_number":2663,"context_line":"    the ``mac_address`` field of the port resource will be updated to the MAC"},{"line_number":2664,"context_line":"    from the active binding."},{"line_number":2665,"context_line":"  in: body"},{"line_number":2666,"context_line":"  required: false"},{"line_number":2667,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"383bb8b9_afb81824","line":2664,"range":{"start_line":2660,"start_character":0,"end_line":2664,"end_character":28},"updated":"2022-03-24 12:25:36.000000000","message":"+1","commit_id":"b5f0a2642794a3855097bb1a5221076849ab675f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"082a4b9abfd56f41035b2dffa7502fa8b0d409c1","unresolved":true,"context_lines":[{"line_number":2661,"context_line":"    field of the binding:profile can be used to provide the MAC address of the"},{"line_number":2662,"context_line":"    physical device a direct-physical port is being bound to. If provided, then"},{"line_number":2663,"context_line":"    the ``mac_address`` field of the port resource will be updated to the MAC"},{"line_number":2664,"context_line":"    from the active binding."},{"line_number":2665,"context_line":"  in: body"},{"line_number":2666,"context_line":"  required: false"},{"line_number":2667,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c08a97f0_7c526397","line":2664,"updated":"2022-03-24 12:56:00.000000000","message":"Maybe this piece is also relevant here:\n\n\"\"\"\nAlso when the port is being unbound or the MAC address is removed from\nthe active binding profile then neutron resets the mac_address field of\nport to a generated MAC to avoid duplicated MAC issues when another port\nis being bound to the same physical device.\n\"\"\"","commit_id":"b5f0a2642794a3855097bb1a5221076849ab675f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0e43c24cefe47f4df89ec71508929967397f539a","unresolved":true,"context_lines":[{"line_number":2661,"context_line":"    field of the binding:profile can be used to provide the MAC address of the"},{"line_number":2662,"context_line":"    physical device a direct-physical port is being bound to. If provided, then"},{"line_number":2663,"context_line":"    the ``mac_address`` field of the port resource will be updated to the MAC"},{"line_number":2664,"context_line":"    from the active binding."},{"line_number":2665,"context_line":"  in: body"},{"line_number":2666,"context_line":"  required: false"},{"line_number":2667,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ba8453c_b8828ab2","line":2664,"in_reply_to":"c08a97f0_7c526397","updated":"2022-03-25 15:46:43.000000000","message":"IMO that additional info which Bence proposed would be good too. But can be added as follow-up patch too :)","commit_id":"b5f0a2642794a3855097bb1a5221076849ab675f"}]}