)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"ee106f7ac6e252cf0b3053a28765a49dd4bdc36a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"988a2d69_b7303122","updated":"2022-03-08 05:47:24.000000000","message":"Other problems should have caused zuul -1, I have submited fix patch: https://review.opendev.org/c/openstack/neutron-lib/+/832484","commit_id":"3467868eb4cf201dc78ff6203e0ba3d1a7e7f93a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"485be3c5797acf07d75f69ebff6dd6b4951e7a9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7c52300a_b74003e8","updated":"2022-03-15 14:49:50.000000000","message":"Everything seems to be fine. I marked the resolved comments as resolved, to clean and facilitate others reviewers.","commit_id":"1dde6c24b777a86eb1a562a4ee2ca5019ac1e08a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"256fbb5a1bd42cb7ef7f1ed482c1cf45bf87a4b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1b3af743_1d3ff53f","updated":"2022-03-15 17:15:53.000000000","message":"recheck","commit_id":"1dde6c24b777a86eb1a562a4ee2ca5019ac1e08a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"ae2d1e0e420168cd8974f144a58fc2755ba56627","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8b7b6756_68b607b9","updated":"2022-03-15 20:22:27.000000000","message":"recheck","commit_id":"1dde6c24b777a86eb1a562a4ee2ca5019ac1e08a"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"7262485255d4bd367475424f0b50590fb97a40c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8d787d90_51e5709e","updated":"2022-03-16 02:21:09.000000000","message":"recheck","commit_id":"1dde6c24b777a86eb1a562a4ee2ca5019ac1e08a"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"5f2f764d96ba26e259a08b2961037508ebd5b0ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"93d699a7_f6ce22f7","updated":"2022-03-15 23:43:20.000000000","message":"recheck","commit_id":"1dde6c24b777a86eb1a562a4ee2ca5019ac1e08a"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"402066c3a64e091356da24a4e2a12f190eabf6fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"966f1271_c2f54b7b","updated":"2022-03-14 22:26:34.000000000","message":"recheck","commit_id":"1dde6c24b777a86eb1a562a4ee2ca5019ac1e08a"}],"neutron_lib/api/validators/__init__.py":[{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"66746e82ecbfdee95812a094b11c605b6adb6eda","unresolved":true,"context_lines":[{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"    :param data: The data to validate"},{"line_number":1041,"context_line":"    :param valid_values: valid port range, default is [0, 65535]"},{"line_number":1042,"context_line":"    :returns: None if data is an int between 0 and 65535, or two ints between 0"},{"line_number":1043,"context_line":"        and 65535 with a colon between them, otherwise a human readable message"},{"line_number":1044,"context_line":"        as to why data is invalid."},{"line_number":1045,"context_line":"    \"\"\""},{"line_number":1046,"context_line":"    if data is None:"},{"line_number":1047,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":3,"id":"38d2df5f_7c13753b","line":1044,"range":{"start_line":1042,"start_character":4,"end_line":1044,"end_character":34},"updated":"2022-03-09 01:27:44.000000000","message":"here need be updated.","commit_id":"d11460939f7ad20c1f44749c5c5a5f076bbd41fc"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"485be3c5797acf07d75f69ebff6dd6b4951e7a9f","unresolved":false,"context_lines":[{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"    :param data: The data to validate"},{"line_number":1041,"context_line":"    :param valid_values: valid port range, default is [0, 65535]"},{"line_number":1042,"context_line":"    :returns: None if data is an int between 0 and 65535, or two ints between 0"},{"line_number":1043,"context_line":"        and 65535 with a colon between them, otherwise a human readable message"},{"line_number":1044,"context_line":"        as to why data is invalid."},{"line_number":1045,"context_line":"    \"\"\""},{"line_number":1046,"context_line":"    if data is None:"},{"line_number":1047,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":3,"id":"0449abb1_8b393575","line":1044,"range":{"start_line":1042,"start_character":4,"end_line":1044,"end_character":34},"in_reply_to":"38d2df5f_7c13753b","updated":"2022-03-15 14:49:50.000000000","message":"Done","commit_id":"d11460939f7ad20c1f44749c5c5a5f076bbd41fc"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"66746e82ecbfdee95812a094b11c605b6adb6eda","unresolved":true,"context_lines":[{"line_number":1066,"context_line":"        if max_value \u003c int(p) or int(p) \u003c min_value:"},{"line_number":1067,"context_line":"            msg \u003d _(\"Invalid port: %s, the port must be in the range \""},{"line_number":1068,"context_line":"                    \"[%s, %s]\") % (p, min_value, max_value)"},{"line_number":1069,"context_line":"            LOG.debug(msg)"},{"line_number":1070,"context_line":"            return msg"},{"line_number":1071,"context_line":"    if len(ports) \u003e 1 and int(ports[0]) \u003e int(ports[1]):"},{"line_number":1072,"context_line":"        msg \u003d _(\"First port in a port range must be lower than the second \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3dd48ff0_381a021c","line":1069,"range":{"start_line":1069,"start_character":12,"end_line":1069,"end_character":26},"updated":"2022-03-09 01:27:44.000000000","message":"according to [1] \"[N537] Don\u0027t translate logs.\", we shouldn\u0027t transfer it, but the whole file is in this style.\nif neutron core has no comments, please ignore it 😊\n\n[1] https://github.com/openstack/neutron-lib/blob/master/HACKING.rst","commit_id":"d11460939f7ad20c1f44749c5c5a5f076bbd41fc"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"485be3c5797acf07d75f69ebff6dd6b4951e7a9f","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"        if max_value \u003c int(p) or int(p) \u003c min_value:"},{"line_number":1067,"context_line":"            msg \u003d _(\"Invalid port: %s, the port must be in the range \""},{"line_number":1068,"context_line":"                    \"[%s, %s]\") % (p, min_value, max_value)"},{"line_number":1069,"context_line":"            LOG.debug(msg)"},{"line_number":1070,"context_line":"            return msg"},{"line_number":1071,"context_line":"    if len(ports) \u003e 1 and int(ports[0]) \u003e int(ports[1]):"},{"line_number":1072,"context_line":"        msg \u003d _(\"First port in a port range must be lower than the second \""}],"source_content_type":"text/x-python","patch_set":3,"id":"192b5778_fea14a7b","line":1069,"range":{"start_line":1069,"start_character":12,"end_line":1069,"end_character":26},"in_reply_to":"3dd48ff0_381a021c","updated":"2022-03-15 14:49:50.000000000","message":"Done","commit_id":"d11460939f7ad20c1f44749c5c5a5f076bbd41fc"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"4a951f9daa065c3018fda295c661fbd47dda276f","unresolved":true,"context_lines":[{"line_number":1068,"context_line":"            msg \u003d \"Invalid port: %s, the port must be in the range \" \\"},{"line_number":1069,"context_line":"                  \"[%s, %s]\" % (p, min_value, max_value)"},{"line_number":1070,"context_line":"            LOG.debug(msg)"},{"line_number":1071,"context_line":"            return msg"},{"line_number":1072,"context_line":"    if len(ports) \u003e 1 and int(ports[0]) \u003e int(ports[1]):"},{"line_number":1073,"context_line":"        msg \u003d _(\"First port in a port range must be lower than the second \""},{"line_number":1074,"context_line":"                \"port\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"8db5b2c8_f85edb6a","line":1071,"range":{"start_line":1071,"start_character":12,"end_line":1071,"end_character":22},"updated":"2022-03-14 00:32:37.000000000","message":"I mean, do not transfer the log msg, but the returned msg should be transfered because it will be returned to caller. you can try \"return _(msg)\"","commit_id":"24272da190ec5fbb694d603e1f51802ddcc0bc62"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"485be3c5797acf07d75f69ebff6dd6b4951e7a9f","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"            msg \u003d \"Invalid port: %s, the port must be in the range \" \\"},{"line_number":1069,"context_line":"                  \"[%s, %s]\" % (p, min_value, max_value)"},{"line_number":1070,"context_line":"            LOG.debug(msg)"},{"line_number":1071,"context_line":"            return msg"},{"line_number":1072,"context_line":"    if len(ports) \u003e 1 and int(ports[0]) \u003e int(ports[1]):"},{"line_number":1073,"context_line":"        msg \u003d _(\"First port in a port range must be lower than the second \""},{"line_number":1074,"context_line":"                \"port\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"4f40163a_7992ddde","line":1071,"range":{"start_line":1071,"start_character":12,"end_line":1071,"end_character":22},"in_reply_to":"62d07b49_a2bab072","updated":"2022-03-15 14:49:50.000000000","message":"Done","commit_id":"24272da190ec5fbb694d603e1f51802ddcc0bc62"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"faf032d00f7ffd093850e5d70dfcccfd98ea209f","unresolved":true,"context_lines":[{"line_number":1068,"context_line":"            msg \u003d \"Invalid port: %s, the port must be in the range \" \\"},{"line_number":1069,"context_line":"                  \"[%s, %s]\" % (p, min_value, max_value)"},{"line_number":1070,"context_line":"            LOG.debug(msg)"},{"line_number":1071,"context_line":"            return msg"},{"line_number":1072,"context_line":"    if len(ports) \u003e 1 and int(ports[0]) \u003e int(ports[1]):"},{"line_number":1073,"context_line":"        msg \u003d _(\"First port in a port range must be lower than the second \""},{"line_number":1074,"context_line":"                \"port\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"62d07b49_a2bab072","line":1071,"range":{"start_line":1071,"start_character":12,"end_line":1071,"end_character":22},"in_reply_to":"8db5b2c8_f85edb6a","updated":"2022-03-14 11:44:33.000000000","message":"Oh, sorry, I got it 👍, thanks","commit_id":"24272da190ec5fbb694d603e1f51802ddcc0bc62"}]}
