)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9edce31c730613f74682ba47cd2215cd1c1b020c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65eab63d_195cfd45","updated":"2022-05-31 13:11:56.000000000","message":"Waiting for the CI, but code looks ok and comments are addressed","commit_id":"ad7a5ba0a03fb607b88f76493f3bfb158d5fc9b0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8adc31b4d8c9dfeaae82bcd6d557ba82eb9e9162","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2bd74dfb_4aa98e9f","updated":"2022-06-02 06:15:13.000000000","message":"Despite I don\u0027t like where those new constants are located.","commit_id":"231067cabadb91eb40e44202b4f55785d5c7afe1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5d154d5b21ab888cc2a85561d53d5b71a0b5ba3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a69f9195_b4f64435","updated":"2022-06-02 11:37:13.000000000","message":"thanks","commit_id":"231067cabadb91eb40e44202b4f55785d5c7afe1"}],"neutron_lib/agent/linux/openvswitch_firewall/constants.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f7546e15ea9b4b5e06b1920d2a0760c32bd75686","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"REG_INGRESS_BW_LIMIT \u003d 3"},{"line_number":18,"context_line":"REG_MIN_BW \u003d 4"},{"line_number":19,"context_line":"REG_PORT \u003d 5"},{"line_number":20,"context_line":"REG_NET \u003d 6"},{"line_number":21,"context_line":"# for logging remote group rule"},{"line_number":22,"context_line":"REG_REMOTE_GROUP \u003d 7"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca2e910a_045e77fb","line":22,"range":{"start_line":17,"start_character":0,"end_line":22,"end_character":20},"updated":"2022-04-27 15:03:46.000000000","message":"Big +1 for this","commit_id":"96a27c32ab59792930c996d8305d210663523d20"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"de9fd05861f9716837b936a8be4b92462669b2bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"779135a5_5a71b049","updated":"2022-05-31 13:34:58.000000000","message":"these are QoS related constants, why not agent/linux/flows/qos_constants.py or some other module name?","commit_id":"ad7a5ba0a03fb607b88f76493f3bfb158d5fc9b0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffc6fa9e1071f8f6d6953fda9eec44e8f4a36e30","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa2c12b0_aa8e7753","in_reply_to":"779135a5_5a71b049","updated":"2022-06-01 20:17:09.000000000","message":"Not all of those constants are really related to the QoS and I wanted to keep all of them in one place as all are related to the used registries in the OF rules.\n\nBut You\u0027re right that it also isn\u0027t related to the openvswitch fw driver directly so I moved it to different place now.","commit_id":"ad7a5ba0a03fb607b88f76493f3bfb158d5fc9b0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5070fd89a2a71b5e0f5b48c6315a4e8822545d8d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4759aa42_b157edf7","in_reply_to":"936251e3_0d83f9ed","updated":"2022-06-02 07:36:36.000000000","message":"Actually some of those constants were used by ovs firewall only but some were used by QoS driver. And IMO registry numbers are more related to the ovs in general then to ovs firewall, so as we want to keep all used registries in same place I think that it shouldn\u0027t be coupled with ovs firewall.","commit_id":"ad7a5ba0a03fb607b88f76493f3bfb158d5fc9b0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8adc31b4d8c9dfeaae82bcd6d557ba82eb9e9162","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"936251e3_0d83f9ed","in_reply_to":"fa2c12b0_aa8e7753","updated":"2022-06-02 06:15:13.000000000","message":"I don\u0027t understand this change. Those constants where related to the ovs firewall only. PS2 was, IMO, correct.","commit_id":"ad7a5ba0a03fb607b88f76493f3bfb158d5fc9b0"}],"neutron_lib/agent/linux/openvswitch_firewall/utils.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f7546e15ea9b4b5e06b1920d2a0760c32bd75686","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def create_reg_numbers(flow_params):"},{"line_number":39,"context_line":"    \"\"\"Replace reg_(port|net) values with defined register numbers\"\"\""},{"line_number":40,"context_line":"    _replace_register(flow_params, constants.REG_PORT, \u0027reg_port\u0027)"},{"line_number":41,"context_line":"    _replace_register(flow_params, constants.REG_NET, \u0027reg_net\u0027)"},{"line_number":42,"context_line":"    _replace_register("},{"line_number":43,"context_line":"        flow_params, constants.REG_REMOTE_GROUP, \u0027reg_remote_group\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d890272_16ce22c8","line":40,"range":{"start_line":40,"start_character":56,"end_line":40,"end_character":64},"updated":"2022-04-27 15:03:46.000000000","message":"1) I would add a constant for those strings (e.g.: REG_PORT_STR, etc...)\n2) You also need to add REG_INGRESS_BW_LIMIT and REG_MIN_BW","commit_id":"96a27c32ab59792930c996d8305d210663523d20"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f9083122581b06415a837a9deade28b7061d2b8","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def create_reg_numbers(flow_params):"},{"line_number":39,"context_line":"    \"\"\"Replace reg_(port|net) values with defined register numbers\"\"\""},{"line_number":40,"context_line":"    _replace_register(flow_params, constants.REG_PORT, \u0027reg_port\u0027)"},{"line_number":41,"context_line":"    _replace_register(flow_params, constants.REG_NET, \u0027reg_net\u0027)"},{"line_number":42,"context_line":"    _replace_register("},{"line_number":43,"context_line":"        flow_params, constants.REG_REMOTE_GROUP, \u0027reg_remote_group\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"001b4736_f8aa7fe9","line":40,"range":{"start_line":40,"start_character":56,"end_line":40,"end_character":64},"in_reply_to":"9d890272_16ce22c8","updated":"2022-05-31 13:02:39.000000000","message":"Done","commit_id":"96a27c32ab59792930c996d8305d210663523d20"}]}