)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0c67f4ab51e798c2561558d7aa2cb4f275750733","unresolved":true,"context_lines":[{"line_number":12,"context_line":"this patch adds the port forwarding returned contents: \u0027id\u0027 and"},{"line_number":13,"context_line":"\u0027internal_port_id\u0027 when list floatingip."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Needed-By: https://review.opendev.org/c/openstack/neutron/+/840565"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I34aa6948fccc669fc729d032b540bd1aa0c17ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9336a9eb_2b9dc5c2","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":19},"updated":"2022-07-29 11:29:41.000000000","message":"Not needed, the neutron patch implements locally the extension. You can add this link as a reference but not with the \"Needed-By\" keyword.","commit_id":"4648617a05fa5b3928bdfd314d6d205fd88386a6"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"dafff8dfb13db2a130d7004b1519cba911550f8b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"this patch adds the port forwarding returned contents: \u0027id\u0027 and"},{"line_number":13,"context_line":"\u0027internal_port_id\u0027 when list floatingip."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Needed-By: https://review.opendev.org/c/openstack/neutron/+/840565"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I34aa6948fccc669fc729d032b540bd1aa0c17ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0e5e4983_6120868d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":19},"in_reply_to":"9336a9eb_2b9dc5c2","updated":"2022-08-01 01:01:49.000000000","message":"Done","commit_id":"4648617a05fa5b3928bdfd314d6d205fd88386a6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a97b08759616f7899bb4487986eb0b2f2aef35a8","unresolved":true,"context_lines":[{"line_number":10,"context_line":"call the update \u0027port forwarding\u0027 api, because we don\u0027t know the port"},{"line_number":11,"context_line":"forwarding id."},{"line_number":12,"context_line":"this patch adds the port forwarding returned contents: \u0027id\u0027 and"},{"line_number":13,"context_line":"\u0027internal_port_id\u0027 when list floatingip."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I34aa6948fccc669fc729d032b540bd1aa0c17ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"423302bf_31208f7d","line":13,"range":{"start_line":13,"start_character":1,"end_line":13,"end_character":17},"updated":"2022-08-01 07:00:08.000000000","message":"The bug does not mention this, can you please clarify why is this needed in a floating ip list output? to me it seems more an internal information.","commit_id":"0a4ea4a3bfc3c5d8a989af1650ef5bf9b9aaccbb"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"5b9bf0a542a977f7db1820b080190f714b048357","unresolved":false,"context_lines":[{"line_number":10,"context_line":"call the update \u0027port forwarding\u0027 api, because we don\u0027t know the port"},{"line_number":11,"context_line":"forwarding id."},{"line_number":12,"context_line":"this patch adds the port forwarding returned contents: \u0027id\u0027 and"},{"line_number":13,"context_line":"\u0027internal_port_id\u0027 when list floatingip."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I34aa6948fccc669fc729d032b540bd1aa0c17ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"0aaec402_4f52befa","line":13,"range":{"start_line":13,"start_character":1,"end_line":13,"end_character":17},"in_reply_to":"423302bf_31208f7d","updated":"2022-08-05 05:33:56.000000000","message":"Done","commit_id":"0a4ea4a3bfc3c5d8a989af1650ef5bf9b9aaccbb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a97b08759616f7899bb4487986eb0b2f2aef35a8","unresolved":true,"context_lines":[{"line_number":11,"context_line":"forwarding id."},{"line_number":12,"context_line":"this patch adds the port forwarding returned contents: \u0027id\u0027 and"},{"line_number":13,"context_line":"\u0027internal_port_id\u0027 when list floatingip."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I34aa6948fccc669fc729d032b540bd1aa0c17ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"0f34e60c_168e9a19","line":14,"updated":"2022-08-01 07:00:08.000000000","message":"please add bug ref here","commit_id":"0a4ea4a3bfc3c5d8a989af1650ef5bf9b9aaccbb"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"5b9bf0a542a977f7db1820b080190f714b048357","unresolved":false,"context_lines":[{"line_number":11,"context_line":"forwarding id."},{"line_number":12,"context_line":"this patch adds the port forwarding returned contents: \u0027id\u0027 and"},{"line_number":13,"context_line":"\u0027internal_port_id\u0027 when list floatingip."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I34aa6948fccc669fc729d032b540bd1aa0c17ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"98b2a446_180c510a","line":14,"in_reply_to":"0f34e60c_168e9a19","updated":"2022-08-05 05:33:56.000000000","message":"Done","commit_id":"0a4ea4a3bfc3c5d8a989af1650ef5bf9b9aaccbb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1e5f179cb7466b0fa71120b6b076a0a2323398a5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"this patch adds the port forwarding returned contents: \u0027id\u0027 and"},{"line_number":16,"context_line":"\u0027internal_port_id\u0027 when list floatingip."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-bug: #1971646"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I34aa6948fccc669fc729d032b540bd1aa0c17ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d125ce2b_b236028d","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":21},"updated":"2022-08-05 07:40:50.000000000","message":"Should be an RFE","commit_id":"17a6a1476e5b17501732600ed9b4b37c01918181"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a010c825ed3a320dfc8763d96792240a21e35ef4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"697f005d_7b556f17","updated":"2022-05-11 10:02:54.000000000","message":"Sorry, I don\u0027t understand this new API extension. The PF API is already exposing the internal port ID and the PF ID [1]. In [2] you are actually adding those values to the PF dict, but those values should have been there before.\n\nIn order to implement [2], you don\u0027t need this extension.\n\n\n[1]https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/floating_ip_port_forwarding.py\n[2]https://review.opendev.org/c/openstack/neutron/+/840565/6/neutron/services/portforwarding/pf_plugin.py#112\n","commit_id":"4648617a05fa5b3928bdfd314d6d205fd88386a6"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"5492162db8b179f7bb4e912efe80448a6b72da77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d31bc087_b7d1ebb2","in_reply_to":"697f005d_7b556f17","updated":"2022-05-12 00:42:38.000000000","message":"If we don\u0027t add an extension, we can\u0027t specify the return value of list floating IP in [3].\n\n[3] 1https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/840584","commit_id":"4648617a05fa5b3928bdfd314d6d205fd88386a6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0c67f4ab51e798c2561558d7aa2cb4f275750733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2af842c5_446f10bd","in_reply_to":"d31bc087_b7d1ebb2","updated":"2022-07-29 11:29:41.000000000","message":"Ok now I understand: you are extending the PF dictionary, contained in the FIP, with those two new fields.","commit_id":"4648617a05fa5b3928bdfd314d6d205fd88386a6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"56e55f9188afbf6ec85ca7a7d924164b3ee6c054","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"af68eae6_2e72cd6c","updated":"2022-08-04 10:57:53.000000000","message":"I think we can add this patch to the next n-lib release if you address Oleg\u0027s comments ASAP.","commit_id":"0a4ea4a3bfc3c5d8a989af1650ef5bf9b9aaccbb"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"5b9bf0a542a977f7db1820b080190f714b048357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"71d596c7_bd1d4e8d","updated":"2022-08-05 05:33:56.000000000","message":"recheck","commit_id":"17a6a1476e5b17501732600ed9b4b37c01918181"}],"neutron_lib/api/definitions/fip_pf_detail.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0c67f4ab51e798c2561558d7aa2cb4f275750733","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"NAME \u003d \u0027Floating IP port forwarding detail\u0027"},{"line_number":17,"context_line":"ALIAS \u003d \u0027fip-pf-detail\u0027"},{"line_number":18,"context_line":"DESCRIPTION \u003d ("},{"line_number":19,"context_line":"    \"Allow list floating ip return more port forwarding data, include\""},{"line_number":20,"context_line":"    \"\u0027id\u0027 and \u0027internal_port_id\u0027\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"8053280d_78d94e29","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":23},"updated":"2022-07-29 11:29:41.000000000","message":"We have two \"related\" extensions: \"floating-ip-port-forwarding-description\" and \"floating-ip-port-forwarding-port-ranges\".\n\nPlease use the string \"floating-ip-port-forwarding-detail\"","commit_id":"4648617a05fa5b3928bdfd314d6d205fd88386a6"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"dafff8dfb13db2a130d7004b1519cba911550f8b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"NAME \u003d \u0027Floating IP port forwarding detail\u0027"},{"line_number":17,"context_line":"ALIAS \u003d \u0027fip-pf-detail\u0027"},{"line_number":18,"context_line":"DESCRIPTION \u003d ("},{"line_number":19,"context_line":"    \"Allow list floating ip return more port forwarding data, include\""},{"line_number":20,"context_line":"    \"\u0027id\u0027 and \u0027internal_port_id\u0027\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"78ff2c39_6e309e84","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":23},"in_reply_to":"8053280d_78d94e29","updated":"2022-08-01 01:01:49.000000000","message":"Done","commit_id":"4648617a05fa5b3928bdfd314d6d205fd88386a6"}]}