)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"04bed84af41506812d03e6ef2035aadec44f2cff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Danylo Vodopianov \u003cdvo-plv@napatech.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-06 23:21:53 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new vif type linkvirt_ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DPDK datapath type added"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3b056d98_9bea107f","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":29},"updated":"2023-02-06 12:37:29.000000000","message":"this is not in sync with the code change, am I right?","commit_id":"56535943c32017847db2a2a5ed29267b5c7c655d"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"5236afe99321ccb09dc7ff327c788703e0e9e805","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Danylo Vodopianov \u003cdvo-plv@napatech.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-06 23:21:53 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new vif type linkvirt_ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DPDK datapath type added"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"887005af_f782bbb8","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":29},"in_reply_to":"3b056d98_9bea107f","updated":"2023-03-10 13:35:58.000000000","message":"yes, it was a mistake from the first iteration.","commit_id":"56535943c32017847db2a2a5ed29267b5c7c655d"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"9a51711f57e0ce46a6de3962798509fffff3d049","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Danylo Vodopianov \u003cdvo-plv@napatech.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-06 23:21:53 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new vif type linkvirt_ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DPDK datapath type added"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a98030a_24b87eac","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":29},"in_reply_to":"887005af_f782bbb8","updated":"2023-03-10 15:16:26.000000000","message":"Done","commit_id":"56535943c32017847db2a2a5ed29267b5c7c655d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8c03182736e485ecf59d8a35a32f55c620e3c120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a2021fd_e8c6ccac","updated":"2022-09-30 10:02:40.000000000","message":"And we should wait till the nova spec is accepted","commit_id":"551e9f91e6387426d48eaa942e2d3f39a1ef4cd3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2492b3344813c2e53f9f719de5385cf2c0cd64de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d275e8d9_7286ef45","updated":"2022-09-30 10:01:46.000000000","message":"Please extend the api-ref with the new vif type, and please add a release note also.\nPlease check https://review.opendev.org/c/openstack/neutron-lib/+/483530 which can be a good example for you","commit_id":"551e9f91e6387426d48eaa942e2d3f39a1ef4cd3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"359c1014b17bf4e929c611c557d0355a1b2f99ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5eb3cde4_75673328","updated":"2022-10-26 22:42:27.000000000","message":"i honestly dont see a need for this.\nmy prefernce woudl be to just add support for virtio-forwarder to ml2/ovs and ml2/ovn\n\nwe there does not look to be an napatech sepcific cod ein the os-vif plugin or neutron ml2 dirver.\n\nso even if virtio-forwarder is not fully supprot in upstream ovs-dpdk it seams like a lot less work and maintaince to supprot it directly in the ovs ml2 driver and ovs os-vif plug.\n\nthat is escially ture since the current napatech os-vif plug is inheriting form the in tree ovs os-vif pluging which is not something you are allowed to do.","commit_id":"551e9f91e6387426d48eaa942e2d3f39a1ef4cd3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"132fc972b94ea08436541f9ebf57ecbe170b745c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bdf8c03_29b27ec8","in_reply_to":"5eb3cde4_75673328","updated":"2022-11-02 11:38:07.000000000","message":"Agree with Sean. You can use VIF_TYPE_OVS and VNIC_VIRTIO_FORWARDER.\n\nIs there any specific code you need for this? So you have a POC for ML2/OVS or ML2/OVN?\n\n[1]https://review.opendev.org/q/topic:netronome-smartnic-enablement","commit_id":"551e9f91e6387426d48eaa942e2d3f39a1ef4cd3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6bac7882eae6dfd6fe128f3fb65840c33cbaa301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"515b2688_bee04668","updated":"2023-02-06 12:32:17.000000000","message":"Could you please fix the pep8 error?","commit_id":"56535943c32017847db2a2a5ed29267b5c7c655d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b9082a40311399ed1a9bb710fb3cb09347708c8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"003e272d_f20b935b","updated":"2023-01-17 09:46:47.000000000","message":"Please check the pep8 problem and fix it","commit_id":"56535943c32017847db2a2a5ed29267b5c7c655d"}],"neutron_lib/plugins/ml2/ovs_constants.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a4e4dc027cc3c36853e3bce89e7e48b913dfbe15","unresolved":true,"context_lines":[{"line_number":214,"context_line":"OVS_DATAPATH_NETDEV \u003d \u0027netdev\u0027"},{"line_number":215,"context_line":"OVS_DPDK_VHOST_USER \u003d \u0027dpdkvhostuser\u0027"},{"line_number":216,"context_line":"OVS_DPDK_VHOST_USER_CLIENT \u003d \u0027dpdkvhostuserclient\u0027"},{"line_number":217,"context_line":"OVS_DPDK_USER \u003d \u0027dpdk\u0027"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"OVS_DPDK_PORT_TYPES \u003d [OVS_DPDK_VHOST_USER,"},{"line_number":220,"context_line":"                       OVS_DPDK_VHOST_USER_CLIENT,"}],"source_content_type":"text/x-python","patch_set":6,"id":"88d0cf0b_12d33028","line":217,"range":{"start_line":217,"start_character":0,"end_line":217,"end_character":13},"updated":"2023-05-03 08:14:46.000000000","message":"Why DPDK_USER? The constant used is just \"dpdk\"","commit_id":"321cb4f27fc672e2586a346a82e2e87d6aa5f51e"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"603d14e7c96b2071d7e955154d6972e4c2b5ef52","unresolved":false,"context_lines":[{"line_number":214,"context_line":"OVS_DATAPATH_NETDEV \u003d \u0027netdev\u0027"},{"line_number":215,"context_line":"OVS_DPDK_VHOST_USER \u003d \u0027dpdkvhostuser\u0027"},{"line_number":216,"context_line":"OVS_DPDK_VHOST_USER_CLIENT \u003d \u0027dpdkvhostuserclient\u0027"},{"line_number":217,"context_line":"OVS_DPDK_USER \u003d \u0027dpdk\u0027"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"OVS_DPDK_PORT_TYPES \u003d [OVS_DPDK_VHOST_USER,"},{"line_number":220,"context_line":"                       OVS_DPDK_VHOST_USER_CLIENT,"}],"source_content_type":"text/x-python","patch_set":6,"id":"00d4969e_39cbe95a","line":217,"range":{"start_line":217,"start_character":0,"end_line":217,"end_character":13},"in_reply_to":"88d0cf0b_12d33028","updated":"2023-05-04 14:33:48.000000000","message":"Done","commit_id":"321cb4f27fc672e2586a346a82e2e87d6aa5f51e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a4e4dc027cc3c36853e3bce89e7e48b913dfbe15","unresolved":true,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"OVS_DPDK_PORT_TYPES \u003d [OVS_DPDK_VHOST_USER,"},{"line_number":220,"context_line":"                       OVS_DPDK_VHOST_USER_CLIENT,"},{"line_number":221,"context_line":"                       OVS_DPDK_USER]"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"# default ovs vhost-user socket location"},{"line_number":224,"context_line":"VHOST_USER_SOCKET_DIR \u003d \u0027/var/run/openvswitch\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"46f6e06a_f3bf0d5d","line":221,"range":{"start_line":221,"start_character":23,"end_line":221,"end_character":36},"updated":"2023-05-03 08:14:46.000000000","message":"In case of having new DPDK types, please add a comma and close the parenthesis in the next line. That will keep the git history if a new item is added.","commit_id":"321cb4f27fc672e2586a346a82e2e87d6aa5f51e"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"603d14e7c96b2071d7e955154d6972e4c2b5ef52","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"OVS_DPDK_PORT_TYPES \u003d [OVS_DPDK_VHOST_USER,"},{"line_number":220,"context_line":"                       OVS_DPDK_VHOST_USER_CLIENT,"},{"line_number":221,"context_line":"                       OVS_DPDK_USER]"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"# default ovs vhost-user socket location"},{"line_number":224,"context_line":"VHOST_USER_SOCKET_DIR \u003d \u0027/var/run/openvswitch\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5323d947_701f84af","line":221,"range":{"start_line":221,"start_character":23,"end_line":221,"end_character":36},"in_reply_to":"46f6e06a_f3bf0d5d","updated":"2023-05-04 14:33:48.000000000","message":"Done","commit_id":"321cb4f27fc672e2586a346a82e2e87d6aa5f51e"}]}