)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cf7142f0d87692c5dfa019e205c651edcb10069","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Add enforce_policy\u003dTrue on port for device_id parameter to build a new"},{"line_number":10,"context_line":"policy. The target is to authorize only admin to use this parameter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"bug #1986969"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3d1c0ec074a5475091ee89f4f177b107fa61b264"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3c3f78db_486feb88","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":3},"updated":"2022-10-27 11:32:09.000000000","message":"Please, read [1]. This should be:\nRelated-Bug: #1986969\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"3e26094e700cd0f679ec0caac6d89f99d46b0ab9"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"b599f08c464a0c6b896e875b4aafc81432e74541","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add enforce_policy\u003dTrue on port for device_id parameter to build a new"},{"line_number":10,"context_line":"policy. The target is to authorize only admin to use this parameter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"bug #1986969"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3d1c0ec074a5475091ee89f4f177b107fa61b264"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a409012b_48b98e93","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":3},"in_reply_to":"3c3f78db_486feb88","updated":"2022-11-03 06:47:56.000000000","message":"Done","commit_id":"3e26094e700cd0f679ec0caac6d89f99d46b0ab9"}],"neutron_lib/api/definitions/port.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"666730496389d36bd81e9488b9aff2d2fd80f415","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        \u0027device_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":74,"context_line":"                      \u0027validate\u0027: {"},{"line_number":75,"context_line":"                          \u0027type:string\u0027: db_const.DEVICE_ID_FIELD_SIZE},"},{"line_number":76,"context_line":"                      \u0027default\u0027: \u0027\u0027, \u0027enforce_policy\u0027: True,"},{"line_number":77,"context_line":"                      \u0027is_filter\u0027: True,"},{"line_number":78,"context_line":"                      \u0027is_sort_key\u0027: True,"},{"line_number":79,"context_line":"                      \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":1,"id":"15fea2d8_54cdc574","line":76,"range":{"start_line":76,"start_character":37,"end_line":76,"end_character":60},"updated":"2022-10-13 13:34:56.000000000","message":"1) There is no policy for port.device_id [1]\n2) In order to allow a change like this, we maybe should create a new extension (this could be decided by other reviewers)\n3) Why don\u0027t you solve the issue in the deployment tool you reported (Terraform)?\n4) nit: if accepted, add this parameter in a new line\n\n[1]https://github.com/openstack/neutron/blob/master/neutron/conf/policies/port.py","commit_id":"31706fb2dec39139def410101960b0187170c27a"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"4f211bddfb20110d5e2c1212b0e3aef766686734","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        \u0027device_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":74,"context_line":"                      \u0027validate\u0027: {"},{"line_number":75,"context_line":"                          \u0027type:string\u0027: db_const.DEVICE_ID_FIELD_SIZE},"},{"line_number":76,"context_line":"                      \u0027default\u0027: \u0027\u0027, \u0027enforce_policy\u0027: True,"},{"line_number":77,"context_line":"                      \u0027is_filter\u0027: True,"},{"line_number":78,"context_line":"                      \u0027is_sort_key\u0027: True,"},{"line_number":79,"context_line":"                      \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a47d1fe_9e91227b","line":76,"range":{"start_line":76,"start_character":37,"end_line":76,"end_character":60},"in_reply_to":"15fea2d8_54cdc574","updated":"2022-10-14 09:31:51.000000000","message":"1) yes it\u0027s in progress: https://review.opendev.org/c/openstack/neutron/+/861169\n2) do you need something on my side?\n3) yes it\u0027s planned to do it also in Terraform but I want to lock this action for everybody to have consistency.\n4) I agree with you","commit_id":"31706fb2dec39139def410101960b0187170c27a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"931b1133e1437d68a355d3a16c1c2d2eadb246d9","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        \u0027device_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":74,"context_line":"                      \u0027validate\u0027: {"},{"line_number":75,"context_line":"                          \u0027type:string\u0027: db_const.DEVICE_ID_FIELD_SIZE},"},{"line_number":76,"context_line":"                      \u0027default\u0027: \u0027\u0027, \u0027enforce_policy\u0027: True,"},{"line_number":77,"context_line":"                      \u0027is_filter\u0027: True,"},{"line_number":78,"context_line":"                      \u0027is_sort_key\u0027: True,"},{"line_number":79,"context_line":"                      \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc21b58e_962bbd52","line":76,"range":{"start_line":76,"start_character":37,"end_line":76,"end_character":60},"in_reply_to":"7a47d1fe_9e91227b","updated":"2022-10-17 09:16:23.000000000","message":"I\u0027m not really sure if we need API extension for that. My feeling is that release note should be enough as we are \"just\" changing who can do the operation by default","commit_id":"31706fb2dec39139def410101960b0187170c27a"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"7246fcbd50c8f44e141311a8243055a15a370700","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \u0027device_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":74,"context_line":"                      \u0027validate\u0027: {"},{"line_number":75,"context_line":"                          \u0027type:string\u0027: db_const.DEVICE_ID_FIELD_SIZE},"},{"line_number":76,"context_line":"                      \u0027default\u0027: \u0027\u0027, \u0027enforce_policy\u0027: True,"},{"line_number":77,"context_line":"                      \u0027is_filter\u0027: True,"},{"line_number":78,"context_line":"                      \u0027is_sort_key\u0027: True,"},{"line_number":79,"context_line":"                      \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":1,"id":"f550f124_e4e22c11","line":76,"range":{"start_line":76,"start_character":37,"end_line":76,"end_character":60},"in_reply_to":"dc21b58e_962bbd52","updated":"2022-10-20 08:42:23.000000000","message":"Done","commit_id":"31706fb2dec39139def410101960b0187170c27a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cf7142f0d87692c5dfa019e205c651edcb10069","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \u0027device_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":74,"context_line":"                      \u0027validate\u0027: {"},{"line_number":75,"context_line":"                          \u0027type:string\u0027: db_const.DEVICE_ID_FIELD_SIZE},"},{"line_number":76,"context_line":"                      \u0027default\u0027: \u0027\u0027, \u0027enforce_policy\u0027: True,"},{"line_number":77,"context_line":"                      \u0027is_filter\u0027: True,"},{"line_number":78,"context_line":"                      \u0027is_sort_key\u0027: True,"},{"line_number":79,"context_line":"                      \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":1,"id":"18c42041_4f52dd32","line":76,"range":{"start_line":76,"start_character":37,"end_line":76,"end_character":60},"in_reply_to":"f550f124_e4e22c11","updated":"2022-10-27 11:32:09.000000000","message":"Perfect, nice to see the Neutron patch. And as I see, other reviewers support the idea of not creating a new extension (we have too many of them).","commit_id":"31706fb2dec39139def410101960b0187170c27a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"09ef42884e114279cb6fcd73d706549a71a7731d","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                         \u0027validate\u0027: {"},{"line_number":83,"context_line":"                             \u0027type:string\u0027: db_const.DEVICE_OWNER_FIELD_SIZE},"},{"line_number":84,"context_line":"                         \u0027default\u0027: \u0027\u0027,"},{"line_number":85,"context_line":"                         \u0027enforce_policy\u0027: True,"},{"line_number":86,"context_line":"                         \u0027is_filter\u0027: True,"},{"line_number":87,"context_line":"                         \u0027is_sort_key\u0027: True,"},{"line_number":88,"context_line":"                         \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":2,"id":"397a8a35_c8844513","line":85,"range":{"start_line":85,"start_character":25,"end_line":85,"end_character":48},"updated":"2022-10-21 08:12:09.000000000","message":"yeah looks better, but messes up git history, so, not sure to keep it","commit_id":"cdce51fdc4a89ab0cd81f5da0d92907d184b92d0"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"b92cf9328899dd1bc6f01b7ee09452b2ef3adf35","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                         \u0027validate\u0027: {"},{"line_number":83,"context_line":"                             \u0027type:string\u0027: db_const.DEVICE_OWNER_FIELD_SIZE},"},{"line_number":84,"context_line":"                         \u0027default\u0027: \u0027\u0027,"},{"line_number":85,"context_line":"                         \u0027enforce_policy\u0027: True,"},{"line_number":86,"context_line":"                         \u0027is_filter\u0027: True,"},{"line_number":87,"context_line":"                         \u0027is_sort_key\u0027: True,"},{"line_number":88,"context_line":"                         \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":2,"id":"c4411394_8a30dbcf","line":85,"range":{"start_line":85,"start_character":25,"end_line":85,"end_character":48},"in_reply_to":"10a4fd93_44df3546","updated":"2022-10-27 05:46:32.000000000","message":"Done","commit_id":"cdce51fdc4a89ab0cd81f5da0d92907d184b92d0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f2eb6380c6d7ac26d71531432bd7a30e3eb47fb4","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                         \u0027validate\u0027: {"},{"line_number":83,"context_line":"                             \u0027type:string\u0027: db_const.DEVICE_OWNER_FIELD_SIZE},"},{"line_number":84,"context_line":"                         \u0027default\u0027: \u0027\u0027,"},{"line_number":85,"context_line":"                         \u0027enforce_policy\u0027: True,"},{"line_number":86,"context_line":"                         \u0027is_filter\u0027: True,"},{"line_number":87,"context_line":"                         \u0027is_sort_key\u0027: True,"},{"line_number":88,"context_line":"                         \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":2,"id":"10a4fd93_44df3546","line":85,"range":{"start_line":85,"start_character":25,"end_line":85,"end_character":48},"in_reply_to":"397a8a35_c8844513","updated":"2022-10-26 12:44:14.000000000","message":"I agree with Lajos here. I would vote to not do it in this patch","commit_id":"cdce51fdc4a89ab0cd81f5da0d92907d184b92d0"}]}