)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"00f340efde520fc4911d0013abb43fab2743c212","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"257e0629_4cc5c3f9","updated":"2022-11-25 14:26:27.000000000","message":"Ok, now pep8 and UTs are passing. This version won\u0027t affect any upgrade.\n\nGood catch Slawek!","commit_id":"2ded6ed3ce93983b7c852a873f1808fe13931eba"}],"neutron_lib/plugins/utils.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e30a209d98bbf004b1ee016f848ea961827c1a37","unresolved":true,"context_lines":[{"line_number":286,"context_line":"                           \"given length for an interface name.\"))"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    namelen \u003d max_len - len(prefix) - INTERFACE_HASH_LEN"},{"line_number":289,"context_line":"    hashed_name \u003d hashlib.sha256(encodeutils.to_utf8(name))"},{"line_number":290,"context_line":"    new_name \u003d (\u0027%(prefix)s%(truncated)s%(hash)s\u0027 %"},{"line_number":291,"context_line":"                {\u0027prefix\u0027: prefix, \u0027truncated\u0027: name[0:namelen],"},{"line_number":292,"context_line":"                 \u0027hash\u0027: hashed_name.hexdigest()[0:INTERFACE_HASH_LEN]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac2e66b_3a5f340c","line":289,"range":{"start_line":289,"start_character":26,"end_line":289,"end_character":32},"updated":"2022-11-25 08:30:01.000000000","message":"Quicker again than me, I wanted to it this morning :-)","commit_id":"2a31ab6fe40ff36bd6b00d21e9a3dd98f9e11bde"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fd09dd69abf63e050e537d83ca748183b33a5b10","unresolved":true,"context_lines":[{"line_number":286,"context_line":"                           \"given length for an interface name.\"))"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    namelen \u003d max_len - len(prefix) - INTERFACE_HASH_LEN"},{"line_number":289,"context_line":"    hashed_name \u003d hashlib.sha256(encodeutils.to_utf8(name))"},{"line_number":290,"context_line":"    new_name \u003d (\u0027%(prefix)s%(truncated)s%(hash)s\u0027 %"},{"line_number":291,"context_line":"                {\u0027prefix\u0027: prefix, \u0027truncated\u0027: name[0:namelen],"},{"line_number":292,"context_line":"                 \u0027hash\u0027: hashed_name.hexdigest()[0:INTERFACE_HASH_LEN]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3801de33_f94c65dd","line":289,"updated":"2022-11-25 14:03:47.000000000","message":"did You check how it will work after e.g. restart of the agent? This will change names of some interfaces like patch ports or some physical interfaces in linuxbridge agent. Are we sure that it won\u0027t impact existing deployments at all?","commit_id":"2a31ab6fe40ff36bd6b00d21e9a3dd98f9e11bde"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"702600859f352c3cfebcadade4ebeba13effe611","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                           \"given length for an interface name.\"))"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    namelen \u003d max_len - len(prefix) - INTERFACE_HASH_LEN"},{"line_number":289,"context_line":"    hashed_name \u003d hashlib.sha256(encodeutils.to_utf8(name))"},{"line_number":290,"context_line":"    new_name \u003d (\u0027%(prefix)s%(truncated)s%(hash)s\u0027 %"},{"line_number":291,"context_line":"                {\u0027prefix\u0027: prefix, \u0027truncated\u0027: name[0:namelen],"},{"line_number":292,"context_line":"                 \u0027hash\u0027: hashed_name.hexdigest()[0:INTERFACE_HASH_LEN]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c75cdd6_94d5a2da","line":289,"in_reply_to":"3801de33_f94c65dd","updated":"2022-11-25 14:08:34.000000000","message":"Right, we can\u0027t make this change freely. We should consider the upgrades. Instead of this, I\u0027ll skip the pylint error. We don\u0027t mind here if the sha1 is unsecure, we are using it just as a randomiser method.","commit_id":"2a31ab6fe40ff36bd6b00d21e9a3dd98f9e11bde"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"121e133f24b0c1a98906b6166827ab5b76a0fc0b","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                           \"given length for an interface name.\"))"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    namelen \u003d max_len - len(prefix) - INTERFACE_HASH_LEN"},{"line_number":289,"context_line":"    hashed_name \u003d hashlib.sha256(encodeutils.to_utf8(name))"},{"line_number":290,"context_line":"    new_name \u003d (\u0027%(prefix)s%(truncated)s%(hash)s\u0027 %"},{"line_number":291,"context_line":"                {\u0027prefix\u0027: prefix, \u0027truncated\u0027: name[0:namelen],"},{"line_number":292,"context_line":"                 \u0027hash\u0027: hashed_name.hexdigest()[0:INTERFACE_HASH_LEN]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"83dad9be_bcb6e5fc","line":289,"range":{"start_line":289,"start_character":26,"end_line":289,"end_character":32},"in_reply_to":"7ac2e66b_3a5f340c","updated":"2022-11-25 09:14:53.000000000","message":"hehehe I saw it yesterday when pushing https://review.opendev.org/c/openstack/neutron-lib/+/865517/","commit_id":"2a31ab6fe40ff36bd6b00d21e9a3dd98f9e11bde"}]}