)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3c6e2df172c70e7c4f3b5fef3d8bc31f6acdfb26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"508bcadd_7620a9b1","updated":"2023-05-23 13:21:48.000000000","message":"Sorry, that was my bad.","commit_id":"a2d4be7f482bcc8d9d08d40b1a8a172427b12961"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f3dfe72083405aefb47367c56df2647f333ad249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"185322fa_7c3cd19c","updated":"2023-05-23 17:21:18.000000000","message":"LGTM","commit_id":"aa3fb1df3a697d0090c53d4e42b0f26abe25ed1b"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"7a3bfbc5c80f8c46d9ffe903bc94d878f77d5a1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3eb0d745_7624d715","updated":"2023-05-25 12:19:48.000000000","message":"typo fix","commit_id":"c9d8839ba0e4a4e2936ea7679f306c8714682c8d"}],"neutron_lib/exceptions/__init__.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3c6e2df172c70e7c4f3b5fef3d8bc31f6acdfb26","unresolved":true,"context_lines":[{"line_number":246,"context_line":"                \"device %(device_id)s.\")"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class FipAttached(InUse):"},{"line_number":250,"context_line":"    \"\"\"An operational error indicating the port still has FIP attached."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    A specialization of the InUse exception indicating an operation failed on"}],"source_content_type":"text/x-python","patch_set":2,"id":"ca4639df_5f5b65d4","line":249,"range":{"start_line":249,"start_character":6,"end_line":249,"end_character":17},"updated":"2023-05-23 13:21:48.000000000","message":"Sorry, my bad when we talked via IRC. The process to link a FIP to a port is not called attachment but association [1]. This should be called ``FipAssociated``\n\n[1]https://docs.openstack.org/newton/user-guide/cli-manage-ip-addresses.html","commit_id":"a2d4be7f482bcc8d9d08d40b1a8a172427b12961"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"67833f247e3c843fa9d464527a500be17f921a7e","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                \"device %(device_id)s.\")"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class FipAttached(InUse):"},{"line_number":250,"context_line":"    \"\"\"An operational error indicating the port still has FIP attached."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    A specialization of the InUse exception indicating an operation failed on"}],"source_content_type":"text/x-python","patch_set":2,"id":"73b6a244_5be07e26","line":249,"range":{"start_line":249,"start_character":6,"end_line":249,"end_character":17},"in_reply_to":"ca4639df_5f5b65d4","updated":"2023-05-25 12:19:59.000000000","message":"Done","commit_id":"a2d4be7f482bcc8d9d08d40b1a8a172427b12961"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"26c9c507350fcb21cb2fa65080f06f89e55fe0b1","unresolved":true,"context_lines":[{"line_number":246,"context_line":"                \"device %(device_id)s.\")"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class FipAssociated(InUse):"},{"line_number":250,"context_line":"    \"\"\"An operational error indicates that port still has an associated FIP."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    A specialization of the InUse exception indicating an operation failed on"}],"source_content_type":"text/x-python","patch_set":5,"id":"f9727d79_aa1d721f","line":249,"updated":"2023-05-26 07:19:44.000000000","message":"L3-specific exceptions (at least new exceptions related to L3) are defined in neutron_lib/exceptions/l3.py. Could you move it to exceptions/l3.py?","commit_id":"c9d8839ba0e4a4e2936ea7679f306c8714682c8d"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"1b2d06dcb10f716a651ca77317f7583e9dc07e4d","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                \"device %(device_id)s.\")"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class FipAssociated(InUse):"},{"line_number":250,"context_line":"    \"\"\"An operational error indicates that port still has an associated FIP."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    A specialization of the InUse exception indicating an operation failed on"}],"source_content_type":"text/x-python","patch_set":5,"id":"21b461f7_30f29d28","line":249,"in_reply_to":"f9727d79_aa1d721f","updated":"2023-05-26 08:10:35.000000000","message":"Done","commit_id":"c9d8839ba0e4a4e2936ea7679f306c8714682c8d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"26c9c507350fcb21cb2fa65080f06f89e55fe0b1","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    :param port_id: The UUID of the port requested."},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s \""},{"line_number":258,"context_line":"                \"because port still has associated floating IP.\")"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"0e4138e1_746d6961","line":257,"range":{"start_line":257,"start_character":36,"end_line":257,"end_character":45},"updated":"2023-05-26 07:19:44.000000000","message":"nit: operation -\u003e the operation","commit_id":"c9d8839ba0e4a4e2936ea7679f306c8714682c8d"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"1b2d06dcb10f716a651ca77317f7583e9dc07e4d","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    :param port_id: The UUID of the port requested."},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s \""},{"line_number":258,"context_line":"                \"because port still has associated floating IP.\")"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ce1a00b3_89758e0b","line":257,"range":{"start_line":257,"start_character":36,"end_line":257,"end_character":45},"in_reply_to":"0e4138e1_746d6961","updated":"2023-05-26 08:10:35.000000000","message":"Done","commit_id":"c9d8839ba0e4a4e2936ea7679f306c8714682c8d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"26c9c507350fcb21cb2fa65080f06f89e55fe0b1","unresolved":true,"context_lines":[{"line_number":255,"context_line":"    :param port_id: The UUID of the port requested."},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s \""},{"line_number":258,"context_line":"                \"because port still has associated floating IP.\")"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class ServicePortInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dce880a3_2d000f60","line":258,"updated":"2023-05-26 07:19:44.000000000","message":"nits:\n- port -\u003e the port\n- assocaited floating IP -\u003e an associated floating IP","commit_id":"c9d8839ba0e4a4e2936ea7679f306c8714682c8d"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"1b2d06dcb10f716a651ca77317f7583e9dc07e4d","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    :param port_id: The UUID of the port requested."},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s \""},{"line_number":258,"context_line":"                \"because port still has associated floating IP.\")"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class ServicePortInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"af02f837_0433876d","line":258,"in_reply_to":"dce880a3_2d000f60","updated":"2023-05-26 08:10:35.000000000","message":"Done","commit_id":"c9d8839ba0e4a4e2936ea7679f306c8714682c8d"}]}