)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e4045fc1952a5fcd0ba3206ce41264b4f48e8c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cdc1abe3_17d55f26","updated":"2023-12-15 10:02:17.000000000","message":"Some nits only","commit_id":"4d70185a0051b91af41c19785039c7a0099f770a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fe4fcb3da1c3edcfe07f5fc36365364da12dd9d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ad85d87e_651f1ef0","updated":"2024-01-10 11:21:20.000000000","message":"recheck\ntest_bootable_volume_backup_and_restore failure in full-py3 is not related","commit_id":"1c09f2972ddb76ea0a0186d55f1fbc0eda67fe3a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"024e12bde8f6f01f237c5d48e19a8eff18ed6408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"12b22805_7188fc71","updated":"2024-01-25 16:57:01.000000000","message":"api-def doc looks better now, thanks","commit_id":"72442e0ba0637898f8dbf0af757e81c7332c9c7a"}],"api-ref/source/v2/tap_mirrors.inc":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e4045fc1952a5fcd0ba3206ce41264b4f48e8c90","unresolved":true,"context_lines":[{"line_number":201,"context_line":"   - remote_ip: remote_ip_tap_mirror"},{"line_number":202,"context_line":"   - directions: directions_tap_mirror"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Response Example"},{"line_number":205,"context_line":"----------------"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":".. literalinclude:: samples/taas/tap_mirror-show-response.json"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"48914735_8d7011fa","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":2},"updated":"2023-12-15 10:02:17.000000000","message":"Don\u0027t we have a request example?","commit_id":"4d70185a0051b91af41c19785039c7a0099f770a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8df1401a5e319db1b95e9243d8ed1a188059f890","unresolved":true,"context_lines":[{"line_number":201,"context_line":"   - remote_ip: remote_ip_tap_mirror"},{"line_number":202,"context_line":"   - directions: directions_tap_mirror"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Response Example"},{"line_number":205,"context_line":"----------------"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":".. literalinclude:: samples/taas/tap_mirror-show-response.json"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9ab68aaf_4ce3cb6e","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":2},"in_reply_to":"48914735_8d7011fa","updated":"2024-01-09 17:08:09.000000000","message":"yes there is for update and create (https://review.opendev.org/c/openstack/neutron-lib/+/885354/7/api-ref/source/v2/tap_mirrors.inc#124 \u0026 https://review.opendev.org/c/openstack/neutron-lib/+/885354/7/api-ref/source/v2/tap_mirrors.inc#78 )","commit_id":"4d70185a0051b91af41c19785039c7a0099f770a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7b0151a6ab94fad65ce9b2ba32a392726312c056","unresolved":true,"context_lines":[{"line_number":170,"context_line":"Show Tap Mirror"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":".. rest_method:: GET /v2.0/taas/tap_mirrors/{tap_mirror_id/name}"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Shows details for a tap mirror."},{"line_number":176,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"965d44be_0c8ab603","line":173,"updated":"2024-01-24 20:24:37.000000000","message":"This is the only issue I found. It looks like the request can use either a name or ID, but the parameters below only shows \u0027name\u0027 as an option. The taas file has the same syntax, but has two items in the list:\n\nname query string The name of the Tap Service.\nid (Optional) query string The ID of the Tap Service.\n\nOf course I can\u0027t find where it actually adds that Optional item.\n\nAlso, do any of the other requests support ID? It would seem like they would and would mirror taas.inc document.","commit_id":"a9702c00aba999926b6da49612a6ba4c2a78b59e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"024e12bde8f6f01f237c5d48e19a8eff18ed6408","unresolved":true,"context_lines":[{"line_number":170,"context_line":"Show Tap Mirror"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":".. rest_method:: GET /v2.0/taas/tap_mirrors/{tap_mirror_id/name}"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Shows details for a tap mirror."},{"line_number":176,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"048a4ff2_978a8873","line":173,"in_reply_to":"5424afb7_6c3861a0","updated":"2024-01-25 16:57:01.000000000","message":"Ok, if you are going to fix taas.inc I\u0027ll let you fix these two typos I found there as well:\n\ndiff --git a/api-ref/source/v2/taas.inc b/api-ref/source/v2/taas.inc\nindex 7ded793b..49875288 100644\n--- a/api-ref/source/v2/taas.inc\n+++ b/api-ref/source/v2/taas.inc\n@@ -319,7 +319,7 @@ Response Example\n Update Tap Flow\n \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n \n-.. rest_method:: PUT /v2.0/taas/tap_flows/{taf_service_id/name}\n+.. rest_method:: PUT /v2.0/taas/tap_flows/{tap_flows_id/name}\n \n Update Tap Flow by passing tap flow ``name`` or ``id`` as JSON-encoded data.\n Name or description or both can only be updated.\n@@ -365,7 +365,7 @@ Response Example\n Delete Tap Flow\n \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n \n-.. rest_method:: DELETE /v2.0/taas/tap_flows/{tap_service_id/name}\n+.. rest_method:: DELETE /v2.0/taas/tap_flows/{tap_flows_id/name}\n \n Delete Tap Flow by passing tap flow ``name`` or ``id`` as JSON-encoded data.","commit_id":"a9702c00aba999926b6da49612a6ba4c2a78b59e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3300b70c9c4393345130845dd43fbdd03433b37f","unresolved":true,"context_lines":[{"line_number":170,"context_line":"Show Tap Mirror"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":".. rest_method:: GET /v2.0/taas/tap_mirrors/{tap_mirror_id/name}"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Shows details for a tap mirror."},{"line_number":176,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"5424afb7_6c3861a0","line":173,"in_reply_to":"965d44be_0c8ab603","updated":"2024-01-25 14:03:00.000000000","message":"Thanks, after double checking it, I think this is a copy paste error, as I don\u0027t think openstack API supports GET /\u003cresource\u003e/\u003cname of resource\u003e type queries, only \u003cuuid of resource\u003e.\nI push a FUP for taas also, as I also copy pasted there the name wrongly from some old doc it seems.","commit_id":"a9702c00aba999926b6da49612a6ba4c2a78b59e"}],"neutron_lib/api/definitions/tap_mirror.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e4045fc1952a5fcd0ba3206ce41264b4f48e8c90","unresolved":true,"context_lines":[{"line_number":71,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d None"},{"line_number":72,"context_line":"ACTION_MAP \u003d {}"},{"line_number":73,"context_line":"ACTION_STATUS \u003d {}"},{"line_number":74,"context_line":"REQUIRED_EXTENSIONS \u003d [\u0027taas\u0027]"},{"line_number":75,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"0c342b68_b6a7b816","line":74,"range":{"start_line":74,"start_character":23,"end_line":74,"end_character":29},"updated":"2023-12-15 10:02:17.000000000","message":"nit: this is taas.ALIAS constant.","commit_id":"4d70185a0051b91af41c19785039c7a0099f770a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8df1401a5e319db1b95e9243d8ed1a188059f890","unresolved":false,"context_lines":[{"line_number":71,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d None"},{"line_number":72,"context_line":"ACTION_MAP \u003d {}"},{"line_number":73,"context_line":"ACTION_STATUS \u003d {}"},{"line_number":74,"context_line":"REQUIRED_EXTENSIONS \u003d [\u0027taas\u0027]"},{"line_number":75,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"5e47cd1b_de4083e7","line":74,"range":{"start_line":74,"start_character":23,"end_line":74,"end_character":29},"in_reply_to":"0c342b68_b6a7b816","updated":"2024-01-09 17:08:09.000000000","message":"Done","commit_id":"4d70185a0051b91af41c19785039c7a0099f770a"}]}