)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1183e9da811593e6d480f0689c76799fd542b1e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ee28731c_0149a7a6","updated":"2023-06-23 13:27:02.000000000","message":"Thanks","commit_id":"c4be8ca2919fd7191f9885619789b33e48b8a33e"}],"api-ref/source/v2/samples/subnets/subnets-onboard-request.json":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7f5661a5ca1c01e5190ed1089f39d341536d21e1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"network_id\": \"30640c16-a281-4ec5-8ec0-da05a0a5578d\","},{"line_number":3,"context_line":"  \"subnetpool_id\": \"5b3d3ffd-109a-4bda-a03c-57b17989b215\""},{"line_number":4,"context_line":"}"}],"source_content_type":"application/json","patch_set":6,"id":"50145211_5fd21c57","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":57},"updated":"2023-06-22 13:01:08.000000000","message":"No, this parameter is not in the request JSON file but in the URL: https://review.opendev.org/c/openstack/neutron-lib/+/885968/5..6/api-ref/source/v2/subnet_onboard_ops.inc#12","commit_id":"378195f624be443263855aa8053e41f1ea00f7f6"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"0c75700b089bd268186a65801e7e0b41c5793f63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"network_id\": \"30640c16-a281-4ec5-8ec0-da05a0a5578d\","},{"line_number":3,"context_line":"  \"subnetpool_id\": \"5b3d3ffd-109a-4bda-a03c-57b17989b215\""},{"line_number":4,"context_line":"}"}],"source_content_type":"application/json","patch_set":6,"id":"ff7c9b31_d54b6f4f","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":57},"in_reply_to":"50145211_5fd21c57","updated":"2023-06-22 15:23:17.000000000","message":"Done","commit_id":"378195f624be443263855aa8053e41f1ea00f7f6"}],"api-ref/source/v2/samples/subnets/subnets-onboard-response.json":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d29718c0797eb3667efaebc4d10a60e1f2c6a731","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"id\": \"5b3d3ffd-109a-4bda-a03c-57b17989b215\","},{"line_number":3,"context_line":"  \"cidr\": \"10.0.2.0/24\""},{"line_number":4,"context_line":"}"},{"line_number":5,"context_line":""}],"source_content_type":"application/json","patch_set":5,"id":"8eac56ba_054a2ebc","line":2,"updated":"2023-06-22 11:07:37.000000000","message":"This parameter should be \"subnetpool_id\"","commit_id":"4308a0c56127c33ed99c4fb7e0c90c9cef05ca06"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"62e33291c25cd107792def7adddaee91352623cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"id\": \"5b3d3ffd-109a-4bda-a03c-57b17989b215\","},{"line_number":3,"context_line":"  \"cidr\": \"10.0.2.0/24\""},{"line_number":4,"context_line":"}"},{"line_number":5,"context_line":""}],"source_content_type":"application/json","patch_set":5,"id":"b24afe4b_5893a704","line":2,"in_reply_to":"8eac56ba_054a2ebc","updated":"2023-06-22 12:26:44.000000000","message":"Done","commit_id":"4308a0c56127c33ed99c4fb7e0c90c9cef05ca06"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d29718c0797eb3667efaebc4d10a60e1f2c6a731","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff13182d_384848a3","line":6,"updated":"2023-06-22 11:07:37.000000000","message":"nit: Please remove this last line.","commit_id":"4308a0c56127c33ed99c4fb7e0c90c9cef05ca06"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"62e33291c25cd107792def7adddaee91352623cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e903a43b_fd8277bf","line":6,"in_reply_to":"ff13182d_384848a3","updated":"2023-06-22 12:26:44.000000000","message":"Done","commit_id":"4308a0c56127c33ed99c4fb7e0c90c9cef05ca06"}],"api-ref/source/v2/subnet_onboard_ops.inc":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e3b780c1289413c62d8a411cbfb479fd2fa03740","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   - subnetpool_id: subnetpool_id"},{"line_number":39,"context_line":"   - cidr: cidr"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"858c0075_4fd4d52a","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":33},"updated":"2023-06-14 09:08:16.000000000","message":"You have to create an entry for this in parameters.yaml (be careful there are mines like alphabetical checks and similar :))","commit_id":"4308a0c56127c33ed99c4fb7e0c90c9cef05ca06"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"62e33291c25cd107792def7adddaee91352623cc","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   - subnetpool_id: subnetpool_id"},{"line_number":39,"context_line":"   - cidr: cidr"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"21aeb282_500b8770","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":33},"in_reply_to":"0f57a34e_b0f9cd2f","updated":"2023-06-22 12:26:44.000000000","message":"Thanks! Now got it","commit_id":"4308a0c56127c33ed99c4fb7e0c90c9cef05ca06"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d29718c0797eb3667efaebc4d10a60e1f2c6a731","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   - subnetpool_id: subnetpool_id"},{"line_number":39,"context_line":"   - cidr: cidr"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"0f57a34e_b0f9cd2f","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":33},"in_reply_to":"16349217_64688045","updated":"2023-06-22 11:07:37.000000000","message":"Because you require the \"subnetpool_id\" parameter in the request too, and this is missing.\n\n    Request\n    -------\n    .. rest_parameters:: parameters.yaml\n       - subnetpool_id: subnetpool_id\n       - network_id: network_id","commit_id":"4308a0c56127c33ed99c4fb7e0c90c9cef05ca06"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"5048fcd39e149c4fe226a1be89df168415eb30c9","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   - subnetpool_id: subnetpool_id"},{"line_number":39,"context_line":"   - cidr: cidr"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"16349217_64688045","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":33},"in_reply_to":"858c0075_4fd4d52a","updated":"2023-06-14 09:31:18.000000000","message":"Hi! I don\u0027t understand why this check is failing. subnetpool_id entry is exist in parameters.yaml [1]. And used in other places [2], [3]\n\n1) https://opendev.org/openstack/neutron-lib/src/branch/master/api-ref/source/v2/parameters.yaml#L312\n\n2) https://opendev.org/openstack/neutron-lib/src/branch/master/api-ref/source/v2/subnetpool_prefix_ops.inc#L25\n\n3) https://opendev.org/openstack/neutron-lib/src/branch/master/api-ref/source/v2/subnetpools.inc#L51","commit_id":"4308a0c56127c33ed99c4fb7e0c90c9cef05ca06"}]}