)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"793a6edce9cfbdd71608172b4d799648cd3e2570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f2a0fe24_43ab7efe","updated":"2023-06-29 14:40:32.000000000","message":"-1 for visibility\n1) Please add a reno, this change really deserves it.\n2) Shouldn\u0027t you add this role to [1] too?\n\n[1]https://github.com/openstack/neutron-lib/blob/d5acebbe7bf8f987cd06e93b1740a76c50e78af4/neutron_lib/context.py#L122","commit_id":"d440e7a5900d2f82f8a99f892c62e5e429043c2a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"997875ac0bf395b24b74f4811cb1c384a7789b5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"224744fb_6f3b4b55","updated":"2023-06-29 14:42:29.000000000","message":"Setting -W until the questions are resolved.","commit_id":"d440e7a5900d2f82f8a99f892c62e5e429043c2a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c21709012770db1e6deec25414fcb51d2c9e90a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dedc6dd3_57c50be8","updated":"2023-06-29 14:31:11.000000000","message":"Thanks, as I see it is ok","commit_id":"d440e7a5900d2f82f8a99f892c62e5e429043c2a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8ac5f7eeab770d6e30e31e503dcc8bd1418adda4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"683babab_01e02c15","in_reply_to":"1784d2b3_21df5f1c","updated":"2023-07-03 14:06:26.000000000","message":"Thanks!","commit_id":"d440e7a5900d2f82f8a99f892c62e5e429043c2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6d3a322568ca3c4ad5f8666b503cafe31b7c8b0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1784d2b3_21df5f1c","in_reply_to":"f2a0fe24_43ab7efe","updated":"2023-06-30 13:58:24.000000000","message":"reno added. I also added warning about deprecation of the old is_advscv attribute.\nRegarding second question - no, service role is something different and even admin don\u0027t have this role so I think it\u0027s fine like it\u0027s now.","commit_id":"d440e7a5900d2f82f8a99f892c62e5e429043c2a"}],"neutron_lib/policy/_engine.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"417ec6bc5bca905625506b236ac1e09a583ebbcb","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        \u0027role:advsvc\u0027,"},{"line_number":41,"context_line":"        description\u003d\u0027Rule for advanced service role access\u0027),"},{"line_number":42,"context_line":"    policy.RuleDefault("},{"line_number":43,"context_line":"        \u0027service_api\u0027,"},{"line_number":44,"context_line":"        \u0027role:service\u0027,"},{"line_number":45,"context_line":"        description\u003d\u0027Default rule for the service-to-service APIs.\u0027),"},{"line_number":46,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"afaedbce_6fd5f1d9","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":21},"updated":"2023-06-28 17:11:19.000000000","message":"Should this be the constant from above?","commit_id":"5c107a054a8a06eddca650927c9a310e81de45af"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"46b14b86d63727733f01c0700a3cd2aa5c6e19e2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \u0027role:advsvc\u0027,"},{"line_number":41,"context_line":"        description\u003d\u0027Rule for advanced service role access\u0027),"},{"line_number":42,"context_line":"    policy.RuleDefault("},{"line_number":43,"context_line":"        \u0027service_api\u0027,"},{"line_number":44,"context_line":"        \u0027role:service\u0027,"},{"line_number":45,"context_line":"        description\u003d\u0027Default rule for the service-to-service APIs.\u0027),"},{"line_number":46,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0879a57_58940d0d","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":21},"in_reply_to":"afaedbce_6fd5f1d9","updated":"2023-06-29 13:44:32.000000000","message":"Done","commit_id":"5c107a054a8a06eddca650927c9a310e81de45af"}]}