)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"deccfa6d88a4d060b5ad9a93c5a04c8ff2e5ca6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"095594a4_03871dc1","updated":"2023-11-29 20:09:07.000000000","message":"We can\u0027t do this as it will break other projects that still use the constant, even if the neutron repo isn\u0027t.\n\nhttps://codesearch.opendev.org/?q\u003dDEVICE_OWNER_LOADBALANCER\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"83cce93b64c766644b71fe086369003ae1e47212"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6009517675b8ae0e342fd299efb10ec2520ed75f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6af854c8_4fc809ed","in_reply_to":"095594a4_03871dc1","updated":"2023-11-30 02:07:27.000000000","message":"I\u0027ve pushed changes to fwaas and sfc to remove usage of these constants.\n https://review.opendev.org/c/openstack/networking-sfc/+/902216\n https://review.opendev.org/c/openstack/neutron-fwaas/+/902215\n\nInterestingly Codesearch shows old version of charm-octavia which contains these constants but I see these constants are not longer used in the latest code.\n\nThere are two projects outside of OpenStack\u0027s governance but AFAIK both of these are unmaintained so I believe we can ignore these (or leave the required changes to the maintainer of these repos).\n x/group-based-policy\n x/vmware-nsx","commit_id":"83cce93b64c766644b71fe086369003ae1e47212"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7f32511db63f24582f8e7484d4c20a2e14d5d0be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d3b63865_5c14134a","in_reply_to":"6af854c8_4fc809ed","updated":"2023-12-03 16:05:49.000000000","message":"So I think the charm-octavia code still does use the constant, and relies on the code we removed from neutron. Let me check with the team here that owns that code and do a deployment to make sure.","commit_id":"83cce93b64c766644b71fe086369003ae1e47212"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aaff652e969f0c6f7c3e124e8857068b7fdef7f9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b56063c_d7632ac0","in_reply_to":"d3b63865_5c14134a","updated":"2023-12-04 02:02:23.000000000","message":"Hmm. So it looks like the neutron change already broke the charm-octavia which is using that internal logic to enable IPv6 RA. TBVH I think the current implementation in charm-octavia is ugly and it should not rely on internal logic in Neutron. We probably have to implement a specific owner or property to tell Neutron to apply configurations to allow IPv6 RA.\n\nFor now I proposed https://review.opendev.org/c/openstack/charm-octavia/+/902499 to replace LBaaS v2 constant by a different internal owner (trunk sub ports) which should enable IPv6 RA.","commit_id":"83cce93b64c766644b71fe086369003ae1e47212"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"97029e38e6ad5dbdf5a48fa8e8ed9107aead3098","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8b1264e9_6d441778","updated":"2024-02-21 08:31:57.000000000","message":"Do we have to wait for https://review.opendev.org/c/openstack/charm-octavia/+/909319 or https://review.opendev.org/c/openstack/charm-octavia/+/902499 ?","commit_id":"9081c39100b13d2b404869a59b79af6f12a9eb2d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1ce251951d1cc9f65b77f7be0e80c24bcf7aa641","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26ef4e05_e00f8d0e","updated":"2024-02-08 04:24:35.000000000","message":"I\u0027m restoring this change because it really needs to be done. If this is still needed by charm (though I don\u0027t think so because the usage has been already removed from neutron) then they should vendor this by themselves.","commit_id":"9081c39100b13d2b404869a59b79af6f12a9eb2d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67310141897301bb8bbe11ddc7d0a5eefc56e2d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2dbe9d0c_86a4924a","updated":"2024-02-18 14:59:33.000000000","message":"I\u0027ve pushed https://review.opendev.org/c/openstack/charm-octavia/+/909319 to stop importing the constant from neutron-lib","commit_id":"9081c39100b13d2b404869a59b79af6f12a9eb2d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9b19d5801d2ba50f2f7e11702769407a7f49739e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c7733ec1_97cac229","updated":"2024-02-22 16:21:38.000000000","message":"Let\u0027s merge this as the constant has no meaning in neutron any more, i\u0027ll work on getting the charm code fixed.","commit_id":"9081c39100b13d2b404869a59b79af6f12a9eb2d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d3f34cbcceaaa5b76770ffcd4352cf1f540db1ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"05b80ecb_f9a79e4c","in_reply_to":"2dbe9d0c_86a4924a","updated":"2024-02-20 23:03:38.000000000","message":"https://review.opendev.org/c/openstack/charm-octavia/+/902499 had also been sent previously.\n\nI\u0027m still trying to get someone to review the charm change so we don\u0027t break them, but do not have a response yet.","commit_id":"9081c39100b13d2b404869a59b79af6f12a9eb2d"}]}