)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"599199b7eb1b4187335dd2833561a9397a1c9c6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a02f4d7d_01ff87b3","updated":"2023-12-19 14:22:33.000000000","message":"recheck","commit_id":"257c152437d80a9f09743b18ff24319e22b1a229"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4f9a9d07eb5c7737a9a4ed54c799f7d9c63367e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0d7115da_928875eb","updated":"2024-01-09 07:13:19.000000000","message":"This change is modifying the ``api.definitions.vpn.ipsecpolicies.encryption_algorithm``. This requires an API extension. You cannot directly change \"VPN_SUPPORTED_ENCRYPTION_ALGORITHMS\".","commit_id":"48ac3b36d86d95a3648cfc23fe535c32d2e69c35"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"d3c9108ef8e69d95300fa6896c1463b9ac8a16aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf4e1034_6139eec7","in_reply_to":"0d7115da_928875eb","updated":"2024-01-09 09:16:19.000000000","message":"Added one for aes_ctr.","commit_id":"48ac3b36d86d95a3648cfc23fe535c32d2e69c35"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3976ad641588355e389c2a2ca0dbcef0e5f7abe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0549e0c_ccca69be","updated":"2024-01-09 13:04:02.000000000","message":"nit: could you add a release note also to extend the original reno (https://review.opendev.org/c/openstack/neutron-lib/+/898828/4/releasenotes/notes/add-vpnaas-ciphers-6c1dffbc2cdc3225.yaml )","commit_id":"a761d6708ca1daa236547c1e0735670205c27218"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee36ffab8f7ba1e6a4e9c68ac19690d07506508a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b478a3e2_c9e49621","updated":"2024-02-20 22:18:58.000000000","message":"I would agree with Rodolfo we should do this based on his example.\n\nRodolfo - do you see a way to fix the other one?","commit_id":"a7bf94a537be18a1c6301b41e1c7c771efb8ce25"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"b6e299cf2a6953057652373c8a57a0cd1a6e9fa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a5592d9_e016f600","updated":"2024-01-09 16:01:29.000000000","message":"Sure. I added it to the existing release notes file, because both go into the same next release.","commit_id":"a7bf94a537be18a1c6301b41e1c7c771efb8ce25"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ad1e0853ecd71d54b42e4b00219639e3309ba0fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b4e76a59_d3665663","in_reply_to":"b478a3e2_c9e49621","updated":"2024-02-21 07:10:26.000000000","message":"No, the previous patch was released and we can\u0027t prevent anyone to use it. We can block the n-lib version with this feature (the previous patch) in requirements.","commit_id":"a7bf94a537be18a1c6301b41e1c7c771efb8ce25"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"d2a2ec3bf701001247e3a2f50b509b3da8fac24c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f8f7d1d_a4bcaa39","updated":"2024-02-26 15:30:13.000000000","message":"I fixed the extension definition for this one here.\nIs there something I should do to fix the previous extension?","commit_id":"91f6051b2302d9e2783ddcb2517df39dd2e2953b"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"5278cf22766f4339ec6dd3dc28740696d880861e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1c849864_376133a4","updated":"2024-02-27 09:04:55.000000000","message":"recheck","commit_id":"7e76067f539bf3a981c9b20b9e9a38a524d587c8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a4bfc7f1c47a64dbb776f6056f4660290ba48496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c598fdc9_1774e63e","updated":"2024-06-27 07:04:38.000000000","message":"Hi Brian. I commented my concerns about this API change without creating a new one. What do you think about it?","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"e479ae88a98f8aeaf54700fcbf32b49e7b1667eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c88b4b64_b0e96b39","updated":"2025-01-14 09:42:58.000000000","message":"I\u0027d appreciate a review here. I hope my changes with patchset 5 define the extension properly.","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e29c3e91e60255803d5dca87dff43239797e4730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c115d9ff_4d0a70d9","updated":"2025-01-14 15:24:50.000000000","message":"Looks like Rodolfo prefers you introducing a ALGORITHMS_NEW (ALGORITHMS_WITH_AES_CTR?) list instead of touching the existing one. Otherwise, this should be good to go I think. I will wait for PS8.","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"eac838dc884c71daedcd6b7931ba6020144b20c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"af8e73a8_de29cb15","in_reply_to":"5c4445d2_76e85e2a","updated":"2024-08-22 09:01:17.000000000","message":"hmmm, good question, perhaps we can have a live chat during the drivers meeting, not sure who can participate this Friday (or worst case next weeks team meeting on-demand can work also, but I suppose most people slowly come back from summer-time 😊))","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dda4540c3cc9c0c6a5d231f9a97d9bef31721215","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"908080a8_09a32724","in_reply_to":"77438d28_f18d46a8","updated":"2024-08-22 08:32:23.000000000","message":"+1, I would like to see if the same result can be achieved with new extension with the new AES algorithms (I don\u0027t see why adding a new extension could not work, and that is a future/upgrade proof solution)","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"3784a50f45a1bbd7a6cbed1b5dfac4661c13b5ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d87aca34_d2d41fa8","in_reply_to":"908080a8_09a32724","updated":"2024-08-22 08:38:20.000000000","message":"with patchset 5 I changed the extension definition so that it does not directly change the existing API but adds the aes-ctr choices in vpn_aes_ctr.py (the extension). In vpn.py the choices validation choices are left as VPN_SUPPORTED_ENCRYPTION_ALGORITHMS_V390, i.e. the list without the 3 new ones.\nIs there more to do?\n\nI understand that the previous (and already merged) patch to add AES GCM and several DH groups didn\u0027t do it right. Should that be fixed here too or in another patch or is it too late because it\u0027s already merged?","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"045ce71ae279e68f10d48142106d9cc676bebbeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"605e3227_d2c631b0","in_reply_to":"af8e73a8_de29cb15","updated":"2024-08-22 09:14:31.000000000","message":"unfortunately Friday I won\u0027t be able to attend, but next week\u0027s team or driver meetings are fine","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"3e14b71d396cca9c446b54c0751970fdfa7dbea2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"74394d1a_c175042e","in_reply_to":"b343ee63_3266d372","updated":"2025-01-14 10:15:21.000000000","message":"yes, I will join today","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cfc489f9f782da441509844d167b87bac844f5fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c8ec8c03_6313f2b7","in_reply_to":"c598fdc9_1774e63e","updated":"2024-06-27 13:55:45.000000000","message":"Hi Rodolfo - maybe I mis-understood, did you want to block the n-lib version with the previous definition? I didn\u0027t see any conclusion in the meeting notes.","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9d1e8afd95fff6b63bcc5bc5ba1c83120338a179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b343ee63_3266d372","in_reply_to":"c88b4b64_b0e96b39","updated":"2025-01-14 10:06:14.000000000","message":"Could you please join the meeting This Tuesday (14. Jan. 1400UTC) or Friday (17. Jan. 1400UTC) to refresh the memories for this topic?","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5489b4ae4e184cdee62b62a8bb35f3f3566825cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"77438d28_f18d46a8","in_reply_to":"c8ec8c03_6313f2b7","updated":"2024-07-01 12:57:14.000000000","message":"Not really, I\u0027m just asking about how this API change should be done. This patch is directly modifying an existing API, something that should not be done. Instead a new API extension, with the new fields, should be proposed.","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"78849eb2f7d9feb51178eaf212a7304d1c7533ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5c4445d2_76e85e2a","in_reply_to":"d87aca34_d2d41fa8","updated":"2024-08-22 08:46:27.000000000","message":"The previous one was https://review.opendev.org/c/openstack/neutron-lib/+/898828","commit_id":"258a60a81c0b3568a09ebe2eea775e51e1394e3d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8ad5f5f9577609171e74ffb4d4af649346ec8422","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a1981789_b7c49a15","updated":"2025-01-14 15:45:31.000000000","message":"thank you","commit_id":"488fcb06d451b4fef966b8cd703e528cdaf33939"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"410c965644be83f57d8f82105a161cb45416cfcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"176aa280_2660e409","updated":"2025-01-15 22:54:14.000000000","message":"recheck functional was fixed","commit_id":"ef72d4cd6e2e74a0452dcea916613357c3627a22"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af376555ab0b6df629440081ee42b4d523ec5c3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"79d7d45c_1f843f85","updated":"2025-01-15 07:12:37.000000000","message":"recheck neutron-tempest-plugin-openvswitch","commit_id":"ef72d4cd6e2e74a0452dcea916613357c3627a22"}],"neutron_lib/api/definitions/vpn.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c4f5b6a5f6442c05279f351bcd125e8bb643d670","unresolved":true,"context_lines":[{"line_number":52,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_256_CCM_12 \u003d \u0027aes-256-ccm-12\u0027"},{"line_number":53,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_128_CCM_16 \u003d \u0027aes-128-ccm-16\u0027"},{"line_number":54,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_192_CCM_16 \u003d \u0027aes-192-ccm-16\u0027"},{"line_number":55,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_256_CCM_16 \u003d \u0027aes-256-ccm-16\u0027"},{"line_number":56,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_128_GCM_8 \u003d \u0027aes-128-gcm-8\u0027"},{"line_number":57,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_192_GCM_8 \u003d \u0027aes-192-gcm-8\u0027"},{"line_number":58,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_256_GCM_8 \u003d \u0027aes-256-gcm-8\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1f361b6_5b86318e","line":55,"updated":"2024-01-08 17:41:16.000000000","message":"They should be added after here to keep this list alphabetical.","commit_id":"257c152437d80a9f09743b18ff24319e22b1a229"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"80618c7e4433dd2627fcc9f676e804ed028c92bd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_256_CCM_12 \u003d \u0027aes-256-ccm-12\u0027"},{"line_number":53,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_128_CCM_16 \u003d \u0027aes-128-ccm-16\u0027"},{"line_number":54,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_192_CCM_16 \u003d \u0027aes-192-ccm-16\u0027"},{"line_number":55,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_256_CCM_16 \u003d \u0027aes-256-ccm-16\u0027"},{"line_number":56,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_128_GCM_8 \u003d \u0027aes-128-gcm-8\u0027"},{"line_number":57,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_192_GCM_8 \u003d \u0027aes-192-gcm-8\u0027"},{"line_number":58,"context_line":"VPN_ENCRYPTION_ALGORITHM_AES_256_GCM_8 \u003d \u0027aes-256-gcm-8\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"19d07aff_704cf325","line":55,"in_reply_to":"b1f361b6_5b86318e","updated":"2024-01-08 17:57:31.000000000","message":"moved the CTR types","commit_id":"257c152437d80a9f09743b18ff24319e22b1a229"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c4f5b6a5f6442c05279f351bcd125e8bb643d670","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_256_CCM_12,"},{"line_number":77,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_128_CCM_16,"},{"line_number":78,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_192_CCM_16,"},{"line_number":79,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_256_CCM_16,"},{"line_number":80,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_128_GCM_8,"},{"line_number":81,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_192_GCM_8,"},{"line_number":82,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_256_GCM_8,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b8b7e5f8_4191fac3","line":79,"updated":"2024-01-08 17:41:16.000000000","message":"Should they also be added here to the supported list?","commit_id":"257c152437d80a9f09743b18ff24319e22b1a229"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"80618c7e4433dd2627fcc9f676e804ed028c92bd","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_256_CCM_12,"},{"line_number":77,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_128_CCM_16,"},{"line_number":78,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_192_CCM_16,"},{"line_number":79,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_256_CCM_16,"},{"line_number":80,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_128_GCM_8,"},{"line_number":81,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_192_GCM_8,"},{"line_number":82,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_256_GCM_8,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5bc7a760_92808e16","line":79,"in_reply_to":"b8b7e5f8_4191fac3","updated":"2024-01-08 17:57:31.000000000","message":"yes. I added them.","commit_id":"257c152437d80a9f09743b18ff24319e22b1a229"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b7e9c60e229c9210d126293d6b443a8fc5809f65","unresolved":true,"context_lines":[{"line_number":384,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":385,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":386,"context_line":"            \u0027default\u0027: VPN_ENCRYPTION_ALGORITHM_AES_128,"},{"line_number":387,"context_line":"            \u0027validate\u0027: {\u0027type:values\u0027: VPN_SUPPORTED_ENCRYPTION_ALGORITHMS},"},{"line_number":388,"context_line":"            \u0027is_visible\u0027: True},"},{"line_number":389,"context_line":"        \u0027encapsulation_mode\u0027: {"},{"line_number":390,"context_line":"            \u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"393165a9_28b752c9","line":387,"updated":"2024-02-13 19:37:35.000000000","message":"You are changing VPN_SUPPORTED_ENCRYPTION_ALGORITHMS list in this patch. That will change the supported \"encryption_algorithm\" values without using the new API extension.\n\nYou need to explicitly keep this list as is now and update the \"encryption_algorithm\" value in the new extension.","commit_id":"a7bf94a537be18a1c6301b41e1c7c771efb8ce25"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f91e3f3f76058490ee0c07c492a9a53f8ffc124c","unresolved":true,"context_lines":[{"line_number":384,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":385,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":386,"context_line":"            \u0027default\u0027: VPN_ENCRYPTION_ALGORITHM_AES_128,"},{"line_number":387,"context_line":"            \u0027validate\u0027: {\u0027type:values\u0027: VPN_SUPPORTED_ENCRYPTION_ALGORITHMS},"},{"line_number":388,"context_line":"            \u0027is_visible\u0027: True},"},{"line_number":389,"context_line":"        \u0027encapsulation_mode\u0027: {"},{"line_number":390,"context_line":"            \u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"78862e30_bf3d855c","line":387,"in_reply_to":"393165a9_28b752c9","updated":"2024-02-13 19:37:55.000000000","message":"Example: https://review.opendev.org/c/openstack/neutron-lib/+/903531","commit_id":"a7bf94a537be18a1c6301b41e1c7c771efb8ce25"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9a74cfc0ee50f5397f6ca1f578b7c2baa5493bb2","unresolved":true,"context_lines":[{"line_number":384,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":385,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":386,"context_line":"            \u0027default\u0027: VPN_ENCRYPTION_ALGORITHM_AES_128,"},{"line_number":387,"context_line":"            \u0027validate\u0027: {\u0027type:values\u0027: VPN_SUPPORTED_ENCRYPTION_ALGORITHMS},"},{"line_number":388,"context_line":"            \u0027is_visible\u0027: True},"},{"line_number":389,"context_line":"        \u0027encapsulation_mode\u0027: {"},{"line_number":390,"context_line":"            \u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d76210a8_bd5af178","line":387,"in_reply_to":"436fe8d6_48002cb8","updated":"2024-02-16 07:27:22.000000000","message":"Yes, [1] was an incorrect implementation. And yes, it is already released [2]. I\u0027ll ask next Tuesday, in the Neutron meeting, how to proceed on this one.\n\n[1]https://review.opendev.org/c/openstack/neutron-lib/+/898828\n[2]https://github.com/openstack/neutron-lib/commits/3.10.0/","commit_id":"a7bf94a537be18a1c6301b41e1c7c771efb8ce25"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"48fca388fb96a0a3b5ee84e634edd4509a58e6c4","unresolved":true,"context_lines":[{"line_number":384,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":385,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":386,"context_line":"            \u0027default\u0027: VPN_ENCRYPTION_ALGORITHM_AES_128,"},{"line_number":387,"context_line":"            \u0027validate\u0027: {\u0027type:values\u0027: VPN_SUPPORTED_ENCRYPTION_ALGORITHMS},"},{"line_number":388,"context_line":"            \u0027is_visible\u0027: True},"},{"line_number":389,"context_line":"        \u0027encapsulation_mode\u0027: {"},{"line_number":390,"context_line":"            \u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"436fe8d6_48002cb8","line":387,"in_reply_to":"78862e30_bf3d855c","updated":"2024-02-14 10:03:47.000000000","message":"Then I did it wrong in https://review.opendev.org/c/openstack/neutron-lib/+/898828 as well. Unfortunately I forgot AES CTR in that patch, but it also changes VPN_SUPPORTED_ENCRYPTION_ALGORITHMS. That other patch is already merged, but not released yet. Does it make sense to add AES CTR to the extension defined there and fix the issue you just mentioned for both patches together?\nOtherwise we would have two extensions that add some ciphers in the same release and structuring the validation gets complicated. I hope there\u0027s still time before the next release to build it as a combined extension","commit_id":"a7bf94a537be18a1c6301b41e1c7c771efb8ce25"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"b61170dda0219650ee4e302fcc0019495847a766","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":385,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":386,"context_line":"            \u0027default\u0027: VPN_ENCRYPTION_ALGORITHM_AES_128,"},{"line_number":387,"context_line":"            \u0027validate\u0027: {\u0027type:values\u0027: VPN_SUPPORTED_ENCRYPTION_ALGORITHMS},"},{"line_number":388,"context_line":"            \u0027is_visible\u0027: True},"},{"line_number":389,"context_line":"        \u0027encapsulation_mode\u0027: {"},{"line_number":390,"context_line":"            \u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e66dd7a8_98f3ee11","line":387,"in_reply_to":"d76210a8_bd5af178","updated":"2025-01-14 15:46:15.000000000","message":"Fixed by keeping the old `VPN_SUPPORTED_ENCRYPTION_ALGORITHMS` and introducing `VPN_SUPPORTED_ENCRYPTION_ALGORITHMS_WITH_CTR` in the new extension","commit_id":"a7bf94a537be18a1c6301b41e1c7c771efb8ce25"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1a53e567e0335b2befa6b43125f12c354a4c7479","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_256_GCM_16,"},{"line_number":93,"context_line":"]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"VPN_SUPPORTED_ENCRYPTION_ALGORITHMS_WITH_CTR \u003d ("},{"line_number":96,"context_line":"    VPN_SUPPORTED_ENCRYPTION_ALGORITHMS + ["},{"line_number":97,"context_line":"        VPN_ENCRYPTION_ALGORITHM_AES_128_CTR,"},{"line_number":98,"context_line":"        VPN_ENCRYPTION_ALGORITHM_AES_192_CTR,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f03021a_7c69645c","line":95,"updated":"2025-01-14 15:35:07.000000000","message":"the list and new values probably should go into the new extension module?","commit_id":"7358a2fe5e750f4621b574e8babe17a9ae8b02bf"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"c2ca8455f1f8a589bd3e616449458bd21ed35106","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    VPN_ENCRYPTION_ALGORITHM_AES_256_GCM_16,"},{"line_number":93,"context_line":"]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"VPN_SUPPORTED_ENCRYPTION_ALGORITHMS_WITH_CTR \u003d ("},{"line_number":96,"context_line":"    VPN_SUPPORTED_ENCRYPTION_ALGORITHMS + ["},{"line_number":97,"context_line":"        VPN_ENCRYPTION_ALGORITHM_AES_128_CTR,"},{"line_number":98,"context_line":"        VPN_ENCRYPTION_ALGORITHM_AES_192_CTR,"}],"source_content_type":"text/x-python","patch_set":8,"id":"6040b4df_82676062","line":95,"in_reply_to":"1f03021a_7c69645c","updated":"2025-01-14 15:44:58.000000000","message":"moved them","commit_id":"7358a2fe5e750f4621b574e8babe17a9ae8b02bf"}]}