)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4eb1613bcd3a50c2c44f8343105f89c8481d81bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"937dc210_3a26312b","updated":"2024-02-23 14:30:51.000000000","message":"I think it is safe to merge it","commit_id":"fc2f383dd698321f01dc8ec56dff44ba4ec66157"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7a8dd3e9041723f974cf6b129dae760af330cc87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6e40285f_a69061cd","updated":"2024-02-09 12:39:24.000000000","message":"recheck neutron-functional-with-uwsgi","commit_id":"fc2f383dd698321f01dc8ec56dff44ba4ec66157"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fc95b2d881a14c09074b2e50b07a9485c99a5a57","unresolved":true,"context_lines":[{"line_number":1661,"context_line":"  in: query"},{"line_number":1662,"context_line":"  required: false"},{"line_number":1663,"context_line":"  type: string"},{"line_number":1664,"context_line":"subnet-router:external:"},{"line_number":1665,"context_line":"  description: |"},{"line_number":1666,"context_line":"    The membership of a subnet to an external network."},{"line_number":1667,"context_line":"  in: query"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5eb60304_b8b3493a","line":1664,"range":{"start_line":1664,"start_character":0,"end_line":1664,"end_character":22},"updated":"2024-02-08 20:02:21.000000000","message":"Should this be \"subnet-router:external-query\" like the others here?\n\nAnd I\u0027m actually curious if having a colon in the name is a problem instead of \"subnet-router_external-query\"?\n\nActually, looking at the constant for EXTERNAL it says:\n\n# For backward compatibility the \u0027router\u0027 prefix is kept.\nEXTERNAL \u003d \u0027router:external\u0027\n\nSo we could call this field something else, like \"external_network\" ?","commit_id":"0d1fb036cdb3fb279cd10fe1fec5915ff06e03e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"22a4b22b0889f21220b6bef2ef82b62103da7111","unresolved":false,"context_lines":[{"line_number":1661,"context_line":"  in: query"},{"line_number":1662,"context_line":"  required: false"},{"line_number":1663,"context_line":"  type: string"},{"line_number":1664,"context_line":"subnet-router:external:"},{"line_number":1665,"context_line":"  description: |"},{"line_number":1666,"context_line":"    The membership of a subnet to an external network."},{"line_number":1667,"context_line":"  in: query"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa4076f_f1f308b8","line":1664,"range":{"start_line":1664,"start_character":0,"end_line":1664,"end_character":22},"in_reply_to":"09b468bc_89de52f4","updated":"2024-02-12 08:11:54.000000000","message":"No, we are not providing the functionality in the API (nor the CLI). This parameter will be only present in the responses, not the requests.","commit_id":"0d1fb036cdb3fb279cd10fe1fec5915ff06e03e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"300e68a2c5b74d45789a5cf02a7edad7cf342291","unresolved":false,"context_lines":[{"line_number":1661,"context_line":"  in: query"},{"line_number":1662,"context_line":"  required: false"},{"line_number":1663,"context_line":"  type: string"},{"line_number":1664,"context_line":"subnet-router:external:"},{"line_number":1665,"context_line":"  description: |"},{"line_number":1666,"context_line":"    The membership of a subnet to an external network."},{"line_number":1667,"context_line":"  in: query"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8279c5ad_b1374462","line":1664,"range":{"start_line":1664,"start_character":0,"end_line":1664,"end_character":22},"in_reply_to":"5eb60304_b8b3493a","updated":"2024-02-09 09:24:00.000000000","message":"I had the same comment in PS2 but in the opposite direction. I would prefer to keep the same name as in network resource.\n\nThe colon is not a problem for a field that is only in the resource dict.\n\nI need to remove the \"filter\" part from the API. This parameter won\u0027t be in any query, only in the responses (this is why -query is not needed).","commit_id":"0d1fb036cdb3fb279cd10fe1fec5915ff06e03e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bc83233ac37aa359d9a399bec8094792efff838b","unresolved":false,"context_lines":[{"line_number":1661,"context_line":"  in: query"},{"line_number":1662,"context_line":"  required: false"},{"line_number":1663,"context_line":"  type: string"},{"line_number":1664,"context_line":"subnet-router:external:"},{"line_number":1665,"context_line":"  description: |"},{"line_number":1666,"context_line":"    The membership of a subnet to an external network."},{"line_number":1667,"context_line":"  in: query"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"09b468bc_89de52f4","line":1664,"range":{"start_line":1664,"start_character":0,"end_line":1664,"end_character":22},"in_reply_to":"8279c5ad_b1374462","updated":"2024-02-09 23:19:41.000000000","message":"Ok, so there is no way to filter by this property via the API?","commit_id":"0d1fb036cdb3fb279cd10fe1fec5915ff06e03e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fc95b2d881a14c09074b2e50b07a9485c99a5a57","unresolved":true,"context_lines":[{"line_number":1663,"context_line":"  type: string"},{"line_number":1664,"context_line":"subnet-router:external:"},{"line_number":1665,"context_line":"  description: |"},{"line_number":1666,"context_line":"    The membership of a subnet to an external network."},{"line_number":1667,"context_line":"  in: query"},{"line_number":1668,"context_line":"  required: false"},{"line_number":1669,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"382c8fae_9a2d9a32","line":1666,"range":{"start_line":1666,"start_character":4,"end_line":1666,"end_character":54},"updated":"2024-02-08 20:02:21.000000000","message":"As this is a filter, it should look like the others here, something like:\n\n\"Filter the subnet list result based on if the subnet belongs to an external network.\"","commit_id":"0d1fb036cdb3fb279cd10fe1fec5915ff06e03e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"300e68a2c5b74d45789a5cf02a7edad7cf342291","unresolved":false,"context_lines":[{"line_number":1663,"context_line":"  type: string"},{"line_number":1664,"context_line":"subnet-router:external:"},{"line_number":1665,"context_line":"  description: |"},{"line_number":1666,"context_line":"    The membership of a subnet to an external network."},{"line_number":1667,"context_line":"  in: query"},{"line_number":1668,"context_line":"  required: false"},{"line_number":1669,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ca40eaa_2760770a","line":1666,"range":{"start_line":1666,"start_character":4,"end_line":1666,"end_character":54},"in_reply_to":"382c8fae_9a2d9a32","updated":"2024-02-09 09:24:00.000000000","message":"I\u0027ll remove the filter part. This parameter won\u0027t be in any query, only in the responses.","commit_id":"0d1fb036cdb3fb279cd10fe1fec5915ff06e03e2"}],"api-ref/source/v2/samples/subnets/subnets-list-response.json":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"478449accd877ea8573f8ded2f1d6575e8b79df1","unresolved":true,"context_lines":[{"line_number":29,"context_line":"            \"subnetpool_id\": null,"},{"line_number":30,"context_line":"            \"tags\": [\"tag1,tag2\"],"},{"line_number":31,"context_line":"            \"updated_at\": \"2016-10-10T14:35:34Z\","},{"line_number":32,"context_line":"            \"external_network\": false"},{"line_number":33,"context_line":"        },"},{"line_number":34,"context_line":"        {"},{"line_number":35,"context_line":"            \"name\": \"my_subnet\","}],"source_content_type":"application/json","patch_set":2,"id":"4c2cdce8_6b8c9073","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":29},"updated":"2024-02-06 17:59:13.000000000","message":"why not name it the same as it is for \"network\" resource so it would be \"router:external\" there?","commit_id":"e205973482f75bc1bb0d87b6d341b62669ac37e7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0f133fed15ff204d68bc59ccef1a59308937fcea","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            \"subnetpool_id\": null,"},{"line_number":30,"context_line":"            \"tags\": [\"tag1,tag2\"],"},{"line_number":31,"context_line":"            \"updated_at\": \"2016-10-10T14:35:34Z\","},{"line_number":32,"context_line":"            \"external_network\": false"},{"line_number":33,"context_line":"        },"},{"line_number":34,"context_line":"        {"},{"line_number":35,"context_line":"            \"name\": \"my_subnet\","}],"source_content_type":"application/json","patch_set":2,"id":"cdb3c9a9_9cc57bfe","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":29},"in_reply_to":"4c2cdce8_6b8c9073","updated":"2024-02-07 16:16:12.000000000","message":"I was explicitly using a different name because the resource is different, but could be easier to understand if I use \"router:external\".","commit_id":"e205973482f75bc1bb0d87b6d341b62669ac37e7"}],"neutron_lib/api/definitions/subnet_external_network.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4eb1613bcd3a50c2c44f8343105f89c8481d81bc","unresolved":true,"context_lines":[{"line_number":45,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":46,"context_line":"ACTION_MAP \u003d {}"},{"line_number":47,"context_line":"ACTION_STATUS \u003d {}"},{"line_number":48,"context_line":"REQUIRED_EXTENSIONS \u003d []"},{"line_number":49,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"33cccae5_375ab00a","line":48,"updated":"2024-02-23 14:30:51.000000000","message":"nit: extnet_def.ALIAS","commit_id":"fc2f383dd698321f01dc8ec56dff44ba4ec66157"}]}