)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c3f3fe3cbd4d08067adb41b755e81096782981b3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-27 14:48:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[netaddrd\u003e\u003d1.0.0] Do not use netaddr.core.ZEROFILL flag with IPv6"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flag \"netaddr.core.ZEROFILL\" cannot be used with IPv6 addresses"},{"line_number":10,"context_line":"with netaddr\u003e\u003d1.0.0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f53d4e14_2d907193","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":9},"updated":"2024-02-27 20:07:17.000000000","message":"s/netaddr but doesn\u0027t affect content","commit_id":"47607ee02350e5a441dc82e14c8ff3dc7887ff45"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5ad239b68ce13078c1f90cf1e2bfee3a4144b15a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-27 14:48:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[netaddrd\u003e\u003d1.0.0] Do not use netaddr.core.ZEROFILL flag with IPv6"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flag \"netaddr.core.ZEROFILL\" cannot be used with IPv6 addresses"},{"line_number":10,"context_line":"with netaddr\u003e\u003d1.0.0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c08fa4c3_be4cb06c","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":9},"in_reply_to":"f53d4e14_2d907193","updated":"2024-02-29 08:37:34.000000000","message":"Done","commit_id":"47607ee02350e5a441dc82e14c8ff3dc7887ff45"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c015d364253decb66eb7d14cf1b88e717172811b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"95f9411b_9aead2e9","updated":"2024-03-01 05:34:30.000000000","message":"recheck functional shy ports","commit_id":"3a9e39b9ef4d73cc60b534411bc5255e7d280bef"}],"neutron_lib/api/validators/__init__.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cb7195ff03c21508a0c2e050050bbac799b7e650","unresolved":true,"context_lines":[{"line_number":443,"context_line":"    msg \u003d None"},{"line_number":444,"context_line":"    msg_data \u003d data"},{"line_number":445,"context_line":"    try:"},{"line_number":446,"context_line":"        try:"},{"line_number":447,"context_line":"            # netaddr.core.ZEROFILL is only applicable to IPv4."},{"line_number":448,"context_line":"            # it will remove leading zeros from IPv4 address octets."},{"line_number":449,"context_line":"            ip \u003d netaddr.IPAddress(validate_no_whitespace(data),"},{"line_number":450,"context_line":"                                   flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":451,"context_line":"        except ValueError:"},{"line_number":452,"context_line":"            # It could be an IPv6 address and netaddr.core.ZEROFILL flag"},{"line_number":453,"context_line":"            # cannot be used in netaddr\u003e\u003d1.0.0"},{"line_number":454,"context_line":"            ip \u003d netaddr.IPAddress(validate_no_whitespace(data))"},{"line_number":455,"context_line":"        # The followings are quick checks for IPv6 (has \u0027:\u0027) and"},{"line_number":456,"context_line":"        # IPv4.  (has 3 periods like \u0027xx.xx.xx.xx\u0027)"},{"line_number":457,"context_line":"        # NOTE(yamamoto): netaddr uses libraries provided by the underlying"}],"source_content_type":"text/x-python","patch_set":3,"id":"86bc61bd_45bfa4fb","line":454,"range":{"start_line":446,"start_character":0,"end_line":454,"end_character":64},"updated":"2024-02-29 09:37:19.000000000","message":"I prefer if-else, but I see this is the simplest for this check","commit_id":"3a9e39b9ef4d73cc60b534411bc5255e7d280bef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e6ec6e4317e062deb5553ac44dcafc4de7e814b2","unresolved":false,"context_lines":[{"line_number":443,"context_line":"    msg \u003d None"},{"line_number":444,"context_line":"    msg_data \u003d data"},{"line_number":445,"context_line":"    try:"},{"line_number":446,"context_line":"        try:"},{"line_number":447,"context_line":"            # netaddr.core.ZEROFILL is only applicable to IPv4."},{"line_number":448,"context_line":"            # it will remove leading zeros from IPv4 address octets."},{"line_number":449,"context_line":"            ip \u003d netaddr.IPAddress(validate_no_whitespace(data),"},{"line_number":450,"context_line":"                                   flags\u003dnetaddr.core.ZEROFILL)"},{"line_number":451,"context_line":"        except ValueError:"},{"line_number":452,"context_line":"            # It could be an IPv6 address and netaddr.core.ZEROFILL flag"},{"line_number":453,"context_line":"            # cannot be used in netaddr\u003e\u003d1.0.0"},{"line_number":454,"context_line":"            ip \u003d netaddr.IPAddress(validate_no_whitespace(data))"},{"line_number":455,"context_line":"        # The followings are quick checks for IPv6 (has \u0027:\u0027) and"},{"line_number":456,"context_line":"        # IPv4.  (has 3 periods like \u0027xx.xx.xx.xx\u0027)"},{"line_number":457,"context_line":"        # NOTE(yamamoto): netaddr uses libraries provided by the underlying"}],"source_content_type":"text/x-python","patch_set":3,"id":"a4ad25b5_6ef37727","line":454,"range":{"start_line":446,"start_character":0,"end_line":454,"end_character":64},"in_reply_to":"86bc61bd_45bfa4fb","updated":"2024-02-29 10:01:14.000000000","message":"Yes... but not in Python [1]. I don\u0027t like to code by exception but it works better in Python. And there is another problem there: I don\u0027t have a method to check if the IP is 4 or 6; there is one, but to be called after this validation.\n\n[1]https://switowski.com/blog/ask-for-permission-or-look-before-you-leap/","commit_id":"3a9e39b9ef4d73cc60b534411bc5255e7d280bef"}]}