)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3b465dce2cd403daf9e96ee649212a70895b3c27","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add initial mypy tooling for type annotations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"FIXME: update this commit message"},{"line_number":10,"context_line":"In the last PTG meeting we have decided to try enabling"},{"line_number":11,"context_line":"type checking in our codebase. Neutron-lib was chosen as"},{"line_number":12,"context_line":"a good candidate to try this out."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ac1e76ff_8bbe4e97","line":9,"updated":"2024-06-06 21:55:12.000000000","message":"Could you please add a CI job to run this in the check pipeline, first non-voting, eventually we\u0027d switch to voting once sure it\u0027s stable? Thanks.","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d23f1ccfa9f0d65bb19fd242e42430e744342a4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b2f23c8_299373e5","updated":"2024-06-07 01:27:03.000000000","message":"I\u0027m collecting pieces that I think are needed to make this patch complete for merge here: https://review.opendev.org/c/openstack/neutron-lib/+/921483 Feel free to squash it in here if you agree these are appropriate changes.","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3635cd9b3fe32c64ed3342740b263746b986e2c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0609ba7_cc8a60f0","updated":"2024-06-26 06:03:35.000000000","message":"If you want this patch to be part of the next library freeze (Jul 4), please address the comments.","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c2eb0860cb4b4ac3fea603ed1845e6d7bc9c5641","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ec809a8_739a007e","updated":"2024-08-30 14:54:52.000000000","message":"Is this going anywhere? Thought we\u0027ll try to make dent on this in this cycle, but I guess no?","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5a074cc9c9eea1223ded6baaf7c6e4ed778c5e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ebf433ef_27030fa2","updated":"2024-06-06 21:54:29.000000000","message":"What keeps it WIP?","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"}],"mypy.ini":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"42e3e46950e2d0e90257bbe1b247812d340419a1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87ad58b7_8a2da105","updated":"2024-05-16 08:31:04.000000000","message":"Note this can be integrated to setup.cfg as well. https://review.opendev.org/c/openstack/octavia/+/879749/67/setup.cfg","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5a074cc9c9eea1223ded6baaf7c6e4ed778c5e7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7df3df19_1959166c","in_reply_to":"158bca12_d2f22cfe","updated":"2024-06-06 21:54:29.000000000","message":"We may transition to pyproject.toml in the future, in which case it can as well go there. I don\u0027t think it\u0027s important where it is right now. Let\u0027s get the ball rolling.","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"1220713a329eaa988c4af93d41329a55e528b1fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e03546a1_c3d870a9","in_reply_to":"7df3df19_1959166c","updated":"2024-09-11 17:15:16.000000000","message":"Marking as resolved. Not really important.","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"badec823b98f031ca62f251611d46236af203fb2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"158bca12_d2f22cfe","in_reply_to":"87ad58b7_8a2da105","updated":"2024-05-21 02:22:55.000000000","message":"Yep I saw that when I was referencing the config_file documentation [1]. But for experimental purposes I decided it will be cleaner to leave it in the dedicated file. I will decide later what to do with it\n\n[1] https://mypy.readthedocs.io/en/stable/config_file.html","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9ef368393c4c09af2002fcca818cd4d7777f25f5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Config file options: https://mypy.readthedocs.io/en/stable/config_file.html"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[mypy]"},{"line_number":4,"context_line":"check_untyped_defs \u003d True"},{"line_number":5,"context_line":"disallow_untyped_defs \u003d True"},{"line_number":6,"context_line":"incremental \u003d True"},{"line_number":7,"context_line":"pretty \u003d True"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5917b8d7_7b7781be","line":4,"updated":"2024-06-07 01:01:37.000000000","message":"we should start with just enabling mypy for all modules and fixing violations it can already catch regardless of type definitions for functions; then we can start enforcing some of these rules for typed definitions. Please remove lines 4-5.","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5a074cc9c9eea1223ded6baaf7c6e4ed778c5e7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# and rules applied to the whole repo"},{"line_number":15,"context_line":"# packages \u003d"},{"line_number":16,"context_line":"#     neutron_lib.agent"},{"line_number":17,"context_line":"files \u003d"},{"line_number":18,"context_line":"    neutron_lib/agent/extension.py"}],"source_content_type":"text/x-properties","patch_set":3,"id":"18302aa7_640f733b","line":17,"updated":"2024-06-06 21:54:29.000000000","message":"can we go vice versa - list all files as `excludes` regexes, then we are sure that new files won\u0027t be introduced with type violations.","commit_id":"4bd1b40073a2128216a8cd53006826440aab79b5"}]}