)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8de84ffe6661d7abdb139b61f0f7df04827efafe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03e72c97_1ae3d459","updated":"2024-08-01 17:09:50.000000000","message":"I\u0027m still not sure this is correct just based on other projects usage (which is very little), but it did find a missing blank line after a docstring:\n\n/home/zuul/src/opendev.org/openstack/neutron-lib/neutron_lib/placement/utils.py:docstring of neutron_lib.placement.utils.parse_rp_bandwidths:13:Definition list ends without a blank line; unexpected unindent.","commit_id":"0cf152a00a57ace5227d62b7a50694aee76ea86e"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"d0f085a90a873d1fe5a7d319905b1edf337573cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8bfff58e_8c866ec9","in_reply_to":"03e72c97_1ae3d459","updated":"2024-08-01 17:45:09.000000000","message":"There were quite a few more in my testing:\n\n```\n/neutron-lib/neutron_lib/placement/utils.py:docstring of neutron_lib.placement.utils.parse_rp_bandwidths:13: WARNING: Definition list ends without a blank line; unexpected unindent.\n/neutron-lib/neutron_lib/placement/utils.py:docstring of neutron_lib.placement.utils.parse_rp_inventory_defaults:11: WARNING: Definition list ends without a blank line; unexpected unindent.\n/neutron-lib/neutron_lib/placement/utils.py:docstring of neutron_lib.placement.utils.parse_rp_inventory_defaults:16: WARNING: Definition list ends without a blank line; unexpected unindent.\n/neutron-lib/neutron_lib/placement/utils.py:docstring of neutron_lib.placement.utils.parse_rp_pp_with_direction:15: WARNING: Definition list ends without a blank line; unexpected unindent.\nlooking for now-outdated files... none found\n/neutron-lib/neutron_lib/placement/utils.py:docstring of neutron_lib.placement.utils.parse_rp_pp_without_direction:14: WARNING: Definition list ends without a blank line; unexpected unindent.\n```","commit_id":"0cf152a00a57ace5227d62b7a50694aee76ea86e"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"4777b9b5e6dded0987f068642e32125d1a1a6ef9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5197513_f4ee4c4d","in_reply_to":"8bfff58e_8c866ec9","updated":"2024-08-15 13:28:25.000000000","message":"Done","commit_id":"0cf152a00a57ace5227d62b7a50694aee76ea86e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3d7020457e8d29e3b0924d93b78147d653edc863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a9a9204_27487582","updated":"2024-08-09 07:05:15.000000000","message":"Thanks","commit_id":"8cf30e80859702c317447bbb95f22ed7bacb1105"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b446829e057066f16be2ddb6925231749cb061ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27377b36_36095943","updated":"2024-08-05 10:59:52.000000000","message":"is this something that affects other projects like Neutron?","commit_id":"8cf30e80859702c317447bbb95f22ed7bacb1105"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"f5f5e5667ca2cc3a5e1374e693f8b824ffe44fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"253be41b_9c5b2ef6","in_reply_to":"27377b36_36095943","updated":"2024-08-07 14:05:50.000000000","message":"Looks like the python module documentation for Neutron was never created, so I\u0027d say no.\n\n reference:\n\n https://docs.openstack.org/neutron/latest/contributor/modules.html","commit_id":"8cf30e80859702c317447bbb95f22ed7bacb1105"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"efa4e16416709e48f7136428ed62012e6bc54917","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"64f0ec88_b2fc028d","updated":"2024-08-14 18:13:34.000000000","message":"Thanks for the update, some additional questions","commit_id":"f04bfd3e2c23e2bb656be289b9ce4c959ce40d9a"}],"doc/source/conf.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"efa4e16416709e48f7136428ed62012e6bc54917","unresolved":true,"context_lines":[{"line_number":242,"context_line":"    \u0027db/resource_extend.py\u0027,"},{"line_number":243,"context_line":"    \u0027db/sqlalchemytypes.py\u0027,"},{"line_number":244,"context_line":"    \u0027fixture.py\u0027,"},{"line_number":245,"context_line":"    \u0027hacking\u0027,"},{"line_number":246,"context_line":"    \u0027tests/*\u0027,"},{"line_number":247,"context_line":"]"},{"line_number":248,"context_line":"apidoc_separate_modules \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"a88d5cfa_ebd152cc","line":245,"updated":"2024-08-14 18:13:34.000000000","message":"This should be hacking/* right?","commit_id":"f04bfd3e2c23e2bb656be289b9ce4c959ce40d9a"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"9b85079d23bdec92a4eb34b7da48eab7dc7bb96f","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    \u0027db/resource_extend.py\u0027,"},{"line_number":243,"context_line":"    \u0027db/sqlalchemytypes.py\u0027,"},{"line_number":244,"context_line":"    \u0027fixture.py\u0027,"},{"line_number":245,"context_line":"    \u0027hacking\u0027,"},{"line_number":246,"context_line":"    \u0027tests/*\u0027,"},{"line_number":247,"context_line":"]"},{"line_number":248,"context_line":"apidoc_separate_modules \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb58538e_54c81a2c","line":245,"in_reply_to":"a88d5cfa_ebd152cc","updated":"2024-08-15 13:28:11.000000000","message":"the `hacking` alone would simply exclude the folder, but I have changed it to `hacking/*` for consistency as requested.","commit_id":"f04bfd3e2c23e2bb656be289b9ce4c959ce40d9a"}],"doc/source/index.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"efa4e16416709e48f7136428ed62012e6bc54917","unresolved":true,"context_lines":[{"line_number":51,"context_line":"      :maxdepth: 1"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"      reference/index"},{"line_number":54,"context_line":"      neutron_lib package \u003creference/modules/modules\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ee737653_f9da045e","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":25},"updated":"2024-08-14 18:13:34.000000000","message":"Should this be \u0027Package Reference\u0027 or \u0027API Package Reference\u0027 ? The one above has a heading \u0027Module Reference\u0027 but I couldn\u0027t find anything similar in other projects.","commit_id":"f04bfd3e2c23e2bb656be289b9ce4c959ce40d9a"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"9b85079d23bdec92a4eb34b7da48eab7dc7bb96f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      :maxdepth: 1"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"      reference/index"},{"line_number":54,"context_line":"      neutron_lib package \u003creference/modules/modules\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c2ada5f2_de92e77b","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":25},"in_reply_to":"ee737653_f9da045e","updated":"2024-08-15 13:28:11.000000000","message":"changed to \u0027Package Reference\u0027","commit_id":"f04bfd3e2c23e2bb656be289b9ce4c959ce40d9a"}],"tox.ini":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1bdaa7c4b6742b66019f41b840065fbc83a99992","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  sphinx-apidoc --remove-old -o doc/source/reference/modules neutron_lib/ neutron_lib/tests neutron_lib/fixture.py neutron_lib/db/resource_extend.py neutron_lib/hacking"},{"line_number":58,"context_line":"  sphinx-build -b html doc/source doc/build/html"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:pdf-docs]"},{"line_number":61,"context_line":"deps \u003d {[testenv:docs]deps}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"599e9b75_5e374fee","line":58,"updated":"2024-08-14 13:22:45.000000000","message":"I don\u0027t think we want to remove the -W here:\n\n  -W                turn warnings into errors\n\nSeems it should help not allowing us merge docs that are broken.\n\nWas there a a reason it was removed?","commit_id":"8cf30e80859702c317447bbb95f22ed7bacb1105"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"9c11e5c8f1f04201bd8816f91315c1a64ee27d8d","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  sphinx-apidoc --remove-old -o doc/source/reference/modules neutron_lib/ neutron_lib/tests neutron_lib/fixture.py neutron_lib/db/resource_extend.py neutron_lib/hacking"},{"line_number":58,"context_line":"  sphinx-build -b html doc/source doc/build/html"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:pdf-docs]"},{"line_number":61,"context_line":"deps \u003d {[testenv:docs]deps}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5d531f9b_84ad0c4f","line":58,"in_reply_to":"599e9b75_5e374fee","updated":"2024-08-14 13:41:19.000000000","message":"Yes, there is a reason why this was removed - there are a bunch of functions that produce warnings (see my response to your comment in https://review.opendev.org/c/openstack/neutron-lib/+/925503/comments/03e72c97_1ae3d459) and until they are fixed, build simply fails.\n\nI figured that 95% working documentation is better than 0% documentation.\n\n\u003e Seems it should help not allowing us merge docs that are broken.\n\nIt didn\u0027t in the past, they are all broken/inaccessible atm, hence this PR.\n\nWould you prefer me to try to fix the broken docstrings instead?","commit_id":"8cf30e80859702c317447bbb95f22ed7bacb1105"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"851c15c4bcaddafa35cd80a378d90b07a450104e","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  sphinx-apidoc --remove-old -o doc/source/reference/modules neutron_lib/ neutron_lib/tests neutron_lib/fixture.py neutron_lib/db/resource_extend.py neutron_lib/hacking"},{"line_number":58,"context_line":"  sphinx-build -b html doc/source doc/build/html"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:pdf-docs]"},{"line_number":61,"context_line":"deps \u003d {[testenv:docs]deps}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"f046bd11_207b0798","line":58,"in_reply_to":"5d531f9b_84ad0c4f","updated":"2024-08-14 13:48:14.000000000","message":"Yes, please fix the warnings since they all seemed to be missing blank lines or indentations that are probably impacting the layouts of the generated docs.","commit_id":"8cf30e80859702c317447bbb95f22ed7bacb1105"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"4777b9b5e6dded0987f068642e32125d1a1a6ef9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  sphinx-apidoc --remove-old -o doc/source/reference/modules neutron_lib/ neutron_lib/tests neutron_lib/fixture.py neutron_lib/db/resource_extend.py neutron_lib/hacking"},{"line_number":58,"context_line":"  sphinx-build -b html doc/source doc/build/html"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:pdf-docs]"},{"line_number":61,"context_line":"deps \u003d {[testenv:docs]deps}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9795f3ae_ee14f3b8","line":58,"in_reply_to":"90cabc54_68be6dab","updated":"2024-08-15 13:28:25.000000000","message":"Done","commit_id":"8cf30e80859702c317447bbb95f22ed7bacb1105"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"5972ee174b290228d03f2825ce27e68e40a2cc74","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  sphinx-apidoc --remove-old -o doc/source/reference/modules neutron_lib/ neutron_lib/tests neutron_lib/fixture.py neutron_lib/db/resource_extend.py neutron_lib/hacking"},{"line_number":58,"context_line":"  sphinx-build -b html doc/source doc/build/html"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:pdf-docs]"},{"line_number":61,"context_line":"deps \u003d {[testenv:docs]deps}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"90cabc54_68be6dab","line":58,"in_reply_to":"f046bd11_207b0798","updated":"2024-08-14 15:47:45.000000000","message":"Fixed the warnings for blank lines as requested. I have also enabled `sphinxcontrib.apidoc` that removes the need to run separate commands through tox (this is how the keystone project does it too). \n\nThe error-on-warning flag has been restored to its original setting.","commit_id":"8cf30e80859702c317447bbb95f22ed7bacb1105"}]}