)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"08ebf948b5dc55a576599390d6ba3ccc14f087ef","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Slawek Kaplonski \u003cskaplons@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-05 09:33:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add definition of the \u0027qinq\u0027 api extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This new extension allows to enable QinQ VLAN type for the networks."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d64c71d5_5c139898","line":7,"updated":"2024-12-18 22:16:05.000000000","message":"(No action required; Commentary for posterity)\n\nThis was merged and I don\u0027t want to derail any work, but I will note that QinQ means Q-tag-in-Q-tag where Q is 802.1q tag (0x8100); what is proposed here is 802.1ad double tagging (where different ethertypes are used for outer and inner tags).\n\nQinQ is an ambiguous term that is used by different vendors to refer to one or another. The updated RFC for VLAN tagging is often referred to as QinQ, and that\u0027s what it means here in the proposed extension. On the other hand, Cisco still refers to double-0x8100 as QinQ (and allows to set a \"custom\" ethertype for outer tag if needed).\n\nSo I have some reservations about this naming here. It may be a source of confusion in the future. Unclear though - which less ambiguous name we could pick that would not be as ugly as e.g. `vlan_transparent_rfc`...)","commit_id":"8396d75b31ea4ac4622de1b64b77ab8dfb8ac2e1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"246ba28363ec452d54bce836e0826dcff9f0b1f0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Slawek Kaplonski \u003cskaplons@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-05 09:33:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add definition of the \u0027qinq\u0027 api extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This new extension allows to enable QinQ VLAN type for the networks."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"26907e55_9c23b58f","line":7,"in_reply_to":"5f2e0165_d43b905d","updated":"2025-01-21 14:32:04.000000000","message":"❤️","commit_id":"8396d75b31ea4ac4622de1b64b77ab8dfb8ac2e1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"781827607d671bcf5a894586f83e6c8f89f3677d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Slawek Kaplonski \u003cskaplons@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-05 09:33:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add definition of the \u0027qinq\u0027 api extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This new extension allows to enable QinQ VLAN type for the networks."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f2e0165_d43b905d","line":7,"in_reply_to":"d64c71d5_5c139898","updated":"2025-01-21 11:44:46.000000000","message":"I proposed follow up https://review.opendev.org/c/openstack/neutron-lib/+/939708 to explain it a bit better. I hope it is good for you 😊","commit_id":"8396d75b31ea4ac4622de1b64b77ab8dfb8ac2e1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52743e46a88c6130ba57914a60a741a5e43e4f22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5c319dc_56195ec9","updated":"2024-12-04 22:00:12.000000000","message":"There was one typo, added nits once I saw it, otherwise looks good","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"91c0adbc1e79be3bca6f2b5346301fe92c2044dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dcde4680_74d5d813","updated":"2024-12-04 16:05:11.000000000","message":"recheck - unrelated issue while deploying horizon","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86cd08444d4215f8d7fc928deebfc1e41f89540a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c43e277_9469bb18","updated":"2024-12-05 09:41:21.000000000","message":"Similar to the ``vlan_transparent`` extension definition.","commit_id":"8396d75b31ea4ac4622de1b64b77ab8dfb8ac2e1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"45a8f77682188a9268d4c6b03c2b62cc22b85851","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4076147b_7b87aa49","updated":"2024-12-06 10:34:51.000000000","message":"recheck\nfunctional is fixed by https://review.opendev.org/c/openstack/neutron/+/937106","commit_id":"8396d75b31ea4ac4622de1b64b77ab8dfb8ac2e1"}],"api-ref/source/v2/networks.inc":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52743e46a88c6130ba57914a60a741a5e43e4f22","unresolved":true,"context_lines":[{"line_number":115,"context_line":"child objects of a network upon its deletion."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"QinQ"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":"The ``qinq`` extension adds the ``qinq`` boolean attribute which allows to"},{"line_number":120,"context_line":"control the VLAN QinQ (vlan in vlan) of the network. It uses ``0x8a88`` ethertype for"},{"line_number":121,"context_line":"the double tagged packets. If the service does not support VLAN QinQ and a user"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"b7e0082d_b1c1f519","line":118,"updated":"2024-12-04 22:00:12.000000000","message":"nit: missing blank line","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ebbe11cd8fde0a901e075d15b35bf9592688121","unresolved":false,"context_lines":[{"line_number":115,"context_line":"child objects of a network upon its deletion."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"QinQ"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":"The ``qinq`` extension adds the ``qinq`` boolean attribute which allows to"},{"line_number":120,"context_line":"control the VLAN QinQ (vlan in vlan) of the network. It uses ``0x8a88`` ethertype for"},{"line_number":121,"context_line":"the double tagged packets. If the service does not support VLAN QinQ and a user"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"a763dccf_09cd5659","line":118,"in_reply_to":"b7e0082d_b1c1f519","updated":"2024-12-05 09:33:53.000000000","message":"Done","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"}],"releasenotes/notes/QinQ-API-extension-a7b95d0a7a35411c.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52743e46a88c6130ba57914a60a741a5e43e4f22","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c8200434_dcf2c0c6","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":32},"updated":"2024-12-04 22:00:12.000000000","message":"s/adds a","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52743e46a88c6130ba57914a60a741a5e43e4f22","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7c26df8e_52605b30","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":27},"updated":"2024-12-04 22:00:12.000000000","message":"s/extension","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ebbe11cd8fde0a901e075d15b35bf9592688121","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"62a78c06_39ee37a2","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":27},"in_reply_to":"7c26df8e_52605b30","updated":"2024-12-05 09:33:53.000000000","message":"Done","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ebbe11cd8fde0a901e075d15b35bf9592688121","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"709ef315_8fbda394","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":32},"in_reply_to":"c8200434_dcf2c0c6","updated":"2024-12-05 09:33:53.000000000","message":"Done","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52743e46a88c6130ba57914a60a741a5e43e4f22","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."},{"line_number":8,"context_line":"    Attributes ``qinq`` and ``vlan_transparent`` can\u0027t be used together"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9044434f_a6da8ddd","line":5,"range":{"start_line":5,"start_character":45,"end_line":5,"end_character":55},"updated":"2024-12-04 22:00:12.000000000","message":"s/in a similar","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52743e46a88c6130ba57914a60a741a5e43e4f22","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."},{"line_number":8,"context_line":"    Attributes ``qinq`` and ``vlan_transparent`` can\u0027t be used together"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"31d4eace_9e10f590","line":5,"range":{"start_line":5,"start_character":60,"end_line":5,"end_character":64},"updated":"2024-12-04 22:00:12.000000000","message":"s/to","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ebbe11cd8fde0a901e075d15b35bf9592688121","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."},{"line_number":8,"context_line":"    Attributes ``qinq`` and ``vlan_transparent`` can\u0027t be used together"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"186c4acc_1cab33ef","line":5,"range":{"start_line":5,"start_character":60,"end_line":5,"end_character":64},"in_reply_to":"31d4eace_9e10f590","updated":"2024-12-05 09:33:53.000000000","message":"Done","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ebbe11cd8fde0a901e075d15b35bf9592688121","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."},{"line_number":8,"context_line":"    Attributes ``qinq`` and ``vlan_transparent`` can\u0027t be used together"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4141ed70_5efb11de","line":5,"range":{"start_line":5,"start_character":45,"end_line":5,"end_character":55},"in_reply_to":"9044434f_a6da8ddd","updated":"2024-12-05 09:33:53.000000000","message":"Done","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52743e46a88c6130ba57914a60a741a5e43e4f22","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."},{"line_number":8,"context_line":"    Attributes ``qinq`` and ``vlan_transparent`` can\u0027t be used together"},{"line_number":9,"context_line":"    for the same network."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f6235906_5b3218d1","line":6,"range":{"start_line":6,"start_character":5,"end_line":6,"end_character":21},"updated":"2024-12-04 22:00:12.000000000","message":"nit: double `` around this","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ebbe11cd8fde0a901e075d15b35bf9592688121","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``qinq`` extenstion adds ``qinq`` attribute to the network"},{"line_number":5,"context_line":"    resource. This new attribute can be used in similar way like"},{"line_number":6,"context_line":"    `vlan_transparent` but networks created with ``qinq`` set will use"},{"line_number":7,"context_line":"    ``0x8a88`` ethertype for the double vlan tagged traffic."},{"line_number":8,"context_line":"    Attributes ``qinq`` and ``vlan_transparent`` can\u0027t be used together"},{"line_number":9,"context_line":"    for the same network."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c62b48ab_089d4d8e","line":6,"range":{"start_line":6,"start_character":5,"end_line":6,"end_character":21},"in_reply_to":"f6235906_5b3218d1","updated":"2024-12-05 09:33:53.000000000","message":"Done","commit_id":"1bf336763c41895426c276e5c4e79bab002868c5"}]}