)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"940be83f742a5f8803bb42d7b51dcf08e50dfc3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6aa6206c_76fdaf93","updated":"2025-05-21 13:36:19.000000000","message":"As commented in the Neutron channel, the pylint checks are missing","commit_id":"4e5abfc68b3ec81b16f3ac86f60f5da57c8dd887"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bdb7b55d98c9ecbab7db1f1bb9dd5dfbd5f6631f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4e9f2e4a_726cdc7e","in_reply_to":"6aa6206c_76fdaf93","updated":"2025-05-21 16:44:21.000000000","message":"Fixed","commit_id":"4e5abfc68b3ec81b16f3ac86f60f5da57c8dd887"}],"test-requirements.txt":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d2906e1b6594bcd8c746d785e40160466b6e1e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"hacking\u003e\u003d6.1.0,\u003c6.2.0 # Apache-2.0"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":4,"context_line":"coverage\u003e\u003d4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"d441f2d4_ffbe8548","side":"PARENT","line":1,"updated":"2025-05-21 16:47:34.000000000","message":"We need to keep this since we import from it for our custom checks.","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d2906e1b6594bcd8c746d785e40160466b6e1e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"hacking\u003e\u003d6.1.0,\u003c6.2.0 # Apache-2.0"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":4,"context_line":"coverage\u003e\u003d4.0 # Apache-2.0"},{"line_number":5,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":6,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":7,"context_line":"flake8-import-order\u003e\u003d0.18.0,\u003c0.19.0 # LGPLv3"}],"source_content_type":"text/plain","patch_set":3,"id":"deb6d1b5_6fc7bfc2","side":"PARENT","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":26},"updated":"2025-05-21 16:47:34.000000000","message":"This is a linter and a \"test runner\" of sort which we don\u0027t need to run our tests.","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d2906e1b6594bcd8c746d785e40160466b6e1e7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"coverage\u003e\u003d4.0 # Apache-2.0"},{"line_number":5,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":6,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":7,"context_line":"flake8-import-order\u003e\u003d0.18.0,\u003c0.19.0 # LGPLv3"},{"line_number":8,"context_line":"pylint\u003e\u003d2.2.0 # GPLv2"},{"line_number":9,"context_line":"isort\u003d\u003d4.3.21 # MIT"},{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"123f060b_36057a94","side":"PARENT","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":19},"updated":"2025-05-21 16:47:34.000000000","message":"ditto","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d2906e1b6594bcd8c746d785e40160466b6e1e7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"flake8-import-order\u003e\u003d0.18.0,\u003c0.19.0 # LGPLv3"},{"line_number":8,"context_line":"pylint\u003e\u003d2.2.0 # GPLv2"},{"line_number":9,"context_line":"isort\u003d\u003d4.3.21 # MIT"},{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":3,"id":"ae0770d0_cdc5067f","side":"PARENT","line":10,"updated":"2025-05-21 16:47:34.000000000","message":"this is not used anywhere and shouldn\u0027t be here","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d2906e1b6594bcd8c746d785e40160466b6e1e7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"34e9255d_61a85cc0","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"updated":"2025-05-21 16:47:34.000000000","message":"ditto","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3783ce0809e851709c21080efea8125d751a2bb7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"fdd7f43f_35da165f","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"02ff6ce7_920d0c53","updated":"2025-06-03 14:30:53.000000000","message":"Nevermind, I don\u0027t think we use them in n-lib repository. In that case, we don\u0027t need them here.","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ba937b1d335430cecea5c483ffecc0037674f83","unresolved":true,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"8efd2c64_aadcbee0","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"16ce4cba_8b8a5a1b","updated":"2025-05-22 10:25:55.000000000","message":"Sure, I can revert this. Shouldn\u0027t it be a dependency of those CI frameworks though? Transitive dependencies are a bad idea.","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"08d96d40a3848b5f79f3e628d901d68ad4ba8ad8","unresolved":true,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"16ce4cba_8b8a5a1b","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"34e9255d_61a85cc0","updated":"2025-05-22 06:05:44.000000000","message":"We still import testscenarios in the Neutron CI frameworks","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0d9ffc190ffcd0f13d491fde852fbf87f66ff4d5","unresolved":true,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"e96f06fc_ce474dd2","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"73221924_11640fb9","updated":"2025-05-22 10:53:10.000000000","message":"Hmm now I see you are removing ddt in the next patch...","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d4d88e4b1864e311925068d51bee46db5884b9c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"af15fe39_d75adcb5","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"7fd8fcc2_dd141dc2","updated":"2025-05-26 13:18:26.000000000","message":"Ah, I understand the problem now. We are importing from `neutron.testing` and the dependencies are used _there_. Hmm, tricky.","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"06dfb13cd30591b51735763c07160256eef767c0","unresolved":true,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"73221924_11640fb9","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"8efd2c64_aadcbee0","updated":"2025-05-22 10:52:30.000000000","message":"But we are explicitly using a functionality that is not implemented in the base test case class (that inherits from testtools). We can instead use ddt but that will take some time to migrate these test cases.","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"26548f7981ba41b43c6d5ccae4f618ae00a31da4","unresolved":true,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"02ff6ce7_920d0c53","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"af15fe39_d75adcb5","updated":"2025-05-26 13:22:14.000000000","message":"Actually, no, we\u0027re not. Not here anyway. We do import from there in e.g. `neutron-fwaas` but not here. I\u0027m still confused 😄","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"31e3223cae7a2c8356fc0475b3876a9fd16b2f6f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"},{"line_number":15,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"7fd8fcc2_dd141dc2","side":"PARENT","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"e96f06fc_ce474dd2","updated":"2025-05-26 11:35:39.000000000","message":"\u003e But we are explicitly using a functionality that is not implemented in the base test case class (that inherits from testtools)\n\nJust to make sure I understand you correctly, are we using this functionality in neutron-lib itself? If so, where (I searched for \"scenario\" and didn\u0027t find anything. Also, the tests are passing). If not, can\u0027t the projects that *are* using it simply add `testscenarios` to their own `test-requirements.txt` files (which IMO they should already be doing)?","commit_id":"de53d622a2f564bbb671a964f2c07f7a758cfe94"}]}