)]}'
{"neutron_lib/api/definitions/evpn.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b085d38c160668fe5b2aeb63fe6f3b330392a83e","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":52,"context_line":"ACTION_MAP \u003d {}"},{"line_number":53,"context_line":"REQUIRED_EXTENSIONS \u003d [l3.ALIAS]"}],"source_content_type":"text/x-python","patch_set":1,"id":"8557e5c1_544b03e5","line":50,"updated":"2026-04-29 07:52:53.000000000","message":"Shouldn\u0027t we also add `advertise_host` in the `add_router_interface` API [1]? If we load this `evpn` extension, we would like both fields, right?\n\n[1]https://review.opendev.org/c/openstack/neutron-specs/+/982256/11/specs/2026.2/bgp_evpn_type_5_route_support.rst#319","commit_id":"da830e15004bf39d91607110478ce483cb92e46f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dcab9921240d786ba6b9013ac560663f4194f56f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":52,"context_line":"ACTION_MAP \u003d {}"},{"line_number":53,"context_line":"REQUIRED_EXTENSIONS \u003d [l3.ALIAS]"}],"source_content_type":"text/x-python","patch_set":1,"id":"8abf64ce_cc4cec67","line":50,"in_reply_to":"03184ba6_45392972","updated":"2026-04-30 13:55:10.000000000","message":"Done","commit_id":"da830e15004bf39d91607110478ce483cb92e46f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"854a10c5c349dd9e04cb45833360c8b0ba0db75a","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":52,"context_line":"ACTION_MAP \u003d {}"},{"line_number":53,"context_line":"REQUIRED_EXTENSIONS \u003d [l3.ALIAS]"}],"source_content_type":"text/x-python","patch_set":1,"id":"37d10f32_ef24a55a","line":50,"in_reply_to":"1dc87828_163aa1aa","updated":"2026-04-29 14:57:21.000000000","message":"\"this documentation\" you mean I should make a comment here about it?","commit_id":"da830e15004bf39d91607110478ce483cb92e46f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb26d65d3030eba6b58faae19d69758752bcbf2b","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":52,"context_line":"ACTION_MAP \u003d {}"},{"line_number":53,"context_line":"REQUIRED_EXTENSIONS \u003d [l3.ALIAS]"}],"source_content_type":"text/x-python","patch_set":1,"id":"03184ba6_45392972","line":50,"in_reply_to":"37d10f32_ef24a55a","updated":"2026-04-30 06:53:11.000000000","message":"I\u0027ll add here what I wrote in Slack.\n\nHere (https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/routers.inc#add-interface-to-router) we have the documentation of the add_router_interface command. That should also refer the new advertise_host field.\n\nThere is no schema, no RESOURCE_ATTRIBUTE_MAP-style definition that formally declares what parameters are accepted. This is the pattern for all ACTION_MAP member actions in Neutron -- they all bypass the framework\u0027s declarative parameter validation and handle raw JSON in code.","commit_id":"da830e15004bf39d91607110478ce483cb92e46f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ec3c78f57f37c41dadabd6f68c5ff8b903b9552f","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":52,"context_line":"ACTION_MAP \u003d {}"},{"line_number":53,"context_line":"REQUIRED_EXTENSIONS \u003d [l3.ALIAS]"}],"source_content_type":"text/x-python","patch_set":1,"id":"d72b1769_d34522d7","line":50,"in_reply_to":"8557e5c1_544b03e5","updated":"2026-04-29 14:02:15.000000000","message":"That\u0027s what I tried to explain in the commit with \"As the L3\nextension add_router_interface method does not have any schema,\nthere was not change required to the API and the --advertise-as-host\nattribute will be taken on the plugin level.\"\n\nDo you think I should reword it to make it more clear. The thing is that how the current api is designed, you can pass really anything to the body of add_router_interface and let the plugins use whatever they need.","commit_id":"da830e15004bf39d91607110478ce483cb92e46f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5b67291b7735ec4f0795d3eae2a4ab4c8c5a17d","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":52,"context_line":"ACTION_MAP \u003d {}"},{"line_number":53,"context_line":"REQUIRED_EXTENSIONS \u003d [l3.ALIAS]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1dc87828_163aa1aa","line":50,"in_reply_to":"d72b1769_d34522d7","updated":"2026-04-29 14:54:18.000000000","message":"To be honest, I missed the commit message...\n\nThat\u0027s weird that we don\u0027t have an schema for this. We have the actions `add_router_interface` and `remove_router_interface` but nothing about the schema. We even have the documentation in `v2/routers.inc`. I think this is a bug, but out of scope from this patch.\n\nIn any case, you should at least update this documentation","commit_id":"da830e15004bf39d91607110478ce483cb92e46f"}]}