)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1d1d7536431f77af57c5f445d627ad588374a8d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19e79ffe_a6b37ac6","updated":"2026-07-08 10:17:21.000000000","message":"Please, provide a launchpad bug description and, if possible, a reproducer.","commit_id":"bce41042643dae9d9e7dc7d8ef63717e75ec4259"},{"author":{"_account_id":39125,"name":"Felix Moebius","email":"felix.moebius@digits.schwarz","username":"felixmoebius"},"change_message_id":"fbfeeeb7965151b40acf50338e9f0f8b23bac6f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76bf29fb_71e749a6","in_reply_to":"19e79ffe_a6b37ac6","updated":"2026-07-10 11:12:27.000000000","message":"Hi Rodolfo, thanks for taking a look. I created a bug for this here:\nhttps://bugs.launchpad.net/neutron/+bug/2160292\n\nA more general question regarding this change: Do we need to make any adjustments on the neutron side to deal with this change in behavior? Silently failing to delete the standardattributes is certainly not great, thus I think it makes sense to do the revert that I am proposing. On the other hand we then might have deletions failing unexpectedly when there is a conflict, which I guess was the motivation for setting confirm_deleted_rows\u003dFalse in the first place.\n\nIdeally we would just not check the revision number on the delete, but looking at the sqlalchemy docs I don\u0027t think that is supported.","commit_id":"bce41042643dae9d9e7dc7d8ef63717e75ec4259"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1545ccca5df5e5c62480a45e1e00aa478ae730eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5e5e43d_2d56bc7a","updated":"2026-07-20 19:50:58.000000000","message":"Might need https://review.opendev.org/c/openstack/neutron-lib/+/998059 first to fix the gate","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"22e36706654bae1fddf2372f15d6a4ea7f822ba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b511fccd_62d84903","updated":"2026-07-20 15:04:43.000000000","message":"This patch makes sense (and I admit it was an error to introduce it). `confirm_deleted_rows\u003dFalse` only suppresses the error check but silently leaves orphaned rows in the DB. From data integrity point of view, if the check fails, we have a transaction rollback and then, if added in the code, a retry. With `confirm_deleted_rows\u003dFalse` we produce a partial deletion..\n\nAs commented, we can always retry via code or manually. But leaving orphaned registers is not acceptable.\n\nMike\u0027s comments in https://review.opendev.org/c/openstack/neutron-lib/+/777581 are totally legit.\n\nAgain, sorry for accepting this patch initially.","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"3f25eb052b2101260861830066f9e10a5c9f7cf9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ea9f73e5_c7224a7d","updated":"2026-07-20 15:13:54.000000000","message":"Well, you can set this however you\u0027d like but I would advise looking at the original issue https://bugs.launchpad.net/neutron/+bug/1916889 where \"raise an error\" seemed to be *not* what was wanted.  \n\nis it possible this operation is called under different conditions, sometimes where \"keep going after failure\" is desirable and others where it\u0027s not ?","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"45206a7aee03863299649f0b4edb86f433052e8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c853b6e_9ab7edaf","in_reply_to":"1e7a36a5_aaf4c096","updated":"2026-07-23 09:04:27.000000000","message":"so we have to revisit the decorators in Neutron and in Stadiums?","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1838f7a485916b47636c3e613079d03667e6e644","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e7a36a5_aaf4c096","in_reply_to":"3514aaaf_02aebe46","updated":"2026-07-23 08:45:20.000000000","message":"Right: https://b0a33bc146a6e2c6edfe-a7033665f00e44c878b32db8197e4d01.ssl.cf1.rackcdn.com/openstack/966167435676453f8b1223827302b43d/testr_results.html\n\n--\u003e https://bugs.launchpad.net/neutron/+bug/2161605","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9637df8220c56637bbd4a1ca83a28085311d0480","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"17169cd4_2b4a4d30","in_reply_to":"5c853b6e_9ab7edaf","updated":"2026-07-23 12:51:55.000000000","message":"I would merge this patch and push a new n-lib release. After that, we\u0027ll need to keep an aye on the CI to catch possible failures caused by this change.","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"212ea10d6658a2365d36420675102a8735da4823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3514aaaf_02aebe46","in_reply_to":"af1d6443_b89b3e33","updated":"2026-07-21 18:05:53.000000000","message":"looks like you have your first one ! :)   \n\nso yes you need to put retry decorators on these typically.    pessimistic locking unfortunately not an option with galera.","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"01e944e4598fcecfc153f530f9001bb7cb8a74b9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"af1d6443_b89b3e33","in_reply_to":"bc0bea44_a7414cd1","updated":"2026-07-21 15:07:44.000000000","message":"These kind of errors are caused by concurrent operations. We\u0027ll see in the CI or via bug reports, where this problem could happen and how to solve each one independently.","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"6953de9b8cdf3f72c1e595bac3407fef8c97feb6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bc0bea44_a7414cd1","in_reply_to":"e427746b_3e4bce75","updated":"2026-07-21 14:29:04.000000000","message":"no argument there but then what was the story behind the change in the first place?   is the problem raised by https://bugs.launchpad.net/neutron/+bug/1916889 going to be solved by adding a new retry decorator?","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"81f85067ad88e5158812e2bfb203fd305921a922","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e427746b_3e4bce75","in_reply_to":"ea9f73e5_c7224a7d","updated":"2026-07-21 14:08:02.000000000","message":"But the point described in the LP bug is legit: right now we are leaving DB leftovers when the delete command doesn\u0027t match the expected number. We are just hiding the error. It is much better to retry it, via decorator, or fail and request the user to retry the operation again. But we won\u0027t leave anything unnecessary in the DB.","commit_id":"bb8fae905e47239a265f83217029fb9ec187cb9f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c877bbc8505e9d193b52605ab0648deb75d9d84b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c483e3a_f56c28a6","updated":"2026-07-21 17:20:28.000000000","message":"Hmm, functional tests don\u0027t seem to like this:\n\nsqlalchemy.orm.exc.StaleDataError: DELETE statement on table \u0027standardattributes\u0027 expected to delete 3 row(s); 0 were matched.  Please set confirm_deleted_rows\u003dFalse within the mapper configuration to prevent this warning.","commit_id":"01c0a7c81e0351c3308c5e32ebfe0da3743478b2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2bad44acced05d5aefd032c39b9603f0b12dbe5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8b6a0e72_28296f4a","updated":"2026-07-22 15:08:39.000000000","message":"recheck neutron-functional","commit_id":"01c0a7c81e0351c3308c5e32ebfe0da3743478b2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2afe29ff741b0d9c84a3079e3207b1bf3839751e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"03a29c05_08cb1443","updated":"2026-07-23 14:20:20.000000000","message":"Functional test is still failing","commit_id":"b45adc9c943b90485f0326549034c9ab5bf9f9cd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"93123160f502385cc41b49cab70418de2bf5f14e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"70aeeda0_db81f124","updated":"2026-07-24 07:59:23.000000000","message":"recheck, new PS4 for https://review.opendev.org/c/openstack/neutron/+/998421","commit_id":"b45adc9c943b90485f0326549034c9ab5bf9f9cd"}]}