)]}'
{"api-ref/source/v2/subnets.inc":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bf0f104793a7d2ef724e9f60a95aec787da7472","unresolved":true,"context_lines":[{"line_number":131,"context_line":"   - not-tags-any: not-tags-any-query"},{"line_number":132,"context_line":"   - dns_publish_fixed_ip: subnet-dns_publish_fixed_ip-query"},{"line_number":133,"context_line":"   - fields: fields"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Response Parameters"},{"line_number":136,"context_line":"-------------------"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"8378e21e_b5acf256","line":134,"updated":"2026-07-31 13:56:57.000000000","message":"If `\u0027is_filter\u0027: True,`, why not adding it here?","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"68e31453f8136e0f8703943982256569f589dd2a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"   - not-tags-any: not-tags-any-query"},{"line_number":132,"context_line":"   - dns_publish_fixed_ip: subnet-dns_publish_fixed_ip-query"},{"line_number":133,"context_line":"   - fields: fields"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Response Parameters"},{"line_number":136,"context_line":"-------------------"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"f5825e92_976ca41f","line":134,"in_reply_to":"211b6b94_6a5c1df8","updated":"2026-08-03 06:48:45.000000000","message":"Done","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2e8df29746df76d573e4be5e26e6b3c4d36bb324","unresolved":true,"context_lines":[{"line_number":131,"context_line":"   - not-tags-any: not-tags-any-query"},{"line_number":132,"context_line":"   - dns_publish_fixed_ip: subnet-dns_publish_fixed_ip-query"},{"line_number":133,"context_line":"   - fields: fields"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Response Parameters"},{"line_number":136,"context_line":"-------------------"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"211b6b94_6a5c1df8","line":134,"in_reply_to":"8378e21e_b5acf256","updated":"2026-07-31 14:48:36.000000000","message":"The implementation extends the response on the API layer - and the way it was implemented is that the Subnet OVO doesn\u0027t know about the attribute at all. I changed the is_filter to False to reflect that. We can implement filtering if needed later.","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bf0f104793a7d2ef724e9f60a95aec787da7472","unresolved":true,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Error response codes: 400, 401, 403, 404, 409"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"Request"},{"line_number":229,"context_line":"-------"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"   - subnet: subnet-obj"},{"line_number":234,"context_line":"   - tenant_id: project_id-request"},{"line_number":235,"context_line":"   - project_id: project_id-request"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3f2c9ce2_7ef6584e","line":232,"range":{"start_line":228,"start_character":0,"end_line":232,"end_character":1},"updated":"2026-07-31 13:56:57.000000000","message":"I was going to ask about POST but then I found that we support PUT only: https://review.opendev.org/c/openstack/neutron-specs/+/998046/5/specs/2026.2/bgp-route-leak-geneve-networks.rst\n\nBut why??","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2e8df29746df76d573e4be5e26e6b3c4d36bb324","unresolved":true,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Error response codes: 400, 401, 403, 404, 409"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"Request"},{"line_number":229,"context_line":"-------"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"   - subnet: subnet-obj"},{"line_number":234,"context_line":"   - tenant_id: project_id-request"},{"line_number":235,"context_line":"   - project_id: project_id-request"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"4017693a_47f3f262","line":232,"range":{"start_line":228,"start_character":0,"end_line":232,"end_character":1},"in_reply_to":"3f2c9ce2_7ef6584e","updated":"2026-07-31 14:48:36.000000000","message":"Because of this constraint: https://review.opendev.org/c/openstack/neutron-specs/+/998046/5/specs/2026.2/bgp-route-leak-geneve-networks.rst#53","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"68e31453f8136e0f8703943982256569f589dd2a","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Error response codes: 400, 401, 403, 404, 409"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"Request"},{"line_number":229,"context_line":"-------"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"   - subnet: subnet-obj"},{"line_number":234,"context_line":"   - tenant_id: project_id-request"},{"line_number":235,"context_line":"   - project_id: project_id-request"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"07875216_ec122029","line":232,"range":{"start_line":228,"start_character":0,"end_line":232,"end_character":1},"in_reply_to":"4017693a_47f3f262","updated":"2026-08-03 06:48:45.000000000","message":"Done","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"}],"neutron_lib/api/definitions/base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bf0f104793a7d2ef724e9f60a95aec787da7472","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    206,"},{"line_number":79,"context_line":")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"KNOWN_EXTENSIONS \u003d ("},{"line_number":82,"context_line":"    \u0027address-scope\u0027,"},{"line_number":83,"context_line":"    \u0027agent\u0027,"},{"line_number":84,"context_line":"    \u0027agent-resources-synced\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"6736b6e2_5894d14d","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":16},"updated":"2026-07-31 13:56:57.000000000","message":"Should be here too","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2e8df29746df76d573e4be5e26e6b3c4d36bb324","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    206,"},{"line_number":79,"context_line":")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"KNOWN_EXTENSIONS \u003d ("},{"line_number":82,"context_line":"    \u0027address-scope\u0027,"},{"line_number":83,"context_line":"    \u0027agent\u0027,"},{"line_number":84,"context_line":"    \u0027agent-resources-synced\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"506c3609_36df2770","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":16},"in_reply_to":"6736b6e2_5894d14d","updated":"2026-07-31 14:48:36.000000000","message":"Done","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"}],"neutron_lib/api/definitions/ovn_bgp.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6d428599167d94a883f0597176ae8533cdb8aa18","unresolved":false,"context_lines":[{"line_number":21,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":22,"context_line":"NAME \u003d \u0027OVN BGP\u0027"},{"line_number":23,"context_line":"API_PREFIX \u003d \u0027\u0027"},{"line_number":24,"context_line":"DESCRIPTION \u003d (\u0027Network extension to support OVN BGP integration attributes\u0027)"},{"line_number":25,"context_line":"UPDATED_TIMESTAMP \u003d \u00272026-07-20T00:00:00-00:00\u0027"},{"line_number":26,"context_line":"RESOURCE_NAME \u003d network.RESOURCE_NAME"},{"line_number":27,"context_line":"COLLECTION_NAME \u003d network.COLLECTION_NAME"}],"source_content_type":"text/x-python","patch_set":1,"id":"99bd0940_3b71af95","line":24,"updated":"2026-07-21 21:24:07.000000000","message":"pep8: C0325: Unnecessary parens after \u0027\u003d\u0027 keyword (superfluous-parens)","commit_id":"9db85eba4942c961fd9bd6a71c9a35b710515a0d"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"e55c73b8bd6e2a884025a3065ef8f074c11e1dcd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2026 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"490b331d_a9bc2c84","line":1,"range":{"start_line":1,"start_character":25,"end_line":1,"end_character":30},"updated":"2026-07-31 13:13:55.000000000","message":"nit: And now that you added `LLC` into test_ovn_bgp.py you should update it here. And all other new files in this topic","commit_id":"72ae8bcdcebd7c72580ccf3b7d9dbac8325459f0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e949de354ac9ad85a470506bcac7a5c8c7fc2e36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2026 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"367592f3_7750c33f","line":1,"range":{"start_line":1,"start_character":25,"end_line":1,"end_character":30},"in_reply_to":"490b331d_a9bc2c84","updated":"2026-07-31 13:30:59.000000000","message":"Done","commit_id":"72ae8bcdcebd7c72580ccf3b7d9dbac8325459f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bf0f104793a7d2ef724e9f60a95aec787da7472","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LEAK_ROUTES \u003d \u0027leak_routes\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":32,"context_line":"    COLLECTION_NAME: {"},{"line_number":33,"context_line":"        LEAK_ROUTES: {"},{"line_number":34,"context_line":"            \u0027allow_post\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"e4f278bb_1777f60d","line":31,"updated":"2026-07-31 13:56:57.000000000","message":"Please, add the type annotations:\n```\nfrom neutron_lib.types import (\n    ActionMap,\n    ResourceAttributeMap,\n    SubResourceAttributeMap,\n)\n```\n\nCheck any other extension","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2e8df29746df76d573e4be5e26e6b3c4d36bb324","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LEAK_ROUTES \u003d \u0027leak_routes\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":32,"context_line":"    COLLECTION_NAME: {"},{"line_number":33,"context_line":"        LEAK_ROUTES: {"},{"line_number":34,"context_line":"            \u0027allow_post\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ec5d9a0_b81a1209","line":31,"in_reply_to":"e4f278bb_1777f60d","updated":"2026-07-31 14:48:36.000000000","message":"Done","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bf0f104793a7d2ef724e9f60a95aec787da7472","unresolved":true,"context_lines":[{"line_number":31,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":32,"context_line":"    COLLECTION_NAME: {"},{"line_number":33,"context_line":"        LEAK_ROUTES: {"},{"line_number":34,"context_line":"            \u0027allow_post\u0027: False,"},{"line_number":35,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":36,"context_line":"            \u0027default\u0027: False,"},{"line_number":37,"context_line":"            \u0027convert_to\u0027: converters.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d77aa92a_0fdb3538","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":32},"updated":"2026-07-31 13:56:57.000000000","message":"Same question as in the paremeters definition: why not post? (I know this is explicitly defined in the spec as a PUT only parameter)","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"68e31453f8136e0f8703943982256569f589dd2a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":32,"context_line":"    COLLECTION_NAME: {"},{"line_number":33,"context_line":"        LEAK_ROUTES: {"},{"line_number":34,"context_line":"            \u0027allow_post\u0027: False,"},{"line_number":35,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":36,"context_line":"            \u0027default\u0027: False,"},{"line_number":37,"context_line":"            \u0027convert_to\u0027: converters.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":6,"id":"336dbfd8_d3a469db","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":32},"in_reply_to":"bee6e5fb_5c62677f","updated":"2026-08-03 06:48:45.000000000","message":"Thanks!","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2e8df29746df76d573e4be5e26e6b3c4d36bb324","unresolved":true,"context_lines":[{"line_number":31,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":32,"context_line":"    COLLECTION_NAME: {"},{"line_number":33,"context_line":"        LEAK_ROUTES: {"},{"line_number":34,"context_line":"            \u0027allow_post\u0027: False,"},{"line_number":35,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":36,"context_line":"            \u0027default\u0027: False,"},{"line_number":37,"context_line":"            \u0027convert_to\u0027: converters.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bee6e5fb_5c62677f","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":32},"in_reply_to":"d77aa92a_0fdb3538","updated":"2026-07-31 14:48:36.000000000","message":"We have prerequisities that subnet must be attached to a router with the external gateway connectivity. You can\u0027t create such a subnet.","commit_id":"85c332051ad248ff4abb737fd4f27e25c3abb001"}],"neutron_lib/tests/unit/api/definitions/test_ovn_bgp.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"46cdf9699bbf1076aafb6963fc563205201eecd4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":4,"id":"70780af3_b19051ed","line":1,"updated":"2026-07-31 01:47:36.000000000","message":"Looks like you are missing \n```\n# Copyright 2026 Red Hat, Inc.\n# All Rights Reserved.\n#\n```\nAnd also, maybe it should say `2026 Red Hat, LLC.` IDK, I am not a lawyer 😉","commit_id":"8651efa614ca8553a8e5c54f963c435567ee9b05"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ca5a43f3b333dbcdbd05caf9299cc5ea20346a6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":4,"id":"8a35357d_a11c365d","line":1,"in_reply_to":"70780af3_b19051ed","updated":"2026-07-31 11:51:52.000000000","message":"Done","commit_id":"8651efa614ca8553a8e5c54f963c435567ee9b05"}]}