)]}'
{"Empty file":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"83b39756a7b6daf208c2a1d37aba8e0953f6e5ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5a890539_626e9ccb","side":"PARENT","updated":"2014-11-08 22:27:41.000000000","message":"rerere","commit_id":"e6cdf8c99c4f67e1176e83dba6fc6bcac2863ae4"}],"specs/juno/dhcp-relay.rst":[{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"3f273f46aee2f04758ab9bd5786e8ff118833e88","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     XX   Network   X  "},{"line_number":42,"context_line":"                     X           XXX  "},{"line_number":43,"context_line":"                     XXXXXX    XXX     "},{"line_number":44,"context_line":"                           XX+XX       "},{"line_number":45,"context_line":"                             |"},{"line_number":46,"context_line":"                             |         "},{"line_number":47,"context_line":"                     +-------+--------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_bdc9ce27","line":44,"updated":"2014-07-14 21:41:36.000000000","message":"whitespaces","commit_id":"1887f1fb182c8706911b2cd9357b9ebd233d7df9"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"191713e886ce42f32196edb963894c09dbcc78c5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"- Each DHCP Relay is plugged into it’s corresponding L2 network and has"},{"line_number":70,"context_line":"  unicast L2 connectivity to external DHCP Server"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- DHCP Relay forwards DHCP requests from the VMs plugged into the network "},{"line_number":73,"context_line":"  to the external DHCP Server"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Each DHCP Relay is automatically configured to forward requests to a certain"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_2eb10647","line":72,"updated":"2014-07-14 22:59:55.000000000","message":"this one is still left :)","commit_id":"ec60e876ae0db98baf8ccb1f2e4ac8c14dae02af"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f858431ea6c4205bf3824c3d516651f02bc1f06d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Communication between VM and DHCP server  will be implemented using DHCP Relay:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- Each tenant network (L2 segment) has a corresponding DHCP Relay daemon"},{"line_number":67,"context_line":"  (Like dnsmasq in relay mode) running on the DHCP node"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"- Each DHCP Relay is plugged into it’s corresponding L2 network and has"},{"line_number":70,"context_line":"  unicast L2 connectivity to external DHCP Server"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baa201ad_52712943","line":67,"updated":"2014-10-13 10:01:59.000000000","message":"If the implementation will be dnsmasq based, can you include some example config file?","commit_id":"5806fa2009089ade44cc1d53c63f1135847be63f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f858431ea6c4205bf3824c3d516651f02bc1f06d","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"REST API impact"},{"line_number":96,"context_line":"---------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"None."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baa201ad_32dbc51c","line":97,"updated":"2014-10-13 10:01:59.000000000","message":"How do we configure a DHCP relay for an specific agent/tenant network. Can you give some examples?","commit_id":"5806fa2009089ade44cc1d53c63f1135847be63f"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"58d3b70f786c5752f9a213d024c1c0c558e8ec4d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"----------"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"1. Implement DHCP Relay with similar interface to DHCP Agent as dnsmasq"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"2. Configuration file to specify IP Address for External Interface for DHCP"},{"line_number":150,"context_line":"   Relay and IP Address binding to external DHCP Server"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baa201ad_34bbbf73","line":148,"updated":"2014-10-12 07:36:29.000000000","message":"DHCP agent configuration file? Is this a global change? Will all dnsmasq\u0027s be either default or relay?\n\nCan you talk about this in the alternatives section? Clearly the alternative is to add this via the API, per subnet?","commit_id":"5806fa2009089ade44cc1d53c63f1135847be63f"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"58d3b70f786c5752f9a213d024c1c0c558e8ec4d","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Testing"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Neutron unit and integration tests + Tempest test required."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baa201ad_14b6bb8a","line":162,"updated":"2014-10-12 07:36:29.000000000","message":"How will the Tempest test work? Are you going to simulate an external DHCP server somehow?","commit_id":"5806fa2009089ade44cc1d53c63f1135847be63f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59590f031b1e6681cb542e2af0480a994c63726d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"- Each DHCP Relay is automatically configured to forward requests to a certain"},{"line_number":79,"context_line":"  external DHCP Server"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- Since OpenStack Neutron guarantees the uniqueness of network ports MAC"},{"line_number":82,"context_line":"  addresses, the external DHCP Server can distinguish the incoming requests by"},{"line_number":83,"context_line":"  the source MAC address"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9aa7fdbe_55e10f99","line":81,"updated":"2014-10-21 21:51:25.000000000","message":"Though uniqueness will still be there, the following proposal may make mac_address alterable: https://review.openstack.org/129085","commit_id":"a0ea2283a6b5b85919d95c63947934ae62cd6448"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"change_message_id":"a7db2c3df102e20ca1a713b62fead88b5fbed083","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"- The DHCP Relay will use and extend configuration options in dhcp_agent.ini"},{"line_number":90,"context_line":"  Here is a list of configuration options:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  # Select DHCP Driver dnsmasq or dhcp relay"},{"line_number":93,"context_line":"  # dhcp_driver \u003d neutron.agent.linux.dhcp.Dnsmasq"},{"line_number":94,"context_line":"  dhcp_driver \u003d neutron.agent.linux.dhcp_dns_proxy.DhcpDnsProxy"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9aa7fdbe_cb74929e","line":91,"updated":"2014-10-21 12:48:20.000000000","message":"Sorry for changing the vote, but I think this configuration should be at higher level as there are DHCP implementations that don\u0027t rely on DHCP agent. Probably in subnet data model.","commit_id":"a0ea2283a6b5b85919d95c63947934ae62cd6448"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     XX   Network   X"},{"line_number":42,"context_line":"                     X           XXX"},{"line_number":43,"context_line":"                     XXXXXX    XXX"},{"line_number":44,"context_line":"                           XX+XX"},{"line_number":45,"context_line":"                             |"},{"line_number":46,"context_line":"                             |"},{"line_number":47,"context_line":"                     +-------+--------+"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_7162d4d9","line":44,"updated":"2014-11-10 21:48:38.000000000","message":"I demand this cloud looks like a proper cloud.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"The current Openstack DHCP infrastructure (i.e. dnsmasq) does not provide the"},{"line_number":58,"context_line":"capability to relay DHCP request from VMs on L2 Tenant Network to an external"},{"line_number":59,"context_line":"DHCP server on a service L3 network. The DHCP Relay specifically will support"},{"line_number":60,"context_line":"link-selection suboption (https://tools.ietf.org/html/rfc3527), which is"},{"line_number":61,"context_line":"required to forward DHCP requests from VMs, on tenant networks, to external"},{"line_number":62,"context_line":"network."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_51acf8ed","line":60,"updated":"2014-11-10 21:48:38.000000000","message":"just for the sake of html rendering, can you move the above link to the refs section?","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"will be synchronized with the external DHCP Servers. The details of this"},{"line_number":66,"context_line":"are beyond the scope of this specification, in one potential deployment a"},{"line_number":67,"context_line":"centeralized external IPAM could be used to synchronize external DHCP Servers"},{"line_number":68,"context_line":"with Neutron configuration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Proposed change"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_f17c0475","line":68,"updated":"2014-11-10 21:48:38.000000000","message":"I agree that they\u0027re out, but they perhaps imply this blueprint has dependencies, which should be stated in the appropriate section so that reviewers can get the whole picture.\n\n(I get how all would work in your design because I\u0027ve read all of your specs, no worries)","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d2b55e7ff52eee3c011a2bc00a1daf1a890e7fa1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"are beyond the scope of this specification, in one potential deployment a"},{"line_number":67,"context_line":"centeralized external IPAM could be used to synchronize external DHCP Servers"},{"line_number":68,"context_line":"with Neutron configuration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Proposed change"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_cb31a40c","line":69,"updated":"2014-12-02 19:53:39.000000000","message":"So basically I would just put the pluggable IPAM blueprint as a dependency","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a5d1cb8a6a2dbd2d76fc9f0d80c6df3d33cf12a8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"are beyond the scope of this specification, in one potential deployment a"},{"line_number":67,"context_line":"centeralized external IPAM could be used to synchronize external DHCP Servers"},{"line_number":68,"context_line":"with Neutron configuration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Proposed change"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_7d7911c4","line":69,"in_reply_to":"5a890539_cb31a40c","updated":"2014-12-04 03:01:14.000000000","message":"you mean, the IPAM one is the parent spec, correct?","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"- Each tenant network (L2 segment) has a corresponding DHCP Relay daemon"},{"line_number":76,"context_line":"  (Like dnsmasq in relay mode) running on the DHCP node"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- Each DHCP Relay is plugged into it’s corresponding L2 network and has"},{"line_number":79,"context_line":"  unicast L2 connectivity to external DHCP Server"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- DHCP Relay forwards DHCP requests from the VMs plugged into the network"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_71901496","line":78,"updated":"2014-11-10 21:48:38.000000000","message":"If I were an english teacher I\u0027d point out a typo in the line above.\nBut I\u0027m not either english or a teacher.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a5d1cb8a6a2dbd2d76fc9f0d80c6df3d33cf12a8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  (Like dnsmasq in relay mode) running on the DHCP node"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- Each DHCP Relay is plugged into it’s corresponding L2 network and has"},{"line_number":79,"context_line":"  unicast L2 connectivity to external DHCP Server"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- DHCP Relay forwards DHCP requests from the VMs plugged into the network"},{"line_number":82,"context_line":"  to the external DHCP Server"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_5d55351c","line":79,"updated":"2014-12-04 03:01:14.000000000","message":"Is this connectivity pre-provisioned? Also, how do we ensure isolation?","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a5d1cb8a6a2dbd2d76fc9f0d80c6df3d33cf12a8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"- Each DHCP Relay is automatically configured to forward requests to a certain"},{"line_number":85,"context_line":"  external DHCP Server"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- Since OpenStack Neutron guarantees the uniqueness of network ports MAC"},{"line_number":88,"context_line":"  addresses, the external DHCP Server can distinguish the incoming requests by"},{"line_number":89,"context_line":"  the source MAC address"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_fd12615f","line":87,"updated":"2014-12-04 03:01:14.000000000","message":"besides mark\u0027s point below, if we assume that this work is dependent on the pluggable IPAM and that the external IPAM system takes care of the IP,MAC assignment, I believe this statement is no longer accurate.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"83b39756a7b6daf208c2a1d37aba8e0953f6e5ef","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- Since OpenStack Neutron guarantees the uniqueness of network ports MAC"},{"line_number":88,"context_line":"  addresses, the external DHCP Server can distinguish the incoming requests by"},{"line_number":89,"context_line":"  the source MAC address"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- The same driver can be used relay both DHCP and DNS requests. The details of"},{"line_number":92,"context_line":"  DNS operation is detailed in:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_827388b0","line":89,"updated":"2014-11-08 22:27:41.000000000","message":"This is only true for a single network.  One can have duplicate macs in different networks.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d2b55e7ff52eee3c011a2bc00a1daf1a890e7fa1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"- Since OpenStack Neutron guarantees the uniqueness of network ports MAC"},{"line_number":88,"context_line":"  addresses, the external DHCP Server can distinguish the incoming requests by"},{"line_number":89,"context_line":"  the source MAC address"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- The same driver can be used relay both DHCP and DNS requests. The details of"},{"line_number":92,"context_line":"  DNS operation is detailed in:"},{"line_number":93,"context_line":"  https://blueprints.launchpad.net/neutron/+spec/dns-subsystem"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_eb366002","line":90,"updated":"2014-12-02 19:53:39.000000000","message":"This is a comment that must be addressed. Can we send a unique id like the port_id on a DHCP request to help the external server discriminate, o will DHCP relay mode need to imply a restriction on MAC uniqueness?","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"4ac3a71c7a504ece97f8dd93a29bf4a006242a14","unresolved":false,"context_lines":[{"line_number":87,"context_line":"- Since OpenStack Neutron guarantees the uniqueness of network ports MAC"},{"line_number":88,"context_line":"  addresses, the external DHCP Server can distinguish the incoming requests by"},{"line_number":89,"context_line":"  the source MAC address"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- The same driver can be used relay both DHCP and DNS requests. The details of"},{"line_number":92,"context_line":"  DNS operation is detailed in:"},{"line_number":93,"context_line":"  https://blueprints.launchpad.net/neutron/+spec/dns-subsystem"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_b841b40b","line":90,"in_reply_to":"5a890539_82ed6727","updated":"2014-12-04 14:57:02.000000000","message":"Ack. Actually it looks like we are using the link-selection sub-option for this. Because the relay IP in the tenant network is not routable for the DHCP server, the \"giaddr\" value is set to the IP in the management network, while the link-selection sub-option is set to the relay address in the tenant network. The server then uses the management IP of the relay agent to communicate with the agent, but the IP in the sub-option to determine the appropriate subnet for the address allocation.\n\nThe fact that there is a relay agent *per network*, with a separate IP in the management network is how traffic is isolated between tenants.\n\nIn the single-process model, with a single IP in the management network, it become necessary to use the vpn ID or circuit ID to differentiate, because address in the tenant network is not sufficient. That is, you could use the vpn ID or circuit ID to differentiate the tenant and specific tenant network.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"63c0c805400aa226e99fdd90396e74d5dc9aed06","unresolved":false,"context_lines":[{"line_number":87,"context_line":"- Since OpenStack Neutron guarantees the uniqueness of network ports MAC"},{"line_number":88,"context_line":"  addresses, the external DHCP Server can distinguish the incoming requests by"},{"line_number":89,"context_line":"  the source MAC address"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- The same driver can be used relay both DHCP and DNS requests. The details of"},{"line_number":92,"context_line":"  DNS operation is detailed in:"},{"line_number":93,"context_line":"  https://blueprints.launchpad.net/neutron/+spec/dns-subsystem"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_82ed6727","line":90,"in_reply_to":"5a890539_eb366002","updated":"2014-12-04 14:12:47.000000000","message":"The relay agent would set DHCP option 82 (circuit ID) based on the Neutron L2 segment.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- The same driver can be used relay both DHCP and DNS requests. The details of"},{"line_number":92,"context_line":"  DNS operation is detailed in:"},{"line_number":93,"context_line":"  https://blueprints.launchpad.net/neutron/+spec/dns-subsystem"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- The DHCP Relay will use and extend configuration options in dhcp_agent.ini"},{"line_number":96,"context_line":"  Here is a list of configuration options:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_31ddac71","line":93,"updated":"2014-11-10 21:48:38.000000000","message":"is this a reference or a dependency (looks more like the former). Perhaps add it to the references section","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  dhcp_driver \u003d neutron.agent.linux.dhcp_dns_proxy.DhcpDnsProxy"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  # Network interface used for relay"},{"line_number":103,"context_line":"  dhcp_dns_proxy_bridge \u003d br-mgmt"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  # Network from which an Fixed IP is allocated for relay"},{"line_number":106,"context_line":"  dhcp_dns_relay_network \u003d 10.39.12.0/24"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_f1ca44a0","line":103,"updated":"2014-11-10 21:48:38.000000000","message":"I\u0027d like more details on why the relay would need a different bridge.\nIs that a requirement or an option?","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  dhcp_dns_proxy_bridge \u003d br-mgmt"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  # Network from which an Fixed IP is allocated for relay"},{"line_number":106,"context_line":"  dhcp_dns_relay_network \u003d 10.39.12.0/24"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- The relay will be used for all tenants and there will not be an option to"},{"line_number":109,"context_line":"  select between dnsmasq or DHCP Relay drivers for tenants or networks."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_11d0b04f","line":106,"updated":"2014-11-10 21:48:38.000000000","message":"can you clarify the purpose of this cidr? Is it a sort of \"alternative\" mgmt network for communicating with the external dhcp server? Can it be alternative if the dhcp server sits on the \"traditional\" management network?","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"63c0c805400aa226e99fdd90396e74d5dc9aed06","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  dhcp_dns_proxy_bridge \u003d br-mgmt"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  # Network from which an Fixed IP is allocated for relay"},{"line_number":106,"context_line":"  dhcp_dns_relay_network \u003d 10.39.12.0/24"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- The relay will be used for all tenants and there will not be an option to"},{"line_number":109,"context_line":"  select between dnsmasq or DHCP Relay drivers for tenants or networks."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_8262c7aa","line":106,"in_reply_to":"5a890539_11d0b04f","updated":"2014-12-04 14:12:47.000000000","message":"In fact each instance of the relay needs an IP on a network that has routing to the DHCP server. This means for every namespace, we consume one IP on this management network. For this reason, the DHCP proposal [1] that Don Kehn made is preferable over this one.\n\n[1] https://blueprints.launchpad.net/neutron/+spec/dhcp-cpnr-integration","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  dhcp_dns_relay_network \u003d 10.39.12.0/24"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- The relay will be used for all tenants and there will not be an option to"},{"line_number":109,"context_line":"  select between dnsmasq or DHCP Relay drivers for tenants or networks."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_91bbc00d","line":109,"updated":"2014-11-10 21:48:38.000000000","message":"makes sense","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bcd5d29e7617bf27232d50f4e91e397e953714b9","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"- You could have finer granularity for deploying a relay, either per tenant or"},{"line_number":116,"context_line":"  per subnet. The current DHCP Agent configuration and deployment model fit our"},{"line_number":117,"context_line":"  use case and we did not implement this level of granularity."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Data model impact"},{"line_number":120,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_1147d020","line":117,"updated":"2014-11-10 21:48:38.000000000","message":"I reckon the only use case for this would be differentiated service levels, but I do not see any reason for doing this kind of implementation right now.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"83b39756a7b6daf208c2a1d37aba8e0953f6e5ef","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Security impact"},{"line_number":133,"context_line":"---------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"None."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_a267a4e9","line":134,"updated":"2014-11-08 22:27:41.000000000","message":"There is a significant security impact here.  How do you intend to let the traffic escape the isolated segment?  As an operator, I\u0027d want to know what security precautions are in place to preven t cross tenant traffic.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"63c0c805400aa226e99fdd90396e74d5dc9aed06","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Security impact"},{"line_number":133,"context_line":"---------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"None."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_42c0df49","line":134,"in_reply_to":"5a890539_581aa36f","updated":"2014-12-04 14:12:47.000000000","message":"The tenant has no control over the IP in the management network. The relay will pickup the DHCP request from the isolated L2 segment, then unicast via the management network, setting the circuit-id to differentiate the segments. It\u0027s up to the receiving DHCP server to properly interpret the options.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a5d1cb8a6a2dbd2d76fc9f0d80c6df3d33cf12a8","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Security impact"},{"line_number":133,"context_line":"---------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"None."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_581aa36f","line":134,"in_reply_to":"5a890539_a267a4e9","updated":"2014-12-04 03:01:14.000000000","message":"see my question line 79","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a5d1cb8a6a2dbd2d76fc9f0d80c6df3d33cf12a8","unresolved":false,"context_lines":[{"line_number":168,"context_line":"-----------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Primary assignee:"},{"line_number":171,"context_line":"Soheil Eizadi (seizadi)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"TBD"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_3836b7e7","line":171,"updated":"2014-12-04 03:01:14.000000000","message":"Perhaps John Belamaric took over? He\u0027s the one resurrecting: https://review.openstack.org/#/c/97967/","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":12912,"name":"John Belamaric","email":"jbelamaric@infoblox.com","username":"johnbelamaric"},"change_message_id":"63c0c805400aa226e99fdd90396e74d5dc9aed06","unresolved":false,"context_lines":[{"line_number":168,"context_line":"-----------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Primary assignee:"},{"line_number":171,"context_line":"Soheil Eizadi (seizadi)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"TBD"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_82a567b6","line":171,"in_reply_to":"5a890539_3836b7e7","updated":"2014-12-04 14:12:47.000000000","message":"Yes.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a5d1cb8a6a2dbd2d76fc9f0d80c6df3d33cf12a8","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Soheil Eizadi (seizadi)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"TBD"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Work Items"},{"line_number":177,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_782cbf93","line":174,"updated":"2014-12-04 03:01:14.000000000","message":"tatore?","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"83b39756a7b6daf208c2a1d37aba8e0953f6e5ef","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Neutron unit and integration tests + Tempest test required."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"An external DHCP Server will be used as part of Tempest tests for Thrid Party"},{"line_number":198,"context_line":"CI Testing to qualify the DHCP Relay operation."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Documentation Impact"},{"line_number":201,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_c264b0e7","line":198,"updated":"2014-11-08 22:27:41.000000000","message":"Seems like functional testing is needed too.","commit_id":"15a58ab3a3b181222a652292ed9daa7c8da02680"}]}