)]}'
{"specs/kilo/ml2-ucs-manager-mechanism-driver.rst":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"80b2ce5ab8258863249b7f269e8958ebd3cba481","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\"direct\" or \"macvtap\" modes. In the \"direct\" mode, the VM\u0027s port is connected"},{"line_number":36,"context_line":"directly to the VF and to a macvtap device on the host in the \"macvtap\" mode."},{"line_number":37,"context_line":"In both these modes, the VM\u0027s traffic completely bypasses the hypervisor,"},{"line_number":38,"context_line":"sending and receiving traffic directly to and from the vNIC and thus the"},{"line_number":39,"context_line":"upstream switch. This results in a significant increase in throughput on the VM"},{"line_number":40,"context_line":"and frees up CPU resources on the host OS to handle more VMs. Due to this"},{"line_number":41,"context_line":"direct connection with the upstream switch, the \"direct\" mode does not support"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_a3690a27","line":38,"updated":"2014-11-13 06:29:29.000000000","message":"I am not sure that it is accurate to say that in macvtap mode traffic is completely bypasses the hypervisor.","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22377eaeffe75a555c525ee4a41700595a6d1061","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\"direct\" or \"macvtap\" modes. In the \"direct\" mode, the VM\u0027s port is connected"},{"line_number":36,"context_line":"directly to the VF and to a macvtap device on the host in the \"macvtap\" mode."},{"line_number":37,"context_line":"In both these modes, the VM\u0027s traffic completely bypasses the hypervisor,"},{"line_number":38,"context_line":"sending and receiving traffic directly to and from the vNIC and thus the"},{"line_number":39,"context_line":"upstream switch. This results in a significant increase in throughput on the VM"},{"line_number":40,"context_line":"and frees up CPU resources on the host OS to handle more VMs. Due to this"},{"line_number":41,"context_line":"direct connection with the upstream switch, the \"direct\" mode does not support"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_d6dec33e","line":38,"in_reply_to":"5a890539_a3690a27","updated":"2014-11-13 15:55:08.000000000","message":"Done","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"80b2ce5ab8258863249b7f269e8958ebd3cba481","unresolved":false,"context_lines":[{"line_number":45,"context_line":"SR-IOV technology using the concept of port profiles. Port profiles are"},{"line_number":46,"context_line":"configuration entities that specify additional config that needs to be applied"},{"line_number":47,"context_line":"on the VF. This config includes the vlan-id, QoS (not applicable in Openstack"},{"line_number":48,"context_line":"for now) and the mode (direct/macvtap)."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"5. This mechanism driver needs to configure port profiles on the UCS Manager"},{"line_number":51,"context_line":"and pass this port profile to Nova so that it can stick it into the VM\u0027s domain"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_23651a45","line":48,"updated":"2014-11-13 06:29:29.000000000","message":"At least in scope of OpenStack, the mode is neutron port property, therefor port profile property is not relevant","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22377eaeffe75a555c525ee4a41700595a6d1061","unresolved":false,"context_lines":[{"line_number":45,"context_line":"SR-IOV technology using the concept of port profiles. Port profiles are"},{"line_number":46,"context_line":"configuration entities that specify additional config that needs to be applied"},{"line_number":47,"context_line":"on the VF. This config includes the vlan-id, QoS (not applicable in Openstack"},{"line_number":48,"context_line":"for now) and the mode (direct/macvtap)."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"5. This mechanism driver needs to configure port profiles on the UCS Manager"},{"line_number":51,"context_line":"and pass this port profile to Nova so that it can stick it into the VM\u0027s domain"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_761c2fc2","line":48,"in_reply_to":"5a890539_23651a45","updated":"2014-11-13 15:55:08.000000000","message":"So, is vlan-id. I am just trying to point out what types of configuration goes into Port Profiles since that would not be visible to a user of this mech driver. And I only pointed to QoS as not supported on Openstack (natively) yet. That also means vlan-id and port mode are part of Openstack. If it still feels incorrect, please comment.","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"80b2ce5ab8258863249b7f269e8958ebd3cba481","unresolved":false,"context_lines":[{"line_number":102,"context_line":"6. If the mechanism driver determines that an existing port profile cannot be"},{"line_number":103,"context_line":"re-used it tries to create a new port profile on the UCS manager using the"},{"line_number":104,"context_line":"vlan_id from the network. Since port profile is a vendor specific entity, we"},{"line_number":105,"context_line":"did not\twant to expose this to the cloud admin or the tenant. So, port profiles"},{"line_number":106,"context_line":"are created and maintained completely behind the scenes by the ML2 driver."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"7. Port profiles created by this mechanism driver will have the name"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_23cc3a35","line":105,"updated":"2014-11-13 06:29:29.000000000","message":"problematic char","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22377eaeffe75a555c525ee4a41700595a6d1061","unresolved":false,"context_lines":[{"line_number":102,"context_line":"6. If the mechanism driver determines that an existing port profile cannot be"},{"line_number":103,"context_line":"re-used it tries to create a new port profile on the UCS manager using the"},{"line_number":104,"context_line":"vlan_id from the network. Since port profile is a vendor specific entity, we"},{"line_number":105,"context_line":"did not\twant to expose this to the cloud admin or the tenant. So, port profiles"},{"line_number":106,"context_line":"are created and maintained completely behind the scenes by the ML2 driver."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"7. Port profiles created by this mechanism driver will have the name"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_967a7bef","line":105,"in_reply_to":"5a890539_23cc3a35","updated":"2014-11-13 15:55:08.000000000","message":"Oops! Done.","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"80b2ce5ab8258863249b7f269e8958ebd3cba481","unresolved":false,"context_lines":[{"line_number":127,"context_line":"vlan_id. This vlan_id is then written into the VM\u0027s domain XML file by Nova\u0027s"},{"line_number":128,"context_line":"generic vif driver."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"10. In the case of non-SR-IOV or regular neutron ports, an L2 agent on the"},{"line_number":131,"context_line":"compute host takes care of configuring the neutron port. The mechanism driver"},{"line_number":132,"context_line":"programs the Fabric Interconnect to allow traffic on the VLAN-id associated"},{"line_number":133,"context_line":"with this port by manipulating the Service Profile configuartion on the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_e3f8724b","line":130,"updated":"2014-11-13 06:29:29.000000000","message":"Can you please clarify why existing mechanism drivers (i.e openvswitch, linuxbridge) cannot be used to support non SR-IOV case?","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22377eaeffe75a555c525ee4a41700595a6d1061","unresolved":false,"context_lines":[{"line_number":127,"context_line":"vlan_id. This vlan_id is then written into the VM\u0027s domain XML file by Nova\u0027s"},{"line_number":128,"context_line":"generic vif driver."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"10. In the case of non-SR-IOV or regular neutron ports, an L2 agent on the"},{"line_number":131,"context_line":"compute host takes care of configuring the neutron port. The mechanism driver"},{"line_number":132,"context_line":"programs the Fabric Interconnect to allow traffic on the VLAN-id associated"},{"line_number":133,"context_line":"with this port by manipulating the Service Profile configuartion on the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_19c5dc8d","line":130,"in_reply_to":"5a890539_e3f8724b","updated":"2014-11-13 15:55:08.000000000","message":"I made an attempt at explaining it in 11. of \"Problem Description\" section.  UCS Manager runs on a L2 device called the Fabric Interconnect which needs to be configured to complete connectivity between the neutron port and the upstream switch. Enabling the VLAN associated with the newly created Neutron port on the Fabric Interconnect is the task of this mechanism driver. If UCS Manager is not part of the openstack setup, this step is not required and hence is a mechanism driver specific task.","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"80b2ce5ab8258863249b7f269e8958ebd3cba481","unresolved":false,"context_lines":[{"line_number":217,"context_line":"# ucsm_password\u003dpassword"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"# UCS Manager Host to Service Profile mapping"},{"line_number":220,"context_line":"# ucsm_host_list \u003d {\"hostname1\":\"service_profile1\", "},{"line_number":221,"context_line":"#                   \"hostname2\":\"service_profile2\"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"The deployer should also install the Cisco UCS Python SDK for this ML2 mechanism"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_03f01e66","line":220,"updated":"2014-11-13 06:29:29.000000000","message":"space to be removed","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"22377eaeffe75a555c525ee4a41700595a6d1061","unresolved":false,"context_lines":[{"line_number":217,"context_line":"# ucsm_password\u003dpassword"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"# UCS Manager Host to Service Profile mapping"},{"line_number":220,"context_line":"# ucsm_host_list \u003d {\"hostname1\":\"service_profile1\", "},{"line_number":221,"context_line":"#                   \"hostname2\":\"service_profile2\"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"The deployer should also install the Cisco UCS Python SDK for this ML2 mechanism"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_591e8464","line":220,"in_reply_to":"5a890539_03f01e66","updated":"2014-11-13 15:55:08.000000000","message":"Done","commit_id":"d5720c4edfc04e60ce12046150c92c28b3bc67ea"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3ad3ee101a3f0d80d19812600220bd1265210c96","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"3. With SR-IOV and Cisco VM-FEX a VM\u0027s port can be configured in either the"},{"line_number":35,"context_line":"\"direct\" or \"macvtap\" modes. In the \"direct\" mode, the VM\u0027s port is connected"},{"line_number":36,"context_line":"directly to the VF and to a macvtap device on the host in the \"macvtap\" mode."},{"line_number":37,"context_line":"In the direct SR-IOV mode, the VM\u0027s traffic completely bypasses the hypervisor,"},{"line_number":38,"context_line":"sending and receiving traffic directly to and from the vNIC and thus the"},{"line_number":39,"context_line":"upstream switch. This results in a significant increase in throughput on the VM"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_6138c2ef","line":36,"updated":"2014-11-14 14:49:39.000000000","message":"Can you clarify or reword the above sentence? Did you mean to say:\nIn the \"direct\" mode, the VM\u0027s port is connected directly to the VF, and in the \u0027macvtap\u0027 mode, to a macvtap device on the host.","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"3. With SR-IOV and Cisco VM-FEX a VM\u0027s port can be configured in either the"},{"line_number":35,"context_line":"\"direct\" or \"macvtap\" modes. In the \"direct\" mode, the VM\u0027s port is connected"},{"line_number":36,"context_line":"directly to the VF and to a macvtap device on the host in the \"macvtap\" mode."},{"line_number":37,"context_line":"In the direct SR-IOV mode, the VM\u0027s traffic completely bypasses the hypervisor,"},{"line_number":38,"context_line":"sending and receiving traffic directly to and from the vNIC and thus the"},{"line_number":39,"context_line":"upstream switch. This results in a significant increase in throughput on the VM"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_d77bc678","line":36,"in_reply_to":"5a890539_6138c2ef","updated":"2014-11-17 17:18:31.000000000","message":"Done","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3ad3ee101a3f0d80d19812600220bd1265210c96","unresolved":false,"context_lines":[{"line_number":39,"context_line":"upstream switch. This results in a significant increase in throughput on the VM"},{"line_number":40,"context_line":"and frees up CPU resources on the host OS to handle more VMs. Due to this"},{"line_number":41,"context_line":"direct connection with the upstream switch, the \"direct\" mode does not support"},{"line_number":42,"context_line":"live migration of the VMs that it is attached to."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"4. Cisco VM-FEX technology is based on the 802.1qbh and works on top of the"},{"line_number":45,"context_line":"SR-IOV technology using the concept of port profiles. Port profiles are"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_01045e16","line":42,"updated":"2014-11-14 14:49:39.000000000","message":"s/VMs/VM","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":39,"context_line":"upstream switch. This results in a significant increase in throughput on the VM"},{"line_number":40,"context_line":"and frees up CPU resources on the host OS to handle more VMs. Due to this"},{"line_number":41,"context_line":"direct connection with the upstream switch, the \"direct\" mode does not support"},{"line_number":42,"context_line":"live migration of the VMs that it is attached to."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"4. Cisco VM-FEX technology is based on the 802.1qbh and works on top of the"},{"line_number":45,"context_line":"SR-IOV technology using the concept of port profiles. Port profiles are"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_778a1265","line":42,"in_reply_to":"5a890539_01045e16","updated":"2014-11-17 17:18:31.000000000","message":"Done","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3ad3ee101a3f0d80d19812600220bd1265210c96","unresolved":false,"context_lines":[{"line_number":45,"context_line":"SR-IOV technology using the concept of port profiles. Port profiles are"},{"line_number":46,"context_line":"configuration entities that specify additional config that needs to be applied"},{"line_number":47,"context_line":"on the VF. This config includes the vlan-id, QoS (not applicable in Openstack"},{"line_number":48,"context_line":"for now) and the mode (direct/macvtap)."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"5. This mechanism driver needs to configure port profiles on the UCS Manager"},{"line_number":51,"context_line":"and pass this port profile to Nova so that it can stick it into the VM\u0027s domain"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_642d3095","line":48,"updated":"2014-11-14 14:49:39.000000000","message":"mode (direct/macvtap) is not part of the port profile","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":45,"context_line":"SR-IOV technology using the concept of port profiles. Port profiles are"},{"line_number":46,"context_line":"configuration entities that specify additional config that needs to be applied"},{"line_number":47,"context_line":"on the VF. This config includes the vlan-id, QoS (not applicable in Openstack"},{"line_number":48,"context_line":"for now) and the mode (direct/macvtap)."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"5. This mechanism driver needs to configure port profiles on the UCS Manager"},{"line_number":51,"context_line":"and pass this port profile to Nova so that it can stick it into the VM\u0027s domain"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_78e11f29","line":48,"in_reply_to":"5a890539_642d3095","updated":"2014-11-17 17:18:31.000000000","message":"Done","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":162,"name":"Bob Melander","email":"bob.melander@gmail.com","username":"bob-melander"},"change_message_id":"7e4c2c28f5a8e23cb2f26e9c6b2504abab912d13","unresolved":false,"context_lines":[{"line_number":62,"context_line":"interfaces on the upstream switch, ACLs can be applied on the VFs at the"},{"line_number":63,"context_line":"upstream switch.) This does not seem like an issue in the NFV use case. Also,"},{"line_number":64,"context_line":"when changes proposed by the port security extension become available, security"},{"line_number":65,"context_line":"groups can be turned off for SR-IOV ports."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"9. The mechanism driver should also be able to program the UCS Manager during"},{"line_number":68,"context_line":"the creation of regular non-SR-IOV based VMs. To achieve this, the mechanism"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_46605301","line":65,"updated":"2014-11-13 23:01:09.000000000","message":"Just curious, is there a way for users to see that security groups are not applied on SR-IOV ports, or do they have to know that from documentation?","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":62,"context_line":"interfaces on the upstream switch, ACLs can be applied on the VFs at the"},{"line_number":63,"context_line":"upstream switch.) This does not seem like an issue in the NFV use case. Also,"},{"line_number":64,"context_line":"when changes proposed by the port security extension become available, security"},{"line_number":65,"context_line":"groups can be turned off for SR-IOV ports."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"9. The mechanism driver should also be able to program the UCS Manager during"},{"line_number":68,"context_line":"the creation of regular non-SR-IOV based VMs. To achieve this, the mechanism"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_f2a7f008","line":65,"in_reply_to":"5a890539_46605301","updated":"2014-11-17 17:18:31.000000000","message":"Good point! I think this should be part of the port security extension BP.","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3ad3ee101a3f0d80d19812600220bd1265210c96","unresolved":false,"context_lines":[{"line_number":131,"context_line":"compute host takes care of configuring the neutron port. The mechanism driver"},{"line_number":132,"context_line":"programs the Fabric Interconnect to allow traffic on the VLAN-id associated"},{"line_number":133,"context_line":"with this port by manipulating the Service Profile configuartion on the"},{"line_number":134,"context_line":"UCS Manager."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Data Model Impact"},{"line_number":137,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_27e24a2f","line":134,"updated":"2014-11-14 14:49:39.000000000","message":"How do you plan to manage the Service Profiles? Should this be spelled out in this spec?","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":131,"context_line":"compute host takes care of configuring the neutron port. The mechanism driver"},{"line_number":132,"context_line":"programs the Fabric Interconnect to allow traffic on the VLAN-id associated"},{"line_number":133,"context_line":"with this port by manipulating the Service Profile configuartion on the"},{"line_number":134,"context_line":"UCS Manager."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Data Model Impact"},{"line_number":137,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_5248c4cb","line":134,"in_reply_to":"5a890539_27e24a2f","updated":"2014-11-17 17:18:31.000000000","message":"Done","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":162,"name":"Bob Melander","email":"bob.melander@gmail.com","username":"bob-melander"},"change_message_id":"7e4c2c28f5a8e23cb2f26e9c6b2504abab912d13","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"vlan_id \u003d sa.Colum(sa.Integer(), nullable\u003dFalse)"},{"line_number":148,"context_line":"profile_id \u003d sa.Column(sa.String(64), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":149,"context_line":"created_on_ucsm \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The profile_id to port_id mapping is kept track of via ml2_port_bindings table"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_e967504b","line":148,"updated":"2014-11-13 23:01:09.000000000","message":"If vlan_id is the only uscm config parameter is seems to me that this table would only have to contain one column, namely vlan_id, if vlan_id is stored in vif_details instead of profile_id.\nA non_existing vlan_id in the table would then indicate that uscm has not yet been configured with that vlan.\n\nBut perhaps I overlook something or you plan to store more information in this table later on.","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"vlan_id \u003d sa.Colum(sa.Integer(), nullable\u003dFalse)"},{"line_number":148,"context_line":"profile_id \u003d sa.Column(sa.String(64), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":149,"context_line":"created_on_ucsm \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The profile_id to port_id mapping is kept track of via ml2_port_bindings table"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_7d71110b","line":148,"in_reply_to":"5a890539_640c50ee","updated":"2014-11-17 17:18:31.000000000","message":"Please see response given to Bob\u0027s comment. Again, I don\u0027t see this as an issue unless this table is expected to become very huge.","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3ad3ee101a3f0d80d19812600220bd1265210c96","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"vlan_id \u003d sa.Colum(sa.Integer(), nullable\u003dFalse)"},{"line_number":148,"context_line":"profile_id \u003d sa.Column(sa.String(64), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":149,"context_line":"created_on_ucsm \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The profile_id to port_id mapping is kept track of via ml2_port_bindings table"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_640c50ee","line":148,"in_reply_to":"5a890539_e967504b","updated":"2014-11-14 14:49:39.000000000","message":"Is this id the same as OS-PP-\u003cvlan-id\u003e? In that case, I agree with Bob that this is redundant","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"vlan_id \u003d sa.Colum(sa.Integer(), nullable\u003dFalse)"},{"line_number":148,"context_line":"profile_id \u003d sa.Column(sa.String(64), nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":149,"context_line":"created_on_ucsm \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The profile_id to port_id mapping is kept track of via ml2_port_bindings table"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_bd66194f","line":148,"in_reply_to":"5a890539_e967504b","updated":"2014-11-17 17:18:31.000000000","message":"There are a couple of reasons for storing the profile-id explicitly in the table:\n1. Later, as the set of features supported by this mechanism driver grows, more columns could be added to this table.\n2. I do not like the fact that the association between a Port Profile and the vlan it supports is implicit in the choice of its name. I think the relationship should be made explicit to avoid errors in the future (port profile naming convention can easily be changed).","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3ad3ee101a3f0d80d19812600220bd1265210c96","unresolved":false,"context_lines":[{"line_number":149,"context_line":"created_on_ucsm \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The profile_id to port_id mapping is kept track of via ml2_port_bindings table"},{"line_number":152,"context_line":"where the profile_id is stored in vif_details."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"As the name suggests, \"created_on_ucsm\" is a flag that keeps track of whether a"},{"line_number":155,"context_line":"Port Profile was successfully created on the UCS Manager. If not, when another"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_44b834c8","line":152,"updated":"2014-11-14 14:49:39.000000000","message":"I think that this should be reworded as something like:\n\n the profile_id associated with a neutron port is stored in vif_details, which is part of th eml2_port_bindings table. \n\nThe \u0027profile_id to port_id mapping\u0027 is confusing.","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":149,"context_line":"created_on_ucsm \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The profile_id to port_id mapping is kept track of via ml2_port_bindings table"},{"line_number":152,"context_line":"where the profile_id is stored in vif_details."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"As the name suggests, \"created_on_ucsm\" is a flag that keeps track of whether a"},{"line_number":155,"context_line":"Port Profile was successfully created on the UCS Manager. If not, when another"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_7d4831b3","line":152,"in_reply_to":"5a890539_44b834c8","updated":"2014-11-17 17:18:31.000000000","message":"Done","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3ad3ee101a3f0d80d19812600220bd1265210c96","unresolved":false,"context_lines":[{"line_number":154,"context_line":"As the name suggests, \"created_on_ucsm\" is a flag that keeps track of whether a"},{"line_number":155,"context_line":"Port Profile was successfully created on the UCS Manager. If not, when another"},{"line_number":156,"context_line":"VM is launched on the same VLAN, another attempt is made at creating the same"},{"line_number":157,"context_line":"Port Profile, making this a retry mechanism of sorts."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"REST API Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_c4b18490","line":157,"updated":"2014-11-14 14:49:39.000000000","message":"In the unlikely event that the profile failed to be created, the VMs that depend on it would be left without networking connectivity. I think that there should be a way to hook up with the existing port status report mechanism between neutron and nova so that the VMs would be paused until the ports go active, or VMs errored out after timing out.","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"1b0eaa475be54ca5899294f7670748c15ad43127","unresolved":false,"context_lines":[{"line_number":154,"context_line":"As the name suggests, \"created_on_ucsm\" is a flag that keeps track of whether a"},{"line_number":155,"context_line":"Port Profile was successfully created on the UCS Manager. If not, when another"},{"line_number":156,"context_line":"VM is launched on the same VLAN, another attempt is made at creating the same"},{"line_number":157,"context_line":"Port Profile, making this a retry mechanism of sorts."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"REST API Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_18165b4c","line":157,"in_reply_to":"5a890539_c4b18490","updated":"2014-11-17 17:18:31.000000000","message":"Agreed. As far as I understand, there is no mechanism to do that today and that is a generic problem and not something specific to this mechanism driver. I would like to take this up as a generic bug fix outside the scope of this mechanism driver.","commit_id":"61751a5fb8ea55998399b6e9ff53670c1b5de1ba"}]}