)]}'
{"specs/liberty/phy-net-bridge-mapping.rst":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1ae24d5bd6441d85f84221fab7c468ac781448be","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This proposal implements physical bridge mapping for linuxbridge-agent."},{"line_number":16,"context_line":"According to this proposal, linuxbridge-agent will be able to be aware of"},{"line_number":17,"context_line":"external user-defined physical bridges and attach tap devices on it."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aaa499b_62d23cd4","line":17,"updated":"2015-04-15 07:11:19.000000000","message":"what\u0027s wrong with pre-configuring a bridge and veth-pair attached to it,\nand having the other side of the veth in interface-mappings?\n\nalong the line with: https://github.com/stackforge/networking-ofagent/blob/master/README.rst#notes-for-updating-from-icehouce","commit_id":"5b380cadb21174352cd202d294755cee72a63d99"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"2bc55bd6842b28791e850e2503dab3be0f2d1a0a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This proposal implements physical bridge mapping for linuxbridge-agent."},{"line_number":16,"context_line":"According to this proposal, linuxbridge-agent will be able to be aware of"},{"line_number":17,"context_line":"external user-defined physical bridges and attach tap devices on it."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aaa499b_dd21f5fc","line":17,"in_reply_to":"7aaa499b_62d23cd4","updated":"2015-04-15 07:40:10.000000000","message":"Thanks for your review. The solution you provided is OK. AFAIK, veth-pair is not that optimal in performance, but, I don\u0027t have data on hand.\n\nThe veth-pair way depends on the deployment but the method I provided is a feature.\n\nThis requirement is also proposed by our customers. I think it is worth implementing.","commit_id":"5b380cadb21174352cd202d294755cee72a63d99"},{"author":{"_account_id":1038,"name":"Jack McCann","username":"jack-mccann"},"change_message_id":"5c4f386a20b10ea8e8fd7b7c37812ccaf0ec3a91","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Other Deployer Impact"},{"line_number":89,"context_line":"---------------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Add an option called physical_bridge_mappings in"},{"line_number":92,"context_line":"/etc/neutron/plugins/linuxbridge/linuxbridge_conf.ini."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Developer Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aaa499b_74f0b067","line":91,"updated":"2015-04-15 13:16:41.000000000","message":"Please consider using the same option name (bridge_mappings) as OVS agent.","commit_id":"5b380cadb21174352cd202d294755cee72a63d99"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4cdb82aaa86277394ae86293eba34f092c7f53eb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://blueprints.launchpad.net/neutron/+spec/phy-net-bridge-mapping"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This proposal implements physical bridge mapping for linuxbridge-agent."},{"line_number":16,"context_line":"According to this proposal, linuxbridge-agent will be able to be aware of"},{"line_number":17,"context_line":"external user-defined physical bridges and attach tap devices on it."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_89df3dd5","line":16,"updated":"2015-06-10 23:22:09.000000000","message":"nit:  s/be able to be/be/","commit_id":"6c17dc596f11baf7f97d0aadc14f3bd41c30694a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4cdb82aaa86277394ae86293eba34f092c7f53eb","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For instance, the same physical network might need to be bridged for other"},{"line_number":29,"context_line":"purposes, or the agent moving the system\u0027s IP might not be desired or cause"},{"line_number":30,"context_line":"some unexpected error for the pre-defined environment."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"According to some enterprise end-users\u0027 feedbacks, they do need this feature"},{"line_number":33,"context_line":"to make neutron compatible with their pre-defined virtual network environment"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_d43828d5","line":30,"updated":"2015-06-10 23:22:09.000000000","message":"Any examples?  I\u0027m having trouble understanding the need.  More specifics might help to help me see the motivation.","commit_id":"6c17dc596f11baf7f97d0aadc14f3bd41c30694a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9703585aae91b09ed0dab05277ec7e0c7d5bb87d","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For instance, the same physical network might need to be bridged for other"},{"line_number":29,"context_line":"purposes, or the agent moving the system\u0027s IP might not be desired or cause"},{"line_number":30,"context_line":"some unexpected error for the pre-defined environment."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"According to some enterprise end-users\u0027 feedbacks, they do need this feature"},{"line_number":33,"context_line":"to make neutron compatible with their pre-defined virtual network environment"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_e8bfb2cd","line":30,"in_reply_to":"3afb71cf_d43828d5","updated":"2015-06-11 13:06:10.000000000","message":"+1","commit_id":"6c17dc596f11baf7f97d0aadc14f3bd41c30694a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4cdb82aaa86277394ae86293eba34f092c7f53eb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"purposes, or the agent moving the system\u0027s IP might not be desired or cause"},{"line_number":30,"context_line":"some unexpected error for the pre-defined environment."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"According to some enterprise end-users\u0027 feedbacks, they do need this feature"},{"line_number":33,"context_line":"to make neutron compatible with their pre-defined virtual network environment"},{"line_number":34,"context_line":"due to some security regulations."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_542c3898","line":32,"updated":"2015-06-10 23:22:09.000000000","message":"Can any of this feedback be referenced?  It might give more context to reviewers.","commit_id":"6c17dc596f11baf7f97d0aadc14f3bd41c30694a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9703585aae91b09ed0dab05277ec7e0c7d5bb87d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"purposes, or the agent moving the system\u0027s IP might not be desired or cause"},{"line_number":30,"context_line":"some unexpected error for the pre-defined environment."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"According to some enterprise end-users\u0027 feedbacks, they do need this feature"},{"line_number":33,"context_line":"to make neutron compatible with their pre-defined virtual network environment"},{"line_number":34,"context_line":"due to some security regulations."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_c8b2b605","line":32,"in_reply_to":"3afb71cf_542c3898","updated":"2015-06-11 13:06:10.000000000","message":"+1","commit_id":"6c17dc596f11baf7f97d0aadc14f3bd41c30694a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a23fb7a89c0d333931db27d883ea1774b693c600","unresolved":false,"context_lines":[{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a bridge_mappings configuration variable, similar to that used"},{"line_number":41,"context_line":"by the openvswitch-agent, alongside the current physical_interface_mappings"},{"line_number":42,"context_line":"variable."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"When a physical bridge for a flat network is needed, the bridge mappings would"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1af86dd1_24a15eaa","line":41,"updated":"2015-06-12 10:38:09.000000000","message":"It is great to keep consistent with openvswitch-agent.","commit_id":"6c17dc596f11baf7f97d0aadc14f3bd41c30694a"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"04c812fd213583bcc95540b83f51d3b08b120ff6","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Functional Tests"},{"line_number":146,"context_line":"----------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"None. This new feature can be fully covered by unit test cases."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"API Tests"},{"line_number":151,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_3c1f7e09","line":148,"updated":"2015-06-10 13:35:24.000000000","message":"I would think some sort of functional testing for this would be appropriate, given you\u0027re dealing with changing bridge configuration.","commit_id":"6c17dc596f11baf7f97d0aadc14f3bd41c30694a"}]}
