)]}'
{"specs/pike/ecn.rst":[{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"bb2684e6ea7f7eff68a1f4ae213e58dab38ae224","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Problem Description"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Considering that we have 2 machines, a Source and a Destination, then Explicit Congestion"},{"line_number":11,"context_line":"Notification is the process of notifying the Source machine that the network from Source to"},{"line_number":12,"context_line":"Destination is choked up and due to this the packets can be dropped. The notification therefore"},{"line_number":13,"context_line":"allows the Source to \"slow-down\" and reduce the rate of packet transfer to avoid packet drops and"},{"line_number":14,"context_line":"ensure service quality."}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_8dccc76a","line":11,"range":{"start_line":10,"start_character":70,"end_line":11,"end_character":12},"updated":"2017-08-02 15:03:43.000000000","message":"Hi, I worked for a while on ECN and this spec is interesting so I would like to provide some feedback on it if I may.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Problem Description"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Considering that we have 2 machines, a Source and a Destination, then Explicit Congestion"},{"line_number":11,"context_line":"Notification is the process of notifying the Source machine that the network from Source to"},{"line_number":12,"context_line":"Destination is choked up and due to this the packets can be dropped. The notification therefore"},{"line_number":13,"context_line":"allows the Source to \"slow-down\" and reduce the rate of packet transfer to avoid packet drops and"},{"line_number":14,"context_line":"ensure service quality."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_99a33250","line":11,"range":{"start_line":10,"start_character":70,"end_line":11,"end_character":12},"in_reply_to":"df3967d1_8dccc76a","updated":"2017-08-09 11:33:58.000000000","message":"Great, thanks :)","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"ECN can work if ECN is enabled from End-to-End, therefore, the VM/Baremetal machines, OVS and the"},{"line_number":19,"context_line":"routers lying in between the source and destination MUST have ECN enabled. This means that when a"},{"line_number":20,"context_line":"VM is booted up, if the connection between VMs is to be made ECN enabled, then we need to ensure the"},{"line_number":21,"context_line":"ECN profile is set on the VMs."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_6624630e","line":18,"range":{"start_line":18,"start_character":86,"end_line":18,"end_character":89},"updated":"2017-03-31 16:36:16.000000000","message":"Only OVS backend? Why don\u0027t you say Neutron network backend?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"ECN can work if ECN is enabled from End-to-End, therefore, the VM/Baremetal machines, OVS and the"},{"line_number":19,"context_line":"routers lying in between the source and destination MUST have ECN enabled. This means that when a"},{"line_number":20,"context_line":"VM is booted up, if the connection between VMs is to be made ECN enabled, then we need to ensure the"},{"line_number":21,"context_line":"ECN profile is set on the VMs."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_d9ed3a26","line":18,"range":{"start_line":18,"start_character":86,"end_line":18,"end_character":89},"in_reply_to":"dfeb2761_6624630e","updated":"2017-08-09 11:33:58.000000000","message":"Ok, that actually makes sense, considering that we should not limit it to OVS","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"ECN can work if ECN is enabled from End-to-End, therefore, the VM/Baremetal machines, OVS and the"},{"line_number":19,"context_line":"routers lying in between the source and destination MUST have ECN enabled. This means that when a"},{"line_number":20,"context_line":"VM is booted up, if the connection between VMs is to be made ECN enabled, then we need to ensure the"},{"line_number":21,"context_line":"ECN profile is set on the VMs."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_06beb764","line":19,"range":{"start_line":19,"start_character":17,"end_line":19,"end_character":51},"updated":"2017-03-31 16:36:16.000000000","message":"In the same host? In different hosts?\n\nCan you be explicit with the scope of this feature?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"bb2684e6ea7f7eff68a1f4ae213e58dab38ae224","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ECN can work if ECN is enabled from End-to-End, therefore, the VM/Baremetal machines, OVS and the"},{"line_number":19,"context_line":"routers lying in between the source and destination MUST have ECN enabled. This means that when a"},{"line_number":20,"context_line":"VM is booted up, if the connection between VMs is to be made ECN enabled, then we need to ensure the"},{"line_number":21,"context_line":"ECN profile is set on the VMs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_ad5f8b70","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":29},"updated":"2017-08-02 15:03:43.000000000","message":"So the ECN capability is negotiated between the VMs, but I think it\u0027s possible to set the ECN fields through OVS flows for example if we want to make it independant from VM behaviour. The only challenge is the reaction to the ECN marking that will need to be done also independantly from VMs.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ECN can work if ECN is enabled from End-to-End, therefore, the VM/Baremetal machines, OVS and the"},{"line_number":19,"context_line":"routers lying in between the source and destination MUST have ECN enabled. This means that when a"},{"line_number":20,"context_line":"VM is booted up, if the connection between VMs is to be made ECN enabled, then we need to ensure the"},{"line_number":21,"context_line":"ECN profile is set on the VMs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_1974e234","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":29},"in_reply_to":"df3967d1_ad5f8b70","updated":"2017-08-09 11:33:58.000000000","message":"What you are stating is keeping the ECN at the OVS layer, but not putting it at the instance layer. I think we should expose it to the instances as well, but I like your idea. It would reduce the effort at the nova side. There are some other benefits of the negotiation as well, like if we deploy an Instance with Windows, it doesnt guarantee that we can set the ECN bit at the instance level but at the OVS level, we might have it easier.\n\nBut the problem will be , that the instances cannot push out data at TOP speed and expect complete network bandwidth, so regulation of the instances is important, therefore I would still prefer focussing the E2E ECN enablment.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":20,"context_line":"VM is booted up, if the connection between VMs is to be made ECN enabled, then we need to ensure the"},{"line_number":21,"context_line":"ECN profile is set on the VMs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"},{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_863e4727","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":25},"updated":"2017-03-31 16:36:16.000000000","message":"This paragraph could be redone. Just as an example, from http://www.juniper.net/techpubs/en_US/junos/topics/concept/cos-qfx-series-explicit-congestion-notification-understanding.html.\n\n\"Explicit congestion notification (ECN) enables end-to-end congestion notification between two endpoints on TCP/IP based networks. The two endpoints are an ECN-enabled sender and an ECN-enabled receiver. ECN must be enabled on both endpoints and on all of the intermediate devices between the endpoints for ECN to work properly. Any device in the transmission path that does not support ECN breaks the end-to-end ECN functionality.\"","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":20,"context_line":"VM is booted up, if the connection between VMs is to be made ECN enabled, then we need to ensure the"},{"line_number":21,"context_line":"ECN profile is set on the VMs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"},{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_399206f8","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":25},"in_reply_to":"dfeb2761_863e4727","updated":"2017-08-09 11:33:58.000000000","message":"Modified a bit","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":21,"context_line":"ECN profile is set on the VMs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"},{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_e693d34e","line":24,"range":{"start_line":24,"start_character":68,"end_line":24,"end_character":69},"updated":"2017-03-31 16:36:16.000000000","message":"remove the space","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":21,"context_line":"ECN profile is set on the VMs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"},{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_f9bd9e68","line":24,"range":{"start_line":24,"start_character":68,"end_line":24,"end_character":69},"in_reply_to":"dfeb2761_e693d34e","updated":"2017-08-09 11:33:58.000000000","message":"Done","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"},{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_a69dcb5a","line":25,"updated":"2017-03-31 16:36:16.000000000","message":"add a space","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"},{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_c6b1efe3","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":14},"updated":"2017-03-31 16:36:16.000000000","message":"compatible","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"},{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_b9b71687","line":25,"in_reply_to":"dfeb2761_a69dcb5a","updated":"2017-08-09 11:33:58.000000000","message":"Done","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ECN is end-to-end enabled. If a network is ECN enabled, then it means all the VMs in that network"},{"line_number":24,"context_line":"would be ECN enabled. And if two networks are connected via a router , then the router should also"},{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_d9c2dae9","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":14},"in_reply_to":"dfeb2761_c6b1efe3","updated":"2017-08-09 11:33:58.000000000","message":"Done","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1f66f9cc90e3023caaf503052b34cc53511db173","unresolved":false,"context_lines":[{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"},{"line_number":29,"context_line":"after its creation, all VMs connected to it must be made ECN enabled  by making a setting in the"},{"line_number":30,"context_line":"VM\u0027s OS."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"All VMs which are deployed on the network which is made ECN enabled would have ECN enabled by"},{"line_number":33,"context_line":"default. However, user can change the ECN setting policy in a VM."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Sequence of Operations"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_a2f1d5cf","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":65},"updated":"2017-03-15 05:44:58.000000000","message":"i don\u0027t see how it\u0027s possible.  can you explain?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"94b99749ba3ffccfda68d2427b07be200355ec99","unresolved":false,"context_lines":[{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"},{"line_number":29,"context_line":"after its creation, all VMs connected to it must be made ECN enabled  by making a setting in the"},{"line_number":30,"context_line":"VM\u0027s OS."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"All VMs which are deployed on the network which is made ECN enabled would have ECN enabled by"},{"line_number":33,"context_line":"default. However, user can change the ECN setting policy in a VM."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Sequence of Operations"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_cb6fcd90","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":65},"in_reply_to":"3a1ff146_a2f1d5cf","updated":"2017-03-15 06:45:58.000000000","message":"Since version 2.4.20 of the Linux kernel,Linux supports three working modes of the ECN for TCP, as configured through the sysctl interface by setting parameter /proc/sys/net/ipv4/tcp_ecn to one of the following values:\n0 – disable ECN and neither initiate nor accept it\n1 – enable ECN when requested by incoming connections, and also request ECN on outgoing connection attempts\n2 – enable ECN when requested by incoming connections, but do not request ECN on outgoing connections","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"73a3f517743920750d19ecd4270c8e5a85df1c72","unresolved":false,"context_lines":[{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"},{"line_number":29,"context_line":"after its creation, all VMs connected to it must be made ECN enabled  by making a setting in the"},{"line_number":30,"context_line":"VM\u0027s OS."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"All VMs which are deployed on the network which is made ECN enabled would have ECN enabled by"},{"line_number":33,"context_line":"default. However, user can change the ECN setting policy in a VM."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Sequence of Operations"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_ebfc8940","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":65},"in_reply_to":"3a1ff146_cb6fcd90","updated":"2017-03-15 07:01:59.000000000","message":"i thought you meant to control the setting by the api.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"},{"line_number":29,"context_line":"after its creation, all VMs connected to it must be made ECN enabled  by making a setting in the"},{"line_number":30,"context_line":"VM\u0027s OS."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"All VMs which are deployed on the network which is made ECN enabled would have ECN enabled by"},{"line_number":33,"context_line":"default. However, user can change the ECN setting policy in a VM."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Sequence of Operations"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_064c779c","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":65},"in_reply_to":"3a1ff146_ebfc8940","updated":"2017-03-31 16:36:16.000000000","message":"Just to clarify:\n- You can enable and modify ECN in the host; doing that you are changing the network backend behaviour. Is that correct?\n- You also can change the endpoint (VM) ECN mode. But, can the VM user modify this? If this is possible, how are you going to enforce it?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":25,"context_line":"be ECN enabled to make ECN feature work.Therefore the ECN property needs to be set up on the Network"},{"line_number":26,"context_line":"and the router separately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A network can be made ECN enabled during or after its creation.If a network is made ECN enabled"},{"line_number":29,"context_line":"after its creation, all VMs connected to it must be made ECN enabled  by making a setting in the"},{"line_number":30,"context_line":"VM\u0027s OS."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"All VMs which are deployed on the network which is made ECN enabled would have ECN enabled by"},{"line_number":33,"context_line":"default. However, user can change the ECN setting policy in a VM."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Sequence of Operations"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_5dd2555e","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":65},"in_reply_to":"dfeb2761_064c779c","updated":"2017-08-09 11:33:58.000000000","message":"@Yamamoto San : API changes are mentioned below.\n@Rodolfo : \na) Network should have the ECN property enabled, and the backend should support it. If the Backend doesnt support ECN, then an exception would be generated. If the backend supports it, then the Network can be made ECN enabled. Same with routers. All Instances deployed on the ECN compatible network should have their ECN bit set. If the ECN bit on the instance cannot be set, then the ECN policy may not be adhered. There are 2 ways to handle that\n(i) Reset ECN property on the network\n(ii) Keep the ECN bit on the network but document this behaviour, so that the instances which are ECN compatible continue to behave properly. The ones which are not , they can be handled by the cloud admin.\n\nb) Yes, the VM user can modify this. And thats an interesting catch. And frankly I do not have a solution to it :( . But I am open to solutions.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_262bfb94","line":39,"range":{"start_line":39,"start_character":71,"end_line":39,"end_character":87},"updated":"2017-03-31 16:36:16.000000000","message":"And LB? If I\u0027m not wrong, this feature is supported by LB which is  a in-tree Neutron backend.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_491bb01a","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":69},"updated":"2017-03-31 16:36:16.000000000","message":"And the backend used as you say in the next phrase.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"bb2684e6ea7f7eff68a1f4ae213e58dab38ae224","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_dcbf22ce","line":39,"range":{"start_line":39,"start_character":71,"end_line":39,"end_character":87},"updated":"2017-08-02 15:03:43.000000000","message":"OVS supports the ECN field modification through table flows, but it does not wrap the tc RED/ECN queue yet. It means that we can force the fields to be at a certain value, but we cannot queue packets and mark them at a specific threshold.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1f66f9cc90e3023caaf503052b34cc53511db173","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_02a629c1","line":39,"range":{"start_line":39,"start_character":71,"end_line":39,"end_character":87},"updated":"2017-03-15 05:44:58.000000000","message":"what exactly do you mean when you say \"OVN supports ECN\"?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"94b99749ba3ffccfda68d2427b07be200355ec99","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_0b8e4578","line":39,"range":{"start_line":39,"start_character":71,"end_line":39,"end_character":87},"in_reply_to":"3a1ff146_02a629c1","updated":"2017-03-15 06:45:58.000000000","message":"Can be removed  :)","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"dc5f3c81406a77e8912ad4c95495de8cfb94b885","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_a391249c","line":39,"range":{"start_line":39,"start_character":71,"end_line":39,"end_character":87},"in_reply_to":"9f436f4f_7dbcf904","updated":"2017-08-09 12:44:04.000000000","message":"Through OVS flows, we can only make the packets ECN capable (ECT(0), ECT(1)) after getting them from a VM, or remove the ECN capability before forwarding the traffic to a VM. We can also mark packets CE (congestion experienced) as a RED queue does but it won\u0027t be based on the amount of traffic received by OVS, we will not be able to mark 1 packet out of a 100 for example. And if we mark CE all packets of a VM, this would lead to a very low throughput on VMs that are ECN enabled.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8b7b01b036354f5cfa3125d8d8a20a61ba4595de","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_228989c9","line":39,"range":{"start_line":39,"start_character":71,"end_line":39,"end_character":87},"in_reply_to":"9f436f4f_a391249c","updated":"2017-08-10 15:48:39.000000000","message":"Removing the ECN before forwarding the packet to the VM would result in the same issue which I told earlier , wherein the VM can forward the packets at full speed but due to Congestion experienced, the OVS may throttle the speed.\nWhat do you think?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_7dbcf904","line":39,"range":{"start_line":39,"start_character":71,"end_line":39,"end_character":87},"in_reply_to":"df3967d1_dcbf22ce","updated":"2017-08-09 11:33:58.000000000","message":"LB doesnt support ECN, IIRC. \n@Ali : how do you propose to handle it in OVS then ?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1f66f9cc90e3023caaf503052b34cc53511db173","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- ECN enablment:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_c2c5f15b","line":40,"range":{"start_line":40,"start_character":35,"end_line":40,"end_character":49},"updated":"2017-03-15 05:44:58.000000000","message":"which parameter?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"94b99749ba3ffccfda68d2427b07be200355ec99","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- Admin Setup:"},{"line_number":39,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":40,"context_line":"third party drivers need to modify this parameter to inform Admin and Openstack if ECN can be"},{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- ECN enablment:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_0b32c5f1","line":40,"range":{"start_line":40,"start_character":35,"end_line":40,"end_character":49},"in_reply_to":"3a1ff146_c2c5f15b","updated":"2017-03-15 06:45:58.000000000","message":"ECN Parameter. Will mention it in the next iteration","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d543b1c412102c9614c38fdfc9824f5d2abd2707","unresolved":false,"context_lines":[{"line_number":41,"context_line":"enabled or not."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- ECN enablment:"},{"line_number":44,"context_line":"Tenant/Admin selects a router on which the ECN is to be enabled"},{"line_number":45,"context_line":"If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN extension"},{"line_number":46,"context_line":"ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":47,"context_line":"If the third party driver supports ECN, then it will set ECN in the router configurations"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_098fe823","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":29},"updated":"2017-03-31 16:36:16.000000000","message":"Sorry, which routers are you talking about? Neutron routers?\n\nIf you are talking about external routers, how the admin can select/enable ECN through Neutron?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"bb2684e6ea7f7eff68a1f4ae213e58dab38ae224","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"a) Router recieves packets from VM1"},{"line_number":57,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":58,"context_line":"Packet Drop profile."},{"line_number":59,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up."},{"line_number":60,"context_line":"WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop"},{"line_number":61,"context_line":"Packet End point, when all packets are ECN tagged."}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_5c469223","line":58,"range":{"start_line":57,"start_character":41,"end_line":58,"end_character":19},"updated":"2017-08-02 15:03:43.000000000","message":"There are several parameters in a RED queue (min_thresh, maxthresh, max_prob,...), so are they going to be manageable from the API or will they be fixed on the router queues? The VM flows response to the ECN marking depends highly on the RED parameters so I think this is the most critical part of the implementation.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"dc5f3c81406a77e8912ad4c95495de8cfb94b885","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"a) Router recieves packets from VM1"},{"line_number":57,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":58,"context_line":"Packet Drop profile."},{"line_number":59,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up."},{"line_number":60,"context_line":"WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop"},{"line_number":61,"context_line":"Packet End point, when all packets are ECN tagged."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_a007da1c","line":58,"range":{"start_line":57,"start_character":41,"end_line":58,"end_character":19},"in_reply_to":"9f436f4f_1d284d32","updated":"2017-08-09 12:44:04.000000000","message":"Well, configuring the RED queue parameters is not an easy task as the nature of the traffic influences a lot the queue length. The problem is that if you have very strict parameters, the VMs could end up with a very low throughput, while if your parameters are too wide, you might have no effect on the VMs. I think that the parameters shouldn\u0027t be fixed but made adjustable from the API so that the admin can apply the correct parameters for his setup and the nature of the traffic flowing through the router. I admit it\u0027s more work for the admin but if you fix the parameters once and for all for every type of traffic, it would lead to very random behaviors from VMs.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8b7b01b036354f5cfa3125d8d8a20a61ba4595de","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"a) Router recieves packets from VM1"},{"line_number":57,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":58,"context_line":"Packet Drop profile."},{"line_number":59,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up."},{"line_number":60,"context_line":"WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop"},{"line_number":61,"context_line":"Packet End point, when all packets are ECN tagged."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_e207011c","line":58,"range":{"start_line":57,"start_character":41,"end_line":58,"end_character":19},"in_reply_to":"9f436f4f_a007da1c","updated":"2017-08-10 15:48:39.000000000","message":"Hmm, I agree with your proposal. But what sort of adjustment parameters would we provide to the admin.\nAlso, I think if there are some parameters which we need to fix just once in the system, then we can do it in the config file, for example.\nLets discuss it over email/IRC, if required.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"a) Router recieves packets from VM1"},{"line_number":57,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":58,"context_line":"Packet Drop profile."},{"line_number":59,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up."},{"line_number":60,"context_line":"WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop"},{"line_number":61,"context_line":"Packet End point, when all packets are ECN tagged."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_1d284d32","line":58,"range":{"start_line":57,"start_character":41,"end_line":58,"end_character":19},"in_reply_to":"df3967d1_5c469223","updated":"2017-08-09 11:33:58.000000000","message":"I believe they should be fixed on the router queues. However I would like to know your take on it.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"bb2684e6ea7f7eff68a1f4ae213e58dab38ae224","unresolved":false,"context_lines":[{"line_number":59,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up."},{"line_number":60,"context_line":"WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop"},{"line_number":61,"context_line":"Packet End point, when all packets are ECN tagged."},{"line_number":62,"context_line":"d) When the router experiences congestion, it marks the DiffServ bits in the IP packet with 11 for"},{"line_number":63,"context_line":"Congestion-Experienced ( CE )."},{"line_number":64,"context_line":"e) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1"},{"line_number":65,"context_line":"( ECN Echo flag )."}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_dce042cf","line":62,"range":{"start_line":62,"start_character":56,"end_line":62,"end_character":64},"updated":"2017-08-02 15:03:43.000000000","message":"The TOS field in fact (IPv4) or the Traffic Class field (IPv6), which are comprised of 6 bits for the DiffServ field and 2 bits for the ECN field.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8b7b01b036354f5cfa3125d8d8a20a61ba4595de","unresolved":false,"context_lines":[{"line_number":59,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up."},{"line_number":60,"context_line":"WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop"},{"line_number":61,"context_line":"Packet End point, when all packets are ECN tagged."},{"line_number":62,"context_line":"d) When the router experiences congestion, it marks the DiffServ bits in the IP packet with 11 for"},{"line_number":63,"context_line":"Congestion-Experienced ( CE )."},{"line_number":64,"context_line":"e) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1"},{"line_number":65,"context_line":"( ECN Echo flag )."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_6509db2a","line":62,"range":{"start_line":62,"start_character":56,"end_line":62,"end_character":64},"in_reply_to":"df3967d1_dce042cf","updated":"2017-08-10 15:48:39.000000000","message":"Sorry, couldnt understand this comment.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"bb2684e6ea7f7eff68a1f4ae213e58dab38ae224","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ECN supports the following:"},{"line_number":69,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":70,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":71,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"ECN does not support the following:"},{"line_number":74,"context_line":"- IP packets with MPLS encapsulation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_7c603602","line":71,"range":{"start_line":71,"start_character":2,"end_line":71,"end_character":74},"updated":"2017-08-02 15:03:43.000000000","message":"It\u0027s possible to make the inner packet ECN capable, and the outer header will inherit the ECN value during encapsulation according to the RFC 6040: https://tools.ietf.org/html/rfc6040\n\nWhen the packet is decapsulated, the inner packet will be CE marked if the outer packet was during tunneling.\n\nThe linux kernel implements RFC 6040 since v3.7\nSo both OVS and LB VxLAN ports for example can copy the ECN value from the inner to the outer header and vice versa without any specific configuration on compute nodes:\nhttp://elixir.free-electrons.com/linux/v4.12/source/include/net/inet_ecn.h#L167","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"dc5f3c81406a77e8912ad4c95495de8cfb94b885","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ECN supports the following:"},{"line_number":69,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":70,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":71,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"ECN does not support the following:"},{"line_number":74,"context_line":"- IP packets with MPLS encapsulation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_80c61667","line":71,"range":{"start_line":71,"start_character":2,"end_line":71,"end_character":74},"in_reply_to":"9f436f4f_5da135a9","updated":"2017-08-09 12:44:04.000000000","message":"Yes, if the kernel version is \u003e3.7, then it\u0027s enough to put the ECN capability in the inner header.","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8b7b01b036354f5cfa3125d8d8a20a61ba4595de","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ECN supports the following:"},{"line_number":69,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":70,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":71,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"ECN does not support the following:"},{"line_number":74,"context_line":"- IP packets with MPLS encapsulation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_05aa0fd1","line":71,"range":{"start_line":71,"start_character":2,"end_line":71,"end_character":74},"in_reply_to":"9f436f4f_80c61667","updated":"2017-08-10 15:48:39.000000000","message":"I think most of the versions supported by Openstack  ( Ubuntu 16.X, ubuntu 14.x, RHEL 7.X etc) have kernel version 3.7 and above , so we can probably include it in the internal header","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"976e89a63c19e3ca2d7c2ef2e19bd5f401c1aa15","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ECN supports the following:"},{"line_number":69,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":70,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":71,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"ECN does not support the following:"},{"line_number":74,"context_line":"- IP packets with MPLS encapsulation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f436f4f_5da135a9","line":71,"range":{"start_line":71,"start_character":2,"end_line":71,"end_character":74},"in_reply_to":"df3967d1_7c603602","updated":"2017-08-09 11:33:58.000000000","message":"Hmm, then it depends on the Linux Kernel version , right?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1f66f9cc90e3023caaf503052b34cc53511db173","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Future Scope of Action"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":126,"context_line":"- Allow VMs and networks to be ECN enabled after they have been created."},{"line_number":127,"context_line":"- Allow Users to disable ECN profile on a VM."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Low level implementation details in l3 routers"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_c20091ad","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":45},"updated":"2017-03-15 05:44:58.000000000","message":"how?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"94b99749ba3ffccfda68d2427b07be200355ec99","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Future Scope of Action"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":126,"context_line":"- Allow VMs and networks to be ECN enabled after they have been created."},{"line_number":127,"context_line":"- Allow Users to disable ECN profile on a VM."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Low level implementation details in l3 routers"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_8b25d5ac","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":45},"in_reply_to":"3a1ff146_c20091ad","updated":"2017-03-15 06:45:58.000000000","message":"By providing CLI/API for the same?","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1f66f9cc90e3023caaf503052b34cc53511db173","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Low level implementation details in l3 routers"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":131,"context_line":"\u003cTo-Do\u003e"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"References"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_42eca1c7","line":131,"range":{"start_line":131,"start_character":1,"end_line":131,"end_character":6},"updated":"2017-03-15 05:44:58.000000000","message":"i guess this is the core of this spec. :-)","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"94b99749ba3ffccfda68d2427b07be200355ec99","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Low level implementation details in l3 routers"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":131,"context_line":"\u003cTo-Do\u003e"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"References"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_eb1d6967","line":131,"range":{"start_line":131,"start_character":1,"end_line":131,"end_character":6},"in_reply_to":"3a1ff146_42eca1c7","updated":"2017-03-15 06:45:58.000000000","message":"Yeah, thats why my Workflow is -1 , just because of this :)","commit_id":"990a7ef8c7f93a9bfd72a1f13e94ad9655f90d4c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Explicit Congestion Notification in Neutron"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_39d94a56","line":1,"range":{"start_line":1,"start_character":31,"end_line":1,"end_character":33},"updated":"2017-08-15 17:06:11.000000000","message":"Move the spec from \"Pike\" folder into \"Queens\".\nExtend characters to match the end of the line below.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Explicit Congestion Notification in Neutron"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_c1b357e8","line":1,"range":{"start_line":1,"start_character":31,"end_line":1,"end_character":33},"in_reply_to":"9f436f4f_39d94a56","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Explicit Congestion Notification in Neutron"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Problem Description"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_4052d73c","line":5,"updated":"2017-08-15 17:06:11.000000000","message":"ditto","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Explicit Congestion Notification in Neutron"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Problem Description"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_e1b09bdf","line":5,"in_reply_to":"9f436f4f_4052d73c","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Problem Description"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Considering that we have 2 machines, a Source and a Destination, then Explicit Congestion"},{"line_number":11,"context_line":"Notification is the process of notifying the Source machine that the network from Source to"},{"line_number":12,"context_line":"Destination is choked up and due to this the packets can be dropped. The notification therefore"},{"line_number":13,"context_line":"allows the Source to \"slow-down\" and reduce the rate of packet transfer to avoid packet drops and"},{"line_number":14,"context_line":"ensure service quality."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_80a55f49","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":23},"updated":"2017-08-15 17:06:11.000000000","message":"This isn\u0027t really a problem description and more an explanation of what ECN will do when enabled.\n\nMy knowledge of ECN isn\u0027t 100% so just go through this to make sure I haven\u0027t made a mistake, this is largely quoted from RFC 3168.\n\n\"Loss as an indication of congestion in the network is appropriate for pure best-effort data carried by TCP, with little or no sensitivity to delay or loss of individual packets. However, these mechanisms are not intended to help applications that are sensitive to the delay or loss of one or more individual packets.\n\nSince TCP determines the appropriate congestion window to use by gradually increasing the window size until it experiences a dropped packet, this causes the queues at the bottleneck router to build up.\n\nMost packet drop policies at the router that are not sensitive to the load placed by each individual flow, results in some of the packets of latency-sensitive flows possibly being dropped.\"","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Problem Description"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Considering that we have 2 machines, a Source and a Destination, then Explicit Congestion"},{"line_number":11,"context_line":"Notification is the process of notifying the Source machine that the network from Source to"},{"line_number":12,"context_line":"Destination is choked up and due to this the packets can be dropped. The notification therefore"},{"line_number":13,"context_line":"allows the Source to \"slow-down\" and reduce the rate of packet transfer to avoid packet drops and"},{"line_number":14,"context_line":"ensure service quality."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_5982a501","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":23},"in_reply_to":"9f436f4f_80a55f49","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"allows the Source to \"slow-down\" and reduce the rate of packet transfer to avoid packet drops and"},{"line_number":14,"context_line":"ensure service quality."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, the source and destination instances"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_a39d0d67","line":16,"updated":"2017-08-15 17:06:11.000000000","message":"I\u0027d move \"Dependencies\" and \"Sequence of Operations\" to after \"Proposed Change\".","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":13,"context_line":"allows the Source to \"slow-down\" and reduce the rate of packet transfer to avoid packet drops and"},{"line_number":14,"context_line":"ensure service quality."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, the source and destination instances"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_f97a7921","line":16,"in_reply_to":"9f436f4f_a39d0d67","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"ensure service quality."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, the source and destination instances"},{"line_number":20,"context_line":"(which can be VM/Baremetal machines), Neutron Backend and the routers lying in between the instances"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_20459370","line":17,"updated":"2017-08-15 17:06:11.000000000","message":"Extend to end of \"Dependencies\"","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":14,"context_line":"ensure service quality."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, the source and destination instances"},{"line_number":20,"context_line":"(which can be VM/Baremetal machines), Neutron Backend and the routers lying in between the instances"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_d9757533","line":17,"in_reply_to":"9f436f4f_20459370","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, the source and destination instances"},{"line_number":20,"context_line":"(which can be VM/Baremetal machines), Neutron Backend and the routers lying in between the instances"},{"line_number":21,"context_line":"MUST have ECN enabled. This means that when a instance is booted up, if the connection between"},{"line_number":22,"context_line":"instance is to be made ECN enabled, then we need to ensure the ECN profile is set on the instance."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_c30b7127","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":22},"updated":"2017-08-15 17:06:11.000000000","message":"Explicit Congestion Notification(ECN) provides the most benefits when enabled from End-to-End. As a result, ECN will need to be enabled in the instances, in the Neutron back end and the Routers connection the instances.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Dependencies"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, the source and destination instances"},{"line_number":20,"context_line":"(which can be VM/Baremetal machines), Neutron Backend and the routers lying in between the instances"},{"line_number":21,"context_line":"MUST have ECN enabled. This means that when a instance is booted up, if the connection between"},{"line_number":22,"context_line":"instance is to be made ECN enabled, then we need to ensure the ECN profile is set on the instance."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_19a53da2","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":22},"in_reply_to":"9f436f4f_c30b7127","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, the source and destination instances"},{"line_number":20,"context_line":"(which can be VM/Baremetal machines), Neutron Backend and the routers lying in between the instances"},{"line_number":21,"context_line":"MUST have ECN enabled. This means that when a instance is booted up, if the connection between"},{"line_number":22,"context_line":"instance is to be made ECN enabled, then we need to ensure the ECN profile is set on the instance."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_56ecdd28","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":98},"updated":"2017-08-15 17:06:11.000000000","message":"I\u0027m unsure what this line means, from what I understand this isn\u0027t like QoS in that this can be attached and detached from a port (as you saying this is further work later in the spec).\n\n\nDoes that mean this would need to used with Nova Availability Zones to ensure all ECN enabled instances are assigned to hosts that support ECN and that are connected to Routers that support ECN?","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, the source and destination instances"},{"line_number":20,"context_line":"(which can be VM/Baremetal machines), Neutron Backend and the routers lying in between the instances"},{"line_number":21,"context_line":"MUST have ECN enabled. This means that when a instance is booted up, if the connection between"},{"line_number":22,"context_line":"instance is to be made ECN enabled, then we need to ensure the ECN profile is set on the instance."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_992dadff","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":98},"in_reply_to":"9f436f4f_56ecdd28","updated":"2017-08-17 03:04:47.000000000","message":"There is some difference from your understanding.\nECN would be enabled on the network and the routers so the ports which are connected to the network would be affected by it, but not inheriting the property of ECN. But , it may be reasonable to consider availability zones for future cope where in the instances are connected to routers and networks that support ECN. \nAlso, while investigating, I found that we cannot directly modify the ECN parameters in the VM unless we pass --user-data. Now this would be a little complicated, so I thought it would be better if we can document the VM related change for now.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_d64d6d3e","line":26,"range":{"start_line":26,"start_character":25,"end_line":26,"end_character":43},"updated":"2017-08-15 17:06:11.000000000","message":"s/ ECN functionality/ coverage\n\nECN is used far too often in this spec :P","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_f65bd1f2","line":26,"range":{"start_line":26,"start_character":49,"end_line":26,"end_character":52},"updated":"2017-08-15 17:06:11.000000000","message":"s/ ECN/ this feature\n\n:P","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_966c859c","line":26,"range":{"start_line":26,"start_character":78,"end_line":26,"end_character":85},"updated":"2017-08-15 17:06:11.000000000","message":"s/ network/ the network","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_d94695c0","line":26,"range":{"start_line":26,"start_character":78,"end_line":26,"end_character":85},"in_reply_to":"9f436f4f_966c859c","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_3936c152","line":26,"range":{"start_line":26,"start_character":25,"end_line":26,"end_character":43},"in_reply_to":"9f436f4f_d64d6d3e","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_f93b9934","line":26,"range":{"start_line":26,"start_character":49,"end_line":26,"end_character":52},"in_reply_to":"9f436f4f_f65bd1f2","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_16341549","line":27,"range":{"start_line":27,"start_character":80,"end_line":27,"end_character":81},"updated":"2017-08-15 17:06:11.000000000","message":"Space before \"T\"","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_36e399db","line":27,"range":{"start_line":27,"start_character":54,"end_line":27,"end_character":79},"updated":"2017-08-15 17:06:11.000000000","message":"must all haven ECN enabled","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_b6c9c959","line":27,"range":{"start_line":27,"start_character":20,"end_line":27,"end_character":27},"updated":"2017-08-15 17:06:11.000000000","message":"s/ routers/ the routers","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_590ce592","line":27,"range":{"start_line":27,"start_character":80,"end_line":27,"end_character":81},"in_reply_to":"9f436f4f_16341549","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_390fe188","line":27,"range":{"start_line":27,"start_character":54,"end_line":27,"end_character":79},"in_reply_to":"9f436f4f_36e399db","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":24,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_f924b90e","line":27,"range":{"start_line":27,"start_character":20,"end_line":27,"end_character":27},"in_reply_to":"9f436f4f_b6c9c959","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_16ff7567","line":28,"range":{"start_line":28,"start_character":69,"end_line":28,"end_character":70},"updated":"2017-08-15 17:06:11.000000000","message":"Add a space before \"A\"","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_96d92523","line":28,"range":{"start_line":28,"start_character":35,"end_line":28,"end_character":42},"updated":"2017-08-15 17:06:11.000000000","message":"network","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_d91fb5b4","line":28,"range":{"start_line":28,"start_character":69,"end_line":28,"end_character":70},"in_reply_to":"9f436f4f_16ff7567","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":25,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_b91ab1c2","line":28,"range":{"start_line":28,"start_character":35,"end_line":28,"end_character":42},"in_reply_to":"9f436f4f_96d92523","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"},{"line_number":32,"context_line":"have ECN enabled by default. However, user can change the ECN setting policy in a VM."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_764241ad","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":39},"updated":"2017-08-15 17:06:11.000000000","message":"Space before \"I\"","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":26,"context_line":"ECN breaks the end-to-end ECN functionality. For ECN to work , the instances, network connecting"},{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"},{"line_number":32,"context_line":"have ECN enabled by default. However, user can change the ECN setting policy in a VM."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_997b6df3","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":39},"in_reply_to":"9f436f4f_764241ad","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"those instances and routers connecting those networks must have an ECN property.Therefore the ECN"},{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"},{"line_number":32,"context_line":"have ECN enabled by default. However, user can change the ECN setting policy in a VM."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_d658cd88","line":30,"range":{"start_line":30,"start_character":35,"end_line":30,"end_character":99},"updated":"2017-08-15 17:06:11.000000000","message":"have ECN enabled in the Instance\u0027s OS if the admin wishes those Instances to benefit from ECN.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"},{"line_number":32,"context_line":"have ECN enabled by default. However, user can change the ECN setting policy in a VM."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Sequence of Operations"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_96fc853e","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":85},"updated":"2017-08-15 17:06:11.000000000","message":"I\u0027d remove this line as it isn\u0027t necessarily true. Non ECN enable instances could be placed on the Network, they just wouldn\u0027t benefit from the ECN aspect of it.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":28,"context_line":"property needs to be set up on the Network and the router separately.A network can be made ECN"},{"line_number":29,"context_line":"enabled during or after its creation.If a network is made ECN compatible after its creation,"},{"line_number":30,"context_line":"all instances connected to it must be have ECN enabled by setting a configuration in the instance\u0027s"},{"line_number":31,"context_line":"OS. All VMs which are deployed on the network after the network has been made ECN enabled should"},{"line_number":32,"context_line":"have ECN enabled by default. However, user can change the ECN setting policy in a VM."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Sequence of Operations"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_595aa582","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":85},"in_reply_to":"9f436f4f_96fc853e","updated":"2017-08-17 03:04:47.000000000","message":"Done, besides, its covered by the earlier comment now :)","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- Admin Setup:"},{"line_number":38,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":39,"context_line":"third party drivers need to modify the ECN parameter to inform Admin and Openstack if ECN can be"},{"line_number":40,"context_line":"enabled or not."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_599e4eb9","line":38,"range":{"start_line":38,"start_character":71,"end_line":38,"end_character":83},"updated":"2017-08-15 17:06:11.000000000","message":"Maybe don\u0027t mention OVS specifically.\nUnless you plan on making this an out of tree extension we should aim to enable it on at least OvS and Linux Bridge.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- Admin Setup:"},{"line_number":38,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS supports ECN but other"},{"line_number":39,"context_line":"third party drivers need to modify the ECN parameter to inform Admin and Openstack if ECN can be"},{"line_number":40,"context_line":"enabled or not."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_79cc4934","line":38,"range":{"start_line":38,"start_character":71,"end_line":38,"end_character":83},"in_reply_to":"9f436f4f_599e4eb9","updated":"2017-08-17 03:04:47.000000000","message":"As per the previous comments, it seems LB is also supporting ECN, so waiting for further comments :)","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"a) Router recieves packets from VM1"},{"line_number":56,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":57,"context_line":"Packet Drop profile."},{"line_number":58,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up."},{"line_number":59,"context_line":"WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop"},{"line_number":60,"context_line":"Packet End point, when all packets are ECN tagged."},{"line_number":61,"context_line":"d) When the router experiences congestion, it marks the DiffServ bits in the IP packet with 11 for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_5931aea2","line":58,"range":{"start_line":58,"start_character":90,"end_line":58,"end_character":101},"updated":"2017-08-15 17:06:11.000000000","message":"Move to next line, they just about creep over the 80 char limit.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":55,"context_line":"a) Router recieves packets from VM1"},{"line_number":56,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":57,"context_line":"Packet Drop profile."},{"line_number":58,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up."},{"line_number":59,"context_line":"WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop"},{"line_number":60,"context_line":"Packet End point, when all packets are ECN tagged."},{"line_number":61,"context_line":"d) When the router experiences congestion, it marks the DiffServ bits in the IP packet with 11 for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_39d241d2","line":58,"range":{"start_line":58,"start_character":90,"end_line":58,"end_character":101},"in_reply_to":"9f436f4f_5931aea2","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"In case of DVR, the OVS/Neutron Backend agent running on the Compute node can be notified"},{"line_number":79,"context_line":"from the neutron-server running on the controller node to set up the ECN bit."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Terminology and API"},{"line_number":82,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible API changes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_c00b6727","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":19},"updated":"2017-08-15 17:06:11.000000000","message":"Change to \"Proposed Change\"","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":78,"context_line":"In case of DVR, the OVS/Neutron Backend agent running on the Compute node can be notified"},{"line_number":79,"context_line":"from the neutron-server running on the controller node to set up the ECN bit."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Terminology and API"},{"line_number":82,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible API changes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_19dd3ddf","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":19},"in_reply_to":"9f436f4f_c00b6727","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Terminology and API"},{"line_number":82,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible API changes"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"ECN can be enabled as a separate extension in Neutron, so that it can be plugged in by the user as"},{"line_number":87,"context_line":"per their own convineance. It can be enabled as thus:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_79e0f226","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":20},"updated":"2017-08-15 17:06:11.000000000","message":"Also include discussion on how this will work with the q-l3 and any additional configuration the q-agt may need to do to enable this feature in other sub headers like this one.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Terminology and API"},{"line_number":82,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible API changes"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"ECN can be enabled as a separate extension in Neutron, so that it can be plugged in by the user as"},{"line_number":87,"context_line":"per their own convineance. It can be enabled as thus:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_99f24d6f","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":20},"in_reply_to":"9f436f4f_79e0f226","updated":"2017-08-17 03:04:47.000000000","message":"Added some information below","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"per their own convineance. It can be enabled as thus:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"..code-block: Python"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":92,"context_line":"    \u0027networks\u0027: {"},{"line_number":93,"context_line":"        ECN: {\u0027allow_post\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_03b4d9cf","line":90,"updated":"2017-08-15 17:06:11.000000000","message":"Should this also include the neutron \"port\" attribute if it requires end to end enablement?","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":87,"context_line":"per their own convineance. It can be enabled as thus:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"..code-block: Python"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":92,"context_line":"    \u0027networks\u0027: {"},{"line_number":93,"context_line":"        ECN: {\u0027allow_post\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_39eb6178","line":90,"in_reply_to":"9f436f4f_03b4d9cf","updated":"2017-08-17 03:04:47.000000000","message":"Not necessary ( as mentioned earlier)","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"17e17dc1ebd5c461e459fa4f1c9daafd15f35bc0","unresolved":false,"context_lines":[{"line_number":106,"context_line":"}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"DataModel Impact"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":"Networks"},{"line_number":111,"context_line":"+-------------+--------+---------+-----------+-------------+---------------+"},{"line_number":112,"context_line":"| Attribute   |Type    | Access  | Default   | Validation/ | Description   |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_00484f84","line":109,"range":{"start_line":109,"start_character":16,"end_line":109,"end_character":19},"updated":"2017-08-15 17:06:11.000000000","message":"Remove excess characters.","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"33e2dcde7fb10630bebebe7f533e133ef517a540","unresolved":false,"context_lines":[{"line_number":106,"context_line":"}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"DataModel Impact"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":"Networks"},{"line_number":111,"context_line":"+-------------+--------+---------+-----------+-------------+---------------+"},{"line_number":112,"context_line":"| Attribute   |Type    | Access  | Default   | Validation/ | Description   |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_19065d53","line":109,"range":{"start_line":109,"start_character":16,"end_line":109,"end_character":19},"in_reply_to":"9f436f4f_00484f84","updated":"2017-08-17 03:04:47.000000000","message":"Done","commit_id":"a93689b85de2d238d2f2e1ce45410280cf475a3b"}],"specs/queens/ecn.rst":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"fd76bbb8186ab369efcf5c85daa113b9e02b5da4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"In case of DVR, the OVS/Neutron Backend agent running on the Compute node can be notified"},{"line_number":80,"context_line":"from the neutron-server running on the controller node to set up the ECN bit."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Terminology and API"},{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Possible API changes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f436f4f_9cddb2e1","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":19},"updated":"2017-08-16 10:02:57.000000000","message":"\"Proposed Change\" being missing from a spec is a fail condition for the tests","commit_id":"035b00bdc31b60c1e168cb4da2d76b784000d672"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"5673e0c63aa1bdaf1f8d8b43e75823bfe90b5cb4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"In case of HA and DVR, ECN would not be impacted. ECN would be enabled on the router namespace when it is created,"},{"line_number":140,"context_line":"so it doesn\u0027t matter if it is created on compute node or network node."},{"line_number":141,"context_line":"For Vendor Specific L3 Routers, it would depend on the vendors to implement ECN specific functionality."},{"line_number":142,"context_line":"References"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":"http://www.juniper.net/techpubs/en_US/junos14.1/topics/concept/cos-qfx-series-explicit-congestion-notification-understanding.html"},{"line_number":145,"context_line":"http://paste.openstack.org/show/494363/"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f436f4f_d6baf6be","line":142,"updated":"2017-08-16 12:19:33.000000000","message":"You need a new line before this header as well.","commit_id":"035b00bdc31b60c1e168cb4da2d76b784000d672"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe545040db969daae42bf980a12c97b5b6cbdf02","unresolved":false,"context_lines":[{"line_number":33,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":34,"context_line":"    \u0027networks\u0027: {"},{"line_number":35,"context_line":"        ECN: {\u0027allow_post\u0027: True,"},{"line_number":36,"context_line":"              \u0027allow_put\u0027: False,     #\u003c----- can be changed in the future to TRUE"},{"line_number":37,"context_line":"              \u0027default\u0027: False,"},{"line_number":38,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_1154df53","line":36,"updated":"2017-08-17 19:54:00.000000000","message":"Why it can\u0027t be updated (now)?","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a051150c9f616b97813ca274c9a0469036f7f786","unresolved":false,"context_lines":[{"line_number":33,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":34,"context_line":"    \u0027networks\u0027: {"},{"line_number":35,"context_line":"        ECN: {\u0027allow_post\u0027: True,"},{"line_number":36,"context_line":"              \u0027allow_put\u0027: False,     #\u003c----- can be changed in the future to TRUE"},{"line_number":37,"context_line":"              \u0027default\u0027: False,"},{"line_number":38,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_04581a54","line":36,"in_reply_to":"9f436f4f_1154df53","updated":"2017-09-21 04:32:32.000000000","message":"Wanted to avoid modifying parameters of the existing network /routersright now. Let the newly networks created implement ECN first, then the same logic can be implmented for the existing network and routers.\n\nBut I realized now that it prevents the new networks with ECN to have thier ECN disabled, which makes no sense. So , lets move it to True and see what happens","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe545040db969daae42bf980a12c97b5b6cbdf02","unresolved":false,"context_lines":[{"line_number":41,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":42,"context_line":"    \u0027routers\u0027: {"},{"line_number":43,"context_line":"        ECN: {\u0027allow_post\u0027: True,"},{"line_number":44,"context_line":"              \u0027allow_put\u0027: False,  #\u003c----- can be changed in the future to TRUE"},{"line_number":45,"context_line":"              \u0027default\u0027: False,"},{"line_number":46,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":47,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_f1503b61","line":44,"updated":"2017-08-17 19:54:00.000000000","message":"same question here","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a051150c9f616b97813ca274c9a0469036f7f786","unresolved":false,"context_lines":[{"line_number":41,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":42,"context_line":"    \u0027routers\u0027: {"},{"line_number":43,"context_line":"        ECN: {\u0027allow_post\u0027: True,"},{"line_number":44,"context_line":"              \u0027allow_put\u0027: False,  #\u003c----- can be changed in the future to TRUE"},{"line_number":45,"context_line":"              \u0027default\u0027: False,"},{"line_number":46,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":47,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_e454f623","line":44,"in_reply_to":"9f436f4f_f1503b61","updated":"2017-09-21 04:32:32.000000000","message":"same","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe545040db969daae42bf980a12c97b5b6cbdf02","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":60,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":61,"context_line":"ECN breaks the end-to-end coverage. For the feature to work , the instances, the network connecting"},{"line_number":62,"context_line":"those instances and routers connecting those networks must all have the ECN property. Therefore"},{"line_number":63,"context_line":"the ECN property needs to be set up on the network and the router separately. A network can be made"},{"line_number":64,"context_line":"ECN enabled during or after its creation. If a network is made ECN compatible after its creation,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_d14d37c5","line":61,"updated":"2017-08-17 19:54:00.000000000","message":"nit: space before comma should be removed","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a051150c9f616b97813ca274c9a0469036f7f786","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"ECN must be enabled on both sender/reciever and on all of the intermediate devices between the"},{"line_number":60,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":61,"context_line":"ECN breaks the end-to-end coverage. For the feature to work , the instances, the network connecting"},{"line_number":62,"context_line":"those instances and routers connecting those networks must all have the ECN property. Therefore"},{"line_number":63,"context_line":"the ECN property needs to be set up on the network and the router separately. A network can be made"},{"line_number":64,"context_line":"ECN enabled during or after its creation. If a network is made ECN compatible after its creation,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_e73078eb","line":61,"in_reply_to":"9f436f4f_d14d37c5","updated":"2017-09-21 04:32:32.000000000","message":"Done","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe545040db969daae42bf980a12c97b5b6cbdf02","unresolved":false,"context_lines":[{"line_number":63,"context_line":"the ECN property needs to be set up on the network and the router separately. A network can be made"},{"line_number":64,"context_line":"ECN enabled during or after its creation. If a network is made ECN compatible after its creation,"},{"line_number":65,"context_line":"all instances connected to it must be have ECN enabled in the instance\u0027s OS if the admin wishes the"},{"line_number":66,"context_line":"instances to benefit from it."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Sequence of Operations"},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_b14ab3a9","line":66,"updated":"2017-08-17 19:54:00.000000000","message":"so maybe it should also have extended attribute for network?","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a051150c9f616b97813ca274c9a0469036f7f786","unresolved":false,"context_lines":[{"line_number":63,"context_line":"the ECN property needs to be set up on the network and the router separately. A network can be made"},{"line_number":64,"context_line":"ECN enabled during or after its creation. If a network is made ECN compatible after its creation,"},{"line_number":65,"context_line":"all instances connected to it must be have ECN enabled in the instance\u0027s OS if the admin wishes the"},{"line_number":66,"context_line":"instances to benefit from it."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Sequence of Operations"},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_a434aefc","line":66,"in_reply_to":"9f436f4f_b14ab3a9","updated":"2017-09-21 04:32:32.000000000","message":"I guess the API definition is creating the extended attribute for network, isnt it?","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe545040db969daae42bf980a12c97b5b6cbdf02","unresolved":false,"context_lines":[{"line_number":74,"context_line":"enabled or not."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- ECN enablment:"},{"line_number":77,"context_line":"Tenant/Admin selects a  Neutron router on which the ECN is to be enabled"},{"line_number":78,"context_line":"If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN extension"},{"line_number":79,"context_line":"ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":80,"context_line":"If the third party driver supports ECN, then it will set ECN in the router configurations"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_91c56f0d","line":77,"updated":"2017-08-17 19:54:00.000000000","message":"nit: two spaces before \"Neutron\"","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a051150c9f616b97813ca274c9a0469036f7f786","unresolved":false,"context_lines":[{"line_number":74,"context_line":"enabled or not."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- ECN enablment:"},{"line_number":77,"context_line":"Tenant/Admin selects a  Neutron router on which the ECN is to be enabled"},{"line_number":78,"context_line":"If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN extension"},{"line_number":79,"context_line":"ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":80,"context_line":"If the third party driver supports ECN, then it will set ECN in the router configurations"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_c774549f","line":77,"in_reply_to":"9f436f4f_91c56f0d","updated":"2017-09-21 04:32:32.000000000","message":"Done","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe545040db969daae42bf980a12c97b5b6cbdf02","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"|-------------|             _________                |-------------|"},{"line_number":85,"context_line":"|    VM1      |  -----\u003e    | Router |   --------\u003e    |     VM2     |"},{"line_number":86,"context_line":"|-------------|            |________|                |-------------|"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_71ca0b1b","line":86,"updated":"2017-08-17 19:54:00.000000000","message":"\"router\" here is Openstack router, made usually by L3 agent or it\u0027s some hardware routing in DC?","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a051150c9f616b97813ca274c9a0469036f7f786","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"|-------------|             _________                |-------------|"},{"line_number":85,"context_line":"|    VM1      |  -----\u003e    | Router |   --------\u003e    |     VM2     |"},{"line_number":86,"context_line":"|-------------|            |________|                |-------------|"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_6417e653","line":86,"in_reply_to":"9f436f4f_71ca0b1b","updated":"2017-09-21 04:32:32.000000000","message":"Its any router. If its an Openstack router, then it would have ECN enabled , but if its a hardware router, then it would have the ECN modified by the cloud admin/cloud manager.","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe545040db969daae42bf980a12c97b5b6cbdf02","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"a) Router recieves packets from VM1"},{"line_number":91,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":92,"context_line":"Packet Drop profile."},{"line_number":93,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_51cf0729","line":90,"updated":"2017-08-17 19:54:00.000000000","message":"s/recieves/receives","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a051150c9f616b97813ca274c9a0469036f7f786","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"a) Router recieves packets from VM1"},{"line_number":91,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":92,"context_line":"Packet Drop profile."},{"line_number":93,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_2409de30","line":90,"in_reply_to":"9f436f4f_51cf0729","updated":"2017-09-21 04:32:32.000000000","message":"damn :(","commit_id":"c2740d121af61aa20ebf689c806852593a760c93"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"3ebbccdf862160ddb57d23e0846a7f2effe2400f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"a) Router receives packets from VM1"},{"line_number":91,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":92,"context_line":"Packet Drop profile."},{"line_number":93,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"},{"line_number":94,"context_line":"filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_a8d580bb","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":56},"updated":"2017-08-23 14:53:26.000000000","message":"Important question: who defines the limit and parameters, and how can he know the right thresholds?","commit_id":"1f4be1dbb8538f72397c1b1a1ea82ae2291f48c2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a74ce5bde634193245fc3c23784ba737c1baa22b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"a) Router receives packets from VM1"},{"line_number":91,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":92,"context_line":"Packet Drop profile."},{"line_number":93,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"},{"line_number":94,"context_line":"filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_6f9f8903","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":56},"in_reply_to":"7f287b81_a8d580bb","updated":"2017-08-24 08:02:27.000000000","message":"Wont this be done by the network administrator if its a third party driver? \nAnd for OVS/LB, it can be done by Neutron itself, with a configuration parameter in the configuration file?","commit_id":"1f4be1dbb8538f72397c1b1a1ea82ae2291f48c2"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"3ebbccdf862160ddb57d23e0846a7f2effe2400f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"},{"line_number":94,"context_line":"filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"},{"line_number":95,"context_line":"probability to Drop Packet End point, when all packets are ECN tagged."},{"line_number":96,"context_line":"d) When the router experiences congestion, it marks the DiffServ bits in the IP packet with 11 for"},{"line_number":97,"context_line":"Congestion-Experienced ( CE )."},{"line_number":98,"context_line":"e) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1"},{"line_number":99,"context_line":"( ECN Echo flag )."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_08f01467","line":96,"range":{"start_line":96,"start_character":52,"end_line":96,"end_character":69},"updated":"2017-08-23 14:53:26.000000000","message":"the ECN bits","commit_id":"1f4be1dbb8538f72397c1b1a1ea82ae2291f48c2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a74ce5bde634193245fc3c23784ba737c1baa22b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"},{"line_number":94,"context_line":"filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"},{"line_number":95,"context_line":"probability to Drop Packet End point, when all packets are ECN tagged."},{"line_number":96,"context_line":"d) When the router experiences congestion, it marks the DiffServ bits in the IP packet with 11 for"},{"line_number":97,"context_line":"Congestion-Experienced ( CE )."},{"line_number":98,"context_line":"e) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1"},{"line_number":99,"context_line":"( ECN Echo flag )."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_4fa28d4d","line":96,"range":{"start_line":96,"start_character":52,"end_line":96,"end_character":69},"in_reply_to":"7f287b81_08f01467","updated":"2017-08-24 08:02:27.000000000","message":"Done","commit_id":"1f4be1dbb8538f72397c1b1a1ea82ae2291f48c2"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"3ebbccdf862160ddb57d23e0846a7f2effe2400f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"ECN supports the following:"},{"line_number":103,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":104,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":105,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"ECN does not support the following:"},{"line_number":108,"context_line":"- IP packets with MPLS encapsulation"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_e8bca8bc","line":105,"range":{"start_line":105,"start_character":2,"end_line":105,"end_character":75},"updated":"2017-08-23 14:53:26.000000000","message":"ECN also supports marking the outer IP header and copy the mark to the inner header during decapsulation. You can find details in RFC6040: https://tools.ietf.org/html/rfc6040\n\nIt is also implemented in the linux kernel since version 3.7","commit_id":"1f4be1dbb8538f72397c1b1a1ea82ae2291f48c2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a74ce5bde634193245fc3c23784ba737c1baa22b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"ECN supports the following:"},{"line_number":103,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":104,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":105,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"ECN does not support the following:"},{"line_number":108,"context_line":"- IP packets with MPLS encapsulation"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_2f8981c9","line":105,"range":{"start_line":105,"start_character":2,"end_line":105,"end_character":75},"in_reply_to":"7f287b81_e8bca8bc","updated":"2017-08-24 08:02:27.000000000","message":"Done","commit_id":"1f4be1dbb8538f72397c1b1a1ea82ae2291f48c2"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"8f4ce2755006d0d9afe87566b22e340bf3b6125d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"              \u0027allow_put\u0027: True,"},{"line_number":37,"context_line":"              \u0027default\u0027: False,"},{"line_number":38,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":42,"context_line":"    \u0027routers\u0027: {"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f2577a7_c5a7b54f","line":39,"updated":"2017-09-09 02:59:33.000000000","message":"http://logs.openstack.org/62/445762/8/check/gate-neutron-specs-docs-ubuntu-xenial/6d61194/console.html#_2017-09-08_03_44_11_969963","commit_id":"9610a7784ffa92067ef3bc65aedaeb8f02648233"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0738c71ebf17eeca2bf3c7ccadaf4f861707b03d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Explicit Congestion Notification in Neutron"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_132e19a5","line":1,"range":{"start_line":1,"start_character":43,"end_line":1,"end_character":43},"updated":"2017-09-11 04:48:06.000000000","message":"No empty line","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e78700d1a7e78e6f52a6936e063b4a6de2c3247","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Explicit Congestion Notification in Neutron"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f5c4f37_b3fe43ac","line":1,"range":{"start_line":1,"start_character":43,"end_line":1,"end_character":43},"in_reply_to":"5f2577a7_132e19a5","updated":"2017-09-21 05:29:30.000000000","message":"I think its not a big issue","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0738c71ebf17eeca2bf3c7ccadaf4f861707b03d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Explicit Congestion Notification in Neutron"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Problem Description"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_332115b6","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":1},"updated":"2017-09-11 04:48:06.000000000","message":"No \\n","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e78700d1a7e78e6f52a6936e063b4a6de2c3247","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Explicit Congestion Notification in Neutron"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Problem Description"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f5c4f37_932d7f48","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":1},"in_reply_to":"5f2577a7_332115b6","updated":"2017-09-21 05:29:30.000000000","message":"I think its not a big issue","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0738c71ebf17eeca2bf3c7ccadaf4f861707b03d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ECN can be enabled as a separate extension in Neutron, so that it can be plugged in by the user as"},{"line_number":29,"context_line":"per their own convineance. It can be enabled as thus:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"..code-block: Python"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":34,"context_line":"    \u0027networks\u0027: {"},{"line_number":35,"context_line":"        ECN: {\u0027allow_post\u0027: True,"},{"line_number":36,"context_line":"              \u0027allow_put\u0027: True,"},{"line_number":37,"context_line":"              \u0027default\u0027: False,"},{"line_number":38,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":43,"context_line":"    \u0027routers\u0027: {"},{"line_number":44,"context_line":"        ECN: {\u0027allow_post\u0027: True,"},{"line_number":45,"context_line":"              \u0027allow_put\u0027: True,"},{"line_number":46,"context_line":"              \u0027default\u0027: False,"},{"line_number":47,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"a)Sequence of Operations:"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_ae2c7899","line":49,"range":{"start_line":31,"start_character":0,"end_line":49,"end_character":1},"updated":"2017-09-11 04:48:06.000000000","message":".. code-block:: Python\n\n\tEXTENDED_ATTRIBUTES_2_0 \u003d {\n\t\t\u0027networks\u0027: {\n\t\t\tECN: {\u0027allow_post\u0027: True,\n\t\t\t\t  \u0027allow_put\u0027: True,\n\t\t\t\t  \u0027default\u0027: False,\n\t\t\t\t  \u0027is_visible\u0027: True}\n\t\t}\n\t}\n\n\tEXTENDED_ATTRIBUTES_2_0 \u003d {\n\t\t\u0027routers\u0027: {\n\t\t\tECN: {\u0027allow_post\u0027: True,\n\t\t\t\t  \u0027allow_put\u0027: True,\n\t\t\t\t  \u0027default\u0027: False,\n\t\t\t\t  \u0027is_visible\u0027: True}\n\t\t}\n\t}","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e78700d1a7e78e6f52a6936e063b4a6de2c3247","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ECN can be enabled as a separate extension in Neutron, so that it can be plugged in by the user as"},{"line_number":29,"context_line":"per their own convineance. It can be enabled as thus:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"..code-block: Python"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":34,"context_line":"    \u0027networks\u0027: {"},{"line_number":35,"context_line":"        ECN: {\u0027allow_post\u0027: True,"},{"line_number":36,"context_line":"              \u0027allow_put\u0027: True,"},{"line_number":37,"context_line":"              \u0027default\u0027: False,"},{"line_number":38,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":43,"context_line":"    \u0027routers\u0027: {"},{"line_number":44,"context_line":"        ECN: {\u0027allow_post\u0027: True,"},{"line_number":45,"context_line":"              \u0027allow_put\u0027: True,"},{"line_number":46,"context_line":"              \u0027default\u0027: False,"},{"line_number":47,"context_line":"              \u0027is_visible\u0027: True}"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"a)Sequence of Operations:"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f5c4f37_b31763ee","line":49,"range":{"start_line":31,"start_character":0,"end_line":49,"end_character":1},"in_reply_to":"5f2577a7_ae2c7899","updated":"2017-09-21 05:29:30.000000000","message":"Done","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0738c71ebf17eeca2bf3c7ccadaf4f861707b03d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"a)Sequence of Operations:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- Admin Setup:"},{"line_number":54,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but other"},{"line_number":55,"context_line":"third party drivers need to modify the ECN parameter to inform Admin and Openstack if ECN can be"},{"line_number":56,"context_line":"enabled or not."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- ECN enablment:"},{"line_number":59,"context_line":"Tenant/Admin selects a Neutron router on which the ECN is to be enabled"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_8e21bca2","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":15},"updated":"2017-09-11 04:48:06.000000000","message":"- Admin Setup:\n\tAdmin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but other\n\tthird party drivers need to modify the ECN parameter to inform Admin and Openstack if ECN can be\n\tenabled or not.","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e78700d1a7e78e6f52a6936e063b4a6de2c3247","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"a)Sequence of Operations:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- Admin Setup:"},{"line_number":54,"context_line":"Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but other"},{"line_number":55,"context_line":"third party drivers need to modify the ECN parameter to inform Admin and Openstack if ECN can be"},{"line_number":56,"context_line":"enabled or not."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- ECN enablment:"},{"line_number":59,"context_line":"Tenant/Admin selects a Neutron router on which the ECN is to be enabled"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f5c4f37_f3e27b01","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":15},"in_reply_to":"5f2577a7_8e21bca2","updated":"2017-09-21 05:29:30.000000000","message":"Done","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0738c71ebf17eeca2bf3c7ccadaf4f861707b03d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"third party drivers need to modify the ECN parameter to inform Admin and Openstack if ECN can be"},{"line_number":56,"context_line":"enabled or not."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- ECN enablment:"},{"line_number":59,"context_line":"Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":60,"context_line":"If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN extension"},{"line_number":61,"context_line":"ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":62,"context_line":"If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- How It will work:"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_2e3888d1","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":89},"updated":"2017-09-11 04:48:06.000000000","message":"- ECN enablment:\n\tTenant/Admin selects a Neutron router on which the ECN is to be enabled\n\tIf the routers support ECN, then tenant/admin can enable ECN on the router using the ECN extension\n\tECN extension can be Updated to be True/False, using router-create and router-update\n\tIf the third party driver supports ECN, then it will set ECN in the router configuration","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e78700d1a7e78e6f52a6936e063b4a6de2c3247","unresolved":false,"context_lines":[{"line_number":55,"context_line":"third party drivers need to modify the ECN parameter to inform Admin and Openstack if ECN can be"},{"line_number":56,"context_line":"enabled or not."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- ECN enablment:"},{"line_number":59,"context_line":"Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":60,"context_line":"If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN extension"},{"line_number":61,"context_line":"ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":62,"context_line":"If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- How It will work:"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f5c4f37_d3ef77e7","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":89},"in_reply_to":"5f2577a7_2e3888d1","updated":"2017-09-21 05:29:30.000000000","message":"Done","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0738c71ebf17eeca2bf3c7ccadaf4f861707b03d","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"a) Router receives packets from VM1"},{"line_number":73,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":74,"context_line":"Packet Drop profile."},{"line_number":75,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"},{"line_number":76,"context_line":"filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"},{"line_number":77,"context_line":"probability to Drop Packet End point, when all packets are ECN tagged."},{"line_number":78,"context_line":"d) When the router experiences congestion, it marks the ECN bits in the IP packet with 11 for"},{"line_number":79,"context_line":"Congestion-Experienced ( CE )."},{"line_number":80,"context_line":"e) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1"},{"line_number":81,"context_line":"( ECN Echo flag )."},{"line_number":82,"context_line":"f) When VM1 gets this packet, it reduces the speed of the transmission."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"ECN supports the following:"},{"line_number":85,"context_line":"- IPv4 and IPv6 packets based TCP packets."}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_2e3d28bb","line":82,"range":{"start_line":72,"start_character":0,"end_line":82,"end_character":71},"updated":"2017-09-11 04:48:06.000000000","message":"a) Router receives packets from VM1.\nb) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection ) Packet Drop profile.\nc) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on probability to Drop Packet End point, when all packets are ECN tagged.\nd) When the router experiences congestion, it marks the ECN bits in the IP packet with 11 for Congestion-Experienced (CE).\ne) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1 (ECN Echo flag).\nf) When VM1 gets this packet, it reduces the speed of the transmission.","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e78700d1a7e78e6f52a6936e063b4a6de2c3247","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"a) Router receives packets from VM1"},{"line_number":73,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":74,"context_line":"Packet Drop profile."},{"line_number":75,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"},{"line_number":76,"context_line":"filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"},{"line_number":77,"context_line":"probability to Drop Packet End point, when all packets are ECN tagged."},{"line_number":78,"context_line":"d) When the router experiences congestion, it marks the ECN bits in the IP packet with 11 for"},{"line_number":79,"context_line":"Congestion-Experienced ( CE )."},{"line_number":80,"context_line":"e) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1"},{"line_number":81,"context_line":"( ECN Echo flag )."},{"line_number":82,"context_line":"f) When VM1 gets this packet, it reduces the speed of the transmission."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"ECN supports the following:"},{"line_number":85,"context_line":"- IPv4 and IPv6 packets based TCP packets."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f5c4f37_73c0cb51","line":82,"range":{"start_line":72,"start_character":0,"end_line":82,"end_character":71},"in_reply_to":"5f2577a7_2e3d28bb","updated":"2017-09-21 05:29:30.000000000","message":"Full stops wont affect the overall meaning here :)","commit_id":"6583910df312024f7bc90290ee32208f2960888c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Considering that we have 2 machines, a Source and a Destination, then Explicit Congestion"},{"line_number":19,"context_line":"Notification is the process of notifying the Source machine that the network from Source to"},{"line_number":20,"context_line":"Destination is choked up and due to this the packets can be dropped. The notification therefore"},{"line_number":21,"context_line":"allows the Source to \"slow-down\" and reduce the rate of packet transfer to avoid packet drops and"},{"line_number":22,"context_line":"ensure service quality."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_7ba89b1e","line":19,"range":{"start_line":19,"start_character":12,"end_line":19,"end_character":13},"updated":"2018-01-25 16:21:40.000000000","message":"maybe add \"(ECN)\" here, that way it\u0027s obvious when used below, even though it is for most readers","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Considering that we have 2 machines, a Source and a Destination, then Explicit Congestion"},{"line_number":19,"context_line":"Notification is the process of notifying the Source machine that the network from Source to"},{"line_number":20,"context_line":"Destination is choked up and due to this the packets can be dropped. The notification therefore"},{"line_number":21,"context_line":"allows the Source to \"slow-down\" and reduce the rate of packet transfer to avoid packet drops and"},{"line_number":22,"context_line":"ensure service quality."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_c7c74945","line":19,"range":{"start_line":19,"start_character":12,"end_line":19,"end_character":13},"in_reply_to":"5f93b717_7ba89b1e","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Possible API changes"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ECN can be enabled as a separate extension in Neutron, so that it can be plugged in by the user as"},{"line_number":27,"context_line":"per their own convineance. It can be enabled as thus:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. code-block:: Python"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_bb85c3af","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":25},"updated":"2018-01-25 16:21:40.000000000","message":"s/convenience","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Possible API changes"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ECN can be enabled as a separate extension in Neutron, so that it can be plugged in by the user as"},{"line_number":27,"context_line":"per their own convineance. It can be enabled as thus:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. code-block:: Python"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_67c6754b","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":25},"in_reply_to":"5f93b717_bb85c3af","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_9b5fa740","line":47,"range":{"start_line":47,"start_character":75,"end_line":47,"end_character":81},"updated":"2018-01-25 16:21:40.000000000","message":"Maybe spell them out - Open vSwitch and Linuxbridge agents","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_9b76c7d8","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":17},"updated":"2018-01-25 16:21:40.000000000","message":"s/An admin must enable... ?","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_bb7383e7","line":47,"range":{"start_line":47,"start_character":41,"end_line":47,"end_character":50},"updated":"2018-01-25 16:21:40.000000000","message":"s/enablement","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_9b2487c8","line":47,"range":{"start_line":47,"start_character":66,"end_line":47,"end_character":73},"updated":"2018-01-25 16:21:40.000000000","message":"s/router","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_c7cc2963","line":47,"range":{"start_line":47,"start_character":66,"end_line":47,"end_character":73},"in_reply_to":"5f93b717_9b2487c8","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_e7e7e5e3","line":47,"range":{"start_line":47,"start_character":75,"end_line":47,"end_character":81},"in_reply_to":"5f93b717_9b5fa740","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_07ebf1af","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":17},"in_reply_to":"5f93b717_9b76c7d8","updated":"2018-01-29 11:31:50.000000000","message":"I think the current wording is ok","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_47e1f9cf","line":47,"range":{"start_line":47,"start_character":41,"end_line":47,"end_character":50},"in_reply_to":"5f93b717_bb7383e7","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablment:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_1b31570c","line":48,"range":{"start_line":48,"start_character":73,"end_line":48,"end_character":92},"updated":"2018-01-25 16:21:40.000000000","message":"I don\u0027t understand what \"Admin and Openstack\" mean here","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablment depends on the routers. OVS/LB support ECN but"},{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablment:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_0704517a","line":48,"range":{"start_line":48,"start_character":73,"end_line":48,"end_character":92},"in_reply_to":"5f93b717_1b31570c","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_36046a15","line":53,"range":{"start_line":53,"start_character":68,"end_line":53,"end_character":78},"updated":"2018-01-25 16:21:40.000000000","message":"s/it","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_7b2bbb93","line":53,"range":{"start_line":53,"start_character":11,"end_line":53,"end_character":18},"updated":"2018-01-25 16:21:40.000000000","message":"s/router","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_470a598a","line":53,"range":{"start_line":53,"start_character":68,"end_line":53,"end_character":78},"in_reply_to":"5f93b717_36046a15","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_e700456a","line":53,"range":{"start_line":53,"start_character":11,"end_line":53,"end_character":18},"in_reply_to":"5f93b717_7b2bbb93","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_169b6ec9","line":54,"range":{"start_line":54,"start_character":67,"end_line":54,"end_character":98},"updated":"2018-01-25 16:21:40.000000000","message":"router-create and router-update are neutronclient operations, should maybe just say during router creation or updated in this sentence.  Any examples should use the openstack client though.","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_b60f1a2d","line":54,"range":{"start_line":54,"start_character":14,"end_line":54,"end_character":17},"updated":"2018-01-25 16:21:40.000000000","message":"s/The ECN","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_d62186a1","line":54,"range":{"start_line":54,"start_character":35,"end_line":54,"end_character":42},"updated":"2018-01-25 16:21:40.000000000","message":"s/updated","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_472fb9f5","line":54,"range":{"start_line":54,"start_character":67,"end_line":54,"end_character":98},"in_reply_to":"5f93b717_169b6ec9","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_e735a547","line":54,"range":{"start_line":54,"start_character":14,"end_line":54,"end_character":17},"in_reply_to":"5f93b717_b60f1a2d","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_0739b13f","line":54,"range":{"start_line":54,"start_character":35,"end_line":54,"end_character":42},"in_reply_to":"5f93b717_d62186a1","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_b6ab9ad4","line":55,"range":{"start_line":55,"start_character":79,"end_line":55,"end_character":93},"updated":"2018-01-25 16:21:40.000000000","message":"s/configuration.","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_c73ae932","line":55,"range":{"start_line":55,"start_character":79,"end_line":55,"end_character":93},"in_reply_to":"5f93b717_b6ab9ad4","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    |    VM1      |  -----\u003e    | Router |   --------\u003e    |     VM2     |"},{"line_number":62,"context_line":"    |-------------|            |________|                |-------------|"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"a) Router receives packets from VM1"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_56bfb6fa","line":64,"range":{"start_line":64,"start_character":47,"end_line":64,"end_character":55},"updated":"2018-01-25 16:21:40.000000000","message":"Should probably say \"neutron virtual router \"Router\"\" to be clear","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    |    VM1      |  -----\u003e    | Router |   --------\u003e    |     VM2     |"},{"line_number":62,"context_line":"    |-------------|            |________|                |-------------|"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"a) Router receives packets from VM1"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_3689ca74","line":64,"range":{"start_line":64,"start_character":22,"end_line":64,"end_character":28},"updated":"2018-01-25 16:21:40.000000000","message":"s/a packet","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    |    VM1      |  -----\u003e    | Router |   --------\u003e    |     VM2     |"},{"line_number":62,"context_line":"    |-------------|            |________|                |-------------|"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"a) Router receives packets from VM1"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_2715cd9c","line":64,"range":{"start_line":64,"start_character":22,"end_line":64,"end_character":28},"in_reply_to":"5f93b717_3689ca74","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    |    VM1      |  -----\u003e    | Router |   --------\u003e    |     VM2     |"},{"line_number":62,"context_line":"    |-------------|            |________|                |-------------|"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Suppose VM1 sends out packet to VM2 via router \"Router\"."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"a) Router receives packets from VM1"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_8744e1b8","line":64,"range":{"start_line":64,"start_character":47,"end_line":64,"end_character":55},"in_reply_to":"5f93b717_56bfb6fa","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":69,"context_line":"   Packet Drop profile."},{"line_number":70,"context_line":"   "},{"line_number":71,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"},{"line_number":72,"context_line":"   filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"},{"line_number":73,"context_line":"   probability to Drop Packet End point, when all packets are ECN tagged."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_96977e91","line":70,"updated":"2018-01-25 16:21:40.000000000","message":"nit: extra spaces here and L74, L77","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"b) Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":69,"context_line":"   Packet Drop profile."},{"line_number":70,"context_line":"   "},{"line_number":71,"context_line":"c) If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"},{"line_number":72,"context_line":"   filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"},{"line_number":73,"context_line":"   probability to Drop Packet End point, when all packets are ECN tagged."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_e70e058c","line":70,"in_reply_to":"5f93b717_96977e91","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"   filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"},{"line_number":73,"context_line":"   probability to Drop Packet End point, when all packets are ECN tagged."},{"line_number":74,"context_line":"   "},{"line_number":75,"context_line":"d) When the router experiences congestion, it marks the ECN bits in the IP packet with 11 for"},{"line_number":76,"context_line":"   Congestion-Experienced ( CE )."},{"line_number":77,"context_line":"   "},{"line_number":78,"context_line":"e) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_96dc5e75","line":75,"range":{"start_line":75,"start_character":87,"end_line":75,"end_character":89},"updated":"2018-01-25 16:21:40.000000000","message":"I don\u0027t know where \u002711\u0027 comes from, an RFC perhaps?","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":72,"context_line":"   filled up. WRED defines the Drop Packet Start point from which ECN packet tagging starts on"},{"line_number":73,"context_line":"   probability to Drop Packet End point, when all packets are ECN tagged."},{"line_number":74,"context_line":"   "},{"line_number":75,"context_line":"d) When the router experiences congestion, it marks the ECN bits in the IP packet with 11 for"},{"line_number":76,"context_line":"   Congestion-Experienced ( CE )."},{"line_number":77,"context_line":"   "},{"line_number":78,"context_line":"e) VM2 recieves the IP packet with CE bits enabled and sends the TCP ACK with ECE bit to 1"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_071211b2","line":75,"range":{"start_line":75,"start_character":87,"end_line":75,"end_character":89},"in_reply_to":"5f93b717_96dc5e75","updated":"2018-01-29 11:31:50.000000000","message":"Yes, from RFC","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"f) When VM1 gets this packet, it reduces the speed of the transmission."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"ECN supports the following:"},{"line_number":83,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":84,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":85,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_f645a218","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":24},"updated":"2018-01-25 16:21:40.000000000","message":"d/packets here","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":80,"context_line":"f) When VM1 gets this packet, it reduces the speed of the transmission."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"ECN supports the following:"},{"line_number":83,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":84,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":85,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_477d79e5","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":24},"in_reply_to":"5f93b717_f645a218","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"ECN supports the following:"},{"line_number":83,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":84,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":85,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"ECN does not support the following:"},{"line_number":88,"context_line":"- IP packets with MPLS encapsulation"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_96f8dec4","line":85,"range":{"start_line":85,"start_character":46,"end_line":85,"end_character":73},"updated":"2018-01-25 16:21:40.000000000","message":"probably don\u0027t need this since it is below","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":82,"context_line":"ECN supports the following:"},{"line_number":83,"context_line":"- IPv4 and IPv6 packets based TCP packets."},{"line_number":84,"context_line":"- Untagged, single-tagged, and double-tagged packets"},{"line_number":85,"context_line":"- The outer IP header of IP tunneled packets (but not the inner IP header)."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"ECN does not support the following:"},{"line_number":88,"context_line":"- IP packets with MPLS encapsulation"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_e78365cb","line":85,"range":{"start_line":85,"start_character":46,"end_line":85,"end_character":73},"in_reply_to":"5f93b717_96f8dec4","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"ECN does not support the following:"},{"line_number":88,"context_line":"- IP packets with MPLS encapsulation"},{"line_number":89,"context_line":"- The inner IP header of IP tunneled packets (however, ECN works on the outer IP header)"},{"line_number":90,"context_line":"- Multicast, broadcast, and destination lookup fail (DLF) traffic"},{"line_number":91,"context_line":"- Non TCP-IP traffic"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_560256b6","line":89,"range":{"start_line":89,"start_character":46,"end_line":89,"end_character":87},"updated":"2018-01-25 16:21:40.000000000","message":"probably don\u0027t need this since it is above","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"ECN does not support the following:"},{"line_number":88,"context_line":"- IP packets with MPLS encapsulation"},{"line_number":89,"context_line":"- The inner IP header of IP tunneled packets (however, ECN works on the outer IP header)"},{"line_number":90,"context_line":"- Multicast, broadcast, and destination lookup fail (DLF) traffic"},{"line_number":91,"context_line":"- Non TCP-IP traffic"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_078771d9","line":89,"range":{"start_line":89,"start_character":46,"end_line":89,"end_character":87},"in_reply_to":"5f93b717_560256b6","updated":"2018-01-29 11:31:50.000000000","message":"Handled above","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"In case of HA and DVR, ECN would not be impacted. ECN would be enabled on the router namespace"},{"line_number":127,"context_line":"when it is created, so it doesn\u0027t matter if it is created on compute node or network node."},{"line_number":128,"context_line":"For Vendor Specific L3 Routers, it would depend on the vendors to implement ECN specific"},{"line_number":129,"context_line":"functionality."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_b6007a36","line":129,"updated":"2018-01-25 16:21:40.000000000","message":"Can you give more info on what the config would look like for a neutron router?  Is it just setting some sysctl values?","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":126,"context_line":"In case of HA and DVR, ECN would not be impacted. ECN would be enabled on the router namespace"},{"line_number":127,"context_line":"when it is created, so it doesn\u0027t matter if it is created on compute node or network node."},{"line_number":128,"context_line":"For Vendor Specific L3 Routers, it would depend on the vendors to implement ECN specific"},{"line_number":129,"context_line":"functionality."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_a76d5d33","line":129,"in_reply_to":"5f93b717_b6007a36","updated":"2018-01-29 11:31:50.000000000","message":"Yes.\nDo I need to give an example of it?","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, ECN will need to be enabled in the"},{"line_number":135,"context_line":"instances, in the Neutron back end and the Routers connection the instances."},{"line_number":136,"context_line":"This means that when a instance is booted up, if the connection between"},{"line_number":137,"context_line":"instance is to be made ECN enabled, then the ECN profile should be set on the instance to allow"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_b624fa0e","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":12},"updated":"2018-01-25 16:21:40.000000000","message":"s/only work ?","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, ECN will need to be enabled in the"},{"line_number":135,"context_line":"instances, in the Neutron back end and the Routers connection the instances."},{"line_number":136,"context_line":"This means that when a instance is booted up, if the connection between"},{"line_number":137,"context_line":"instance is to be made ECN enabled, then the ECN profile should be set on the instance to allow"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_67775504","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":12},"in_reply_to":"5f93b717_b624fa0e","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, ECN will need to be enabled in the"},{"line_number":135,"context_line":"instances, in the Neutron back end and the Routers connection the instances."},{"line_number":136,"context_line":"This means that when a instance is booted up, if the connection between"},{"line_number":137,"context_line":"instance is to be made ECN enabled, then the ECN profile should be set on the instance to allow"},{"line_number":138,"context_line":"ECN to work."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_367eaae4","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":23},"updated":"2018-01-25 16:21:40.000000000","message":"s/an","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, ECN will need to be enabled in the"},{"line_number":135,"context_line":"instances, in the Neutron back end and the Routers connection the instances."},{"line_number":136,"context_line":"This means that when a instance is booted up, if the connection between"},{"line_number":137,"context_line":"instance is to be made ECN enabled, then the ECN profile should be set on the instance to allow"},{"line_number":138,"context_line":"ECN to work."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_8772a110","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":23},"in_reply_to":"5f93b717_367eaae4","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, ECN will need to be enabled in the"},{"line_number":135,"context_line":"instances, in the Neutron back end and the Routers connection the instances."},{"line_number":136,"context_line":"This means that when a instance is booted up, if the connection between"},{"line_number":137,"context_line":"instance is to be made ECN enabled, then the ECN profile should be set on the instance to allow"},{"line_number":138,"context_line":"ECN to work."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"ECN must be enabled on both sender/receiver and on all of the intermediate devices between the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_36cc6a34","line":137,"range":{"start_line":137,"start_character":45,"end_line":137,"end_character":56},"updated":"2018-01-25 16:21:40.000000000","message":"What is an ECN profile for an instance?","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa590e014e93157b63b27794d69746573b9b6d58","unresolved":false,"context_lines":[{"line_number":134,"context_line":"ECN can work if ECN is enabled from End-to-End. Therefore, ECN will need to be enabled in the"},{"line_number":135,"context_line":"instances, in the Neutron back end and the Routers connection the instances."},{"line_number":136,"context_line":"This means that when a instance is booted up, if the connection between"},{"line_number":137,"context_line":"instance is to be made ECN enabled, then the ECN profile should be set on the instance to allow"},{"line_number":138,"context_line":"ECN to work."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"ECN must be enabled on both sender/receiver and on all of the intermediate devices between the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_27638d44","line":137,"range":{"start_line":137,"start_character":45,"end_line":137,"end_character":56},"in_reply_to":"5f93b717_36cc6a34","updated":"2018-01-29 11:31:50.000000000","message":"Done","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d39405795f31b34367633f3fb0f23e9a06e1018c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"ECN to work."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"ECN must be enabled on both sender/receiver and on all of the intermediate devices between the"},{"line_number":141,"context_line":"endpoints for ECN to work properly. Any device in the transmission path that does not support"},{"line_number":142,"context_line":"ECN breaks the end-to-end coverage. For the feature to work, the instances, the network connecting"},{"line_number":143,"context_line":"those instances and routers connecting those networks must all have the ECN property. Therefore"},{"line_number":144,"context_line":"the ECN property needs to be set up on the network and the router separately. A network can be made"},{"line_number":145,"context_line":"ECN enabled during or after its creation. If a network is made ECN compatible after its creation,"},{"line_number":146,"context_line":"all instances connected to it must be have ECN enabled in the instance\u0027s OS if the admin wishes the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f93b717_d65bc684","line":143,"range":{"start_line":141,"start_character":36,"end_line":143,"end_character":84},"updated":"2018-01-25 16:21:40.000000000","message":"These two sentences seem to duplicate each other","commit_id":"69f602e05023c3ab73ac081b54ee359a8a5b08b8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b91954a9a26d04090c697bed968ba199d52cda9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            ECN: {\u0027allow_post\u0027: True,"},{"line_number":34,"context_line":"                  \u0027allow_put\u0027: True,"},{"line_number":35,"context_line":"                  \u0027default\u0027: False,"},{"line_number":36,"context_line":"                  \u0027is_visible\u0027: True}}}"},{"line_number":37,"context_line":"    EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":38,"context_line":"        \u0027routers\u0027: {"},{"line_number":39,"context_line":"            ECN: {\u0027allow_post\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_623c75bf","line":36,"updated":"2018-01-20 11:44:49.000000000","message":"sorry for maybe silly question but I don\u0027t know one thing.\nFor routers it\u0027s clear for me: when this new value will be set to True then feature will be enabled in router\u0027s namespace - fine.\nBut what about networks. What and where exactly will be changed/switched to make this feature enabled/disabled? Will it be done by L2 agent on port directly?","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0e6a2446829269d24d23a7ad1022d2f00819783e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            ECN: {\u0027allow_post\u0027: True,"},{"line_number":34,"context_line":"                  \u0027allow_put\u0027: True,"},{"line_number":35,"context_line":"                  \u0027default\u0027: False,"},{"line_number":36,"context_line":"                  \u0027is_visible\u0027: True}}}"},{"line_number":37,"context_line":"    EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":38,"context_line":"        \u0027routers\u0027: {"},{"line_number":39,"context_line":"            ECN: {\u0027allow_post\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_ea490932","line":36,"in_reply_to":"7f96bb07_623c75bf","updated":"2018-01-23 05:55:42.000000000","message":"If the network is made ECN Enabled, then the network namespace would have the ECN flag set.\nIf the packet is going from an ECN enabled network to an ECN enabled network, then routers would implement the Congestion Notification. If the Packet is going from an ECN enabled to a NON-ECN enabled ( or vice versa ) , the routers wont modify the IP header for Congestion","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b91954a9a26d04090c697bed968ba199d52cda9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_c24b095d","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":15},"updated":"2018-01-20 11:44:49.000000000","message":"enablement","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0e6a2446829269d24d23a7ad1022d2f00819783e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    other third party drivers need to modify the ECN parameter to inform Admin and Openstack if"},{"line_number":49,"context_line":"    ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_ca676db7","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":15},"in_reply_to":"7f96bb07_c24b095d","updated":"2018-01-23 05:55:42.000000000","message":"Done","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b91954a9a26d04090c697bed968ba199d52cda9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_e250850d","line":54,"range":{"start_line":54,"start_character":35,"end_line":54,"end_character":36},"updated":"2018-01-20 11:44:49.000000000","message":"lowercase","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0e6a2446829269d24d23a7ad1022d2f00819783e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- ECN enablment:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"},{"line_number":53,"context_line":"    If the routers support ECN, then tenant/admin can enable ECN on the router using the ECN"},{"line_number":54,"context_line":"    extension ECN extension can be Updated to be True/False, using router-create and router-update"},{"line_number":55,"context_line":"    If the third party driver supports ECN, then it will set ECN in the router configurations"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- How It will work:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_6a0419c7","line":54,"range":{"start_line":54,"start_character":35,"end_line":54,"end_character":36},"in_reply_to":"7f96bb07_e250850d","updated":"2018-01-23 05:55:42.000000000","message":"Done","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b91954a9a26d04090c697bed968ba199d52cda9","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"c) Future Scope of Action:"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"- Allow VMs and networks to be ECN enabled after they have been created."},{"line_number":118,"context_line":"- Allow Users to disable ECN profile on a VM."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"d) Low level implementation details in l3 routers:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_825501fd","line":117,"range":{"start_line":117,"start_character":16,"end_line":117,"end_character":71},"updated":"2018-01-20 11:44:49.000000000","message":"but in L34 there is \"allow_put: True\" for networks so will be update of this feature allowed or not for now?","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0e6a2446829269d24d23a7ad1022d2f00819783e","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"c) Future Scope of Action:"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"- Allow VMs and networks to be ECN enabled after they have been created."},{"line_number":118,"context_line":"- Allow Users to disable ECN profile on a VM."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"d) Low level implementation details in l3 routers:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_8a0725ca","line":117,"range":{"start_line":117,"start_character":16,"end_line":117,"end_character":71},"in_reply_to":"7f96bb07_825501fd","updated":"2018-01-23 05:55:42.000000000","message":"I think the Update should be dealt in the next version, so I will change L34 to False","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b91954a9a26d04090c697bed968ba199d52cda9","unresolved":false,"context_lines":[{"line_number":144,"context_line":"those instances and routers connecting those networks must all have the ECN property. Therefore"},{"line_number":145,"context_line":"the ECN property needs to be set up on the network and the router separately. A network can be made"},{"line_number":146,"context_line":"ECN enabled during or after its creation. If a network is made ECN compatible after its creation,"},{"line_number":147,"context_line":"all instances connected to it must be have ECN enabled in the instance\u0027s OS if the admin wishes the"},{"line_number":148,"context_line":"instances to benefit from it."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f96bb07_423ff9b4","line":147,"range":{"start_line":147,"start_character":38,"end_line":147,"end_character":42},"updated":"2018-01-20 11:44:49.000000000","message":"is it necessary?","commit_id":"a453adfba1b561cf9a2f7ed517ac36f963c306d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"13b6ad4c3e9842de84e05525c2218b387d730065","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":32,"context_line":"        \u0027networks\u0027: {"},{"line_number":33,"context_line":"            ECN: {\u0027allow_post\u0027: True,"},{"line_number":34,"context_line":"                  \u0027allow_put\u0027: False,"},{"line_number":35,"context_line":"                  \u0027default\u0027: False,"},{"line_number":36,"context_line":"                  \u0027is_visible\u0027: True}}}"},{"line_number":37,"context_line":"    EXTENDED_ATTRIBUTES_2_0 \u003d {"}],"source_content_type":"text/x-rst","patch_set":20,"id":"df7087c5_51e9b817","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":36},"updated":"2018-03-21 15:03:29.000000000","message":"Can\u0027t it be updated for already created network?","commit_id":"caa706560e5381209ab9481199893a8a4b0e0fd9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"88ce0a5835719f72fe4abb19eb22075b091bd85c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":32,"context_line":"        \u0027networks\u0027: {"},{"line_number":33,"context_line":"            ECN: {\u0027allow_post\u0027: True,"},{"line_number":34,"context_line":"                  \u0027allow_put\u0027: False,"},{"line_number":35,"context_line":"                  \u0027default\u0027: False,"},{"line_number":36,"context_line":"                  \u0027is_visible\u0027: True}}}"},{"line_number":37,"context_line":"    EXTENDED_ATTRIBUTES_2_0 \u003d {"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bf659307_ac9b3064","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":36},"in_reply_to":"df7087c5_51e9b817","updated":"2018-04-09 10:47:37.000000000","message":"I was considering of not doing it in the current release","commit_id":"caa706560e5381209ab9481199893a8a4b0e0fd9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"13b6ad4c3e9842de84e05525c2218b387d730065","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. OpenVSwtich and Linux"},{"line_number":48,"context_line":"    Bridge support ECN but other third party drivers need to modify the ECN parameter to "},{"line_number":49,"context_line":"    inform Openstack if ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"df7087c5_b1e1342d","line":47,"range":{"start_line":47,"start_character":75,"end_line":47,"end_character":86},"updated":"2018-03-21 15:03:29.000000000","message":"Open vSwitch","commit_id":"caa706560e5381209ab9481199893a8a4b0e0fd9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"13b6ad4c3e9842de84e05525c2218b387d730065","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. OpenVSwtich and Linux"},{"line_number":48,"context_line":"    Bridge support ECN but other third party drivers need to modify the ECN parameter to "},{"line_number":49,"context_line":"    inform Openstack if ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablement:"}],"source_content_type":"text/x-rst","patch_set":20,"id":"df7087c5_11f3400c","line":48,"range":{"start_line":48,"start_character":88,"end_line":48,"end_character":89},"updated":"2018-03-21 15:03:29.000000000","message":"trailing space","commit_id":"caa706560e5381209ab9481199893a8a4b0e0fd9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"13b6ad4c3e9842de84e05525c2218b387d730065","unresolved":false,"context_lines":[{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. OpenVSwtich and Linux"},{"line_number":48,"context_line":"    Bridge support ECN but other third party drivers need to modify the ECN parameter to "},{"line_number":49,"context_line":"    inform Openstack if ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablement:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"}],"source_content_type":"text/x-rst","patch_set":20,"id":"df7087c5_f1456c16","line":49,"updated":"2018-03-21 15:03:29.000000000","message":"so You want to introduce some validation mechanism which will not allow to enable it if backend don\u0027t support it?","commit_id":"caa706560e5381209ab9481199893a8a4b0e0fd9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"88ce0a5835719f72fe4abb19eb22075b091bd85c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. OpenVSwtich and Linux"},{"line_number":48,"context_line":"    Bridge support ECN but other third party drivers need to modify the ECN parameter to "},{"line_number":49,"context_line":"    inform Openstack if ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablement:"},{"line_number":52,"context_line":"    Tenant/Admin selects a Neutron router on which the ECN is to be enabled"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bf659307_ccb784d8","line":49,"in_reply_to":"df7087c5_f1456c16","updated":"2018-04-09 10:47:37.000000000","message":"Yep","commit_id":"caa706560e5381209ab9481199893a8a4b0e0fd9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"13b6ad4c3e9842de84e05525c2218b387d730065","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"ECN does not support the following:"},{"line_number":85,"context_line":"- IP packets with MPLS encapsulation"},{"line_number":86,"context_line":"- The inner IP header of IP tunneled packets (however, ECN works on the outer IP header)"},{"line_number":87,"context_line":"- Multicast, broadcast, and destination lookup fail (DLF) traffic"},{"line_number":88,"context_line":"- Non TCP-IP traffic"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"df7087c5_f1ca4c6c","line":86,"updated":"2018-03-21 15:03:29.000000000","message":"so how it will work e.g. in vxlan networks?","commit_id":"caa706560e5381209ab9481199893a8a4b0e0fd9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"88ce0a5835719f72fe4abb19eb22075b091bd85c","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"ECN does not support the following:"},{"line_number":85,"context_line":"- IP packets with MPLS encapsulation"},{"line_number":86,"context_line":"- The inner IP header of IP tunneled packets (however, ECN works on the outer IP header)"},{"line_number":87,"context_line":"- Multicast, broadcast, and destination lookup fail (DLF) traffic"},{"line_number":88,"context_line":"- Non TCP-IP traffic"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"bf659307_ec084892","line":86,"in_reply_to":"df7087c5_f1ca4c6c","updated":"2018-04-09 10:47:37.000000000","message":"In case of VxLAN, if the outer header has the ECN packet enabled, then the outer packet\u0027s transmission speed would be controlled.\nIt should iterate back to the VMs who are producing the VxLAN packets to throttle thier own packet producing speed","commit_id":"caa706560e5381209ab9481199893a8a4b0e0fd9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a388156ca96ee7a627f73367bf56a8e95f521db8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. OpenvSwtich and Linux"},{"line_number":48,"context_line":"    Bridge support ECN but other third party drivers need to modify the ECN parameter to"},{"line_number":49,"context_line":"    inform Openstack if ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"9f6a8fd7_f9204a4c","line":47,"range":{"start_line":47,"start_character":75,"end_line":47,"end_character":86},"updated":"2018-04-16 08:05:35.000000000","message":"Open vSwitch according to http://www.openvswitch.org :) You have now without space between \"Open\" and \"vSwitch\" and also You have \"Swtich\" :)","commit_id":"0978808db142030a114d62f65e516b12adad0e2a"}],"specs/rocky/ecn.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d9fe0e8ee66219e9d5652f8ecc278599551882c0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. Open vSwtich and Linux"},{"line_number":48,"context_line":"    Bridge support ECN but other third party drivers need to modify the ECN parameter to"},{"line_number":49,"context_line":"    inform Openstack if ECN can be enabled or not."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"9f6a8fd7_1c07101f","line":47,"range":{"start_line":47,"start_character":80,"end_line":47,"end_character":87},"updated":"2018-04-17 07:27:41.000000000","message":"nitty nit: still You have vSwtich instead of vSwitch (\"i\" and \"t\" are changed) :)","commit_id":"3dbe812846830fc2e88b7ed3b60a95c1db37ff69"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"d4e6a35284535a4fc687b3eca4e58dae9d2843db","unresolved":false,"context_lines":[{"line_number":85,"context_line":"- IP packets with MPLS encapsulation"},{"line_number":86,"context_line":"- The inner IP header of IP tunneled packets (however, ECN works on the outer IP header)"},{"line_number":87,"context_line":"- Multicast, broadcast, and destination lookup fail (DLF) traffic"},{"line_number":88,"context_line":"- Non TCP-IP traffic"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"In case of DVR, the OVS/Neutron Backend agent running on the Compute node can be notified"},{"line_number":91,"context_line":"from the neutron-server running on the controller node to set up the ECN bit."}],"source_content_type":"text/x-rst","patch_set":25,"id":"5f7c97a3_a3600ba6","line":88,"updated":"2018-06-19 15:53:59.000000000","message":"Since ECN is in the IP packet header, I think it will support non-TCP types of IP traffic, such as UDP.","commit_id":"87415331cb40e7292c27d198e292ba2c7a7f6bba"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2280d6607a420f9b83dc6c65f229e7cabb94395a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"- IP packets with MPLS encapsulation"},{"line_number":86,"context_line":"- The inner IP header of IP tunneled packets (however, ECN works on the outer IP header)"},{"line_number":87,"context_line":"- Multicast, broadcast, and destination lookup fail (DLF) traffic"},{"line_number":88,"context_line":"- UDP traffic"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"In case of DVR, the OVS/Neutron Backend agent running on the Compute node can be notified"},{"line_number":91,"context_line":"from the neutron-server running on the controller node to set up the ECN bit."}],"source_content_type":"text/x-rst","patch_set":26,"id":"3f79a3b5_e64e60c0","line":88,"updated":"2018-08-05 19:40:04.000000000","message":"I\u0027m not sure but IMHO previous version was better. As is written in RFC: https://tools.ietf.org/html/rfc3168 ECN requires support from transport layer protocol and there is only TCP protocol mentioned there. So IMO it\u0027s not supported for all other protocols, right?","commit_id":"b56a0c56ad757a376ae19a1229d9a701d1666fb8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6d0340e6ae385b9f1c315ec7ec06fe7674a870a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"- IP packets with MPLS encapsulation"},{"line_number":86,"context_line":"- The inner IP header of IP tunneled packets (however, ECN works on the outer IP header)"},{"line_number":87,"context_line":"- Multicast, broadcast, and destination lookup fail (DLF) traffic"},{"line_number":88,"context_line":"- UDP traffic"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"In case of DVR, the OVS/Neutron Backend agent running on the Compute node can be notified"},{"line_number":91,"context_line":"from the neutron-server running on the controller node to set up the ECN bit."}],"source_content_type":"text/x-rst","patch_set":26,"id":"3f79a3b5_da90d398","line":88,"in_reply_to":"3f79a3b5_e64e60c0","updated":"2018-08-06 07:01:10.000000000","message":"Ok, as Reedip told me on IRC it works also for other protocols, like DCTCP and SCTP. Details on https://en.wikipedia.org/wiki/Explicit_Congestion_Notification\nSo it\u0027s fine like that for me","commit_id":"b56a0c56ad757a376ae19a1229d9a701d1666fb8"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f959ed3ecbec1c5d822c1bb590162adba9a64a56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"3f79a3b5_e5afb279","updated":"2018-10-11 16:07:29.000000000","message":"should go to stein now ?","commit_id":"ee05d7b96fd3ab105bbfefb3f7b9bb9dc67f530f"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"5b4bc87bbc2548d335b98ffe3ad621e6b1b50c42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"3f79a3b5_b30912dc","in_reply_to":"3f79a3b5_e5afb279","updated":"2018-11-21 13:54:43.000000000","message":"Done","commit_id":"ee05d7b96fd3ab105bbfefb3f7b9bb9dc67f530f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1f7c481d35eeb8cf333dcffcda1defa41649c7f5","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":32,"context_line":"        \u0027networks\u0027: {"},{"line_number":33,"context_line":"            ECN: {\u0027allow_post\u0027: True,"},{"line_number":34,"context_line":"                  \u0027allow_put\u0027: False,"},{"line_number":35,"context_line":"                  \u0027default\u0027: False,"},{"line_number":36,"context_line":"                  \u0027is_visible\u0027: True}}}"}],"source_content_type":"text/x-rst","patch_set":27,"id":"3f79a3b5_3211595d","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":15},"updated":"2018-10-12 11:41:01.000000000","message":"can you add an explanation how ecn field in networks works?\n\nin this spec i could only find explanation about routers.","commit_id":"ee05d7b96fd3ab105bbfefb3f7b9bb9dc67f530f"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"5b4bc87bbc2548d335b98ffe3ad621e6b1b50c42","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":32,"context_line":"        \u0027networks\u0027: {"},{"line_number":33,"context_line":"            ECN: {\u0027allow_post\u0027: True,"},{"line_number":34,"context_line":"                  \u0027allow_put\u0027: False,"},{"line_number":35,"context_line":"                  \u0027default\u0027: False,"},{"line_number":36,"context_line":"                  \u0027is_visible\u0027: True}}}"}],"source_content_type":"text/x-rst","patch_set":27,"id":"3f79a3b5_930416c6","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":15},"in_reply_to":"3f79a3b5_3211595d","updated":"2018-11-21 13:54:43.000000000","message":"Done","commit_id":"ee05d7b96fd3ab105bbfefb3f7b9bb9dc67f530f"}],"specs/train/ecn.rst":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a6d5edd485f06a9db5fe9886f0367479e97f1f21","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                  \u0027default\u0027: False,"},{"line_number":42,"context_line":"                  \u0027is_visible\u0027: True}}}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. Open vSwitch and Linux"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_f9776b06","line":44,"updated":"2018-11-21 15:45:15.000000000","message":"Should this be a subheading?","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"6f7fc9bab551250ebff0692212d10a7ce33e54a5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                  \u0027default\u0027: False,"},{"line_number":42,"context_line":"                  \u0027is_visible\u0027: True}}}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. Open vSwitch and Linux"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_7bbb13dd","line":44,"in_reply_to":"3f79a3b5_5c87635d","updated":"2018-11-26 17:52:56.000000000","message":"I think it would make sense to use the features of RST, yes.","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"013fb36f96768a6bc042001d9170b9913c88dc9c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                  \u0027default\u0027: False,"},{"line_number":42,"context_line":"                  \u0027is_visible\u0027: True}}}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. Open vSwitch and Linux"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_e81ae667","line":44,"in_reply_to":"3f79a3b5_7bbb13dd","updated":"2018-12-10 10:58:56.000000000","message":"Ok, will do so","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                  \u0027default\u0027: False,"},{"line_number":42,"context_line":"                  \u0027is_visible\u0027: True}}}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"a)Sequence of Operations:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Admin Setup:"},{"line_number":47,"context_line":"    Admin enables the ECN extension. ECN enablement depends on the router. Open vSwitch and Linux"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_5c87635d","line":44,"in_reply_to":"3f79a3b5_f9776b06","updated":"2018-11-22 05:42:19.000000000","message":"I was OK with this, but if you feel this can be a sub-heading, let me know","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6d372d87799c7f29ef689b70808da5ff4fa7101","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    inform Openstack if ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablement:"},{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_33b8a2bf","line":52,"range":{"start_line":52,"start_character":53,"end_line":52,"end_character":55},"updated":"2018-11-21 14:05:05.000000000","message":"nitty nit: 2 spaces","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    inform Openstack if ECN can be enabled or not."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- ECN enablement:"},{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_fc6aefb1","line":52,"range":{"start_line":52,"start_character":53,"end_line":52,"end_character":55},"in_reply_to":"3f79a3b5_33b8a2bf","updated":"2018-11-22 05:42:19.000000000","message":"Done","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6d372d87799c7f29ef689b70808da5ff4fa7101","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_53f3dea0","line":55,"range":{"start_line":55,"start_character":69,"end_line":55,"end_character":76},"updated":"2018-11-21 14:05:05.000000000","message":"IMO should be \"driver\"","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6d372d87799c7f29ef689b70808da5ff4fa7101","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_93f5f688","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":32},"updated":"2018-11-21 14:05:05.000000000","message":"nitty nit: 2 spaces","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6d372d87799c7f29ef689b70808da5ff4fa7101","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_73f05a93","line":55,"range":{"start_line":55,"start_character":77,"end_line":55,"end_character":84},"updated":"2018-11-21 14:05:05.000000000","message":"supports","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_5c59a327","line":55,"range":{"start_line":55,"start_character":69,"end_line":55,"end_character":76},"in_reply_to":"3f79a3b5_53f3dea0","updated":"2018-11-22 05:42:19.000000000","message":"I intended it to be Plural ( multiple drivers can support ECN )","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"6f7fc9bab551250ebff0692212d10a7ce33e54a5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_9b786f2c","line":55,"range":{"start_line":55,"start_character":69,"end_line":55,"end_character":76},"in_reply_to":"3f79a3b5_5c59a327","updated":"2018-11-26 17:52:56.000000000","message":"The problem is the word \"the\" which indicates a singular entity.  You could do \"If the third party driver in use supports ECN...\" or you could say \"If third party drivers support ECN...\"","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_1c956b94","line":55,"range":{"start_line":55,"start_character":77,"end_line":55,"end_character":84},"in_reply_to":"3f79a3b5_73f05a93","updated":"2018-11-22 05:42:19.000000000","message":"Multiple Drivers can support ECN :)","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_3c9aa7c3","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":32},"in_reply_to":"3f79a3b5_93f5f688","updated":"2018-11-22 05:42:19.000000000","message":"Done","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"013fb36f96768a6bc042001d9170b9913c88dc9c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Tenant/Admin selects the Neutron networks and the  intermediate router(s) on which the ECN"},{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_a8306eeb","line":55,"range":{"start_line":55,"start_character":69,"end_line":55,"end_character":76},"in_reply_to":"3f79a3b5_9b786f2c","updated":"2018-12-10 10:58:56.000000000","message":"Okay, will do so","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6d372d87799c7f29ef689b70808da5ff4fa7101","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_f329caf0","line":56,"range":{"start_line":56,"start_character":97,"end_line":56,"end_character":98},"updated":"2018-11-21 14:05:05.000000000","message":"nit: trailing space","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    is to be enabled. If the network/router supports ECN, then tenant/admin can enable ECN on it"},{"line_number":54,"context_line":"    using the ECN extension. The ECN extension can be updated to be True/False, using network\u0027s and"},{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_fc9f4faf","line":56,"range":{"start_line":56,"start_character":97,"end_line":56,"end_character":98},"in_reply_to":"3f79a3b5_f329caf0","updated":"2018-11-22 05:42:19.000000000","message":"Done","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a6d5edd485f06a9db5fe9886f0367479e97f1f21","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_9978b7f6","line":58,"updated":"2018-11-21 15:45:15.000000000","message":"I agree with @Slawek, I think the reference to networks here is confusing.  The only place where changing the setting makes a difference is in the router.  This is demonstrated in your \"How it will work\" section below, where the network is never mentioned, only the router.","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6d372d87799c7f29ef689b70808da5ff4fa7101","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_133ec626","line":58,"updated":"2018-11-21 14:05:05.000000000","message":"TBH I still don\u0027t understand what impact on backend can/will have set \"ecn_enabled\u003dTrue\" for network.\nI understand it for router but not for network :/","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_fc78af7d","line":58,"in_reply_to":"3f79a3b5_9978b7f6","updated":"2018-11-22 05:42:19.000000000","message":"What I was thinking was that if 2 networks are connected with a router and one of the networks does not support ECN, then ECN should not be enabled for the whole path.\n\nLike, say we have 3 networks, Network 1, Network 2 and Network 3.\nNetwork 1 --\u003e Router 1 --\u003e Network 2\nNetwork 1 --\u003e Router 1 --\u003e Network 3\n\nAssume ECN is enabled in Network 1, Network 3 and Router 1.All connections from Network 1 to Network 3 can have ECN support. Network 2 does not support ECN, then there is no need to throttle the throughput from network 1 to network 2.\n\nSo , even if we have ECN enabled on Router, it is possible that certain network paths do not require ECN for a particular reason ( say its already throttled/controlled and there is no need for ECN there, or the connection is such that loss of packets is OK ), but other network paths do require ECN.","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"013fb36f96768a6bc042001d9170b9913c88dc9c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_c865aae5","line":58,"in_reply_to":"3f79a3b5_fbe3a39d","updated":"2018-12-10 10:58:56.000000000","message":"ECN can be based on the network interfaces, but IIUC, a router also has to support ECN. If the router doesnt have an ECN support, then there is no point of including it. \nI can remove the ECN configuration from routers, but I believe that it would give the users the flexibility to configure it directly.","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"6f7fc9bab551250ebff0692212d10a7ce33e54a5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    router\u0027s create and update  operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN "},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_fbe3a39d","line":58,"in_reply_to":"3f79a3b5_fc78af7d","updated":"2018-11-26 17:52:56.000000000","message":"ECN in OpenStack should work the same way it does in a traditional, non-virtualized environment.  Looking at the Cisco [1] and Juniper [2] configuration reference material for examples, ECN is configured in a policy that can be applied on a per-interface basis.  It is not a global setting in the router.  Given this, I think it actually makes sense for ECN to be an attribute of the network and not the router.  The router would then enable ECN on a per-interface basis based on the attribute of the associated network.\n\n[1] https://www.cisco.com/c/en/us/td/docs/ios-xml/ios/qos_conavd/configuration/xe-3s/qos-conavd-xe-3s-book/qos-conavd-wred-ecn.html#GUID-B28648F0-E9F8-4060-904E-959B4F2BA362\n[2] https://www.juniper.net/documentation/en_US/junos/topics/example/cos-schedulers-explicit-congestion-notification-configuring.html","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a6d5edd485f06a9db5fe9886f0367479e97f1f21","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Suppose VM1 sends out a packet to VM2 via neutron virtual router \"Router\"."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_b97d73e6","line":60,"updated":"2018-11-21 15:45:15.000000000","message":"Should this be a subheading?","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"6f7fc9bab551250ebff0692212d10a7ce33e54a5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Suppose VM1 sends out a packet to VM2 via neutron virtual router \"Router\"."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_db8fc71e","line":60,"in_reply_to":"3f79a3b5_7c849f57","updated":"2018-11-26 17:52:56.000000000","message":"see above","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Suppose VM1 sends out a packet to VM2 via neutron virtual router \"Router\"."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_7c849f57","line":60,"in_reply_to":"3f79a3b5_b97d73e6","updated":"2018-11-22 05:42:19.000000000","message":"same, I think its ok","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"013fb36f96768a6bc042001d9170b9913c88dc9c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Suppose VM1 sends out a packet to VM2 via neutron virtual router \"Router\"."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_e868a6bb","line":60,"in_reply_to":"3f79a3b5_db8fc71e","updated":"2018-12-10 10:58:56.000000000","message":"Yep, will do so","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a6d5edd485f06a9db5fe9886f0367479e97f1f21","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Router receives packets from VM1"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":67,"context_line":"   Packet Drop profile."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_59669f58","line":66,"updated":"2018-11-21 15:45:15.000000000","message":"Is WRED the only kind of AQM that is realistically going to be selected, or is it possible for other RED variants (ARED, RRED) or other AQM styles (PID) to be selected?  I\u0027m not sure about what OVS supports but I can imagine the question being asked.  You could just add a pointer to docs about what AQM OVS uses.","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":23858,"name":"reedip","username":"reedip","inactive":true},"change_message_id":"c5f262f69fd82fbb5f37f29c3375695c771a0e95","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Router receives packets from VM1"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":67,"context_line":"   Packet Drop profile."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"}],"source_content_type":"text/x-rst","patch_set":28,"id":"3f79a3b5_3ce86713","line":66,"in_reply_to":"3f79a3b5_59669f58","updated":"2018-11-22 05:42:19.000000000","message":"I need to read more on this....","commit_id":"7d926f4e3093b1174684c158163da8f07720bd32"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"fc28b0dbb70baaeabd49a059fbda665415bfe1bb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    router\u0027s create and update operation. If the third party router drivers support ECN, then it will"},{"line_number":56,"context_line":"    set ECN in the router configuration. Individual Networks can be made ECN enabled but true ECN"},{"line_number":57,"context_line":"    behavior can only be observed if the networks between source and destination and all routers"},{"line_number":58,"context_line":"    connecting them have ECN enabled."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- How It will work:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f79a3b5_3b611b11","line":58,"updated":"2018-11-26 17:54:23.000000000","message":"See comment in PS28 on ECN as an attribute of the network but not of the router.  \n\nOne way or the other, I think there should be only one object that has an ECN-enablement switch.  Having two sows confusion and is not needed.","commit_id":"77d19f77b791ecbab772cdd259c56d1ad516939d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"6f7fc9bab551250ebff0692212d10a7ce33e54a5","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Router receives packets from VM1"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Router has a defined queue limit with a specific WRED ( Weighted Random Early Detection )"},{"line_number":67,"context_line":"   Packet Drop profile."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# If VM1 transfer rate \u003e processing rate of router, the router input queue starts getting"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f79a3b5_3bb6fbdc","line":66,"updated":"2018-11-26 17:52:56.000000000","message":"See comment on AQM is PS28.  Both Cisco and Juniper seem to like WRED, but I think the dispositive factor is what the reference implementation (OVS) has available.","commit_id":"77d19f77b791ecbab772cdd259c56d1ad516939d"}]}