)]}'
{"images/routed-networks-with-floating-ips.png":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8314d912ae8a1758b0d6ad8dbf553895f4289dca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"PNG\r"},{"line_number":2,"context_line":"\u001a"},{"line_number":3,"context_line":"\u0000\u0000\u0000\rIHDR\u0000\u0000\u0003À\u0000\u0000\u0002\u001c\b\u0002\u0000\u0000\u0000¶?P,\u0000\u0000\u0000IDATxÚì½yt\u0015×ïë?üV»×r¿çµ.};ÝM^Ü·ÉmÞ\ré$8Æ6±±\u0013ìà\u0018c°11¶Ìdp\u0018dÀX \u0018@H\b!4f4\"4#ÐÐÐ\u0004\b!!!\u0004\bÄ$f\rÀyß£\u001dïlêS:à\b¾u\u0016\u001cÕ©Úµk×°?µëW{?c \u0010B\b!XÍ3,\u0002B\b!\u0010B(Ð\u0010B\b!P \t!\u0010B\b¡@\u0013B\b!\u0010B\u0026\u0010B\b!\u0002M\b!\u0010B\b\u0005E@\b!\u0010B\b\u0005\u0010B\b!\u0010"},{"line_number":4,"context_line":"4!\u0010B\b!\u0014hB\b!\u0010B(Ð\u0010B\b!P \t!\u0010B\b¡@³\b\b!\u0010B\b¡@\u0013B\b!\u0010B\u0026\u0010B\b!\u0002M\b!\u0010B\b\u0005\u0010B\b!\u0010"}],"source_content_type":"image/png","patch_set":14,"id":"bfb3d3c7_8cf7b58b","line":1,"updated":"2019-05-30 08:06:22.000000000","message":"I was looking at rendered version of this spec: http://logs.openstack.org/50/486450/14/check/openstack-tox-docs/c4cd219/html/specs/train/routed-networks-floating-ips.html and I can\u0027t see this image anywhere. Where it should be placed exactly?","commit_id":"1308854f05332166f3a2e48f948c502401edd324"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7cb4d2992fcb2e6088e398d0efa474766ff6b09c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"PNG\r"},{"line_number":2,"context_line":"\u001a"},{"line_number":3,"context_line":"\u0000\u0000\u0000\rIHDR\u0000\u0000\u0003À\u0000\u0000\u0002\u001c\b\u0002\u0000\u0000\u0000¶?P,\u0000\u0000\u0000IDATxÚì½yt\u0015×ïë?üV»×r¿çµ.};ÝM^Ü·ÉmÞ\ré$8Æ6±±\u0013ìà\u0018c°11¶Ìdp\u0018dÀX \u0018@H\b!4f4\"4#ÐÐÐ\u0004\b!!!\u0004\bÄ$f\rÀyß£\u001dïlêS:à\b¾u\u0016\u001cÕ©Úµk×°?µëW{?c \u0010B\b!XÍ3,\u0002B\b!\u0010B(Ð\u0010B\b!P \t!\u0010B\b¡@\u0013B\b!\u0010B\u0026\u0010B\b!\u0002M\b!\u0010B\b\u0005E@\b!\u0010B\b\u0005\u0010B\b!\u0010"},{"line_number":4,"context_line":"4!\u0010B\b!\u0014hB\b!\u0010B(Ð\u0010B\b!P \t!\u0010B\b¡@³\b\b!\u0010B\b¡@\u0013B\b!\u0010B\u0026\u0010B\b!\u0002M\b!\u0010B\b\u0005\u0010B\b!\u0010"}],"source_content_type":"image/png","patch_set":14,"id":"bfb3d3c7_529dcf63","line":1,"in_reply_to":"bfb3d3c7_8cf7b58b","updated":"2019-05-30 13:24:33.000000000","message":"I\u0027m going to start over with new graphics that help illustrate the points in the spec more clearly.","commit_id":"1308854f05332166f3a2e48f948c502401edd324"}],"specs/pike/routed-networks-floating-ips.rst":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"deebbf251b3e2b745cb9c5e4bd5d80b4a048f508","unresolved":false,"context_lines":[{"line_number":122,"context_line":"IP of the associated port."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"For the case where address translation is enabled, we will extend `DVR`__ with"},{"line_number":125,"context_line":"a new class of router named ``DvrRoutedNetworkLocalRouter``, that will only"},{"line_number":126,"context_line":"handle North / South routing and carry out the required address translations."},{"line_number":127,"context_line":"The BGP speaker will advertise the floating IP agent gateway on the"},{"line_number":128,"context_line":"corresponding compute node as the next-hop for a floating IP associated to a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df3967d1_6bc4b4f5","line":125,"range":{"start_line":125,"start_character":30,"end_line":125,"end_character":57},"updated":"2017-08-03 22:06:43.000000000","message":"Do we need a separate Class for this? Right now the DVRLocalRouter can handle this.","commit_id":"e2eaf83de07b84cd600b77c1bb22b0cfced4dba6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b8bc35261eb141b449a1eb2668b1d321c7ca1857","unresolved":false,"context_lines":[{"line_number":122,"context_line":"IP of the associated port."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"For the case where address translation is enabled, we will extend `DVR`__ with"},{"line_number":125,"context_line":"a new class of router named ``DvrRoutedNetworkLocalRouter``, that will only"},{"line_number":126,"context_line":"handle North / South routing and carry out the required address translations."},{"line_number":127,"context_line":"The BGP speaker will advertise the floating IP agent gateway on the"},{"line_number":128,"context_line":"corresponding compute node as the next-hop for a floating IP associated to a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf3e73b7_48a2b59c","line":125,"range":{"start_line":125,"start_character":30,"end_line":125,"end_character":57},"in_reply_to":"df3967d1_6bc4b4f5","updated":"2017-08-07 00:19:29.000000000","message":"No, we don\u0027t need a separate class for this. I misunderstood a comment made during the con call. But if it not necessary, the better :-)","commit_id":"e2eaf83de07b84cd600b77c1bb22b0cfced4dba6"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e7195bf7a7b7712c256c5ec0a8eb6c240d11d052","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This specification proposes to enable the association of ports in a Routed"},{"line_number":37,"context_line":"Network with floating IP addreses (floating IPs). This will enable operators"},{"line_number":38,"context_line":"and their users to create ports in routed networks with fixed IP addresses in"},{"line_number":39,"context_line":"private ranges and assign to them scarce publicly routable IPv4 addresses only"},{"line_number":40,"context_line":"when needed, through the association of floating IPs. This functionality will"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f436f4f_beaa856e","line":37,"range":{"start_line":37,"start_character":25,"end_line":37,"end_character":33},"updated":"2017-08-25 15:57:16.000000000","message":"s/addreses/addresses","commit_id":"8a9413253292e7640cbc0a9f15d2f7fb36a53f33"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cbf8af549ce45f1fd80c0ca20cd3f4f0fc1541f5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This specification proposes to enable the association of ports in a Routed"},{"line_number":37,"context_line":"Network with floating IP addreses (floating IPs). This will enable operators"},{"line_number":38,"context_line":"and their users to create ports in routed networks with fixed IP addresses in"},{"line_number":39,"context_line":"private ranges and assign to them scarce publicly routable IPv4 addresses only"},{"line_number":40,"context_line":"when needed, through the association of floating IPs. This functionality will"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f287b81_29d06fc9","line":37,"range":{"start_line":37,"start_character":25,"end_line":37,"end_character":33},"in_reply_to":"9f436f4f_beaa856e","updated":"2017-09-04 00:17:04.000000000","message":"Done","commit_id":"8a9413253292e7640cbc0a9f15d2f7fb36a53f33"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e7195bf7a7b7712c256c5ec0a8eb6c240d11d052","unresolved":false,"context_lines":[{"line_number":58,"context_line":"all the segments that are part of the routed network."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"We will also add a ``segments`` attribute to the ``BGP peer`` abstraction. An"},{"line_number":61,"context_line":"underlying BGP capable physical router will receive routes advertisements for"},{"line_number":62,"context_line":"the floating IPs assigned to ports in the list of segments associated to the"},{"line_number":63,"context_line":"``BGP peer`` that represents it."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f287b81_e766ce29","line":61,"range":{"start_line":61,"start_character":57,"end_line":61,"end_character":58},"updated":"2017-08-25 15:57:16.000000000","message":"nit remove \u0027s\u0027","commit_id":"8a9413253292e7640cbc0a9f15d2f7fb36a53f33"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cbf8af549ce45f1fd80c0ca20cd3f4f0fc1541f5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"all the segments that are part of the routed network."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"We will also add a ``segments`` attribute to the ``BGP peer`` abstraction. An"},{"line_number":61,"context_line":"underlying BGP capable physical router will receive routes advertisements for"},{"line_number":62,"context_line":"the floating IPs assigned to ports in the list of segments associated to the"},{"line_number":63,"context_line":"``BGP peer`` that represents it."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f287b81_09d5b3b9","line":61,"range":{"start_line":61,"start_character":57,"end_line":61,"end_character":58},"in_reply_to":"7f287b81_e766ce29","updated":"2017-09-04 00:17:04.000000000","message":"Done","commit_id":"8a9413253292e7640cbc0a9f15d2f7fb36a53f33"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e7195bf7a7b7712c256c5ec0a8eb6c240d11d052","unresolved":false,"context_lines":[{"line_number":136,"context_line":"-----------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"#. Binding of a ``BGP peer`` to a segment."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"#. ``service_type`` attribute for floating IPs."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"REST API Impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f287b81_cd22d3a4","line":139,"updated":"2017-08-25 15:57:16.000000000","message":"Should the extension to \u0027\u0027BGP Speaker\u0027\u0027 also be included here?","commit_id":"8a9413253292e7640cbc0a9f15d2f7fb36a53f33"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cbf8af549ce45f1fd80c0ca20cd3f4f0fc1541f5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"-----------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"#. Binding of a ``BGP peer`` to a segment."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"#. ``service_type`` attribute for floating IPs."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"REST API Impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f287b81_e902673e","line":139,"in_reply_to":"7f287b81_cd22d3a4","updated":"2017-09-04 00:17:04.000000000","message":"I don\u0027t think there is a change in the BGP speaker DB model","commit_id":"8a9413253292e7640cbc0a9f15d2f7fb36a53f33"}],"specs/queens/routed-networks-floating-ips.rst":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"94298b7cbfd4858211cc8f2cd59850b4ab7613ee","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed Change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This specification proposes to enable the association of ports in a Routed"},{"line_number":37,"context_line":"Network with floating IP addresses (floating IPs). This will enable operators"},{"line_number":38,"context_line":"and their users to create ports in routed networks with fixed IP addresses in"},{"line_number":39,"context_line":"private ranges and assign to them scarce publicly routable IPv4 addresses only"},{"line_number":40,"context_line":"when needed, through the association of floating IPs. This functionality will"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5f4e5783_b3ddbf71","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":49},"updated":"2017-10-12 21:47:07.000000000","message":"Well to an extent, this is already possible today isn\u0027t it? Should we be a bit more clear about the side effects that the user would see if the FIP is associated to a fixed IP of a port that\u0027s sitting on a segment of a routed network?","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"94298b7cbfd4858211cc8f2cd59850b4ab7613ee","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed Change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This specification proposes to enable the association of ports in a Routed"},{"line_number":37,"context_line":"Network with floating IP addresses (floating IPs). This will enable operators"},{"line_number":38,"context_line":"and their users to create ports in routed networks with fixed IP addresses in"},{"line_number":39,"context_line":"private ranges and assign to them scarce publicly routable IPv4 addresses only"},{"line_number":40,"context_line":"when needed, through the association of floating IPs. This functionality will"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5f4e5783_d3f6fbf9","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":49},"updated":"2017-10-12 21:47:07.000000000","message":"Well to an extent, this is already possible today isn\u0027t it? Should we be a bit more clear about the side effects that the user would see if the FIP is associated to a fixed IP of a port that\u0027s sitting on a segment of a routed network?","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"089035a132f2ab0879745da537c1230207f777ba","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed Change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This specification proposes to enable the association of ports in a Routed"},{"line_number":37,"context_line":"Network with floating IP addresses (floating IPs). This will enable operators"},{"line_number":38,"context_line":"and their users to create ports in routed networks with fixed IP addresses in"},{"line_number":39,"context_line":"private ranges and assign to them scarce publicly routable IPv4 addresses only"},{"line_number":40,"context_line":"when needed, through the association of floating IPs. This functionality will"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1f485f77_d0663152","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":49},"in_reply_to":"5f4e5783_d3f6fbf9","updated":"2017-11-12 05:57:06.000000000","message":"Question: For migration purposes to routed_networks (until this spec is implemented), is it possible that (data model wise) a network that has a segment_indentifier (so a segment of a routed network) can be associated to a neutron router.\n\nI understand that neutron may not be able to make a functioning implementation without this spec implemented.  But I was talking with Miguel about how we can migrate our current setup over to using routed networks.  Right now have a bunch of provider networks, that we associate to two routers.  One router handles public ip\u0027s another handles floating ips.  We then extended the L3 classes to let neutron do its normal stuff for association, then we call into our own api\u0027s to actually route the ip in the network.  the reverse is done for dis-associating an ip.  We do not run an L3-agent anywhere except when we are adding new networks via the api.  So we dont care if the router itself actually works (since we do the work of making the ip work).  We only care that neutron api will let us associate/disassociate ips (ie the data model works)\n\nThe plan would be to move each of those provider networks into a routed network by creating a new routed network and moving in each existing networks in as segments.  Then once this spec is implemented to attempt to migrate the existing floating ip\u0027s over to using this new functionality and remove our custom code.","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"94298b7cbfd4858211cc8f2cd59850b4ab7613ee","unresolved":false,"context_lines":[{"line_number":38,"context_line":"and their users to create ports in routed networks with fixed IP addresses in"},{"line_number":39,"context_line":"private ranges and assign to them scarce publicly routable IPv4 addresses only"},{"line_number":40,"context_line":"when needed, through the association of floating IPs. This functionality will"},{"line_number":41,"context_line":"require the changes described in the following sections."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Floating IPs advertisement with BGP Dynamic Routing"},{"line_number":44,"context_line":"---------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5f4e5783_f30fb7de","line":41,"updated":"2017-10-12 21:47:07.000000000","message":"The way I understand this is that router:external networks don\u0027t quite fully work when they are segmented and thus still only operate on the assumption that they are a single broadcast domain. Am I barking up at the wrong tree?","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"94298b7cbfd4858211cc8f2cd59850b4ab7613ee","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the two extremes just described, where several physical routers are associated"},{"line_number":77,"context_line":"with subsets of the network\u0027s segments."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Service subnets and floating IPs for routed networks"},{"line_number":80,"context_line":"----------------------------------------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"`Service subnets`__ enable operators to define valid port types for each subnet"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5f4e5783_73f187cd","line":79,"updated":"2017-10-12 21:47:07.000000000","message":"a (possibly) unrelated question. How do address scopes work with routed networks? Do we know what happens when we use them together?","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5db62ec1db00f8193214e3ab9ef3f771e15c603f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the two extremes just described, where several physical routers are associated"},{"line_number":77,"context_line":"with subsets of the network\u0027s segments."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Service subnets and floating IPs for routed networks"},{"line_number":80,"context_line":"----------------------------------------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"`Service subnets`__ enable operators to define valid port types for each subnet"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1f485f77_45d02620","line":79,"in_reply_to":"5f4e5783_73f187cd","updated":"2017-11-13 18:37:21.000000000","message":"I had a similar question on this topic. \nWhile using routed networks, is it allowed to use Address scopes in combination.\nBecause if address scopes are used then, the floatingIP are void for the same scope (internal and external network).","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5db62ec1db00f8193214e3ab9ef3f771e15c603f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"from where the address can be allocated. Continuining with the example"},{"line_number":106,"context_line":"described a few lines above, this means that the operator will associate with"},{"line_number":107,"context_line":"the routed network one or more subnets with ``service_type`` of"},{"line_number":108,"context_line":"``network:floatingip:external`` and one or more subnets with ``service_type``"},{"line_number":109,"context_line":"of ``network:floatingip:internal``. The users of this example would specify"},{"line_number":110,"context_line":"``service_type`` ``external`` or ``internal`` when creating floating IPs."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Floating IPs address translation"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1f485f77_a5923a4a","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":75},"updated":"2017-11-13 18:37:21.000000000","message":"Still not clear on how this internal floatingIP to external floatingIP translation will take place.\nAdding a picture or more description would be helpfull to understand this.","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"089035a132f2ab0879745da537c1230207f777ba","unresolved":false,"context_lines":[{"line_number":122,"context_line":"will create / associate a floating IP in the routed network and bind the"},{"line_number":123,"context_line":"address to their VM interface manually. For this use case, the next hop"},{"line_number":124,"context_line":"advertised to the infrastructure routers for the floating IP will be the fixed"},{"line_number":125,"context_line":"IP of the associated port."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For the case where address translation is enabled, we will use `DVR`__. Routers"},{"line_number":128,"context_line":"of class ``DvrLocalRouter`` in each compute host will handle North / South"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1f485f77_9004397d","line":125,"updated":"2017-11-12 05:57:06.000000000","message":"We would also like if we could either:\n1.) update allowed-address pairs to permit the associated floating ip\n\n2.) extend the anti-spoofing rules to allow traffic for the ip to pass.  \n\nMy preference would be that I would like to see the anti-spoofing rules extended - so that I had the option of keeping allowed-address-pairs locked down to specific users.","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5db62ec1db00f8193214e3ab9ef3f771e15c603f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"advertised to the infrastructure routers for the floating IP will be the fixed"},{"line_number":125,"context_line":"IP of the associated port."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For the case where address translation is enabled, we will use `DVR`__. Routers"},{"line_number":128,"context_line":"of class ``DvrLocalRouter`` in each compute host will handle North / South"},{"line_number":129,"context_line":"routing and carry out the required address translations. The BGP speaker will"},{"line_number":130,"context_line":"advertise the floating IP agent gateway on the corresponding compute node as"},{"line_number":131,"context_line":"the next-hop for a floating IP associated to a routed network port."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1f485f77_a5e0facd","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":27},"updated":"2017-11-13 18:37:21.000000000","message":"While using DVR routers, is it ok to still route traffic between two segments internally or should we prevent any routing happening through the internal routers and make sure the routing only happens outside the neutron controlled routers.","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"94298b7cbfd4858211cc8f2cd59850b4ab7613ee","unresolved":false,"context_lines":[{"line_number":248,"context_line":"-----------------------"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"A new section to the Neutron devref will be added describing the implementation"},{"line_number":251,"context_line":"of floating IPs for routed networks."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"References"},{"line_number":254,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5f4e5783_f3b697fa","line":251,"updated":"2017-10-12 21:47:07.000000000","message":"don\u0027t know how many times I said this is an old template, meh :)","commit_id":"4572b9293d9987385513897e763fc53bc6ab68d9"}],"specs/train/routed-networks-floating-ips.rst":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"380b125a2f446a2be35e980d2741ba0df7473854","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This specification proposes to enable the association of ports in a Routed"},{"line_number":37,"context_line":"Network with floating IP addresses (floating IPs). This will enable operators"},{"line_number":38,"context_line":"and their users to create ports in routed networks with fixed IP addresses in"},{"line_number":39,"context_line":"private ranges and assign to them scarce publicly routable IPv4 addresses only"},{"line_number":40,"context_line":"when needed, through the association of floating IPs. This functionality will"},{"line_number":41,"context_line":"require the changes described in the following sections."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Floating IPs advertisement with BGP Dynamic Routing"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bfb3d3c7_333e6f8c","line":40,"range":{"start_line":37,"start_character":51,"end_line":40,"end_character":53},"updated":"2019-05-24 17:13:50.000000000","message":"This needs a neutron Router connected to both private network (router interface) and public network (router gateway), so how to accomplish this association here? For routed network, the neutron Router is necessary or not?","commit_id":"225f01ad4772ebcd9aae8adb38bb189c08c5bc28"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"11a6f73d8e045618236f7254ad662355b335c9c6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This specification proposes to enable the association of ports in a Routed"},{"line_number":37,"context_line":"Network with floating IP addresses (floating IPs). This will enable operators"},{"line_number":38,"context_line":"and their users to create ports in routed networks with fixed IP addresses in"},{"line_number":39,"context_line":"private ranges and assign to them scarce publicly routable IPv4 addresses only"},{"line_number":40,"context_line":"when needed, through the association of floating IPs. This functionality will"},{"line_number":41,"context_line":"require the changes described in the following sections."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Floating IPs advertisement with BGP Dynamic Routing"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bfb3d3c7_8e8a94bc","line":40,"range":{"start_line":37,"start_character":51,"end_line":40,"end_character":53},"in_reply_to":"bfb3d3c7_333e6f8c","updated":"2019-05-24 19:06:37.000000000","message":"A neutron router is necessary. The workflow is to connect the router gateway interface to the external network, just as you do now. In my environment, the rack (ie segment) that has my network nodes (which are optional here with the exception of DHCP by the way) has a subnet with a service type of \"network:router_gateway\". The centralized router magically ends up scheduled on that segment, proper use of subnet service types makes this work flawlessly.\n\nI\u0027ll spin a new patch set that shows an example of this all in action. My PoC environment demonstrates that the only change required to make any of this work is to relax the segment-subnet constraints on routed networks. It constitutes a rather solid reference architecture, and with one single patch we could unlock powerful functionality. Strategic use of existing features including subnet service types, address scopes, subnet pools, and BGP makes this all work.","commit_id":"225f01ad4772ebcd9aae8adb38bb189c08c5bc28"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"380b125a2f446a2be35e980d2741ba0df7473854","unresolved":false,"context_lines":[{"line_number":56,"context_line":"IP\u0027s by identifying the relevant router and floating IP agent gateway ports"},{"line_number":57,"context_line":"and mapping floating IP\u0027s to their proper endpoint. In this way, it is"},{"line_number":58,"context_line":"completely agnostic of segments and is capable of properly discovering and"},{"line_number":59,"context_line":"announcing the correct next-hop for a /32 host route of a floating IP."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Service subnets and floating IPs for routed networks"},{"line_number":62,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bfb3d3c7_33674fc0","line":59,"updated":"2019-05-24 17:13:50.000000000","message":"Yes, we route it, not NAT, right? The floating IP will still be set to one device in the namespace? If not, then, which device/who will answer the floating IP ARP?","commit_id":"225f01ad4772ebcd9aae8adb38bb189c08c5bc28"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"11a6f73d8e045618236f7254ad662355b335c9c6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"IP\u0027s by identifying the relevant router and floating IP agent gateway ports"},{"line_number":57,"context_line":"and mapping floating IP\u0027s to their proper endpoint. In this way, it is"},{"line_number":58,"context_line":"completely agnostic of segments and is capable of properly discovering and"},{"line_number":59,"context_line":"announcing the correct next-hop for a /32 host route of a floating IP."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Service subnets and floating IPs for routed networks"},{"line_number":62,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bfb3d3c7_ce0bac7a","line":59,"in_reply_to":"bfb3d3c7_33674fc0","updated":"2019-05-24 19:06:37.000000000","message":"You have to route the floating IP. On the segment, ARP for the floating IP would be answered by the FIP gateway port. However, from outside the segment you have to involve routing to figure out where the FIP actually is. Nothing changes from a DVR perspective, we would have DVR assign the FIP to the FIP gateway port as it already does.\n\nDVR already knows how to apply FIP\u0027s to the FIP gateway (it\u0027s segment-agnostic), the only piece missing is to allow a subnet that is not bound to a segment to be created on the external network. There is no change to DVR involved here.\n\nWith regard to ARP: as I mentioned earlier the upstream router would theoretically be able to ARP for the FIP, however in practice you would never see it do that because BGP would be telling it to route the /32.","commit_id":"225f01ad4772ebcd9aae8adb38bb189c08c5bc28"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"a9aa53c1a809fe16631771fb02afce6330decce7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"segment when one or more subnets on the network are already bound to a"},{"line_number":87,"context_line":"segment. To address this limitation, the following options exist:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* Simply relax the constraint that all subnets or none must be bound to a"},{"line_number":90,"context_line":"  segment."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Allow subnets with a ``service_type`` of ``network:floatingip`` to span the"},{"line_number":93,"context_line":"  subnet by allowing them to exempted from segment binding restrictions."}],"source_content_type":"text/x-rst","patch_set":12,"id":"bfb3d3c7_68a3aa9f","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":10},"updated":"2019-05-23 20:01:09.000000000","message":"See https://github.com/openstack/neutron/blob/6ba8d8d6f4993467dc48acb9a665933ea194ca2e/neutron/db/ipam_backend_mixin.py#L318 . I\u0027m not yet sure of what the implications of simply relaxing this constraint altogether are, but it does seem like the easiest and least invasive way of implementing this spec.","commit_id":"225f01ad4772ebcd9aae8adb38bb189c08c5bc28"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"380b125a2f446a2be35e980d2741ba0df7473854","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"This change is not expected to pose any new security concerns."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Other End User Impact"},{"line_number":101,"context_line":"---------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The client will be enhanced to support changes in the API. Horizon will need"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bfb3d3c7_33d98f7e","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":21},"updated":"2019-05-24 17:13:50.000000000","message":"Or add a basic workflow from the user\u0027s perspective?","commit_id":"225f01ad4772ebcd9aae8adb38bb189c08c5bc28"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"11a6f73d8e045618236f7254ad662355b335c9c6","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"This change is not expected to pose any new security concerns."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Other End User Impact"},{"line_number":101,"context_line":"---------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The client will be enhanced to support changes in the API. Horizon will need"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bfb3d3c7_ee48f087","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":21},"in_reply_to":"bfb3d3c7_33d98f7e","updated":"2019-05-24 19:06:37.000000000","message":"There is no impact to the workflow of a tenant. They still simply create a router, then set up the gateway interface, and attach floating IP\u0027s just as they do today.\n\nThe operator impact is simply around learning how to use things that already exist in neutron like routed provider networks, address scopes, subnet pools, subnet service types, and neutron-dynamic-routing. By fixing this one thing (allowing a subnet to not be bound to a segment), this becomes simply a documentation exercise.","commit_id":"225f01ad4772ebcd9aae8adb38bb189c08c5bc28"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"8e918c3311ccfa84033adae905a36313cf9cead6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Other End User Impact"},{"line_number":101,"context_line":"---------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The client will be enhanced to support changes in the API. Horizon will need"},{"line_number":104,"context_line":"to expose the ``service_type`` attribute on floating IPs."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Implementation"},{"line_number":107,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bfb3d3c7_e5634319","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":57},"updated":"2019-05-23 19:28:44.000000000","message":"Oops, forgot to remove this bit. I\u0027m proposing we not go through with this API change anymore. Keep it simple and relax the constraints on subnet creation on routed networks. BGP can take it from there (I think...)","commit_id":"225f01ad4772ebcd9aae8adb38bb189c08c5bc28"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"91c591e4439bd4ba50a643c21f54a6a5bf6619bc","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The current definition of a routed provider network is a network in which"},{"line_number":61,"context_line":"each subnet is associated to a different segment. This definition will change"},{"line_number":62,"context_line":"subtly and include networks where 1 or more subnets with a ``service_type`` of"},{"line_number":63,"context_line":"``network:routed`` is associated with the network but none of the individual"},{"line_number":64,"context_line":"segments comprising it."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_f749eab6","line":62,"range":{"start_line":62,"start_character":61,"end_line":62,"end_character":73},"updated":"2019-07-25 11:27:24.000000000","message":"nit: service_types","commit_id":"1308854f05332166f3a2e48f948c502401edd324"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"91c591e4439bd4ba50a643c21f54a6a5bf6619bc","unresolved":false,"context_lines":[{"line_number":189,"context_line":"Tempest Tests"},{"line_number":190,"context_line":"-------------"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"There will be additions to tempest tests."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Functional Tests"},{"line_number":195,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_d77f0ea9","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":41},"updated":"2019-07-25 11:27:24.000000000","message":"Just a note: there are no tempest tests for the routed provider networks feature.","commit_id":"1308854f05332166f3a2e48f948c502401edd324"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"91c591e4439bd4ba50a643c21f54a6a5bf6619bc","unresolved":false,"context_lines":[{"line_number":199,"context_line":"API Tests"},{"line_number":200,"context_line":"---------"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"- Floating IP subnets can be created on a routed provider network"},{"line_number":203,"context_line":"- Floating IP\u0027s can be created on a routed provider network"},{"line_number":204,"context_line":"- Floating IP\u0027s from the same subnet can be associated to ports across"},{"line_number":205,"context_line":"  different segments"},{"line_number":206,"context_line":"- Tests in neutron-dynamic-routing to assert proper route discovery on"},{"line_number":207,"context_line":"  routed provider networks"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_e2c84675","line":205,"range":{"start_line":202,"start_character":2,"end_line":205,"end_character":20},"updated":"2019-07-25 11:27:24.000000000","message":"Just a note: actually as I see there are no API tests (nor functional or fullstack as I see) for routed provider networks feature.\nI started to add to tempest, see:\nhttps://review.opendev.org/665155\n\nAs I see it would be good to have some tests for the whole feature before moving forward with new functionality.\n\nBtw: For fullstack tests the minimal placement server can be used which was added to test the bandwidth feature (see: https://opendev.org/openstack/neutron/src/branch/master/neutron/tests/fullstack/servers/placement.py).","commit_id":"1308854f05332166f3a2e48f948c502401edd324"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9b9f3a5e155e300521aa5dfbcc81632648dcff20","unresolved":false,"context_lines":[{"line_number":84,"context_line":"floating IP subnet that can be used on a routed provider network, the subnet"},{"line_number":85,"context_line":"should be created with two ``service_types``: ``network:routed`` and"},{"line_number":86,"context_line":"``network:floatingip``. ``network:routed`` allows the subnet to be pinned to"},{"line_number":87,"context_line":"the network rather than a particular segment, and ``network:floatingip``"},{"line_number":88,"context_line":"allows for floating IP\u0027s be allocated from the subnet."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"No changes are anticipated to enable this to work properly. Documentation"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9f560f44_fac0132d","line":87,"updated":"2020-07-30 08:27:22.000000000","message":"Why \"network:floatingip\" is not enough for a subnet to be allocated in a routed network?","commit_id":"8fbc6959be72d012a4e67f3a4606d96b3d564f54"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"3acd745aa6e70df5ed8e4436ea49c3fbce58738e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"floating IP subnet that can be used on a routed provider network, the subnet"},{"line_number":85,"context_line":"should be created with two ``service_types``: ``network:routed`` and"},{"line_number":86,"context_line":"``network:floatingip``. ``network:routed`` allows the subnet to be pinned to"},{"line_number":87,"context_line":"the network rather than a particular segment, and ``network:floatingip``"},{"line_number":88,"context_line":"allows for floating IP\u0027s be allocated from the subnet."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"No changes are anticipated to enable this to work properly. Documentation"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9f560f44_af0cdf3b","line":87,"in_reply_to":"9f560f44_fac0132d","updated":"2020-08-12 13:19:38.000000000","message":"We need network:routed for the exact reason that is described here: to allow the subnet to *not* be bound to a specific segment. Having *only* network:floatingip is a valid configuration, but it would be different from a subnet which also has network:routed.\n\nA subnet with network:floatingip with a segmented network will have different floatingip ranges depending on the segment.\n\nA subnet with both network:floatingip and network:routed will be in used on all segments, and will use the provider network as the next BGP HOP.","commit_id":"8fbc6959be72d012a4e67f3a4606d96b3d564f54"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9b9f3a5e155e300521aa5dfbcc81632648dcff20","unresolved":false,"context_lines":[{"line_number":98,"context_line":"No changes to the current operation of DVR need to be made in support of"},{"line_number":99,"context_line":"these changes. Changes to documentation will be made to reflect the fact that"},{"line_number":100,"context_line":"subnets on segments where you wish to have floating IP gateway ports built"},{"line_number":101,"context_line":"should be created with the ```service_type`` of"},{"line_number":102,"context_line":"``network:floatingip_agent_gateway`` should be used to indicate that compute"},{"line_number":103,"context_line":"nodes can reach the routed external network on a given segment. For the"},{"line_number":104,"context_line":"network node connectivity, a ``service_type`` of ``network:router_gateway``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9f560f44_7a38833c","line":101,"updated":"2020-07-30 08:27:22.000000000","message":"same here, why do we need another type?","commit_id":"8fbc6959be72d012a4e67f3a4606d96b3d564f54"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"3acd745aa6e70df5ed8e4436ea49c3fbce58738e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"No changes to the current operation of DVR need to be made in support of"},{"line_number":99,"context_line":"these changes. Changes to documentation will be made to reflect the fact that"},{"line_number":100,"context_line":"subnets on segments where you wish to have floating IP gateway ports built"},{"line_number":101,"context_line":"should be created with the ```service_type`` of"},{"line_number":102,"context_line":"``network:floatingip_agent_gateway`` should be used to indicate that compute"},{"line_number":103,"context_line":"nodes can reach the routed external network on a given segment. For the"},{"line_number":104,"context_line":"network node connectivity, a ``service_type`` of ``network:router_gateway``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9f560f44_af25ffad","line":101,"in_reply_to":"9f560f44_7a38833c","updated":"2020-08-12 13:19:38.000000000","message":"There\u0027s no need for a *new* type, as this type already exist. This type is used in the provider network, so that floating IPs can use these IPs as next BGP HOP, and we need to make sure the range is used *only* for this (and nothing else).","commit_id":"8fbc6959be72d012a4e67f3a4606d96b3d564f54"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4122152021fd043084c7f0d30e640a2d7007d303","unresolved":false,"context_lines":[{"line_number":99,"context_line":"these changes. Changes to documentation will be made to reflect the fact that"},{"line_number":100,"context_line":"subnets on segments where you wish to have floating IP gateway ports built"},{"line_number":101,"context_line":"should be created with the ```service_type`` of"},{"line_number":102,"context_line":"``network:floatingip_agent_gateway`` should be used to indicate that compute"},{"line_number":103,"context_line":"nodes can reach the routed external network on a given segment. For the"},{"line_number":104,"context_line":"network node connectivity, a ``service_type`` of ``network:router_gateway``"},{"line_number":105,"context_line":"should be used to indicate centralized router ports will be instantiated on"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_d297b845","line":102,"range":{"start_line":102,"start_character":37,"end_line":102,"end_character":51},"updated":"2019-12-08 21:33:36.000000000","message":"nit, this reads bad with should ... should ..\n\nWould read better if these three words was removed. s/should be used//","commit_id":"8fbc6959be72d012a4e67f3a4606d96b3d564f54"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"906a4fbe72768975dffb6306bc6cc72900651df8","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Primary assignee:"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* `Ryan Tidwell \u003chttps://launchpad.net/~ryan-tidwell\u003e`_"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Other contributors:"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"* `Miguel Lavalle \u003chttps://launchpad.net/~minsel\u003e`_"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Work Items"},{"line_number":174,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"1fa4df85_6450bad5","line":171,"range":{"start_line":167,"start_character":0,"end_line":171,"end_character":51},"updated":"2020-03-02 11:24:24.000000000","message":"I\u0027m fine with merging this but do You really plan to work on this?","commit_id":"8fbc6959be72d012a4e67f3a4606d96b3d564f54"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"837ad9a673c159d2b31b86f61ffdd6bba0c6c54d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"There are currently no tempest tests for routed provider networks. However,"},{"line_number":193,"context_line":"some tests are being developed and tests that cover floating IP creation on"},{"line_number":194,"context_line":"routed provider networks can eventually be added to these tests."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Functional Tests"},{"line_number":197,"context_line":"----------------"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_9cc8ae56","line":195,"updated":"2019-12-04 12:40:22.000000000","message":"Some tests are under review, just to have some reference here as well:\nhttps://review.opendev.org/665155","commit_id":"8fbc6959be72d012a4e67f3a4606d96b3d564f54"}]}
