)]}'
{"specs/queens/sriov_bond.rst":[{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port using"},{"line_number":16,"context_line":"SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_c390a251","line":14,"updated":"2017-10-30 19:28:35.000000000","message":"I can bond virtual NICs just as well as SRIOV ones.  More relevant is the use of multiple uplinks.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"511522fb80e2ac3c52121a237e75e70befc847d4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port using"},{"line_number":16,"context_line":"SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_649b06c9","line":14,"in_reply_to":"3f4b6375_c390a251","updated":"2017-11-01 07:45:51.000000000","message":"thanks, Wells,good to see your reply","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port using"},{"line_number":16,"context_line":"SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_43c03251","line":15,"updated":"2017-10-30 19:28:35.000000000","message":"Not to mention that if you don\u0027t define \u0027bond\u0027 here (passive, active/backup vs round robin vs LACP actively conducted by the VM) you are adding to the confusion.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"511522fb80e2ac3c52121a237e75e70befc847d4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port using"},{"line_number":16,"context_line":"SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_845e0210","line":15,"in_reply_to":"3f4b6375_43c03251","updated":"2017-11-01 07:45:51.000000000","message":"Sorry for the confusion,i\u0027ll make it clear.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"adapters to implement this."},{"line_number":26,"context_line":"For example:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"But this BP have some limits in the following areas:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_e3cefe81","line":28,"updated":"2017-10-30 19:28:35.000000000","message":"These are related but independent ideas.  It\u0027s logical that I don\u0027t want shared components in two bonded links between the bond endpoints if I can achieve it, but should I be able to specify that (which the spec here actually doesn\u0027t allow me to specify, and nor does yours)?","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"1.  In the Vxlan network scenario, when using SR-IOV,we must use ToR"},{"line_number":33,"context_line":"    switch as a vtep.So,it cannot specify a physical network and you"},{"line_number":34,"context_line":"    cannot select which of the VF belongs to a particular PF."},{"line_number":35,"context_line":"2.  As a SR-IOV bond port,we need two or more VFs which have the"},{"line_number":36,"context_line":"    same mac to avoid the problem of spoof because mostly linux bond"},{"line_number":37,"context_line":"    or dpdk bond will make the packet have the same source mac from the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_03afda94","line":34,"updated":"2017-10-30 19:28:35.000000000","message":"I can assign two PFs to the same physnet (and in some sense a VXLAN network has a physnet, corresponding to its VRF).  Regardless of segmentation type it\u0027s normal that bonding is at the switch. Bonding in the vswitch achieves nothing.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"511522fb80e2ac3c52121a237e75e70befc847d4","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"1.  In the Vxlan network scenario, when using SR-IOV,we must use ToR"},{"line_number":33,"context_line":"    switch as a vtep.So,it cannot specify a physical network and you"},{"line_number":34,"context_line":"    cannot select which of the VF belongs to a particular PF."},{"line_number":35,"context_line":"2.  As a SR-IOV bond port,we need two or more VFs which have the"},{"line_number":36,"context_line":"    same mac to avoid the problem of spoof because mostly linux bond"},{"line_number":37,"context_line":"    or dpdk bond will make the packet have the same source mac from the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_199f1b04","line":34,"in_reply_to":"3f4b6375_03afda94","updated":"2017-11-01 07:45:51.000000000","message":"yes,some bonding is at the switch ,i.e openvswitch","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":55,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":56,"context_line":"from two different NICs.In HostOS bond this tow NICs together and"},{"line_number":57,"context_line":"deliver the bond mode to the GuestOS through metadata,in GuestOS dpdk"},{"line_number":58,"context_line":"bond the two VFs together."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_0388fa1c","line":56,"updated":"2017-10-30 19:28:35.000000000","message":"In what sense do you consider the host OS has anything to do with the bonding?","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"511522fb80e2ac3c52121a237e75e70befc847d4","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":55,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":56,"context_line":"from two different NICs.In HostOS bond this tow NICs together and"},{"line_number":57,"context_line":"deliver the bond mode to the GuestOS through metadata,in GuestOS dpdk"},{"line_number":58,"context_line":"bond the two VFs together."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_5963531b","line":56,"in_reply_to":"3f4b6375_0388fa1c","updated":"2017-11-01 07:45:51.000000000","message":"some bonding configuration is needed in the host OS","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3dfddbbe1b0ccf301919a3fc269a577ed4e4eebf","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Creat neutron bond port with neutron API::"},{"line_number":81,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --binding:profile\u003d{bond\u003dtrue, \\"},{"line_number":82,"context_line":"    bond_mode\u003dactive-backup,bound_count\u003d2,bond_antiafinity\u003dpf} --name bond1 private"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"2.  Creat SR-IOV VM with nova API::"},{"line_number":85,"context_line":"    nova boot --nic port-id\u003dbond1"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_2ed3d23a","line":82,"updated":"2017-09-25 10:27:04.000000000","message":"It\u0027s not clear what is going to configure the bonding on the guest OS.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"0912cd7bfb8504b4210c03a478586aeb0c42c329","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Creat neutron bond port with neutron API::"},{"line_number":81,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --binding:profile\u003d{bond\u003dtrue, \\"},{"line_number":82,"context_line":"    bond_mode\u003dactive-backup,bound_count\u003d2,bond_antiafinity\u003dpf} --name bond1 private"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"2.  Creat SR-IOV VM with nova API::"},{"line_number":85,"context_line":"    nova boot --nic port-id\u003dbond1"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_62fe4c38","line":82,"in_reply_to":"7f515b1d_2ed3d23a","updated":"2017-10-23 09:57:55.000000000","message":"Done,I have added the configuring of bonding on the guest,please review it again,thanks","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    bond_mode\u003dactive-backup,bound_count\u003d2,bond_antiafinity\u003dpf} --name bond1 private"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"2.  Creat SR-IOV VM with nova API::"},{"line_number":85,"context_line":"    nova boot --nic port-id\u003dbond1"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"3.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":88,"context_line":"    one or more VFs to VM according to the port bonding info."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_a3ab6673","line":85,"updated":"2017-10-30 19:28:35.000000000","message":"This is one port with two virtual interfaces, it would seem.  I imagine that breaks about half of Neutron and a good chunk of Nova.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"511522fb80e2ac3c52121a237e75e70befc847d4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    bond_mode\u003dactive-backup,bound_count\u003d2,bond_antiafinity\u003dpf} --name bond1 private"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"2.  Creat SR-IOV VM with nova API::"},{"line_number":85,"context_line":"    nova boot --nic port-id\u003dbond1"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"3.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":88,"context_line":"    one or more VFs to VM according to the port bonding info."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_d90d033f","line":85,"in_reply_to":"3f4b6375_a3ab6673","updated":"2017-11-01 07:45:51.000000000","message":"understand your concern,in fact we have apply it in our product TECS(based on OpenStack) and it works well.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    nova boot --nic port-id\u003dbond1"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"3.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":88,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"4.  Add a OVS/LINUX bond of PFs manually in VM."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_83a86a77","line":88,"updated":"2017-10-30 19:28:35.000000000","message":"And what will tell the VM that there\u0027s a bonded pair of ports?  Metadata?  How?","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"511522fb80e2ac3c52121a237e75e70befc847d4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    nova boot --nic port-id\u003dbond1"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"3.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":88,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"4.  Add a OVS/LINUX bond of PFs manually in VM."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_64ff8601","line":88,"in_reply_to":"3f4b6375_83a86a77","updated":"2017-11-01 07:45:51.000000000","message":"by metadata","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"3.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":88,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"4.  Add a OVS/LINUX bond of PFs manually in VM."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_43bcb2ba","line":90,"updated":"2017-10-30 19:28:35.000000000","message":"Nothing in this will be \u0027manual\u0027 so there\u0027s something somewhere that should be telling the VM this needs to happen.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"511522fb80e2ac3c52121a237e75e70befc847d4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"3.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":88,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"4.  Add a OVS/LINUX bond of PFs manually in VM."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_84172246","line":90,"in_reply_to":"3f4b6375_43bcb2ba","updated":"2017-11-01 07:45:51.000000000","message":"yes,we shoud config the bond port in vm, i have added the info in patch 6,thanks","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"4246d05491c3f32acb65ada5c34a93919a4e83e1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"---------------------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  * Cloud deployer will need to set the ``phynic_mappings`` to allow"},{"line_number":138,"context_line":"    bonding for PCI devices."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Developer impact"},{"line_number":141,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_83c18a31","line":138,"updated":"2017-10-30 19:28:35.000000000","message":"Since this is the first time you\u0027ve mentioned this setting, I think it\u0027s clear that this is missing implementation details.","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"511522fb80e2ac3c52121a237e75e70befc847d4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"---------------------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  * Cloud deployer will need to set the ``phynic_mappings`` to allow"},{"line_number":138,"context_line":"    bonding for PCI devices."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Developer impact"},{"line_number":141,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_c464fae7","line":138,"in_reply_to":"3f4b6375_83c18a31","updated":"2017-11-01 07:45:51.000000000","message":"yes,indeed,i have added the details in patch 6~","commit_id":"2a4bbba6ab14411400c5fef087be4f339bb1031a"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"20d200375847143d23de159018cc6abc570618a5","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port using"},{"line_number":16,"context_line":"SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f4b6375_c3f54285","line":14,"updated":"2017-10-30 19:30:49.000000000","message":"Please see my comments on patch 4, most are still relevant (I was just on the wrong version).","commit_id":"a21517edfbfb3e427bdafefb9cee605aaec72f75"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"20d200375847143d23de159018cc6abc570618a5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    SLAVE\u003dyes"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    then restart network service with command::"},{"line_number":121,"context_line":"    systemctl restart network.service"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f4b6375_03047a7a","line":121,"updated":"2017-10-30 19:30:49.000000000","message":"No-one running cloud applications logs into a machine to make the application work.  How can the VM work out on its own (eg via cloud-init) that the interfaces are bonded, and how?","commit_id":"a21517edfbfb3e427bdafefb9cee605aaec72f75"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"7e7b81e3f23ca981778a749d76d451f80e74482f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    SLAVE\u003dyes"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    then restart network service with command::"},{"line_number":121,"context_line":"    systemctl restart network.service"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f4b6375_c4451a17","line":121,"in_reply_to":"3f4b6375_03047a7a","updated":"2017-11-01 07:53:10.000000000","message":"it\u0027s good to do it via cloud-init,thanks for your advice,i\u0027ll modify it .","commit_id":"a21517edfbfb3e427bdafefb9cee605aaec72f75"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port(with mode"},{"line_number":16,"context_line":"\"active-backup\") using SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_c46ef1fe","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":4},"updated":"2017-11-29 08:31:23.000000000","message":"I don\u0027t think the technology not support, I think you want to describe that Openstack need this ability for launch instance with a bond nic for L2 traffic HA. Right?","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port(with mode"},{"line_number":16,"context_line":"\"active-backup\") using SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_a4b64d89","line":15,"range":{"start_line":15,"start_character":5,"end_line":15,"end_character":7},"updated":"2017-11-29 08:31:23.000000000","message":"there should be a blank after \u0027.\u0027","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port(with mode"},{"line_number":16,"context_line":"\"active-backup\") using SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_8a1dcb67","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":4},"in_reply_to":"ff82abbf_c46ef1fe","updated":"2017-12-06 08:39:11.000000000","message":"Done","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port(with mode"},{"line_number":16,"context_line":"\"active-backup\") using SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_a49ded0a","line":17,"range":{"start_line":17,"start_character":42,"end_line":17,"end_character":44},"updated":"2017-11-29 08:31:23.000000000","message":"there should be a blank after \u0027,\u0027","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Current Single root I/O virtualization (SR-IOV) don\u0027t have the function of"},{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port(with mode"},{"line_number":16,"context_line":"\"active-backup\") using SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_aa18cf74","line":17,"range":{"start_line":17,"start_character":42,"end_line":17,"end_character":44},"in_reply_to":"ff82abbf_a49ded0a","updated":"2017-12-06 08:39:11.000000000","message":"Done","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port(with mode"},{"line_number":16,"context_line":"\"active-backup\") using SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_04c4d9f3","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":26},"updated":"2017-11-29 08:31:23.000000000","message":"from","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"bond.In NFV scenario,it is really useful to add a bond port(with mode"},{"line_number":16,"context_line":"\"active-backup\") using SR-IOV NICs.It\u0027s just **one port** logically."},{"line_number":17,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":18,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_4a290388","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":26},"in_reply_to":"ff82abbf_04c4d9f3","updated":"2017-12-06 08:39:11.000000000","message":"Done","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV.But currently"},{"line_number":23,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":24,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":25,"context_line":"adapters to implement this."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_847469d0","line":22,"range":{"start_line":22,"start_character":17,"end_line":22,"end_character":21},"updated":"2017-11-29 08:31:23.000000000","message":"blank","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV.But currently"},{"line_number":23,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":24,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":25,"context_line":"adapters to implement this."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_247f9dab","line":22,"range":{"start_line":22,"start_character":58,"end_line":22,"end_character":61},"updated":"2017-11-29 08:31:23.000000000","message":"ditto","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV.But currently"},{"line_number":23,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":24,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":25,"context_line":"adapters to implement this."}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_6a2c0799","line":22,"range":{"start_line":22,"start_character":17,"end_line":22,"end_character":21},"in_reply_to":"ff82abbf_847469d0","updated":"2017-12-06 08:39:11.000000000","message":"Done","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV.But currently"},{"line_number":23,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":24,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":25,"context_line":"adapters to implement this."},{"line_number":26,"context_line":"For example:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_64104558","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":27},"updated":"2017-11-29 08:31:23.000000000","message":"The solution provided by nova and neutron is that we need to attach multiple neutron VF ports which allocated from different PF nics.","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV.But currently"},{"line_number":23,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":24,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":25,"context_line":"adapters to implement this."},{"line_number":26,"context_line":"For example:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_aa69af8b","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":27},"in_reply_to":"ff82abbf_64104558","updated":"2017-12-06 08:39:11.000000000","message":"You\u0027re right, we can guarantee it by configuration","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"But this BP have some limits in the following areas:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"1.  In the Vxlan network scenario, when using SR-IOV,we must use ToR"},{"line_number":33,"context_line":"    switch as a vtep.So,it cannot specify a physical network and you"},{"line_number":34,"context_line":"    cannot select which of the VF belongs to a particular PF."},{"line_number":35,"context_line":"2.  As a SR-IOV bond port,we need two or more VFs which have the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_a6017207","line":32,"range":{"start_line":32,"start_character":53,"end_line":32,"end_character":55},"updated":"2017-11-29 08:31:23.000000000","message":"blank","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"But this BP have some limits in the following areas:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"1.  In the Vxlan network scenario, when using SR-IOV,we must use ToR"},{"line_number":33,"context_line":"    switch as a vtep.So,it cannot specify a physical network and you"},{"line_number":34,"context_line":"    cannot select which of the VF belongs to a particular PF."},{"line_number":35,"context_line":"2.  As a SR-IOV bond port,we need two or more VFs which have the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_0a23fba9","line":32,"range":{"start_line":32,"start_character":53,"end_line":32,"end_character":55},"in_reply_to":"ff82abbf_a6017207","updated":"2017-12-06 08:39:11.000000000","message":"Done","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_04cdb92f","line":80,"range":{"start_line":80,"start_character":12,"end_line":80,"end_character":18},"updated":"2017-11-29 08:31:23.000000000","message":"adds","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_ca3c33ca","line":80,"range":{"start_line":80,"start_character":12,"end_line":80,"end_character":18},"in_reply_to":"ff82abbf_04cdb92f","updated":"2017-12-06 08:39:11.000000000","message":"Done","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_e61a1a6d","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":24},"updated":"2017-11-29 08:31:23.000000000","message":"compute","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_4610a64e","line":81,"range":{"start_line":81,"start_character":25,"end_line":81,"end_character":31},"updated":"2017-11-29 08:31:23.000000000","message":"split","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_ea37b7e2","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":24},"in_reply_to":"ff82abbf_e61a1a6d","updated":"2017-12-06 08:39:11.000000000","message":"Done","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_66204a9c","line":90,"range":{"start_line":90,"start_character":62,"end_line":90,"end_character":71},"updated":"2017-11-29 08:31:23.000000000","message":"this must be a string type. right?","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_8a362be6","line":90,"range":{"start_line":90,"start_character":62,"end_line":90,"end_character":71},"in_reply_to":"ff82abbf_66204a9c","updated":"2017-12-06 08:39:11.000000000","message":"Done","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"6.  Add LINUX bond of VFs via cloud-init in VM."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_8658ee30","line":102,"updated":"2017-11-29 08:31:23.000000000","message":"I\u0027m afraid that the contents of proposed Header is a way to use the new feature. What\u0027s your plan/details to implement it?","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"6.  Add LINUX bond of VFs via cloud-init in VM."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_6a51670e","line":102,"in_reply_to":"ff82abbf_8658ee30","updated":"2017-12-06 08:39:11.000000000","message":"Understand your worries, maybe we can do it by manual operation in the current status, and discuss the plan in the new blueprint.","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Performance Impact"},{"line_number":155,"context_line":"------------------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"None"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_e648da5c","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":4},"updated":"2017-11-29 08:31:23.000000000","message":"I don\u0027t think no affect.","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"cbe28f4bb005ac10052dc1de1c47c926032c547e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Performance Impact"},{"line_number":155,"context_line":"------------------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"None"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df87a7cf_ea6577e2","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":4},"in_reply_to":"ff82abbf_e648da5c","updated":"2017-12-06 08:39:11.000000000","message":"thanks for the comments, i think it has a small impact on the performance.","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  * Reflactor existing codes to make it compatible with new port bonding info."},{"line_number":186,"context_line":"  * Implement new physnet configuration."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Dependencies"},{"line_number":189,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_a678928f","line":187,"updated":"2017-11-29 08:31:23.000000000","message":"No UTs/function test addition?","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"8ac1b63b01e3d8c0cc34241f2d489791e731e485","unresolved":false,"context_lines":[{"line_number":199,"context_line":"Documentation Impact"},{"line_number":200,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"The config-sriov.rst in the networking-guide should be updated with"},{"line_number":203,"context_line":"information on how this feature should be used."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff82abbf_666e0aca","line":202,"range":{"start_line":202,"start_character":4,"end_line":202,"end_character":45},"updated":"2017-11-29 08:31:23.000000000","message":"Please add as a reference link.","commit_id":"77a391bc3a1d2580e309fb47ab0652ee4ad4fd89"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"46d17954b073129e0fa57eb5a8ea4084b74c2ab9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"1.  Neutron adds configure option in the sriov_agent.ini on the bond"},{"line_number":82,"context_line":"    compute node to tell neutron server this compute node needs bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df87a7cf_d1dde714","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":65},"updated":"2017-12-05 12:31:48.000000000","message":"This confused me because we already have physical_device_mappings for SR_IOV. Cloud you describe the difference here?\n\nAnyway, what do bond1 and eth1-eth2 mean?","commit_id":"91dffb2648e06a0ac73d4aa6db52186c8146b2e1"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"742de625f1d070d10bd0a497fe0bdf2993692fd7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"1.  Neutron adds configure option in the sriov_agent.ini on the bond"},{"line_number":82,"context_line":"    compute node to tell neutron server this compute node needs bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df87a7cf_cf2525c4","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":65},"in_reply_to":"df87a7cf_6f32d9a9","updated":"2017-12-06 08:25:34.000000000","message":"Done","commit_id":"91dffb2648e06a0ac73d4aa6db52186c8146b2e1"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"b00af6db5bb8e7854759652791b0505ff9f9182e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"1.  Neutron adds configure option in the sriov_agent.ini on the bond"},{"line_number":82,"context_line":"    compute node to tell neutron server this compute node needs bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df87a7cf_6f32d9a9","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":65},"in_reply_to":"df87a7cf_d1dde714","updated":"2017-12-06 08:15:24.000000000","message":"Sorry for the confusion, physical_device_mappings is ok, i\u0027ll fix it. \nBy the way, the ports are the members of the SR-IOV bond.","commit_id":"91dffb2648e06a0ac73d4aa6db52186c8146b2e1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"46d17954b073129e0fa57eb5a8ea4084b74c2ab9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":\"eth1-eth2\"}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df87a7cf_51a3179f","line":90,"range":{"start_line":86,"start_character":0,"end_line":90,"end_character":75},"updated":"2017-12-05 12:31:48.000000000","message":"I\u0027m not sure what is added. Could you show that current vif_details of SR_IOV and the vif_details of this feature?","commit_id":"91dffb2648e06a0ac73d4aa6db52186c8146b2e1"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"b00af6db5bb8e7854759652791b0505ff9f9182e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":\"eth1-eth2\"}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df87a7cf_cf7e8518","line":90,"range":{"start_line":86,"start_character":0,"end_line":90,"end_character":75},"in_reply_to":"df87a7cf_51a3179f","updated":"2017-12-06 08:15:24.000000000","message":"thanks for the comments, i\u0027ll make it clear","commit_id":"91dffb2648e06a0ac73d4aa6db52186c8146b2e1"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"742de625f1d070d10bd0a497fe0bdf2993692fd7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":\"eth1-eth2\"}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df87a7cf_ef2029b3","line":90,"range":{"start_line":86,"start_character":0,"end_line":90,"end_character":75},"in_reply_to":"df87a7cf_cf7e8518","updated":"2017-12-06 08:25:34.000000000","message":"Done","commit_id":"91dffb2648e06a0ac73d4aa6db52186c8146b2e1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e887247eae236c444c1c5bfda7e45a471548896","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":56,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":57,"context_line":"from two different NICs. In HostOS bond this tow NICs together and"},{"line_number":58,"context_line":"deliver the bond mode to the GuestOS through metadata, in GuestOS dpdk"},{"line_number":59,"context_line":"bond the two VFs together."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_d85831fb","line":57,"range":{"start_line":57,"start_character":45,"end_line":57,"end_character":48},"updated":"2017-12-10 06:08:28.000000000","message":"two?","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"c4fc3002a8d22912ea496a485e736cde99fa0622","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":56,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":57,"context_line":"from two different NICs. In HostOS bond this tow NICs together and"},{"line_number":58,"context_line":"deliver the bond mode to the GuestOS through metadata, in GuestOS dpdk"},{"line_number":59,"context_line":"bond the two VFs together."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_2bca201a","line":57,"range":{"start_line":57,"start_character":45,"end_line":57,"end_character":48},"in_reply_to":"df87a7cf_d85831fb","updated":"2017-12-11 01:10:02.000000000","message":"Done","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e887247eae236c444c1c5bfda7e45a471548896","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    The configure will be used to set the same mac address for the two ports."},{"line_number":91,"context_line":"    For example::"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_b8f68dd6","line":93,"updated":"2017-12-10 06:08:28.000000000","message":"should this be same as line#85 ?","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"c4fc3002a8d22912ea496a485e736cde99fa0622","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    The configure will be used to set the same mac address for the two ports."},{"line_number":91,"context_line":"    For example::"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_6be348a5","line":93,"in_reply_to":"df87a7cf_b8f68dd6","updated":"2017-12-11 01:10:02.000000000","message":"yes, the mapping info provides the members of the bond port,thanks for reviewing~","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e887247eae236c444c1c5bfda7e45a471548896","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_586c219b","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":9},"updated":"2017-12-10 06:08:28.000000000","message":"create","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"c4fc3002a8d22912ea496a485e736cde99fa0622","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_4bcd242f","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":9},"in_reply_to":"df87a7cf_586c219b","updated":"2017-12-11 01:10:02.000000000","message":"Done","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e887247eae236c444c1c5bfda7e45a471548896","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"4.  Creat SR-IOV VM with nova API::"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        nova boot --nic port-id\u003dbond1"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_7867a5b8","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":9},"updated":"2017-12-10 06:08:28.000000000","message":"same","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"c4fc3002a8d22912ea496a485e736cde99fa0622","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"4.  Creat SR-IOV VM with nova API::"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        nova boot --nic port-id\u003dbond1"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_ebcf5826","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":9},"in_reply_to":"df87a7cf_7867a5b8","updated":"2017-12-11 01:10:02.000000000","message":"Done","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e887247eae236c444c1c5bfda7e45a471548896","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Other deployer impact"},{"line_number":166,"context_line":"---------------------"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  * Cloud deployer will need to set the ``physical_device_mappings`` "},{"line_number":169,"context_line":"    to allow bonding for PCI devices."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_f8109502","line":168,"range":{"start_line":168,"start_character":68,"end_line":168,"end_character":69},"updated":"2017-12-10 06:08:28.000000000","message":"remove the space","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"c4fc3002a8d22912ea496a485e736cde99fa0622","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Other deployer impact"},{"line_number":166,"context_line":"---------------------"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  * Cloud deployer will need to set the ``physical_device_mappings`` "},{"line_number":169,"context_line":"    to allow bonding for PCI devices."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":16,"id":"df87a7cf_0bd39cd6","line":168,"range":{"start_line":168,"start_character":68,"end_line":168,"end_character":69},"in_reply_to":"df87a7cf_f8109502","updated":"2017-12-11 01:10:02.000000000","message":"Done","commit_id":"078cf01a70944aeaf7f58f2d9610247f16a83fd8"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a776e91b6c05f820b6d686e60c2b4cb30558eada","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    The configure will be used to add ports for the bridge."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"}],"source_content_type":"text/x-rst","patch_set":17,"id":"df87a7cf_5a25d507","line":85,"range":{"start_line":85,"start_character":49,"end_line":85,"end_character":78},"updated":"2017-12-11 22:44:00.000000000","message":"I\u0027m not sure what does this format mean. What does neutron or nova use this information for?","commit_id":"e0610375971d31ca36747541c0ddd60d25b081e6"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"3d6283da5ff2d5d3c5a9152a5b3122dd5e06d02f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    The configure will be used to add ports for the bridge."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"}],"source_content_type":"text/x-rst","patch_set":17,"id":"df87a7cf_124b7687","line":85,"range":{"start_line":85,"start_character":49,"end_line":85,"end_character":78},"in_reply_to":"df87a7cf_5a25d507","updated":"2017-12-14 01:16:42.000000000","message":"Done","commit_id":"e0610375971d31ca36747541c0ddd60d25b081e6"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"a319c73340cf5378b57618b07494cdbb4ca7936e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    The configure will be used to add ports for the bridge."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"}],"source_content_type":"text/x-rst","patch_set":17,"id":"df87a7cf_928786b7","line":85,"range":{"start_line":85,"start_character":49,"end_line":85,"end_character":78},"in_reply_to":"df87a7cf_5a25d507","updated":"2017-12-14 01:12:32.000000000","message":"To create a neutron bond port, the bond attributes is needed:\nbond-mode:active-backup/balance-tlb etc.\nlacp-mode:active/off/passive\nmember port name:ens1-ens2\nI\u0027ll make it clear, thanks~","commit_id":"e0610375971d31ca36747541c0ddd60d25b081e6"}],"specs/rocky/sriov_bond.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/neutron/+spec/support-sriov-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The ability for OpenStack with a bond nic of Single root I/O"},{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"},{"line_number":16,"context_line":"it needs to add a bond port(its mode can be \"active-backup\" or"},{"line_number":17,"context_line":"\"balance-tcp\" or \"balance-slb\") using SR-IOV NICs."},{"line_number":18,"context_line":"It\u0027s just **one port** logically, but support HA."},{"line_number":19,"context_line":"When create a VM with the bond logic port, we use two SR-IOV"},{"line_number":20,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_a8178ea3","line":20,"range":{"start_line":14,"start_character":0,"end_line":20,"end_character":66},"updated":"2018-03-27 19:58:27.000000000","message":"why limit this to sriov. bounds are equally valid for vswitchs especially for hardware offloaded ovs where the dataplane may leverage sriov or mdevs allocated from phyical nics.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"a962a02ee0fcf073479790a77fe9697b97a9a2d9","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/neutron/+spec/support-sriov-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The ability for OpenStack with a bond nic of Single root I/O"},{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"},{"line_number":16,"context_line":"it needs to add a bond port(its mode can be \"active-backup\" or"},{"line_number":17,"context_line":"\"balance-tcp\" or \"balance-slb\") using SR-IOV NICs."},{"line_number":18,"context_line":"It\u0027s just **one port** logically, but support HA."},{"line_number":19,"context_line":"When create a VM with the bond logic port, we use two SR-IOV"},{"line_number":20,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_f215459d","line":20,"range":{"start_line":14,"start_character":0,"end_line":20,"end_character":66},"in_reply_to":"bf659307_a8178ea3","updated":"2018-03-29 02:16:16.000000000","message":"Hi, sean moony, thank you for your opinion. Ovs supports bonding management, the principle that we implement sriov-bond is making sriov-nics(host nics) bonding by ovs bond or linux bond. If we want to get a ovs VM which has a bond port, we can also bond host nics of dataplane, and then use Port-Status-Linkage module to update the status of tap-port or qvo-port according to the status in OVS bond.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/neutron/+spec/support-sriov-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The ability for OpenStack with a bond nic of Single root I/O"},{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"},{"line_number":16,"context_line":"it needs to add a bond port(its mode can be \"active-backup\" or"},{"line_number":17,"context_line":"\"balance-tcp\" or \"balance-slb\") using SR-IOV NICs."},{"line_number":18,"context_line":"It\u0027s just **one port** logically, but support HA."},{"line_number":19,"context_line":"When create a VM with the bond logic port, we use two SR-IOV"},{"line_number":20,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_e097efea","line":20,"range":{"start_line":14,"start_character":0,"end_line":20,"end_character":66},"in_reply_to":"bf659307_f215459d","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    if we turn off VF spoof checking, data traffic on VF will be overflowing,"},{"line_number":43,"context_line":"    and it affects the performance of packets forwarding."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"2.  How to manage the mode of bond ports? The mode of bond can be \"active-backup\" or"},{"line_number":46,"context_line":"    \"balance-tcp\" or \"balance-slb\". We need a mechanism to maintain the status"},{"line_number":47,"context_line":"    of bond port and its members port."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"3.  IF we get a mechanism to maintain the mode of bond ports(PFs) on compute node, how"},{"line_number":50,"context_line":"    to feed back the status of bond PFs to bond nics in VM."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_88796afd","line":47,"range":{"start_line":45,"start_character":3,"end_line":47,"end_character":38},"updated":"2018-03-27 19:58:27.000000000","message":"this seams like something that the guest should track no neutron.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    if we turn off VF spoof checking, data traffic on VF will be overflowing,"},{"line_number":43,"context_line":"    and it affects the performance of packets forwarding."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"2.  How to manage the mode of bond ports? The mode of bond can be \"active-backup\" or"},{"line_number":46,"context_line":"    \"balance-tcp\" or \"balance-slb\". We need a mechanism to maintain the status"},{"line_number":47,"context_line":"    of bond port and its members port."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"3.  IF we get a mechanism to maintain the mode of bond ports(PFs) on compute node, how"},{"line_number":50,"context_line":"    to feed back the status of bond PFs to bond nics in VM."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_c04bcb84","line":47,"range":{"start_line":45,"start_character":3,"end_line":47,"end_character":38},"in_reply_to":"bf659307_45b30d4e","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"d38a0f4641bb7c638fdc0ab2888fd4cb43127099","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    if we turn off VF spoof checking, data traffic on VF will be overflowing,"},{"line_number":43,"context_line":"    and it affects the performance of packets forwarding."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"2.  How to manage the mode of bond ports? The mode of bond can be \"active-backup\" or"},{"line_number":46,"context_line":"    \"balance-tcp\" or \"balance-slb\". We need a mechanism to maintain the status"},{"line_number":47,"context_line":"    of bond port and its members port."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"3.  IF we get a mechanism to maintain the mode of bond ports(PFs) on compute node, how"},{"line_number":50,"context_line":"    to feed back the status of bond PFs to bond nics in VM."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_45b30d4e","line":47,"range":{"start_line":45,"start_character":3,"end_line":47,"end_character":38},"in_reply_to":"bf659307_88796afd","updated":"2018-03-29 03:12:12.000000000","message":"First, we bond host sriov-nics by ovs bond or linux bond. When VM is booting, it will get two vfs in two different host bonding sriov-nics, but Neutron do not set port bonding in VM. It needs additional operation to finish it, for example, it can be configured by administrator, or configured by metadata. The bond mode in VM should not be 802.3ad, cause that different VMs all use 802.3ad, it will Confuse negotiation through same host sriov-bond-nics. So we only set 802.3ad mode in host sriov-bond-nics if it is needed. Then the bonding status is updated by Port-Status-Linkage module according to the status of  host bonding nics. Port-Status-Linkage will set vf up/down so that guest bond can switch its member ports.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"balance-tcp\" or \"balance-slb\". We need a mechanism to maintain the status"},{"line_number":47,"context_line":"    of bond port and its members port."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"3.  IF we get a mechanism to maintain the mode of bond ports(PFs) on compute node, how"},{"line_number":50,"context_line":"    to feed back the status of bond PFs to bond nics in VM."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"So there should be a solution to use just one neutron port for two or more"},{"line_number":53,"context_line":"VFs on different PFs if we need bond sriov port."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_688656de","line":50,"range":{"start_line":49,"start_character":4,"end_line":50,"end_character":59},"updated":"2018-03-27 19:58:27.000000000","message":"if we delegate the bound status tracking to the guest this mechanisium is not needed.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"balance-tcp\" or \"balance-slb\". We need a mechanism to maintain the status"},{"line_number":47,"context_line":"    of bond port and its members port."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"3.  IF we get a mechanism to maintain the mode of bond ports(PFs) on compute node, how"},{"line_number":50,"context_line":"    to feed back the status of bond PFs to bond nics in VM."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"So there should be a solution to use just one neutron port for two or more"},{"line_number":53,"context_line":"VFs on different PFs if we need bond sriov port."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_405fbb40","line":50,"range":{"start_line":49,"start_character":4,"end_line":50,"end_character":59},"in_reply_to":"bf659307_25c7f966","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"d38a0f4641bb7c638fdc0ab2888fd4cb43127099","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"balance-tcp\" or \"balance-slb\". We need a mechanism to maintain the status"},{"line_number":47,"context_line":"    of bond port and its members port."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"3.  IF we get a mechanism to maintain the mode of bond ports(PFs) on compute node, how"},{"line_number":50,"context_line":"    to feed back the status of bond PFs to bond nics in VM."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"So there should be a solution to use just one neutron port for two or more"},{"line_number":53,"context_line":"VFs on different PFs if we need bond sriov port."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_25c7f966","line":50,"range":{"start_line":49,"start_character":4,"end_line":50,"end_character":59},"in_reply_to":"bf659307_688656de","updated":"2018-03-29 03:12:12.000000000","message":"Real bond is deployed on host sriov-nics, host bond and guest bond complete bond task together, the status of guest bond is up to host bond.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":63,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":64,"context_line":"from two different NICs. In HostOS bond this two NICs together and"},{"line_number":65,"context_line":"deliver the bond mode to the GuestOS through metadata, in GuestOS dpdk"},{"line_number":66,"context_line":"bond the two VFs together."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"::"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_08047a49","line":66,"range":{"start_line":64,"start_character":25,"end_line":66,"end_character":26},"updated":"2018-03-27 19:58:27.000000000","message":"how can you bond in both the guest and the host.\n\nto do an sriov passthough you will need to bind the VF in the host to vfio-pci. vfio-pci does not expose a netdev to the linux kernel so VF bound to vfio-pci cannot be bonded using the linux bond driver.\n\nthe use of dpdk in the guest is not relevant here. the bound should be able to work with the kernel bound driver in the guest not jsut dpdk. for example if you vnf uses ebpf or some other kernel technology you may not want to use dpdk in the guest but still want bonding.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":63,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":64,"context_line":"from two different NICs. In HostOS bond this two NICs together and"},{"line_number":65,"context_line":"deliver the bond mode to the GuestOS through metadata, in GuestOS dpdk"},{"line_number":66,"context_line":"bond the two VFs together."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"::"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_a016d754","line":66,"range":{"start_line":64,"start_character":25,"end_line":66,"end_character":26},"in_reply_to":"bf659307_08047a49","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Proposed change"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":"1.  Neutron adds configure option in the sriov_agent.ini on the bond compute node."},{"line_number":106,"context_line":"    The configure will be used to add member nics to bond manage mechanism, such"},{"line_number":107,"context_line":"    as OVS(Openvswitch) Bond or Linux Bond."},{"line_number":108,"context_line":"    For example::"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        physical_device_mappings \u003d physnet1:bond1(mode of bond;"},{"line_number":111,"context_line":"                                                  mode of lacp;"},{"line_number":112,"context_line":"                                                  list of member nics)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":115,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"},{"line_number":116,"context_line":"    mac address."},{"line_number":117,"context_line":"    The configure will be used to set the same mac address for the two member ports."},{"line_number":118,"context_line":"    For example::"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        physical_device_mappings \u003d physnet1:bond1(mode of bond;"},{"line_number":121,"context_line":"                                                  mode of lacp;"},{"line_number":122,"context_line":"                                                  list of member ports)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"3.  For Neutron, There is no difference between bond ports and Non-bond ports,"},{"line_number":125,"context_line":"    it will generate two member ports(VFs) when booting the VM."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_4dd124cd","line":122,"range":{"start_line":105,"start_character":3,"end_line":122,"end_character":71},"updated":"2018-03-27 19:58:27.000000000","message":"anything that requires nova/neutron config options to specify the bond mode statically is very inflexible. we should really model bond modes as atribute on the neutron port.\n\nyou might want to have a neuton config option to model things like pf to tor releationships.\n\nwe should not need to modify nova to model the device mapping idealy beyond perhaps consuming trait/resouce request in the neutron port for selecting RP of PFs or VFs in the placement api.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Proposed change"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":"1.  Neutron adds configure option in the sriov_agent.ini on the bond compute node."},{"line_number":106,"context_line":"    The configure will be used to add member nics to bond manage mechanism, such"},{"line_number":107,"context_line":"    as OVS(Openvswitch) Bond or Linux Bond."},{"line_number":108,"context_line":"    For example::"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        physical_device_mappings \u003d physnet1:bond1(mode of bond;"},{"line_number":111,"context_line":"                                                  mode of lacp;"},{"line_number":112,"context_line":"                                                  list of member nics)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":115,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"},{"line_number":116,"context_line":"    mac address."},{"line_number":117,"context_line":"    The configure will be used to set the same mac address for the two member ports."},{"line_number":118,"context_line":"    For example::"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        physical_device_mappings \u003d physnet1:bond1(mode of bond;"},{"line_number":121,"context_line":"                                                  mode of lacp;"},{"line_number":122,"context_line":"                                                  list of member ports)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"3.  For Neutron, There is no difference between bond ports and Non-bond ports,"},{"line_number":125,"context_line":"    it will generate two member ports(VFs) when booting the VM."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_400d7b3c","line":122,"range":{"start_line":105,"start_character":3,"end_line":122,"end_character":71},"in_reply_to":"bf659307_2071670d","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"b83115686bc6a63156203f0b9bd43cef61b5db1e","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Proposed change"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":"1.  Neutron adds configure option in the sriov_agent.ini on the bond compute node."},{"line_number":106,"context_line":"    The configure will be used to add member nics to bond manage mechanism, such"},{"line_number":107,"context_line":"    as OVS(Openvswitch) Bond or Linux Bond."},{"line_number":108,"context_line":"    For example::"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        physical_device_mappings \u003d physnet1:bond1(mode of bond;"},{"line_number":111,"context_line":"                                                  mode of lacp;"},{"line_number":112,"context_line":"                                                  list of member nics)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":115,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"},{"line_number":116,"context_line":"    mac address."},{"line_number":117,"context_line":"    The configure will be used to set the same mac address for the two member ports."},{"line_number":118,"context_line":"    For example::"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        physical_device_mappings \u003d physnet1:bond1(mode of bond;"},{"line_number":121,"context_line":"                                                  mode of lacp;"},{"line_number":122,"context_line":"                                                  list of member ports)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"3.  For Neutron, There is no difference between bond ports and Non-bond ports,"},{"line_number":125,"context_line":"    it will generate two member ports(VFs) when booting the VM."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_2071670d","line":122,"range":{"start_line":105,"start_character":3,"end_line":122,"end_character":71},"in_reply_to":"bf659307_4dd124cd","updated":"2018-04-09 08:18:26.000000000","message":"I think it need to configure bonding info through neutron port-create command as your proposal.But how to resolve the confusion if VMs all use 802.3ad mode bonding or some VMs use 802.3ad mode and others use active-backup mode. So we define just one mode in agent.ini for host bonding nic, all VMs use this bonding mode. So if we don\u0027t define bonding option in nova.conf, nova is unable to get bonding port information from Neutron.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"d38a0f4641bb7c638fdc0ab2888fd4cb43127099","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Proposed change"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":"1.  Neutron adds configure option in the sriov_agent.ini on the bond compute node."},{"line_number":106,"context_line":"    The configure will be used to add member nics to bond manage mechanism, such"},{"line_number":107,"context_line":"    as OVS(Openvswitch) Bond or Linux Bond."},{"line_number":108,"context_line":"    For example::"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        physical_device_mappings \u003d physnet1:bond1(mode of bond;"},{"line_number":111,"context_line":"                                                  mode of lacp;"},{"line_number":112,"context_line":"                                                  list of member nics)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":115,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"},{"line_number":116,"context_line":"    mac address."},{"line_number":117,"context_line":"    The configure will be used to set the same mac address for the two member ports."},{"line_number":118,"context_line":"    For example::"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        physical_device_mappings \u003d physnet1:bond1(mode of bond;"},{"line_number":121,"context_line":"                                                  mode of lacp;"},{"line_number":122,"context_line":"                                                  list of member ports)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"3.  For Neutron, There is no difference between bond ports and Non-bond ports,"},{"line_number":125,"context_line":"    it will generate two member ports(VFs) when booting the VM."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_a581c9fd","line":122,"range":{"start_line":105,"start_character":3,"end_line":122,"end_character":71},"in_reply_to":"bf659307_4dd124cd","updated":"2018-03-29 03:12:12.000000000","message":"You are right, we are thinking about removing nova config option.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    it will generate two member ports(VFs) when booting the VM."},{"line_number":126,"context_line":"    So create bond port with neutron API::"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"4.  Create SR-IOV VM with nova API::"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_edf8384a","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":75},"updated":"2018-03-27 19:58:27.000000000","message":"we should be specifing the bond mode here.\n\nwe may be able to use granular resouce request on the port object to model the affintiy/anti afinity of the port so that placement can prefilter to only host that have enough nics to ensure all bond pairs dont come form the same nic/tor.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    it will generate two member ports(VFs) when booting the VM."},{"line_number":126,"context_line":"    So create bond port with neutron API::"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"4.  Create SR-IOV VM with nova API::"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_40249bc6","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":75},"in_reply_to":"bf659307_654091a6","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"d38a0f4641bb7c638fdc0ab2888fd4cb43127099","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    it will generate two member ports(VFs) when booting the VM."},{"line_number":126,"context_line":"    So create bond port with neutron API::"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"4.  Create SR-IOV VM with nova API::"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_654091a6","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":75},"in_reply_to":"bf659307_edf8384a","updated":"2018-03-29 03:12:12.000000000","message":"Since we set real bonding on host sriov-nics, I\u0027m worried about that different bond mode configured by different neutron ports in the same physical network, will it Confuse the bonding configuration on  host sriov-nics. For example, port1 of VM1 needs 802.3ad mode, port2 of VM2 needs backup mode, they are in the same physical network, what should I do for host nics bonding, it only use one mode.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":135,"context_line":"    one or more VFs to VM according to the port bonding informations."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"6.  Add LINUX bond of VFs in VM. It can be configured by Administrator, or"},{"line_number":138,"context_line":"    from Metadata. It is noteworthy that the bond mode should not be 802.3ad or"},{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_ed8d98d3","line":137,"range":{"start_line":137,"start_character":33,"end_line":137,"end_character":70},"updated":"2018-03-27 19:58:27.000000000","message":"how by injecting somthing into cloud init?","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":134,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":135,"context_line":"    one or more VFs to VM according to the port bonding informations."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"6.  Add LINUX bond of VFs in VM. It can be configured by Administrator, or"},{"line_number":138,"context_line":"    from Metadata. It is noteworthy that the bond mode should not be 802.3ad or"},{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_c030ab0a","line":137,"range":{"start_line":137,"start_character":33,"end_line":137,"end_character":70},"in_reply_to":"bf659307_85260515","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"d38a0f4641bb7c638fdc0ab2888fd4cb43127099","unresolved":false,"context_lines":[{"line_number":134,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":135,"context_line":"    one or more VFs to VM according to the port bonding informations."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"6.  Add LINUX bond of VFs in VM. It can be configured by Administrator, or"},{"line_number":138,"context_line":"    from Metadata. It is noteworthy that the bond mode should not be 802.3ad or"},{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_85260515","line":137,"range":{"start_line":137,"start_character":33,"end_line":137,"end_character":70},"in_reply_to":"bf659307_ed8d98d3","updated":"2018-03-29 03:12:12.000000000","message":"I think conifg bonding information in metadata, when VM booting ,it can get bonding information from metadata, then set its bonding. Or it can be configured by administrator.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    one or more VFs to VM according to the port bonding informations."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"6.  Add LINUX bond of VFs in VM. It can be configured by Administrator, or"},{"line_number":138,"context_line":"    from Metadata. It is noteworthy that the bond mode should not be 802.3ad or"},{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"7.  Neutron distribute the bond informations to Bond-Manage-Mechanism, Such"},{"line_number":142,"context_line":"    as OVS Bond or Linux Bond. Then OVS Bond or Linux Bond can maintain the"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_adc1e0e6","line":139,"range":{"start_line":138,"start_character":19,"end_line":139,"end_character":58},"updated":"2018-03-27 19:58:27.000000000","message":"why not? should this not be up to the tenant to decide?","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"d38a0f4641bb7c638fdc0ab2888fd4cb43127099","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    one or more VFs to VM according to the port bonding informations."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"6.  Add LINUX bond of VFs in VM. It can be configured by Administrator, or"},{"line_number":138,"context_line":"    from Metadata. It is noteworthy that the bond mode should not be 802.3ad or"},{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"7.  Neutron distribute the bond informations to Bond-Manage-Mechanism, Such"},{"line_number":142,"context_line":"    as OVS Bond or Linux Bond. Then OVS Bond or Linux Bond can maintain the"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_e5634141","line":139,"range":{"start_line":138,"start_character":19,"end_line":139,"end_character":58},"in_reply_to":"bf659307_adc1e0e6","updated":"2018-03-29 03:12:12.000000000","message":"Here is a correction, the guest bond mode should not be 802.3ad. Real bonding is deployed on host sriov-nics.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    one or more VFs to VM according to the port bonding informations."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"6.  Add LINUX bond of VFs in VM. It can be configured by Administrator, or"},{"line_number":138,"context_line":"    from Metadata. It is noteworthy that the bond mode should not be 802.3ad or"},{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"7.  Neutron distribute the bond informations to Bond-Manage-Mechanism, Such"},{"line_number":142,"context_line":"    as OVS Bond or Linux Bond. Then OVS Bond or Linux Bond can maintain the"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_a03d77de","line":139,"range":{"start_line":138,"start_character":19,"end_line":139,"end_character":58},"in_reply_to":"bf659307_e5634141","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"7.  Neutron distribute the bond informations to Bond-Manage-Mechanism, Such"},{"line_number":142,"context_line":"    as OVS Bond or Linux Bond. Then OVS Bond or Linux Bond can maintain the"},{"line_number":143,"context_line":"    status of Bond nics."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"8.  There is new Module named Port-Status-Linkage, it check the status of"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_eda6f853","line":142,"range":{"start_line":142,"start_character":7,"end_line":142,"end_character":29},"updated":"2018-03-27 19:58:27.000000000","message":"ovs bond ports cannont be pass into a guest they can only be used for bonding phyical nics on the host level that are used by ovs so i dont see how this is relevent?","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"7.  Neutron distribute the bond informations to Bond-Manage-Mechanism, Such"},{"line_number":142,"context_line":"    as OVS Bond or Linux Bond. Then OVS Bond or Linux Bond can maintain the"},{"line_number":143,"context_line":"    status of Bond nics."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"8.  There is new Module named Port-Status-Linkage, it check the status of"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_e0336f12","line":142,"range":{"start_line":142,"start_character":7,"end_line":142,"end_character":29},"in_reply_to":"bf659307_454a2dac","updated":"2018-04-09 08:44:50.000000000","message":"Done","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"d38a0f4641bb7c638fdc0ab2888fd4cb43127099","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    active-backup, but static-balance mode is recommended."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"7.  Neutron distribute the bond informations to Bond-Manage-Mechanism, Such"},{"line_number":142,"context_line":"    as OVS Bond or Linux Bond. Then OVS Bond or Linux Bond can maintain the"},{"line_number":143,"context_line":"    status of Bond nics."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"8.  There is new Module named Port-Status-Linkage, it check the status of"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_454a2dac","line":142,"range":{"start_line":142,"start_character":7,"end_line":142,"end_character":29},"in_reply_to":"bf659307_eda6f853","updated":"2018-03-29 03:12:12.000000000","message":"You can see the description above.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Alternatives"},{"line_number":151,"context_line":"------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":154,"context_line":"    just one port in software level."},{"line_number":155,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":156,"context_line":"    this need in hardware level, but it depends on the physical NIC card"},{"line_number":157,"context_line":"    itself. And when we need more than two physical NICs to be bond, that"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_88ff2a00","line":154,"range":{"start_line":153,"start_character":4,"end_line":154,"end_character":36},"updated":"2018-03-27 19:58:27.000000000","message":"well that is only true for vnic_type direct.\n\nfor vnic_type macvtap then you could create a bond on that host between the 2 VFs and then create a macvtap from the bound that is passed through to the vm.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Alternatives"},{"line_number":151,"context_line":"------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":154,"context_line":"    just one port in software level."},{"line_number":155,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":156,"context_line":"    this need in hardware level, but it depends on the physical NIC card"},{"line_number":157,"context_line":"    itself. And when we need more than two physical NICs to be bond, that"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_7b92b0a1","line":154,"range":{"start_line":153,"start_character":4,"end_line":154,"end_character":36},"in_reply_to":"bf659307_88ff2a00","updated":"2018-04-09 08:44:50.000000000","message":"Bonding manage is implemented on host nics, the status of bonding in VMs depends on host bonding nics, through periodic refresh task of Port-Status-Linkage module.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c1f286158b8904cab40de0c30b6b0c03fda99f3","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    this need in hardware level, but it depends on the physical NIC card"},{"line_number":157,"context_line":"    itself. And when we need more than two physical NICs to be bond, that"},{"line_number":158,"context_line":"    won\u0027t work."},{"line_number":159,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."},{"line_number":160,"context_line":"    when you want to change a non-bond virtual machine to a bond one."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    if you use neutron port property options,maybe you should:"},{"line_number":163,"context_line":"    [1] delete or detach port"},{"line_number":164,"context_line":"    [2] Upgrade port properties information"},{"line_number":165,"context_line":"    [3] add or attach port"},{"line_number":166,"context_line":"    Changing the port properties may affect the business of virtual machine."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if you use the agent config options, maybe you can:"},{"line_number":169,"context_line":"    [1] Migration the virtual machine to other node"},{"line_number":170,"context_line":"    [2] Upgrade the SR-IOV configuration for this node"},{"line_number":171,"context_line":"    [3] Migration the virtual machine back"},{"line_number":172,"context_line":"    and these operations do not affect the normal business."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_28f5be83","line":172,"range":{"start_line":159,"start_character":3,"end_line":172,"end_character":59},"updated":"2018-03-27 19:58:27.000000000","message":"i would disagree.\nusing a config option means that a tenant cannot configure a bound port themeslves and this becomes an admin only operation requiring config update and therefore agent restarts to facilitate any change to the bound.\n\nas the bond configuration is know only on the compute node\nthe schduler/placement api would not be able to accout for bond topologyes as part of livemigrations. as such the ha guratee might change as part of a livemigration.\n\nsince nova has no awareness of the bound on a host at the plamcenent level there is also no path to guarenttee that you land on a host with bonding confiugred intially. you would be forced to use host aggreage + a nova availableity zone to select host with bonding if that is what you needed.\n\nsriov can be used with vxlan by using a hieracical port binding driver to terminate the vtep at the tor.\n\nsince the spec refers to physical_device_mappings \u003d physnet1:bond1\nthat percludes bound for routed network or tunneled networks as we do not have a physnet in those cases as they are not provider networks.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"},{"author":{"_account_id":20787,"name":"Bin Lu","email":"369283883@qq.com","username":"LuBin"},"change_message_id":"8ac4d76a88af096a89a0b7e5be99c3e3d23ddceb","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    this need in hardware level, but it depends on the physical NIC card"},{"line_number":157,"context_line":"    itself. And when we need more than two physical NICs to be bond, that"},{"line_number":158,"context_line":"    won\u0027t work."},{"line_number":159,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."},{"line_number":160,"context_line":"    when you want to change a non-bond virtual machine to a bond one."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    if you use neutron port property options,maybe you should:"},{"line_number":163,"context_line":"    [1] delete or detach port"},{"line_number":164,"context_line":"    [2] Upgrade port properties information"},{"line_number":165,"context_line":"    [3] add or attach port"},{"line_number":166,"context_line":"    Changing the port properties may affect the business of virtual machine."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if you use the agent config options, maybe you can:"},{"line_number":169,"context_line":"    [1] Migration the virtual machine to other node"},{"line_number":170,"context_line":"    [2] Upgrade the SR-IOV configuration for this node"},{"line_number":171,"context_line":"    [3] Migration the virtual machine back"},{"line_number":172,"context_line":"    and these operations do not affect the normal business."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bf659307_7bcab06e","line":172,"range":{"start_line":159,"start_character":3,"end_line":172,"end_character":59},"in_reply_to":"bf659307_28f5be83","updated":"2018-04-09 08:44:50.000000000","message":"But if we define bonding option throught port-create configuration command, all VMs under same physnet using different bonding mode or all using 802.3ad mode will confuse\nnegotiation or bonding status through same host SR-IOV bonding nics. So real bonding manage is suggested to be implemented on host bonding nics.","commit_id":"c87e14679d0de3d60aa28bd7e9cf047902d1c38b"}]}