)]}'
{"specs/train/l3-ips-metering.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b98e61949a5d0450e0ac016153321a31cdca1fc4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agent increase"},{"line_number":28,"context_line":"the centralized message queue pressure."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_5ef0eec9","line":28,"updated":"2019-07-29 11:35:21.000000000","message":"should we than think about deprecate and later remove of this agent? Do You have any informations about usage of this agent by other deployments?\n\nOr maybe we should optimize this metering agend to make it \"less heavy\"? :)","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af75e097fec1cb0a2059147ed3ba768d1934c6bb","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agent increase"},{"line_number":28,"context_line":"the centralized message queue pressure."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_6668bc86","line":28,"in_reply_to":"7faddb67_5ef0eec9","updated":"2019-07-29 14:49:50.000000000","message":"I have not heard much experiences of current neutron metering plugin and metering agent. But I encountered a variety of public IP monitoring and metering requirements for cloud deployment. And indeed current neutron metering plugin and metering agent are not widely used ever.\nThis proposal here will be something like we have done in neutron: iptables security group had been replaced with openflow based implementation by default. And yes, iptables based metering can be abandoned someday as well.","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b98e61949a5d0450e0ac016153321a31cdca1fc4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For this proposal here, a new L3 agent extension will be added to achieve the"},{"line_number":35,"context_line":"L3 IP metering."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Solution Proposed"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_beca426b","line":35,"updated":"2019-07-29 11:35:21.000000000","message":"so after Your proposal we will have 2 different solutions to achieve the same goal (metering). TBH personally I don\u0027t think it\u0027s good idea in longer perspective.","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af75e097fec1cb0a2059147ed3ba768d1934c6bb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For this proposal here, a new L3 agent extension will be added to achieve the"},{"line_number":35,"context_line":"L3 IP metering."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Solution Proposed"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_667bdcbd","line":35,"in_reply_to":"7faddb67_beca426b","updated":"2019-07-29 14:49:50.000000000","message":"Things are always changing and improving. This can be an alternative, neutron always have alternatives, something like ovs and linux_bridge mechanism drivers. Maybe as you said, we can start deprecating the original approach.","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b98e61949a5d0450e0ac016153321a31cdca1fc4","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* Both router and floating IPs will have a defult QoS policy binding mechanism"},{"line_number":45,"context_line":"  which means neutron server will set a default QoS policy ID for router gateway"},{"line_number":46,"context_line":"  IPs and floating IPs."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"L3 agent side changes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_1ea116aa","line":46,"updated":"2019-07-29 11:35:21.000000000","message":"why we need default QoS to be associated with each FIP and router?\nI know that technically You want to use tc filters\u0027 stats to get metering statistics but from logic and user perspective those are completly different things and IMO we shouldn\u0027t mix those 2 things in this spec at all.","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af75e097fec1cb0a2059147ed3ba768d1934c6bb","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* Both router and floating IPs will have a defult QoS policy binding mechanism"},{"line_number":45,"context_line":"  which means neutron server will set a default QoS policy ID for router gateway"},{"line_number":46,"context_line":"  IPs and floating IPs."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"L3 agent side changes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_a68f942c","line":46,"in_reply_to":"7faddb67_1ea116aa","updated":"2019-07-29 14:49:50.000000000","message":"Not router, it is gateway IP QoS.\nhttps://review.opendev.org/#/q/status:merged+project:openstack/neutron+branch:master+topic:bug/1757044","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b98e61949a5d0450e0ac016153321a31cdca1fc4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"the following tasks:"},{"line_number":68,"context_line":"1. retrieve the data from the TC rules periodically"},{"line_number":69,"context_line":"2. store the data to local store file"},{"line_number":70,"context_line":"3. report the data to ceilometer/metering service via RPC notification or UDP"},{"line_number":71,"context_line":"4. (optional) Some other service like zabbix read the local store data or report to it."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_9e942646","line":70,"updated":"2019-07-29 11:35:21.000000000","message":"will L3 agent report it directly to the ceilometer or to neutron-server and server will send it to other services?","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af75e097fec1cb0a2059147ed3ba768d1934c6bb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"the following tasks:"},{"line_number":68,"context_line":"1. retrieve the data from the TC rules periodically"},{"line_number":69,"context_line":"2. store the data to local store file"},{"line_number":70,"context_line":"3. report the data to ceilometer/metering service via RPC notification or UDP"},{"line_number":71,"context_line":"4. (optional) Some other service like zabbix read the local store data or report to it."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_a69d5458","line":70,"in_reply_to":"7faddb67_9e942646","updated":"2019-07-29 14:49:50.000000000","message":"Directly by L3 agent, data will be send by notification to message queue, or send data by UDP to other service port. This will be configurable.","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b98e61949a5d0450e0ac016153321a31cdca1fc4","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  [DEFAULT]"},{"line_number":93,"context_line":"  floating_ip_default_qos_policy \u003d \u003ca-policy-uuid\u003e"},{"line_number":94,"context_line":"  router_gateway_ip_default_qos_policy \u003d  \u003ca-policy-uuid\u003e"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The neutron basic workflow"},{"line_number":97,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_7e992a77","line":94,"updated":"2019-07-29 11:35:21.000000000","message":"as I said before, metering has nothing to the QoS so no qos policy should be mentioned in this spec IMO","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af75e097fec1cb0a2059147ed3ba768d1934c6bb","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  [DEFAULT]"},{"line_number":93,"context_line":"  floating_ip_default_qos_policy \u003d \u003ca-policy-uuid\u003e"},{"line_number":94,"context_line":"  router_gateway_ip_default_qos_policy \u003d  \u003ca-policy-uuid\u003e"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The neutron basic workflow"},{"line_number":97,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_0614689f","line":94,"in_reply_to":"7faddb67_7e992a77","updated":"2019-07-29 14:49:50.000000000","message":"Yes, agree. But once in drivers meeting I got some advice that we could add a default policy to these IPs. And I think it is achievable.\nMy original thoughts is to only enable those IPs\u0027 metering which have binding QoS policy.","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b98e61949a5d0450e0ac016153321a31cdca1fc4","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API Impact"},{"line_number":111,"context_line":"---------------"},{"line_number":112,"context_line":"None"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_5e778e3b","line":112,"updated":"2019-07-29 11:35:21.000000000","message":"will it be possible to get those meterings with neutron API? or it will only be reported to some other services?","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af75e097fec1cb0a2059147ed3ba768d1934c6bb","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API Impact"},{"line_number":111,"context_line":"---------------"},{"line_number":112,"context_line":"None"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_26096494","line":112,"in_reply_to":"7faddb67_5e778e3b","updated":"2019-07-29 14:49:50.000000000","message":"L3-agent (neutron) reports data only, retrieve data will be another project.","commit_id":"fb513c288ff84b8718aeab85a316d575de8b67be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0c1dd08d60675477aa9b9351907baf16db89c8f2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RFE: https://bugs.launchpad.net/neutron/+bug/1817881"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For now, L3 IPs are all have bandwidth QoS functionality [1]_ [2]_ [3]_ ."},{"line_number":14,"context_line":"Floating IPs and gateway IPs have the same TC rules. And for one specific"},{"line_number":15,"context_line":"IP, it can not be set in two hosts for current neutron architecture. That"},{"line_number":16,"context_line":"is saying, where the IP is working, we can retrieve the traffic statistic"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_7dcd692e","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":24},"updated":"2019-08-01 22:09:37.000000000","message":"Currently, all L3 IPs ....","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"63a7feb0d5c399a4a20c75857eec3e16b11b0010","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RFE: https://bugs.launchpad.net/neutron/+bug/1817881"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For now, L3 IPs are all have bandwidth QoS functionality [1]_ [2]_ [3]_ ."},{"line_number":14,"context_line":"Floating IPs and gateway IPs have the same TC rules. And for one specific"},{"line_number":15,"context_line":"IP, it can not be set in two hosts for current neutron architecture. That"},{"line_number":16,"context_line":"is saying, where the IP is working, we can retrieve the traffic statistic"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_83cd5fb8","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":24},"in_reply_to":"7faddb67_7dcd692e","updated":"2019-08-02 07:33:47.000000000","message":"Done","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0c1dd08d60675477aa9b9351907baf16db89c8f2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For now, L3 IPs are all have bandwidth QoS functionality [1]_ [2]_ [3]_ ."},{"line_number":14,"context_line":"Floating IPs and gateway IPs have the same TC rules. And for one specific"},{"line_number":15,"context_line":"IP, it can not be set in two hosts for current neutron architecture. That"},{"line_number":16,"context_line":"is saying, where the IP is working, we can retrieve the traffic statistic"},{"line_number":17,"context_line":"data for it."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_5d018d37","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":54},"updated":"2019-08-01 22:09:37.000000000","message":"in two different hosts under current Neutron","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"63a7feb0d5c399a4a20c75857eec3e16b11b0010","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For now, L3 IPs are all have bandwidth QoS functionality [1]_ [2]_ [3]_ ."},{"line_number":14,"context_line":"Floating IPs and gateway IPs have the same TC rules. And for one specific"},{"line_number":15,"context_line":"IP, it can not be set in two hosts for current neutron architecture. That"},{"line_number":16,"context_line":"is saying, where the IP is working, we can retrieve the traffic statistic"},{"line_number":17,"context_line":"data for it."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_03b96f13","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":54},"in_reply_to":"7faddb67_5d018d37","updated":"2019-08-02 07:33:47.000000000","message":"Done","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0c1dd08d60675477aa9b9351907baf16db89c8f2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For now, L3 IPs are all have bandwidth QoS functionality [1]_ [2]_ [3]_ ."},{"line_number":14,"context_line":"Floating IPs and gateway IPs have the same TC rules. And for one specific"},{"line_number":15,"context_line":"IP, it can not be set in two hosts for current neutron architecture. That"},{"line_number":16,"context_line":"is saying, where the IP is working, we can retrieve the traffic statistic"},{"line_number":17,"context_line":"data for it."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This spec describes how to add a built-in L3 extension to collect and report"},{"line_number":20,"context_line":"L3 IPs traffic usage."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_dd9a5d12","line":17,"range":{"start_line":15,"start_character":69,"end_line":17,"end_character":12},"updated":"2019-08-01 22:09:37.000000000","message":"This implies that we can collect the IP traffic statistics in one location in the deployment.","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"63a7feb0d5c399a4a20c75857eec3e16b11b0010","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For now, L3 IPs are all have bandwidth QoS functionality [1]_ [2]_ [3]_ ."},{"line_number":14,"context_line":"Floating IPs and gateway IPs have the same TC rules. And for one specific"},{"line_number":15,"context_line":"IP, it can not be set in two hosts for current neutron architecture. That"},{"line_number":16,"context_line":"is saying, where the IP is working, we can retrieve the traffic statistic"},{"line_number":17,"context_line":"data for it."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This spec describes how to add a built-in L3 extension to collect and report"},{"line_number":20,"context_line":"L3 IPs traffic usage."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_a3373bb0","line":17,"range":{"start_line":15,"start_character":69,"end_line":17,"end_character":12},"in_reply_to":"7faddb67_dd9a5d12","updated":"2019-08-02 07:33:47.000000000","message":"Done","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0c1dd08d60675477aa9b9351907baf16db89c8f2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agent increase"},{"line_number":28,"context_line":"the centralized message queue pressure."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_3d8931c9","line":27,"range":{"start_line":27,"start_character":61,"end_line":27,"end_character":66},"updated":"2019-08-01 22:09:37.000000000","message":"agents","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"63a7feb0d5c399a4a20c75857eec3e16b11b0010","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agent increase"},{"line_number":28,"context_line":"the centralized message queue pressure."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_633dc38c","line":27,"range":{"start_line":27,"start_character":61,"end_line":27,"end_character":66},"in_reply_to":"7faddb67_3d8931c9","updated":"2019-08-02 07:33:47.000000000","message":"Done","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0c1dd08d60675477aa9b9351907baf16db89c8f2","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agent increase"},{"line_number":28,"context_line":"the centralized message queue pressure."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_5d866dbb","line":28,"range":{"start_line":28,"start_character":30,"end_line":28,"end_character":38},"updated":"2019-08-01 22:09:37.000000000","message":"load","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"63a7feb0d5c399a4a20c75857eec3e16b11b0010","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agent increase"},{"line_number":28,"context_line":"the centralized message queue pressure."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_234b4b2b","line":28,"range":{"start_line":28,"start_character":30,"end_line":28,"end_character":38},"in_reply_to":"7faddb67_5d866dbb","updated":"2019-08-02 07:33:47.000000000","message":"Done","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0c1dd08d60675477aa9b9351907baf16db89c8f2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed Change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For this proposal here, a new L3 agent extension will be added to achieve the"},{"line_number":35,"context_line":"L3 IP metering."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_bdbe8162","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":22},"updated":"2019-08-01 22:09:37.000000000","message":"remove","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"63a7feb0d5c399a4a20c75857eec3e16b11b0010","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed Change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For this proposal here, a new L3 agent extension will be added to achieve the"},{"line_number":35,"context_line":"L3 IP metering."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_4348c72b","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":22},"in_reply_to":"7faddb67_bdbe8162","updated":"2019-08-02 07:33:47.000000000","message":"Done","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0c1dd08d60675477aa9b9351907baf16db89c8f2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Server side changes"},{"line_number":42,"context_line":"+++++++++++++++++++"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":47,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":48,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"L3 agent side changes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_1d7a35b9","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":42},"updated":"2019-08-01 22:09:37.000000000","message":"Why make QoS a precondition for this extension? IThis new extension can be configurable on its own, can\u0027t it?","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f9510b0910a4fc08899fe3ed89e2860ac6755beb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Server side changes"},{"line_number":42,"context_line":"+++++++++++++++++++"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":47,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":48,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"L3 agent side changes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_f21d03be","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":42},"in_reply_to":"7faddb67_1d7a35b9","updated":"2019-08-02 05:48:14.000000000","message":"The tc filters are added by floating IP or gateway IP QoS agent extension. We should not implement totally same qos-binding and agent-TC-intalling mechanism. Because we already have.","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"71e7280bfdc2342c8103df49c408be3c19fe3ce3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Server side changes"},{"line_number":42,"context_line":"+++++++++++++++++++"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":47,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":48,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"L3 agent side changes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_9e8ff821","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":42},"in_reply_to":"7faddb67_f21d03be","updated":"2019-08-02 07:52:30.000000000","message":"But those are 2 different points. Internally You can (and IMO should) reuse as much code as it is possible but You can\u0027t require from user or cloud operator the to have metering functionality enabled for FIP, QoS policy has to be assigned to this FIP.\nSo from user/API point of view those are completly separate features, even if they use same tools underneath to achieve goal.","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b98e61949a5d0450e0ac016153321a31cdca1fc4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"The neutron basic workflow"},{"line_number":106,"context_line":"--------------------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Users need to ensure the L3 IPs have the binding QoS policy and enable the"},{"line_number":109,"context_line":"metering extension with proper reporting settings. No more extra works need"},{"line_number":110,"context_line":"to do, then it can achive a native L3 IPs metering functionality."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"If the default QoS policy is configured, then we can say all L3 IPs will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_bec6c248","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":50},"updated":"2019-07-29 11:35:21.000000000","message":"that is IMO totally agains any good user experience practices and we shouldn\u0027t do it this way.","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af75e097fec1cb0a2059147ed3ba768d1934c6bb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"The neutron basic workflow"},{"line_number":106,"context_line":"--------------------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Users need to ensure the L3 IPs have the binding QoS policy and enable the"},{"line_number":109,"context_line":"metering extension with proper reporting settings. No more extra works need"},{"line_number":110,"context_line":"to do, then it can achive a native L3 IPs metering functionality."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"If the default QoS policy is configured, then we can say all L3 IPs will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_a6d7944f","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":50},"in_reply_to":"7faddb67_bec6c248","updated":"2019-07-29 14:49:50.000000000","message":"Maybe I should move the next sentence forward:\n\"\"\"\nTo achive native L3 IPs metering functionality, they just need to ensure the L3 IPs have the binding QoS policy (with bandwidth rules) and enable the L3 agent metering extension with proper reporting settings, no more extra works.\n\"\"\"","commit_id":"64cd34fd726a90907de456eff2d561554ded11e5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ff71d894443be06f359b83b151d505ea46b3e627","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   police 0x2 rate 1024Kbit burst 128Kb mtu 64Kb action drop overhead 0b linklayer ethernet"},{"line_number":64,"context_line":"   ref 1 bind 1 installed 86737 sec used 439 sec"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   Sent 17640 bytes 180 pkts (dropped 0, overlimits 0)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The last line is the statistical data for this proposal. Then l3-agent will complete"},{"line_number":69,"context_line":"the following tasks:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7faddb67_2c1a496e","line":66,"range":{"start_line":66,"start_character":3,"end_line":66,"end_character":54},"updated":"2019-08-04 04:25:48.000000000","message":"If no policing for TC filter rules, no statistic data. The following is my test.\n\n(1) add filter without police\n$ sudo ip netns exec snat-1abc2c44-e385-41cd-b554-c811d2fe2547 tc filter add dev qg-a2c257de-29 parent ffff: protocol ip prio 1 u32 match ip src 172.16.111.53 flowid :1\n\n\n(2) no statistic data for IP 172.16.111.53\n$ sudo ip netns exec snat-1abc2c44-e385-41cd-b554-c811d2fe2547 tc -s -d -p filter show dev qg-a2c257de-29 parent ffff:\nfilter protocol ip pref 1 u32 \nfilter protocol ip pref 1 u32 fh 800: ht divisor 1 \nfilter protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 not_in_hw  (rule hit 0 success 0)\n  match IP dst 172.16.13.52/32 (success 0 ) \n police 0x1 rate 1Mbit burst 125Kb mtu 64Kb action drop overhead 0b linklayer ethernet \n\tref 1 bind 1 installed 4382 sec used 4382 sec\n\n Sent 0 bytes 0 pkts (dropped 0, overlimits 0) \nfilter protocol ip pref 1 u32 fh 800::801 order 2049 key ht 800 bkt 0 flowid :1 not_in_hw  (rule hit 0 success 0)\n  match IP src 172.16.111.53/32 (success 0 )","commit_id":"b8941024fe3a5d1b335462c7d360cadaadc227fb"}],"specs/victoria/l3-ips-metering.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d129185a_d212eb55","updated":"2020-11-23 11:15:53.000000000","message":"Please move it to the Wallaby now","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"10a786f83f2b6aad91d00670011843e68bad9b5a","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Problem Description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agents increase"},{"line_number":28,"context_line":"the centralized message queue load, such as you run metering agent in every"},{"line_number":29,"context_line":"compute nodes. And there is a known issue that dvr could not work with metering"},{"line_number":30,"context_line":"agent [4]_."}],"source_content_type":"text/x-rst","patch_set":10,"id":"38adc3a4_a74eeab0","line":27,"range":{"start_line":26,"start_character":60,"end_line":27,"end_character":50},"updated":"2020-11-25 13:24:57.000000000","message":"We have been using the metering agent for quite a while now, and we do not feel this burden. Can you illustrate/describe it a bit further?","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"10a786f83f2b6aad91d00670011843e68bad9b5a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agents increase"},{"line_number":28,"context_line":"the centralized message queue load, such as you run metering agent in every"},{"line_number":29,"context_line":"compute nodes. And there is a known issue that dvr could not work with metering"},{"line_number":30,"context_line":"agent [4]_."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":10,"id":"4138937d_5ce8a8f6","line":30,"range":{"start_line":29,"start_character":15,"end_line":30,"end_character":10},"updated":"2020-11-25 13:24:57.000000000","message":"Limitation always exist, that would be a matter of extending the metering agent to support DVR.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b7760ca1a19c0145aba021827b636c340c55d36f","unresolved":true,"context_lines":[{"line_number":26,"context_line":"The metering agent is a bit heavy for the cloud deployment. Users need to add"},{"line_number":27,"context_line":"extra actions to enable the metering functionality. And more agents increase"},{"line_number":28,"context_line":"the centralized message queue load, such as you run metering agent in every"},{"line_number":29,"context_line":"compute nodes. And there is a known issue that dvr could not work with metering"},{"line_number":30,"context_line":"agent [4]_."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":10,"id":"4b17f228_a7b84d15","line":30,"range":{"start_line":29,"start_character":15,"end_line":30,"end_character":10},"in_reply_to":"4138937d_5ce8a8f6","updated":"2020-12-07 07:02:56.000000000","message":"From my personal experiences, when your cloud deployment growth, you will not want to add more agents. But the metering functions are independent, you need to run L3 agent, ovs-agent and metering agent on every compute nodes. You have 1000 compute nodes, you will have 3 * 1000 neutron agents. Then how many neutron-server you should have? How to make the message queue happy? If you try to do some upgrading work, more agents more failure points.\nSo, based on these points, I want to make the L3 IPs has metering functions in L3 scope natively.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"10a786f83f2b6aad91d00670011843e68bad9b5a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Server side changes"},{"line_number":44,"context_line":"+++++++++++++++++++"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"}],"source_content_type":"text/x-rst","patch_set":10,"id":"4a4b0ee4_96d35ae4","line":46,"range":{"start_line":46,"start_character":43,"end_line":46,"end_character":51},"updated":"2020-11-25 13:24:57.000000000","message":"may? Or always? \n\nWhat happens if they do not have a QoS policy?","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b7760ca1a19c0145aba021827b636c340c55d36f","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Server side changes"},{"line_number":44,"context_line":"+++++++++++++++++++"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"}],"source_content_type":"text/x-rst","patch_set":10,"id":"380ee4d4_8aebc9cd","line":46,"range":{"start_line":46,"start_character":43,"end_line":46,"end_character":51},"in_reply_to":"4a4b0ee4_96d35ae4","updated":"2020-12-07 07:02:56.000000000","message":"It should be \u0027always\u0027 since the agent side needs to apply the TC rules which is based on the rules of the policy.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":50,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"21812a61_7eea9f42","line":48,"range":{"start_line":48,"start_character":29,"end_line":48,"end_character":35},"updated":"2020-11-23 11:15:53.000000000","message":"could or cloud?","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":50,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1970d8cd_00fb8ed1","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":49},"updated":"2020-11-23 11:15:53.000000000","message":"default","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"10a786f83f2b6aad91d00670011843e68bad9b5a","unresolved":true,"context_lines":[{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":50,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"L3 agent side changes"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7ce337a7_3bfae31a","line":50,"range":{"start_line":49,"start_character":2,"end_line":50,"end_character":42},"updated":"2020-11-25 13:24:57.000000000","message":"Right now, with the current metering agent, we can have a great deal of flexibility by adding and removing metering rules. Would that be supported with this proposal as well?","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  filter parent 1: protocol ip pref 1 u32"},{"line_number":62,"context_line":"  filter parent 1: protocol ip pref 1 u32 fh 800: ht divisor 1"},{"line_number":63,"context_line":"  filter parent 1: protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 not_in_hw (rule hit 180 success 180)"},{"line_number":64,"context_line":"    match IP src 172.16.100.10/32 (success 180 )"},{"line_number":65,"context_line":"   police 0x2 rate 1024Kbit burst 128Kb mtu 64Kb action drop overhead 0b linklayer ethernet"},{"line_number":66,"context_line":"   ref 1 bind 1 installed 86737 sec used 439 sec"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5003c5e0_df91d867","line":64,"range":{"start_line":64,"start_character":17,"end_line":64,"end_character":33},"updated":"2020-11-23 11:15:53.000000000","message":"this is Floating IP, right?","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b7760ca1a19c0145aba021827b636c340c55d36f","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  filter parent 1: protocol ip pref 1 u32"},{"line_number":62,"context_line":"  filter parent 1: protocol ip pref 1 u32 fh 800: ht divisor 1"},{"line_number":63,"context_line":"  filter parent 1: protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 not_in_hw (rule hit 180 success 180)"},{"line_number":64,"context_line":"    match IP src 172.16.100.10/32 (success 180 )"},{"line_number":65,"context_line":"   police 0x2 rate 1024Kbit burst 128Kb mtu 64Kb action drop overhead 0b linklayer ethernet"},{"line_number":66,"context_line":"   ref 1 bind 1 installed 86737 sec used 439 sec"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"8c3582ae_b37c7e97","line":64,"range":{"start_line":64,"start_character":17,"end_line":64,"end_character":33},"in_reply_to":"5003c5e0_df91d867","updated":"2020-12-07 07:02:56.000000000","message":"Yes, here can be floating IP or gateway IP.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":71,"context_line":"the following tasks:"},{"line_number":72,"context_line":"1. retrieve the data from the TC rules periodically"},{"line_number":73,"context_line":"2. store the data to local store file"},{"line_number":74,"context_line":"3. report the data to ceilometer/metering service via RPC notification or UDP"},{"line_number":75,"context_line":"4. (optional) Some other service like zabbix read the local store data or report to it."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9e5e61a1_d8e4a575","line":74,"updated":"2020-11-23 11:15:53.000000000","message":"this RPC notification will be optional or always enabled?","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b7760ca1a19c0145aba021827b636c340c55d36f","unresolved":true,"context_lines":[{"line_number":71,"context_line":"the following tasks:"},{"line_number":72,"context_line":"1. retrieve the data from the TC rules periodically"},{"line_number":73,"context_line":"2. store the data to local store file"},{"line_number":74,"context_line":"3. report the data to ceilometer/metering service via RPC notification or UDP"},{"line_number":75,"context_line":"4. (optional) Some other service like zabbix read the local store data or report to it."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3d095bf1_3ea65ecf","line":74,"in_reply_to":"9e5e61a1_d8e4a575","updated":"2020-12-07 07:02:56.000000000","message":"It is optional, the work of this line is similar to metering agent which will report the data to a message queue[1]. But I\u0027d like to expand the methods to not expand the message queue pressure. Something like report structure date to data store via UDP, or to any TSDB.\n[1] https://github.com/openstack/neutron/blob/master/neutron/services/metering/agents/metering_agent.py#L93-L131","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":83,"context_line":"::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  [agent]"},{"line_number":86,"context_line":"  extensions \u003d metering"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"A new config section [metering] will be added to l3-agent config:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f00a756_38911826","line":86,"range":{"start_line":86,"start_character":15,"end_line":86,"end_character":23},"updated":"2020-11-23 11:15:53.000000000","message":"I would name it like e.g. \"qos_metering\" or something like that to highligh that it\u0027s not related to the Metering agent at all.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"10a786f83f2b6aad91d00670011843e68bad9b5a","unresolved":true,"context_lines":[{"line_number":83,"context_line":"::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  [agent]"},{"line_number":86,"context_line":"  extensions \u003d metering"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"A new config section [metering] will be added to l3-agent config:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"f186c82c_8d56514b","line":86,"range":{"start_line":86,"start_character":15,"end_line":86,"end_character":23},"in_reply_to":"3f00a756_38911826","updated":"2020-11-25 13:24:57.000000000","message":"+1","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"::"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  [metering]"},{"line_number":93,"context_line":"  data_store_path \u003d /var/lib/neutron"},{"line_number":94,"context_line":"  data_retrieve_interval \u003d 30"},{"line_number":95,"context_line":"  data_report_interval \u003d 30"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8b3da73f_ba9ce690","line":92,"range":{"start_line":92,"start_character":3,"end_line":92,"end_character":11},"updated":"2020-11-23 11:15:53.000000000","message":"same here","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":101,"context_line":"::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  [DEFAULT]"},{"line_number":104,"context_line":"  floating_ip_default_qos_policy \u003d \u003ca-policy-uuid\u003e"},{"line_number":105,"context_line":"  router_gateway_ip_default_qos_policy \u003d  \u003ca-policy-uuid\u003e"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The neutron basic workflow"},{"line_number":108,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8dfad6a3_19c04f5c","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":57},"updated":"2020-11-23 11:15:53.000000000","message":"we already have API to set default QoS policy. Why to introduce another config knobs for that?","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b7760ca1a19c0145aba021827b636c340c55d36f","unresolved":true,"context_lines":[{"line_number":101,"context_line":"::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  [DEFAULT]"},{"line_number":104,"context_line":"  floating_ip_default_qos_policy \u003d \u003ca-policy-uuid\u003e"},{"line_number":105,"context_line":"  router_gateway_ip_default_qos_policy \u003d  \u003ca-policy-uuid\u003e"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The neutron basic workflow"},{"line_number":108,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"c50319b5_2ca056d0","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":57},"in_reply_to":"8dfad6a3_19c04f5c","updated":"2020-12-07 07:02:56.000000000","message":"I don\u0027t think the default qos policy can be applied to floating IP and gateway IP. It is now only affect the network or port.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"10a786f83f2b6aad91d00670011843e68bad9b5a","unresolved":true,"context_lines":[{"line_number":108,"context_line":"--------------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"To achive native L3 IPs metering functionality, users just need to"},{"line_number":111,"context_line":"ensure the L3 IPs have the binding QoS policy (with bandwidth rules)"},{"line_number":112,"context_line":"and enable the L3 agent metering extension with proper reporting"},{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"80cb980e_ed53fc5b","line":111,"range":{"start_line":111,"start_character":35,"end_line":111,"end_character":68},"updated":"2020-11-25 13:24:57.000000000","message":"what about integrating the current metering API with this proposal. I mean, a QoS policy, is  a policy to define the quality of service we want. It looks a bit odd to me that we add into these policies the metering rules.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5fd7bc9e69a3cc95bac0d12af73062c62e2c84a6","unresolved":true,"context_lines":[{"line_number":108,"context_line":"--------------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"To achive native L3 IPs metering functionality, users just need to"},{"line_number":111,"context_line":"ensure the L3 IPs have the binding QoS policy (with bandwidth rules)"},{"line_number":112,"context_line":"and enable the L3 agent metering extension with proper reporting"},{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"d860708c_e745d6d2","line":111,"range":{"start_line":111,"start_character":35,"end_line":111,"end_character":68},"in_reply_to":"5b8a5671_9358b659","updated":"2020-12-14 12:38:04.000000000","message":"I see, but that is actually one of the problems I see. It seems to me that we are deprecating it, but the alternative would not fulfill all of its feature. That is why I suggested extending the current API and allowing a different backend to apply the metering rules. Then, we would address your use case with the API that we already have in place.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b7760ca1a19c0145aba021827b636c340c55d36f","unresolved":true,"context_lines":[{"line_number":108,"context_line":"--------------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"To achive native L3 IPs metering functionality, users just need to"},{"line_number":111,"context_line":"ensure the L3 IPs have the binding QoS policy (with bandwidth rules)"},{"line_number":112,"context_line":"and enable the L3 agent metering extension with proper reporting"},{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"d3064906_b2888042","line":111,"range":{"start_line":111,"start_character":35,"end_line":111,"end_character":68},"in_reply_to":"80cb980e_ed53fc5b","updated":"2020-12-07 07:02:56.000000000","message":"My idea is to not involve metering API/DB/agent at all. All the L3 IPs metering will be done by L3-agent natively. Neutron will add some default policy which is for the IPs do not have a binding policy. And ensure every L3 IPs have qos policy in order to make L3 agent can install TC rules for the L3 IPs.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"a7a88bb2de3e4a49a67c558719c60c5d826bb24a","unresolved":true,"context_lines":[{"line_number":108,"context_line":"--------------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"To achive native L3 IPs metering functionality, users just need to"},{"line_number":111,"context_line":"ensure the L3 IPs have the binding QoS policy (with bandwidth rules)"},{"line_number":112,"context_line":"and enable the L3 agent metering extension with proper reporting"},{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"eef88cbc_36b6e6fc","line":111,"range":{"start_line":111,"start_character":35,"end_line":111,"end_character":68},"in_reply_to":"d3064906_b2888042","updated":"2020-12-11 11:01:26.000000000","message":"Why not re-use the API? I mean, the API is the standard to configure labels and rules. One could add a new option in the API (e.g. driver/backend/something else) that defines the agent where the rules are applied. Then, we could satisfy what you want and keep the API that is already in place and used by everyone else. This would also create a smoother migration path.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"17ae60fe3efeef9667c2e518391b0b98380d52d0","unresolved":true,"context_lines":[{"line_number":108,"context_line":"--------------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"To achive native L3 IPs metering functionality, users just need to"},{"line_number":111,"context_line":"ensure the L3 IPs have the binding QoS policy (with bandwidth rules)"},{"line_number":112,"context_line":"and enable the L3 agent metering extension with proper reporting"},{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"d4612d03_5a4f9f61","line":111,"range":{"start_line":111,"start_character":35,"end_line":111,"end_character":68},"in_reply_to":"d860708c_e745d6d2","updated":"2020-12-18 09:17:13.000000000","message":"After some consideration about the API, IMO, I would not to change or extend those. Here are some reason:\n1. save the RPCs between neutron server and agents when the API resource create/delete/update.\n2. if there are tons of IPs/Routers/Gateways etc., operators need to call tons of APIs to enable the metering.\n3. from my personal experiences, operators usually want all L3 public IPs are under monitor, so config once and funciton up looks a better solution for them.\n4. same to 3, but for cloud app developers, current metering API sometimes causes too much developing/operation burden on north APPs, such as console or portal.\n5. this spec is to add an alternative for L3 public IPs metering, it is not an extension of existing metering plugin/api/agent.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"efbb0cd472ef43f999c1beaf11cc534978b9a039","unresolved":true,"context_lines":[{"line_number":108,"context_line":"--------------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"To achive native L3 IPs metering functionality, users just need to"},{"line_number":111,"context_line":"ensure the L3 IPs have the binding QoS policy (with bandwidth rules)"},{"line_number":112,"context_line":"and enable the L3 agent metering extension with proper reporting"},{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5b8a5671_9358b659","line":111,"range":{"start_line":111,"start_character":35,"end_line":111,"end_character":68},"in_reply_to":"eef88cbc_36b6e6fc","updated":"2020-12-14 02:16:21.000000000","message":"My final idea is to deprecate the metering agent to narrow down the pressure centrilized MQ and DB when the running hosts have a large number of growth. So it\u0027s a bit strange to me if we still remain to use the existing APIs. I will take a look at the metering code deeply. For now, it seems tightly coupled for the metering plugin, notifications, RPCs and agents. Looks we need to do lots refactor works.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":110,"context_line":"To achive native L3 IPs metering functionality, users just need to"},{"line_number":111,"context_line":"ensure the L3 IPs have the binding QoS policy (with bandwidth rules)"},{"line_number":112,"context_line":"and enable the L3 agent metering extension with proper reporting"},{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"If the default QoS policy is configured, then we can say all L3 IPs will"},{"line_number":116,"context_line":"be set under a bandwidth restriction. And if IPs is finnally installed to"}],"source_content_type":"text/x-rst","patch_set":10,"id":"049274df_a8e3138e","line":113,"range":{"start_line":113,"start_character":24,"end_line":113,"end_character":29},"updated":"2020-11-23 11:15:53.000000000","message":"work","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"If the default QoS policy is configured, then we can say all L3 IPs will"},{"line_number":116,"context_line":"be set under a bandwidth restriction. And if IPs is finnally installed to"},{"line_number":117,"context_line":"the L3 agent, the tc rules will be created, and metering can start if"},{"line_number":118,"context_line":"agent enable metering extension."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"86f38252_b7c5d2e4","line":116,"range":{"start_line":116,"start_character":52,"end_line":116,"end_character":60},"updated":"2020-11-23 11:15:53.000000000","message":"finally","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":115,"context_line":"If the default QoS policy is configured, then we can say all L3 IPs will"},{"line_number":116,"context_line":"be set under a bandwidth restriction. And if IPs is finnally installed to"},{"line_number":117,"context_line":"the L3 agent, the tc rules will be created, and metering can start if"},{"line_number":118,"context_line":"agent enable metering extension."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bea4cd1e_4fc98b8e","line":118,"updated":"2020-11-23 11:15:53.000000000","message":"who will be owner of this default policy? Will user see it in API? If so, will user be able to change it?","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b7760ca1a19c0145aba021827b636c340c55d36f","unresolved":true,"context_lines":[{"line_number":115,"context_line":"If the default QoS policy is configured, then we can say all L3 IPs will"},{"line_number":116,"context_line":"be set under a bandwidth restriction. And if IPs is finnally installed to"},{"line_number":117,"context_line":"the L3 agent, the tc rules will be created, and metering can start if"},{"line_number":118,"context_line":"agent enable metering extension."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"cfb074bd_27f39bf5","line":118,"in_reply_to":"bea4cd1e_4fc98b8e","updated":"2020-12-07 07:02:56.000000000","message":"The default policy should be owned by the admin user, because the rules of the default policy should not be changed/removed.","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"721bf412d5761e827712155c76eb9dd74c55da53","unresolved":true,"context_lines":[{"line_number":134,"context_line":"be another way. But that requires:"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"- 1. adapting API changing since TC has no use of the metering label."},{"line_number":137,"context_line":"- 2. adding new potential binding between lable and IP default qos."},{"line_number":138,"context_line":"- 3. data interacting between L3 agent and metering agent because for"},{"line_number":139,"context_line":"  different nodes, it will have different l3_agent_mode, metering driver"},{"line_number":140,"context_line":"  should be aware of where the agent is running."}],"source_content_type":"text/x-rst","patch_set":10,"id":"b2babf90_71dcc0a2","line":137,"range":{"start_line":137,"start_character":42,"end_line":137,"end_character":47},"updated":"2020-11-23 11:15:53.000000000","message":"label","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"10a786f83f2b6aad91d00670011843e68bad9b5a","unresolved":true,"context_lines":[{"line_number":142,"context_line":"- 5. coordinate L3 IP QoS TC driver and metering agent TC driver, such as:"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  + a. removing the QoS of an IP and adding metering driver\u0027s back"},{"line_number":145,"context_line":"  + b. adding metering lable with TC driver and adding IP QoS policy"},{"line_number":146,"context_line":"  + c. removing metering driver\u0027s TC rule and adding IP QoS TC rule"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":10,"id":"b69e26c2_0ea3c741","line":145,"range":{"start_line":145,"start_character":23,"end_line":145,"end_character":28},"updated":"2020-11-25 13:24:57.000000000","message":"label","commit_id":"794785080a3ebe7d7b32e90d41be917372a7f061"}],"specs/xena/l3-ips-metering.rst":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"868a1743e4ef1a7cd8fc7da094d5621ead038add","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":50,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"33f63596_ca225f3e","line":48,"range":{"start_line":48,"start_character":29,"end_line":48,"end_character":35},"updated":"2021-05-12 16:30:39.000000000","message":"nit: could?","commit_id":"724e3aaf2c310be02ef2da1231e36cad5e9ca452"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"868a1743e4ef1a7cd8fc7da094d5621ead038add","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":50,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"e5a6331d_3c19a8ed","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":49},"updated":"2021-05-12 16:30:39.000000000","message":"nit: default","commit_id":"724e3aaf2c310be02ef2da1231e36cad5e9ca452"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"abc9f85b5e664ab98c80f8e14c592aedec1f3403","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":50,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"8d910324_f170d545","line":48,"range":{"start_line":48,"start_character":29,"end_line":48,"end_character":35},"in_reply_to":"33f63596_ca225f3e","updated":"2021-05-21 01:18:41.000000000","message":"Done","commit_id":"724e3aaf2c310be02ef2da1231e36cad5e9ca452"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"abc9f85b5e664ab98c80f8e14c592aedec1f3403","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Both router gateway IPs and floating IPs may need to bind a QoS policy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* For router and floating IP clould have a defult QoS policy binding mechanism"},{"line_number":49,"context_line":"  which means neutron server will set a default QoS policy with bandwidth rules"},{"line_number":50,"context_line":"  for router gateway IPs and floating IPs."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"25287200_586d60e8","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":49},"in_reply_to":"e5a6331d_3c19a8ed","updated":"2021-05-21 01:18:41.000000000","message":"Done","commit_id":"724e3aaf2c310be02ef2da1231e36cad5e9ca452"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"868a1743e4ef1a7cd8fc7da094d5621ead038add","unresolved":true,"context_lines":[{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"If the default QoS policy is configured, then we can say all L3 IPs will"},{"line_number":116,"context_line":"be set under a bandwidth restriction. And if IPs is finnally installed to"},{"line_number":117,"context_line":"the L3 agent, the tc rules will be created, and metering can start if"},{"line_number":118,"context_line":"agent enable metering extension."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":16,"id":"14b564d3_0f288420","line":118,"range":{"start_line":116,"start_character":38,"end_line":118,"end_character":32},"updated":"2021-05-12 16:30:39.000000000","message":"What about: \"If IPs are finally installed (sent via RPC?) to the L3 agent, the tc rules will be created, and metering can start if metering extension is enabled in the agent config.\" ?","commit_id":"724e3aaf2c310be02ef2da1231e36cad5e9ca452"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"abc9f85b5e664ab98c80f8e14c592aedec1f3403","unresolved":false,"context_lines":[{"line_number":113,"context_line":"settings, no more extra works."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"If the default QoS policy is configured, then we can say all L3 IPs will"},{"line_number":116,"context_line":"be set under a bandwidth restriction. And if IPs is finnally installed to"},{"line_number":117,"context_line":"the L3 agent, the tc rules will be created, and metering can start if"},{"line_number":118,"context_line":"agent enable metering extension."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":16,"id":"c759af77_da3441ae","line":118,"range":{"start_line":116,"start_character":38,"end_line":118,"end_character":32},"in_reply_to":"14b564d3_0f288420","updated":"2021-05-21 01:18:41.000000000","message":"Done","commit_id":"724e3aaf2c310be02ef2da1231e36cad5e9ca452"}]}