)]}'
{"specs/ussuri/address-groups-support-in-security-group-rule.rst":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b3e5f1a6466978fe12027e5f5339f3196fddad01","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification describes how to support address groups (groups of IP"},{"line_number":14,"context_line":"address blocks) in Neutron security group rules. The concept of address group"},{"line_number":15,"context_line":"was introduced in FaaS v2.0 but implemented [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f493fa4_5e47a84c","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":22},"updated":"2020-04-22 11:43:17.000000000","message":"nit: FWaaS","commit_id":"40272d2056f30368ca6103d0a3f303e003536ca8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b3e5f1a6466978fe12027e5f5339f3196fddad01","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification describes how to support address groups (groups of IP"},{"line_number":14,"context_line":"address blocks) in Neutron security group rules. The concept of address group"},{"line_number":15,"context_line":"was introduced in FaaS v2.0 but implemented [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f493fa4_be750c9b","line":15,"range":{"start_line":15,"start_character":32,"end_line":15,"end_character":43},"updated":"2020-04-22 11:43:17.000000000","message":"nit: not implemented?","commit_id":"40272d2056f30368ca6103d0a3f303e003536ca8"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d1211bbf9b7533a8eb489bf634487cb3e8213e15","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification describes how to support address groups (groups of IP"},{"line_number":14,"context_line":"address blocks) in Neutron security group rules. The concept of address group"},{"line_number":15,"context_line":"was introduced in FaaS v2.0 but implemented [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f493fa4_8b73a7e7","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":22},"in_reply_to":"1f493fa4_5e47a84c","updated":"2020-04-22 18:28:47.000000000","message":"Done","commit_id":"40272d2056f30368ca6103d0a3f303e003536ca8"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d1211bbf9b7533a8eb489bf634487cb3e8213e15","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification describes how to support address groups (groups of IP"},{"line_number":14,"context_line":"address blocks) in Neutron security group rules. The concept of address group"},{"line_number":15,"context_line":"was introduced in FaaS v2.0 but implemented [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f493fa4_eb806b8e","line":15,"range":{"start_line":15,"start_character":32,"end_line":15,"end_character":43},"in_reply_to":"1f493fa4_be750c9b","updated":"2020-04-22 18:28:47.000000000","message":"Done","commit_id":"40272d2056f30368ca6103d0a3f303e003536ca8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b3e5f1a6466978fe12027e5f5339f3196fddad01","unresolved":false,"context_lines":[{"line_number":552,"context_line":"* REST API"},{"line_number":553,"context_line":"* DB Schema"},{"line_number":554,"context_line":"* CLI update"},{"line_number":555,"context_line":"* Documentation update"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"Testing"},{"line_number":558,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f493fa4_7e91c499","line":555,"updated":"2020-04-22 11:43:17.000000000","message":"Do we need changes in the firewall drivers to also collect the addresses from remote_address_group when they implement the rules?","commit_id":"40272d2056f30368ca6103d0a3f303e003536ca8"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"d1211bbf9b7533a8eb489bf634487cb3e8213e15","unresolved":false,"context_lines":[{"line_number":552,"context_line":"* REST API"},{"line_number":553,"context_line":"* DB Schema"},{"line_number":554,"context_line":"* CLI update"},{"line_number":555,"context_line":"* Documentation update"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"Testing"},{"line_number":558,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f493fa4_eb598b5a","line":555,"in_reply_to":"1f493fa4_7e91c499","updated":"2020-04-22 18:28:47.000000000","message":"I\u0027m not sure about the future plan for fwaas, looks like it is not actively maintained: https://docs.openstack.org/neutron-fwaas/latest/","commit_id":"40272d2056f30368ca6103d0a3f303e003536ca8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e055f8b43ce5e88eb16fb19f05ee518af85687e3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/neutron/+bug/1592028"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification describes how to support address groups (groups of IP"},{"line_number":14,"context_line":"address blocks) in Neutron security group rules. The concept of address group"},{"line_number":15,"context_line":"was introduced in FWaaS v2.0 but not implemented [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_ea06291c","line":14,"range":{"start_line":14,"start_character":72,"end_line":14,"end_character":77},"updated":"2020-04-28 18:15:58.000000000","message":"s/groups","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"eb187b9e20a370160117c3108c06cbf9464f0011","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/neutron/+bug/1592028"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification describes how to support address groups (groups of IP"},{"line_number":14,"context_line":"address blocks) in Neutron security group rules. The concept of address group"},{"line_number":15,"context_line":"was introduced in FWaaS v2.0 but not implemented [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_70eac673","line":14,"range":{"start_line":14,"start_character":72,"end_line":14,"end_character":77},"in_reply_to":"1f493fa4_ea06291c","updated":"2020-06-05 17:22:46.000000000","message":"Done","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e055f8b43ce5e88eb16fb19f05ee518af85687e3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Neutron security group rules currently support using an ip address block or a"},{"line_number":21,"context_line":"security group as the remote end of the network access rule. In actual usage,"},{"line_number":22,"context_line":"an OpenStack cloud may require connectivity between instances and external"},{"line_number":23,"context_line":"services which are not provisioned by OpenStack. And each service may also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_ca0b6d21","line":20,"range":{"start_line":20,"start_character":56,"end_line":20,"end_character":58},"updated":"2020-04-28 18:15:58.000000000","message":"s/IP","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"eb187b9e20a370160117c3108c06cbf9464f0011","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Neutron security group rules currently support using an ip address block or a"},{"line_number":21,"context_line":"security group as the remote end of the network access rule. In actual usage,"},{"line_number":22,"context_line":"an OpenStack cloud may require connectivity between instances and external"},{"line_number":23,"context_line":"services which are not provisioned by OpenStack. And each service may also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_d004724c","line":20,"range":{"start_line":20,"start_character":56,"end_line":20,"end_character":58},"in_reply_to":"1f493fa4_ca0b6d21","updated":"2020-06-05 17:22:46.000000000","message":"Done","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e055f8b43ce5e88eb16fb19f05ee518af85687e3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"an OpenStack cloud may require connectivity between instances and external"},{"line_number":23,"context_line":"services which are not provisioned by OpenStack. And each service may also"},{"line_number":24,"context_line":"have multiple endpoint addresses which are not contiguous. To allow the"},{"line_number":25,"context_line":"connectivity, one rule per external address need be created which can be very"},{"line_number":26,"context_line":"cumbersome and difficult to maintain as the number of external addresses may"},{"line_number":27,"context_line":"be substantial."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_6a1a196f","line":25,"range":{"start_line":25,"start_character":44,"end_line":25,"end_character":48},"updated":"2020-04-28 18:15:58.000000000","message":"s/needs","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"eb187b9e20a370160117c3108c06cbf9464f0011","unresolved":false,"context_lines":[{"line_number":22,"context_line":"an OpenStack cloud may require connectivity between instances and external"},{"line_number":23,"context_line":"services which are not provisioned by OpenStack. And each service may also"},{"line_number":24,"context_line":"have multiple endpoint addresses which are not contiguous. To allow the"},{"line_number":25,"context_line":"connectivity, one rule per external address need be created which can be very"},{"line_number":26,"context_line":"cumbersome and difficult to maintain as the number of external addresses may"},{"line_number":27,"context_line":"be substantial."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_b0ff3e32","line":25,"range":{"start_line":25,"start_character":44,"end_line":25,"end_character":48},"in_reply_to":"1f493fa4_6a1a196f","updated":"2020-06-05 17:22:46.000000000","message":"Done","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dffa9c3609b30fb56cbceb60850622857eb17431","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            \"addresses\": ["},{"line_number":262,"context_line":"               {\"address\": \"132.168.4.12/24\", \"ip_version\": 4},"},{"line_number":263,"context_line":"               {\"address\": \"132.168.5.12-132.168.5.24\", \"ip_version\": 4},"},{"line_number":264,"context_line":"               {\"address\": \"2001::db8::f00/64\", \"ip_version\": 6}"},{"line_number":265,"context_line":"            ]"},{"line_number":266,"context_line":"        }"},{"line_number":267,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_7e24a9af","line":264,"updated":"2020-04-28 09:45:20.000000000","message":"how this update will work? Will it just store all those 3 addresses to the group and removes everything else? Or will it just try to add those 3 addresses without touching new old ones?\nIf latter is true, how to remove some addresses from group?\nIf first option is true, I think we will have some problem like with router\u0027s extraroutes, see: https://specs.openstack.org/openstack/neutron-specs/specs/train/improve-extraroute-api.html for details","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"eb187b9e20a370160117c3108c06cbf9464f0011","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            \"addresses\": ["},{"line_number":262,"context_line":"               {\"address\": \"132.168.4.12/24\", \"ip_version\": 4},"},{"line_number":263,"context_line":"               {\"address\": \"132.168.5.12-132.168.5.24\", \"ip_version\": 4},"},{"line_number":264,"context_line":"               {\"address\": \"2001::db8::f00/64\", \"ip_version\": 6}"},{"line_number":265,"context_line":"            ]"},{"line_number":266,"context_line":"        }"},{"line_number":267,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_70d126cc","line":264,"in_reply_to":"1f493fa4_7e24a9af","updated":"2020-06-05 17:22:46.000000000","message":"Good point. I kept the update endpoint for non-address field operations and made two more endpoints for address add and remove. Please check in the updated patch.","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dffa9c3609b30fb56cbceb60850622857eb17431","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            \"port_range_max\": 80,"},{"line_number":467,"context_line":"            \"port_range_min\": 80,"},{"line_number":468,"context_line":"            \"protocol\": \"tcp\","},{"line_number":469,"context_line":"           \"remote_ip_prefix\": null,"},{"line_number":470,"context_line":"            \"remote_group_id\": null,"},{"line_number":471,"context_line":"            \"remote_address_group_id\": \"8722e0e0-9cc9-4490-9660-8c9a5732fbb0\","},{"line_number":472,"context_line":"            \"security_group_id\": \"a7734e61-b545-452d-a3cd-0189cbd9747a\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_e30e6639","line":469,"updated":"2020-04-28 09:45:20.000000000","message":"nitty nit: please fix alignment with line above","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"eb187b9e20a370160117c3108c06cbf9464f0011","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            \"port_range_max\": 80,"},{"line_number":467,"context_line":"            \"port_range_min\": 80,"},{"line_number":468,"context_line":"            \"protocol\": \"tcp\","},{"line_number":469,"context_line":"           \"remote_ip_prefix\": null,"},{"line_number":470,"context_line":"            \"remote_group_id\": null,"},{"line_number":471,"context_line":"            \"remote_address_group_id\": \"8722e0e0-9cc9-4490-9660-8c9a5732fbb0\","},{"line_number":472,"context_line":"            \"security_group_id\": \"a7734e61-b545-452d-a3cd-0189cbd9747a\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_f0dc16e2","line":469,"in_reply_to":"1f493fa4_e30e6639","updated":"2020-06-05 17:22:46.000000000","message":"Done","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e055f8b43ce5e88eb16fb19f05ee518af85687e3","unresolved":false,"context_lines":[{"line_number":585,"context_line":"Developer Documentation"},{"line_number":586,"context_line":"-----------------------"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"* neutron api devref and documentation need be updated."},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"References"},{"line_number":591,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_0a68b5b6","line":588,"range":{"start_line":588,"start_character":2,"end_line":588,"end_character":13},"updated":"2020-04-28 18:15:58.000000000","message":"s/Neutron API","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e055f8b43ce5e88eb16fb19f05ee518af85687e3","unresolved":false,"context_lines":[{"line_number":585,"context_line":"Developer Documentation"},{"line_number":586,"context_line":"-----------------------"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"* neutron api devref and documentation need be updated."},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"References"},{"line_number":591,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_8aa165fb","line":588,"range":{"start_line":588,"start_character":44,"end_line":588,"end_character":46},"updated":"2020-04-28 18:15:58.000000000","message":"s/to be","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"eb187b9e20a370160117c3108c06cbf9464f0011","unresolved":false,"context_lines":[{"line_number":585,"context_line":"Developer Documentation"},{"line_number":586,"context_line":"-----------------------"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"* neutron api devref and documentation need be updated."},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"References"},{"line_number":591,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_50f1826a","line":588,"range":{"start_line":588,"start_character":2,"end_line":588,"end_character":13},"in_reply_to":"1f493fa4_0a68b5b6","updated":"2020-06-05 17:22:46.000000000","message":"Done","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"eb187b9e20a370160117c3108c06cbf9464f0011","unresolved":false,"context_lines":[{"line_number":585,"context_line":"Developer Documentation"},{"line_number":586,"context_line":"-----------------------"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"* neutron api devref and documentation need be updated."},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"References"},{"line_number":591,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_30f4ce5a","line":588,"range":{"start_line":588,"start_character":44,"end_line":588,"end_character":46},"in_reply_to":"1f493fa4_8aa165fb","updated":"2020-06-05 17:22:46.000000000","message":"Done","commit_id":"1abe831b5a40c4b4af417258fe321542ccd50365"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8456f9521986ee848635221f1f04e8077603ac58","unresolved":false,"context_lines":[{"line_number":69,"context_line":"|                   |         |       |      | \"ip_version\": 4 or 6(Integer value)   |"},{"line_number":70,"context_line":"|                   |         |       |      | An example of addresses:              |"},{"line_number":71,"context_line":"|                   |         |       |      | [{\"address\": \"132.168.4.12/24\",       |"},{"line_number":72,"context_line":"|                   |         |       |      | \"ip_version\": 4}]                     |"},{"line_number":73,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"|"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_fd0cbced","line":72,"updated":"2020-06-09 17:43:42.000000000","message":"In sake of simplicity, do we need to store both the IP address and the version? The version is something easily calculable.","commit_id":"b76523daac4bff578c2ef93b0138d3b1bc18e11e"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"e8099411863200c70ec1d9cac0185f7865a149c4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"|                   |         |       |      | \"ip_version\": 4 or 6(Integer value)   |"},{"line_number":70,"context_line":"|                   |         |       |      | An example of addresses:              |"},{"line_number":71,"context_line":"|                   |         |       |      | [{\"address\": \"132.168.4.12/24\",       |"},{"line_number":72,"context_line":"|                   |         |       |      | \"ip_version\": 4}]                     |"},{"line_number":73,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"|"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_b6c42110","line":72,"in_reply_to":"ff570b3c_fd0cbced","updated":"2020-06-09 20:53:50.000000000","message":"Make sense, I removed the version field in the new patch.","commit_id":"b76523daac4bff578c2ef93b0138d3b1bc18e11e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8456f9521986ee848635221f1f04e8077603ac58","unresolved":false,"context_lines":[{"line_number":644,"context_line":"+------------------------+------------+-----+------+---------------------------------------+"},{"line_number":645,"context_line":"| Attribute              | Type       | Req | CRUD |  Description                          |"},{"line_number":646,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":647,"context_line":"| remote_address         | String     | No  | CRU  | When a remote_address_group is        |"},{"line_number":648,"context_line":"| _group_id              |            |     |      | specified, it is matched when the     |"},{"line_number":649,"context_line":"|                        |            |     |      | remote IP address in the packet       |"},{"line_number":650,"context_line":"|                        |            |     |      | matches one of the IP addresses in    |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_fda83c8d","line":647,"updated":"2020-06-09 17:43:42.000000000","message":"I guess that \"remote_ip_prefix\", \"remote_group_id\" and \"remote_address_group_id\" are exclusive.","commit_id":"b76523daac4bff578c2ef93b0138d3b1bc18e11e"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"e8099411863200c70ec1d9cac0185f7865a149c4","unresolved":false,"context_lines":[{"line_number":644,"context_line":"+------------------------+------------+-----+------+---------------------------------------+"},{"line_number":645,"context_line":"| Attribute              | Type       | Req | CRUD |  Description                          |"},{"line_number":646,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":647,"context_line":"| remote_address         | String     | No  | CRU  | When a remote_address_group is        |"},{"line_number":648,"context_line":"| _group_id              |            |     |      | specified, it is matched when the     |"},{"line_number":649,"context_line":"|                        |            |     |      | remote IP address in the packet       |"},{"line_number":650,"context_line":"|                        |            |     |      | matches one of the IP addresses in    |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_f6e7b9ab","line":647,"in_reply_to":"ff570b3c_fda83c8d","updated":"2020-06-09 20:53:50.000000000","message":"Yes, it is mentioned in L539. Also added to the description here in the new patch.","commit_id":"b76523daac4bff578c2ef93b0138d3b1bc18e11e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8456f9521986ee848635221f1f04e8077603ac58","unresolved":false,"context_lines":[{"line_number":666,"context_line":"* REST API"},{"line_number":667,"context_line":"* DB Schema"},{"line_number":668,"context_line":"* CLI update"},{"line_number":669,"context_line":"* Documentation update"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"Testing"},{"line_number":672,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_7d9c2c6a","line":669,"updated":"2020-06-09 17:43:42.000000000","message":"Are you going to implement this change in any in-tree firewall (iptables, OVS)?","commit_id":"b76523daac4bff578c2ef93b0138d3b1bc18e11e"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"e8099411863200c70ec1d9cac0185f7865a149c4","unresolved":false,"context_lines":[{"line_number":666,"context_line":"* REST API"},{"line_number":667,"context_line":"* DB Schema"},{"line_number":668,"context_line":"* CLI update"},{"line_number":669,"context_line":"* Documentation update"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"Testing"},{"line_number":672,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_76fba946","line":669,"in_reply_to":"ff570b3c_7d9c2c6a","updated":"2020-06-09 20:53:50.000000000","message":"Yup, added them.","commit_id":"b76523daac4bff578c2ef93b0138d3b1bc18e11e"}],"specs/victoria/address-groups-support-in-security-group-rule.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"225fab6d4f9aad2b7b58f10fe017125df69dda09","unresolved":false,"context_lines":[{"line_number":66,"context_line":"|                   |         |       |      | An example of addresses:              |"},{"line_number":67,"context_line":"|                   |         |       |      | [\"132.168.4.12/24\",                   |"},{"line_number":68,"context_line":"|                   |         |       |      | \"132.168.5.12-132.168.5.24\",          |"},{"line_number":69,"context_line":"|                   |         |       |      | \"2001::db8::f00/64\"]                  |"},{"line_number":70,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"|"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_4620019c","line":69,"range":{"start_line":69,"start_character":47,"end_line":69,"end_character":66},"updated":"2020-06-23 08:45:55.000000000","message":"should we mixed IPv4 and IPv6 in one group? Maybe better would be to have groups only with one type of addresses?","commit_id":"cdabbe3b5ecf061af17b92f615d02379c9164043"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"661abc4d2fc2d42b46bb6bf3e26ce4f1d840c6db","unresolved":false,"context_lines":[{"line_number":66,"context_line":"|                   |         |       |      | An example of addresses:              |"},{"line_number":67,"context_line":"|                   |         |       |      | [\"132.168.4.12/24\",                   |"},{"line_number":68,"context_line":"|                   |         |       |      | \"132.168.5.12-132.168.5.24\",          |"},{"line_number":69,"context_line":"|                   |         |       |      | \"2001::db8::f00/64\"]                  |"},{"line_number":70,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"|"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_39952734","line":69,"range":{"start_line":69,"start_character":47,"end_line":69,"end_character":66},"in_reply_to":"bf51134e_4620019c","updated":"2020-06-23 15:13:08.000000000","message":"I prefer to let one address group can hold both v4 and v6 addresses, which is similar to a port and easy to use. The logic to distinguish v4 and v6 addresses can easily be done on the server-side.","commit_id":"cdabbe3b5ecf061af17b92f615d02379c9164043"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"225fab6d4f9aad2b7b58f10fe017125df69dda09","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                \"protocol\": null,"},{"line_number":474,"context_line":"                \"remote_group_id\": null,"},{"line_number":475,"context_line":"                \"remote_ip_prefix\": null,"},{"line_number":476,"context_line":"                \"remote_address_group_id\": \"8722e0e0-9cc9-4490-9660-8c9a5732fbb0\","},{"line_number":477,"context_line":"                \"security_group_id\": \"85cc3048-abc3-43cc-89b3-377341426ac5\","},{"line_number":478,"context_line":"                \"project_id\": \"e4f50856753b4dc6afee5fa6b9b6c550\","},{"line_number":479,"context_line":"                \"revision_number\": 1,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_0678c98d","line":476,"updated":"2020-06-23 08:45:55.000000000","message":"so, how it will work if ethertype is IPv4 and You will have IPv6 addresses in the address group?","commit_id":"cdabbe3b5ecf061af17b92f615d02379c9164043"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"661abc4d2fc2d42b46bb6bf3e26ce4f1d840c6db","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                \"protocol\": null,"},{"line_number":474,"context_line":"                \"remote_group_id\": null,"},{"line_number":475,"context_line":"                \"remote_ip_prefix\": null,"},{"line_number":476,"context_line":"                \"remote_address_group_id\": \"8722e0e0-9cc9-4490-9660-8c9a5732fbb0\","},{"line_number":477,"context_line":"                \"security_group_id\": \"85cc3048-abc3-43cc-89b3-377341426ac5\","},{"line_number":478,"context_line":"                \"project_id\": \"e4f50856753b4dc6afee5fa6b9b6c550\","},{"line_number":479,"context_line":"                \"revision_number\": 1,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_19d8231c","line":476,"in_reply_to":"bf51134e_0678c98d","updated":"2020-06-23 15:13:08.000000000","message":"The behavior should be similar to using a remote-security-group in the rule. When the remote security group is bond with ports with both v4 and v6 addresses, the rule will only be applied to the addresses matching with the rule\u0027s ethertype. The logic will be handled on server-side.","commit_id":"cdabbe3b5ecf061af17b92f615d02379c9164043"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"225fab6d4f9aad2b7b58f10fe017125df69dda09","unresolved":false,"context_lines":[{"line_number":612,"context_line":"| description       | String  | No    | CRU  | Human readable description for the     |"},{"line_number":613,"context_line":"|                   |         |       |      | address group (255 characters limit).  |"},{"line_number":614,"context_line":"+-------------------+---------+-------+------+----------------------------------------+"},{"line_number":615,"context_line":"| project_id        | uuid-str| Yes   | CR   | Owner of the address group. Only       |"},{"line_number":616,"context_line":"|                   |         |       |      | admin users can specify a project      |"},{"line_number":617,"context_line":"|                   |         |       |      | identifier other than their own.       |"},{"line_number":618,"context_line":"+-------------------+---------+-------+------+----------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_6668a5b8","line":615,"range":{"start_line":615,"start_character":2,"end_line":615,"end_character":12},"updated":"2020-06-23 08:45:55.000000000","message":"it\u0027s not for this spec and RFE but IMO it would be good to add RBAC support for that in the future.","commit_id":"cdabbe3b5ecf061af17b92f615d02379c9164043"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"661abc4d2fc2d42b46bb6bf3e26ce4f1d840c6db","unresolved":false,"context_lines":[{"line_number":612,"context_line":"| description       | String  | No    | CRU  | Human readable description for the     |"},{"line_number":613,"context_line":"|                   |         |       |      | address group (255 characters limit).  |"},{"line_number":614,"context_line":"+-------------------+---------+-------+------+----------------------------------------+"},{"line_number":615,"context_line":"| project_id        | uuid-str| Yes   | CR   | Owner of the address group. Only       |"},{"line_number":616,"context_line":"|                   |         |       |      | admin users can specify a project      |"},{"line_number":617,"context_line":"|                   |         |       |      | identifier other than their own.       |"},{"line_number":618,"context_line":"+-------------------+---------+-------+------+----------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_f9ed6fb7","line":615,"range":{"start_line":615,"start_character":2,"end_line":615,"end_character":12},"in_reply_to":"bf51134e_6668a5b8","updated":"2020-06-23 15:13:08.000000000","message":"Yes, that\u0027s in my plan as well. I added RBAC to the work items list.","commit_id":"cdabbe3b5ecf061af17b92f615d02379c9164043"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"225fab6d4f9aad2b7b58f10fe017125df69dda09","unresolved":false,"context_lines":[{"line_number":670,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"Tempest Tests"},{"line_number":673,"context_line":"--------------"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"* DB mixin and schema tests"},{"line_number":676,"context_line":"* Tempest tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_069d69bb","line":673,"range":{"start_line":673,"start_character":13,"end_line":673,"end_character":14},"updated":"2020-06-23 08:45:55.000000000","message":"nitty nit: not needed :)","commit_id":"cdabbe3b5ecf061af17b92f615d02379c9164043"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"661abc4d2fc2d42b46bb6bf3e26ce4f1d840c6db","unresolved":false,"context_lines":[{"line_number":670,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"Tempest Tests"},{"line_number":673,"context_line":"--------------"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"* DB mixin and schema tests"},{"line_number":676,"context_line":"* Tempest tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_3931a75b","line":673,"range":{"start_line":673,"start_character":13,"end_line":673,"end_character":14},"in_reply_to":"bf51134e_069d69bb","updated":"2020-06-23 15:13:08.000000000","message":"Done","commit_id":"cdabbe3b5ecf061af17b92f615d02379c9164043"}]}