)]}'
{"specs/ussuri/shared-qos-bandwidth-limit.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"in some situations, administrator may want to limit the total bandwidth"},{"line_number":18,"context_line":"of vm. In other words, if vm has several nics, and administrator want to"},{"line_number":19,"context_line":"limit the total bandwidth of those nics. This proposal talks about"},{"line_number":20,"context_line":"providing an new qos policy rule(shared-qos-bandwidth-limit) to implement"},{"line_number":21,"context_line":"the feature describe above. The implementation described is limited to only"},{"line_number":22,"context_line":"the OVS back-end and to Linux Bridge back-end."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_c91cc015","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":12},"updated":"2020-05-04 07:09:29.000000000","message":"nit: I think it should be \"a\" here","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed Change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"We will add an new qos rule tupe called shared_bandwidth_limit to support this feature."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* shared_bandwidth_limit type rule are incompatible with other rules, if Qos Policy include an"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_c9ca006d","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":32},"updated":"2020-05-04 07:09:29.000000000","message":"s/type","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"We will add an new qos rule tupe called shared_bandwidth_limit to support this feature."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* shared_bandwidth_limit type rule are incompatible with other rules, if Qos Policy include an"},{"line_number":31,"context_line":"  shared_bandwidth_limit rule, it can not has other type qos rule any more."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Qos Policy(include shared_bandwidth_limit) can only be associated to nics(belong to the same vm). devcie_id of ports will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_49a430ba","line":30,"range":{"start_line":30,"start_character":73,"end_line":30,"end_character":76},"updated":"2020-05-04 07:09:29.000000000","message":"nitty nit: s/QoS","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* shared_bandwidth_limit type rule are incompatible with other rules, if Qos Policy include an"},{"line_number":31,"context_line":"  shared_bandwidth_limit rule, it can not has other type qos rule any more."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Qos Policy(include shared_bandwidth_limit) can only be associated to nics(belong to the same vm). devcie_id of ports will"},{"line_number":34,"context_line":"  be checked before associating."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_e9925c58","line":31,"updated":"2020-05-04 07:09:29.000000000","message":"why it can\u0027t have e.g. dscp marking rules?","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"* shared_bandwidth_limit type rule are incompatible with other rules, if Qos Policy include an"},{"line_number":31,"context_line":"  shared_bandwidth_limit rule, it can not has other type qos rule any more."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Qos Policy(include shared_bandwidth_limit) can only be associated to nics(belong to the same vm). devcie_id of ports will"},{"line_number":34,"context_line":"  be checked before associating."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Qos Policy(include shared_bandwidth_limit type rule) can be associagted to ports(unbound), but device_id will be checked when"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_099a286d","line":33,"range":{"start_line":33,"start_character":100,"end_line":33,"end_character":109},"updated":"2020-05-04 07:09:29.000000000","message":"device_id","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  shared_bandwidth_limit rule, it can not has other type qos rule any more."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Qos Policy(include shared_bandwidth_limit) can only be associated to nics(belong to the same vm). devcie_id of ports will"},{"line_number":34,"context_line":"  be checked before associating."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Qos Policy(include shared_bandwidth_limit type rule) can be associagted to ports(unbound), but device_id will be checked when"},{"line_number":37,"context_line":"  assocaiting the port to an vm."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_498d5030","line":34,"updated":"2020-05-04 07:09:29.000000000","message":"what if user will want to detach port from vm and maybe later attach it to the other VM?","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* Qos Policy(include shared_bandwidth_limit) can only be associated to nics(belong to the same vm). devcie_id of ports will"},{"line_number":34,"context_line":"  be checked before associating."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Qos Policy(include shared_bandwidth_limit type rule) can be associagted to ports(unbound), but device_id will be checked when"},{"line_number":37,"context_line":"  assocaiting the port to an vm."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_a98214ff","line":36,"range":{"start_line":36,"start_character":62,"end_line":36,"end_character":73},"updated":"2020-05-04 07:09:29.000000000","message":"s/associated","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  be checked before associating."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Qos Policy(include shared_bandwidth_limit type rule) can be associagted to ports(unbound), but device_id will be checked when"},{"line_number":37,"context_line":"  assocaiting the port to an vm."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We propose an update to the QoS API and OVS driver/ Linux Bridge Driver to support share qos bandwidth limit."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_89875810","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":13},"updated":"2020-05-04 07:09:29.000000000","message":"s/associating","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Data Model Impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":"The model follows the way that the QoS Bandwidth Limiting functionality applies"},{"line_number":46,"context_line":"to QoS policies by adding a \t table."},{"line_number":47,"context_line":"The QosSharedBandwidthLimitRule model would look like:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"+--------------+-------+----------+---------+-----------------+------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_0973484f","line":46,"range":{"start_line":46,"start_character":27,"end_line":46,"end_character":30},"updated":"2020-05-04 07:09:29.000000000","message":"tab - please remove it","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"REST calls::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        GET /v2.0/qos/policies"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        Response:"},{"line_number":114,"context_line":"        {"},{"line_number":115,"context_line":"            \"policy\": {"},{"line_number":116,"context_line":"                \"name\": \"Shared-Qos-Test\","},{"line_number":117,"context_line":"                \"description\": \"This policy test share qos rule\","},{"line_number":118,"context_line":"                \"shared\": \"False\""},{"line_number":119,"context_line":"             }"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        GET /v2.0/qos/policies/\u003cpolicy-uuid\u003e"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        Response:"},{"line_number":125,"context_line":"        {"},{"line_number":126,"context_line":"            \"policy\": {"},{"line_number":127,"context_line":"                \"tenant_id\": \"\u003ctenant-id\u003e\","},{"line_number":128,"context_line":"                \"id\": \"\u003cid\u003e\","},{"line_number":129,"context_line":"                \"name\": \"Shared-Qos-Test\","},{"line_number":130,"context_line":"                \"description\": \"This policy test share qos rule\","},{"line_number":131,"context_line":"                \"shared\": False,"},{"line_number":132,"context_line":"                \"rules\": ["},{"line_number":133,"context_line":"                    {"},{"line_number":134,"context_line":"                        \"direction\": \"ingress\","},{"line_number":135,"context_line":"                        \"id\": \"\u003ctenant-id\u003e\","},{"line_number":136,"context_line":"                        \"max_burst_kbps\": 1024,"},{"line_number":137,"context_line":"                        \"max_kbps\": 1024000,"},{"line_number":138,"context_line":"                        \"qos_policy_id\": \"\u003cpolicy-uuid\u003e\","},{"line_number":139,"context_line":"                        \"type\": \"shared_bandwidth_limit\""},{"line_number":140,"context_line":"                    }],"},{"line_number":141,"context_line":"             }"},{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":"        POST /v2.0/qos/policies/\u003cpolicy-uuid\u003e/shared_bandwidth_limit-rules/"},{"line_number":144,"context_line":"        {"},{"line_number":145,"context_line":"            \"shared_bandwidth_limit_rule\":"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_e9c9bc5a","line":142,"range":{"start_line":111,"start_character":0,"end_line":142,"end_character":9},"updated":"2020-05-04 07:09:29.000000000","message":"I don\u0027t think that those calls are really related to this spec directly. It is something which we already have implemented.","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":231,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":232,"context_line":"To implement shared_bandwidth_limit_rule, the following steps are required:"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"* Create a `IFB`_ for shared_bandwidth_limit_rule type policy."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* if port has been associated to shared_bandwidth_limit_rule type policy, Send"},{"line_number":237,"context_line":"  all traffic (ingress or egress) to this IFB, mirroring it, using a TC rule."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_a98174c6","line":234,"updated":"2020-05-04 07:09:29.000000000","message":"in case of openvswitch firewall driver tap- port is internal ovs port. Will it work fine with such IFB device also? Or do we need to limit this feature to iptables_hybrid firewall driver?","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"Dependencies"},{"line_number":267,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":268,"context_line":"* Creating shared_bandwidth_limit_rule values"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_69048c7f","line":265,"updated":"2020-05-04 07:09:29.000000000","message":"I don\u0027t think that so many empty lines are needed here.","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eb78ab7e1ca71e25905d52624f7666d74bee4d1f","unresolved":false,"context_lines":[{"line_number":290,"context_line":"* Updating QoS policy and checking again the values."},{"line_number":291,"context_line":"* Deleting QoS policy and verifying all the values related to the rule are"},{"line_number":292,"context_line":"  deleted."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"Documentation Impact"},{"line_number":296,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_69292cf1","line":293,"updated":"2020-05-04 07:09:29.000000000","message":"what about some scenario test. Do You think it\u0027s doable to do something what will be reliable?","commit_id":"5cabca104e83cbdd7587632e77483c0738e331ea"}]}