)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"dcdf09eebb1e4bc7b3b0e3ef1bba47f2a712e6dc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Source and destination filtering for metering label rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib29af56fcb5c1ee3174f2acd3aa5cdf1ddf6591f"},{"line_number":10,"context_line":"Implements: https://blueprints.launchpad.net/neutron/+spec/local-ip-prefix-in-metering-rules"},{"line_number":11,"context_line":"RFE: https://bugs.launchpad.net/neutron/+bug/1889431"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_5f4e6396","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":92},"updated":"2020-08-17 06:49:38.000000000","message":"nit: blueprint local-ip-prefix-in-metering-rules","commit_id":"916399653bd9b3c9f4ea033d274025c43cb1705a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5e4ee96ab14d7d368300d5c2edb6bd03a83441b4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Source and destination filtering for metering label rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib29af56fcb5c1ee3174f2acd3aa5cdf1ddf6591f"},{"line_number":10,"context_line":"Implements: https://blueprints.launchpad.net/neutron/+spec/local-ip-prefix-in-metering-rules"},{"line_number":11,"context_line":"RFE: https://bugs.launchpad.net/neutron/+bug/1889431"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_281c17c0","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":92},"in_reply_to":"9f560f44_5f4e6396","updated":"2020-08-17 10:41:12.000000000","message":"Done","commit_id":"916399653bd9b3c9f4ea033d274025c43cb1705a"}],"specs/victoria/source-and-destination-metering-label-rules.rst":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a7e7b307bf45597d3ce87d0a8992c0810d68eeae","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The \"source_ip_prefix\" and \"destination_ip_prefix\" could be used together, or"},{"line_number":38,"context_line":"only one of them can be defined. However, a metering rule must always have at"},{"line_number":39,"context_line":"least one of them (local_ip_prefix or remote_ip_prefix) defined. On the other"},{"line_number":40,"context_line":"hand, these two new parameters will not be allowed to be used in conjunction"},{"line_number":41,"context_line":"with \"remote_ip_prefix\"."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_5f1b5f71","line":39,"range":{"start_line":39,"start_character":19,"end_line":39,"end_character":54},"updated":"2020-08-07 19:33:11.000000000","message":"shouldn\u0027t be \"source_ip_prefix\" and \"destination_ip_prefix\" here?","commit_id":"563767cc67d8e1a9812b347cd0289ef7f5010193"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d4ef9a115c9b74ae0f21a7542872449281fe5ec0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The \"source_ip_prefix\" and \"destination_ip_prefix\" could be used together, or"},{"line_number":38,"context_line":"only one of them can be defined. However, a metering rule must always have at"},{"line_number":39,"context_line":"least one of them (local_ip_prefix or remote_ip_prefix) defined. On the other"},{"line_number":40,"context_line":"hand, these two new parameters will not be allowed to be used in conjunction"},{"line_number":41,"context_line":"with \"remote_ip_prefix\"."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_e3c8d955","line":39,"range":{"start_line":39,"start_character":19,"end_line":39,"end_character":54},"in_reply_to":"9f560f44_5f1b5f71","updated":"2020-08-10 02:06:38.000000000","message":"Done","commit_id":"563767cc67d8e1a9812b347cd0289ef7f5010193"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a7e7b307bf45597d3ce87d0a8992c0810d68eeae","unresolved":false,"context_lines":[{"line_number":59,"context_line":".. code-block:: json"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    {"},{"line_number":62,"context_line":"      \"remote_ip_prefix\": \"192.168.0.14/32\","},{"line_number":63,"context_line":"      \"source_ip_prefix\": \"192.168.0.14/32\","},{"line_number":64,"context_line":"      \"destination_ip_prefix\": \"0.0.0.0/0\","},{"line_number":65,"context_line":"      \"direction\": \"egress\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_bf239ba6","line":62,"range":{"start_line":62,"start_character":7,"end_line":62,"end_character":23},"updated":"2020-08-07 19:33:11.000000000","message":"I think tha the use of the remote_ip_prefix in that case is denied, so I think that this field should be removed from this example.","commit_id":"563767cc67d8e1a9812b347cd0289ef7f5010193"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d4ef9a115c9b74ae0f21a7542872449281fe5ec0","unresolved":false,"context_lines":[{"line_number":59,"context_line":".. code-block:: json"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    {"},{"line_number":62,"context_line":"      \"remote_ip_prefix\": \"192.168.0.14/32\","},{"line_number":63,"context_line":"      \"source_ip_prefix\": \"192.168.0.14/32\","},{"line_number":64,"context_line":"      \"destination_ip_prefix\": \"0.0.0.0/0\","},{"line_number":65,"context_line":"      \"direction\": \"egress\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_23bf71aa","line":62,"range":{"start_line":62,"start_character":7,"end_line":62,"end_character":23},"in_reply_to":"9f560f44_bf239ba6","updated":"2020-08-10 02:06:38.000000000","message":"Done","commit_id":"563767cc67d8e1a9812b347cd0289ef7f5010193"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a7e7b307bf45597d3ce87d0a8992c0810d68eeae","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    | id                    | varchar(36)              | NO   | PRI | NULL    |       |"},{"line_number":96,"context_line":"    | direction             | enum(\u0027ingress\u0027,\u0027egress\u0027) | YES  |     | NULL    |       |"},{"line_number":97,"context_line":"    | remote_ip_prefix      | varchar(64)              | YES  |     | NULL    |       |"},{"line_number":98,"context_line":"    | local_ip_prefix       | varchar(64)              | YES  |     | NULL    |       |"},{"line_number":99,"context_line":"    | source_ip_prefix      | varchar(64)              | YES  |     | NULL    |       |"},{"line_number":100,"context_line":"    | destination_ip_prefix | varchar(64)              | YES  |     | NULL    |       |"},{"line_number":101,"context_line":"    | metering_label_id     | varchar(36)              | NO   | MUL | NULL    |       |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_7f890373","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":21},"updated":"2020-08-07 19:33:11.000000000","message":"local_ip_prefix? I thought that will be added only the source/destination_ip_prefix, right?","commit_id":"563767cc67d8e1a9812b347cd0289ef7f5010193"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d4ef9a115c9b74ae0f21a7542872449281fe5ec0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    | id                    | varchar(36)              | NO   | PRI | NULL    |       |"},{"line_number":96,"context_line":"    | direction             | enum(\u0027ingress\u0027,\u0027egress\u0027) | YES  |     | NULL    |       |"},{"line_number":97,"context_line":"    | remote_ip_prefix      | varchar(64)              | YES  |     | NULL    |       |"},{"line_number":98,"context_line":"    | local_ip_prefix       | varchar(64)              | YES  |     | NULL    |       |"},{"line_number":99,"context_line":"    | source_ip_prefix      | varchar(64)              | YES  |     | NULL    |       |"},{"line_number":100,"context_line":"    | destination_ip_prefix | varchar(64)              | YES  |     | NULL    |       |"},{"line_number":101,"context_line":"    | metering_label_id     | varchar(36)              | NO   | MUL | NULL    |       |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_63e209d7","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":21},"in_reply_to":"9f560f44_7f890373","updated":"2020-08-10 02:06:38.000000000","message":"Done","commit_id":"563767cc67d8e1a9812b347cd0289ef7f5010193"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"dcdf09eebb1e4bc7b3b0e3ef1bba47f2a712e6dc","unresolved":false,"context_lines":[{"line_number":59,"context_line":".. code-block:: json"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    {"},{"line_number":62,"context_line":"      \"source_ip_prefix\": \"192.168.0.14/32\","},{"line_number":63,"context_line":"      \"destination_ip_prefix\": \"0.0.0.0/0\","},{"line_number":64,"context_line":"      \"direction\": \"egress\","},{"line_number":65,"context_line":"      \"metering_label_id\": \"9ffd6512-9d2a-4dd2-9657-6a605126264d\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_9f163b55","line":62,"range":{"start_line":62,"start_character":6,"end_line":62,"end_character":43},"updated":"2020-08-17 06:49:38.000000000","message":"If current remote_ip_prefix actually means source ip prefix, then here I expected to see 0.0.0.0/0 to comply with #50. Is my understanding correct?","commit_id":"916399653bd9b3c9f4ea033d274025c43cb1705a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"5e4ee96ab14d7d368300d5c2edb6bd03a83441b4","unresolved":false,"context_lines":[{"line_number":59,"context_line":".. code-block:: json"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    {"},{"line_number":62,"context_line":"      \"source_ip_prefix\": \"192.168.0.14/32\","},{"line_number":63,"context_line":"      \"destination_ip_prefix\": \"0.0.0.0/0\","},{"line_number":64,"context_line":"      \"direction\": \"egress\","},{"line_number":65,"context_line":"      \"metering_label_id\": \"9ffd6512-9d2a-4dd2-9657-6a605126264d\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_083e7328","line":62,"range":{"start_line":62,"start_character":6,"end_line":62,"end_character":43},"in_reply_to":"9f560f44_9f163b55","updated":"2020-08-17 10:41:12.000000000","message":"No. This is an egrees rule. Therefore, it should be the opposite. The source_ip_prefix must be the IP that is generating the request inside OpenStack, and the destination IP must be the target IP.","commit_id":"916399653bd9b3c9f4ea033d274025c43cb1705a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"026769f93405c566d3dd49ff277689bbe9e30c2b","unresolved":false,"context_lines":[{"line_number":47,"context_line":".. code-block:: json"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    {"},{"line_number":50,"context_line":"      \"remote_ip_prefix\": \"0.0.0.0/0\","},{"line_number":51,"context_line":"      \"direction\": \"egress\","},{"line_number":52,"context_line":"      \"metering_label_id\": \"9ffd6512-9d2a-4dd2-9657-6a605126264d\","},{"line_number":53,"context_line":"      \"id\": \"f1694467-d866-4d8e-a8dc-18da516caedc\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f560f44_088833c4","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":36},"updated":"2020-08-17 10:55:47.000000000","message":"\"Instead of matching on the remote prefix (towards the external interface), it matches the local prefix (towards the OpenStack tenant networks).\" - should this rather be 192.168.0.14/32 here to reflect what problem description says? Sorry for me being dumb if I didn\u0027t get it right again :)","commit_id":"83db457086ef17e2df4f9c2fa2caa34df0a2d345"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"80ae9e5f15b0b9ce5de98a21a3774f5eb5244b02","unresolved":false,"context_lines":[{"line_number":47,"context_line":".. code-block:: json"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    {"},{"line_number":50,"context_line":"      \"remote_ip_prefix\": \"0.0.0.0/0\","},{"line_number":51,"context_line":"      \"direction\": \"egress\","},{"line_number":52,"context_line":"      \"metering_label_id\": \"9ffd6512-9d2a-4dd2-9657-6a605126264d\","},{"line_number":53,"context_line":"      \"id\": \"f1694467-d866-4d8e-a8dc-18da516caedc\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f560f44_c86c7b0a","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":36},"in_reply_to":"9f560f44_088833c4","updated":"2020-08-17 10:59:30.000000000","message":"Ah, ok, you want to show how to convert from the current model to the newly proposed one. If that is the case, yes.\n\nI was not paying much attention to the content of the examples here. I will fix it.","commit_id":"83db457086ef17e2df4f9c2fa2caa34df0a2d345"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"1e11fad0c0339ae461bb35cc07218db4be870d31","unresolved":false,"context_lines":[{"line_number":47,"context_line":".. code-block:: json"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    {"},{"line_number":50,"context_line":"      \"remote_ip_prefix\": \"0.0.0.0/0\","},{"line_number":51,"context_line":"      \"direction\": \"egress\","},{"line_number":52,"context_line":"      \"metering_label_id\": \"9ffd6512-9d2a-4dd2-9657-6a605126264d\","},{"line_number":53,"context_line":"      \"id\": \"f1694467-d866-4d8e-a8dc-18da516caedc\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f560f44_59803b8c","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":36},"in_reply_to":"9f560f44_13dce472","updated":"2020-08-17 14:00:53.000000000","message":"\u003e Yeah, otherwise it\u0027s a bit confusing. Thanks!\n\nThanks for your review!","commit_id":"83db457086ef17e2df4f9c2fa2caa34df0a2d345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f8d131895e4c535fecb1d9a566993074bb015e0d","unresolved":false,"context_lines":[{"line_number":47,"context_line":".. code-block:: json"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    {"},{"line_number":50,"context_line":"      \"remote_ip_prefix\": \"0.0.0.0/0\","},{"line_number":51,"context_line":"      \"direction\": \"egress\","},{"line_number":52,"context_line":"      \"metering_label_id\": \"9ffd6512-9d2a-4dd2-9657-6a605126264d\","},{"line_number":53,"context_line":"      \"id\": \"f1694467-d866-4d8e-a8dc-18da516caedc\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f560f44_13dce472","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":36},"in_reply_to":"9f560f44_c86c7b0a","updated":"2020-08-17 11:17:46.000000000","message":"Yeah, otherwise it\u0027s a bit confusing. Thanks!","commit_id":"83db457086ef17e2df4f9c2fa2caa34df0a2d345"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"30aa9846ab2dee008a17ca950f71ca30e562fd32","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    | excluded          | tinyint(1)               | YES  |     | 0       |       |"},{"line_number":85,"context_line":"    +-------------------+--------------------------+------+-----+---------+-------+"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"We would add a new field to it. Therefore, it would look like:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. code-block:: bash"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f560f44_cdcb561b","line":87,"range":{"start_line":87,"start_character":13,"end_line":87,"end_character":14},"updated":"2020-08-26 07:00:56.000000000","message":"nit 2/two new fields","commit_id":"933c7fbd2caac9c0c4ef7b547e95b0b78be74c6b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e81011832d3a2f02f5dc21f50d75ed4d697b5864","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    | excluded          | tinyint(1)               | YES  |     | 0       |       |"},{"line_number":85,"context_line":"    +-------------------+--------------------------+------+-----+---------+-------+"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"We would add a new field to it. Therefore, it would look like:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. code-block:: bash"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f560f44_2fd92282","line":87,"range":{"start_line":87,"start_character":13,"end_line":87,"end_character":14},"in_reply_to":"9f560f44_cdcb561b","updated":"2020-08-26 12:02:02.000000000","message":"Done","commit_id":"933c7fbd2caac9c0c4ef7b547e95b0b78be74c6b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"30aa9846ab2dee008a17ca950f71ca30e562fd32","unresolved":false,"context_lines":[{"line_number":133,"context_line":"-----------"},{"line_number":134,"context_line":"Two new parameters will be introduced, but they are not required."},{"line_number":135,"context_line":"Therefore, people using it would not suffer an immediate impact."},{"line_number":136,"context_line":"However, when the \"remote_ip_prefix\" is removed. Then, people might"},{"line_number":137,"context_line":"have a problem. therefore, as soon as the new method of building rules"},{"line_number":138,"context_line":"is available, people will be encouraged to use it, instead of the"},{"line_number":139,"context_line":"\"remote_ip_prefix\" metering rule base."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f560f44_edf1fa6c","line":136,"range":{"start_line":136,"start_character":47,"end_line":136,"end_character":53},"updated":"2020-08-26 07:00:56.000000000","message":"nit: , then","commit_id":"933c7fbd2caac9c0c4ef7b547e95b0b78be74c6b"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e81011832d3a2f02f5dc21f50d75ed4d697b5864","unresolved":false,"context_lines":[{"line_number":133,"context_line":"-----------"},{"line_number":134,"context_line":"Two new parameters will be introduced, but they are not required."},{"line_number":135,"context_line":"Therefore, people using it would not suffer an immediate impact."},{"line_number":136,"context_line":"However, when the \"remote_ip_prefix\" is removed. Then, people might"},{"line_number":137,"context_line":"have a problem. therefore, as soon as the new method of building rules"},{"line_number":138,"context_line":"is available, people will be encouraged to use it, instead of the"},{"line_number":139,"context_line":"\"remote_ip_prefix\" metering rule base."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f560f44_afd6d24d","line":136,"range":{"start_line":136,"start_character":47,"end_line":136,"end_character":53},"in_reply_to":"9f560f44_edf1fa6c","updated":"2020-08-26 12:02:02.000000000","message":"Done","commit_id":"933c7fbd2caac9c0c4ef7b547e95b0b78be74c6b"}]}