)]}'
{"specs/wallaby/bfd_support.rst":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) is used to detect link failures"},{"line_number":20,"context_line":"between routers."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"BFD can be used to provide quick, low-overhead link failure detection between"},{"line_number":23,"context_line":"adjacent forwarding engines [1]_:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e44c1ed7_030c4955","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":15},"updated":"2020-12-16 15:40:37.000000000","message":"between a Neutron router and an arbitrary destination (which of course is likely a non-Neutron router)","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) is used to detect link failures"},{"line_number":20,"context_line":"between routers."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"BFD can be used to provide quick, low-overhead link failure detection between"},{"line_number":23,"context_line":"adjacent forwarding engines [1]_:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"918829da_74f80062","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":15},"in_reply_to":"e44c1ed7_030c4955","updated":"2021-01-05 16:52:41.000000000","message":"Done","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The goal of this spec is to add API to manage bfd_monitor instances, fetch"},{"line_number":42,"context_line":"their status, associate a monitor to an extra route or assign it to a"},{"line_number":43,"context_line":"bgp_peer."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"This gives possibility to the operators to monitor the routes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8ba7d8df_5a3418d0","line":42,"range":{"start_line":42,"start_character":55,"end_line":42,"end_character":61},"updated":"2020-12-16 15:40:37.000000000","message":"You use different words, but is there a difference between \u0027associate\u0027 and \u0027assign\u0027 here?","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The goal of this spec is to add API to manage bfd_monitor instances, fetch"},{"line_number":42,"context_line":"their status, associate a monitor to an extra route or assign it to a"},{"line_number":43,"context_line":"bgp_peer."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"This gives possibility to the operators to monitor the routes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4eea299c_d8d40ad5","line":42,"range":{"start_line":42,"start_character":55,"end_line":42,"end_character":61},"in_reply_to":"8ba7d8df_5a3418d0","updated":"2021-01-05 16:52:41.000000000","message":"I used as synonims, but You are right, better to use assign everywhere","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":79,"context_line":"                          \\____dst4"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"* 2 different moitor for the same destination-nexthop pair in case of HA"},{"line_number":83,"context_line":"  router setup"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"+------+----------+------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bb129054_f40fa4a6","line":82,"range":{"start_line":82,"start_character":14,"end_line":82,"end_character":20},"updated":"2020-12-16 15:40:37.000000000","message":"typo: monitors","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                          \\____dst4"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"* 2 different moitor for the same destination-nexthop pair in case of HA"},{"line_number":83,"context_line":"  router setup"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"+------+----------+------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2ff134b8_5410d6e1","line":82,"range":{"start_line":82,"start_character":14,"end_line":82,"end_character":20},"in_reply_to":"bb129054_f40fa4a6","updated":"2021-01-05 16:52:41.000000000","message":"Done","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":160,"context_line":"| description       | String  | No    | CRU  | Human readable description for the    |"},{"line_number":161,"context_line":"|                   |         |       |      | bfd_monitor (255 characters limit).   |"},{"line_number":162,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":163,"context_line":"| project_id        | uuid-str| No    | CR   | Owner of the bfd_monitor.             |"},{"line_number":164,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":165,"context_line":"| mode              | String  | No    | CR   | Can be ``asynchronous`` (default      |"},{"line_number":166,"context_line":"|                   |         |       |      | common echo mode of BFD) or           |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fecebed4_9330a6ce","line":163,"range":{"start_line":163,"start_character":2,"end_line":163,"end_character":12},"updated":"2020-12-16 15:40:37.000000000","message":"Do we need this? Do we want a bfd_monitor that\u0027s owned by somebody else, not the router\u0027s owner?","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":160,"context_line":"| description       | String  | No    | CRU  | Human readable description for the    |"},{"line_number":161,"context_line":"|                   |         |       |      | bfd_monitor (255 characters limit).   |"},{"line_number":162,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":163,"context_line":"| project_id        | uuid-str| No    | CR   | Owner of the bfd_monitor.             |"},{"line_number":164,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":165,"context_line":"| mode              | String  | No    | CR   | Can be ``asynchronous`` (default      |"},{"line_number":166,"context_line":"|                   |         |       |      | common echo mode of BFD) or           |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5923a5cd_77114c00","line":163,"range":{"start_line":163,"start_character":2,"end_line":163,"end_character":12},"in_reply_to":"fecebed4_9330a6ce","updated":"2021-01-05 16:52:41.000000000","message":"You are right this is a read-only field for the monitor, not sure If I have to list it here, I can remove it.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":173,"context_line":"|                   |         |       |      | and accepts future types.             |"},{"line_number":174,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":175,"context_line":"| dst_ip            | String  | No    | CR   | The destination IP address to be      |"},{"line_number":176,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"},{"line_number":177,"context_line":"|                   |         |       |      | this is the nexthop ip of the route.  |"},{"line_number":178,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":179,"context_line":"| src_ip            | String  | N/A   | R    | IP address used as source for         |"},{"line_number":180,"context_line":"|                   |         |       |      | transmitted BFD packets. A read only  |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"72955b2f_fdff9132","line":177,"range":{"start_line":176,"start_character":58,"end_line":177,"end_character":83},"updated":"2020-12-16 15:40:37.000000000","message":"That\u0027s what makes sense of course. Do you want to enforve it? It\u0027s technically possible for the singlehop case, but not in general. In the generic case (including multihop BFD) from the APIs point of view this is an arbitrary IP, right?","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":173,"context_line":"|                   |         |       |      | and accepts future types.             |"},{"line_number":174,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":175,"context_line":"| dst_ip            | String  | No    | CR   | The destination IP address to be      |"},{"line_number":176,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"},{"line_number":177,"context_line":"|                   |         |       |      | this is the nexthop ip of the route.  |"},{"line_number":178,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":179,"context_line":"| src_ip            | String  | N/A   | R    | IP address used as source for         |"},{"line_number":180,"context_line":"|                   |         |       |      | transmitted BFD packets. A read only  |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"beb1c91b_95e04b28","line":177,"range":{"start_line":176,"start_character":58,"end_line":177,"end_character":83},"in_reply_to":"72955b2f_fdff9132","updated":"2021-01-05 16:52:41.000000000","message":"I added a line to make it clear that multihop is different here.\nYeah perhaps better to enforce it, like if type is singlehop dst_ip is read-only or similar, and will be filled after assignment to an extra_route for example.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":177,"context_line":"|                   |         |       |      | this is the nexthop ip of the route.  |"},{"line_number":178,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":179,"context_line":"| src_ip            | String  | N/A   | R    | IP address used as source for         |"},{"line_number":180,"context_line":"|                   |         |       |      | transmitted BFD packets. A read only  |"},{"line_number":181,"context_line":"|                   |         |       |      | field that practically shows the IP   |"},{"line_number":182,"context_line":"|                   |         |       |      | set on the interface, like on on      |"},{"line_number":183,"context_line":"|                   |         |       |      | qg-xyz.                               |"},{"line_number":184,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":185,"context_line":"| min_rx            | Integer | Yes   | CRU  | The shortest interval, in millisecs,  |"},{"line_number":186,"context_line":"|                   |         |       |      | at which this  BFD  session offers to |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d938217e_5fee3649","line":183,"range":{"start_line":180,"start_character":72,"end_line":183,"end_character":54},"updated":"2020-12-16 15:40:37.000000000","message":"And its purpose is to expose the IP selected by neutron to the admin, so he/she can configure it at the other end.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":177,"context_line":"|                   |         |       |      | this is the nexthop ip of the route.  |"},{"line_number":178,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":179,"context_line":"| src_ip            | String  | N/A   | R    | IP address used as source for         |"},{"line_number":180,"context_line":"|                   |         |       |      | transmitted BFD packets. A read only  |"},{"line_number":181,"context_line":"|                   |         |       |      | field that practically shows the IP   |"},{"line_number":182,"context_line":"|                   |         |       |      | set on the interface, like on on      |"},{"line_number":183,"context_line":"|                   |         |       |      | qg-xyz.                               |"},{"line_number":184,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":185,"context_line":"| min_rx            | Integer | Yes   | CRU  | The shortest interval, in millisecs,  |"},{"line_number":186,"context_line":"|                   |         |       |      | at which this  BFD  session offers to |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dc800a4b_db4cc7ee","line":183,"range":{"start_line":180,"start_character":72,"end_line":183,"end_character":54},"in_reply_to":"d938217e_5fee3649","updated":"2021-01-05 16:52:41.000000000","message":"Done","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":203,"context_line":"|                   |         |       |      | monitoring will only start (the       |"},{"line_number":204,"context_line":"|                   |         |       |      | backend eactions will take place) when|"},{"line_number":205,"context_line":"|                   |         |       |      | the bfd_monitor is attached to a      |"},{"line_number":206,"context_line":"|                   |         |       |      | specific route.                       |"},{"line_number":207,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Show bfd_monitor status (For details see [1]_, State Variables section)::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"47b69619_359b80be","line":206,"updated":"2020-12-16 15:40:37.000000000","message":"The purpose is to detect collisions between bfd monitors as early as possible.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":203,"context_line":"|                   |         |       |      | monitoring will only start (the       |"},{"line_number":204,"context_line":"|                   |         |       |      | backend eactions will take place) when|"},{"line_number":205,"context_line":"|                   |         |       |      | the bfd_monitor is attached to a      |"},{"line_number":206,"context_line":"|                   |         |       |      | specific route.                       |"},{"line_number":207,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Show bfd_monitor status (For details see [1]_, State Variables section)::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"785e6092_1ab2579a","line":206,"in_reply_to":"47b69619_359b80be","updated":"2021-01-05 16:52:41.000000000","message":"Done","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":204,"context_line":"|                   |         |       |      | backend eactions will take place) when|"},{"line_number":205,"context_line":"|                   |         |       |      | the bfd_monitor is attached to a      |"},{"line_number":206,"context_line":"|                   |         |       |      | specific route.                       |"},{"line_number":207,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Show bfd_monitor status (For details see [1]_, State Variables section)::"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"86aedd20_48fbcba9","line":207,"updated":"2020-12-16 15:40:37.000000000","message":"IMO we will need the usual \u0027status\u0027 field here, to know if the monitor was deployed in the backend.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":204,"context_line":"|                   |         |       |      | backend eactions will take place) when|"},{"line_number":205,"context_line":"|                   |         |       |      | the bfd_monitor is attached to a      |"},{"line_number":206,"context_line":"|                   |         |       |      | specific route.                       |"},{"line_number":207,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Show bfd_monitor status (For details see [1]_, State Variables section)::"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d487c9ef_c36a967b","line":207,"in_reply_to":"86aedd20_48fbcba9","updated":"2021-01-05 16:52:41.000000000","message":"Done","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Show bfd_monitor status (For details see [1]_, State Variables section)::"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/monitor_status"},{"line_number":212,"context_line":"        {"},{"line_number":213,"context_line":"            \"bfd_monitor_status\": {"},{"line_number":214,"context_line":"                \"SessionState\": \"Init, Up, Down, or AdminDown\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"b4ccaa13_170ca135","line":211,"range":{"start_line":211,"start_character":44,"end_line":211,"end_character":58},"updated":"2020-12-16 15:40:37.000000000","message":"To distinguish this from the monitor\u0027s status, let\u0027s call this differently, like session_status.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Show bfd_monitor status (For details see [1]_, State Variables section)::"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/monitor_status"},{"line_number":212,"context_line":"        {"},{"line_number":213,"context_line":"            \"bfd_monitor_status\": {"},{"line_number":214,"context_line":"                \"SessionState\": \"Init, Up, Down, or AdminDown\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"42df9d28_7e0c55e2","line":211,"range":{"start_line":211,"start_character":44,"end_line":211,"end_character":58},"in_reply_to":"b4ccaa13_170ca135","updated":"2021-01-05 16:52:41.000000000","message":"Right, session_status is much better","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/monitor_status"},{"line_number":212,"context_line":"        {"},{"line_number":213,"context_line":"            \"bfd_monitor_status\": {"},{"line_number":214,"context_line":"                \"SessionState\": \"Init, Up, Down, or AdminDown\","},{"line_number":215,"context_line":"                \"RemoteSessionState\": \"\","},{"line_number":216,"context_line":"                \"LocalDiscr\": \"\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"2d4afa25_2e9e2c0c","line":213,"range":{"start_line":213,"start_character":17,"end_line":213,"end_character":31},"updated":"2020-12-16 15:40:37.000000000","message":"here too","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/monitor_status"},{"line_number":212,"context_line":"        {"},{"line_number":213,"context_line":"            \"bfd_monitor_status\": {"},{"line_number":214,"context_line":"                \"SessionState\": \"Init, Up, Down, or AdminDown\","},{"line_number":215,"context_line":"                \"RemoteSessionState\": \"\","},{"line_number":216,"context_line":"                \"LocalDiscr\": \"\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"40ea688c_d981b918","line":213,"range":{"start_line":213,"start_character":17,"end_line":213,"end_character":31},"in_reply_to":"2d4afa25_2e9e2c0c","updated":"2021-01-05 16:52:41.000000000","message":"Done","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/monitor_status"},{"line_number":212,"context_line":"        {"},{"line_number":213,"context_line":"            \"bfd_monitor_status\": {"},{"line_number":214,"context_line":"                \"SessionState\": \"Init, Up, Down, or AdminDown\","},{"line_number":215,"context_line":"                \"RemoteSessionState\": \"\","},{"line_number":216,"context_line":"                \"LocalDiscr\": \"\","},{"line_number":217,"context_line":"                \"RemoteDiscr\": ,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a23766ff_03ef5b6c","line":214,"range":{"start_line":214,"start_character":52,"end_line":214,"end_character":61},"updated":"2020-12-16 15:40:37.000000000","message":"I guess we don\u0027t expose this at moment. I\u0027m not saying we should, but it maybe worth mentioning that it\u0027s not. You can always just delete the monitor instead.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/monitor_status"},{"line_number":212,"context_line":"        {"},{"line_number":213,"context_line":"            \"bfd_monitor_status\": {"},{"line_number":214,"context_line":"                \"SessionState\": \"Init, Up, Down, or AdminDown\","},{"line_number":215,"context_line":"                \"RemoteSessionState\": \"\","},{"line_number":216,"context_line":"                \"LocalDiscr\": \"\","},{"line_number":217,"context_line":"                \"RemoteDiscr\": ,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"19ce17c9_16ef400f","line":214,"range":{"start_line":214,"start_character":52,"end_line":214,"end_character":61},"in_reply_to":"a23766ff_03ef5b6c","updated":"2021-01-05 16:52:41.000000000","message":"yeah, do not overcomplicate it.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                \"RcvAuthSeq\": \"\","},{"line_number":228,"context_line":"                \"XmitAuthSeq\": \"\","},{"line_number":229,"context_line":"                \"AuthSeqKnown\": \"\","},{"line_number":230,"context_line":"                \"router\": {"},{"line_number":231,"context_line":"                    \"id\": {router_id},"},{"line_number":232,"context_line":"                    \"route\": {"},{"line_number":233,"context_line":"                        \"destination\": \"10.0.3.0/24\","},{"line_number":234,"context_line":"                        \"nexthop\": \"10.0.0.1\""},{"line_number":235,"context_line":"                    }"},{"line_number":236,"context_line":"                },"},{"line_number":237,"context_line":"                \"bgp_speaker\": {"},{"line_number":238,"context_line":"                    \"id\": {bgp_speaker_id},"},{"line_number":239,"context_line":"                    \"routes\": ["},{"line_number":240,"context_line":"                        {\"cidr\": \"\", \"nexthop\": \"\"},"},{"line_number":241,"context_line":"                    ]"},{"line_number":242,"context_line":"                }"},{"line_number":243,"context_line":"            }"},{"line_number":244,"context_line":"        }"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5c7c100f_be3f755a","line":242,"range":{"start_line":230,"start_character":0,"end_line":242,"end_character":17},"updated":"2020-12-16 15:40:37.000000000","message":"This seems a bit convoluted.\n\nIMO we can separate 3 things:\n\n1) the extraroute we monitor\n2) the bgp peer we monitor\n3) the router we monitor from\n\n3) should be always present. But at any time we can only monitor either 1) or 2), never both.\n\nAlso the current data structure is not friendly to machine processing.\n\nSo what about something like this?\n\n \"bfd_monitor_status\": {\n     ...\n     \"router\": {...},\n     \"remote\": {\n         \"type\": \"extra_route|bgp_peer\",\n         \"extra_route\": {...}, # but only that key is present, that was in \"type\"\n         \"bgp_peer\": {...},\n     },","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                \"RcvAuthSeq\": \"\","},{"line_number":228,"context_line":"                \"XmitAuthSeq\": \"\","},{"line_number":229,"context_line":"                \"AuthSeqKnown\": \"\","},{"line_number":230,"context_line":"                \"router\": {"},{"line_number":231,"context_line":"                    \"id\": {router_id},"},{"line_number":232,"context_line":"                    \"route\": {"},{"line_number":233,"context_line":"                        \"destination\": \"10.0.3.0/24\","},{"line_number":234,"context_line":"                        \"nexthop\": \"10.0.0.1\""},{"line_number":235,"context_line":"                    }"},{"line_number":236,"context_line":"                },"},{"line_number":237,"context_line":"                \"bgp_speaker\": {"},{"line_number":238,"context_line":"                    \"id\": {bgp_speaker_id},"},{"line_number":239,"context_line":"                    \"routes\": ["},{"line_number":240,"context_line":"                        {\"cidr\": \"\", \"nexthop\": \"\"},"},{"line_number":241,"context_line":"                    ]"},{"line_number":242,"context_line":"                }"},{"line_number":243,"context_line":"            }"},{"line_number":244,"context_line":"        }"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"eab4ff0b_13e42353","line":242,"range":{"start_line":230,"start_character":0,"end_line":242,"end_character":17},"in_reply_to":"5c7c100f_be3f755a","updated":"2021-01-05 16:52:41.000000000","message":"yeah this part was really a quick draft, thanks, it can work as I see.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":277,"context_line":"        {"},{"line_number":278,"context_line":"            \"router\": {"},{"line_number":279,"context_line":"                \"routes\": ["},{"line_number":280,"context_line":"                    { \"destination\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"bfd_monitor_status\": \"UP\" },"},{"line_number":281,"context_line":"                ]"},{"line_number":282,"context_line":"            }"},{"line_number":283,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1c94c3dd_e5fbfc78","line":280,"range":{"start_line":280,"start_character":79,"end_line":280,"end_character":97},"updated":"2020-12-16 15:40:37.000000000","message":"I would suggest to explicitly detach this status from bfd. We could think about the route being alive or not (status: UP/DOWN), and bfd monitoring being one possible source that drives this status/liveness.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":277,"context_line":"        {"},{"line_number":278,"context_line":"            \"router\": {"},{"line_number":279,"context_line":"                \"routes\": ["},{"line_number":280,"context_line":"                    { \"destination\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"bfd_monitor_status\": \"UP\" },"},{"line_number":281,"context_line":"                ]"},{"line_number":282,"context_line":"            }"},{"line_number":283,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":2,"id":"77f9b9fd_1d630aac","line":280,"range":{"start_line":280,"start_character":79,"end_line":280,"end_character":97},"in_reply_to":"1c94c3dd_e5fbfc78","updated":"2021-01-05 16:52:41.000000000","message":"True, that makes the API more resilient","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":288,"context_line":"overload or affect ordinary router API operations."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"The routes_status API endpoint gives feedback to the user if the bfd_monitor"},{"line_number":291,"context_line":"was succesfully created at the backend for the given route and if the"},{"line_number":292,"context_line":"monitored link is up."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"If the bfd_monitor_status is DOWN the given route should be removed in the"},{"line_number":295,"context_line":"backend (on the command line: ip r delete....), and set back if the monitor"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d63f1437_8454e464","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":21},"updated":"2020-12-16 15:40:37.000000000","message":"As written above, let\u0027s keep these two concepts separate.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":288,"context_line":"overload or affect ordinary router API operations."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"The routes_status API endpoint gives feedback to the user if the bfd_monitor"},{"line_number":291,"context_line":"was succesfully created at the backend for the given route and if the"},{"line_number":292,"context_line":"monitored link is up."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"If the bfd_monitor_status is DOWN the given route should be removed in the"},{"line_number":295,"context_line":"backend (on the command line: ip r delete....), and set back if the monitor"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c59b8db4_48cf6dae","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":21},"in_reply_to":"d63f1437_8454e464","updated":"2021-01-05 16:52:41.000000000","message":"Done","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"A common way from switch vendors (I checked Cisco, Juniper and Extreme,"},{"line_number":299,"context_line":"see [4]_, [5]_, [6]_) to add options to the bgp peer creation to enable and"},{"line_number":300,"context_line":"set BFD as well, and in case BFD detects link failure BGP can change the"},{"line_number":301,"context_line":"routing accordingly."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":304,"context_line":"associated with the given extra route, and it is deleted in the backend when"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8dd5952c_e66ff6ef","line":301,"range":{"start_line":300,"start_character":58,"end_line":301,"end_character":20},"updated":"2020-12-16 15:40:37.000000000","message":"I did not look into this yet, but doesn\u0027t this change the routes advertised?","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"A common way from switch vendors (I checked Cisco, Juniper and Extreme,"},{"line_number":299,"context_line":"see [4]_, [5]_, [6]_) to add options to the bgp peer creation to enable and"},{"line_number":300,"context_line":"set BFD as well, and in case BFD detects link failure BGP can change the"},{"line_number":301,"context_line":"routing accordingly."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":304,"context_line":"associated with the given extra route, and it is deleted in the backend when"}],"source_content_type":"text/x-rst","patch_set":2,"id":"013ab465_2b9d3276","line":301,"range":{"start_line":300,"start_character":58,"end_line":301,"end_character":20},"in_reply_to":"8dd5952c_e66ff6ef","updated":"2021-01-05 16:52:41.000000000","message":"I have to check this in detail","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":301,"context_line":"routing accordingly."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":304,"context_line":"associated with the given extra route, and it is deleted in the backend when"},{"line_number":305,"context_line":"the extra route updated to have the bfd_monitor association removed."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Changes to bgp_peer API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0c2b7cf2_0dc0e5f7","line":304,"range":{"start_line":304,"start_character":11,"end_line":304,"end_character":37},"updated":"2020-12-16 15:40:37.000000000","message":"with any route (be that static extra route or dynamic bgp route)","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":301,"context_line":"routing accordingly."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":304,"context_line":"associated with the given extra route, and it is deleted in the backend when"},{"line_number":305,"context_line":"the extra route updated to have the bfd_monitor association removed."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Changes to bgp_peer API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"384b8257_49ae2074","line":304,"range":{"start_line":304,"start_character":11,"end_line":304,"end_character":37},"in_reply_to":"0c2b7cf2_0dc0e5f7","updated":"2021-01-05 16:52:41.000000000","message":"Done","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":316,"context_line":"              \"remote_as\":\"1001\","},{"line_number":317,"context_line":"              \"name\":\"bgp-peer\","},{"line_number":318,"context_line":"              \"peer_ip\":\"10.0.0.3\","},{"line_number":319,"context_line":"              \"bfd_monitor\": {bfd_monitor_uuid}"},{"line_number":320,"context_line":"           }"},{"line_number":321,"context_line":"        }"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"c7fb654f_f7ca01dc","line":319,"range":{"start_line":319,"start_character":15,"end_line":319,"end_character":26},"updated":"2020-12-16 15:40:37.000000000","message":"I didn\u0027t yet think through the bgp use case at all, but don\u0027t we need to associate a monitor with one particular route instead if the peer (to which we advertise multiple routes)?","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":316,"context_line":"              \"remote_as\":\"1001\","},{"line_number":317,"context_line":"              \"name\":\"bgp-peer\","},{"line_number":318,"context_line":"              \"peer_ip\":\"10.0.0.3\","},{"line_number":319,"context_line":"              \"bfd_monitor\": {bfd_monitor_uuid}"},{"line_number":320,"context_line":"           }"},{"line_number":321,"context_line":"        }"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6c3573af_320cc8ae","line":319,"range":{"start_line":319,"start_character":15,"end_line":319,"end_character":26},"in_reply_to":"c7fb654f_f7ca01dc","updated":"2021-01-05 16:52:41.000000000","message":"I have to check that","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":332,"context_line":"        {"},{"line_number":333,"context_line":"            \"routes_status\": {"},{"line_number":334,"context_line":"                \"routes\": ["},{"line_number":335,"context_line":"                    { \"cidr\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"bfd_monitor_status\": \"UP\" },"},{"line_number":336,"context_line":"                ]"},{"line_number":337,"context_line":"            }"},{"line_number":338,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ef75a77d_4b773de3","line":335,"range":{"start_line":335,"start_character":72,"end_line":335,"end_character":90},"updated":"2020-12-16 15:40:37.000000000","message":"I\u0027d suggest the same separation as above. Plus I\u0027m wondering if this could be meaningfully incorporated into the list-advertised-routes API query.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        {"},{"line_number":333,"context_line":"            \"routes_status\": {"},{"line_number":334,"context_line":"                \"routes\": ["},{"line_number":335,"context_line":"                    { \"cidr\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"bfd_monitor_status\": \"UP\" },"},{"line_number":336,"context_line":"                ]"},{"line_number":337,"context_line":"            }"},{"line_number":338,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3c5ea608_eaa33dd5","line":335,"range":{"start_line":335,"start_character":72,"end_line":335,"end_character":90},"in_reply_to":"ef75a77d_4b773de3","updated":"2021-01-05 16:52:41.000000000","message":"Done\nMy idea was to make the API \"symetric\":\nGET routes_status\nGET advertised_routes_status\n\nbut I think about it","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":382,"context_line":"      In case the ``type:multihop`` is used for the bfd_monitor this can be"},{"line_number":383,"context_line":"      considered."},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"          * alternative: in case of OVS backend reject multihop BFD and give"},{"line_number":386,"context_line":"            background to the user in documentation."},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"* OVS supports only ``asynchronous`` mode where the endpoints exchange BFD"}],"source_content_type":"text/x-rst","patch_set":2,"id":"56cdfba0_8298d8b8","line":385,"range":{"start_line":385,"start_character":48,"end_line":385,"end_character":67},"updated":"2020-12-16 15:40:37.000000000","message":"I think 501 Unimplemented is perfect here.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":382,"context_line":"      In case the ``type:multihop`` is used for the bfd_monitor this can be"},{"line_number":383,"context_line":"      considered."},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"          * alternative: in case of OVS backend reject multihop BFD and give"},{"line_number":386,"context_line":"            background to the user in documentation."},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"* OVS supports only ``asynchronous`` mode where the endpoints exchange BFD"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7c63113d_acbf0fe6","line":385,"range":{"start_line":385,"start_character":48,"end_line":385,"end_character":67},"in_reply_to":"56cdfba0_8298d8b8","updated":"2021-01-05 16:52:41.000000000","message":"there is a suggestion for http405 as well, I have to check neutron API status codes","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e5c1a1b4bad8b142a93c1cd466997bb73875b0d1","unresolved":true,"context_lines":[{"line_number":395,"context_line":"neutron-dynamic-routing and QUAGGA limitations"},{"line_number":396,"context_line":"++++++++++++++++++++++++++++++++++++++++++++++"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"As neutron-dynamic-routing uses QUAGGA (see [7]_) as backend, and QUAGGA has"},{"line_number":399,"context_line":"no support for BFD, this dynamism (to make the routes changed based on BFD"},{"line_number":400,"context_line":"status) is not straigth-forward."},{"line_number":401,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"42394ad3_d9b7a37e","line":398,"range":{"start_line":398,"start_character":3,"end_line":398,"end_character":60},"updated":"2020-12-16 15:40:37.000000000","message":"I remember having an os-ken driver, and no quagga/zebra driver.","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"43ad4c5ed3bf9a1b9682ebb712e9a0885acdfb30","unresolved":true,"context_lines":[{"line_number":395,"context_line":"neutron-dynamic-routing and QUAGGA limitations"},{"line_number":396,"context_line":"++++++++++++++++++++++++++++++++++++++++++++++"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"As neutron-dynamic-routing uses QUAGGA (see [7]_) as backend, and QUAGGA has"},{"line_number":399,"context_line":"no support for BFD, this dynamism (to make the routes changed based on BFD"},{"line_number":400,"context_line":"status) is not straigth-forward."},{"line_number":401,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b3cd6523_9d0e87b4","line":398,"range":{"start_line":398,"start_character":3,"end_line":398,"end_character":60},"in_reply_to":"42394ad3_d9b7a37e","updated":"2021-01-05 16:52:41.000000000","message":"actually os-ken is the driver which gives the quagga/zebra API","commit_id":"5139a08704f37e1ead7d0841de5f053582c7127f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0e2de52a953b473538ab6f8558965a73c0297b53","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  based on link status."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    This spec is not covering other usecases like tunnel monitoring and HA or"},{"line_number":36,"context_line":"    DVR router monitoring."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9bd2884c_8a056af7","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":2},"updated":"2021-01-06 06:54:02.000000000","message":"This can be a note section, not code block or chart, use \n\n.. note:: \n\ninstead.","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"429678906b87a10e5be25c66d0970e3a7ca8f07f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  based on link status."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    This spec is not covering other usecases like tunnel monitoring and HA or"},{"line_number":36,"context_line":"    DVR router monitoring."}],"source_content_type":"text/x-rst","patch_set":4,"id":"e631ac69_b9b4121b","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":2},"in_reply_to":"9bd2884c_8a056af7","updated":"2021-01-06 14:32:55.000000000","message":"Done","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0e2de52a953b473538ab6f8558965a73c0297b53","unresolved":true,"context_lines":[{"line_number":61,"context_line":"::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"           ____nexthop1 ____"},{"line_number":64,"context_line":"        __/                 \\ ____dst1"},{"line_number":65,"context_line":"          \\____nexthop2____ /"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"264656fb_8e587214","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":11},"updated":"2021-01-06 06:54:02.000000000","message":"This convergence here looks not necessary.","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"429678906b87a10e5be25c66d0970e3a7ca8f07f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"           ____nexthop1 ____"},{"line_number":64,"context_line":"        __/                 \\ ____dst1"},{"line_number":65,"context_line":"          \\____nexthop2____ /"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d5edb639_56b4d9c4","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":11},"in_reply_to":"264656fb_8e587214","updated":"2021-01-06 14:32:55.000000000","message":"Done","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0e2de52a953b473538ab6f8558965a73c0297b53","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"           ____nexthop1 ____"},{"line_number":64,"context_line":"        __/                 \\ ____dst1"},{"line_number":65,"context_line":"          \\____nexthop2____ /"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* monitoring 2 different destinations through the same nexthop"}],"source_content_type":"text/x-rst","patch_set":4,"id":"151b5288_79fbe8fc","line":65,"range":{"start_line":65,"start_character":10,"end_line":65,"end_character":11},"updated":"2021-01-06 06:54:02.000000000","message":"This convergence here looks not necessary.","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"429678906b87a10e5be25c66d0970e3a7ca8f07f","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"           ____nexthop1 ____"},{"line_number":64,"context_line":"        __/                 \\ ____dst1"},{"line_number":65,"context_line":"          \\____nexthop2____ /"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* monitoring 2 different destinations through the same nexthop"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3316dd3e_7241b091","line":65,"range":{"start_line":65,"start_character":10,"end_line":65,"end_character":11},"in_reply_to":"151b5288_79fbe8fc","updated":"2021-01-06 14:32:55.000000000","message":"Done","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0e2de52a953b473538ab6f8558965a73c0297b53","unresolved":true,"context_lines":[{"line_number":361,"context_line":"Backend"},{"line_number":362,"context_line":"~~~~~~~"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"OVS is able to handle BFD, see [3]_, it\u0027s possible to set BFD on an"},{"line_number":365,"context_line":"interface, and check the status of it."},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"The manual process is something like this:"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":".. code-block:: bash"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        $ sudo ovs-vsctl set interface ens5 bfd:bfd_src_ip\u003d192.168.122.237 bfd:bfd_dst_ip\u003d192.168.122.57 bfd:enable\u003dtrue"},{"line_number":372,"context_line":"        $ #.... Do the same on the remote end ...."},{"line_number":373,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":374,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"OVS limitations"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4268e7b3_548c7d7b","line":374,"range":{"start_line":364,"start_character":0,"end_line":374,"end_character":169},"updated":"2021-01-06 06:54:02.000000000","message":"So L3 agent will run these commands?","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"429678906b87a10e5be25c66d0970e3a7ca8f07f","unresolved":true,"context_lines":[{"line_number":361,"context_line":"Backend"},{"line_number":362,"context_line":"~~~~~~~"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"OVS is able to handle BFD, see [3]_, it\u0027s possible to set BFD on an"},{"line_number":365,"context_line":"interface, and check the status of it."},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"The manual process is something like this:"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":".. code-block:: bash"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        $ sudo ovs-vsctl set interface ens5 bfd:bfd_src_ip\u003d192.168.122.237 bfd:bfd_dst_ip\u003d192.168.122.57 bfd:enable\u003dtrue"},{"line_number":372,"context_line":"        $ #.... Do the same on the remote end ...."},{"line_number":373,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":374,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"OVS limitations"}],"source_content_type":"text/x-rst","patch_set":4,"id":"477c98f9_cc003910","line":374,"range":{"start_line":364,"start_character":0,"end_line":374,"end_character":169},"in_reply_to":"4268e7b3_548c7d7b","updated":"2021-01-06 14:32:55.000000000","message":"I plan to use some native library (os-ken or ovsdbapp?) to manipulate ovsdb","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c87c6a5b3f37dd8b633ff7645488c4e62480bda","unresolved":true,"context_lines":[{"line_number":417,"context_line":"neutron-dynamic-routing and QUAGGA limitations"},{"line_number":418,"context_line":"++++++++++++++++++++++++++++++++++++++++++++++"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"As neutron-dynamic-routing uses QUAGGA (see [7]_) as backend, and QUAGGA has"},{"line_number":421,"context_line":"no support for BFD, this dynamism (to make the routes changed based on BFD"},{"line_number":422,"context_line":"status) is not straigth-forward."},{"line_number":423,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df8b632d_5a8bc889","line":420,"updated":"2021-01-05 19:35:38.000000000","message":"afaict n-d-r does not use quagga as a backend, but os-ken. This doesn\u0027t change the fact that there is not BFD support. I also don\u0027t see how BFD would come into action in this case, as the BGP sessions are usually happening on a network that is completely different from the networks to which the L3 routers are connected.\n\nUnless you have a specific use case and explain this in more detail, I\u0027d prefer to leave n-d-r out of this spec completely.","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"429678906b87a10e5be25c66d0970e3a7ca8f07f","unresolved":true,"context_lines":[{"line_number":417,"context_line":"neutron-dynamic-routing and QUAGGA limitations"},{"line_number":418,"context_line":"++++++++++++++++++++++++++++++++++++++++++++++"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"As neutron-dynamic-routing uses QUAGGA (see [7]_) as backend, and QUAGGA has"},{"line_number":421,"context_line":"no support for BFD, this dynamism (to make the routes changed based on BFD"},{"line_number":422,"context_line":"status) is not straigth-forward."},{"line_number":423,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"e5178058_ac58cee5","line":420,"in_reply_to":"df8b632d_5a8bc889","updated":"2021-01-06 14:32:55.000000000","message":"Thanks, I checked again os-ken and You are right, there is no zebra/quagga behind it in case of bgp, I will change this part.\n\nI come back to your question later.\nShort answer is that our use case is to make possible to assign BFD monitor to bgp peers with openstack API, like the switch vendors do (see the references 4-6 for cisco/juniper/extreme documentation)","commit_id":"6f7c4625b3f9406289f428c4195bcdd8dac162ae"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) is used to detect link failures"},{"line_number":20,"context_line":"between a Neutron router and an arbitrary destination, like and external"},{"line_number":21,"context_line":"non-Neutron router."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BFD can be used to provide quick, low-overhead link failure detection between"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3eb1c985_0eb52b22","line":20,"range":{"start_line":20,"start_character":60,"end_line":20,"end_character":72},"updated":"2021-01-07 02:53:21.000000000","message":"an external ?","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f9bf50c059d9a46cafc3359a79520433b7ccdae0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) is used to detect link failures"},{"line_number":20,"context_line":"between a Neutron router and an arbitrary destination, like and external"},{"line_number":21,"context_line":"non-Neutron router."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BFD can be used to provide quick, low-overhead link failure detection between"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2847e2b4_22231471","line":20,"range":{"start_line":20,"start_character":60,"end_line":20,"end_character":72},"in_reply_to":"3eb1c985_0eb52b22","updated":"2021-01-13 16:44:50.000000000","message":"Done","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. note::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    This spec is not covering other usecases like tunnel monitoring and HA or"},{"line_number":36,"context_line":"    DVR router monitoring."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"f66d8fb4_954f026d","line":35,"range":{"start_line":35,"start_character":36,"end_line":35,"end_character":44},"updated":"2021-01-07 02:53:21.000000000","message":"use cases? I\u0027m not sure because I\u0027m not a native English speaker.","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f9bf50c059d9a46cafc3359a79520433b7ccdae0","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. note::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    This spec is not covering other usecases like tunnel monitoring and HA or"},{"line_number":36,"context_line":"    DVR router monitoring."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"39820375_6a05d5db","line":35,"range":{"start_line":35,"start_character":36,"end_line":35,"end_character":44},"in_reply_to":"f66d8fb4_954f026d","updated":"2021-01-13 16:44:50.000000000","message":"Done","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    Only an unassociated bfd_monitor can be deleted."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":155,"context_line":"| Attribute         | Type    | Req   | CRUD | Description                           |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3b7c7907_3e01e97c","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":4},"updated":"2021-01-07 02:53:21.000000000","message":"Remove this spaces to move this line out of the code block.","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f9bf50c059d9a46cafc3359a79520433b7ccdae0","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    Only an unassociated bfd_monitor can be deleted."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":155,"context_line":"| Attribute         | Type    | Req   | CRUD | Description                           |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"479e35c4_6d419c98","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":4},"in_reply_to":"3b7c7907_3e01e97c","updated":"2021-01-13 16:44:50.000000000","message":"Done","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    Only an unassociated bfd_monitor can be deleted."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":155,"context_line":"| Attribute         | Type    | Req   | CRUD | Description                           |"},{"line_number":156,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":157,"context_line":"| name              | String  | No    | CRU  | Human readable name for the           |"},{"line_number":158,"context_line":"|                   |         |       |      | bfd_monitor (255 characters limit).   |"},{"line_number":159,"context_line":"|                   |         |       |      | Does not have to be unique.           |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4b7a0c61_73913049","line":156,"range":{"start_line":154,"start_character":0,"end_line":156,"end_character":86},"updated":"2021-01-07 02:53:21.000000000","message":"It\u0027s better to add some desciption for this table before this table header.","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f9bf50c059d9a46cafc3359a79520433b7ccdae0","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    Only an unassociated bfd_monitor can be deleted."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":155,"context_line":"| Attribute         | Type    | Req   | CRUD | Description                           |"},{"line_number":156,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":157,"context_line":"| name              | String  | No    | CRU  | Human readable name for the           |"},{"line_number":158,"context_line":"|                   |         |       |      | bfd_monitor (255 characters limit).   |"},{"line_number":159,"context_line":"|                   |         |       |      | Does not have to be unique.           |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6a968883_e31148c1","line":156,"range":{"start_line":154,"start_character":0,"end_line":156,"end_character":86},"in_reply_to":"4b7a0c61_73913049","updated":"2021-01-13 16:44:50.000000000","message":"Done","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":223,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":224,"context_line":"        {"},{"line_number":225,"context_line":"            \"bfd_session_status\": {"},{"line_number":226,"context_line":"                \"SessionState\": \"Init, Up, Down\","},{"line_number":227,"context_line":"                \"RemoteSessionState\": \"\","},{"line_number":228,"context_line":"                \"LocalDiscr\": \"\","},{"line_number":229,"context_line":"                \"RemoteDiscr\": ,"},{"line_number":230,"context_line":"                \"LocalDiag\": \"\","},{"line_number":231,"context_line":"                \"RemoteDiag\": \"\","},{"line_number":232,"context_line":"                \"DesiredMinTxInterval\": \"\","},{"line_number":233,"context_line":"                \"RequiredMinRxInterval\": \"\","},{"line_number":234,"context_line":"                \"RemoteMinRxInterval\": \"\","},{"line_number":235,"context_line":"                \"DemandMode\": \"\","},{"line_number":236,"context_line":"                \"RemoteDemandMode\": \"\","},{"line_number":237,"context_line":"                \"DetectMult\": \"\","},{"line_number":238,"context_line":"                \"AuthType\": \"\","},{"line_number":239,"context_line":"                \"RcvAuthSeq\": \"\","},{"line_number":240,"context_line":"                \"XmitAuthSeq\": \"\","},{"line_number":241,"context_line":"                \"AuthSeqKnown\": \"\","},{"line_number":242,"context_line":"                \"router\": {router_id},"},{"line_number":243,"context_line":"                \"remote\": {"},{"line_number":244,"context_line":"                    \"type\": \"extra_route/bgp_peer\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"0323640e_454fcb1a","line":241,"range":{"start_line":226,"start_character":0,"end_line":241,"end_character":35},"updated":"2021-01-07 02:53:21.000000000","message":"Can we move these attributes to a next level block to make it a bit clear? Something like this:\n        {\n            \"bfd_session_status\": {\n            \"status\": {\"SessionState\": ...\n                       \"RemoteSessionState\": ...},\n\n            \"router\": {router_id},\n                \"remote\": {\n                    ...\n                    },\n                    \"bgp_peer\": {\n                      ...\n                    }\n                }\n            }\n        }\n\nand all these attribtues are needed for users?","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2ec108950e8a8e33a1de0beba5e0aeb97414911a","unresolved":true,"context_lines":[{"line_number":223,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":224,"context_line":"        {"},{"line_number":225,"context_line":"            \"bfd_session_status\": {"},{"line_number":226,"context_line":"                \"SessionState\": \"Init, Up, Down\","},{"line_number":227,"context_line":"                \"RemoteSessionState\": \"\","},{"line_number":228,"context_line":"                \"LocalDiscr\": \"\","},{"line_number":229,"context_line":"                \"RemoteDiscr\": ,"},{"line_number":230,"context_line":"                \"LocalDiag\": \"\","},{"line_number":231,"context_line":"                \"RemoteDiag\": \"\","},{"line_number":232,"context_line":"                \"DesiredMinTxInterval\": \"\","},{"line_number":233,"context_line":"                \"RequiredMinRxInterval\": \"\","},{"line_number":234,"context_line":"                \"RemoteMinRxInterval\": \"\","},{"line_number":235,"context_line":"                \"DemandMode\": \"\","},{"line_number":236,"context_line":"                \"RemoteDemandMode\": \"\","},{"line_number":237,"context_line":"                \"DetectMult\": \"\","},{"line_number":238,"context_line":"                \"AuthType\": \"\","},{"line_number":239,"context_line":"                \"RcvAuthSeq\": \"\","},{"line_number":240,"context_line":"                \"XmitAuthSeq\": \"\","},{"line_number":241,"context_line":"                \"AuthSeqKnown\": \"\","},{"line_number":242,"context_line":"                \"router\": {router_id},"},{"line_number":243,"context_line":"                \"remote\": {"},{"line_number":244,"context_line":"                    \"type\": \"extra_route/bgp_peer\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"6e3f36d1_b3a46aef","line":241,"range":{"start_line":226,"start_character":0,"end_line":241,"end_character":35},"in_reply_to":"0323640e_454fcb1a","updated":"2021-01-08 12:50:27.000000000","message":"thanks for the question/suggestion, yeah, that can work.\nRegarding which of these we need:\n\n* Option1 should be to put everything to the API extension what is defined in the RFC, even if the backend like ovs based implementation can\u0027t/doesn\u0027t show most of them. (see https://tools.ietf.org/html/rfc5880#section-6.8.1 )\n    * This can be good to make the API useful for all backends that implement it\n    * but perhaps confusing for users of backends where not all are available.\n\n* Option2 should be to say that the reference implementation will be OVS based, so the API should show only what ovs can show (see https://www.freebsd.org/cgi/man.cgi?query\u003dovs-vswitchd.conf.db\u0026apropos\u003d0\u0026sektion\u003d5\u0026manpath\u003dFreeBSD+Ports+9.0-RELEASE\u0026arch\u003ddefault\u0026format\u003dhtml look for BFD Status )\n\nI try to aggregate the 2 approach to have a minimum useful set of BFD status indicators on the API.","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f9bf50c059d9a46cafc3359a79520433b7ccdae0","unresolved":true,"context_lines":[{"line_number":223,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":224,"context_line":"        {"},{"line_number":225,"context_line":"            \"bfd_session_status\": {"},{"line_number":226,"context_line":"                \"SessionState\": \"Init, Up, Down\","},{"line_number":227,"context_line":"                \"RemoteSessionState\": \"\","},{"line_number":228,"context_line":"                \"LocalDiscr\": \"\","},{"line_number":229,"context_line":"                \"RemoteDiscr\": ,"},{"line_number":230,"context_line":"                \"LocalDiag\": \"\","},{"line_number":231,"context_line":"                \"RemoteDiag\": \"\","},{"line_number":232,"context_line":"                \"DesiredMinTxInterval\": \"\","},{"line_number":233,"context_line":"                \"RequiredMinRxInterval\": \"\","},{"line_number":234,"context_line":"                \"RemoteMinRxInterval\": \"\","},{"line_number":235,"context_line":"                \"DemandMode\": \"\","},{"line_number":236,"context_line":"                \"RemoteDemandMode\": \"\","},{"line_number":237,"context_line":"                \"DetectMult\": \"\","},{"line_number":238,"context_line":"                \"AuthType\": \"\","},{"line_number":239,"context_line":"                \"RcvAuthSeq\": \"\","},{"line_number":240,"context_line":"                \"XmitAuthSeq\": \"\","},{"line_number":241,"context_line":"                \"AuthSeqKnown\": \"\","},{"line_number":242,"context_line":"                \"router\": {router_id},"},{"line_number":243,"context_line":"                \"remote\": {"},{"line_number":244,"context_line":"                    \"type\": \"extra_route/bgp_peer\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"34e0058c_a26bd57d","line":241,"range":{"start_line":226,"start_character":0,"end_line":241,"end_character":35},"in_reply_to":"6e3f36d1_b3a46aef","updated":"2021-01-13 16:44:50.000000000","message":"Finally I mostly used the state variables from ovs","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":265,"context_line":"    appear."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Changes to Router API"},{"line_number":269,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"* Changes to Add extra routes to router or Update router::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"d6a78709_cc8053e0","line":268,"range":{"start_line":268,"start_character":11,"end_line":268,"end_character":21},"updated":"2021-01-07 02:53:21.000000000","message":"Router  extra routes API","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f9bf50c059d9a46cafc3359a79520433b7ccdae0","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    appear."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Changes to Router API"},{"line_number":269,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"* Changes to Add extra routes to router or Update router::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4e5a6029_509eabbe","line":268,"range":{"start_line":268,"start_character":11,"end_line":268,"end_character":21},"in_reply_to":"d6a78709_cc8053e0","updated":"2021-01-13 16:44:50.000000000","message":"Done","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":268,"context_line":"Changes to Router API"},{"line_number":269,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"* Changes to Add extra routes to router or Update router::"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        PUT /v2.0/routers/{router_id}"},{"line_number":274,"context_line":"        {"}],"source_content_type":"text/x-rst","patch_set":5,"id":"d7748cf1_69506b12","line":271,"range":{"start_line":271,"start_character":13,"end_line":271,"end_character":56},"updated":"2021-01-07 02:53:21.000000000","message":"Add or Update API","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f9bf50c059d9a46cafc3359a79520433b7ccdae0","unresolved":false,"context_lines":[{"line_number":268,"context_line":"Changes to Router API"},{"line_number":269,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"* Changes to Add extra routes to router or Update router::"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        PUT /v2.0/routers/{router_id}"},{"line_number":274,"context_line":"        {"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f9e04a66_ee326a33","line":271,"range":{"start_line":271,"start_character":13,"end_line":271,"end_character":56},"in_reply_to":"d7748cf1_69506b12","updated":"2021-01-13 16:44:50.000000000","message":"Done","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":316,"context_line":"backend (on the command line: ip r delete....), and set back if the monitor"},{"line_number":317,"context_line":"is UP again."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"A common way from switch vendors (I checked Cisco, Juniper and Extreme,"},{"line_number":320,"context_line":"see [4]_, [5]_, [6]_) to add options to the bgp peer creation to enable and"},{"line_number":321,"context_line":"set BFD as well, and in case BFD detects link failure BGP can change the"},{"line_number":322,"context_line":"routing accordingly."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1b8fd31c_117098ba","line":320,"range":{"start_line":319,"start_character":33,"end_line":320,"end_character":21},"updated":"2021-01-07 02:53:21.000000000","message":"Did you mean neutron need to control the physical devices?","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2ec108950e8a8e33a1de0beba5e0aeb97414911a","unresolved":true,"context_lines":[{"line_number":316,"context_line":"backend (on the command line: ip r delete....), and set back if the monitor"},{"line_number":317,"context_line":"is UP again."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"A common way from switch vendors (I checked Cisco, Juniper and Extreme,"},{"line_number":320,"context_line":"see [4]_, [5]_, [6]_) to add options to the bgp peer creation to enable and"},{"line_number":321,"context_line":"set BFD as well, and in case BFD detects link failure BGP can change the"},{"line_number":322,"context_line":"routing accordingly."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"c4990542_fed20a99","line":320,"range":{"start_line":319,"start_character":33,"end_line":320,"end_character":21},"in_reply_to":"1b8fd31c_117098ba","updated":"2021-01-08 12:50:27.000000000","message":"No. These are just examples which I checked to see how switch vendors handle BGP and BFD.","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":395,"context_line":"                            \\"},{"line_number":396,"context_line":"                             \\________ nexthopD"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    * Another possibility can be to add infrastructure interfaces for extra"},{"line_number":401,"context_line":"      bfd instances."}],"source_content_type":"text/x-rst","patch_set":5,"id":"8744ff0d_99afdb65","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":1},"updated":"2021-01-07 02:53:21.000000000","message":"Unknown period","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4be8af8e01c8b9193ed382bb151f8b5680a84bf9","unresolved":true,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    * Another possibility can be to add infrastructure interfaces for extra"},{"line_number":401,"context_line":"      bfd instances."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"      In case the ``type:multihop`` is used for the bfd_monitor this can be"},{"line_number":404,"context_line":"      considered."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"          * alternative: in case of OVS backend reject multihop BFD with"},{"line_number":407,"context_line":"            HTTP501 Not Implemented or HTTP405 Method Not Allowed and give"},{"line_number":408,"context_line":"            background to the user in documentation."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"* OVS supports only ``asynchronous`` mode where the endpoints exchange BFD"},{"line_number":411,"context_line":"  Hello packets."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    * Demand mode is a way to detect link aliveness not just with BFD Hello"},{"line_number":414,"context_line":"      packets. (OVS has a setting `forwarding_if_rx`, but that\u0027s not exactly"},{"line_number":415,"context_line":"      ``demand`` mode.)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"neutron-dynamic-routing and QUAGGA limitations"},{"line_number":418,"context_line":"++++++++++++++++++++++++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9df5314a_e9d768ff","line":415,"range":{"start_line":400,"start_character":0,"end_line":415,"end_character":23},"updated":"2021-01-07 02:53:21.000000000","message":"Accoriding to the final render of this doc [1], these blocks looks a bit strange.\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1eb/767337/5/check/openstack-tox-docs/1eb041c/docs/specs/wallaby/bfd_support.html","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f9bf50c059d9a46cafc3359a79520433b7ccdae0","unresolved":true,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    * Another possibility can be to add infrastructure interfaces for extra"},{"line_number":401,"context_line":"      bfd instances."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"      In case the ``type:multihop`` is used for the bfd_monitor this can be"},{"line_number":404,"context_line":"      considered."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"          * alternative: in case of OVS backend reject multihop BFD with"},{"line_number":407,"context_line":"            HTTP501 Not Implemented or HTTP405 Method Not Allowed and give"},{"line_number":408,"context_line":"            background to the user in documentation."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"* OVS supports only ``asynchronous`` mode where the endpoints exchange BFD"},{"line_number":411,"context_line":"  Hello packets."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    * Demand mode is a way to detect link aliveness not just with BFD Hello"},{"line_number":414,"context_line":"      packets. (OVS has a setting `forwarding_if_rx`, but that\u0027s not exactly"},{"line_number":415,"context_line":"      ``demand`` mode.)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"neutron-dynamic-routing and QUAGGA limitations"},{"line_number":418,"context_line":"++++++++++++++++++++++++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f1289fef_e6a126d3","line":415,"range":{"start_line":400,"start_character":0,"end_line":415,"end_character":23},"in_reply_to":"9df5314a_e9d768ff","updated":"2021-01-13 16:44:50.000000000","message":"It\u0027s better now, these indentations always play with me to have the correct rendering at the end","commit_id":"3ff9c0a22293579905c5cd2a735af3ba0d1aeb2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8c1381979cf1853b5eb84adad06dd0cb57679588","unresolved":true,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Changes to bgp_peer API"},{"line_number":352,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"* Create BGP Peer::"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        POST /v2.0/bgp-peers"}],"source_content_type":"text/x-rst","patch_set":6,"id":"073aa6d6_28fc2774","line":353,"updated":"2021-01-13 16:52:44.000000000","message":"Add detailed use case for BGP....","commit_id":"02786e25dad5d616e3df298eaf0ae0a6c1c70035"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"62ca1c84b89fd19cc7232e6fdfbbf264fd290c7d","unresolved":true,"context_lines":[{"line_number":367,"context_line":"The bfd_monitoring instance in the backend is created when the bgp_peer is"},{"line_number":368,"context_line":"associated to the bgp_speaker."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"The BFD session is created between the routers\u0027 north legs and the nexthops"},{"line_number":371,"context_line":"from the advertised_routes list as destinations."},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"* get advertised routes BFD status::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c6df1fd6_33701301","line":370,"updated":"2021-01-14 05:53:46.000000000","message":"This is nonsense, these two things are identical.","commit_id":"02786e25dad5d616e3df298eaf0ae0a6c1c70035"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0bcb77d9e3be85ed5d0282111a1e64b015e6cb19","unresolved":true,"context_lines":[{"line_number":518,"context_line":".. [3] https://www.freebsd.org/cgi/man.cgi?query\u003dovs-vswitchd.conf.db\u0026apropos\u003d0\u0026sektion\u003d5\u0026manpath\u003dFreeBSD+Ports+9.0-RELEASE\u0026arch\u003ddefault\u0026format\u003dhtml"},{"line_number":519,"context_line":".. [4] https://www.cisco.com/c/en/us/td/docs/ios/12_0s/feature/guide/fs_bfd.html#wp1153100"},{"line_number":520,"context_line":".. [5] https://www.juniper.net/documentation/en_US/junos/topics/topic-map/bfd-for-bgp-session.html"},{"line_number":521,"context_line":".. [6] https://gtacknowledge.extremenetworks.com/articles/How_To/How-to-enable-Bidirectional-Forwarding-Detection-BFD-protection-of-BGP-peering-sessions"}],"source_content_type":"text/x-rst","patch_set":6,"id":"73da55ef_17fe7675","line":521,"range":{"start_line":521,"start_character":7,"end_line":521,"end_character":152},"updated":"2021-01-15 07:43:53.000000000","message":"For some reason this link is not working ,I have to change it to this I think:\nhttps://extremeportal.force.com/ExtrArticleDetail?an\u003d000078861\u0026q\u003dHow-to-enable-Bidirectional-Forwarding-Detection-BFD-protection-of-BGP-peering-sessions","commit_id":"02786e25dad5d616e3df298eaf0ae0a6c1c70035"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) is used to detect link failures"},{"line_number":20,"context_line":"between a Neutron router and an arbitrary destination, like an external"},{"line_number":21,"context_line":"non-Neutron router."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"8ab3e376_b0560f4d","line":19,"range":{"start_line":19,"start_character":41,"end_line":19,"end_character":51},"updated":"2021-01-28 08:33:57.000000000","message":"Here should be \"can be used to\", since neutron does not support this for now.","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bdeefb8b32e3f00f916d9fcdc8c77a4f2f765bef","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) is used to detect link failures"},{"line_number":20,"context_line":"between a Neutron router and an arbitrary destination, like an external"},{"line_number":21,"context_line":"non-Neutron router."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"c1eafe5d_6b600d2b","line":19,"range":{"start_line":19,"start_character":41,"end_line":19,"end_character":51},"in_reply_to":"8ab3e376_b0560f4d","updated":"2021-01-29 16:49:39.000000000","message":"Done","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The goal of this spec is to add API to manage bfd_monitor instances, fetch"},{"line_number":39,"context_line":"their status, associate a monitor to an extra route."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"This gives possibility to the operators to monitor the routes"}],"source_content_type":"text/x-rst","patch_set":7,"id":"84c215ee_fe2fd886","line":38,"range":{"start_line":38,"start_character":32,"end_line":38,"end_character":35},"updated":"2021-01-28 08:33:57.000000000","message":"APIs","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bdeefb8b32e3f00f916d9fcdc8c77a4f2f765bef","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The goal of this spec is to add API to manage bfd_monitor instances, fetch"},{"line_number":39,"context_line":"their status, associate a monitor to an extra route."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"This gives possibility to the operators to monitor the routes"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a0f5b9d_6fe0aee0","line":38,"range":{"start_line":38,"start_character":32,"end_line":38,"end_character":35},"in_reply_to":"84c215ee_fe2fd886","updated":"2021-01-29 16:49:39.000000000","message":"Done","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"API fields and descriptions for bfd_monitor:"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":159,"context_line":"| Attribute         | Type    | Req   | CRUD | Description                           |"},{"line_number":160,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":161,"context_line":"| name              | String  | No    | CRU  | Human readable name for the           |"},{"line_number":162,"context_line":"|                   |         |       |      | bfd_monitor (255 characters limit).   |"},{"line_number":163,"context_line":"|                   |         |       |      | Does not have to be unique.           |"}],"source_content_type":"text/x-rst","patch_set":7,"id":"09b260b1_5c1c9359","line":160,"range":{"start_line":158,"start_character":0,"end_line":160,"end_character":21},"updated":"2021-01-28 08:33:57.000000000","message":"Where is the id of the bfd_monitor since the APIs you defined upper will use it?","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bdeefb8b32e3f00f916d9fcdc8c77a4f2f765bef","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"API fields and descriptions for bfd_monitor:"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":159,"context_line":"| Attribute         | Type    | Req   | CRUD | Description                           |"},{"line_number":160,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":161,"context_line":"| name              | String  | No    | CRU  | Human readable name for the           |"},{"line_number":162,"context_line":"|                   |         |       |      | bfd_monitor (255 characters limit).   |"},{"line_number":163,"context_line":"|                   |         |       |      | Does not have to be unique.           |"}],"source_content_type":"text/x-rst","patch_set":7,"id":"97121325_3a9661fa","line":160,"range":{"start_line":158,"start_character":0,"end_line":160,"end_character":21},"in_reply_to":"09b260b1_5c1c9359","updated":"2021-01-29 16:49:39.000000000","message":"Done","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":231,"context_line":"|                   |         |       |      | chain in which key is an integer of   |"},{"line_number":232,"context_line":"|                   |         |       |      | ``Auth Key ID`` and value is a string |"},{"line_number":233,"context_line":"|                   |         |       |      | of ``Password`` or ``Auth Key``.      |"},{"line_number":234,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Show bfd_monitor status (For details see rfc5880, State Variables section)::"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ea7f72e5_8b4f824e","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":86},"updated":"2021-01-28 08:33:57.000000000","message":"Maybe you can directly paste the extension RESOURCE_ATTRIBUTE_MAP difination here, so we can know the params status for it. For instance, the Agent API:\n\n\nRESOURCE_ATTRIBUTE_MAP \u003d {\n    COLLECTION_NAME: {\n        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n               \u0027validate\u0027: {\u0027type:uuid\u0027: None},\n               \u0027is_filter\u0027: True,\n               \u0027is_visible\u0027: True},\n        \u0027agent_type\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                       \u0027is_filter\u0027: True, \u0027is_visible\u0027: True},\n        \u0027binary\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                   \u0027is_filter\u0027: True, \u0027is_visible\u0027: True},\n        \u0027topic\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                  \u0027is_filter\u0027: True, \u0027is_visible\u0027: True},\n        \u0027host\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                 \u0027is_filter\u0027: True, \u0027is_visible\u0027: True},\n        \u0027admin_state_up\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: True,\n                           \u0027convert_to\u0027: converters.convert_to_boolean,\n                           \u0027is_filter\u0027: True,\n                           \u0027is_visible\u0027: True},\n        \u0027created_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                       \u0027is_visible\u0027: True},\n        \u0027started_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                       \u0027is_visible\u0027: True},\n        \u0027heartbeat_timestamp\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                                \u0027is_visible\u0027: True},\n        \u0027alive\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                  \u0027is_filter\u0027: True, \u0027is_visible\u0027: True},\n        \u0027configurations\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,\n                           \u0027is_visible\u0027: True},\n        \u0027description\u0027: {\n            \u0027allow_post\u0027: False, \u0027allow_put\u0027: True,\n            \u0027is_visible\u0027: True, \u0027is_filter\u0027: True,\n            \u0027validate\u0027: {\n                \u0027type:string_or_none\u0027: constants.DESCRIPTION_FIELD_SIZE}},\n    }\n}","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bdeefb8b32e3f00f916d9fcdc8c77a4f2f765bef","unresolved":true,"context_lines":[{"line_number":231,"context_line":"|                   |         |       |      | chain in which key is an integer of   |"},{"line_number":232,"context_line":"|                   |         |       |      | ``Auth Key ID`` and value is a string |"},{"line_number":233,"context_line":"|                   |         |       |      | of ``Password`` or ``Auth Key``.      |"},{"line_number":234,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Show bfd_monitor status (For details see rfc5880, State Variables section)::"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"f6f97777_97980635","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":86},"in_reply_to":"ea7f72e5_8b4f824e","updated":"2021-01-29 16:49:39.000000000","message":"I feared that it will be too noisy.","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":233,"context_line":"|                   |         |       |      | of ``Password`` or ``Auth Key``.      |"},{"line_number":234,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Show bfd_monitor status (For details see rfc5880, State Variables section)::"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":239,"context_line":"        {"},{"line_number":240,"context_line":"            \"bfd_session_status\": {"},{"line_number":241,"context_line":"                \"status\": {"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5122b544_ef412a76","line":238,"range":{"start_line":236,"start_character":0,"end_line":238,"end_character":58},"updated":"2021-01-28 08:33:57.000000000","message":"I\u0027m a bit confused about \"bfd_monitor status\" and \"session_status\". It\u0027s the same thing you mean here?","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bdeefb8b32e3f00f916d9fcdc8c77a4f2f765bef","unresolved":true,"context_lines":[{"line_number":233,"context_line":"|                   |         |       |      | of ``Password`` or ``Auth Key``.      |"},{"line_number":234,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Show bfd_monitor status (For details see rfc5880, State Variables section)::"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":239,"context_line":"        {"},{"line_number":240,"context_line":"            \"bfd_session_status\": {"},{"line_number":241,"context_line":"                \"status\": {"}],"source_content_type":"text/x-rst","patch_set":7,"id":"b3c855ae_cabb5888","line":238,"range":{"start_line":236,"start_character":0,"end_line":238,"end_character":58},"in_reply_to":"5122b544_ef412a76","updated":"2021-01-29 16:49:39.000000000","message":"Yeah for that I tried to add notes in the tables:\n\"status\": (see l218) that shows only if the bfd_monitor was created successfuly in the backend, so after POST bfd_monitor it will be DOWN, if you associate the monitor to an extra_route it will be UP.\n\n\"session_status\": for that another API endpoint is added as that can be quite expansive operation to collect the bfd session information.","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":297,"context_line":"|                    | is the discriminator chosen by the remote system.   |"},{"line_number":298,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":299,"context_line":"| Forwarding         | Reports whether the BFD session believes this       |"},{"line_number":300,"context_line":"|                    | Interface  may  be used  to forward traffic., it    |"},{"line_number":301,"context_line":"|                    | can be ``true`` or ``false``.                       |"},{"line_number":302,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"91620a17_a0b47e0f","line":300,"range":{"start_line":300,"start_character":66,"end_line":300,"end_character":68},"updated":"2021-01-28 08:33:57.000000000","message":"extra period?","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bdeefb8b32e3f00f916d9fcdc8c77a4f2f765bef","unresolved":false,"context_lines":[{"line_number":297,"context_line":"|                    | is the discriminator chosen by the remote system.   |"},{"line_number":298,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":299,"context_line":"| Forwarding         | Reports whether the BFD session believes this       |"},{"line_number":300,"context_line":"|                    | Interface  may  be used  to forward traffic., it    |"},{"line_number":301,"context_line":"|                    | can be ``true`` or ``false``.                       |"},{"line_number":302,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"af34384a_6a9e8fc5","line":300,"range":{"start_line":300,"start_character":66,"end_line":300,"end_character":68},"in_reply_to":"91620a17_a0b47e0f","updated":"2021-01-29 16:49:39.000000000","message":"Done","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"The manual process is something like this:"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":".. code-block:: bash"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        $ sudo ovs-vsctl set interface ens5 bfd:bfd_src_ip\u003d192.168.122.237 bfd:bfd_dst_ip\u003d192.168.122.57 bfd:enable\u003dtrue"},{"line_number":375,"context_line":"        $ #.... Do the same on the remote end ...."},{"line_number":376,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":377,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"os-ken can be used to to handle BFD (see [4]_ )."},{"line_number":380,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"6f01d3c5_9f803921","line":377,"range":{"start_line":372,"start_character":0,"end_line":377,"end_character":169},"updated":"2021-01-28 08:33:57.000000000","message":"This is a bit strange to me to control ovsdb in l3 agent.","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":377,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"os-ken can be used to to handle BFD (see [4]_ )."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"OVS limitations"},{"line_number":382,"context_line":"+++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"254b1969_a2f59763","line":379,"range":{"start_line":379,"start_character":0,"end_line":379,"end_character":13},"updated":"2021-01-28 08:33:57.000000000","message":"After some code investigation, IMO, the os_ken bfdlib can not be used to manipulate the ovs\u0027s bdf. The os_ken lib is a bfd \u0027server\u0027 which is used to be an endpoint for the bfd protocol.","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae7489aef4dd0fcdd392d0a1e7ea175537e3ca05","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":377,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"os-ken can be used to to handle BFD (see [4]_ )."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"OVS limitations"},{"line_number":382,"context_line":"+++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ad7ddab2_cb798a18","line":379,"range":{"start_line":379,"start_character":19,"end_line":379,"end_character":24},"updated":"2021-01-28 08:33:57.000000000","message":"to","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bdeefb8b32e3f00f916d9fcdc8c77a4f2f765bef","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":377,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"os-ken can be used to to handle BFD (see [4]_ )."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"OVS limitations"},{"line_number":382,"context_line":"+++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"8164d8b4_1ea874b5","line":379,"range":{"start_line":379,"start_character":0,"end_line":379,"end_character":13},"in_reply_to":"254b1969_a2f59763","updated":"2021-01-29 16:49:39.000000000","message":"you are right, when first checked os-ken I had the impression that os-ken finally goes to ovs, but it really starts a bfd server, or similar.\n\nI try to push my PoC to reach this part, and I will add details to the spec as well based on that.","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3893b472102d6513c8b8e065afc50fb6453ee967","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":377,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"os-ken can be used to to handle BFD (see [4]_ )."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"OVS limitations"},{"line_number":382,"context_line":"+++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"b75d69a4_485abea9","line":379,"range":{"start_line":379,"start_character":0,"end_line":379,"end_character":13},"in_reply_to":"811cb6b4_8ed8e593","updated":"2021-02-08 16:37:14.000000000","message":"Liu: os-ken with its bfd support seems much better choice, so I removes ovs based bfd totally and added some details for os-ken based bfd.\nI try to come back with my PoC experiment asap. (I check my other local only patches and refresh them based on the spec review and push them this week I hope)","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8e10d5b71d42a708fe90b09fa4dd508931abaa39","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":377,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"os-ken can be used to to handle BFD (see [4]_ )."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"OVS limitations"},{"line_number":382,"context_line":"+++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"811cb6b4_8ed8e593","line":379,"range":{"start_line":379,"start_character":0,"end_line":379,"end_character":13},"in_reply_to":"8164d8b4_1ea874b5","updated":"2021-02-07 09:14:30.000000000","message":"So for this part, about how to create bfd for interface, we need to add commands [1] and all related functions to ovsdbapp. Then L3 agent can call it to control the ovsdb. So please left these ovs-vsctl commands here, and try to add some simulation ovsdbapp commands to this spec to describe the bfd CURD workflow in L3 agent side.\n\n\n[1] https://github.com/openstack/ovsdbapp/blob/master/ovsdbapp/schema/open_vswitch/commands.py","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3893b472102d6513c8b8e065afc50fb6453ee967","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        $ sudo ovs-vsctl get interface ens5 bfd_status"},{"line_number":377,"context_line":"          {diagnostic\u003d\"Control Detection Time Expired\", flap_count\u003d\"7\", forwarding\u003d\"true\", remote_diagnostic\u003d\"Neighbor Signaled Session Down\", remote_state\u003dup, state\u003dup}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"os-ken can be used to to handle BFD (see [4]_ )."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"OVS limitations"},{"line_number":382,"context_line":"+++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"d8d77ec5_5e42f82e","line":379,"range":{"start_line":379,"start_character":19,"end_line":379,"end_character":24},"in_reply_to":"ad7ddab2_cb798a18","updated":"2021-02-08 16:37:14.000000000","message":"Done","commit_id":"d2b0573153fc52d059861330ea0b1a3ecc421fd7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":179,"context_line":"| type              | String  | No    | CR   | Can be ``singlehop``, ``multihop``    |"},{"line_number":180,"context_line":"|                   |         |       |      | and accepts future types.             |"},{"line_number":181,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":182,"context_line":"| dst_ip            | String  | No    | CR   | The destination IP address to be      |"},{"line_number":183,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"},{"line_number":184,"context_line":"|                   |         |       |      | this is the nexthop ip of the route,  |"},{"line_number":185,"context_line":"|                   |         |       |      | for the general case (like multihop   |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f6a3b787_02adb3d8","line":182,"range":{"start_line":182,"start_character":32,"end_line":182,"end_character":34},"updated":"2021-02-01 13:47:16.000000000","message":"Isn\u0027t this required?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":179,"context_line":"| type              | String  | No    | CR   | Can be ``singlehop``, ``multihop``    |"},{"line_number":180,"context_line":"|                   |         |       |      | and accepts future types.             |"},{"line_number":181,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":182,"context_line":"| dst_ip            | String  | No    | CR   | The destination IP address to be      |"},{"line_number":183,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"},{"line_number":184,"context_line":"|                   |         |       |      | this is the nexthop ip of the route,  |"},{"line_number":185,"context_line":"|                   |         |       |      | for the general case (like multihop   |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c7eaad80_298ae35d","line":182,"range":{"start_line":182,"start_character":32,"end_line":182,"end_character":34},"in_reply_to":"f6a3b787_02adb3d8","updated":"2021-02-05 13:39:33.000000000","message":"thanks, it\u0027s needed","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":193,"context_line":"|                   |         |       |      | This can be set on the remote end to  |"},{"line_number":194,"context_line":"|                   |         |       |      | be configured.                        |"},{"line_number":195,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":196,"context_line":"| min_rx            | Integer | Yes   | CRU  | The shortest interval, in millisecs,  |"},{"line_number":197,"context_line":"|                   |         |       |      | at which this  BFD  session offers to |"},{"line_number":198,"context_line":"|                   |         |       |      | receive BFD control messages. At      |"},{"line_number":199,"context_line":"|                   |         |       |      | least 1.                              |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"aadb87ea_5e0ebbc4","line":196,"range":{"start_line":196,"start_character":2,"end_line":196,"end_character":8},"updated":"2021-02-01 13:47:16.000000000","message":"I\u0027m wondering if we could have a default for this and then it could be optional. The same applies for min_tx and multiplier.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4fcabcfaaee247eb0149dfa3461f5cde8bc97517","unresolved":true,"context_lines":[{"line_number":193,"context_line":"|                   |         |       |      | This can be set on the remote end to  |"},{"line_number":194,"context_line":"|                   |         |       |      | be configured.                        |"},{"line_number":195,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":196,"context_line":"| min_rx            | Integer | Yes   | CRU  | The shortest interval, in millisecs,  |"},{"line_number":197,"context_line":"|                   |         |       |      | at which this  BFD  session offers to |"},{"line_number":198,"context_line":"|                   |         |       |      | receive BFD control messages. At      |"},{"line_number":199,"context_line":"|                   |         |       |      | least 1.                              |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fc4e09da_8326d590","line":196,"range":{"start_line":196,"start_character":2,"end_line":196,"end_character":8},"in_reply_to":"aadb87ea_5e0ebbc4","updated":"2021-02-02 10:38:48.000000000","message":"+1","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":193,"context_line":"|                   |         |       |      | This can be set on the remote end to  |"},{"line_number":194,"context_line":"|                   |         |       |      | be configured.                        |"},{"line_number":195,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":196,"context_line":"| min_rx            | Integer | Yes   | CRU  | The shortest interval, in millisecs,  |"},{"line_number":197,"context_line":"|                   |         |       |      | at which this  BFD  session offers to |"},{"line_number":198,"context_line":"|                   |         |       |      | receive BFD control messages. At      |"},{"line_number":199,"context_line":"|                   |         |       |      | least 1.                              |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9c3bf30f_b5e8f8ce","line":196,"range":{"start_line":196,"start_character":2,"end_line":196,"end_character":8},"in_reply_to":"fc4e09da_8326d590","updated":"2021-02-05 13:39:33.000000000","message":"That\u0027s true, thanks, as I checked these can be quite useful defaults.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4fcabcfaaee247eb0149dfa3461f5cde8bc97517","unresolved":true,"context_lines":[{"line_number":203,"context_line":"|                   |         |       |      | willing to transmit BFD control       |"},{"line_number":204,"context_line":"|                   |         |       |      | messages. At least 1.                 |"},{"line_number":205,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":206,"context_line":"| multiplier        | Integer | Yes   | CRU  | The BFD detection multiplier, An      |"},{"line_number":207,"context_line":"|                   |         |       |      | endpoint signals  a connectivity      |"},{"line_number":208,"context_line":"|                   |         |       |      | fault if the given number of          |"},{"line_number":209,"context_line":"|                   |         |       |      | consecutive BFD control messages fail |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c746c7d5_256b1bc4","line":206,"range":{"start_line":206,"start_character":2,"end_line":206,"end_character":12},"updated":"2021-02-02 10:38:48.000000000","message":"maybe here we could also have some default value?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":false,"context_lines":[{"line_number":203,"context_line":"|                   |         |       |      | willing to transmit BFD control       |"},{"line_number":204,"context_line":"|                   |         |       |      | messages. At least 1.                 |"},{"line_number":205,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":206,"context_line":"| multiplier        | Integer | Yes   | CRU  | The BFD detection multiplier, An      |"},{"line_number":207,"context_line":"|                   |         |       |      | endpoint signals  a connectivity      |"},{"line_number":208,"context_line":"|                   |         |       |      | fault if the given number of          |"},{"line_number":209,"context_line":"|                   |         |       |      | consecutive BFD control messages fail |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"278cf6f5_ecccb891","line":206,"range":{"start_line":206,"start_character":2,"end_line":206,"end_character":12},"in_reply_to":"c746c7d5_256b1bc4","updated":"2021-02-05 13:39:33.000000000","message":"Done","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bdeefb8b32e3f00f916d9fcdc8c77a4f2f765bef","unresolved":true,"context_lines":[{"line_number":209,"context_line":"|                   |         |       |      | consecutive BFD control messages fail |"},{"line_number":210,"context_line":"|                   |         |       |      | to arrive.                            |"},{"line_number":211,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":212,"context_line":"| address_scope     | uuid-str| Yes   | CR   | The id of the ``address-scope`` to    |"},{"line_number":213,"context_line":"|                   |         |       |      | use for the bfd_monitor, this makes   |"},{"line_number":214,"context_line":"|                   |         |       |      | sure that there will be no overlapping|"},{"line_number":215,"context_line":"|                   |         |       |      | bfd destinations.                     |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c6ba960a_fcdae8d9","line":212,"range":{"start_line":212,"start_character":2,"end_line":212,"end_character":15},"updated":"2021-01-29 16:49:39.000000000","message":"After some discussion using address_scope instead of router can be more general, and still gives enough possibility for validation to avoid collisions.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":209,"context_line":"|                   |         |       |      | consecutive BFD control messages fail |"},{"line_number":210,"context_line":"|                   |         |       |      | to arrive.                            |"},{"line_number":211,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":212,"context_line":"| address_scope     | uuid-str| Yes   | CR   | The id of the ``address-scope`` to    |"},{"line_number":213,"context_line":"|                   |         |       |      | use for the bfd_monitor, this makes   |"},{"line_number":214,"context_line":"|                   |         |       |      | sure that there will be no overlapping|"},{"line_number":215,"context_line":"|                   |         |       |      | bfd destinations.                     |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"cac0a828_bb33acc4","line":212,"range":{"start_line":212,"start_character":2,"end_line":212,"end_character":15},"in_reply_to":"c6ba960a_fcdae8d9","updated":"2021-02-01 13:47:16.000000000","message":"Here\u0027s a problem that we didn\u0027t think of before: How do we allow bfd monitoring on a subnet that does not belong to any address scope? Also on a single router we could have multiple address scopes. Do we need both attributes: router and address_scope?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4fcabcfaaee247eb0149dfa3461f5cde8bc97517","unresolved":true,"context_lines":[{"line_number":212,"context_line":"| address_scope     | uuid-str| Yes   | CR   | The id of the ``address-scope`` to    |"},{"line_number":213,"context_line":"|                   |         |       |      | use for the bfd_monitor, this makes   |"},{"line_number":214,"context_line":"|                   |         |       |      | sure that there will be no overlapping|"},{"line_number":215,"context_line":"|                   |         |       |      | bfd destinations.                     |"},{"line_number":216,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":217,"context_line":"| status            | String  | N/A   | R    | Shows if the BFD monitor was          |"},{"line_number":218,"context_line":"|                   |         |       |      | succesfully created in the backend,   |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"eb3386e0_1acf76c9","line":215,"updated":"2021-02-02 10:38:48.000000000","message":"I\u0027m not sure if I understand correctly. Here You are saying that this is to be sure that there is no overlapping destinations but in L77-84 You have use case where You have same destination for 2 different BFDs","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":212,"context_line":"| address_scope     | uuid-str| Yes   | CR   | The id of the ``address-scope`` to    |"},{"line_number":213,"context_line":"|                   |         |       |      | use for the bfd_monitor, this makes   |"},{"line_number":214,"context_line":"|                   |         |       |      | sure that there will be no overlapping|"},{"line_number":215,"context_line":"|                   |         |       |      | bfd destinations.                     |"},{"line_number":216,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":217,"context_line":"| status            | String  | N/A   | R    | Shows if the BFD monitor was          |"},{"line_number":218,"context_line":"|                   |         |       |      | succesfully created in the backend,   |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"24807b39_a82b08bf","line":215,"in_reply_to":"eb3386e0_1acf76c9","updated":"2021-02-05 13:39:33.000000000","message":"thanks, I removed that usecase","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":226,"context_line":"|                   |         |       |      | ``MeticulousSHA1``, if empty no       |"},{"line_number":227,"context_line":"|                   |         |       |      | authentication is used.               |"},{"line_number":228,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":229,"context_line":"| auth_key          | Dics    | No    | CR   | A dictionary of authentication key    |"},{"line_number":230,"context_line":"|                   |         |       |      | chain in which key is an integer of   |"},{"line_number":231,"context_line":"|                   |         |       |      | ``Auth Key ID`` and value is a string |"},{"line_number":232,"context_line":"|                   |         |       |      | of ``Password`` or ``Auth Key``.      |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d9668dc8_082999cd","line":229,"range":{"start_line":229,"start_character":22,"end_line":229,"end_character":26},"updated":"2021-02-01 13:47:16.000000000","message":"Dict","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":false,"context_lines":[{"line_number":226,"context_line":"|                   |         |       |      | ``MeticulousSHA1``, if empty no       |"},{"line_number":227,"context_line":"|                   |         |       |      | authentication is used.               |"},{"line_number":228,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":229,"context_line":"| auth_key          | Dics    | No    | CR   | A dictionary of authentication key    |"},{"line_number":230,"context_line":"|                   |         |       |      | chain in which key is an integer of   |"},{"line_number":231,"context_line":"|                   |         |       |      | ``Auth Key ID`` and value is a string |"},{"line_number":232,"context_line":"|                   |         |       |      | of ``Password`` or ``Auth Key``.      |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"87f200d6_10bee053","line":229,"range":{"start_line":229,"start_character":22,"end_line":229,"end_character":26},"in_reply_to":"d9668dc8_082999cd","updated":"2021-02-05 13:39:33.000000000","message":"Done","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":267,"context_line":"                     \u0027default\u0027: BFD_MODE_SINGLEHOP, \u0027is_filter\u0027: True,"},{"line_number":268,"context_line":"                     \u0027is_sort_key\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":269,"context_line":"            \u0027dst_ip\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":270,"context_line":"                       \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":271,"context_line":"                       \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"},{"line_number":272,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":273,"context_line":"                       \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8b4ca68a_ecebb8a9","line":270,"range":{"start_line":270,"start_character":42,"end_line":270,"end_character":60},"updated":"2021-02-01 13:47:16.000000000","message":"Is None intentional?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":267,"context_line":"                     \u0027default\u0027: BFD_MODE_SINGLEHOP, \u0027is_filter\u0027: True,"},{"line_number":268,"context_line":"                     \u0027is_sort_key\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":269,"context_line":"            \u0027dst_ip\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":270,"context_line":"                       \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":271,"context_line":"                       \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"},{"line_number":272,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":273,"context_line":"                       \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":8,"id":"72b1d597_4859bf7c","line":270,"range":{"start_line":270,"start_character":42,"end_line":270,"end_character":60},"in_reply_to":"8b4ca68a_ecebb8a9","updated":"2021-02-05 13:39:33.000000000","message":"no, that was bad copy-paste or similar","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":272,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":273,"context_line":"                       \u0027enforce_policy\u0027: True},"},{"line_number":274,"context_line":"            \u0027src_ip\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":275,"context_line":"                       \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":276,"context_line":"                       \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"},{"line_number":277,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":278,"context_line":"                       \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":8,"id":"2b008036_a2d6d9fc","line":275,"range":{"start_line":275,"start_character":24,"end_line":275,"end_character":32},"updated":"2021-02-01 13:47:16.000000000","message":"This never comes from a user.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":273,"context_line":"                       \u0027enforce_policy\u0027: True},"},{"line_number":274,"context_line":"            \u0027src_ip\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":275,"context_line":"                       \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":276,"context_line":"                       \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"},{"line_number":277,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":278,"context_line":"                       \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":8,"id":"4777e0d6_bbefb4f0","line":275,"range":{"start_line":275,"start_character":24,"end_line":275,"end_character":32},"in_reply_to":"2b008036_a2d6d9fc","updated":"2021-02-05 13:39:33.000000000","message":"Done","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":278,"context_line":"                       \u0027enforce_policy\u0027: True},"},{"line_number":279,"context_line":"            \u0027min_rx\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":280,"context_line":"                       \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":281,"context_line":"                       \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":282,"context_line":"                       \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":283,"context_line":"                       \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0cf41c9b_f8875a98","line":280,"range":{"start_line":280,"start_character":42,"end_line":280,"end_character":54},"updated":"2021-02-01 13:47:16.000000000","message":"What does zero mean?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":278,"context_line":"                       \u0027enforce_policy\u0027: True},"},{"line_number":279,"context_line":"            \u0027min_rx\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":280,"context_line":"                       \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":281,"context_line":"                       \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":282,"context_line":"                       \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":283,"context_line":"                       \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b8fc8f64_816c4a34","line":280,"range":{"start_line":280,"start_character":42,"end_line":280,"end_character":54},"in_reply_to":"0cf41c9b_f8875a98","updated":"2021-02-05 13:39:33.000000000","message":"yeah, good catch, in worst case I will add a new validator validate_greater_than_zero or similar.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                       \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":283,"context_line":"                       \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":284,"context_line":"            \u0027min_tx\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":285,"context_line":"                       \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":286,"context_line":"                       \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":287,"context_line":"                       \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":288,"context_line":"                       \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":8,"id":"60d2e5f7_53c5a54d","line":285,"range":{"start_line":285,"start_character":42,"end_line":285,"end_character":54},"updated":"2021-02-01 13:47:16.000000000","message":"0?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"2fcc4f7d47e00a1d8ce1c254814820cefdcddd6c","unresolved":true,"context_lines":[{"line_number":287,"context_line":"                       \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":288,"context_line":"                       \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":289,"context_line":"            \u0027multiplier\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":290,"context_line":"                           \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":291,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":292,"context_line":"                           \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":293,"context_line":"                           \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":8,"id":"cd4e2899_d3349afe","line":290,"range":{"start_line":290,"start_character":46,"end_line":290,"end_character":58},"updated":"2021-02-01 13:47:16.000000000","message":"0?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"489183832f3ef4b64e8d264e45386e65af179caa","unresolved":true,"context_lines":[{"line_number":328,"context_line":"                    \"extra_route\": {"},{"line_number":329,"context_line":"                        \"destination\": \"10.0.3.0/24\","},{"line_number":330,"context_line":"                        \"nexthop\": \"10.0.0.1\""},{"line_number":331,"context_line":"                    },"},{"line_number":332,"context_line":"                    \"status\": {"},{"line_number":333,"context_line":"                        \"SessionState\": \"Init, Up, Down\","},{"line_number":334,"context_line":"                        \"RemoteSessionState\": \"Init, Up, Down\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"7dcc3f15_eea002ac","line":331,"updated":"2021-02-03 14:18:37.000000000","message":"I don\u0027t think there\u0027s anything to change here right not, but a comment for our future selves: We need to provide the most useful information here that back-references who uses this monitor. Sometimes this cannot be direct - for example because an extraroute does not have a UUID - but we still need to provide info that practically identifies all users of this monitor.\n\nMay want to add some of this to the spec to make ourselves remember.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":328,"context_line":"                    \"extra_route\": {"},{"line_number":329,"context_line":"                        \"destination\": \"10.0.3.0/24\","},{"line_number":330,"context_line":"                        \"nexthop\": \"10.0.0.1\""},{"line_number":331,"context_line":"                    },"},{"line_number":332,"context_line":"                    \"status\": {"},{"line_number":333,"context_line":"                        \"SessionState\": \"Init, Up, Down\","},{"line_number":334,"context_line":"                        \"RemoteSessionState\": \"Init, Up, Down\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"80aea146_79db33f1","line":331,"in_reply_to":"7dcc3f15_eea002ac","updated":"2021-02-05 13:39:33.000000000","message":"I added a new endpoint bfd_monitor_associations, but that is more or less overlaps with this session_status, the good in that is there\u0027s no need for fetching the status for the given session, can work from the db only.\nSummary: not sure if that endpoint is really needed, but can be useful and quicker than fetching the session_status always to know wher a bfd_monitor is used.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4fcabcfaaee247eb0149dfa3461f5cde8bc97517","unresolved":true,"context_lines":[{"line_number":375,"context_line":"| LocalDiagnostic    | A diagnostic code specifying the local system\u0027s     |"},{"line_number":376,"context_line":"|                    | reason for the last change in session state. The    |"},{"line_number":377,"context_line":"|                    | error messages are defined  in section 4.1 of       |"},{"line_number":378,"context_line":"|                    | RFC 5880.                                           |"},{"line_number":379,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":380,"context_line":"| RemoteDiagnostic   | A diagnostic code specifying the remote system\u0027s    |"},{"line_number":381,"context_line":"|                    | reason for  the last  change in session state. The  |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8c6d391a_79e370db","line":378,"updated":"2021-02-02 10:38:48.000000000","message":"nit: I think it should be \"of the RFC 5880\",\nmaybe You can also add link to that RFC here?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":false,"context_lines":[{"line_number":375,"context_line":"| LocalDiagnostic    | A diagnostic code specifying the local system\u0027s     |"},{"line_number":376,"context_line":"|                    | reason for the last change in session state. The    |"},{"line_number":377,"context_line":"|                    | error messages are defined  in section 4.1 of       |"},{"line_number":378,"context_line":"|                    | RFC 5880.                                           |"},{"line_number":379,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":380,"context_line":"| RemoteDiagnostic   | A diagnostic code specifying the remote system\u0027s    |"},{"line_number":381,"context_line":"|                    | reason for  the last  change in session state. The  |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f31a484_e1190536","line":378,"in_reply_to":"8c6d391a_79e370db","updated":"2021-02-05 13:39:33.000000000","message":"Done","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4fcabcfaaee247eb0149dfa3461f5cde8bc97517","unresolved":true,"context_lines":[{"line_number":380,"context_line":"| RemoteDiagnostic   | A diagnostic code specifying the remote system\u0027s    |"},{"line_number":381,"context_line":"|                    | reason for  the last  change in session state. The  |"},{"line_number":382,"context_line":"|                    | error messages are defined  in section 4.1 of       |"},{"line_number":383,"context_line":"|                    | RFC 5880.                                           |"},{"line_number":384,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":385,"context_line":"| LocalDiscriminator | The local discriminator for this BFD session, used  |"},{"line_number":386,"context_line":"|                    | to uniquely identify it.                            |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5464367f_bc232c01","line":383,"updated":"2021-02-02 10:38:48.000000000","message":"same nit here","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":false,"context_lines":[{"line_number":380,"context_line":"| RemoteDiagnostic   | A diagnostic code specifying the remote system\u0027s    |"},{"line_number":381,"context_line":"|                    | reason for  the last  change in session state. The  |"},{"line_number":382,"context_line":"|                    | error messages are defined  in section 4.1 of       |"},{"line_number":383,"context_line":"|                    | RFC 5880.                                           |"},{"line_number":384,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":385,"context_line":"| LocalDiscriminator | The local discriminator for this BFD session, used  |"},{"line_number":386,"context_line":"|                    | to uniquely identify it.                            |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff20730d_b016fd0a","line":383,"in_reply_to":"5464367f_bc232c01","updated":"2021-02-05 13:39:33.000000000","message":"Done","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4fcabcfaaee247eb0149dfa3461f5cde8bc97517","unresolved":true,"context_lines":[{"line_number":421,"context_line":"            \"router\" : {"},{"line_number":422,"context_line":"                \"routes\" : ["},{"line_number":423,"context_line":"                   { \"destination\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"bfd_monitor\": {bfd_monitor_uuid} },"},{"line_number":424,"context_line":"                   { \"destination\" : \"10.0.4.0/24\", \"nexthop\" : \"10.0.0.14\" }"},{"line_number":425,"context_line":"                ]"},{"line_number":426,"context_line":"            }"},{"line_number":427,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fda35ae6_68485c18","line":424,"updated":"2021-02-02 10:38:48.000000000","message":"I\u0027m not BFD expert so maybe my question isn\u0027t the best but what will happen if we will have e.g. one extraroute with bfd_monitor and other without? How it will work in such case?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":421,"context_line":"            \"router\" : {"},{"line_number":422,"context_line":"                \"routes\" : ["},{"line_number":423,"context_line":"                   { \"destination\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"bfd_monitor\": {bfd_monitor_uuid} },"},{"line_number":424,"context_line":"                   { \"destination\" : \"10.0.4.0/24\", \"nexthop\" : \"10.0.0.14\" }"},{"line_number":425,"context_line":"                ]"},{"line_number":426,"context_line":"            }"},{"line_number":427,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9cc58915_c38552ab","line":424,"in_reply_to":"fda35ae6_68485c18","updated":"2021-02-05 13:39:33.000000000","message":"The os_ken app will handle the sessions, and the session will be started only for the extra routes which have bfd_monitor association.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4fcabcfaaee247eb0149dfa3461f5cde8bc97517","unresolved":true,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":484,"context_line":"associated with any routes, and it is deleted in the backend when"},{"line_number":485,"context_line":"the extra route updated and bfd_monitor value is set to empty."},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"Backend"},{"line_number":488,"context_line":"~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f73fa0f1_aa8118b1","line":485,"updated":"2021-02-02 10:38:48.000000000","message":"so all of that will be done by the neutron L3 agent?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":484,"context_line":"associated with any routes, and it is deleted in the backend when"},{"line_number":485,"context_line":"the extra route updated and bfd_monitor value is set to empty."},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"Backend"},{"line_number":488,"context_line":"~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5032c646_6c79c6ba","line":485,"in_reply_to":"f73fa0f1_aa8118b1","updated":"2021-02-05 13:39:33.000000000","message":"yes, L3-agent will be responsible for handling the bfd_monitors, and reporting back the status of bfd_monitors.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4fcabcfaaee247eb0149dfa3461f5cde8bc97517","unresolved":true,"context_lines":[{"line_number":488,"context_line":"~~~~~~~"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"os-ken can be used to handle BFD (see [3]_ )."},{"line_number":491,"context_line":"... More details ..."},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"Data Model Impact"},{"line_number":494,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"93d26bf3_051c3ff5","line":491,"updated":"2021-02-02 10:38:48.000000000","message":"AFAIK os-ken is an app to manage open flows in ovs. Can it be also used to manage routes in the qrouter- namespace?","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4c938df35bec09777c535c252dbc47065408106","unresolved":true,"context_lines":[{"line_number":488,"context_line":"~~~~~~~"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"os-ken can be used to handle BFD (see [3]_ )."},{"line_number":491,"context_line":"... More details ..."},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"Data Model Impact"},{"line_number":494,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a434bf7_5d1cc139","line":491,"in_reply_to":"93d26bf3_051c3ff5","updated":"2021-02-05 13:39:33.000000000","message":"That was my original idea as well, but now I start to feel like os-ken is a kind of put everything useful lib, so yes it can start special applications like a bfd_monitor, see the ref [4]:\nhttps://opendev.org/openstack/os-ken/src/branch/master/os_ken/lib/bfdlib.py#L651\n\nIt will not touch the routes in namespace, but starts an os-ken application which handles the monitors with packet sending and receiving and giving a high level API for that with state change event subscription and similar.","commit_id":"2ee7e0c4f3e22fbc361262781f5df4c79057beb5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab6cbdd16f5c08ff14fed409f2d51fa23fc646be","unresolved":true,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"BFD support for Neutron"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/neutron/+bug/1907089"}],"source_content_type":"text/x-rst","patch_set":9,"id":"eddb10be_6266bef8","line":8,"updated":"2021-02-09 09:10:57.000000000","message":"BFD Service for Neutron","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4a387f803b900ca46189ad6bcf768a72af198a43","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"BFD support for Neutron"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/neutron/+bug/1907089"}],"source_content_type":"text/x-rst","patch_set":9,"id":"758b782b_f34e175b","line":8,"in_reply_to":"eddb10be_6266bef8","updated":"2021-02-12 16:19:57.000000000","message":"Done","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab6cbdd16f5c08ff14fed409f2d51fa23fc646be","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/neutron/+bug/1907089"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add possibility to define BDF monitors in Neutron and associate it with routes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":9,"id":"d14896e4_ec8eeb49","line":13,"updated":"2021-02-09 09:10:57.000000000","message":"BFD monitors","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4a387f803b900ca46189ad6bcf768a72af198a43","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/neutron/+bug/1907089"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add possibility to define BDF monitors in Neutron and associate it with routes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":9,"id":"337b4c4b_db33752f","line":13,"in_reply_to":"d14896e4_ec8eeb49","updated":"2021-02-12 16:19:57.000000000","message":"Done","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab6cbdd16f5c08ff14fed409f2d51fa23fc646be","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) can be used to detect link failures"},{"line_number":20,"context_line":"between a Neutron router and an arbitrary destination, like an external"},{"line_number":21,"context_line":"non-Neutron router."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BFD can be used to provide quick, low-overhead link failure detection between"}],"source_content_type":"text/x-rst","patch_set":9,"id":"203ae8fd_20d779c7","line":20,"updated":"2021-02-09 09:10:57.000000000","message":"BFD can be used to detect faults in the bidirectional path between two entities.   Typically the entities on either sides can be routers,  bgp-routing-protocol engine, ospf-routing-protocol-engine etc.\n\n\nThe idea of this Spec is to provide a generic Tenant driven BFD Monitoring Service function in Neutron which can be put to use for the following purposes by other Neutron Specs (and / or backend implementations of Neutron):\n\n\na. Use BFD monitoring with Neutron Extra Route API , to provide intelligent forwarding plane for Extra Route Destinations configured for Neutron Routers\n\nb. Use BFD monitoring with Neutron BGPaaS Peering API, to provide intelligent forwarding plane for Peers configured under Neutron Dynamic BGPaaS\n\nC. Use BFD monitoring \n\nIn this Spec, we will focus on resource entities and APIs to cover generic BFD Monitoring Service for Openstack Tenants\n\n\nIn addition to the same, we will also propose enhancement to the Neutron Extra Route API to take advantage of this BFD-Monitoring-aaS, thereby preventing Neutron Routers from blackholing the traffic-flows to to Extra-Route destinations due to \"unavailable (or) unreachable nexthops\" that may be configured serve such Extra-Route destinations.","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) can be used to detect link failures"},{"line_number":20,"context_line":"between a Neutron router and an arbitrary destination, like an external"},{"line_number":21,"context_line":"non-Neutron router."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BFD can be used to provide quick, low-overhead link failure detection between"}],"source_content_type":"text/x-rst","patch_set":9,"id":"31a6d2d7_f01f9cdb","line":20,"in_reply_to":"203ae8fd_20d779c7","updated":"2021-02-09 17:23:28.000000000","message":"I left out BGP to cover that later in a different spec","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"5135fdc2e1b99924739c314689e2dda5a681c024","unresolved":true,"context_lines":[{"line_number":92,"context_line":"                \"min_tx\": 100,"},{"line_number":93,"context_line":"                \"multiplier\": 3,"},{"line_number":94,"context_line":"                \"auth_type\": \"\","},{"line_number":95,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":96,"context_line":"                \"address_scope\": {address_scope_id},"},{"line_number":97,"context_line":"            }"},{"line_number":98,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":9,"id":"04622ce9_4c5b2e04","line":95,"updated":"2021-02-09 10:35:09.000000000","message":"can you please let us know what is the role of these auth-keys?","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":92,"context_line":"                \"min_tx\": 100,"},{"line_number":93,"context_line":"                \"multiplier\": 3,"},{"line_number":94,"context_line":"                \"auth_type\": \"\","},{"line_number":95,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":96,"context_line":"                \"address_scope\": {address_scope_id},"},{"line_number":97,"context_line":"            }"},{"line_number":98,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":9,"id":"489023e8_288200eb","line":95,"in_reply_to":"04622ce9_4c5b2e04","updated":"2021-02-09 17:23:28.000000000","message":"bfd can use authentication, so if we want to make the API generic we have to provide this. For possible auth types please check the field description table below.","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4a387f803b900ca46189ad6bcf768a72af198a43","unresolved":true,"context_lines":[{"line_number":92,"context_line":"                \"min_tx\": 100,"},{"line_number":93,"context_line":"                \"multiplier\": 3,"},{"line_number":94,"context_line":"                \"auth_type\": \"\","},{"line_number":95,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":96,"context_line":"                \"address_scope\": {address_scope_id},"},{"line_number":97,"context_line":"            }"},{"line_number":98,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":9,"id":"13acfb58_bbf36e39","line":95,"in_reply_to":"489023e8_288200eb","updated":"2021-02-12 16:19:57.000000000","message":"The 4. reference point to this part in RFC5880, added a note for it","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8e10d5b71d42a708fe90b09fa4dd508931abaa39","unresolved":true,"context_lines":[{"line_number":93,"context_line":"                \"multiplier\": 3,"},{"line_number":94,"context_line":"                \"auth_type\": \"\","},{"line_number":95,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":96,"context_line":"                \"address_scope\": {address_scope_id},"},{"line_number":97,"context_line":"            }"},{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"edb34a1d_61ba869c","line":96,"range":{"start_line":96,"start_character":16,"end_line":96,"end_character":52},"updated":"2021-02-07 09:14:30.000000000","message":"Why this is changed to ``address_scope_id``? Could you elaborate the detail sicne I did not see any information about `address scope` in this spec?","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3893b472102d6513c8b8e065afc50fb6453ee967","unresolved":true,"context_lines":[{"line_number":93,"context_line":"                \"multiplier\": 3,"},{"line_number":94,"context_line":"                \"auth_type\": \"\","},{"line_number":95,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":96,"context_line":"                \"address_scope\": {address_scope_id},"},{"line_number":97,"context_line":"            }"},{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"a5532d16_5b0ccb8c","line":96,"range":{"start_line":96,"start_character":16,"end_line":96,"end_character":52},"in_reply_to":"edb34a1d_61ba869c","updated":"2021-02-08 16:37:14.000000000","message":"Actually it is more like a generalization of the API (see my comment: https://review.opendev.org/c/openstack/neutron-specs/+/767337/8/specs/wallaby/bfd_support.rst#212 )","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab6cbdd16f5c08ff14fed409f2d51fa23fc646be","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                \"auth_type\": \"\","},{"line_number":95,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":96,"context_line":"                \"address_scope\": {address_scope_id},"},{"line_number":97,"context_line":"            }"},{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* List bfd_monitors::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"e6b33357_40fc675a","line":97,"updated":"2021-02-09 09:10:57.000000000","message":"address-scope provide an IP-Scoping for the source and destination addresses of a BFD monitor.\nMeaning, it makes us possible to derive the subnet mask for the source and the destination addresses.   \n\nAlso when two tenants create BFD Monitor with same source and/or destination addresses (eg., overlapping addresses),  the address-scope drives conflict resolution as it represents the IP scope for such source/destination addresses.","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab6cbdd16f5c08ff14fed409f2d51fa23fc646be","unresolved":true,"context_lines":[{"line_number":167,"context_line":"|                   |         |       |      | ``one-arm-echo`` see [3]_ .           |"},{"line_number":168,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":169,"context_line":"| type              | String  | No    | CR   | Can be ``singlehop``, ``multihop``    |"},{"line_number":170,"context_line":"|                   |         |       |      | and accepts future types.             |"},{"line_number":171,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":172,"context_line":"| dst_ip            | String  | Yes   | CR   | The destination IP address to be      |"},{"line_number":173,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5063185d_e58a9906","line":170,"updated":"2021-02-09 09:10:57.000000000","message":"It is not clear if we need to have \u0027type\u0027 at the moment.\n\nThe mode can support\u0027asynchronous, demand, one-arm-echo as options.","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":167,"context_line":"|                   |         |       |      | ``one-arm-echo`` see [3]_ .           |"},{"line_number":168,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":169,"context_line":"| type              | String  | No    | CR   | Can be ``singlehop``, ``multihop``    |"},{"line_number":170,"context_line":"|                   |         |       |      | and accepts future types.             |"},{"line_number":171,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":172,"context_line":"| dst_ip            | String  | Yes   | CR   | The destination IP address to be      |"},{"line_number":173,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"706cc8c9_caac0739","line":170,"in_reply_to":"5063185d_e58a9906","updated":"2021-02-09 17:23:28.000000000","message":"Type is here to make the API as generic as possible, though os-ken (the backend candidate as of now) supports only async mode.","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"5135fdc2e1b99924739c314689e2dda5a681c024","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                       \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":286,"context_line":"            \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":287,"context_line":"                       \u0027is_filter\u0027: True, \u0027is_sort_key\u0027: True,"},{"line_number":288,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":289,"context_line":"            \u0027auth_type\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":290,"context_line":"                          \u0027validate\u0027: {\u0027type:string_or_none\u0027:"},{"line_number":291,"context_line":"                                       db_const.NAME_FIELD_SIZE},"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dc160c29_0338a5dd","line":288,"updated":"2021-02-09 10:35:09.000000000","message":"can you please explain what will be the role of this \u0027status\u0027 field?\n\nWill it be DOWN until the bfd-monitor is associated to something useful like extra-routes and/or bgp peers and then transition to ACTIVE once the monitor is started?","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                       \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":286,"context_line":"            \u0027status\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":287,"context_line":"                       \u0027is_filter\u0027: True, \u0027is_sort_key\u0027: True,"},{"line_number":288,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":289,"context_line":"            \u0027auth_type\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":290,"context_line":"                          \u0027validate\u0027: {\u0027type:string_or_none\u0027:"},{"line_number":291,"context_line":"                                       db_const.NAME_FIELD_SIZE},"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3c7869e2_eb1d620e","line":288,"in_reply_to":"dc160c29_0338a5dd","updated":"2021-02-09 17:23:28.000000000","message":"Yeah it is a tricky one, so I added details for it ~l207:\nShows if the BFD monitor was succesfully created in the backend, but nothing about the session status, for that the session_status API endpoint can be used.","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab6cbdd16f5c08ff14fed409f2d51fa23fc646be","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":313,"context_line":"        {"},{"line_number":314,"context_line":"            \"bfd_session_status\": {"},{"line_number":315,"context_line":"                \"remotes\": [{"},{"line_number":316,"context_line":"                    \"type\": \"extra_route\","},{"line_number":317,"context_line":"                    \"router\":{router_id},"},{"line_number":318,"context_line":"                    \"extra_route\": {"}],"source_content_type":"text/x-rst","patch_set":9,"id":"359fe052_efea36b8","line":315,"updated":"2021-02-09 09:10:57.000000000","message":"one bfd-monitor will have only one session.  so why do we have a list of \"remotes\" here?","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":313,"context_line":"        {"},{"line_number":314,"context_line":"            \"bfd_session_status\": {"},{"line_number":315,"context_line":"                \"remotes\": [{"},{"line_number":316,"context_line":"                    \"type\": \"extra_route\","},{"line_number":317,"context_line":"                    \"router\":{router_id},"},{"line_number":318,"context_line":"                    \"extra_route\": {"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3dc33989_bf657964","line":315,"in_reply_to":"359fe052_efea36b8","updated":"2021-02-09 17:23:28.000000000","message":"it makes possible to use the same bfd_monitor API instance for several extraroutes nexthop-destination pairs or even for other things like for BGP.\nThis makes the life of the user easier if all the values are the same.\n\"remotes\" is there to make it possible to list different associations for the same monitor and keep the API clean, see https://review.opendev.org/c/openstack/neutron-specs/+/767337/2/specs/wallaby/bfd_support.rst#242","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab6cbdd16f5c08ff14fed409f2d51fa23fc646be","unresolved":true,"context_lines":[{"line_number":341,"context_line":"       GET /v2.0/bfd_monitors/{monitor_id}/bfd_monitor_associations"},{"line_number":342,"context_line":"       {"},{"line_number":343,"context_line":"            \"bfd_monitor_associations\": {"},{"line_number":344,"context_line":"                \"remotes\": [{"},{"line_number":345,"context_line":"                    \"type\": \"extra_route\","},{"line_number":346,"context_line":"                    \"router\": {router_id},"},{"line_number":347,"context_line":"                    \"extra_route\": {"}],"source_content_type":"text/x-rst","patch_set":9,"id":"6ccd6d33_12e7fdc5","line":344,"updated":"2021-02-09 09:10:57.000000000","message":"a given bfd-monitor can be associted to multiple destinations.  As a result, we tend to see that bfd_monitor_associations can be a list of associaations.  The intermediate \u0027remotes\u0027 tag can be removed?","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":341,"context_line":"       GET /v2.0/bfd_monitors/{monitor_id}/bfd_monitor_associations"},{"line_number":342,"context_line":"       {"},{"line_number":343,"context_line":"            \"bfd_monitor_associations\": {"},{"line_number":344,"context_line":"                \"remotes\": [{"},{"line_number":345,"context_line":"                    \"type\": \"extra_route\","},{"line_number":346,"context_line":"                    \"router\": {router_id},"},{"line_number":347,"context_line":"                    \"extra_route\": {"}],"source_content_type":"text/x-rst","patch_set":9,"id":"cacfc6da_e0a4e5aa","line":344,"in_reply_to":"6ccd6d33_12e7fdc5","updated":"2021-02-09 17:23:28.000000000","message":"see my comment above (https://review.opendev.org/c/openstack/neutron-specs/+/767337/9/specs/wallaby/bfd_support.rst#315 )","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4a387f803b900ca46189ad6bcf768a72af198a43","unresolved":false,"context_lines":[{"line_number":341,"context_line":"       GET /v2.0/bfd_monitors/{monitor_id}/bfd_monitor_associations"},{"line_number":342,"context_line":"       {"},{"line_number":343,"context_line":"            \"bfd_monitor_associations\": {"},{"line_number":344,"context_line":"                \"remotes\": [{"},{"line_number":345,"context_line":"                    \"type\": \"extra_route\","},{"line_number":346,"context_line":"                    \"router\": {router_id},"},{"line_number":347,"context_line":"                    \"extra_route\": {"}],"source_content_type":"text/x-rst","patch_set":9,"id":"b23d9422_8ac2154f","line":344,"in_reply_to":"cacfc6da_e0a4e5aa","updated":"2021-02-12 16:19:57.000000000","message":"I added few lines describing this ~l497","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"5135fdc2e1b99924739c314689e2dda5a681c024","unresolved":true,"context_lines":[{"line_number":442,"context_line":"        {"},{"line_number":443,"context_line":"            \"router\": {"},{"line_number":444,"context_line":"                \"routes\": ["},{"line_number":445,"context_line":"                    { \"destination\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"status\": \"UP\" },"},{"line_number":446,"context_line":"                ]"},{"line_number":447,"context_line":"            }"},{"line_number":448,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":9,"id":"8965e9d1_c81a09ae","line":445,"updated":"2021-02-09 10:35:09.000000000","message":"could we show bfd-monitor names here too before \u0027status\u0027 column (if a destination is configured with a monitor)?\n\nfor those destination without monitors, the status can be always set to \u0027UP\u0027.","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4a387f803b900ca46189ad6bcf768a72af198a43","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        {"},{"line_number":443,"context_line":"            \"router\": {"},{"line_number":444,"context_line":"                \"routes\": ["},{"line_number":445,"context_line":"                    { \"destination\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"status\": \"UP\" },"},{"line_number":446,"context_line":"                ]"},{"line_number":447,"context_line":"            }"},{"line_number":448,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":9,"id":"cf330843_5d456ddc","line":445,"in_reply_to":"1b4dcbab_477adf39","updated":"2021-02-12 16:19:57.000000000","message":"check please if this is what you thought","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":442,"context_line":"        {"},{"line_number":443,"context_line":"            \"router\": {"},{"line_number":444,"context_line":"                \"routes\": ["},{"line_number":445,"context_line":"                    { \"destination\" : \"10.0.3.0/24\", \"nexthop\" : \"10.0.0.13\", \"status\": \"UP\" },"},{"line_number":446,"context_line":"                ]"},{"line_number":447,"context_line":"            }"},{"line_number":448,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1b4dcbab_477adf39","line":445,"in_reply_to":"8965e9d1_c81a09ae","updated":"2021-02-09 17:23:28.000000000","message":"bfd_monitor_id can be good to see here, you are right, and will update with the status related notes as well","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"5135fdc2e1b99924739c314689e2dda5a681c024","unresolved":true,"context_lines":[{"line_number":487,"context_line":"link is up."},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"If the bfd_monitor_status is DOWN the given route should be removed in the"},{"line_number":490,"context_line":"backend (on the command line: ip r delete....), and set back if the monitor"},{"line_number":491,"context_line":"is UP again."},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"}],"source_content_type":"text/x-rst","patch_set":9,"id":"d328f680_429bd002","line":490,"updated":"2021-02-09 10:35:09.000000000","message":"there is a session-status and bfd-monitor-running status.   Can you please clarify which part you are discussin here when you use \u0027bfd_monitor-status is DOWN\u0027 ?\n\nwe tend to believe you are discussing about session-status here and use that drive presence/absence of a route in the router?","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4a387f803b900ca46189ad6bcf768a72af198a43","unresolved":false,"context_lines":[{"line_number":487,"context_line":"link is up."},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"If the bfd_monitor_status is DOWN the given route should be removed in the"},{"line_number":490,"context_line":"backend (on the command line: ip r delete....), and set back if the monitor"},{"line_number":491,"context_line":"is UP again."},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"}],"source_content_type":"text/x-rst","patch_set":9,"id":"f93c3cce_0bf2c4f6","line":490,"in_reply_to":"69c494c7_55ebe4e4","updated":"2021-02-12 16:19:57.000000000","message":"Done","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":487,"context_line":"link is up."},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"If the bfd_monitor_status is DOWN the given route should be removed in the"},{"line_number":490,"context_line":"backend (on the command line: ip r delete....), and set back if the monitor"},{"line_number":491,"context_line":"is UP again."},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"}],"source_content_type":"text/x-rst","patch_set":9,"id":"69c494c7_55ebe4e4","line":490,"in_reply_to":"d328f680_429bd002","updated":"2021-02-09 17:23:28.000000000","message":"thanks I clarify it with a next patchset","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"5135fdc2e1b99924739c314689e2dda5a681c024","unresolved":true,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":494,"context_line":"associated with any routes, and it is deleted in the backend when"},{"line_number":495,"context_line":"the extra route updated and bfd_monitor value is set to empty."},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"Backend"},{"line_number":498,"context_line":"~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"af228d52_9eab7a81","line":495,"updated":"2021-02-09 10:35:09.000000000","message":"the \u0027status\u0027 field for a bfd-monitor can serve good purpose to reflect this type of behaviour.\n\nFor eg., the \u0027status\u0027 field can be DOWN, ACTIVE.  \u0027DOWN\u0027 means the monitoring itself is not started.  \u0027ACTIVE\u0027 monitoring has started.   Please note that this status is different from session-status.","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e07fab5a18c8eb47c1063140cb53457e656a7402","unresolved":true,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":494,"context_line":"associated with any routes, and it is deleted in the backend when"},{"line_number":495,"context_line":"the extra route updated and bfd_monitor value is set to empty."},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"Backend"},{"line_number":498,"context_line":"~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"daafdf67_e53d8393","line":495,"in_reply_to":"af228d52_9eab7a81","updated":"2021-02-09 17:23:28.000000000","message":"thanks I will clarify it with a next patchset","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4a387f803b900ca46189ad6bcf768a72af198a43","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":494,"context_line":"associated with any routes, and it is deleted in the backend when"},{"line_number":495,"context_line":"the extra route updated and bfd_monitor value is set to empty."},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"Backend"},{"line_number":498,"context_line":"~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ab7a6f22_7db2c56b","line":495,"in_reply_to":"daafdf67_e53d8393","updated":"2021-02-12 16:19:57.000000000","message":"Done","commit_id":"cddfed8baed722e5ec0d179e8e5b3e08286ce712"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":63,"context_line":"| dst3 | nexthop3 | bfd3 |"},{"line_number":64,"context_line":"+------+----------+------+"},{"line_number":65,"context_line":"| dst4 | nexthop3 | bfd4 |"},{"line_number":66,"context_line":"+------+----------+------+"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"::"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"2d2e6b89_2208f9a1","line":66,"updated":"2021-03-23 13:35:30.000000000","message":"in this case the same BFD-Monitor can be used.  Can you please let us know why we have put bfd3, bfd4 here?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a8e6a5341357c8f185523580fb6346364636183b","unresolved":true,"context_lines":[{"line_number":63,"context_line":"| dst3 | nexthop3 | bfd3 |"},{"line_number":64,"context_line":"+------+----------+------+"},{"line_number":65,"context_line":"| dst4 | nexthop3 | bfd4 |"},{"line_number":66,"context_line":"+------+----------+------+"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"::"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"effbf480_a797902d","line":66,"in_reply_to":"2d2e6b89_2208f9a1","updated":"2021-03-29 11:49:12.000000000","message":"It seems to me the table is missing a piece of information: what is the bfd destination?\n\nIf it is nexthop3 then we can (and in most cases should) use the same monitor.\nIf it is something beyond nexthop3 then we should use two different monitors.\n\nMaybe it\u0027s worth extending the table to contain the bfd destination too.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":63,"context_line":"| dst3 | nexthop3 | bfd3 |"},{"line_number":64,"context_line":"+------+----------+------+"},{"line_number":65,"context_line":"| dst4 | nexthop3 | bfd4 |"},{"line_number":66,"context_line":"+------+----------+------+"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"::"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"ebc9480e_73f72653","line":66,"in_reply_to":"effbf480_a797902d","updated":"2021-03-31 15:44:41.000000000","message":"I can add an extra column but dst3 \u0026 dst4 is already there.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        {"},{"line_number":85,"context_line":"            \"bfd_monitor\": {"},{"line_number":86,"context_line":"                \"name\": \"bfd1\","},{"line_number":87,"context_line":"                \"mode\": \"asynchronous\","},{"line_number":88,"context_line":"                \"type\": \"singlehop\","},{"line_number":89,"context_line":"                \"min_rx\": 1000,"},{"line_number":90,"context_line":"                \"min_tx\": 100,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"e9fa9ee4_938a9596","line":87,"updated":"2021-03-23 13:35:30.000000000","message":"the mode can be asynchronous, demand, one-arm-echo","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        {"},{"line_number":85,"context_line":"            \"bfd_monitor\": {"},{"line_number":86,"context_line":"                \"name\": \"bfd1\","},{"line_number":87,"context_line":"                \"mode\": \"asynchronous\","},{"line_number":88,"context_line":"                \"type\": \"singlehop\","},{"line_number":89,"context_line":"                \"min_rx\": 1000,"},{"line_number":90,"context_line":"                \"min_tx\": 100,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"c449d74a_8be022f0","line":87,"in_reply_to":"e9fa9ee4_938a9596","updated":"2021-03-31 15:44:41.000000000","message":"it\u0027s written at l158","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            \"bfd_monitor\": {"},{"line_number":86,"context_line":"                \"name\": \"bfd1\","},{"line_number":87,"context_line":"                \"mode\": \"asynchronous\","},{"line_number":88,"context_line":"                \"type\": \"singlehop\","},{"line_number":89,"context_line":"                \"min_rx\": 1000,"},{"line_number":90,"context_line":"                \"min_tx\": 100,"},{"line_number":91,"context_line":"                \"multiplier\": 3,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"4db8476e_cab03e9d","line":88,"updated":"2021-03-23 13:35:30.000000000","message":"do we require a type?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cacda42351ffac76a4c6dda1e1a21b5048d8d2f4","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            \"bfd_monitor\": {"},{"line_number":86,"context_line":"                \"name\": \"bfd1\","},{"line_number":87,"context_line":"                \"mode\": \"asynchronous\","},{"line_number":88,"context_line":"                \"type\": \"singlehop\","},{"line_number":89,"context_line":"                \"min_rx\": 1000,"},{"line_number":90,"context_line":"                \"min_tx\": 100,"},{"line_number":91,"context_line":"                \"multiplier\": 3,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"2f8b2299_3e9044dc","line":88,"in_reply_to":"4db8476e_cab03e9d","updated":"2021-03-31 15:51:09.000000000","message":"I removed it to keep the API simpler and to cover only the tings that we can really support in the backend (auth can be a good question as that is in the RFC)","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                \"min_tx\": 100,"},{"line_number":91,"context_line":"                \"multiplier\": 3,"},{"line_number":92,"context_line":"                \"auth_type\": \"\","},{"line_number":93,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"d1ff015c_f4855061","line":93,"updated":"2021-03-23 13:35:30.000000000","message":"do we want to cover authentication for bfd sessions in this spec (and implementation)?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                \"min_tx\": 100,"},{"line_number":91,"context_line":"                \"multiplier\": 3,"},{"line_number":92,"context_line":"                \"auth_type\": \"\","},{"line_number":93,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aac977d_f1cce72d","line":93,"in_reply_to":"d1ff015c_f4855061","updated":"2021-03-31 15:44:41.000000000","message":"It\u0027s in the RFC, so I think the API should have fields for it, but for example ovs doesn\u0027t support it, so good question.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a8e6a5341357c8f185523580fb6346364636183b","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                \"multiplier\": 3,"},{"line_number":92,"context_line":"                \"auth_type\": \"\","},{"line_number":93,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* List bfd_monitors::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"a257343d_f827e7dc","line":94,"updated":"2021-03-29 11:49:12.000000000","message":"This example should have a dst_ip, right?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                \"multiplier\": 3,"},{"line_number":92,"context_line":"                \"auth_type\": \"\","},{"line_number":93,"context_line":"                \"auth_keys\": {1: \"secret_1\", 2: \"secret_2\"},"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* List bfd_monitors::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"a2c38d3a_79cd6a22","line":94,"in_reply_to":"a257343d_f827e7dc","updated":"2021-03-31 15:44:41.000000000","message":"Thanks it should","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* Update a bfd_monitor::"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        PUT /v2.0/bfd_monitors/{monitor_id}"},{"line_number":124,"context_line":"        {"},{"line_number":125,"context_line":"            \"bfd_monitor\": {"},{"line_number":126,"context_line":"                \"name\": \"bfd_monitor1\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"147a04a0_4d292769","line":123,"updated":"2021-03-23 13:35:30.000000000","message":"for a monitor that is already ACTIVE, when will this change in tx/rx/mult be realized?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cacda42351ffac76a4c6dda1e1a21b5048d8d2f4","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* Update a bfd_monitor::"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        PUT /v2.0/bfd_monitors/{monitor_id}"},{"line_number":124,"context_line":"        {"},{"line_number":125,"context_line":"            \"bfd_monitor\": {"},{"line_number":126,"context_line":"                \"name\": \"bfd_monitor1\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"37ae0323_95199670","line":123,"in_reply_to":"147a04a0_4d292769","updated":"2021-03-31 15:51:09.000000000","message":"a notification can be send to the responsible agent to update all existing sessions\u0027 values","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":159,"context_line":"|                   |         |       |      | common echo mode of BFD) or           |"},{"line_number":160,"context_line":"|                   |         |       |      | ``demand`` (some other mechanism is   |"},{"line_number":161,"context_line":"|                   |         |       |      | used to detect link state) and can    |"},{"line_number":162,"context_line":"|                   |         |       |      | accept future types like              |"},{"line_number":163,"context_line":"|                   |         |       |      | ``one-arm-echo`` see [3]_ .           |"},{"line_number":164,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":165,"context_line":"| type              | String  | No    | CR   | Can be ``singlehop``, ``multihop``    |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"f5819a87_1b3b7bbe","line":162,"updated":"2021-03-23 13:35:30.000000000","message":"future modes like","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":false,"context_lines":[{"line_number":159,"context_line":"|                   |         |       |      | common echo mode of BFD) or           |"},{"line_number":160,"context_line":"|                   |         |       |      | ``demand`` (some other mechanism is   |"},{"line_number":161,"context_line":"|                   |         |       |      | used to detect link state) and can    |"},{"line_number":162,"context_line":"|                   |         |       |      | accept future types like              |"},{"line_number":163,"context_line":"|                   |         |       |      | ``one-arm-echo`` see [3]_ .           |"},{"line_number":164,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":165,"context_line":"| type              | String  | No    | CR   | Can be ``singlehop``, ``multihop``    |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"8e95563f_1a8a64e5","line":162,"in_reply_to":"f5819a87_1b3b7bbe","updated":"2021-03-31 15:44:41.000000000","message":"Done","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":163,"context_line":"|                   |         |       |      | ``one-arm-echo`` see [3]_ .           |"},{"line_number":164,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":165,"context_line":"| type              | String  | No    | CR   | Can be ``singlehop``, ``multihop``    |"},{"line_number":166,"context_line":"|                   |         |       |      | and accepts future types.             |"},{"line_number":167,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":168,"context_line":"| dst_ip            | String  | Yes   | CR   | The destination IP address to be      |"},{"line_number":169,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"b92acc47_f8e7fa36","line":166,"updated":"2021-03-23 13:35:30.000000000","message":"this \"type\" might not be required","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":false,"context_lines":[{"line_number":163,"context_line":"|                   |         |       |      | ``one-arm-echo`` see [3]_ .           |"},{"line_number":164,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":165,"context_line":"| type              | String  | No    | CR   | Can be ``singlehop``, ``multihop``    |"},{"line_number":166,"context_line":"|                   |         |       |      | and accepts future types.             |"},{"line_number":167,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":168,"context_line":"| dst_ip            | String  | Yes   | CR   | The destination IP address to be      |"},{"line_number":169,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"6e0a48ab_4257eb54","line":166,"in_reply_to":"b92acc47_f8e7fa36","updated":"2021-03-31 15:44:41.000000000","message":"Done","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a8e6a5341357c8f185523580fb6346364636183b","unresolved":true,"context_lines":[{"line_number":169,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"},{"line_number":170,"context_line":"|                   |         |       |      | this is the nexthop ip of the route,  |"},{"line_number":171,"context_line":"|                   |         |       |      | for the general case (like multihop   |"},{"line_number":172,"context_line":"|                   |         |       |      | bfd) this is an arbitrary IP that can |"},{"line_number":173,"context_line":"|                   |         |       |      | serve as BFD neighbor.                |"},{"line_number":174,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":175,"context_line":"| src_ip            | String  | N/A   | R    | IP address used as source for         |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"8604c6c7_39bdbe45","line":172,"range":{"start_line":172,"start_character":63,"end_line":172,"end_character":75},"updated":"2021-03-29 11:49:12.000000000","message":"The validators allow both v4 or v6 (which is good). Maybe we should mention it here.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":false,"context_lines":[{"line_number":169,"context_line":"|                   |         |       |      | monitored. In case of singlehop bfd   |"},{"line_number":170,"context_line":"|                   |         |       |      | this is the nexthop ip of the route,  |"},{"line_number":171,"context_line":"|                   |         |       |      | for the general case (like multihop   |"},{"line_number":172,"context_line":"|                   |         |       |      | bfd) this is an arbitrary IP that can |"},{"line_number":173,"context_line":"|                   |         |       |      | serve as BFD neighbor.                |"},{"line_number":174,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":175,"context_line":"| src_ip            | String  | N/A   | R    | IP address used as source for         |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"eaa8e2ce_210b5c54","line":172,"range":{"start_line":172,"start_character":63,"end_line":172,"end_character":75},"in_reply_to":"8604c6c7_39bdbe45","updated":"2021-03-31 15:44:41.000000000","message":"Done","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":261,"context_line":"            \u0027type\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":262,"context_line":"                     \u0027validate\u0027: {\u0027type:string\u0027: db_const.STATUS_FIELD_SIZE},"},{"line_number":263,"context_line":"                     \u0027default\u0027: BFD_MODE_SINGLEHOP, \u0027is_filter\u0027: True,"},{"line_number":264,"context_line":"                     \u0027is_sort_key\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":265,"context_line":"            \u0027dst_ip\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":266,"context_line":"                       \u0027validate\u0027: {\u0027type:ip_address\u0027: None},"},{"line_number":267,"context_line":"                       \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"0e8a6453_f7a9e5ef","line":264,"updated":"2021-03-23 13:35:30.000000000","message":"ditto, might not be required.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            \u0027type\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":262,"context_line":"                     \u0027validate\u0027: {\u0027type:string\u0027: db_const.STATUS_FIELD_SIZE},"},{"line_number":263,"context_line":"                     \u0027default\u0027: BFD_MODE_SINGLEHOP, \u0027is_filter\u0027: True,"},{"line_number":264,"context_line":"                     \u0027is_sort_key\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":265,"context_line":"            \u0027dst_ip\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":266,"context_line":"                       \u0027validate\u0027: {\u0027type:ip_address\u0027: None},"},{"line_number":267,"context_line":"                       \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"97f3d8dc_1e018312","line":264,"in_reply_to":"0e8a6453_f7a9e5ef","updated":"2021-03-31 15:44:41.000000000","message":"Done","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":311,"context_line":"    REQUIRED_EXTENSIONS \u003d [l3.ALIAS]"},{"line_number":312,"context_line":"    OPTIONAL_EXTENSIONS \u003d []"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"* Show bfd_monitor status (For details see rfc5880, State Variables section)::"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":317,"context_line":"        {"}],"source_content_type":"text/x-rst","patch_set":13,"id":"28ad0058_39048f76","line":314,"updated":"2021-03-23 13:35:30.000000000","message":"show bfd session status","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    REQUIRED_EXTENSIONS \u003d [l3.ALIAS]"},{"line_number":312,"context_line":"    OPTIONAL_EXTENSIONS \u003d []"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"* Show bfd_monitor status (For details see rfc5880, State Variables section)::"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        GET /v2.0/bfd_monitors/{monitor_id}/session_status"},{"line_number":317,"context_line":"        {"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ff216598_3837d0c3","line":314,"in_reply_to":"28ad0058_39048f76","updated":"2021-03-31 15:44:41.000000000","message":"Done","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"* Show bfd_monitor associations::"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"       GET /v2.0/bfd_monitors/{monitor_id}/bfd_monitor_associations"},{"line_number":346,"context_line":"       {"},{"line_number":347,"context_line":"            \"bfd_monitor_associations\": {"},{"line_number":348,"context_line":"                \"remotes\": [{"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ebb0597f_45e356c0","line":345,"updated":"2021-03-23 13:35:30.000000000","message":"this is really cool !","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":363,"context_line":".. note::"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    ``type`` is kept in the above API proposal to make the API flexible enough"},{"line_number":366,"context_line":"    for later additions of BFD monitoring targets."},{"line_number":367,"context_line":""},{"line_number":368,"context_line":".. note::"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"f5200330_9f749281","line":366,"updated":"2021-03-23 13:35:30.000000000","message":"Not sure if it matters for the tenant to configure BFD as single-hop or multi-hop given that it typically runs over UDP. \n\nCould we please avoid this field?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":363,"context_line":".. note::"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    ``type`` is kept in the above API proposal to make the API flexible enough"},{"line_number":366,"context_line":"    for later additions of BFD monitoring targets."},{"line_number":367,"context_line":""},{"line_number":368,"context_line":".. note::"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"e5586556_abc040f9","line":366,"in_reply_to":"f5200330_9f749281","updated":"2021-03-31 15:44:41.000000000","message":"thanks, I removed","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":450,"context_line":"                    { \"destination\" : \"10.0.3.0/24\","},{"line_number":451,"context_line":"                      \"nexthop\" : \"10.0.0.13\","},{"line_number":452,"context_line":"                      \"status\": \"UP\","},{"line_number":453,"context_line":"                      \"bfd_monitor\": {bfd_monitor_uuid}"},{"line_number":454,"context_line":"                    },"},{"line_number":455,"context_line":"                ]"},{"line_number":456,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":13,"id":"c7d84003_d5430958","line":453,"updated":"2021-03-23 13:35:30.000000000","message":"the \u0027status\u0027 and \u0027bfd-monitor\u0027 fields will not be available for non-bfd-monitored extra-route-destinations but will be available in routes-status output for only bfd-monitored destinations, is that correct understanding by us?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":450,"context_line":"                    { \"destination\" : \"10.0.3.0/24\","},{"line_number":451,"context_line":"                      \"nexthop\" : \"10.0.0.13\","},{"line_number":452,"context_line":"                      \"status\": \"UP\","},{"line_number":453,"context_line":"                      \"bfd_monitor\": {bfd_monitor_uuid}"},{"line_number":454,"context_line":"                    },"},{"line_number":455,"context_line":"                ]"},{"line_number":456,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":13,"id":"a19bdcdd_6ebbf386","line":453,"in_reply_to":"37f1a976_27283966","updated":"2021-03-31 15:44:41.000000000","message":"I can imagine even a \"not-monitored\" state","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a8e6a5341357c8f185523580fb6346364636183b","unresolved":true,"context_lines":[{"line_number":450,"context_line":"                    { \"destination\" : \"10.0.3.0/24\","},{"line_number":451,"context_line":"                      \"nexthop\" : \"10.0.0.13\","},{"line_number":452,"context_line":"                      \"status\": \"UP\","},{"line_number":453,"context_line":"                      \"bfd_monitor\": {bfd_monitor_uuid}"},{"line_number":454,"context_line":"                    },"},{"line_number":455,"context_line":"                ]"},{"line_number":456,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":13,"id":"37f1a976_27283966","line":453,"in_reply_to":"c7d84003_d5430958","updated":"2021-03-29 11:49:12.000000000","message":"To me it seems slightly less surprising to the user if the status is there (as always \"UP\") for other extraroutes too.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a8e6a5341357c8f185523580fb6346364636183b","unresolved":true,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    [6]_ proposes the change of the ``hostroutes`` validator to accept a list"},{"line_number":493,"context_line":"    of possible fields to validate, like: ``destination``, ``nexthop`` and"},{"line_number":494,"context_line":"    ``bfd_monitor_id``."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"BFD itself and fetching bfd_monitor session status information can be quite"},{"line_number":497,"context_line":"resource intensive operation (the information must be fetched from the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"d9250417_9631daae","line":494,"updated":"2021-03-29 11:49:12.000000000","message":"Just a side note: We will need to cross-check the IP version of a BFD monitor with the IP version of the extraroute and only accept them for the same IP version.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    [6]_ proposes the change of the ``hostroutes`` validator to accept a list"},{"line_number":493,"context_line":"    of possible fields to validate, like: ``destination``, ``nexthop`` and"},{"line_number":494,"context_line":"    ``bfd_monitor_id``."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"BFD itself and fetching bfd_monitor session status information can be quite"},{"line_number":497,"context_line":"resource intensive operation (the information must be fetched from the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"69e70c7c_8dbe4220","line":494,"in_reply_to":"d9250417_9631daae","updated":"2021-03-31 15:44:41.000000000","message":"ack, I made a mental note","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a8e6a5341357c8f185523580fb6346364636183b","unresolved":true,"context_lines":[{"line_number":511,"context_line":"route updated and bfd_monitor value is set to empty, the bfd_monitor is"},{"line_number":512,"context_line":"deleted in the backend."},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"As a bfd_monitor can be associated to many routes, if it is associated to"},{"line_number":515,"context_line":"at least on route and the creation in the backend is successful the ``status``"},{"line_number":516,"context_line":"field of the bfd_monitor is ``UP``, and it will change to ``DOWN`` when the"},{"line_number":517,"context_line":"last route association is deleted (the bfd_monitor is deleted from the last"}],"source_content_type":"text/x-rst","patch_set":13,"id":"26e24d6a_6542c00d","line":514,"updated":"2021-03-29 11:49:12.000000000","message":"I find this quite confusing. We are talking about the status of the monitor (and not the session), right? Can we use some other words so people don\u0027t confuse this with the session UP/DOWN? For example the standard DOWN/ACTIVE.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":511,"context_line":"route updated and bfd_monitor value is set to empty, the bfd_monitor is"},{"line_number":512,"context_line":"deleted in the backend."},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"As a bfd_monitor can be associated to many routes, if it is associated to"},{"line_number":515,"context_line":"at least on route and the creation in the backend is successful the ``status``"},{"line_number":516,"context_line":"field of the bfd_monitor is ``UP``, and it will change to ``DOWN`` when the"},{"line_number":517,"context_line":"last route association is deleted (the bfd_monitor is deleted from the last"}],"source_content_type":"text/x-rst","patch_set":13,"id":"4250c7bb_a608ddc1","line":514,"in_reply_to":"26e24d6a_6542c00d","updated":"2021-03-31 15:44:41.000000000","message":"Could you please check it?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"a8e6a5341357c8f185523580fb6346364636183b","unresolved":true,"context_lines":[{"line_number":519,"context_line":""},{"line_number":520,"context_line":"Backend"},{"line_number":521,"context_line":"~~~~~~~"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"os-ken can be used to handle BFD (see [5]_ )."},{"line_number":524,"context_line":"os-ken is able to start bfd_sessions in an ``OSKenApp``, and in this case"},{"line_number":525,"context_line":"the application starts a session that can send and receive BFD packet, and"}],"source_content_type":"text/x-rst","patch_set":13,"id":"19a29ac5_4d85263a","line":522,"updated":"2021-03-29 11:49:12.000000000","message":"I\u0027m wondering if the \"Backend\" section is needed here at all. I understand we need to find a good-enough backend, but behavior for end users is not affected by it, so maybe we can leave this for the implementation patches.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7a85a42450ec6ea34cf5c9c8c61bc0ec63c58944","unresolved":true,"context_lines":[{"line_number":519,"context_line":""},{"line_number":520,"context_line":"Backend"},{"line_number":521,"context_line":"~~~~~~~"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"os-ken can be used to handle BFD (see [5]_ )."},{"line_number":524,"context_line":"os-ken is able to start bfd_sessions in an ``OSKenApp``, and in this case"},{"line_number":525,"context_line":"the application starts a session that can send and receive BFD packet, and"}],"source_content_type":"text/x-rst","patch_set":13,"id":"d6b0c507_3c8af20b","line":522,"in_reply_to":"19a29ac5_4d85263a","updated":"2021-03-31 15:44:41.000000000","message":"Thanks, I removed, and interested on the opinion of others as well.\nOVS seems to be the most convenient backend (after burning weeks with os-ken\u0027s bfdlib), but it has its own limitations, and design restrictions, like touching ovsdb from l3, or adding a new l2-agent-extension and rpc everything to it, or the other thing that ovs can support only 1 bfd instance on 1 port, so we need new port for every bfd session.","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"dc135b07bda726d88c22a57fd2c78197fa512d8f","unresolved":true,"context_lines":[{"line_number":537,"context_line":"when bfd_monitor extension is started."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"The bfd_monitor OSKenApp needs to register the packet_in_handler from"},{"line_number":540,"context_line":"``BFDLib`` instance."},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"To notify the bfd_monitor agent extension about extraroute changes"},{"line_number":543,"context_line":"``ResourcesPushRpcApi`` can be used."}],"source_content_type":"text/x-rst","patch_set":13,"id":"576125bc_521350ce","line":540,"updated":"2021-03-23 13:35:30.000000000","message":"does every BFDPacket received from the Peer triggers a PACKET-IN towards the OVS-L2-Agent because of our feature.\n\nWon\u0027t so many BFDPackets received due to multiple BFD Monitors being configured negative overwhelm timely handling of BFD HELLO Packets?\n\nSummatively,  query from us is will our implementation here lead to situations where we mark session-state as DOWN due to our own control plane delays rather than true delays in sending BFD Packets by peer?","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"555639e02a791e7fbebd1208caedef5c11481a8b","unresolved":true,"context_lines":[{"line_number":537,"context_line":"when bfd_monitor extension is started."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"The bfd_monitor OSKenApp needs to register the packet_in_handler from"},{"line_number":540,"context_line":"``BFDLib`` instance."},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"To notify the bfd_monitor agent extension about extraroute changes"},{"line_number":543,"context_line":"``ResourcesPushRpcApi`` can be used."}],"source_content_type":"text/x-rst","patch_set":13,"id":"9736ff55_3a88859b","line":540,"in_reply_to":"576125bc_521350ce","updated":"2021-03-24 17:17:36.000000000","message":"Yes, if os-ken bfdlib is used a packet_in_handler must be registered and that will \"filter-out\" bfd packets and act based on them.\nI have more and more doubts regarding to use os-ken bfdlib or not, as during my experiments I had many issues with it, which I tried to summarize here.\nFor some discussion regarding it please see l3-meeting log: http://eavesdrop.openstack.org/irclogs/%23openstack-meeting/%23openstack-meeting.2021-03-24.log.html#t2021-03-24T14:48:03","commit_id":"1f6728aeae97b47d835e80c3a08c18e59519dec3"}],"specs/xena/bfd_support.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78c72a3f637bf52f85707b3cf366bfa77b22448a","unresolved":true,"context_lines":[{"line_number":155,"context_line":"| description       | String  | No    | CRU  | Human readable description for the    |"},{"line_number":156,"context_line":"|                   |         |       |      | bfd_monitor (255 characters limit).   |"},{"line_number":157,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":158,"context_line":"| project_id        | uuid-str| No    | R    | Owner of the bfd_monitor.             |"},{"line_number":159,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":160,"context_line":"| mode              | String  | No    | CR   | Can be ``asynchronous`` (default      |"},{"line_number":161,"context_line":"|                   |         |       |      | common echo mode of BFD) or           |"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3bb49948_1368531c","line":158,"range":{"start_line":158,"start_character":22,"end_line":158,"end_character":26},"updated":"2021-04-08 10:37:45.000000000","message":"nit: project_id isn\u0027t uuid","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"abf0927d698dcb51e4a1ad94767cbe9f90e1f4ff","unresolved":true,"context_lines":[{"line_number":155,"context_line":"| description       | String  | No    | CRU  | Human readable description for the    |"},{"line_number":156,"context_line":"|                   |         |       |      | bfd_monitor (255 characters limit).   |"},{"line_number":157,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":158,"context_line":"| project_id        | uuid-str| No    | R    | Owner of the bfd_monitor.             |"},{"line_number":159,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":160,"context_line":"| mode              | String  | No    | CR   | Can be ``asynchronous`` (default      |"},{"line_number":161,"context_line":"|                   |         |       |      | common echo mode of BFD) or           |"}],"source_content_type":"text/x-rst","patch_set":18,"id":"cf51ff54_c099b4ff","line":158,"range":{"start_line":158,"start_character":22,"end_line":158,"end_character":26},"in_reply_to":"3bb49948_1368531c","updated":"2021-06-23 15:59:40.000000000","message":"thanks, I changed it to string","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78c72a3f637bf52f85707b3cf366bfa77b22448a","unresolved":true,"context_lines":[{"line_number":320,"context_line":"                    },"},{"line_number":321,"context_line":"                    \"status\": {"},{"line_number":322,"context_line":"                        \"SessionState\": \"Init, Up, Down\","},{"line_number":323,"context_line":"                        \"RemoteSessionState\": \"Init, Up, Down\","},{"line_number":324,"context_line":"                        \"LocalDiagnostic\": \"\","},{"line_number":325,"context_line":"                        \"RemoteDiagnostic\": \"\","},{"line_number":326,"context_line":"                        \"LocalDiscriminator\": \"\","}],"source_content_type":"text/x-rst","patch_set":18,"id":"acc85ac7_5380a2cd","line":323,"updated":"2021-04-08 10:37:45.000000000","message":"those \"Init, Up and Down\" are possible values, right? Maybe would be better to give only one value here as an example.","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"abf0927d698dcb51e4a1ad94767cbe9f90e1f4ff","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                    },"},{"line_number":321,"context_line":"                    \"status\": {"},{"line_number":322,"context_line":"                        \"SessionState\": \"Init, Up, Down\","},{"line_number":323,"context_line":"                        \"RemoteSessionState\": \"Init, Up, Down\","},{"line_number":324,"context_line":"                        \"LocalDiagnostic\": \"\","},{"line_number":325,"context_line":"                        \"RemoteDiagnostic\": \"\","},{"line_number":326,"context_line":"                        \"LocalDiscriminator\": \"\","}],"source_content_type":"text/x-rst","patch_set":18,"id":"64a64b44_683b2869","line":323,"in_reply_to":"acc85ac7_5380a2cd","updated":"2021-06-23 15:59:40.000000000","message":"Done","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78c72a3f637bf52f85707b3cf366bfa77b22448a","unresolved":true,"context_lines":[{"line_number":514,"context_line":"OVS can handle BFD on an interface and check the status of it."},{"line_number":515,"context_line":"The problem with it is that ovs can have 1 BFD session per port, and"},{"line_number":516,"context_line":"to manage it ovsdb is the simplest way, but as LIU Yulong stated in [7]_"},{"line_number":517,"context_line":"touching ovsdb from l3-agent can be weird."},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"},{"line_number":520,"context_line":"implementation is os-ken is not mature enough, and it needs ovsdb connection"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ad6e61cf_8a193d78","line":517,"updated":"2021-04-08 10:37:45.000000000","message":"Actually it already uses \"intrface\" driver to e.g. create ports in the ovs or set DEAD_VLAN tag on such ports. Maybe we can have similar drivers for the BFD monitors so it may be used in L3 agent and works fine with openvswitch and linuxbridge L2 agents.","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"abf0927d698dcb51e4a1ad94767cbe9f90e1f4ff","unresolved":true,"context_lines":[{"line_number":514,"context_line":"OVS can handle BFD on an interface and check the status of it."},{"line_number":515,"context_line":"The problem with it is that ovs can have 1 BFD session per port, and"},{"line_number":516,"context_line":"to manage it ovsdb is the simplest way, but as LIU Yulong stated in [7]_"},{"line_number":517,"context_line":"touching ovsdb from l3-agent can be weird."},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"},{"line_number":520,"context_line":"implementation is os-ken is not mature enough, and it needs ovsdb connection"}],"source_content_type":"text/x-rst","patch_set":18,"id":"f26e7424_4a81aa7d","line":517,"in_reply_to":"ad6e61cf_8a193d78","updated":"2021-06-23 15:59:40.000000000","message":"Actually I spent the last months with finding how it should work with OVS (or with anything at all), for ovs see my mail: https://mail.openvswitch.org/pipermail/ovs-discuss/2021-April/051086.html\n( I sent the same actually to ovs-dev and to bugs@openvswitch.org without answer....)\nAnd finally today I got the help from Ericsson\u0027s ovs developers and it seems that the solution can be what I wrote below: create a bridge (like br-bfd) and create veth pair one veth in br-bfd and one in br-int and start bfd on the veth in br-bfd.\n\nWhat do you think?","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78c72a3f637bf52f85707b3cf366bfa77b22448a","unresolved":true,"context_lines":[{"line_number":517,"context_line":"touching ovsdb from l3-agent can be weird."},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"},{"line_number":520,"context_line":"implementation is os-ken is not mature enough, and it needs ovsdb connection"},{"line_number":521,"context_line":"anyway, so I do not suggest os-ken to be used for BFD."},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"f5a3e787_40b8d663","line":520,"range":{"start_line":520,"start_character":15,"end_line":520,"end_character":17},"updated":"2021-04-08 10:37:45.000000000","message":"nitty nit: s/is/in probably","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"abf0927d698dcb51e4a1ad94767cbe9f90e1f4ff","unresolved":false,"context_lines":[{"line_number":517,"context_line":"touching ovsdb from l3-agent can be weird."},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"},{"line_number":520,"context_line":"implementation is os-ken is not mature enough, and it needs ovsdb connection"},{"line_number":521,"context_line":"anyway, so I do not suggest os-ken to be used for BFD."},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"6fdc28cd_f722a6c1","line":520,"range":{"start_line":520,"start_character":15,"end_line":520,"end_character":17},"in_reply_to":"f5a3e787_40b8d663","updated":"2021-06-23 15:59:40.000000000","message":"Done","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"78c72a3f637bf52f85707b3cf366bfa77b22448a","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"},{"line_number":520,"context_line":"implementation is os-ken is not mature enough, and it needs ovsdb connection"},{"line_number":521,"context_line":"anyway, so I do not suggest os-ken to be used for BFD."},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"Data Model Impact"},{"line_number":524,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":18,"id":"b47e8361_dc633c96","line":521,"updated":"2021-04-08 10:37:45.000000000","message":"just a question - what about OVN? Did You check it with that backend maybe?","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"abf0927d698dcb51e4a1ad94767cbe9f90e1f4ff","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"},{"line_number":520,"context_line":"implementation is os-ken is not mature enough, and it needs ovsdb connection"},{"line_number":521,"context_line":"anyway, so I do not suggest os-ken to be used for BFD."},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"Data Model Impact"},{"line_number":524,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":18,"id":"e938bd56_7c9034dd","line":521,"in_reply_to":"b47e8361_dc633c96","updated":"2021-06-23 15:59:40.000000000","message":"I checked OVN as it uses BFD for monitoring chassis from gw node, but OVN at the end goes to OVS, am I right? \nI checked FRR for example and that is promising, but it\u0027s not yet ready to be integrated to an \"SDN solution\" like Neutron (at least I see this way). It works if you configure it (BFD, BGP,.....) but to use it programmatically they at the moment just promise that there will be nice shiny interface for it (YANG with grpc or similar) but now it is experimental and not everything works, and have to rebuild the whole stuff with yang support.\nSo FRR worth to follow as possible tool to integrate to Neutron, and that can be managed from OVN as well (like ltomasbo started for OVN BGP agent)","commit_id":"1fa85e5e624b07b203fbe882db0e386b9dd23bda"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"ea60ec5de34ab15ac4ebfdf68ff65ad7fbfba94e","unresolved":true,"context_lines":[{"line_number":488,"context_line":"The routes_status API endpoint gives feedback to the user if the monitored"},{"line_number":489,"context_line":"link is up."},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"If the bfd_monitor\u0027s session_status is DOWN (BFD detects the given link dead)"},{"line_number":492,"context_line":"the given route should be removed in the backend (on the command line: ip r"},{"line_number":493,"context_line":"delete....), and set back if the monitor is UP again."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":496,"context_line":"associated with any routes, the ``status`` of the bfd_monitor is set to"}],"source_content_type":"text/x-rst","patch_set":19,"id":"a468e229_01241c32","line":493,"range":{"start_line":491,"start_character":0,"end_line":493,"end_character":53},"updated":"2021-04-30 05:45:02.000000000","message":"How is the applications(l3ecmp/bgp etc) notified when the bfd monitor\u0027s session status is DOWN? Does this sentence mean that the BFD would automatically go and delete the route for applications? Or is this route something specific to BFD?","commit_id":"687e8a73234bd1254c219ba0e103cd12a75f4a5b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ee3592310ddcb6180d00487355f60ab2791ad865","unresolved":true,"context_lines":[{"line_number":488,"context_line":"The routes_status API endpoint gives feedback to the user if the monitored"},{"line_number":489,"context_line":"link is up."},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"If the bfd_monitor\u0027s session_status is DOWN (BFD detects the given link dead)"},{"line_number":492,"context_line":"the given route should be removed in the backend (on the command line: ip r"},{"line_number":493,"context_line":"delete....), and set back if the monitor is UP again."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":496,"context_line":"associated with any routes, the ``status`` of the bfd_monitor is set to"}],"source_content_type":"text/x-rst","patch_set":19,"id":"fffd3613_74a26a23","line":493,"range":{"start_line":491,"start_character":0,"end_line":493,"end_character":53},"in_reply_to":"a468e229_01241c32","updated":"2021-05-04 13:01:12.000000000","message":"As the given direction is down the route is \"dead\", so the route can be removed, on the backend, and on the API show that the BFD status is down for it with the \"GET /v2.0/routers/{router_id}/routes_status\" query for example.\nIs this answers your question?","commit_id":"687e8a73234bd1254c219ba0e103cd12a75f4a5b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bf57050c18203faaa2414a778cf0050d56075bfe","unresolved":true,"context_lines":[{"line_number":498,"context_line":"the extra route updated and bfd_monitor value is set to empty, so the"},{"line_number":499,"context_line":"bfd_monitor is deleted in the backend."},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"As a bfd_monitor can be associated to many routes, if it is associated to"},{"line_number":502,"context_line":"at least one route and the creation in the backend is successful the"},{"line_number":503,"context_line":"``status`` field of the bfd_monitor is ``ACTIVE``, and it will change to"},{"line_number":504,"context_line":"``DOWN`` when the last route association is deleted (the bfd_monitor is"}],"source_content_type":"text/x-rst","patch_set":19,"id":"2db3adc0_1093a653","line":501,"updated":"2021-06-22 16:41:40.000000000","message":"Just a question that is linked to the implementation: a BFD monitor can be associated with more than one route, but how many routers? Just one? Where is this instance running?","commit_id":"687e8a73234bd1254c219ba0e103cd12a75f4a5b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"abf0927d698dcb51e4a1ad94767cbe9f90e1f4ff","unresolved":true,"context_lines":[{"line_number":498,"context_line":"the extra route updated and bfd_monitor value is set to empty, so the"},{"line_number":499,"context_line":"bfd_monitor is deleted in the backend."},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"As a bfd_monitor can be associated to many routes, if it is associated to"},{"line_number":502,"context_line":"at least one route and the creation in the backend is successful the"},{"line_number":503,"context_line":"``status`` field of the bfd_monitor is ``ACTIVE``, and it will change to"},{"line_number":504,"context_line":"``DOWN`` when the last route association is deleted (the bfd_monitor is"}],"source_content_type":"text/x-rst","patch_set":19,"id":"f3b98e2f_8a92d803","line":501,"in_reply_to":"2db3adc0_1093a653","updated":"2021-06-23 15:59:40.000000000","message":"A BFD monitor can be associated to more routers routes. Now I finally got help from OVS developers so it seems that with veth pairs created between a bridge (like br-bfd) and br-int we can have one bfd session on the veth connected to br-bfd. So one BFD session per one veth port in br-bfd. Sadly bfd is an entry in ovsdb thus we can have 1 session per port.","commit_id":"687e8a73234bd1254c219ba0e103cd12a75f4a5b"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BFD (Bidirectional Forwarding Detection) can be used to detect link failures"},{"line_number":20,"context_line":"between a Neutron router and an arbitrary destination, like an external"},{"line_number":21,"context_line":"non-Neutron router."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BFD can be used to provide quick, low-overhead link failure detection between"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a4eb470_803c32af","line":20,"updated":"2021-07-07 06:17:22.000000000","message":"Neutron Router and destinations reachable from the router like:\na.  VM Primary IP Addresses available on subnets managed by the router\nb.  External Gateway hosted IP Addresses reachable through external-gateway-interfaces of the router.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This spec is not covering other use cases like tunnel monitoring and HA or"},{"line_number":30,"context_line":"    DVR router monitoring, or BGP or other routing protocol monitoring."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9d9f374b_6077a476","line":30,"updated":"2021-07-07 06:17:22.000000000","message":"Can we please provide on example to indicate that IPv6 BFD Monitoring is also covered by the implementation of the Spec?\n\nAlso since HA-Capable routers are most frequently used, we need to attempt in our implementation to support such Routers being able to run BFD monitoring.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2b29b2736cb8d525ca72beca3cc1b108cde05a22","unresolved":false,"context_lines":[{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This spec is not covering other use cases like tunnel monitoring and HA or"},{"line_number":30,"context_line":"    DVR router monitoring, or BGP or other routing protocol monitoring."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":20,"id":"0465fbe5_9d710e15","line":30,"in_reply_to":"17b691c6_e648e5ae","updated":"2021-07-30 16:35:15.000000000","message":"There\u0027s no such restriction now, but I will make sure to allow such operation and document it if in the reference implementation it is not supported.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"eba4c7f3a0b7899cb5f1ad5009a65f2500c23232","unresolved":false,"context_lines":[{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This spec is not covering other use cases like tunnel monitoring and HA or"},{"line_number":30,"context_line":"    DVR router monitoring, or BGP or other routing protocol monitoring."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":20,"id":"17b691c6_e648e5ae","line":30,"in_reply_to":"4500737b_1763faca","updated":"2021-07-30 08:02:33.000000000","message":"Could we request to make sure that the API should NOT be at a disadvantage for HA Routers?\n\ni.e.,  We request that atleast the BFD-Monitor API must allow the bfd-monitor resource to be attachable to an Extra Route configured on HA-Capable Centralized Neutron Router.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This spec is not covering other use cases like tunnel monitoring and HA or"},{"line_number":30,"context_line":"    DVR router monitoring, or BGP or other routing protocol monitoring."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":20,"id":"4500737b_1763faca","line":30,"in_reply_to":"9d9f374b_6077a476","updated":"2021-07-07 13:06:12.000000000","message":"I will check ovs with ipv6, there is no mention of not supporting it\n\nthis limitation was added to keep the upstream version as lightweight as possible, but as I see nothing prevents use to add HA capability later, or downstream","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* monitoring 2 different destinations through the same nexthop, the case"},{"line_number":63,"context_line":"  when bfd3 and bfd4 dst_ip is the same is not covered here."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"+------+----------+----------+------+"},{"line_number":66,"context_line":"| dst3 | nexthop3 | bfd_dst3 | bfd3 |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"45e83d2c_36d05e6d","line":63,"updated":"2021-07-07 06:17:22.000000000","message":"this might need to be covered.  It is unclear to us why such a common use-case isn\u0027t covered.\nMost of the VNFs will host multiple Service-IP Addresses within them.   So for such multiple Service-IP-Addresses as destinations of extra-route, the nexthop might be the same VNF Primary-Neutron-IP-Address.\n\nCan we please educate us why we decided not to support this here?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* monitoring 2 different destinations through the same nexthop, the case"},{"line_number":63,"context_line":"  when bfd3 and bfd4 dst_ip is the same is not covered here."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"+------+----------+----------+------+"},{"line_number":66,"context_line":"| dst3 | nexthop3 | bfd_dst3 | bfd3 |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"6eebbafd_895aa473","line":63,"in_reply_to":"45e83d2c_36d05e6d","updated":"2021-07-07 13:06:12.000000000","message":"I check this, as I remember it was written somewhere","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"eba4c7f3a0b7899cb5f1ad5009a65f2500c23232","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* monitoring 2 different destinations through the same nexthop, the case"},{"line_number":63,"context_line":"  when bfd3 and bfd4 dst_ip is the same is not covered here."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"+------+----------+----------+------+"},{"line_number":66,"context_line":"| dst3 | nexthop3 | bfd_dst3 | bfd3 |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"fc28e874_02108b27","line":63,"in_reply_to":"6eebbafd_895aa473","updated":"2021-07-30 08:02:33.000000000","message":"could you please come back on this?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":157,"context_line":"| project_id        | String  | No    | R    | Owner of the bfd_monitor.             |"},{"line_number":158,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":159,"context_line":"| mode              | String  | No    | CR   | Can be ``asynchronous`` (default      |"},{"line_number":160,"context_line":"|                   |         |       |      | common echo mode of BFD) or           |"},{"line_number":161,"context_line":"|                   |         |       |      | ``demand`` (some other mechanism is   |"},{"line_number":162,"context_line":"|                   |         |       |      | used to detect link state) and can    |"},{"line_number":163,"context_line":"|                   |         |       |      | accept future modes like              |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"4ea6cc27_1caf6d15","line":160,"updated":"2021-07-07 06:17:22.000000000","message":"asynchronous,   demand and one-arm-echo must be the 3 supported modes.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":157,"context_line":"| project_id        | String  | No    | R    | Owner of the bfd_monitor.             |"},{"line_number":158,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":159,"context_line":"| mode              | String  | No    | CR   | Can be ``asynchronous`` (default      |"},{"line_number":160,"context_line":"|                   |         |       |      | common echo mode of BFD) or           |"},{"line_number":161,"context_line":"|                   |         |       |      | ``demand`` (some other mechanism is   |"},{"line_number":162,"context_line":"|                   |         |       |      | used to detect link state) and can    |"},{"line_number":163,"context_line":"|                   |         |       |      | accept future modes like              |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"49d94543_baf5fd21","line":160,"in_reply_to":"4ea6cc27_1caf6d15","updated":"2021-07-07 13:06:12.000000000","message":"all 3 is listed in the Description of this field as I see","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":168,"context_line":"|                   |         |       |      | this is the nexthop ip of the route,  |"},{"line_number":169,"context_line":"|                   |         |       |      | for the general case (like multihop   |"},{"line_number":170,"context_line":"|                   |         |       |      | bfd) this is an arbitrary IP (IPv4 or |"},{"line_number":171,"context_line":"|                   |         |       |      | Ipv6) that can serve as BFD neighbor. |"},{"line_number":172,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":173,"context_line":"| min_rx            | Integer | No    | CRU  | The shortest interval, in millisecs,  |"},{"line_number":174,"context_line":"|                   |         |       |      | at which this BFD session offers to   |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"2b54e071_f1de89cd","line":171,"updated":"2021-07-07 06:17:22.000000000","message":"can you please let us know why we have not included the src_ip into the bfd-monitor?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":168,"context_line":"|                   |         |       |      | this is the nexthop ip of the route,  |"},{"line_number":169,"context_line":"|                   |         |       |      | for the general case (like multihop   |"},{"line_number":170,"context_line":"|                   |         |       |      | bfd) this is an arbitrary IP (IPv4 or |"},{"line_number":171,"context_line":"|                   |         |       |      | Ipv6) that can serve as BFD neighbor. |"},{"line_number":172,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":173,"context_line":"| min_rx            | Integer | No    | CRU  | The shortest interval, in millisecs,  |"},{"line_number":174,"context_line":"|                   |         |       |      | at which this BFD session offers to   |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"72b29c94_a28c37ce","line":171,"in_reply_to":"2b54e071_f1de89cd","updated":"2021-07-07 13:06:12.000000000","message":"src_ip is a read_only field for GET /session_status and GET /bfd_monitor_associations as that is the ip of the router\u0027s port","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"eba4c7f3a0b7899cb5f1ad5009a65f2500c23232","unresolved":false,"context_lines":[{"line_number":168,"context_line":"|                   |         |       |      | this is the nexthop ip of the route,  |"},{"line_number":169,"context_line":"|                   |         |       |      | for the general case (like multihop   |"},{"line_number":170,"context_line":"|                   |         |       |      | bfd) this is an arbitrary IP (IPv4 or |"},{"line_number":171,"context_line":"|                   |         |       |      | Ipv6) that can serve as BFD neighbor. |"},{"line_number":172,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":173,"context_line":"| min_rx            | Integer | No    | CRU  | The shortest interval, in millisecs,  |"},{"line_number":174,"context_line":"|                   |         |       |      | at which this BFD session offers to   |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"738975e5_64a420e2","line":171,"in_reply_to":"72b29c94_a28c37ce","updated":"2021-07-30 08:02:33.000000000","message":"Different backend implementations use different Source-IP Addresses for BFD Monitoring.  For example,  a Fabric-driven backend allocates an additional Neutron Port (with its IP carved from \n same tenant subnet) wherein that Port is NOT THE NEUTRON ROUTER-INTERFACE Port.\n\nSo we request that the API needs to allow the flexibility to input a \"source-ip address\" into the bfd-monitor resource during (or) after its creation for supporting fabric-driven Neutron backend.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2b29b2736cb8d525ca72beca3cc1b108cde05a22","unresolved":false,"context_lines":[{"line_number":168,"context_line":"|                   |         |       |      | this is the nexthop ip of the route,  |"},{"line_number":169,"context_line":"|                   |         |       |      | for the general case (like multihop   |"},{"line_number":170,"context_line":"|                   |         |       |      | bfd) this is an arbitrary IP (IPv4 or |"},{"line_number":171,"context_line":"|                   |         |       |      | Ipv6) that can serve as BFD neighbor. |"},{"line_number":172,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":173,"context_line":"| min_rx            | Integer | No    | CRU  | The shortest interval, in millisecs,  |"},{"line_number":174,"context_line":"|                   |         |       |      | at which this BFD session offers to   |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"f07a0421_dc7f762c","line":171,"in_reply_to":"738975e5_64a420e2","updated":"2021-07-30 16:35:15.000000000","message":"I updated the api-def spec:\nhttps://review.opendev.org/c/openstack/neutron-lib/+/775420/12/neutron_lib/api/definitions/bfd_monitor.py#65\n\nI will push an update/followup for the spec","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":201,"context_line":"| auth_key          | Dict    | No    | CR   | A dictionary of authentication key    |"},{"line_number":202,"context_line":"|                   |         |       |      | chain in which key is an integer of   |"},{"line_number":203,"context_line":"|                   |         |       |      | ``Auth Key ID`` and value is a string |"},{"line_number":204,"context_line":"|                   |         |       |      | of ``Password`` or ``Auth Key``.      |"},{"line_number":205,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":".. Note::"}],"source_content_type":"text/x-rst","patch_set":20,"id":"e34ca59e_43293a7c","line":204,"updated":"2021-07-07 06:17:22.000000000","message":"do we intend to support securing BFD sessions?  \n\nThis was not in our original scope for this spec, but just wanted to know if driving this would make it easy / difficult from both implementation \u0026 upstream release timeline perspectve?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":201,"context_line":"| auth_key          | Dict    | No    | CR   | A dictionary of authentication key    |"},{"line_number":202,"context_line":"|                   |         |       |      | chain in which key is an integer of   |"},{"line_number":203,"context_line":"|                   |         |       |      | ``Auth Key ID`` and value is a string |"},{"line_number":204,"context_line":"|                   |         |       |      | of ``Password`` or ``Auth Key``.      |"},{"line_number":205,"context_line":"+-------------------+---------+-------+------+---------------------------------------+"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":".. Note::"}],"source_content_type":"text/x-rst","patch_set":20,"id":"842e2dd4_f7375171","line":204,"in_reply_to":"e34ca59e_43293a7c","updated":"2021-07-07 13:06:12.000000000","message":"I added it here to cover all things in BFD rfc, to keep the API open for future designs.\nos-ken for example supports authentication, bunt nor ovs nor FRR.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":223,"context_line":"    BFD_SESSION_STATUS \u003d \u0027bfd_session_status\u0027"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    BFD_MODE_ASYNC \u003d \u0027asynchronous\u0027"},{"line_number":226,"context_line":"    BFD_MODE_SINGLEHOP \u003d \u0027singlehop\u0027"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":229,"context_line":"        BFD_MONITORS: {"}],"source_content_type":"text/x-rst","patch_set":20,"id":"e98ed828_ff7661c8","line":226,"updated":"2021-07-07 06:17:22.000000000","message":"this is not a supported mode for us.  Can we please remove this.. As said earlier:\nasynchrounous, demand and one-arm echo can be our supported modes.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    BFD_SESSION_STATUS \u003d \u0027bfd_session_status\u0027"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    BFD_MODE_ASYNC \u003d \u0027asynchronous\u0027"},{"line_number":226,"context_line":"    BFD_MODE_SINGLEHOP \u003d \u0027singlehop\u0027"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":229,"context_line":"        BFD_MONITORS: {"}],"source_content_type":"text/x-rst","patch_set":20,"id":"7746a5e0_a70345f5","line":226,"in_reply_to":"e98ed828_ff7661c8","updated":"2021-07-07 13:06:12.000000000","message":"good catch that is a leftover from a previous version, I will push perhaps a followup","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":367,"context_line":"| Attribute          | Description                                         |"},{"line_number":368,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":369,"context_line":"| SessionState       | The state of the BFD session, it can be             |"},{"line_number":370,"context_line":"|                    | ``admin_down``, ``down``, ``init``,  or ``up``.     |"},{"line_number":371,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":372,"context_line":"| RemoteSessionState | The state of the remote endpoint\u0027s BFD session, it  |"},{"line_number":373,"context_line":"|                    | can be ``admin_down``, ``down``, ``init``,  or      |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"b3561123_f9f156aa","line":370,"updated":"2021-07-07 06:17:22.000000000","message":"how can we make a SessionState admin-down through our existing BFD Service API proposed above?\n\nOr are these state fields values driven with (RFC + Linux BFD) ?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":367,"context_line":"| Attribute          | Description                                         |"},{"line_number":368,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":369,"context_line":"| SessionState       | The state of the BFD session, it can be             |"},{"line_number":370,"context_line":"|                    | ``admin_down``, ``down``, ``init``,  or ``up``.     |"},{"line_number":371,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":372,"context_line":"| RemoteSessionState | The state of the remote endpoint\u0027s BFD session, it  |"},{"line_number":373,"context_line":"|                    | can be ``admin_down``, ``down``, ``init``,  or      |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"a7909101_1d9d27cc","line":370,"in_reply_to":"b3561123_f9f156aa","updated":"2021-07-07 13:06:12.000000000","message":"These are from the rfc and OVS uses the same session state names","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":371,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":372,"context_line":"| RemoteSessionState | The state of the remote endpoint\u0027s BFD session, it  |"},{"line_number":373,"context_line":"|                    | can be ``admin_down``, ``down``, ``init``,  or      |"},{"line_number":374,"context_line":"|                    | ``up``.                                             |"},{"line_number":375,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":376,"context_line":"| LocalDiagnostic    | A diagnostic code specifying the local system\u0027s     |"},{"line_number":377,"context_line":"|                    | reason for the last change in session state. The    |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"1582a1c1_6b0e4563","line":374,"updated":"2021-07-07 06:17:22.000000000","message":"it is not clear to us what is difference between SessionState and RemoteSessionState.  Which one is of interest to us to decide to INACTIVATE a destination of extra-route?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":371,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":372,"context_line":"| RemoteSessionState | The state of the remote endpoint\u0027s BFD session, it  |"},{"line_number":373,"context_line":"|                    | can be ``admin_down``, ``down``, ``init``,  or      |"},{"line_number":374,"context_line":"|                    | ``up``.                                             |"},{"line_number":375,"context_line":"+--------------------+-----------------------------------------------------+"},{"line_number":376,"context_line":"| LocalDiagnostic    | A diagnostic code specifying the local system\u0027s     |"},{"line_number":377,"context_line":"|                    | reason for the last change in session state. The    |"}],"source_content_type":"text/x-rst","patch_set":20,"id":"e27d9605_35719240","line":374,"in_reply_to":"1582a1c1_6b0e4563","updated":"2021-07-07 13:06:12.000000000","message":"remote session state is from the rfc, and OVS implementation as well (ovs-vswitchd doc: https://www.freebsd.org/cgi/man.cgi?query\u003dovs-vswitchd.conf.db\u0026apropos\u003d0\u0026sektion\u003d5\u0026manpath\u003dFreeBSD+Ports+9.0-RELEASE\u0026arch\u003ddefault\u0026format\u003dhtml )","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"* Changes to Add extra routes to router or Update router API::"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        PUT /v2.0/routers/{router_id}"},{"line_number":409,"context_line":"        {"},{"line_number":410,"context_line":"            \"router\": {"},{"line_number":411,"context_line":"                \"routes\": ["}],"source_content_type":"text/x-rst","patch_set":20,"id":"a7dd7d0a_086eb059","line":408,"updated":"2021-07-07 06:17:22.000000000","message":"Is update-router API still supported to manage extra-routes?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"* Changes to Add extra routes to router or Update router API::"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        PUT /v2.0/routers/{router_id}"},{"line_number":409,"context_line":"        {"},{"line_number":410,"context_line":"            \"router\": {"},{"line_number":411,"context_line":"                \"routes\": ["}],"source_content_type":"text/x-rst","patch_set":20,"id":"6ec19db6_64b151aa","line":408,"in_reply_to":"a7dd7d0a_086eb059","updated":"2021-07-07 13:06:12.000000000","message":"yes","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"* Get routes status::"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        GET /v2.0/routers/{router_id}/routes_status"},{"line_number":434,"context_line":"        {"},{"line_number":435,"context_line":"            \"router\": {"},{"line_number":436,"context_line":"                \"routes\": ["}],"source_content_type":"text/x-rst","patch_set":20,"id":"cddf62b7_d055dd7b","line":433,"updated":"2021-07-07 06:17:22.000000000","message":"can this API be used to identify what all BFD-Monitors are used by a given router?\n\nOr does a GET v2.0/router/\u003crouter-id\u003e REST API itself will be enhanced to show all bfd-monitors available on a given router?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"54302d3200efdd8ac9ac98c47cabcbff07badbcd","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"* Get routes status::"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        GET /v2.0/routers/{router_id}/routes_status"},{"line_number":434,"context_line":"        {"},{"line_number":435,"context_line":"            \"router\": {"},{"line_number":436,"context_line":"                \"routes\": ["}],"source_content_type":"text/x-rst","patch_set":20,"id":"dc0e8e45_bee00e03","line":433,"in_reply_to":"305292d3_5173471f","updated":"2021-08-05 08:50:40.000000000","message":"the GET routers API shows routes and bfd_monitors, example from my not yet pushed environment:\n$ curl -H \"X-Auth-Token: $MY_TOKEN\"  -X GET \"http://127.0.0.1:9696/v2.0/routers\" |json_pp\n{\n   \"routers\" : [\n      {\n         \"admin_state_up\" : true,\n         ...\n         \"routes\" : [\n            {\n               \"bfd_monitor_id\" : \"06833654-f575-4a35-baff-2d724672ff07\",\n               \"destination\" : \"20.0.20.0/24\",\n               \"nexthop\" : \"100.109.1.199\"\n            }\n         ],\n         \"status\" : \"ACTIVE\",\n         ...\n      }\n   ]\n}","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"eba4c7f3a0b7899cb5f1ad5009a65f2500c23232","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"* Get routes status::"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        GET /v2.0/routers/{router_id}/routes_status"},{"line_number":434,"context_line":"        {"},{"line_number":435,"context_line":"            \"router\": {"},{"line_number":436,"context_line":"                \"routes\": ["}],"source_content_type":"text/x-rst","patch_set":20,"id":"305292d3_5173471f","line":433,"in_reply_to":"c6842974_b05ec74c","updated":"2021-07-30 08:02:33.000000000","message":"Are you confirming here that router\u0027s routes list is gettable through the current neutron router-show (GET /v2.0/routers/\u003crouter-id\u003e API) and that will show extra-routes along with bfd-monitor names?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"* Get routes status::"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        GET /v2.0/routers/{router_id}/routes_status"},{"line_number":434,"context_line":"        {"},{"line_number":435,"context_line":"            \"router\": {"},{"line_number":436,"context_line":"                \"routes\": ["}],"source_content_type":"text/x-rst","patch_set":20,"id":"c6842974_b05ec74c","line":433,"in_reply_to":"cddf62b7_d055dd7b","updated":"2021-07-07 13:06:12.000000000","message":"The router\u0027s routes list will show the bfd monitors associated with destination-nexthop pairs, but the routers/\u003crouter_id\u003e/routes_status can show the BFD session status","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":436,"context_line":"                \"routes\": ["},{"line_number":437,"context_line":"                    { \"destination\" : \"10.0.3.0/24\","},{"line_number":438,"context_line":"                      \"nexthop\" : \"10.0.0.13\","},{"line_number":439,"context_line":"                      \"status\": \"UP\","},{"line_number":440,"context_line":"                      \"bfd_monitor\": {bfd_monitor_uuid}"},{"line_number":441,"context_line":"                    },"},{"line_number":442,"context_line":"                ]"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bf19a425_7d20642c","line":439,"updated":"2021-07-07 06:17:22.000000000","message":"is this Status value of \u0027UP\u0027 based on SESSION-STATUS feedback of the bfd-monitor below?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                \"routes\": ["},{"line_number":437,"context_line":"                    { \"destination\" : \"10.0.3.0/24\","},{"line_number":438,"context_line":"                      \"nexthop\" : \"10.0.0.13\","},{"line_number":439,"context_line":"                      \"status\": \"UP\","},{"line_number":440,"context_line":"                      \"bfd_monitor\": {bfd_monitor_uuid}"},{"line_number":441,"context_line":"                    },"},{"line_number":442,"context_line":"                ]"}],"source_content_type":"text/x-rst","patch_set":20,"id":"7afd99b9_151530b6","line":439,"in_reply_to":"bf19a425_7d20642c","updated":"2021-07-07 13:06:12.000000000","message":"exactly","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":441,"context_line":"                    },"},{"line_number":442,"context_line":"                ]"},{"line_number":443,"context_line":"            }"},{"line_number":444,"context_line":"        }"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"API extension proposal for allowing bfd_monitor association to extra_routes:"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"b68f0fb1_035c1356","line":444,"updated":"2021-07-07 06:17:22.000000000","message":"can you please add a section here on how a tenant will remove a bfd-monitor for an existing extra-route ?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"eba4c7f3a0b7899cb5f1ad5009a65f2500c23232","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                    },"},{"line_number":442,"context_line":"                ]"},{"line_number":443,"context_line":"            }"},{"line_number":444,"context_line":"        }"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"API extension proposal for allowing bfd_monitor association to extra_routes:"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"4afe2ce2_5079cc0b","line":444,"in_reply_to":"980672b7_1cbd9dac","updated":"2021-07-30 08:02:33.000000000","message":"Our question was pertinent to fact that a tenant needed to retain the extra-route in the router, but no longer wants to run BFD-Monitor for that extra-route.  Is that case via current API in this spec possible?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                    },"},{"line_number":442,"context_line":"                ]"},{"line_number":443,"context_line":"            }"},{"line_number":444,"context_line":"        }"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"API extension proposal for allowing bfd_monitor association to extra_routes:"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"980672b7_1cbd9dac","line":444,"in_reply_to":"b68f0fb1_035c1356","updated":"2021-07-07 13:06:12.000000000","message":"the already existing API can be used, i.e.:\n/v2.0/routers/{router_id}/remove_extraroutes {....}","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"If the bfd_monitor\u0027s session_status is DOWN (BFD detects the given link dead)"},{"line_number":492,"context_line":"the given route should be removed in the backend (on the command line: ip r"},{"line_number":493,"context_line":"delete....), and set back if the monitor is UP again."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":496,"context_line":"associated with any routes, the ``status`` of the bfd_monitor is set to"}],"source_content_type":"text/x-rst","patch_set":20,"id":"007ac12f_7777f731","line":493,"updated":"2021-07-07 06:17:22.000000000","message":"would the \u0027route\u0027 for which session-status is DOWN still reflect atleast in the output of /route_status API with Status value for impacted destination shown as \u0027DOWN\u0027?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"If the bfd_monitor\u0027s session_status is DOWN (BFD detects the given link dead)"},{"line_number":492,"context_line":"the given route should be removed in the backend (on the command line: ip r"},{"line_number":493,"context_line":"delete....), and set back if the monitor is UP again."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"The bfd_monitor instance in the backend is created when the bfd_monitor is"},{"line_number":496,"context_line":"associated with any routes, the ``status`` of the bfd_monitor is set to"}],"source_content_type":"text/x-rst","patch_set":20,"id":"d896a086_872f81ab","line":493,"in_reply_to":"007ac12f_7777f731","updated":"2021-07-07 13:06:12.000000000","message":"yes, that\u0027s the plan","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":513,"context_line":"touching ovsdb from l3-agent can be weird."},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"A working solution with OVS is to create a BFD bridge, like br-bfd, and"},{"line_number":516,"context_line":"add veth ports to it, and enable BFD on those interfaces."},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"::"},{"line_number":519,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"fa3119b2_f39c9591","line":516,"updated":"2021-07-07 06:17:22.000000000","message":"Can we please have a more elaborate description here on how we are planning to acheive this implementation ?\n\nIf a router has 3 extra-routes configured on a route rand each such extra-route has a single nexthop to be monitored (i.e, 3 bfd-monitors on the router), will that result in 3 veth-interfaces to be plugged into br-bfd?   What will be the IP Addresses of such interfaces plugged into br-bfd?  Will such IP Addresses be different from the router-interface-ip-address that makes the respective monitored nexthop reachable?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":524,"context_line":"            |"},{"line_number":525,"context_line":"            | veth-xy"},{"line_number":526,"context_line":"          --------"},{"line_number":527,"context_line":"         | br-bfd |"},{"line_number":528,"context_line":"          --------"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"}],"source_content_type":"text/x-rst","patch_set":20,"id":"fbe5a441_dc68d930","line":527,"updated":"2021-07-07 06:17:22.000000000","message":"It would be good to state here who will be driving the BFD plumbing and backend tie-up of results of such BFD towards the extra-routes hosted by the router.\n\nDo we plan to have a separate BFD-Agent?  If yes, how will that Agent notify the L3-Agent to inactivate certain extra-route destinations based on the attached BFD-Monitor reporting session-state as DOWN?\n\nIf we donot have a separate BFD-Agent,  will the L3-Agent be overloaded to perform BFD tasks?","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            |"},{"line_number":525,"context_line":"            | veth-xy"},{"line_number":526,"context_line":"          --------"},{"line_number":527,"context_line":"         | br-bfd |"},{"line_number":528,"context_line":"          --------"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"}],"source_content_type":"text/x-rst","patch_set":20,"id":"1b1daa72_653d3a7b","line":527,"in_reply_to":"fbe5a441_dc68d930","updated":"2021-07-07 13:06:12.000000000","message":"the plan is to use l3-agent","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"459d9f7a93cdcad0ed379b2909814179ba4e13e0","unresolved":true,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"},{"line_number":531,"context_line":"implementation in os-ken is not mature enough, and it needs ovsdb connection"},{"line_number":532,"context_line":"anyway, so I do not suggest os-ken to be used for BFD."},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"Data Model Impact"},{"line_number":535,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3f76aa5c_b78fcfcc","line":532,"updated":"2021-07-07 06:17:22.000000000","message":"we agree with this point, that relying on OVS is better than OS-KEN, as OVS BFD has earlier been successfully used with vxlan-tunnel-monitoring.","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e91e0443aed880379173fbc2156de65c6e0ea337","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"Another possibility is to use os-ken, but during my experiments the BFD"},{"line_number":531,"context_line":"implementation in os-ken is not mature enough, and it needs ovsdb connection"},{"line_number":532,"context_line":"anyway, so I do not suggest os-ken to be used for BFD."},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"Data Model Impact"},{"line_number":535,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":20,"id":"5b235afa_e433a4e2","line":532,"in_reply_to":"3f76aa5c_b78fcfcc","updated":"2021-07-07 13:06:12.000000000","message":"Ack","commit_id":"e35a6606f093cd87f72becabbdfcba0729187d18"}]}