)]}'
{"specs/wallaby/distributed_dhcp.rst":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e322db522e397c53e13d89dc082b4838c5c25502","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  failure."},{"line_number":40,"context_line":"* Full sync in unknown reason cause the message Queue, neutron-server and"},{"line_number":41,"context_line":"  DB in high load."},{"line_number":42,"context_line":"* DVR local router creation for the scheduled DHCP port in default config"},{"line_number":43,"context_line":"  option."},{"line_number":44,"context_line":"* Down a DHCP node cause long time recovery of it has tons of scheduled"},{"line_number":45,"context_line":"  network instance"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ea30697_4bea153f","line":43,"range":{"start_line":42,"start_character":56,"end_line":43,"end_character":9},"updated":"2020-12-28 05:58:43.000000000","message":"This is not quite clear to me. Do you mean DVR router is created on the node with only DHCP port?","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e7c71563f8cf04b73e9499e14ba60ab31ae88fa4","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  failure."},{"line_number":40,"context_line":"* Full sync in unknown reason cause the message Queue, neutron-server and"},{"line_number":41,"context_line":"  DB in high load."},{"line_number":42,"context_line":"* DVR local router creation for the scheduled DHCP port in default config"},{"line_number":43,"context_line":"  option."},{"line_number":44,"context_line":"* Down a DHCP node cause long time recovery of it has tons of scheduled"},{"line_number":45,"context_line":"  network instance"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"88916c40_042b0c17","line":43,"range":{"start_line":42,"start_character":56,"end_line":43,"end_character":9},"in_reply_to":"1ea30697_4bea153f","updated":"2020-12-28 06:37:09.000000000","message":"Yes, see this patch:\nhttps://review.opendev.org/c/openstack/neutron/+/364793\n\nThere is a config option ``host_dvr_for_dhcp \u003d False`` which is the default behavior for Neutron.","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"985cb1535358216ad790dbf2882a909d41f1b8f1","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  failure."},{"line_number":40,"context_line":"* Full sync in unknown reason cause the message Queue, neutron-server and"},{"line_number":41,"context_line":"  DB in high load."},{"line_number":42,"context_line":"* DVR local router creation for the scheduled DHCP port in default config"},{"line_number":43,"context_line":"  option."},{"line_number":44,"context_line":"* Down a DHCP node cause long time recovery of it has tons of scheduled"},{"line_number":45,"context_line":"  network instance"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b3d810d4_76ee0824","line":43,"range":{"start_line":42,"start_character":56,"end_line":43,"end_character":9},"in_reply_to":"66a9e63b_5a94c794","updated":"2020-12-28 07:07:00.000000000","message":"maybe \"is default behavior\" then?","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"40dddb741aea7549be0bd20d0fa80d024d098112","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  failure."},{"line_number":40,"context_line":"* Full sync in unknown reason cause the message Queue, neutron-server and"},{"line_number":41,"context_line":"  DB in high load."},{"line_number":42,"context_line":"* DVR local router creation for the scheduled DHCP port in default config"},{"line_number":43,"context_line":"  option."},{"line_number":44,"context_line":"* Down a DHCP node cause long time recovery of it has tons of scheduled"},{"line_number":45,"context_line":"  network instance"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"66a9e63b_5a94c794","line":43,"range":{"start_line":42,"start_character":56,"end_line":43,"end_character":9},"in_reply_to":"88916c40_042b0c17","updated":"2020-12-28 06:41:25.000000000","message":"Sorry, the default value is True...the default behavior.","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a07f021ebe40fd7590fe717fc1add2807d7e20c7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  failure."},{"line_number":40,"context_line":"* Full sync in unknown reason cause the message Queue, neutron-server and"},{"line_number":41,"context_line":"  DB in high load."},{"line_number":42,"context_line":"* DVR local router creation for the scheduled DHCP port in default config"},{"line_number":43,"context_line":"  option."},{"line_number":44,"context_line":"* Down a DHCP node cause long time recovery of it has tons of scheduled"},{"line_number":45,"context_line":"  network instance"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b3d24fa8_c2c934b0","line":43,"range":{"start_line":42,"start_character":56,"end_line":43,"end_character":9},"in_reply_to":"b3d810d4_76ee0824","updated":"2020-12-28 08:00:55.000000000","message":"Done","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e322db522e397c53e13d89dc082b4838c5c25502","unresolved":true,"context_lines":[{"line_number":149,"context_line":"Potential configurations"},{"line_number":150,"context_line":"++++++++++++++++++++++++"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b12614e6_e6b34a31","line":152,"range":{"start_line":152,"start_character":57,"end_line":152,"end_character":64},"updated":"2020-12-28 05:58:43.000000000","message":"what means forever?","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a07f021ebe40fd7590fe717fc1add2807d7e20c7","unresolved":true,"context_lines":[{"line_number":149,"context_line":"Potential configurations"},{"line_number":150,"context_line":"++++++++++++++++++++++++"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9847f114_bd905d46","line":152,"range":{"start_line":152,"start_character":57,"end_line":152,"end_character":64},"in_reply_to":"756c2450_64f6ca30","updated":"2020-12-28 08:00:55.000000000","message":"This word is removed.","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e7c71563f8cf04b73e9499e14ba60ab31ae88fa4","unresolved":true,"context_lines":[{"line_number":149,"context_line":"Potential configurations"},{"line_number":150,"context_line":"++++++++++++++++++++++++"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c48ac704_b8f549ac","line":152,"range":{"start_line":152,"start_character":57,"end_line":152,"end_character":64},"in_reply_to":"b12614e6_e6b34a31","updated":"2020-12-28 06:37:09.000000000","message":"Disable all DHCP related api/attibutes/RPC/scheduling for network, subnet, port and so on.","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"985cb1535358216ad790dbf2882a909d41f1b8f1","unresolved":true,"context_lines":[{"line_number":149,"context_line":"Potential configurations"},{"line_number":150,"context_line":"++++++++++++++++++++++++"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."}],"source_content_type":"text/x-rst","patch_set":1,"id":"756c2450_64f6ca30","line":152,"range":{"start_line":152,"start_character":57,"end_line":152,"end_character":64},"in_reply_to":"c48ac704_b8f549ac","updated":"2020-12-28 07:07:00.000000000","message":"forever sounds quite radical :) I expected smth like \"openflow_dhcp\" - which would mean disable traditional and enable OVS one","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e322db522e397c53e13d89dc082b4838c5c25502","unresolved":true,"context_lines":[{"line_number":150,"context_line":"++++++++++++++++++++++++"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"308fa0d3_9c8b5862","line":153,"range":{"start_line":153,"start_character":24,"end_line":153,"end_character":55},"updated":"2020-12-28 05:58:43.000000000","message":"this should go with 1, no?","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e7c71563f8cf04b73e9499e14ba60ab31ae88fa4","unresolved":true,"context_lines":[{"line_number":150,"context_line":"++++++++++++++++++++++++"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6f107023_f3cd20fd","line":153,"range":{"start_line":153,"start_character":24,"end_line":153,"end_character":55},"in_reply_to":"308fa0d3_9c8b5862","updated":"2020-12-28 06:37:09.000000000","message":"Hmmm, looks positive, I will update.","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a07f021ebe40fd7590fe717fc1add2807d7e20c7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"++++++++++++++++++++++++"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"20bf3c4b_52b7487b","line":153,"range":{"start_line":153,"start_character":24,"end_line":153,"end_character":55},"in_reply_to":"6f107023_f3cd20fd","updated":"2020-12-28 08:00:55.000000000","message":"Done","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e322db522e397c53e13d89dc082b4838c5c25502","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e5ad85c8_64fff1c2","line":154,"range":{"start_line":154,"start_character":14,"end_line":154,"end_character":58},"updated":"2020-12-28 05:58:43.000000000","message":"there is such a config option","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"985cb1535358216ad790dbf2882a909d41f1b8f1","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a3714ff7_d90543b4","line":154,"range":{"start_line":154,"start_character":14,"end_line":154,"end_character":58},"in_reply_to":"11889a28_dfc7418d","updated":"2020-12-28 07:07:00.000000000","message":"for lease_duration ovs agent is usually started with main neutron.conf along with openvswitch.ini, so should be good. For other options prabably need to move.","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a07f021ebe40fd7590fe717fc1add2807d7e20c7","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d56ad2e2_22acb68e","line":154,"range":{"start_line":154,"start_character":14,"end_line":154,"end_character":58},"in_reply_to":"a3714ff7_d90543b4","updated":"2020-12-28 08:00:55.000000000","message":"Done","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e7c71563f8cf04b73e9499e14ba60ab31ae88fa4","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"1. Add config option to disable traditional network DHCP forever."},{"line_number":153,"context_line":"2. Add config option to disable DHCP privisioning block."},{"line_number":154,"context_line":"3. Add config option for DHCP protocol, such as lease time, for"},{"line_number":155,"context_line":"   openvswitch agent."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"11889a28_dfc7418d","line":154,"range":{"start_line":154,"start_character":14,"end_line":154,"end_character":58},"in_reply_to":"e5ad85c8_64fff1c2","updated":"2020-12-28 06:37:09.000000000","message":"It is only available for DHCP agent or neutron_server. Ovs agent will need them.","commit_id":"34b8bb4fb0acc073da861e2bfc2d875359cd3806"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"911a85980619de9ad1d3853db9b3d04cd219d05b","unresolved":true,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"A new extension of Neutron openvswitch agent will be added to achieve the"},{"line_number":64,"context_line":"``Distributed DHCP``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: Linux bridge mechanism driver will not be considered, because this"},{"line_number":67,"context_line":"          new extension will rely on the openflow protocol and principle"}],"source_content_type":"text/x-rst","patch_set":2,"id":"836a8364_dac32f85","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":13},"updated":"2020-12-28 08:43:54.000000000","message":"Will \"OpenVSwitch DHCP\" or \"Openflow DHCP\" be less ambiguous name then?","commit_id":"e389b6fbc801283c5aa637c1b723090e4f5f1a81"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"21f51c74d568f7d9f616314d28822e92e93667a8","unresolved":true,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"A new extension of Neutron openvswitch agent will be added to achieve the"},{"line_number":64,"context_line":"``Distributed DHCP``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: Linux bridge mechanism driver will not be considered, because this"},{"line_number":67,"context_line":"          new extension will rely on the openflow protocol and principle"}],"source_content_type":"text/x-rst","patch_set":2,"id":"49c8bfaa_23428ea9","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":13},"in_reply_to":"836a8364_dac32f85","updated":"2020-12-30 08:32:20.000000000","message":"In the view of entire Neutron deployment, I may say it is indeed distributed, every compute nodes will serve the DHCP locally, no centralized stuff anymore. \u0027Openflow\u0027 and \u0027Openvswitch\u0027 are just the tools for us to achive the final goal: make DHCP distributed. Yes, it is just a naming method. We choose the name based on the result properties. We also have an famous example \u0027DVR\u0027, \u0027Distribtued virtual router\u0027, I don\u0027t think we can call it ``Iptables NAT Router`` or ``Policying Routing Router``. So, for this one, IMO, we can following the DVR\u0027s rule, because L3 and DHCP are basically in same service level for neutron now.","commit_id":"e389b6fbc801283c5aa637c1b723090e4f5f1a81"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"911a85980619de9ad1d3853db9b3d04cd219d05b","unresolved":true,"context_lines":[{"line_number":106,"context_line":"Server side changes"},{"line_number":107,"context_line":"+++++++++++++++++++"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"OpenvSwitch Agent side changes"},{"line_number":112,"context_line":"++++++++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bdaa8243_197e0306","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":4},"updated":"2020-12-28 08:43:54.000000000","message":"I guess server side changes should include network scheduling removal, DHCP agent notifications suppress, DHCP provisioning block removal, etc.","commit_id":"e389b6fbc801283c5aa637c1b723090e4f5f1a81"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"21f51c74d568f7d9f616314d28822e92e93667a8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Server side changes"},{"line_number":107,"context_line":"+++++++++++++++++++"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"OpenvSwitch Agent side changes"},{"line_number":112,"context_line":"++++++++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9de798ff_73ff1cfe","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":4},"in_reply_to":"bdaa8243_197e0306","updated":"2020-12-30 08:32:20.000000000","message":"Done","commit_id":"e389b6fbc801283c5aa637c1b723090e4f5f1a81"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"948114cef61d1f66f5efaeaeb655bb336f74302a","unresolved":true,"context_lines":[{"line_number":50,"context_line":"Too many DHCP agents will increase maintenance pressure for the operators,"},{"line_number":51,"context_line":"and make the centralized components overloaded."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"There is a trick is to schedule one network to all DHCP agents on all compute"},{"line_number":54,"context_line":"nodes. Firstly, this may work for tiny deployment with extremely few resources."},{"line_number":55,"context_line":"For large-scale deployment, it is basically impossible. Because there will be"},{"line_number":56,"context_line":"tens of thousands of Networks in Neutron, this will directly lead to a surge of"}],"source_content_type":"text/x-rst","patch_set":3,"id":"317b255c_694644f7","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":19},"updated":"2021-01-27 08:36:05.000000000","message":"nit: not needed","commit_id":"33228f81d31c2bcbbd03e5d48ed6f4cdd93bb644"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"669ac2a93fa3a1a9ba9c06d6cb7643713ea4e5ff","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Too many DHCP agents will increase maintenance pressure for the operators,"},{"line_number":51,"context_line":"and make the centralized components overloaded."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"There is a trick is to schedule one network to all DHCP agents on all compute"},{"line_number":54,"context_line":"nodes. Firstly, this may work for tiny deployment with extremely few resources."},{"line_number":55,"context_line":"For large-scale deployment, it is basically impossible. Because there will be"},{"line_number":56,"context_line":"tens of thousands of Networks in Neutron, this will directly lead to a surge of"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6276a55c_a7b22436","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":19},"in_reply_to":"317b255c_694644f7","updated":"2021-01-27 08:50:55.000000000","message":"Done","commit_id":"33228f81d31c2bcbbd03e5d48ed6f4cdd93bb644"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d0b8f579f21182b5e02c72e4ae4eb61e17090a46","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  address acquisition and virtual machine startup in other nodes."},{"line_number":101,"context_line":"* Virtual machine startup will no longer be affected by port\u0027s DHCP"},{"line_number":102,"context_line":"  configuration, which reduces the probability of VM spawning failure."},{"line_number":103,"context_line":"* DHCP request and reponse for VM will achieve a high success rate."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Server side changes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"15adc7a1_623f8087","line":103,"updated":"2021-01-04 20:52:19.000000000","message":"Will dnsmasq still be spawned to handle DNS?","commit_id":"33228f81d31c2bcbbd03e5d48ed6f4cdd93bb644"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"48a013fc526c91354c7c3877d01ff9f95fe50e49","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  address acquisition and virtual machine startup in other nodes."},{"line_number":101,"context_line":"* Virtual machine startup will no longer be affected by port\u0027s DHCP"},{"line_number":102,"context_line":"  configuration, which reduces the probability of VM spawning failure."},{"line_number":103,"context_line":"* DHCP request and reponse for VM will achieve a high success rate."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Server side changes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f96abb4b_d7000820","line":103,"in_reply_to":"15adc7a1_623f8087","updated":"2021-01-05 01:21:44.000000000","message":"No DHCP agent, so no dnsmasq (Line 98), and no DNS. But the Subnet DNS options will be still added to DHCP response related option.","commit_id":"33228f81d31c2bcbbd03e5d48ed6f4cdd93bb644"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d0b8f579f21182b5e02c72e4ae4eb61e17090a46","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":185,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":186,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Implementation"},{"line_number":189,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c252748b_c0501907","line":186,"updated":"2021-01-04 20:52:19.000000000","message":"Not only that, things like port-specific DHCP options will be ignored, right?  In the end this will more resemble what OVN does with support for a limited amount of options.","commit_id":"33228f81d31c2bcbbd03e5d48ed6f4cdd93bb644"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"48a013fc526c91354c7c3877d01ff9f95fe50e49","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":185,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":186,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Implementation"},{"line_number":189,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1e255b0b_d2f19fbd","line":186,"in_reply_to":"c252748b_c0501907","updated":"2021-01-05 01:21:44.000000000","message":"Port dns_domain, dns_name and extra_dhcp_opts, as well as Subnet dns_nameservers, host_routes, dns_nameservers and gateway_ip and so on, all these options will be added to the final DHCP response like dnsmasq do.\n\nNot only OVN, but also controllers like dragonflow and opendaylight have similar DHCP responder for their clouds. IMO, Neutron has the all conditions to support this natively, and this will be more easily for existing clouds to upgrade.","commit_id":"33228f81d31c2bcbbd03e5d48ed6f4cdd93bb644"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"948114cef61d1f66f5efaeaeb655bb336f74302a","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"None"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Testing"},{"line_number":210,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Functionality"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f5bde627_a510a356","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":7},"updated":"2021-01-27 08:36:05.000000000","message":"I guess this feature would require a separate CI tempest job, probably experimental one","commit_id":"33228f81d31c2bcbbd03e5d48ed6f4cdd93bb644"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"669ac2a93fa3a1a9ba9c06d6cb7643713ea4e5ff","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"None"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Testing"},{"line_number":210,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Functionality"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a0a17a1_14820c69","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":7},"in_reply_to":"f5bde627_a510a356","updated":"2021-01-27 08:50:55.000000000","message":"I will add fullstack test cases to use dhcp-client to set the VM\u0027s IP, yes, it is in line 215-216.","commit_id":"33228f81d31c2bcbbd03e5d48ed6f4cdd93bb644"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Distributed DHCP"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RFE: https://bugs.launchpad.net/neutron/+bug/1900934"}],"source_content_type":"text/x-rst","patch_set":4,"id":"0158e64f_44acae3c","line":8,"updated":"2021-01-08 12:09:54.000000000","message":"If this DHCP service is only for OVS, that should be in the title.","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Distributed DHCP"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RFE: https://bugs.launchpad.net/neutron/+bug/1900934"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3657df43_8518b1ab","line":8,"in_reply_to":"0158e64f_44acae3c","updated":"2021-01-11 10:44:22.000000000","message":"Done","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":50,"context_line":"Too many DHCP agents will increase maintenance pressure for the operators,"},{"line_number":51,"context_line":"and make the centralized components overloaded."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"There is a trick is to schedule one network to all DHCP agents on all compute"},{"line_number":54,"context_line":"nodes. Firstly, this may work for tiny deployment with extremely few resources."},{"line_number":55,"context_line":"For large-scale deployment, it is basically impossible. Because there will be"},{"line_number":56,"context_line":"tens of thousands of Networks in Neutron, this will directly lead to a surge of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"49f8a8b5_e8cc544e","line":53,"updated":"2021-01-08 12:09:54.000000000","message":"nit: well, not a trick but an architecture deployment option","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Too many DHCP agents will increase maintenance pressure for the operators,"},{"line_number":51,"context_line":"and make the centralized components overloaded."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"There is a trick is to schedule one network to all DHCP agents on all compute"},{"line_number":54,"context_line":"nodes. Firstly, this may work for tiny deployment with extremely few resources."},{"line_number":55,"context_line":"For large-scale deployment, it is basically impossible. Because there will be"},{"line_number":56,"context_line":"tens of thousands of Networks in Neutron, this will directly lead to a surge of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4c387f42_e0b86e7d","line":53,"in_reply_to":"49f8a8b5_e8cc544e","updated":"2021-01-11 10:44:22.000000000","message":"Done","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: Linux bridge mechanism driver will not be considered, because this"},{"line_number":67,"context_line":"          new extension will rely on the openflow protocol and principle"},{"line_number":68,"context_line":"          which is not possible for Linux bridge."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Solution Proposed"},{"line_number":71,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"18056b0b_53d7fbf3","line":68,"updated":"2021-01-08 12:09:54.000000000","message":"We also have OVN and SR-IOV in the in-tree ML2 plugins list.","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: Linux bridge mechanism driver will not be considered, because this"},{"line_number":67,"context_line":"          new extension will rely on the openflow protocol and principle"},{"line_number":68,"context_line":"          which is not possible for Linux bridge."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Solution Proposed"},{"line_number":71,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7515592c_f6711de7","line":68,"in_reply_to":"18056b0b_53d7fbf3","updated":"2021-01-11 10:44:22.000000000","message":"Since OVN and SR-IOV all have no extension, and Linux bridge is very similar way to ovs (agent). Moreover, OVN has such DHCP function now. Anyway, I will rephrase to make this more accurate.","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"After this we will have:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Higher level availability, DHCP requests are directly processed in the"},{"line_number":101,"context_line":"  computing nodes, it is completely distributed."},{"line_number":102,"context_line":"* No DHCP agent and its scheduling mechanism anymore"},{"line_number":103,"context_line":"* No extra external process for DHCP anymore"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a18add7_6cd7eb60","line":100,"range":{"start_line":100,"start_character":2,"end_line":100,"end_character":27},"updated":"2021-01-08 12:09:54.000000000","message":"That could be mistaken as HA, I would remove it.","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"After this we will have:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Higher level availability, DHCP requests are directly processed in the"},{"line_number":101,"context_line":"  computing nodes, it is completely distributed."},{"line_number":102,"context_line":"* No DHCP agent and its scheduling mechanism anymore"},{"line_number":103,"context_line":"* No extra external process for DHCP anymore"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c50faff1_4667e8f7","line":100,"range":{"start_line":100,"start_character":2,"end_line":100,"end_character":27},"in_reply_to":"5a18add7_6cd7eb60","updated":"2021-01-11 10:44:22.000000000","message":"I mean \"higher level availability than DHCP agent with it\u0027s schedlued `dnsmasq`\".","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":101,"context_line":"  computing nodes, it is completely distributed."},{"line_number":102,"context_line":"* No DHCP agent and its scheduling mechanism anymore"},{"line_number":103,"context_line":"* No extra external process for DHCP anymore"},{"line_number":104,"context_line":"* The (Neutron openvswith) agent downtime will no longer affect the"},{"line_number":105,"context_line":"  address acquisition and virtual machine startup in other nodes."},{"line_number":106,"context_line":"* Virtual machine startup will no longer be affected by port\u0027s DHCP"},{"line_number":107,"context_line":"  configuration, which reduces the probability of VM spawning failure."},{"line_number":108,"context_line":"* DHCP request and reponse for VM will achieve a high success rate."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5b4a3165_ed7c5a42","line":105,"range":{"start_line":104,"start_character":2,"end_line":105,"end_character":65},"updated":"2021-01-08 12:09:54.000000000","message":"How is this possible? The OVS agent process is a osken app manager that runs OVSNeutronAgentOSKenApp. That class attends to the handler events added to \"packet_in_handlers\". If the process is not running, how the osken app is going to attend to those requests?","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":true,"context_lines":[{"line_number":101,"context_line":"  computing nodes, it is completely distributed."},{"line_number":102,"context_line":"* No DHCP agent and its scheduling mechanism anymore"},{"line_number":103,"context_line":"* No extra external process for DHCP anymore"},{"line_number":104,"context_line":"* The (Neutron openvswith) agent downtime will no longer affect the"},{"line_number":105,"context_line":"  address acquisition and virtual machine startup in other nodes."},{"line_number":106,"context_line":"* Virtual machine startup will no longer be affected by port\u0027s DHCP"},{"line_number":107,"context_line":"  configuration, which reduces the probability of VM spawning failure."},{"line_number":108,"context_line":"* DHCP request and reponse for VM will achieve a high success rate."}],"source_content_type":"text/x-rst","patch_set":4,"id":"e1e101b1_7fd01615","line":105,"range":{"start_line":104,"start_character":2,"end_line":105,"end_character":65},"in_reply_to":"5b4a3165_ed7c5a42","updated":"2021-01-11 10:44:22.000000000","message":"I guess you missed the place \"in other nodes\", for traditional DHCP agent with it\u0027s schedlued `dnsmasq`. If a ovs-agent (or a host) is down, every scheduled `dnsmasq` will go down in this host.","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":130,"context_line":"APIs, notifications and RPCs will be changed to no operation or be skipped."},{"line_number":131,"context_line":"The config options only controls Neutron itself, the DHCP protocol will have"},{"line_number":132,"context_line":"no effect on. The final goal is to support the full features of DHCP protocol"},{"line_number":133,"context_line":"defined."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"OpenvSwitch Agent side changes"},{"line_number":136,"context_line":"++++++++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e203d3b5_8964f7cd","line":133,"updated":"2021-01-08 12:09:54.000000000","message":"Do you know what changes are needed? Can you specify them?","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":false,"context_lines":[{"line_number":130,"context_line":"APIs, notifications and RPCs will be changed to no operation or be skipped."},{"line_number":131,"context_line":"The config options only controls Neutron itself, the DHCP protocol will have"},{"line_number":132,"context_line":"no effect on. The final goal is to support the full features of DHCP protocol"},{"line_number":133,"context_line":"defined."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"OpenvSwitch Agent side changes"},{"line_number":136,"context_line":"++++++++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fe1a8e5d_04f4ce65","line":133,"in_reply_to":"e203d3b5_8964f7cd","updated":"2021-01-11 10:44:22.000000000","message":"Done","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Data Model Impact"},{"line_number":200,"context_line":"-----------------"},{"line_number":201,"context_line":"None"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"REST API Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"81b98501_349ad8f4","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":4},"updated":"2021-01-08 12:09:54.000000000","message":"You said we need DB changes","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Data Model Impact"},{"line_number":200,"context_line":"-----------------"},{"line_number":201,"context_line":"None"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"REST API Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"41769f12_ff8a8c96","line":201,"range":{"start_line":201,"start_character":0,"end_line":201,"end_character":4},"in_reply_to":"81b98501_349ad8f4","updated":"2021-01-11 10:44:22.000000000","message":"No new db models.","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":208,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":209,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Upgrading"},{"line_number":212,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"33e6adcc_1c484ddc","line":209,"updated":"2021-01-08 12:09:54.000000000","message":"Can you be more explicit about the changed APIs?","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":208,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":209,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Upgrading"},{"line_number":212,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c65eb9d2_92352256","line":209,"in_reply_to":"33e6adcc_1c484ddc","updated":"2021-01-11 10:44:22.000000000","message":"Actually no really API changes, this section and [Server side changes] have descibed the work about this. The config option will be used as a flag to enable/disable some codes.","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"382d0d24192f49023d984e15eba3dbf0f21317ae","unresolved":true,"context_lines":[{"line_number":227,"context_line":"  restart neutron-server processes."},{"line_number":228,"context_line":"* Setup the ovs-agent with ``dhcp`` extension"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Implementation"},{"line_number":232,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"c4783aae_bb16abf4","line":230,"updated":"2021-01-08 12:09:54.000000000","message":"Is it possible to document the parity gaps between this DHCP and the DHCP agent?","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2255410b23da407234b4b8ab7fc095e115313272","unresolved":true,"context_lines":[{"line_number":227,"context_line":"  restart neutron-server processes."},{"line_number":228,"context_line":"* Setup the ovs-agent with ``dhcp`` extension"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Implementation"},{"line_number":232,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"aceec4c0_88ac167d","line":230,"in_reply_to":"c4783aae_bb16abf4","updated":"2021-01-11 10:44:22.000000000","message":"OK, but just only one gap: no DNS lookup support.","commit_id":"c3b4e64de68aeb93da11f82c3166648bfb5dce68"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"948114cef61d1f66f5efaeaeb655bb336f74302a","unresolved":true,"context_lines":[{"line_number":78,"context_line":"distributed DHCP natively:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* ovs-agent is based on the python SDN controller ryu/os-ken"},{"line_number":81,"context_line":"* ovs-agent is fully distribtued, ovs-agent"},{"line_number":82,"context_line":"* ovs-agent has the entire resource information"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"So we can assume the Neutron openvswitch agent is a local SDN controller which"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fce3d6b4_93c3a8f6","line":81,"range":{"start_line":81,"start_character":34,"end_line":81,"end_character":43},"updated":"2021-01-27 08:36:05.000000000","message":"to be removed","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"948114cef61d1f66f5efaeaeb655bb336f74302a","unresolved":true,"context_lines":[{"line_number":78,"context_line":"distributed DHCP natively:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* ovs-agent is based on the python SDN controller ryu/os-ken"},{"line_number":81,"context_line":"* ovs-agent is fully distribtued, ovs-agent"},{"line_number":82,"context_line":"* ovs-agent has the entire resource information"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"So we can assume the Neutron openvswitch agent is a local SDN controller which"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f70ea7b_b6478cad","line":81,"range":{"start_line":81,"start_character":21,"end_line":81,"end_character":32},"updated":"2021-01-27 08:36:05.000000000","message":"typo","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"669ac2a93fa3a1a9ba9c06d6cb7643713ea4e5ff","unresolved":false,"context_lines":[{"line_number":78,"context_line":"distributed DHCP natively:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* ovs-agent is based on the python SDN controller ryu/os-ken"},{"line_number":81,"context_line":"* ovs-agent is fully distribtued, ovs-agent"},{"line_number":82,"context_line":"* ovs-agent has the entire resource information"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"So we can assume the Neutron openvswitch agent is a local SDN controller which"}],"source_content_type":"text/x-rst","patch_set":5,"id":"915f83d7_003659bb","line":81,"range":{"start_line":81,"start_character":21,"end_line":81,"end_character":32},"in_reply_to":"5f70ea7b_b6478cad","updated":"2021-01-27 08:50:55.000000000","message":"Done","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"669ac2a93fa3a1a9ba9c06d6cb7643713ea4e5ff","unresolved":false,"context_lines":[{"line_number":78,"context_line":"distributed DHCP natively:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* ovs-agent is based on the python SDN controller ryu/os-ken"},{"line_number":81,"context_line":"* ovs-agent is fully distribtued, ovs-agent"},{"line_number":82,"context_line":"* ovs-agent has the entire resource information"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"So we can assume the Neutron openvswitch agent is a local SDN controller which"}],"source_content_type":"text/x-rst","patch_set":5,"id":"aa6d5359_23c72f20","line":81,"range":{"start_line":81,"start_character":34,"end_line":81,"end_character":43},"in_reply_to":"fce3d6b4_93c3a8f6","updated":"2021-01-27 08:50:55.000000000","message":"Done","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"948114cef61d1f66f5efaeaeb655bb336f74302a","unresolved":true,"context_lines":[{"line_number":103,"context_line":"  computing nodes, it is completely distributed."},{"line_number":104,"context_line":"* No DHCP agent and its scheduling mechanism anymore"},{"line_number":105,"context_line":"* No extra external process for DHCP anymore"},{"line_number":106,"context_line":"* The (Neutron openvswith) agent downtime will no longer affect the"},{"line_number":107,"context_line":"  address acquisition and virtual machine startup in other nodes."},{"line_number":108,"context_line":"* Virtual machine startup will no longer be affected by port\u0027s DHCP"},{"line_number":109,"context_line":"  configuration, which reduces the probability of VM spawning failure."}],"source_content_type":"text/x-rst","patch_set":5,"id":"a4511e3e_0f8011e0","line":106,"range":{"start_line":106,"start_character":7,"end_line":106,"end_character":25},"updated":"2021-01-27 08:36:05.000000000","message":"did you mean dhcp agent or ovs agent on network node?","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"669ac2a93fa3a1a9ba9c06d6cb7643713ea4e5ff","unresolved":true,"context_lines":[{"line_number":103,"context_line":"  computing nodes, it is completely distributed."},{"line_number":104,"context_line":"* No DHCP agent and its scheduling mechanism anymore"},{"line_number":105,"context_line":"* No extra external process for DHCP anymore"},{"line_number":106,"context_line":"* The (Neutron openvswith) agent downtime will no longer affect the"},{"line_number":107,"context_line":"  address acquisition and virtual machine startup in other nodes."},{"line_number":108,"context_line":"* Virtual machine startup will no longer be affected by port\u0027s DHCP"},{"line_number":109,"context_line":"  configuration, which reduces the probability of VM spawning failure."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1c96060e_a3bdc1e9","line":106,"range":{"start_line":106,"start_character":7,"end_line":106,"end_character":25},"in_reply_to":"a4511e3e_0f8011e0","updated":"2021-01-27 08:50:55.000000000","message":"Any node has running DHCP agent and ovs-agent, while it has scheduled DHCP (namespace and dnsmasq) instance.","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"948114cef61d1f66f5efaeaeb655bb336f74302a","unresolved":true,"context_lines":[{"line_number":175,"context_line":"1. Listen on the EventOFPPacketIn event"},{"line_number":176,"context_line":"2. Verify each packet to be DHCPv4 or DHCPv6"},{"line_number":177,"context_line":"3. According to the openflow inport number to retrieve the port\u0027s information"},{"line_number":178,"context_line":"4. Assemble the DHCP(v4/v6) response and ``packet_out`` to ``in_port``."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Potential configurations"},{"line_number":181,"context_line":"++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5090c7c3_7ca69941","line":178,"range":{"start_line":178,"start_character":3,"end_line":178,"end_character":71},"updated":"2021-01-27 08:36:05.000000000","message":"Which IP address will response have?","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"669ac2a93fa3a1a9ba9c06d6cb7643713ea4e5ff","unresolved":false,"context_lines":[{"line_number":175,"context_line":"1. Listen on the EventOFPPacketIn event"},{"line_number":176,"context_line":"2. Verify each packet to be DHCPv4 or DHCPv6"},{"line_number":177,"context_line":"3. According to the openflow inport number to retrieve the port\u0027s information"},{"line_number":178,"context_line":"4. Assemble the DHCP(v4/v6) response and ``packet_out`` to ``in_port``."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Potential configurations"},{"line_number":181,"context_line":"++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f86ea8c_3e350a31","line":178,"range":{"start_line":178,"start_character":3,"end_line":178,"end_character":71},"in_reply_to":"5090c7c3_7ca69941","updated":"2021-01-27 08:50:55.000000000","message":"Only the first IP, the secondary IPs will not be considered. I will update.","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"948114cef61d1f66f5efaeaeb655bb336f74302a","unresolved":true,"context_lines":[{"line_number":252,"context_line":"If you need a pure deployment without DHCP agents, the following is an overview"},{"line_number":253,"context_line":"about how to migrate to use this new feature:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":256,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":257,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."},{"line_number":258,"context_line":"* After no more scheduled network, stop all DHCP agents and remove it from DB"},{"line_number":259,"context_line":"* Upgrading the Neutron code and set the options for neutron-server, then"},{"line_number":260,"context_line":"  restart neutron-server processes."},{"line_number":261,"context_line":"* Setup the ovs-agent with ``dhcp`` extension."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. note:: This feature does not support DNS lookup. If your running deployments"},{"line_number":264,"context_line":"          are using the DNS lookup function from ``dnsmasq``, consider use"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b8bea578_649bd058","line":261,"range":{"start_line":255,"start_character":2,"end_line":261,"end_character":46},"updated":"2021-01-27 08:36:05.000000000","message":"It means DHCP downtime. Why can\u0027t enable \"dhcp\" extension first? Traditional dhcp should not affect new one, but could serve as backup.","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"669ac2a93fa3a1a9ba9c06d6cb7643713ea4e5ff","unresolved":true,"context_lines":[{"line_number":252,"context_line":"If you need a pure deployment without DHCP agents, the following is an overview"},{"line_number":253,"context_line":"about how to migrate to use this new feature:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":256,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":257,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."},{"line_number":258,"context_line":"* After no more scheduled network, stop all DHCP agents and remove it from DB"},{"line_number":259,"context_line":"* Upgrading the Neutron code and set the options for neutron-server, then"},{"line_number":260,"context_line":"  restart neutron-server processes."},{"line_number":261,"context_line":"* Setup the ovs-agent with ``dhcp`` extension."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. note:: This feature does not support DNS lookup. If your running deployments"},{"line_number":264,"context_line":"          are using the DNS lookup function from ``dnsmasq``, consider use"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4828d058_b2fc484a","line":261,"range":{"start_line":255,"start_character":2,"end_line":261,"end_character":46},"in_reply_to":"b8bea578_649bd058","updated":"2021-01-27 08:50:55.000000000","message":"This should be a intentional upgrading. So from my personal experience, it\u0027s better to clean up the old data before the upgrading. But, yes, it makes sense to move the new extension first. I will change the order here.","commit_id":"441e04d4fc3acaf45ae90747ec9c87fdee748857"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0865100d941351582cfab8a8702ec5ac8adc3069","unresolved":true,"context_lines":[{"line_number":175,"context_line":"1. Listen on the EventOFPPacketIn event"},{"line_number":176,"context_line":"2. Verify each packet to be DHCPv4 or DHCPv6"},{"line_number":177,"context_line":"3. According to the openflow inport number to retrieve the port\u0027s information"},{"line_number":178,"context_line":"4. Assemble the DHCP(v4/v6) response with the port\u0027s first IP(v4/v6) address and ``packet_out`` to ``in_port``."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Potential configurations"},{"line_number":181,"context_line":"++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bfac7581_527e1f65","line":178,"range":{"start_line":178,"start_character":28,"end_line":178,"end_character":36},"updated":"2021-01-27 09:11:20.000000000","message":"my comment was about source IP of response, should it be handled in IPAM? (currently DHCP port is created by dhcp agent (so as IP address of DHCP port). I think this should be described in the spec.","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"755e7efda69afd3eb7ab7d78f122237c0f4fb82f","unresolved":true,"context_lines":[{"line_number":175,"context_line":"1. Listen on the EventOFPPacketIn event"},{"line_number":176,"context_line":"2. Verify each packet to be DHCPv4 or DHCPv6"},{"line_number":177,"context_line":"3. According to the openflow inport number to retrieve the port\u0027s information"},{"line_number":178,"context_line":"4. Assemble the DHCP(v4/v6) response with the port\u0027s first IP(v4/v6) address and ``packet_out`` to ``in_port``."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Potential configurations"},{"line_number":181,"context_line":"++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ee6f9d94_da38ed55","line":178,"range":{"start_line":178,"start_character":28,"end_line":178,"end_character":36},"in_reply_to":"bfac7581_527e1f65","updated":"2021-01-27 10:06:08.000000000","message":"I will add a packet detail for this reponse.","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bf751d5e7dd9099ff3a408ae15e987d2451c754e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"1. Listen on the EventOFPPacketIn event"},{"line_number":176,"context_line":"2. Verify each packet to be DHCPv4 or DHCPv6"},{"line_number":177,"context_line":"3. According to the openflow inport number to retrieve the port\u0027s information"},{"line_number":178,"context_line":"4. Assemble the DHCP(v4/v6) response with the port\u0027s first IP(v4/v6) address and ``packet_out`` to ``in_port``."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Potential configurations"},{"line_number":181,"context_line":"++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e2fec01a_e3102008","line":178,"range":{"start_line":178,"start_character":28,"end_line":178,"end_character":36},"in_reply_to":"ee6f9d94_da38ed55","updated":"2021-01-27 10:07:17.000000000","message":"Done","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0865100d941351582cfab8a8702ec5ac8adc3069","unresolved":true,"context_lines":[{"line_number":252,"context_line":"If you need a pure deployment without DHCP agents, the following is an overview"},{"line_number":253,"context_line":"about how to migrate to use this new feature:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* Upgrading the Neutron code and set the options for neutron-server, then"},{"line_number":256,"context_line":"  restart neutron-server processes."},{"line_number":257,"context_line":"* Setup the ovs-agent with ``dhcp`` extension."},{"line_number":258,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":259,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9e1d358e_75f4b885","line":256,"range":{"start_line":255,"start_character":2,"end_line":256,"end_character":35},"updated":"2021-01-27 09:11:20.000000000","message":"Which options?","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bf751d5e7dd9099ff3a408ae15e987d2451c754e","unresolved":true,"context_lines":[{"line_number":252,"context_line":"If you need a pure deployment without DHCP agents, the following is an overview"},{"line_number":253,"context_line":"about how to migrate to use this new feature:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* Upgrading the Neutron code and set the options for neutron-server, then"},{"line_number":256,"context_line":"  restart neutron-server processes."},{"line_number":257,"context_line":"* Setup the ovs-agent with ``dhcp`` extension."},{"line_number":258,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":259,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"}],"source_content_type":"text/x-rst","patch_set":7,"id":"68f3d60a_2253211a","line":256,"range":{"start_line":255,"start_character":2,"end_line":256,"end_character":35},"in_reply_to":"9e1d358e_75f4b885","updated":"2021-01-27 10:07:17.000000000","message":"Done, move the option setting order. This option is ``disable_traditional_dhcp``.","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0865100d941351582cfab8a8702ec5ac8adc3069","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* Upgrading the Neutron code and set the options for neutron-server, then"},{"line_number":256,"context_line":"  restart neutron-server processes."},{"line_number":257,"context_line":"* Setup the ovs-agent with ``dhcp`` extension."},{"line_number":258,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":259,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":260,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"40912f96_3aca3c39","line":257,"range":{"start_line":257,"start_character":2,"end_line":257,"end_character":46},"updated":"2021-01-27 09:11:20.000000000","message":"Why not as first step?","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"755e7efda69afd3eb7ab7d78f122237c0f4fb82f","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* Upgrading the Neutron code and set the options for neutron-server, then"},{"line_number":256,"context_line":"  restart neutron-server processes."},{"line_number":257,"context_line":"* Setup the ovs-agent with ``dhcp`` extension."},{"line_number":258,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":259,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":260,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"b61fbfe5_a04aeace","line":257,"range":{"start_line":257,"start_character":2,"end_line":257,"end_character":46},"in_reply_to":"40912f96_3aca3c39","updated":"2021-01-27 10:06:08.000000000","message":"No new code, no new agent extension.","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"237fa94a7643f9fbee95b532df95d87b1ac86a93","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* Upgrading the Neutron code and set the options for neutron-server, then"},{"line_number":256,"context_line":"  restart neutron-server processes."},{"line_number":257,"context_line":"* Setup the ovs-agent with ``dhcp`` extension."},{"line_number":258,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":259,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":260,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"50448bc9_49683e71","line":257,"range":{"start_line":257,"start_character":2,"end_line":257,"end_character":46},"in_reply_to":"552d38e8_643e63a6","updated":"2021-01-27 12:19:59.000000000","message":"Please take a look at new patch set. It is now as you said.","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e57042cdbe6cbcbb1d3d93a7ad411706f95dc24d","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* Upgrading the Neutron code and set the options for neutron-server, then"},{"line_number":256,"context_line":"  restart neutron-server processes."},{"line_number":257,"context_line":"* Setup the ovs-agent with ``dhcp`` extension."},{"line_number":258,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":259,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":260,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"552d38e8_643e63a6","line":257,"range":{"start_line":257,"start_character":2,"end_line":257,"end_character":46},"in_reply_to":"b61fbfe5_a04aeace","updated":"2021-01-27 12:11:33.000000000","message":"Not sure I got what you mean. My point is: when implementation is finished, in order to upgrade existing deployment we enable \u0027dhcp\u0027 extension and restart ovs agents one by one, while traditional dhcp service is still running. This lets us avoid downtime. Once all agents are upgraded and support dhcp - we can disable traditional dhcp by restarting neutron server and disabling dhcp agents. What do you think?","commit_id":"541b231a6eec931ede3ab8067359832f4b1499e1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1c32d13607516ca563d7263d2d22565500c72913","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Response the DHCP request is the main function for the scheduled network"},{"line_number":28,"context_line":"instance of DHCP agent. Except this, other functions attached to it, like"},{"line_number":29,"context_line":"isolated metadata and DNS lookup, are not popular. And there are"},{"line_number":30,"context_line":"alternatives for these extended functions, such as config drive for metadata"},{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f1850d1_4cc0aad7","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":49},"updated":"2021-01-28 14:06:49.000000000","message":"citation needed :-)\nBut seriously it is used, even in quite conservative areas like TelCo.","commit_id":"6d787599fe78df939fa7fe67baac4b24f3267c64"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb779da831e305b6f6419cab980c059fd400affe","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Response the DHCP request is the main function for the scheduled network"},{"line_number":28,"context_line":"instance of DHCP agent. Except this, other functions attached to it, like"},{"line_number":29,"context_line":"isolated metadata and DNS lookup, are not popular. And there are"},{"line_number":30,"context_line":"alternatives for these extended functions, such as config drive for metadata"},{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"55e9df01_1ee9ee85","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":49},"in_reply_to":"5f1850d1_4cc0aad7","updated":"2021-02-01 05:58:38.000000000","message":"I\u0027ve worked in Chinatelecom and Chinaunicom. They are telecom company, from my work experiences, we don\u0027t use the DNS funtion in dnsmasq. Since [1], we have disabled it forever.","commit_id":"6d787599fe78df939fa7fe67baac4b24f3267c64"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9bfc7507a2b27f4fc1a01ad8066e3c055f3e8f5e","unresolved":true,"context_lines":[{"line_number":67,"context_line":"          will not be considered, because this new extension will rely on the"},{"line_number":68,"context_line":"          openflow protocol and principle. For OVN, it had supported similar"},{"line_number":69,"context_line":"          DHCP local response mechanism."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Solution Proposed"},{"line_number":72,"context_line":"-----------------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"c73b1683_3cb1a368","line":70,"updated":"2021-01-28 14:08:03.000000000","message":"some word about the cons would be good: \n* like with this flow based dhcp response there is no feedback if the insfrastructure network has issues (with the dhcp-agent based approach I can be sure that at least that network is working which is between my host on which my VM resides and the host on which dhcp-agent sits.)\n\n* ovs-agent will have another task to do....\n\n* perhaps there\u0027s other things on the dark side of this approach.\n\nNote: I agree with your listed \"issues\".","commit_id":"6d787599fe78df939fa7fe67baac4b24f3267c64"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb779da831e305b6f6419cab980c059fd400affe","unresolved":true,"context_lines":[{"line_number":67,"context_line":"          will not be considered, because this new extension will rely on the"},{"line_number":68,"context_line":"          openflow protocol and principle. For OVN, it had supported similar"},{"line_number":69,"context_line":"          DHCP local response mechanism."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Solution Proposed"},{"line_number":72,"context_line":"-----------------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3c353a2e_84b3045c","line":70,"in_reply_to":"c73b1683_3cb1a368","updated":"2021-02-01 05:58:38.000000000","message":"\u003e some word about the cons would be good: \n\u003e * like with this flow based dhcp response there is no feedback if the insfrastructure network has issues (with the dhcp-agent based approach I can be sure that at least that network is working which is between my host on which my VM resides and the host on which dhcp-agent sits.)\n\u003e \n\nTo diagnose the physical network connectivity by using the neutron service, IMO, is not so much reliable. Because we can not say that neutron has abosolutely no issue. So I don\u0027t know if such proposal can be used to evaluate advantages and disadvantages.\n\n\u003e * ovs-agent will have another task to do....\n\u003e \n\nThe extra work for neutron to process is add some flows duing the port process procedure. We will use the native OF api to install the flow, it is fast. And the flow is really simple. So, I don\u0027t think this can be treated as a shortcoming. Comparing to current DHCP port and it\u0027s related flows, namespace, dnsmasq process, IMO, it is simple and efficient.\n\n\u003e * perhaps there\u0027s other things on the dark side of this approach.\n\u003e \n\nEverthing is in this spec, I don\u0027t know the dark side...\n\n\u003e Note: I agree with your listed \"issues\".\n\nThe shortcomes of this extension should be the level of support for DHCP protocol. The \"DHCP(v4/v6) protocol options\" section has some detail about this. So IMO, I will not repeat here.","commit_id":"6d787599fe78df939fa7fe67baac4b24f3267c64"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1c32d13607516ca563d7263d2d22565500c72913","unresolved":true,"context_lines":[{"line_number":319,"context_line":"Functionality"},{"line_number":320,"context_line":"-------------"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"In test namespace creates fake VM port, and then send DHCP request out."},{"line_number":323,"context_line":"Verify the IP address configuration."},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"References"},{"line_number":326,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"a2f61912_f17a315e","line":323,"range":{"start_line":322,"start_character":0,"end_line":323,"end_character":36},"updated":"2021-01-28 14:06:49.000000000","message":"yeah that\u0027s a good question how to make sure that it is tested, perhaps functional or fullstack really is enough.","commit_id":"6d787599fe78df939fa7fe67baac4b24f3267c64"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb779da831e305b6f6419cab980c059fd400affe","unresolved":true,"context_lines":[{"line_number":319,"context_line":"Functionality"},{"line_number":320,"context_line":"-------------"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"In test namespace creates fake VM port, and then send DHCP request out."},{"line_number":323,"context_line":"Verify the IP address configuration."},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"References"},{"line_number":326,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d4186b27_474957ff","line":323,"range":{"start_line":322,"start_character":0,"end_line":323,"end_character":36},"in_reply_to":"a2f61912_f17a315e","updated":"2021-02-01 05:58:38.000000000","message":"I will add the fullstack test.","commit_id":"6d787599fe78df939fa7fe67baac4b24f3267c64"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Response the DHCP request is the main function for the scheduled network"},{"line_number":28,"context_line":"instance of DHCP agent. Except this, other functions attached to it, like"},{"line_number":29,"context_line":"isolated metadata and DNS lookup, are not popular. And there are"},{"line_number":30,"context_line":"alternatives for these extended functions, such as config drive for metadata"},{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1390f95f_054a193e","line":29,"updated":"2021-02-01 08:58:07.000000000","message":"Do You have any data about that? Or is it just Your private opinion?\nIf there is some data about it, I would love to see it but if it\u0027s just opinion, I don\u0027t think it should be written in the spec.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3242cfdfa78ce33d85bd440d88dd59890de74750","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Response the DHCP request is the main function for the scheduled network"},{"line_number":28,"context_line":"instance of DHCP agent. Except this, other functions attached to it, like"},{"line_number":29,"context_line":"isolated metadata and DNS lookup, are not popular. And there are"},{"line_number":30,"context_line":"alternatives for these extended functions, such as config drive for metadata"},{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5279a973_642cf4ab","line":29,"in_reply_to":"1390f95f_054a193e","updated":"2021-02-01 10:54:39.000000000","message":"From my personal experience, I\u0027ve worked for some cloud providers. None of them use these feature. And we have stop DHCP agent for a long time since 2014.\n\nMaybe we can start a OpenStack user suery for this.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Response the DHCP request is the main function for the scheduled network"},{"line_number":28,"context_line":"instance of DHCP agent. Except this, other functions attached to it, like"},{"line_number":29,"context_line":"isolated metadata and DNS lookup, are not popular. And there are"},{"line_number":30,"context_line":"alternatives for these extended functions, such as config drive for metadata"},{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"67235cdd_81678366","line":29,"in_reply_to":"5279a973_642cf4ab","updated":"2021-02-01 11:18:04.000000000","message":"removed the statement","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Then, the use frequency of the DHCP agent and its scheduled instance are"},{"line_number":34,"context_line":"relatively low. And we have more problems for large scale clusters:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The scheduled network instances of DHCP port increase the consuming of"},{"line_number":37,"context_line":"  L2 agent\u0027s capacity and performance."}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff4e1509_44006f7f","line":34,"updated":"2021-02-01 08:58:07.000000000","message":"again, that part of the \"low\" usage frequency of the DHCP agent, if there is no real data behind that sentence, I think we should remove it from spec.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40586ad0631594e72ac9db6fdd3c2e44e93e16b2","unresolved":true,"context_lines":[{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Then, the use frequency of the DHCP agent and its scheduled instance are"},{"line_number":34,"context_line":"relatively low. And we have more problems for large scale clusters:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The scheduled network instances of DHCP port increase the consuming of"},{"line_number":37,"context_line":"  L2 agent\u0027s capacity and performance."}],"source_content_type":"text/x-rst","patch_set":9,"id":"72eb9eac_ac8ac881","line":34,"in_reply_to":"4c7a020a_67a16596","updated":"2021-02-03 08:40:21.000000000","message":"ok, now I understand what You had in mind. Maybe You can clarify that in the spec?","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c21a5270cc91dfcf5b2c63200cb2a300b0363436","unresolved":false,"context_lines":[{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Then, the use frequency of the DHCP agent and its scheduled instance are"},{"line_number":34,"context_line":"relatively low. And we have more problems for large scale clusters:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The scheduled network instances of DHCP port increase the consuming of"},{"line_number":37,"context_line":"  L2 agent\u0027s capacity and performance."}],"source_content_type":"text/x-rst","patch_set":9,"id":"aed23698_df6159fe","line":34,"in_reply_to":"72eb9eac_ac8ac881","updated":"2021-02-03 10:49:43.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3242cfdfa78ce33d85bd440d88dd59890de74750","unresolved":true,"context_lines":[{"line_number":31,"context_line":"and designate for DNS."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Then, the use frequency of the DHCP agent and its scheduled instance are"},{"line_number":34,"context_line":"relatively low. And we have more problems for large scale clusters:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The scheduled network instances of DHCP port increase the consuming of"},{"line_number":37,"context_line":"  L2 agent\u0027s capacity and performance."}],"source_content_type":"text/x-rst","patch_set":9,"id":"4c7a020a_67a16596","line":34,"in_reply_to":"ff4e1509_44006f7f","updated":"2021-02-01 10:54:39.000000000","message":"This is the real fact of DHCP agent and it\u0027s scheduled network instance. It only be used during the VM booting if no DNS lookup. If you use config drive, aslo the scheduled dhcp instance is not useful.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":63,"context_line":"A new extension of Neutron openvswitch agent will be added to achieve the"},{"line_number":64,"context_line":"``Distributed DHCP``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: This extension is only for opnvswitch agent, other mechanism driver"},{"line_number":67,"context_line":"          will not be considered, because this new extension will rely on the"},{"line_number":68,"context_line":"          openflow protocol and principle. For OVN, it had supported similar"},{"line_number":69,"context_line":"          DHCP local response mechanism."}],"source_content_type":"text/x-rst","patch_set":9,"id":"72d9d53c_063d81d3","line":66,"range":{"start_line":66,"start_character":71,"end_line":66,"end_character":77},"updated":"2021-02-01 08:58:07.000000000","message":"drivers","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":63,"context_line":"A new extension of Neutron openvswitch agent will be added to achieve the"},{"line_number":64,"context_line":"``Distributed DHCP``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: This extension is only for opnvswitch agent, other mechanism driver"},{"line_number":67,"context_line":"          will not be considered, because this new extension will rely on the"},{"line_number":68,"context_line":"          openflow protocol and principle. For OVN, it had supported similar"},{"line_number":69,"context_line":"          DHCP local response mechanism."}],"source_content_type":"text/x-rst","patch_set":9,"id":"a8a4227f_3707a0bd","line":66,"range":{"start_line":66,"start_character":37,"end_line":66,"end_character":47},"updated":"2021-02-01 08:58:07.000000000","message":"nit typo","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"A new extension of Neutron openvswitch agent will be added to achieve the"},{"line_number":64,"context_line":"``Distributed DHCP``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: This extension is only for opnvswitch agent, other mechanism driver"},{"line_number":67,"context_line":"          will not be considered, because this new extension will rely on the"},{"line_number":68,"context_line":"          openflow protocol and principle. For OVN, it had supported similar"},{"line_number":69,"context_line":"          DHCP local response mechanism."}],"source_content_type":"text/x-rst","patch_set":9,"id":"d9d9301e_04a12d0d","line":66,"range":{"start_line":66,"start_character":71,"end_line":66,"end_character":77},"in_reply_to":"72d9d53c_063d81d3","updated":"2021-02-01 11:18:04.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"A new extension of Neutron openvswitch agent will be added to achieve the"},{"line_number":64,"context_line":"``Distributed DHCP``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: This extension is only for opnvswitch agent, other mechanism driver"},{"line_number":67,"context_line":"          will not be considered, because this new extension will rely on the"},{"line_number":68,"context_line":"          openflow protocol and principle. For OVN, it had supported similar"},{"line_number":69,"context_line":"          DHCP local response mechanism."}],"source_content_type":"text/x-rst","patch_set":9,"id":"152136b3_0e205c4c","line":66,"range":{"start_line":66,"start_character":37,"end_line":66,"end_character":47},"in_reply_to":"a8a4227f_3707a0bd","updated":"2021-02-01 11:18:04.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: This extension is only for opnvswitch agent, other mechanism driver"},{"line_number":67,"context_line":"          will not be considered, because this new extension will rely on the"},{"line_number":68,"context_line":"          openflow protocol and principle. For OVN, it had supported similar"},{"line_number":69,"context_line":"          DHCP local response mechanism."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Solution Proposed"}],"source_content_type":"text/x-rst","patch_set":9,"id":"f7b69499_eadb500b","line":68,"range":{"start_line":68,"start_character":55,"end_line":68,"end_character":58},"updated":"2021-02-01 08:58:07.000000000","message":"I think it should be \"has\" or something like \"OVN mechanism driver already supports similar ...\"","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. note:: This extension is only for opnvswitch agent, other mechanism driver"},{"line_number":67,"context_line":"          will not be considered, because this new extension will rely on the"},{"line_number":68,"context_line":"          openflow protocol and principle. For OVN, it had supported similar"},{"line_number":69,"context_line":"          DHCP local response mechanism."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Solution Proposed"}],"source_content_type":"text/x-rst","patch_set":9,"id":"d56f7e44_ca9192db","line":68,"range":{"start_line":68,"start_character":55,"end_line":68,"end_character":58},"in_reply_to":"f7b69499_eadb500b","updated":"2021-02-01 11:18:04.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":135,"context_line":"defined. The changes are:"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* disable DHCP scheduling mechanism and its failover forever"},{"line_number":138,"context_line":"* disable DHCP privisioning block"},{"line_number":139,"context_line":"* disable DHCP related RPCs and notificatons"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"OpenvSwitch Agent side changes"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bd5a3b12_bd218650","line":138,"range":{"start_line":138,"start_character":15,"end_line":138,"end_character":27},"updated":"2021-02-01 08:58:07.000000000","message":"provisioning","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"defined. The changes are:"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* disable DHCP scheduling mechanism and its failover forever"},{"line_number":138,"context_line":"* disable DHCP privisioning block"},{"line_number":139,"context_line":"* disable DHCP related RPCs and notificatons"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"OpenvSwitch Agent side changes"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ada2b46a_113ef4ea","line":138,"range":{"start_line":138,"start_character":15,"end_line":138,"end_character":27},"in_reply_to":"bd5a3b12_bd218650","updated":"2021-02-01 11:18:04.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":207,"context_line":"Potential configurations"},{"line_number":208,"context_line":"++++++++++++++++++++++++"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Config option ``disable_traditional_dhcp`` for neutron server side will be"},{"line_number":211,"context_line":"added which is aiming to control:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* to disable DHCP scheduling for networks"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa871caf_fb8ec5f3","line":210,"range":{"start_line":210,"start_character":16,"end_line":210,"end_character":40},"updated":"2021-02-01 08:58:07.000000000","message":"why not \"enable_distributed_dhcp\" which would be similar to \"enable_dvr\" which we already have?","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c21a5270cc91dfcf5b2c63200cb2a300b0363436","unresolved":true,"context_lines":[{"line_number":207,"context_line":"Potential configurations"},{"line_number":208,"context_line":"++++++++++++++++++++++++"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Config option ``disable_traditional_dhcp`` for neutron server side will be"},{"line_number":211,"context_line":"added which is aiming to control:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* to disable DHCP scheduling for networks"}],"source_content_type":"text/x-rst","patch_set":9,"id":"86090bb0_cfb739cd","line":210,"range":{"start_line":210,"start_character":16,"end_line":210,"end_character":40},"in_reply_to":"2867f97a_5e3d315c","updated":"2021-02-03 10:49:43.000000000","message":"\"enable flow based DHCP\" will be only one option, add \"dhcp\" to the agent extension list, see line 223-224.\n\n\nThis spec will add a new agent side extension, but those DHCP related API/RPC/scheduling are in neutron server side. So looks negative to do that.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"625d6442a505cc8af1712e7f9c51fd8f4ed30e75","unresolved":true,"context_lines":[{"line_number":207,"context_line":"Potential configurations"},{"line_number":208,"context_line":"++++++++++++++++++++++++"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Config option ``disable_traditional_dhcp`` for neutron server side will be"},{"line_number":211,"context_line":"added which is aiming to control:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* to disable DHCP scheduling for networks"}],"source_content_type":"text/x-rst","patch_set":9,"id":"8f648d93_24a0d9df","line":210,"range":{"start_line":210,"start_character":16,"end_line":210,"end_character":40},"in_reply_to":"86090bb0_cfb739cd","updated":"2021-02-04 10:35:35.000000000","message":"I agree with Liu: set \"disable_traditional_dhcp\" to disable the DHCP agents and then enable the OVS extension. Both actions are different and should be handled independently.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40586ad0631594e72ac9db6fdd3c2e44e93e16b2","unresolved":true,"context_lines":[{"line_number":207,"context_line":"Potential configurations"},{"line_number":208,"context_line":"++++++++++++++++++++++++"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Config option ``disable_traditional_dhcp`` for neutron server side will be"},{"line_number":211,"context_line":"added which is aiming to control:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* to disable DHCP scheduling for networks"}],"source_content_type":"text/x-rst","patch_set":9,"id":"2867f97a_5e3d315c","line":210,"range":{"start_line":210,"start_character":16,"end_line":210,"end_character":40},"in_reply_to":"e2fbeef1_aabc1492","updated":"2021-02-03 08:40:21.000000000","message":"IIRC that discussion, there should be also another config option to enable flow based DHCP and that is not mentioned in this spec.\nAlso I\u0027m not big fan of adding too many config knobs. What is user will e.g. enable flow based dhcp and forget to disable \"traditional one\"?","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3242cfdfa78ce33d85bd440d88dd59890de74750","unresolved":true,"context_lines":[{"line_number":207,"context_line":"Potential configurations"},{"line_number":208,"context_line":"++++++++++++++++++++++++"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Config option ``disable_traditional_dhcp`` for neutron server side will be"},{"line_number":211,"context_line":"added which is aiming to control:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* to disable DHCP scheduling for networks"}],"source_content_type":"text/x-rst","patch_set":9,"id":"e2fbeef1_aabc1492","line":210,"range":{"start_line":210,"start_character":16,"end_line":210,"end_character":40},"in_reply_to":"fa871caf_fb8ec5f3","updated":"2021-02-01 10:54:39.000000000","message":"The story can be found here:\nhttps://review.opendev.org/c/openstack/neutron/+/772255/4/neutron/conf/common.py","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":211,"context_line":"added which is aiming to control:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* to disable DHCP scheduling for networks"},{"line_number":214,"context_line":"* to disable DHCP privisioning block"},{"line_number":215,"context_line":"* to disable DHCP RPC/notification"},{"line_number":216,"context_line":"* to disable all DHCP related API/attibutes network, subnet and port."},{"line_number":217,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"c501c411_71b2515e","line":214,"range":{"start_line":214,"start_character":18,"end_line":214,"end_character":30},"updated":"2021-02-01 08:58:07.000000000","message":"provisioning","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c21a5270cc91dfcf5b2c63200cb2a300b0363436","unresolved":false,"context_lines":[{"line_number":211,"context_line":"added which is aiming to control:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* to disable DHCP scheduling for networks"},{"line_number":214,"context_line":"* to disable DHCP privisioning block"},{"line_number":215,"context_line":"* to disable DHCP RPC/notification"},{"line_number":216,"context_line":"* to disable all DHCP related API/attibutes network, subnet and port."},{"line_number":217,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"13c8f3b7_20392552","line":214,"range":{"start_line":214,"start_character":18,"end_line":214,"end_character":30},"in_reply_to":"c501c411_71b2515e","updated":"2021-02-03 10:49:43.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":242,"context_line":"The Neutron basic workflow"},{"line_number":243,"context_line":"--------------------------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"1. User create VM in a network"},{"line_number":246,"context_line":"2. Nova plug the VM\u0027s NIC port to ovs-bridge"},{"line_number":247,"context_line":"3. Ovs-agent process the port and install the DHCP related flows"},{"line_number":248,"context_line":"4. L2 provisioning block released (No DHCP provisioning block)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"73200fc7_b289a21b","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":14},"updated":"2021-02-01 08:58:07.000000000","message":"creates a","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c21a5270cc91dfcf5b2c63200cb2a300b0363436","unresolved":false,"context_lines":[{"line_number":242,"context_line":"The Neutron basic workflow"},{"line_number":243,"context_line":"--------------------------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"1. User create VM in a network"},{"line_number":246,"context_line":"2. Nova plug the VM\u0027s NIC port to ovs-bridge"},{"line_number":247,"context_line":"3. Ovs-agent process the port and install the DHCP related flows"},{"line_number":248,"context_line":"4. L2 provisioning block released (No DHCP provisioning block)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7bc90ba7_6ee9b5d2","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":14},"in_reply_to":"73200fc7_b289a21b","updated":"2021-02-03 10:49:43.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":260,"context_line":"REST API Impact"},{"line_number":261,"context_line":"---------------"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":264,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":265,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"e4d94ee6_fe52fa39","line":263,"range":{"start_line":263,"start_character":9,"end_line":263,"end_character":15},"updated":"2021-02-01 08:58:07.000000000","message":"I don\u0027t think this is needed","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":false,"context_lines":[{"line_number":260,"context_line":"REST API Impact"},{"line_number":261,"context_line":"---------------"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":264,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":265,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"af7ab392_24c6cbc7","line":263,"range":{"start_line":263,"start_character":9,"end_line":263,"end_character":15},"in_reply_to":"e4d94ee6_fe52fa39","updated":"2021-02-01 11:18:04.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":264,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":265,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":268,"context_line":"calls just have no effect on the resoruces. The new added config options"}],"source_content_type":"text/x-rst","patch_set":9,"id":"d75bd395_2dce57f2","line":265,"updated":"2021-02-01 08:58:07.000000000","message":"why? Can\u0027t we still honor that setting and don\u0027t provide responses for the ports which are on the subnets with disabled DHCP? We could e.g. don\u0027t install OF rule in table 77/78 for such ports and just drops those packets.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3242cfdfa78ce33d85bd440d88dd59890de74750","unresolved":true,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":264,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":265,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":268,"context_line":"calls just have no effect on the resoruces. The new added config options"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ffc62c9a_4f6d520c","line":265,"in_reply_to":"d75bd395_2dce57f2","updated":"2021-02-01 10:54:39.000000000","message":"Good catch, I will update this line.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"With the future new config options, the DHCP related API for resources"},{"line_number":264,"context_line":"will be silently ignored in neutron-server, for instance ``enable_dhcp``"},{"line_number":265,"context_line":"for ``Subnet`` will actually have no operation on the resource."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":268,"context_line":"calls just have no effect on the resoruces. The new added config options"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3e14e8b6_29053796","line":265,"in_reply_to":"ffc62c9a_4f6d520c","updated":"2021-02-01 11:18:04.000000000","message":"Done","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":268,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":269,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Upgrading"},{"line_number":272,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"b4ea6254_ed3ce978","line":269,"updated":"2021-02-01 08:58:07.000000000","message":"what if there still will be some dhcp agent in the env and if user will add network to that agent? Will such API request return some 4xx error (what exactly?) or will it be accepted?","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3242cfdfa78ce33d85bd440d88dd59890de74750","unresolved":true,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":268,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":269,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Upgrading"},{"line_number":272,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ea859026_f00207fb","line":269,"in_reply_to":"b4ea6254_ed3ce978","updated":"2021-02-01 10:54:39.000000000","message":"IMO, only the admin user can add it to a agent, but it is a DB state only. The scheduler will be disabled, and no way nitify the agent to create ns, dnsmasq, port etc, see the patch for detal:\nhttps://review.opendev.org/c/openstack/neutron/+/772255/","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":true,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":268,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":269,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Upgrading"},{"line_number":272,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"caa67755_4749dbe0","line":269,"in_reply_to":"ea859026_f00207fb","updated":"2021-02-01 11:18:04.000000000","message":"Added this ^ reply to the spec.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7808343923e663efb8468bc44d31a5f66864dd22","unresolved":true,"context_lines":[{"line_number":285,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":286,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":287,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."},{"line_number":288,"context_line":"* After no more scheduled network, stop all DHCP agents and remove it from DB."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":".. note:: This feature does not support DNS lookup. If your running deployments"},{"line_number":291,"context_line":"          are using the DNS lookup function from ``dnsmasq``, consider use"}],"source_content_type":"text/x-rst","patch_set":9,"id":"064b0384_6d89e3f5","line":288,"updated":"2021-02-01 08:58:07.000000000","message":"can\u0027t we do most of that automatically? Like e.g. remove networks from the dhcp agents and don\u0027t schedule new networks there?\nUser would just need to remove old DHCP agents from the deployment and Neutron DB after all. But that wouldn\u0027t be critical at all.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3242cfdfa78ce33d85bd440d88dd59890de74750","unresolved":true,"context_lines":[{"line_number":285,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":286,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":287,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."},{"line_number":288,"context_line":"* After no more scheduled network, stop all DHCP agents and remove it from DB."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":".. note:: This feature does not support DNS lookup. If your running deployments"},{"line_number":291,"context_line":"          are using the DNS lookup function from ``dnsmasq``, consider use"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7db3f63d_8cd2f650","line":288,"in_reply_to":"064b0384_6d89e3f5","updated":"2021-02-01 10:54:39.000000000","message":"My idea is to let the operators know what they are doing and what will cause, instead of hiding the details. And, another reason is I don\u0027t want to make this function too complicated. 😊","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c2ac8ab2cf62dabbd5078b35e8632f50ace547f4","unresolved":true,"context_lines":[{"line_number":285,"context_line":"* Disable all DHCP agents to make sure no more scheduled network are created."},{"line_number":286,"context_line":"* Remove all scheduled network from all DHCP agents, this step is to pure all"},{"line_number":287,"context_line":"  DHCP namespace and DHCP woker process ``dnsmasq``."},{"line_number":288,"context_line":"* After no more scheduled network, stop all DHCP agents and remove it from DB."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":".. note:: This feature does not support DNS lookup. If your running deployments"},{"line_number":291,"context_line":"          are using the DNS lookup function from ``dnsmasq``, consider use"}],"source_content_type":"text/x-rst","patch_set":9,"id":"91773115_e54a2b21","line":288,"in_reply_to":"7db3f63d_8cd2f650","updated":"2021-02-01 11:18:04.000000000","message":"Set DHCP admin state down will remove sechedlued network instances automatically. I will update here.","commit_id":"b15e34bb27060ac38b034f0ee1a171897bdc8bf7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40586ad0631594e72ac9db6fdd3c2e44e93e16b2","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Response the DHCP request is the main function for the scheduled network"},{"line_number":28,"context_line":"instance of DHCP agent. Except this, it has other functions, like"},{"line_number":29,"context_line":"isolated metadata and DNS lookup. But there are alternatives for these"},{"line_number":30,"context_line":"extended functions, such as config drive for metadata and designate"},{"line_number":31,"context_line":"for DNS."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Then, the use frequency of the DHCP agent and its scheduled instance are"}],"source_content_type":"text/x-rst","patch_set":10,"id":"b66a5d4d_813618db","line":30,"range":{"start_line":30,"start_character":58,"end_line":30,"end_character":67},"updated":"2021-02-03 08:40:21.000000000","message":"nit: Designate","commit_id":"f6e31437031df3161abdac899ab80f6c066f9d2f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c21a5270cc91dfcf5b2c63200cb2a300b0363436","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Response the DHCP request is the main function for the scheduled network"},{"line_number":28,"context_line":"instance of DHCP agent. Except this, it has other functions, like"},{"line_number":29,"context_line":"isolated metadata and DNS lookup. But there are alternatives for these"},{"line_number":30,"context_line":"extended functions, such as config drive for metadata and designate"},{"line_number":31,"context_line":"for DNS."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Then, the use frequency of the DHCP agent and its scheduled instance are"}],"source_content_type":"text/x-rst","patch_set":10,"id":"cad41ffc_09b3a696","line":30,"range":{"start_line":30,"start_character":58,"end_line":30,"end_character":67},"in_reply_to":"b66a5d4d_813618db","updated":"2021-02-03 10:49:43.000000000","message":"Done","commit_id":"f6e31437031df3161abdac899ab80f6c066f9d2f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40586ad0631594e72ac9db6fdd3c2e44e93e16b2","unresolved":true,"context_lines":[{"line_number":267,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":268,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":269,"context_line":"For instance, the admin user can still add a network to a agent, but it will"},{"line_number":270,"context_line":"be a DB state only. The scheduler will be disabled, and no way nitify the"},{"line_number":271,"context_line":"agent to create namespace, dnsmasq process."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"For the option ``enable_dhcp`` of ``Subnet``, this agent extension will set"}],"source_content_type":"text/x-rst","patch_set":10,"id":"a669ce95_818d6a4c","line":270,"range":{"start_line":270,"start_character":63,"end_line":270,"end_character":69},"updated":"2021-02-03 08:40:21.000000000","message":"\"to notify\" IMO","commit_id":"f6e31437031df3161abdac899ab80f6c066f9d2f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c21a5270cc91dfcf5b2c63200cb2a300b0363436","unresolved":false,"context_lines":[{"line_number":267,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":268,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":269,"context_line":"For instance, the admin user can still add a network to a agent, but it will"},{"line_number":270,"context_line":"be a DB state only. The scheduler will be disabled, and no way nitify the"},{"line_number":271,"context_line":"agent to create namespace, dnsmasq process."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"For the option ``enable_dhcp`` of ``Subnet``, this agent extension will set"}],"source_content_type":"text/x-rst","patch_set":10,"id":"c9b6e841_c4d7bbcb","line":270,"range":{"start_line":270,"start_character":63,"end_line":270,"end_character":69},"in_reply_to":"a669ce95_818d6a4c","updated":"2021-02-03 10:49:43.000000000","message":"Done","commit_id":"f6e31437031df3161abdac899ab80f6c066f9d2f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40586ad0631594e72ac9db6fdd3c2e44e93e16b2","unresolved":true,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"For the option ``enable_dhcp`` of ``Subnet``, this agent extension will set"},{"line_number":274,"context_line":"the flows based on that. If it is False, ports under this subnet will have"},{"line_number":275,"context_line":"no flows installed in table 77 and 78. The DHCP request will hit the final"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Upgrading"},{"line_number":278,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"aa6410a0_416b9ed9","line":275,"range":{"start_line":275,"start_character":39,"end_line":275,"end_character":74},"updated":"2021-02-03 08:40:21.000000000","message":"is this sentence complete?","commit_id":"f6e31437031df3161abdac899ab80f6c066f9d2f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c21a5270cc91dfcf5b2c63200cb2a300b0363436","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"For the option ``enable_dhcp`` of ``Subnet``, this agent extension will set"},{"line_number":274,"context_line":"the flows based on that. If it is False, ports under this subnet will have"},{"line_number":275,"context_line":"no flows installed in table 77 and 78. The DHCP request will hit the final"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Upgrading"},{"line_number":278,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"cf09ff12_3bfe0642","line":275,"range":{"start_line":275,"start_character":39,"end_line":275,"end_character":74},"in_reply_to":"aa6410a0_416b9ed9","updated":"2021-02-03 10:49:43.000000000","message":"Done","commit_id":"f6e31437031df3161abdac899ab80f6c066f9d2f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f3acef34b4ed7343b0a8eee2a7fa75559f330a25","unresolved":true,"context_lines":[{"line_number":268,"context_line":"scheduling, will be silently ignored in neutron-server."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":271,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":272,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":273,"context_line":"For instance, the admin user can still add a network to a agent, but it will"},{"line_number":274,"context_line":"be a DB state only. The scheduler will be disabled, and no way to notify the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"45d8c534_9f023297","line":271,"range":{"start_line":271,"start_character":33,"end_line":271,"end_character":42},"updated":"2021-02-04 07:43:31.000000000","message":"nit: typo","commit_id":"4681e55f2eaead71329bb9fb672955c629197d08"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae6dff5c61110799040cb9a2f2840d023ba73deb","unresolved":true,"context_lines":[{"line_number":268,"context_line":"scheduling, will be silently ignored in neutron-server."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":271,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":272,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":273,"context_line":"For instance, the admin user can still add a network to a agent, but it will"},{"line_number":274,"context_line":"be a DB state only. The scheduler will be disabled, and no way to notify the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1e933115_727d6b16","line":271,"range":{"start_line":271,"start_character":33,"end_line":271,"end_character":42},"in_reply_to":"45d8c534_9f023297","updated":"2021-02-04 10:00:05.000000000","message":"Removed these statements.","commit_id":"4681e55f2eaead71329bb9fb672955c629197d08"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f3acef34b4ed7343b0a8eee2a7fa75559f330a25","unresolved":true,"context_lines":[{"line_number":270,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":271,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":272,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":273,"context_line":"For instance, the admin user can still add a network to a agent, but it will"},{"line_number":274,"context_line":"be a DB state only. The scheduler will be disabled, and no way to notify the"},{"line_number":275,"context_line":"agent to create namespace, dnsmasq process."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"For the option ``enable_dhcp`` of ``Subnet``, this agent extension will set"},{"line_number":278,"context_line":"the flows based on that. If it is False, ports under this subnet will have"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ccc44920_366d9de9","line":275,"range":{"start_line":273,"start_character":14,"end_line":275,"end_character":43},"updated":"2021-02-04 07:43:31.000000000","message":"I think it would be more fair to fail such API requsts saying that DHCP scheduling is disabled","commit_id":"4681e55f2eaead71329bb9fb672955c629197d08"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8c2f8447346b74b0e1bf97eef1dde215e1586fb3","unresolved":true,"context_lines":[{"line_number":270,"context_line":"Actually no really API changes, users can still call the APIs, but these"},{"line_number":271,"context_line":"calls just have no effect on the resoruces. The new added config options"},{"line_number":272,"context_line":"will be used as flags to enable/disable some codes."},{"line_number":273,"context_line":"For instance, the admin user can still add a network to a agent, but it will"},{"line_number":274,"context_line":"be a DB state only. The scheduler will be disabled, and no way to notify the"},{"line_number":275,"context_line":"agent to create namespace, dnsmasq process."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"For the option ``enable_dhcp`` of ``Subnet``, this agent extension will set"},{"line_number":278,"context_line":"the flows based on that. If it is False, ports under this subnet will have"}],"source_content_type":"text/x-rst","patch_set":12,"id":"10cc227b_8ca7597b","line":275,"range":{"start_line":273,"start_character":14,"end_line":275,"end_character":43},"in_reply_to":"ccc44920_366d9de9","updated":"2021-02-04 09:09:04.000000000","message":"Make sense, I will investigate the feasibility and update here.","commit_id":"4681e55f2eaead71329bb9fb672955c629197d08"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f3acef34b4ed7343b0a8eee2a7fa75559f330a25","unresolved":true,"context_lines":[{"line_number":274,"context_line":"be a DB state only. The scheduler will be disabled, and no way to notify the"},{"line_number":275,"context_line":"agent to create namespace, dnsmasq process."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"For the option ``enable_dhcp`` of ``Subnet``, this agent extension will set"},{"line_number":278,"context_line":"the flows based on that. If it is False, ports under this subnet will have"},{"line_number":279,"context_line":"no flows installed in table 77 and 78. The DHCP request will hit the final"},{"line_number":280,"context_line":"DROP action."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"Upgrading"},{"line_number":283,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"f64b7867_658b4dac","line":280,"range":{"start_line":277,"start_character":0,"end_line":280,"end_character":12},"updated":"2021-02-04 07:43:31.000000000","message":"Does ovs agent currently handle subnet update events?","commit_id":"4681e55f2eaead71329bb9fb672955c629197d08"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8c2f8447346b74b0e1bf97eef1dde215e1586fb3","unresolved":true,"context_lines":[{"line_number":274,"context_line":"be a DB state only. The scheduler will be disabled, and no way to notify the"},{"line_number":275,"context_line":"agent to create namespace, dnsmasq process."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"For the option ``enable_dhcp`` of ``Subnet``, this agent extension will set"},{"line_number":278,"context_line":"the flows based on that. If it is False, ports under this subnet will have"},{"line_number":279,"context_line":"no flows installed in table 77 and 78. The DHCP request will hit the final"},{"line_number":280,"context_line":"DROP action."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"Upgrading"},{"line_number":283,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"418d27ba_114aa069","line":280,"range":{"start_line":277,"start_character":0,"end_line":280,"end_character":12},"in_reply_to":"f64b7867_658b4dac","updated":"2021-02-04 09:09:04.000000000","message":"This new agent extension will handle that.","commit_id":"4681e55f2eaead71329bb9fb672955c629197d08"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"625d6442a505cc8af1712e7f9c51fd8f4ed30e75","unresolved":true,"context_lines":[{"line_number":125,"context_line":"* DHCPv6 Options"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For Neutron, we have some Port attributes like dns_domain, dns_name and"},{"line_number":128,"context_line":"extra_dhcp_opts, and Subnet dns_nameservers, host_routes, dns_nameservers"},{"line_number":129,"context_line":"and gateway_ip and so on, all these options will be added to the final DHCP"},{"line_number":130,"context_line":"response like dnsmasq do."},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3ee413fc_46673fb2","line":128,"range":{"start_line":128,"start_character":58,"end_line":128,"end_character":73},"updated":"2021-02-04 10:35:35.000000000","message":"nit: repeated","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a1c481366743e75b97ff140ac8ba1ea06d75b481","unresolved":false,"context_lines":[{"line_number":125,"context_line":"* DHCPv6 Options"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For Neutron, we have some Port attributes like dns_domain, dns_name and"},{"line_number":128,"context_line":"extra_dhcp_opts, and Subnet dns_nameservers, host_routes, dns_nameservers"},{"line_number":129,"context_line":"and gateway_ip and so on, all these options will be added to the final DHCP"},{"line_number":130,"context_line":"response like dnsmasq do."},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"11eb26f0_e9ea56fa","line":128,"range":{"start_line":128,"start_character":58,"end_line":128,"end_character":73},"in_reply_to":"3ee413fc_46673fb2","updated":"2021-02-04 11:04:44.000000000","message":"Done","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"625d6442a505cc8af1712e7f9c51fd8f4ed30e75","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"::"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  table\u003d77, priority\u003d100,udp,in_port\u003d\"tapcc4f2da4-c5\",dl_src\u003dfa:16:3e:46:58:fe,tp_src\u003d68,tp_dst\u003d67 actions\u003dCONTROLLER:0"},{"line_number":167,"context_line":"  table\u003d77, priority\u003d0 actions\u003ddrop"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"For table 78, DHCPv6 match and drop flows structure are basically same to DHCPv4:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"f0debd3c_0ce895a9","line":166,"updated":"2021-02-04 10:35:35.000000000","message":"nit: it could be easier to read with line breaks","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a1c481366743e75b97ff140ac8ba1ea06d75b481","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"::"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  table\u003d77, priority\u003d100,udp,in_port\u003d\"tapcc4f2da4-c5\",dl_src\u003dfa:16:3e:46:58:fe,tp_src\u003d68,tp_dst\u003d67 actions\u003dCONTROLLER:0"},{"line_number":167,"context_line":"  table\u003d77, priority\u003d0 actions\u003ddrop"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"For table 78, DHCPv6 match and drop flows structure are basically same to DHCPv4:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"c1409913_09389358","line":166,"in_reply_to":"f0debd3c_0ce895a9","updated":"2021-02-04 11:04:44.000000000","message":"For one entire flow entry, looks a bit strange to start new line. The final rendered code block has drag bar.😊","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"625d6442a505cc8af1712e7f9c51fd8f4ed30e75","unresolved":true,"context_lines":[{"line_number":182,"context_line":"* According to the openflow inport number to retrieve the port\u0027s information"},{"line_number":183,"context_line":"* Assemble the DHCP(v4/v6) response and ``packet_out`` to ``in_port``."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"The responce DHCP packet structure will be:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"::"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"311f87ca_a6ce01c7","line":185,"range":{"start_line":185,"start_character":4,"end_line":185,"end_character":12},"updated":"2021-02-04 10:35:35.000000000","message":"response","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a1c481366743e75b97ff140ac8ba1ea06d75b481","unresolved":false,"context_lines":[{"line_number":182,"context_line":"* According to the openflow inport number to retrieve the port\u0027s information"},{"line_number":183,"context_line":"* Assemble the DHCP(v4/v6) response and ``packet_out`` to ``in_port``."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"The responce DHCP packet structure will be:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"::"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"e8f993b0_424720ac","line":185,"range":{"start_line":185,"start_character":4,"end_line":185,"end_character":12},"in_reply_to":"311f87ca_a6ce01c7","updated":"2021-02-04 11:04:44.000000000","message":"Done","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"625d6442a505cc8af1712e7f9c51fd8f4ed30e75","unresolved":true,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  +------------------------------------------+"},{"line_number":190,"context_line":"  |           *Source Mac Address            |"},{"line_number":191,"context_line":"  |The gateway Port\u0027s MAC or A fake fixed MAC|"},{"line_number":192,"context_line":"  +------------------------------------------+"},{"line_number":193,"context_line":"  |       *Destination Mac Address           |"},{"line_number":194,"context_line":"  |        Neutron Port Mac Address          |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"63e73a9a_db47b9b4","line":191,"range":{"start_line":191,"start_character":29,"end_line":191,"end_character":45},"updated":"2021-02-04 10:35:35.000000000","message":"just for curiosity: which one? because we should not use any of the subnet CIDR, right?","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a1c481366743e75b97ff140ac8ba1ea06d75b481","unresolved":true,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  +------------------------------------------+"},{"line_number":190,"context_line":"  |           *Source Mac Address            |"},{"line_number":191,"context_line":"  |The gateway Port\u0027s MAC or A fake fixed MAC|"},{"line_number":192,"context_line":"  +------------------------------------------+"},{"line_number":193,"context_line":"  |       *Destination Mac Address           |"},{"line_number":194,"context_line":"  |        Neutron Port Mac Address          |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ed1f327c_5691d61a","line":191,"range":{"start_line":191,"start_character":29,"end_line":191,"end_character":45},"in_reply_to":"63e73a9a_db47b9b4","updated":"2021-02-04 11:04:44.000000000","message":"This is mac address, we will use the value \"fa:16:3e:00:00:00\" from cfg.CONF.base_mac [1] based on Brian\u0027s suggestion.\nThe original value I used is \"fa:16:3e:ff:ff:ff\", the last mac. See line 203 for details.\n\n[1] https://review.opendev.org/c/openstack/neutron/+/773281/2/neutron/agent/l2/extensions/dhcp/base.py#53","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"625d6442a505cc8af1712e7f9c51fd8f4ed30e75","unresolved":true,"context_lines":[{"line_number":235,"context_line":"  dhcp_opts \u003d ["},{"line_number":236,"context_line":"    cfg.BoolOpt(\u0027enable_dhcp_ipv6\u0027, default\u003dFalse,"},{"line_number":237,"context_line":"                help\u003d_(\"Whether enable DHCP for IPv6\")),"},{"line_number":238,"context_line":"    cfg.IntOpt(\u0027renewal_time\u0027, default\u003d0,"},{"line_number":239,"context_line":"               help\u003d_(\"DHCP renewal time T1 (in seconds). If set to 0, it \""},{"line_number":240,"context_line":"                      \"will default to half of the lease time.\")),"},{"line_number":241,"context_line":"    cfg.IntOpt(\u0027rebinding_time\u0027, default\u003d0,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"eb1e5d59_d9852607","line":238,"range":{"start_line":238,"start_character":16,"end_line":238,"end_character":28},"updated":"2021-02-04 10:35:35.000000000","message":"I would prefer to use the same DHCP config knob names: dhcp_renewal_time, dhcp_rebinding_time","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a1c481366743e75b97ff140ac8ba1ea06d75b481","unresolved":false,"context_lines":[{"line_number":235,"context_line":"  dhcp_opts \u003d ["},{"line_number":236,"context_line":"    cfg.BoolOpt(\u0027enable_dhcp_ipv6\u0027, default\u003dFalse,"},{"line_number":237,"context_line":"                help\u003d_(\"Whether enable DHCP for IPv6\")),"},{"line_number":238,"context_line":"    cfg.IntOpt(\u0027renewal_time\u0027, default\u003d0,"},{"line_number":239,"context_line":"               help\u003d_(\"DHCP renewal time T1 (in seconds). If set to 0, it \""},{"line_number":240,"context_line":"                      \"will default to half of the lease time.\")),"},{"line_number":241,"context_line":"    cfg.IntOpt(\u0027rebinding_time\u0027, default\u003d0,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"2889a94a_611424f0","line":238,"range":{"start_line":238,"start_character":16,"end_line":238,"end_character":28},"in_reply_to":"eb1e5d59_d9852607","updated":"2021-02-04 11:04:44.000000000","message":"I will change the \"add\" to \"register\". The final config options will be also these.","commit_id":"5e0960e9fa03850a509326c1278588fefe259e66"}]}