)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d53eaa6d4d68ae2bfa050b21d02ed0114c5fe34e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for QoS rule type packet per second"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1912460"},{"line_number":10,"context_line":"Change-Id: Ie9e7054d333dad42a5e874a4fee383361457fde6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"68bd3905_904c75f2","line":9,"updated":"2021-03-16 10:26:00.000000000","message":"I don\u0027t think it\u0027s closing the bug :) Please mark it as \"Related-bug\"","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7146d0751855ebd8966ed4d17ca743c6ddb4dee6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for QoS rule type packet per second"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1912460"},{"line_number":10,"context_line":"Change-Id: Ie9e7054d333dad42a5e874a4fee383361457fde6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f39ea66_391c2df8","line":9,"in_reply_to":"68bd3905_904c75f2","updated":"2021-03-19 09:25:08.000000000","message":"Done","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"}],"specs/wallaby/qos_pps_rule.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d53eaa6d4d68ae2bfa050b21d02ed0114c5fe34e","unresolved":true,"context_lines":[{"line_number":24,"context_line":"performance of a device."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"For cloud providers, to limit the packet per second (pps)"},{"line_number":27,"context_line":"of VM NIC is popular and sometimes essential. Transit large set"},{"line_number":28,"context_line":"packets for VM in physical compute hosts will consume the"},{"line_number":29,"context_line":"CPU and physical NIC I/O performance. For small packets, even the"},{"line_number":30,"context_line":"bandwidth is low, the pps can still be higher. Without the limitation,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"864b2d5e_dcf0eb52","line":27,"updated":"2021-03-16 10:26:00.000000000","message":"IMHO \"set of packets\"","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7146d0751855ebd8966ed4d17ca743c6ddb4dee6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"performance of a device."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"For cloud providers, to limit the packet per second (pps)"},{"line_number":27,"context_line":"of VM NIC is popular and sometimes essential. Transit large set"},{"line_number":28,"context_line":"packets for VM in physical compute hosts will consume the"},{"line_number":29,"context_line":"CPU and physical NIC I/O performance. For small packets, even the"},{"line_number":30,"context_line":"bandwidth is low, the pps can still be higher. Without the limitation,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ec80def0_7b5063dd","line":27,"in_reply_to":"864b2d5e_dcf0eb52","updated":"2021-03-19 09:25:08.000000000","message":"Done","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d53eaa6d4d68ae2bfa050b21d02ed0114c5fe34e","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to others even the device is in lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services, other users\u0027 VMs will be under a higher failuer"},{"line_number":38,"context_line":"point."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"74c7e0d1_1bffc19d","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":22},"updated":"2021-03-16 10:26:00.000000000","message":"even if","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d53eaa6d4d68ae2bfa050b21d02ed0114c5fe34e","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to others even the device is in lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services, other users\u0027 VMs will be under a higher failuer"},{"line_number":38,"context_line":"point."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"30382510_014c4369","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":35},"updated":"2021-03-16 10:26:00.000000000","message":"has lower","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d53eaa6d4d68ae2bfa050b21d02ed0114c5fe34e","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to others even the device is in lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services, other users\u0027 VMs will be under a higher failuer"},{"line_number":38,"context_line":"point."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"db81023a_57d2f977","line":36,"range":{"start_line":36,"start_character":10,"end_line":36,"end_character":16},"updated":"2021-03-16 10:26:00.000000000","message":"the others,","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7146d0751855ebd8966ed4d17ca743c6ddb4dee6","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to others even the device is in lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services, other users\u0027 VMs will be under a higher failuer"},{"line_number":38,"context_line":"point."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"80b24ec8_8906b5f6","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":35},"in_reply_to":"30382510_014c4369","updated":"2021-03-19 09:25:08.000000000","message":"Done","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7146d0751855ebd8966ed4d17ca743c6ddb4dee6","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to others even the device is in lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services, other users\u0027 VMs will be under a higher failuer"},{"line_number":38,"context_line":"point."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"30c2de44_d4d975c5","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":22},"in_reply_to":"74c7e0d1_1bffc19d","updated":"2021-03-19 09:25:08.000000000","message":"Done","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7146d0751855ebd8966ed4d17ca743c6ddb4dee6","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to others even the device is in lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services, other users\u0027 VMs will be under a higher failuer"},{"line_number":38,"context_line":"point."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bb6d1e89_0a887352","line":36,"range":{"start_line":36,"start_character":10,"end_line":36,"end_character":16},"in_reply_to":"db81023a_57d2f977","updated":"2021-03-19 09:25:08.000000000","message":"Done","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d53eaa6d4d68ae2bfa050b21d02ed0114c5fe34e","unresolved":true,"context_lines":[{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to others even the device is in lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services, other users\u0027 VMs will be under a higher failuer"},{"line_number":38,"context_line":"point."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"For network quality assurance, the resource consumption of the system"}],"source_content_type":"text/x-rst","patch_set":1,"id":"71c8c54c_3fd31417","line":37,"range":{"start_line":37,"start_character":65,"end_line":37,"end_character":72},"updated":"2021-03-16 10:26:00.000000000","message":"failure","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7146d0751855ebd8966ed4d17ca743c6ddb4dee6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to others even the device is in lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services, other users\u0027 VMs will be under a higher failuer"},{"line_number":38,"context_line":"point."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"For network quality assurance, the resource consumption of the system"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6314c69d_680516ed","line":37,"range":{"start_line":37,"start_character":65,"end_line":37,"end_character":72},"in_reply_to":"71c8c54c_3fd31417","updated":"2021-03-19 09:25:08.000000000","message":"Done","commit_id":"af2ca8943c677979684dbf69943f13c31ee46bdb"}],"specs/xena/qos_pps_rule.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ad52b0a1ccafa9a1779df5d9954cd8a9e0fc40fd","unresolved":true,"context_lines":[{"line_number":32,"context_line":"hacked."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to the others, even if the device has lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services and other users\u0027 VMs will be under a higher"},{"line_number":38,"context_line":"failure point."}],"source_content_type":"text/x-rst","patch_set":3,"id":"0b7d14a7_13b59516","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":42},"updated":"2021-03-31 10:07:38.000000000","message":"nit:typically","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f9c155fa7930ccef7ab8f2830e455bccf541f123","unresolved":false,"context_lines":[{"line_number":32,"context_line":"hacked."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"},{"line_number":35,"context_line":"CPU when user send small packet (topically 64B small) from"},{"line_number":36,"context_line":"the VM to the others, even if the device has lower QoS bandwidth limitation."},{"line_number":37,"context_line":"Then your host services and other users\u0027 VMs will be under a higher"},{"line_number":38,"context_line":"failure point."}],"source_content_type":"text/x-rst","patch_set":3,"id":"40aef17a_9110100e","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":42},"in_reply_to":"0b7d14a7_13b59516","updated":"2021-04-09 01:08:21.000000000","message":"Done","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ad52b0a1ccafa9a1779df5d9954cd8a9e0fc40fd","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \u0027parent\u0027: qos_apidef._PARENT,"},{"line_number":64,"context_line":"            \u0027parameters\u0027: {"},{"line_number":65,"context_line":"                qos_apidef._QOS_RULE_COMMON_FIELDS,"},{"line_number":66,"context_line":"                \u0027max_pps\u0027: {"},{"line_number":67,"context_line":"                    \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":68,"context_line":"                    \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":69,"context_line":"                    \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aad08ee_3c3bdd0e","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":24},"updated":"2021-03-31 10:07:38.000000000","message":"bandwidth limit is in kbps. Do we need pps resolution here or would it be enough to have kpps similarly to kbps?","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f9c155fa7930ccef7ab8f2830e455bccf541f123","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027parent\u0027: qos_apidef._PARENT,"},{"line_number":64,"context_line":"            \u0027parameters\u0027: {"},{"line_number":65,"context_line":"                qos_apidef._QOS_RULE_COMMON_FIELDS,"},{"line_number":66,"context_line":"                \u0027max_pps\u0027: {"},{"line_number":67,"context_line":"                    \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":68,"context_line":"                    \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":69,"context_line":"                    \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4df2c200_d92fea17","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":24},"in_reply_to":"0653290a_fb6a249c","updated":"2021-04-09 01:08:21.000000000","message":"Done","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"99cde85cd1315eeb9307e3e41b4d67eb612bee99","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \u0027parent\u0027: qos_apidef._PARENT,"},{"line_number":64,"context_line":"            \u0027parameters\u0027: {"},{"line_number":65,"context_line":"                qos_apidef._QOS_RULE_COMMON_FIELDS,"},{"line_number":66,"context_line":"                \u0027max_pps\u0027: {"},{"line_number":67,"context_line":"                    \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":68,"context_line":"                    \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":69,"context_line":"                    \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0653290a_fb6a249c","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":24},"in_reply_to":"239566cd_044d3c3b","updated":"2021-04-07 13:37:07.000000000","message":"After further thinking I would prefer the kpps unit. It is more future proof to allow bigger values as the capability of the devices will only increase in the future. While the traffic restricting case can be better achieved with the bandwidth limit rule.","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b861b61dd58750d2b54501a9de5cd20798126f1a","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \u0027parent\u0027: qos_apidef._PARENT,"},{"line_number":64,"context_line":"            \u0027parameters\u0027: {"},{"line_number":65,"context_line":"                qos_apidef._QOS_RULE_COMMON_FIELDS,"},{"line_number":66,"context_line":"                \u0027max_pps\u0027: {"},{"line_number":67,"context_line":"                    \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":68,"context_line":"                    \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":69,"context_line":"                    \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"239566cd_044d3c3b","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":24},"in_reply_to":"6ea84ad4_9cdbb71f","updated":"2021-04-06 12:21:54.000000000","message":"hm it seems we have to compromise either with the resolution or with the max value. Both seem limiting somehow. Disabling vNIC traffic can be done with bandwidth limit rule as well, by setting that to lowest 1 kbps, that is lot lest than 12Mbps with the 1kpps rule. \n\nA third option would be to change the DB field type to a wider than 32 bit type. I guess it has some consequences on other parts of the code assuming 32bit integers. (At least placement resource inventory also using integer database columns with the same limits)","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"65404188b700f6998e0cf2941c949ae34cf13b19","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \u0027parent\u0027: qos_apidef._PARENT,"},{"line_number":64,"context_line":"            \u0027parameters\u0027: {"},{"line_number":65,"context_line":"                qos_apidef._QOS_RULE_COMMON_FIELDS,"},{"line_number":66,"context_line":"                \u0027max_pps\u0027: {"},{"line_number":67,"context_line":"                    \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":68,"context_line":"                    \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":69,"context_line":"                    \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b56347ac_8d1092b8","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":24},"in_reply_to":"7aad08ee_3c3bdd0e","updated":"2021-04-06 07:54:38.000000000","message":"Sounds reasonable, let\u0027s wait and see others\u0027 opinion.\n\nBut from my personal experiences, there is such a scenario, administrators have no right to shutdown the customers\u0027 VMs, but they have ability to disable the vNIC\u0027s traffic. A minimim 1K pps is a bit high for such situation, because 1K * 1500B(mtu) \u003d 12Mbps. And, I\u0027m not sure if 0 kpps can work for real TC rules.","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"227a6bd89f8a006ae3295068cdac9b4c9539dd85","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \u0027parent\u0027: qos_apidef._PARENT,"},{"line_number":64,"context_line":"            \u0027parameters\u0027: {"},{"line_number":65,"context_line":"                qos_apidef._QOS_RULE_COMMON_FIELDS,"},{"line_number":66,"context_line":"                \u0027max_pps\u0027: {"},{"line_number":67,"context_line":"                    \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":68,"context_line":"                    \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":69,"context_line":"                    \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6ea84ad4_9cdbb71f","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":24},"in_reply_to":"b56347ac_8d1092b8","updated":"2021-04-06 10:33:11.000000000","message":"According to the gibi\u0027s comment below I think it would be better to use kpps here and not have this 2gpps upper limit.","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ad52b0a1ccafa9a1779df5d9954cd8a9e0fc40fd","unresolved":true,"context_lines":[{"line_number":70,"context_line":"                    \u0027is_filter\u0027: True,"},{"line_number":71,"context_line":"                    \u0027is_sort_key\u0027: True,"},{"line_number":72,"context_line":"                    \u0027validate\u0027: {"},{"line_number":73,"context_line":"                        \u0027type:range\u0027: [0, db_const.DB_INTEGER_MAX_VALUE]}"},{"line_number":74,"context_line":"                },"},{"line_number":75,"context_line":"                \u0027max_burst_pps\u0027: {"},{"line_number":76,"context_line":"                        \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b34f155f_d02b6a00","line":73,"range":{"start_line":73,"start_character":51,"end_line":73,"end_character":71},"updated":"2021-03-31 10:07:38.000000000","message":"this now limits the value to ~2gpps, I suggest to remove that limitation by using kpps unit instead","commit_id":"bb8626839a427eb99bba6c108cade853d341238f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"96aeee022acc6c624948db8aa89e595378baf0db","unresolved":true,"context_lines":[{"line_number":26,"context_line":"For cloud providers, to limit the packet per second (pps)"},{"line_number":27,"context_line":"of VM NIC is popular and sometimes essential. Transit large set of"},{"line_number":28,"context_line":"packets for VM in physical compute hosts will consume the"},{"line_number":29,"context_line":"CPU and physical NIC I/O performance. For small packets, even the"},{"line_number":30,"context_line":"bandwidth is low, the pps can still be higher. Without the limitation,"},{"line_number":31,"context_line":"it can be an attact point inside the cloud while some VMs are becoming"},{"line_number":32,"context_line":"hacked."}],"source_content_type":"text/x-rst","patch_set":4,"id":"eae99afa_4bee9dd2","line":29,"range":{"start_line":29,"start_character":57,"end_line":29,"end_character":65},"updated":"2021-04-09 07:27:11.000000000","message":"nit: even if the....","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9c45a6d688537f9cb1e97e30dd1510295d49b22","unresolved":false,"context_lines":[{"line_number":26,"context_line":"For cloud providers, to limit the packet per second (pps)"},{"line_number":27,"context_line":"of VM NIC is popular and sometimes essential. Transit large set of"},{"line_number":28,"context_line":"packets for VM in physical compute hosts will consume the"},{"line_number":29,"context_line":"CPU and physical NIC I/O performance. For small packets, even the"},{"line_number":30,"context_line":"bandwidth is low, the pps can still be higher. Without the limitation,"},{"line_number":31,"context_line":"it can be an attact point inside the cloud while some VMs are becoming"},{"line_number":32,"context_line":"hacked."}],"source_content_type":"text/x-rst","patch_set":4,"id":"0594730c_653c678a","line":29,"range":{"start_line":29,"start_character":57,"end_line":29,"end_character":65},"in_reply_to":"eae99afa_4bee9dd2","updated":"2021-04-14 02:05:28.000000000","message":"Done","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"96aeee022acc6c624948db8aa89e595378baf0db","unresolved":true,"context_lines":[{"line_number":28,"context_line":"packets for VM in physical compute hosts will consume the"},{"line_number":29,"context_line":"CPU and physical NIC I/O performance. For small packets, even the"},{"line_number":30,"context_line":"bandwidth is low, the pps can still be higher. Without the limitation,"},{"line_number":31,"context_line":"it can be an attact point inside the cloud while some VMs are becoming"},{"line_number":32,"context_line":"hacked."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8aec4f3e_080f6661","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":19},"updated":"2021-04-09 07:27:11.000000000","message":"nit: attack","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9c45a6d688537f9cb1e97e30dd1510295d49b22","unresolved":false,"context_lines":[{"line_number":28,"context_line":"packets for VM in physical compute hosts will consume the"},{"line_number":29,"context_line":"CPU and physical NIC I/O performance. For small packets, even the"},{"line_number":30,"context_line":"bandwidth is low, the pps can still be higher. Without the limitation,"},{"line_number":31,"context_line":"it can be an attact point inside the cloud while some VMs are becoming"},{"line_number":32,"context_line":"hacked."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For L2 drivers like ovs and ovn, it may get extremly high usage of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c1f7711b_114b166c","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":19},"in_reply_to":"8aec4f3e_080f6661","updated":"2021-04-14 02:05:28.000000000","message":"Done","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d9c7fd275f87bc58391dd6049738f21e56343ed","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                \u0027direction\u0027: {"},{"line_number":85,"context_line":"                    \u0027allow_post\u0027: True,"},{"line_number":86,"context_line":"                    \u0027allow_put\u0027: True,"},{"line_number":87,"context_line":"                    \u0027is_visible\u0027: True,"},{"line_number":88,"context_line":"                    \u0027default\u0027: constants.EGRESS_DIRECTION,"},{"line_number":89,"context_line":"                    \u0027validate\u0027: {"},{"line_number":90,"context_line":"                        \u0027type:values\u0027: constants.VALID_DIRECTIONS}"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fcf86d62_fcc53087","line":87,"updated":"2021-04-09 12:56:50.000000000","message":"we allow filtering and sorting by direction in the other rules","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9c45a6d688537f9cb1e97e30dd1510295d49b22","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                \u0027direction\u0027: {"},{"line_number":85,"context_line":"                    \u0027allow_post\u0027: True,"},{"line_number":86,"context_line":"                    \u0027allow_put\u0027: True,"},{"line_number":87,"context_line":"                    \u0027is_visible\u0027: True,"},{"line_number":88,"context_line":"                    \u0027default\u0027: constants.EGRESS_DIRECTION,"},{"line_number":89,"context_line":"                    \u0027validate\u0027: {"},{"line_number":90,"context_line":"                        \u0027type:values\u0027: constants.VALID_DIRECTIONS}"}],"source_content_type":"text/x-rst","patch_set":4,"id":"41cf8767_7fd2c83f","line":87,"in_reply_to":"fcf86d62_fcc53087","updated":"2021-04-14 02:05:28.000000000","message":"Done","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"96aeee022acc6c624948db8aa89e595378baf0db","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        }"},{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. note:: The unit for the rate and burst is kilo packets per second,"},{"line_number":97,"context_line":"          so the value range will be 1 kpps to 2147 gpps."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Potential agent side enhancements"}],"source_content_type":"text/x-rst","patch_set":4,"id":"2092e6fd_fbcc1670","line":96,"range":{"start_line":96,"start_character":45,"end_line":96,"end_character":49},"updated":"2021-04-09 07:27:11.000000000","message":"dummy question: this kilo is 1000 or 1024?","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b14830339d562dcea6b2d2665927fc826e72e1b","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        }"},{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. note:: The unit for the rate and burst is kilo packets per second,"},{"line_number":97,"context_line":"          so the value range will be 1 kpps to 2147 gpps."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Potential agent side enhancements"}],"source_content_type":"text/x-rst","patch_set":4,"id":"888e2cea_b16e3213","line":96,"range":{"start_line":96,"start_character":45,"end_line":96,"end_character":49},"in_reply_to":"2092e6fd_fbcc1670","updated":"2021-04-09 07:54:12.000000000","message":"good question :)","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9c45a6d688537f9cb1e97e30dd1510295d49b22","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        }"},{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. note:: The unit for the rate and burst is kilo packets per second,"},{"line_number":97,"context_line":"          so the value range will be 1 kpps to 2147 gpps."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Potential agent side enhancements"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b879032d_87ec32d1","line":96,"range":{"start_line":96,"start_character":45,"end_line":96,"end_character":49},"in_reply_to":"33733ee9_278d2ce4","updated":"2021-04-14 02:05:28.000000000","message":"Done. It\u0027s 1000.","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d9c7fd275f87bc58391dd6049738f21e56343ed","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        }"},{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. note:: The unit for the rate and burst is kilo packets per second,"},{"line_number":97,"context_line":"          so the value range will be 1 kpps to 2147 gpps."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Potential agent side enhancements"}],"source_content_type":"text/x-rst","patch_set":4,"id":"33733ee9_278d2ce4","line":96,"range":{"start_line":96,"start_character":45,"end_line":96,"end_character":49},"in_reply_to":"888e2cea_b16e3213","updated":"2021-04-09 12:56:50.000000000","message":"Packets are defined per unit in netfilter [1]. This should use IS (1000), this is not a IEC (1024) unit.\n\nIMO, it is worthy to mention this here.\n\n[1]https://www.netfilter.org/documentation/HOWTO/packet-filtering-HOWTO-7.html","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d9c7fd275f87bc58391dd6049738f21e56343ed","unresolved":true,"context_lines":[{"line_number":100,"context_line":"---------------------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Each of the following will be an independent and huge proposal, we will"},{"line_number":103,"context_line":"not describe the detail here."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"* apply pps rule to L3 IPs in agent side by iptables rule [1]_."},{"line_number":106,"context_line":"* apply pps rule to VM port by ovs meter [2]_ [3]_ [4]_."}],"source_content_type":"text/x-rst","patch_set":4,"id":"6f42fbaa_bb82aaea","line":103,"updated":"2021-04-09 12:56:50.000000000","message":"I understand this list (as an active developer in Neutron) but could be confusing for other people. IMO, this should be:\n- \"pps\" rule for floating IP, using the L3 agent\n- \"pps\" rule for floating IP, using OVN L3 agent\n- \"pps\" rule for gateway IP, using the L3 agent\n- \"pps\" rule for gateway IP, using OVN L3 agent\n- \"pps\" rule for ML2 OVS VM ports\n- \"pps\" rule for ML2 OVN VM ports","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9c45a6d688537f9cb1e97e30dd1510295d49b22","unresolved":true,"context_lines":[{"line_number":100,"context_line":"---------------------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Each of the following will be an independent and huge proposal, we will"},{"line_number":103,"context_line":"not describe the detail here."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"* apply pps rule to L3 IPs in agent side by iptables rule [1]_."},{"line_number":106,"context_line":"* apply pps rule to VM port by ovs meter [2]_ [3]_ [4]_."}],"source_content_type":"text/x-rst","patch_set":4,"id":"94f5181b_b6aa246c","line":103,"in_reply_to":"6f42fbaa_bb82aaea","updated":"2021-04-14 02:05:28.000000000","message":"I will add the list to a new section \"User use cases\". The following I added here is intending to us neutron developers. 😊","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d9c7fd275f87bc58391dd6049738f21e56343ed","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"* apply pps rule to L3 IPs in agent side by iptables rule [1]_."},{"line_number":106,"context_line":"* apply pps rule to VM port by ovs meter [2]_ [3]_ [4]_."},{"line_number":107,"context_line":"* apply pps rule to router ports (gateway port, router interface) by iptables rule."},{"line_number":108,"context_line":"* apply pps rule to L3 IPs and ports to OVN related devices by ovs meter."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"99fdc6db_c43841af","line":107,"range":{"start_line":107,"start_character":34,"end_line":107,"end_character":64},"updated":"2021-04-09 12:56:50.000000000","message":"I don\u0027t understand this. We can apply QoS rules on a GW port, that\u0027s all. Isn\u0027t it?","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9c45a6d688537f9cb1e97e30dd1510295d49b22","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"* apply pps rule to L3 IPs in agent side by iptables rule [1]_."},{"line_number":106,"context_line":"* apply pps rule to VM port by ovs meter [2]_ [3]_ [4]_."},{"line_number":107,"context_line":"* apply pps rule to router ports (gateway port, router interface) by iptables rule."},{"line_number":108,"context_line":"* apply pps rule to L3 IPs and ports to OVN related devices by ovs meter."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"27b75816_c7bcc748","line":107,"range":{"start_line":107,"start_character":34,"end_line":107,"end_character":64},"in_reply_to":"99fdc6db_c43841af","updated":"2021-04-14 02:05:28.000000000","message":"We can set qos policy to router interface, there is no restriction for this action now. Not sure if this real works, for legacy router, the router interface has only one place to live. Maybe ovs can set the qos (tc) rule for it.","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d9c7fd275f87bc58391dd6049738f21e56343ed","unresolved":true,"context_lines":[{"line_number":143,"context_line":"                                  sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":144,"context_line":"                                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":145,"context_line":"                                  nullable\u003dFalse)"},{"line_number":146,"context_line":"        max_mpps \u003d sa.Column(sa.Integer)"},{"line_number":147,"context_line":"        max_burst_mpps \u003d sa.Column(sa.Integer)"},{"line_number":148,"context_line":"        revises_on_change \u003d (\u0027qos_policy\u0027,)"},{"line_number":149,"context_line":"        qos_policy \u003d sa.orm.relationship(QosPolicy, load_on_pending\u003dTrue)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"f1990a4a_603d2526","line":146,"range":{"start_line":146,"start_character":8,"end_line":146,"end_character":16},"updated":"2021-04-09 12:56:50.000000000","message":"Why this unit conversion? It is better to keep the same DB register value without any conversion. Furthermore, you are limiting the precision.","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9c45a6d688537f9cb1e97e30dd1510295d49b22","unresolved":true,"context_lines":[{"line_number":143,"context_line":"                                  sa.ForeignKey(\u0027qos_policies.id\u0027,"},{"line_number":144,"context_line":"                                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":145,"context_line":"                                  nullable\u003dFalse)"},{"line_number":146,"context_line":"        max_mpps \u003d sa.Column(sa.Integer)"},{"line_number":147,"context_line":"        max_burst_mpps \u003d sa.Column(sa.Integer)"},{"line_number":148,"context_line":"        revises_on_change \u003d (\u0027qos_policy\u0027,)"},{"line_number":149,"context_line":"        qos_policy \u003d sa.orm.relationship(QosPolicy, load_on_pending\u003dTrue)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8cf22828_2abbb422","line":146,"range":{"start_line":146,"start_character":8,"end_line":146,"end_character":16},"in_reply_to":"f1990a4a_603d2526","updated":"2021-04-14 02:05:28.000000000","message":"Nice catch. Will fix this.","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d9c7fd275f87bc58391dd6049738f21e56343ed","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":145,"context_line":"                                  nullable\u003dFalse)"},{"line_number":146,"context_line":"        max_mpps \u003d sa.Column(sa.Integer)"},{"line_number":147,"context_line":"        max_burst_mpps \u003d sa.Column(sa.Integer)"},{"line_number":148,"context_line":"        revises_on_change \u003d (\u0027qos_policy\u0027,)"},{"line_number":149,"context_line":"        qos_policy \u003d sa.orm.relationship(QosPolicy, load_on_pending\u003dTrue)"},{"line_number":150,"context_line":"        direction \u003d sa.Column(sa.Enum(constants.EGRESS_DIRECTION,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8463b4d6_f2415812","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":22},"updated":"2021-04-09 12:56:50.000000000","message":"ditto","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e9c45a6d688537f9cb1e97e30dd1510295d49b22","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":145,"context_line":"                                  nullable\u003dFalse)"},{"line_number":146,"context_line":"        max_mpps \u003d sa.Column(sa.Integer)"},{"line_number":147,"context_line":"        max_burst_mpps \u003d sa.Column(sa.Integer)"},{"line_number":148,"context_line":"        revises_on_change \u003d (\u0027qos_policy\u0027,)"},{"line_number":149,"context_line":"        qos_policy \u003d sa.orm.relationship(QosPolicy, load_on_pending\u003dTrue)"},{"line_number":150,"context_line":"        direction \u003d sa.Column(sa.Enum(constants.EGRESS_DIRECTION,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3b80994e_010de3e0","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":22},"in_reply_to":"8463b4d6_f2415812","updated":"2021-04-14 02:05:28.000000000","message":"Done","commit_id":"75202404cd17d0163820cb42fb95c0b2bce734d1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0b16e39c38dd9b2b4bbb500196134493d858da28","unresolved":true,"context_lines":[{"line_number":112,"context_line":"User use cases"},{"line_number":113,"context_line":"--------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"After the L3 backends have the real abilities to limit the pps,"},{"line_number":116,"context_line":"then users can use the pps rule in the following scenarios:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* \"pps\" rule for floating IP, using the L3 agent"}],"source_content_type":"text/x-rst","patch_set":5,"id":"e05015d1_88502f6e","line":115,"range":{"start_line":115,"start_character":21,"end_line":115,"end_character":26},"updated":"2021-04-16 07:36:25.000000000","message":"will have","commit_id":"a7f6cf2f4bc66fed10757846ba9f71a785541403"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c709466b17a648809b6c1a757dc3734718c7d368","unresolved":true,"context_lines":[{"line_number":112,"context_line":"User use cases"},{"line_number":113,"context_line":"--------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"After the L3 backends have the real abilities to limit the pps,"},{"line_number":116,"context_line":"then users can use the pps rule in the following scenarios:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* \"pps\" rule for floating IP, using the L3 agent"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bc6341ac_cfd896e0","line":115,"range":{"start_line":115,"start_character":21,"end_line":115,"end_character":26},"in_reply_to":"e05015d1_88502f6e","updated":"2021-04-16 08:39:59.000000000","message":"There is an \"after\" in the begining.  IMO, This should be \"After we have ..., (then) ....\"","commit_id":"a7f6cf2f4bc66fed10757846ba9f71a785541403"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0b16e39c38dd9b2b4bbb500196134493d858da28","unresolved":true,"context_lines":[{"line_number":120,"context_line":"* \"pps\" rule for gateway IP, using the L3 agent"},{"line_number":121,"context_line":"* \"pps\" rule for gateway IP, using OVN L3 agent"},{"line_number":122,"context_line":"* \"pps\" rule for ML2 OVS VM ports"},{"line_number":123,"context_line":"* \"pps\" rule for ML2 OVN VM ports"},{"line_number":124,"context_line":"* \"pps\" rule for router gateway or interface ports"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"382c4cf9_35839ec2","line":123,"updated":"2021-04-16 07:36:25.000000000","message":"In L115 You are talking about L3 backends and here You are mentioning ML2/OVS and ML2/OVN which are L2 backends. Is that correct?","commit_id":"a7f6cf2f4bc66fed10757846ba9f71a785541403"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c709466b17a648809b6c1a757dc3734718c7d368","unresolved":false,"context_lines":[{"line_number":120,"context_line":"* \"pps\" rule for gateway IP, using the L3 agent"},{"line_number":121,"context_line":"* \"pps\" rule for gateway IP, using OVN L3 agent"},{"line_number":122,"context_line":"* \"pps\" rule for ML2 OVS VM ports"},{"line_number":123,"context_line":"* \"pps\" rule for ML2 OVN VM ports"},{"line_number":124,"context_line":"* \"pps\" rule for router gateway or interface ports"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"907855fa_676a008c","line":123,"in_reply_to":"382c4cf9_35839ec2","updated":"2021-04-16 08:39:59.000000000","message":"Done, change the subject of L115 to \"L2/L3 backends\"","commit_id":"a7f6cf2f4bc66fed10757846ba9f71a785541403"}]}