)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a8e0c5a4012565bbc0ed52a0ea057bc8aa50b376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff83fdbd_89d5355a","updated":"2021-11-17 11:09:20.000000000","message":"Thanks","commit_id":"8f136023f52887e67c0a0d43e2a309c9c41f3c56"}],"specs/yoga/qos-minimum-guaranteed-packet-rate.rst":[{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"2fe3b2d9e1d1a553e1c3d023467ecac31c45fbb5","unresolved":true,"context_lines":[{"line_number":196,"context_line":"                },"},{"line_number":197,"context_line":"                \u0027direction\u0027: {"},{"line_number":198,"context_line":"                    \u0027allow_post\u0027: True,"},{"line_number":199,"context_line":"                    \u0027allow_put\u0027: False,"},{"line_number":200,"context_line":"                    \u0027is_visible\u0027: True,"},{"line_number":201,"context_line":"                    \u0027validate\u0027: {"},{"line_number":202,"context_line":"                        \u0027type:values\u0027: ("}],"source_content_type":"text/x-rst","patch_set":2,"id":"4160bb79_908ed42f","line":199,"range":{"start_line":199,"start_character":33,"end_line":199,"end_character":38},"updated":"2021-09-16 06:17:55.000000000","message":"True","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                },"},{"line_number":197,"context_line":"                \u0027direction\u0027: {"},{"line_number":198,"context_line":"                    \u0027allow_post\u0027: True,"},{"line_number":199,"context_line":"                    \u0027allow_put\u0027: False,"},{"line_number":200,"context_line":"                    \u0027is_visible\u0027: True,"},{"line_number":201,"context_line":"                    \u0027validate\u0027: {"},{"line_number":202,"context_line":"                        \u0027type:values\u0027: ("}],"source_content_type":"text/x-rst","patch_set":2,"id":"aeef29a8_eb82ad28","line":199,"range":{"start_line":199,"start_character":33,"end_line":199,"end_character":38},"in_reply_to":"4160bb79_908ed42f","updated":"2021-09-16 11:33:42.000000000","message":"Done","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"2fe3b2d9e1d1a553e1c3d023467ecac31c45fbb5","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                \u0027direction\u0027: {"},{"line_number":198,"context_line":"                    \u0027allow_post\u0027: True,"},{"line_number":199,"context_line":"                    \u0027allow_put\u0027: False,"},{"line_number":200,"context_line":"                    \u0027is_visible\u0027: True,"},{"line_number":201,"context_line":"                    \u0027validate\u0027: {"},{"line_number":202,"context_line":"                        \u0027type:values\u0027: ("},{"line_number":203,"context_line":"                            constants.ANY_DIRECTION,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6c92ea4c_cd611a3b","line":200,"updated":"2021-09-16 06:17:55.000000000","message":"\u0027default\u0027: constants.EGRESS_DIRECTION,","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                \u0027direction\u0027: {"},{"line_number":198,"context_line":"                    \u0027allow_post\u0027: True,"},{"line_number":199,"context_line":"                    \u0027allow_put\u0027: False,"},{"line_number":200,"context_line":"                    \u0027is_visible\u0027: True,"},{"line_number":201,"context_line":"                    \u0027validate\u0027: {"},{"line_number":202,"context_line":"                        \u0027type:values\u0027: ("},{"line_number":203,"context_line":"                            constants.ANY_DIRECTION,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dde613e1_ff30037b","line":200,"in_reply_to":"6c92ea4c_cd611a3b","updated":"2021-09-16 11:33:42.000000000","message":"Done","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"2fe3b2d9e1d1a553e1c3d023467ecac31c45fbb5","unresolved":true,"context_lines":[{"line_number":281,"context_line":"      }"},{"line_number":282,"context_line":"    }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"* ``GET /v2.0/qos/minimum_packet_rate_rules/{rule_id}``"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"  Show minimum packet rate rule details"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1b2d0c2c_f8297b19","line":284,"range":{"start_line":284,"start_character":4,"end_line":284,"end_character":53},"updated":"2021-09-16 06:17:55.000000000","message":"GET /v2.0/qos/policies/{policy_id}/minimum_packet_rate_rules/{rule_id}","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":false,"context_lines":[{"line_number":281,"context_line":"      }"},{"line_number":282,"context_line":"    }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"* ``GET /v2.0/qos/minimum_packet_rate_rules/{rule_id}``"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"  Show minimum packet rate rule details"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f6082686_d4d453cc","line":284,"range":{"start_line":284,"start_character":4,"end_line":284,"end_character":53},"in_reply_to":"1b2d0c2c_f8297b19","updated":"2021-09-16 11:33:42.000000000","message":"Done","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"2fe3b2d9e1d1a553e1c3d023467ecac31c45fbb5","unresolved":true,"context_lines":[{"line_number":295,"context_line":"      }"},{"line_number":296,"context_line":"    }"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"* ``PUT /v2.0/qos/minimum_packet_rate_rules/{rule_id}``"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"  Update minimum packet rate rule"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3398c35c_d5c142f4","line":298,"range":{"start_line":298,"start_character":4,"end_line":298,"end_character":53},"updated":"2021-09-16 06:17:55.000000000","message":"PUT /v2.0/qos/policies/{policy_id}/minimum_packet_rate_rules/{rule_id}","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":false,"context_lines":[{"line_number":295,"context_line":"      }"},{"line_number":296,"context_line":"    }"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"* ``PUT /v2.0/qos/minimum_packet_rate_rules/{rule_id}``"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"  Update minimum packet rate rule"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"053eb4db_b2952002","line":298,"range":{"start_line":298,"start_character":4,"end_line":298,"end_character":53},"in_reply_to":"3398c35c_d5c142f4","updated":"2021-09-16 11:33:42.000000000","message":"Done","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"2fe3b2d9e1d1a553e1c3d023467ecac31c45fbb5","unresolved":true,"context_lines":[{"line_number":304,"context_line":"    {"},{"line_number":305,"context_line":"      \"minimum_packet_rate_rule\": {"},{"line_number":306,"context_line":"          \"min_kpps\": 2000"},{"line_number":307,"context_line":"      }"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  Response::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"27830bd2_c4296df6","line":307,"range":{"start_line":307,"start_character":0,"end_line":307,"end_character":7},"updated":"2021-09-16 06:17:55.000000000","message":"\"direction\": \"any\",","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    {"},{"line_number":305,"context_line":"      \"minimum_packet_rate_rule\": {"},{"line_number":306,"context_line":"          \"min_kpps\": 2000"},{"line_number":307,"context_line":"      }"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  Response::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"56a807a1_e798b14d","line":307,"range":{"start_line":307,"start_character":0,"end_line":307,"end_character":7},"in_reply_to":"27830bd2_c4296df6","updated":"2021-09-16 11:33:42.000000000","message":"Done","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"2fe3b2d9e1d1a553e1c3d023467ecac31c45fbb5","unresolved":true,"context_lines":[{"line_number":317,"context_line":"      }"},{"line_number":318,"context_line":"    }"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"* ``DELETE /v2.0/qos/packet_rate_limit_rules/{rule_id}``"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  Delete minimum packet rate rule"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"010a6ca7_c0bb981c","line":320,"range":{"start_line":320,"start_character":4,"end_line":320,"end_character":54},"updated":"2021-09-16 06:17:55.000000000","message":"DELETE /v2.0/qos/policies/{policy_id}/minimum_packet_rate_rules/{rule_id}","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":false,"context_lines":[{"line_number":317,"context_line":"      }"},{"line_number":318,"context_line":"    }"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"* ``DELETE /v2.0/qos/packet_rate_limit_rules/{rule_id}``"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  Delete minimum packet rate rule"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"e513facd_db6a7d63","line":320,"range":{"start_line":320,"start_character":4,"end_line":320,"end_character":54},"in_reply_to":"010a6ca7_c0bb981c","updated":"2021-09-16 11:33:42.000000000","message":"Done","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"2fe3b2d9e1d1a553e1c3d023467ecac31c45fbb5","unresolved":true,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  Delete minimum packet rate rule"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":".. note::"},{"line_number":325,"context_line":"    This spec intentionally does not propose the addition of the old style"},{"line_number":326,"context_line":"    ``/v2.0/qos/policies/{policy_id}/minimum_packet_rate_rules/{rule_id}`` APIs"},{"line_number":327,"context_line":"    as Neutron team prefers the"},{"line_number":328,"context_line":"    ``/v2.0/qos/alias_bandwidth_limit_rules/{rule_id}`` style APIs in the"},{"line_number":329,"context_line":"    future. The old style APIs only kept for backwards compatibility for"},{"line_number":330,"context_line":"    already existing QoS rules. However as this new API will not have an old"},{"line_number":331,"context_line":"    style counterpart the \u0027alias\u0027 prefix is removed from the resource name."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"To persist the new QoS rule type a new DB table"},{"line_number":334,"context_line":"``qos_minimum_packet_rate_rules`` is needed::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"785b654b_c3d32d72","line":331,"range":{"start_line":324,"start_character":0,"end_line":331,"end_character":75},"updated":"2021-09-16 06:17:55.000000000","message":"I think this part is no longer relevant.\nWe can mention that QoS rule alias will be added for minimum packet rate rule and it will use \u0027alias_\u0027 prefix just like other rules do.","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"db06ac51fd9379659f6195355ae5f1ae29d59019","unresolved":true,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  Delete minimum packet rate rule"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":".. note::"},{"line_number":325,"context_line":"    This spec intentionally does not propose the addition of the old style"},{"line_number":326,"context_line":"    ``/v2.0/qos/policies/{policy_id}/minimum_packet_rate_rules/{rule_id}`` APIs"},{"line_number":327,"context_line":"    as Neutron team prefers the"},{"line_number":328,"context_line":"    ``/v2.0/qos/alias_bandwidth_limit_rules/{rule_id}`` style APIs in the"},{"line_number":329,"context_line":"    future. The old style APIs only kept for backwards compatibility for"},{"line_number":330,"context_line":"    already existing QoS rules. However as this new API will not have an old"},{"line_number":331,"context_line":"    style counterpart the \u0027alias\u0027 prefix is removed from the resource name."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"To persist the new QoS rule type a new DB table"},{"line_number":334,"context_line":"``qos_minimum_packet_rate_rules`` is needed::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"474510a8_c9c775a0","line":331,"range":{"start_line":324,"start_character":0,"end_line":331,"end_character":75},"in_reply_to":"2f50db45_8ca92640","updated":"2021-09-16 11:47:47.000000000","message":"Due to Neutron limitations, it wasn\u0027t feasible to add support for /v2.0/qos/minimum_packet_rate_rules/{rule_id} style APIs exclusively.\nWe have to support old-style API too.\nI had a chat with Slaweq about it, and we agreed that initially I\u0027ll add support for old-style API.\nAfterwards, I\u0027ll add a new rule alias, but it\u0027s not documented in api-ref at the moment.","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":true,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  Delete minimum packet rate rule"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":".. note::"},{"line_number":325,"context_line":"    This spec intentionally does not propose the addition of the old style"},{"line_number":326,"context_line":"    ``/v2.0/qos/policies/{policy_id}/minimum_packet_rate_rules/{rule_id}`` APIs"},{"line_number":327,"context_line":"    as Neutron team prefers the"},{"line_number":328,"context_line":"    ``/v2.0/qos/alias_bandwidth_limit_rules/{rule_id}`` style APIs in the"},{"line_number":329,"context_line":"    future. The old style APIs only kept for backwards compatibility for"},{"line_number":330,"context_line":"    already existing QoS rules. However as this new API will not have an old"},{"line_number":331,"context_line":"    style counterpart the \u0027alias\u0027 prefix is removed from the resource name."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"To persist the new QoS rule type a new DB table"},{"line_number":334,"context_line":"``qos_minimum_packet_rate_rules`` is needed::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2f50db45_8ca92640","line":331,"range":{"start_line":324,"start_character":0,"end_line":331,"end_character":75},"in_reply_to":"785b654b_c3d32d72","updated":"2021-09-16 11:33:42.000000000","message":"\u003e I think this part is no longer relevant.\n\nack\n\n\u003e We can mention that QoS rule alias will be added for minimum packet rate rule and it will use \u0027alias_\u0027 prefix just like other rules do.\n\nIs it so? I see the above proposed resources in the doc [1] but I don\u0027t see the alias [2]. Is it something that will come later? \n\n[1] https://docs.openstack.org/api-ref/network/v2/index.html#qos-minimum-packet-rate-rules\n[ ] https://docs.openstack.org/api-ref/network/v2/index.html#quality-of-service-rules-alias-api","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"2fe3b2d9e1d1a553e1c3d023467ecac31c45fbb5","unresolved":true,"context_lines":[{"line_number":345,"context_line":"                                           constants.INGRESS_DIRECTION,"},{"line_number":346,"context_line":"                                           name\u003d\"directions\"),"},{"line_number":347,"context_line":"                      nullable\u003dFalse,"},{"line_number":348,"context_line":"                      server_default\u003dNone),"},{"line_number":349,"context_line":"            sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":350,"context_line":"            sa.ForeignKeyConstraint([\u0027qos_policy_id\u0027], [\u0027qos_policies.id\u0027],"},{"line_number":351,"context_line":"                                    ondelete\u003d\u0027CASCADE\u0027)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"68526682_af63c71b","line":348,"range":{"start_line":348,"start_character":37,"end_line":348,"end_character":41},"updated":"2021-09-16 06:17:55.000000000","message":"constants.EGRESS_DIRECTION","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                                           constants.INGRESS_DIRECTION,"},{"line_number":346,"context_line":"                                           name\u003d\"directions\"),"},{"line_number":347,"context_line":"                      nullable\u003dFalse,"},{"line_number":348,"context_line":"                      server_default\u003dNone),"},{"line_number":349,"context_line":"            sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":350,"context_line":"            sa.ForeignKeyConstraint([\u0027qos_policy_id\u0027], [\u0027qos_policies.id\u0027],"},{"line_number":351,"context_line":"                                    ondelete\u003d\u0027CASCADE\u0027)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"aca6281b_69c4ed7e","line":348,"range":{"start_line":348,"start_character":37,"end_line":348,"end_character":41},"in_reply_to":"68526682_af63c71b","updated":"2021-09-16 11:33:42.000000000","message":"Done","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dfc91c1ffcc443f27f8cc47b5ab259da2df1821f","unresolved":true,"context_lines":[{"line_number":601,"context_line":"       direction aware packet rate rule, or vice versa, is not supported and"},{"line_number":602,"context_line":"       rejected."},{"line_number":603,"context_line":"   * - The old QoS policy has both minimum bandwidth and packet rate rules,"},{"line_number":604,"context_line":"       the new policy also has less rules. Either just minimum bandwidth or"},{"line_number":605,"context_line":"       just minimum packet rate or none of them."},{"line_number":606,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":607,"context_line":"       placement."}],"source_content_type":"text/x-rst","patch_set":2,"id":"b9308959_e73e7c2d","line":604,"range":{"start_line":604,"start_character":22,"end_line":604,"end_character":26},"updated":"2021-09-16 09:17:12.000000000","message":"nit: this also sounds useless for me","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"330b6d1dd7d2986ec1f60a685ef6ca57bb5c76f2","unresolved":false,"context_lines":[{"line_number":601,"context_line":"       direction aware packet rate rule, or vice versa, is not supported and"},{"line_number":602,"context_line":"       rejected."},{"line_number":603,"context_line":"   * - The old QoS policy has both minimum bandwidth and packet rate rules,"},{"line_number":604,"context_line":"       the new policy also has less rules. Either just minimum bandwidth or"},{"line_number":605,"context_line":"       just minimum packet rate or none of them."},{"line_number":606,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":607,"context_line":"       placement."}],"source_content_type":"text/x-rst","patch_set":2,"id":"f84bfe1b_c5297880","line":604,"range":{"start_line":604,"start_character":22,"end_line":604,"end_character":26},"in_reply_to":"b9308959_e73e7c2d","updated":"2021-09-16 11:33:42.000000000","message":"Done","commit_id":"45460a306877b047f0e23da7f51184d7e2af6e7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f76dec1a52c669b3c9651c71dfcc662369e8b30","unresolved":true,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"   * - Scenario"},{"line_number":568,"context_line":"     - Result"},{"line_number":569,"context_line":"   * - Update the port.qos_policy_id from None to valid QoS policy with"},{"line_number":570,"context_line":"       minimum bandwidth rule"},{"line_number":571,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":572,"context_line":"   * - Update the port.qos_policy_id from a QoS policy without minimum"},{"line_number":573,"context_line":"       bandwidth rule to a QoS policy with minimum bandwidth rule"},{"line_number":574,"context_line":"     - Not supported. Rejected as it would require a full scheduling"}],"source_content_type":"text/x-rst","patch_set":3,"id":"630037a4_4997f2dd","line":571,"range":{"start_line":569,"start_character":1,"end_line":571,"end_character":68},"updated":"2021-09-17 06:54:42.000000000","message":"This is incorrect. Today neutron accept such update and ignores the resource request. This logic was needed as min bw dataplane enforcement was implemented first. And that supported such change. So when placement enforcement was added neutron did not want to break the data plane enforcement case by rejecting such request that is hard to support for placement enforcement.","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f77fd44fef0918de381dca4254c86e3079e1a45d","unresolved":false,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"   * - Scenario"},{"line_number":568,"context_line":"     - Result"},{"line_number":569,"context_line":"   * - Update the port.qos_policy_id from None to valid QoS policy with"},{"line_number":570,"context_line":"       minimum bandwidth rule"},{"line_number":571,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":572,"context_line":"   * - Update the port.qos_policy_id from a QoS policy without minimum"},{"line_number":573,"context_line":"       bandwidth rule to a QoS policy with minimum bandwidth rule"},{"line_number":574,"context_line":"     - Not supported. Rejected as it would require a full scheduling"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7e16a81e_d5e7419c","line":571,"range":{"start_line":569,"start_character":1,"end_line":571,"end_character":68},"in_reply_to":"4dfe9c65_b32955f3","updated":"2021-10-19 12:29:37.000000000","message":"Done","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"11002aa9493296bbec6e48d500bf351037d863fe","unresolved":true,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"   * - Scenario"},{"line_number":568,"context_line":"     - Result"},{"line_number":569,"context_line":"   * - Update the port.qos_policy_id from None to valid QoS policy with"},{"line_number":570,"context_line":"       minimum bandwidth rule"},{"line_number":571,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":572,"context_line":"   * - Update the port.qos_policy_id from a QoS policy without minimum"},{"line_number":573,"context_line":"       bandwidth rule to a QoS policy with minimum bandwidth rule"},{"line_number":574,"context_line":"     - Not supported. Rejected as it would require a full scheduling"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4dfe9c65_b32955f3","line":571,"range":{"start_line":569,"start_character":1,"end_line":571,"end_character":68},"in_reply_to":"630037a4_4997f2dd","updated":"2021-10-06 09:31:24.000000000","message":"I would go for keep the behavior of other QoS types, allow the update from None to valid QoS, as when the dataplane enforcement will be ready for min pps there should be user who do not use scheduling for it.","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f76dec1a52c669b3c9651c71dfcc662369e8b30","unresolved":true,"context_lines":[{"line_number":569,"context_line":"   * - Update the port.qos_policy_id from None to valid QoS policy with"},{"line_number":570,"context_line":"       minimum bandwidth rule"},{"line_number":571,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":572,"context_line":"   * - Update the port.qos_policy_id from a QoS policy without minimum"},{"line_number":573,"context_line":"       bandwidth rule to a QoS policy with minimum bandwidth rule"},{"line_number":574,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":575,"context_line":"   * - Update the port.qos_policy_id from a QoS policy with minimum bandwidth"},{"line_number":576,"context_line":"       rule to a QoS policy with minimum bandwidth rule but with different"},{"line_number":577,"context_line":"       min_kbps value or different direction."}],"source_content_type":"text/x-rst","patch_set":3,"id":"a2bd8f43_e2698494","line":574,"range":{"start_line":572,"start_character":5,"end_line":574,"end_character":68},"updated":"2021-09-17 06:54:42.000000000","message":"as above it is probably also supported by ignoring the resource request","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f77fd44fef0918de381dca4254c86e3079e1a45d","unresolved":false,"context_lines":[{"line_number":569,"context_line":"   * - Update the port.qos_policy_id from None to valid QoS policy with"},{"line_number":570,"context_line":"       minimum bandwidth rule"},{"line_number":571,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":572,"context_line":"   * - Update the port.qos_policy_id from a QoS policy without minimum"},{"line_number":573,"context_line":"       bandwidth rule to a QoS policy with minimum bandwidth rule"},{"line_number":574,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":575,"context_line":"   * - Update the port.qos_policy_id from a QoS policy with minimum bandwidth"},{"line_number":576,"context_line":"       rule to a QoS policy with minimum bandwidth rule but with different"},{"line_number":577,"context_line":"       min_kbps value or different direction."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4347f7ea_bdf2df0d","line":574,"range":{"start_line":572,"start_character":5,"end_line":574,"end_character":68},"in_reply_to":"1bf03ae3_8ad9d6ba","updated":"2021-10-19 12:29:37.000000000","message":"Done","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"11002aa9493296bbec6e48d500bf351037d863fe","unresolved":true,"context_lines":[{"line_number":569,"context_line":"   * - Update the port.qos_policy_id from None to valid QoS policy with"},{"line_number":570,"context_line":"       minimum bandwidth rule"},{"line_number":571,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":572,"context_line":"   * - Update the port.qos_policy_id from a QoS policy without minimum"},{"line_number":573,"context_line":"       bandwidth rule to a QoS policy with minimum bandwidth rule"},{"line_number":574,"context_line":"     - Not supported. Rejected as it would require a full scheduling"},{"line_number":575,"context_line":"   * - Update the port.qos_policy_id from a QoS policy with minimum bandwidth"},{"line_number":576,"context_line":"       rule to a QoS policy with minimum bandwidth rule but with different"},{"line_number":577,"context_line":"       min_kbps value or different direction."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1bf03ae3_8ad9d6ba","line":574,"range":{"start_line":572,"start_character":5,"end_line":574,"end_character":68},"in_reply_to":"a2bd8f43_e2698494","updated":"2021-10-06 09:31:24.000000000","message":"+1","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f76dec1a52c669b3c9651c71dfcc662369e8b30","unresolved":true,"context_lines":[{"line_number":609,"context_line":"       just minimum packet rate or none of them."},{"line_number":610,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":611,"context_line":"       placement."},{"line_number":612,"context_line":"   * - The new QoS policy adds either minimum bandwidth or packet rate rule or"},{"line_number":613,"context_line":"       both compared to the old policy."},{"line_number":614,"context_line":"     - Not supported. Rejected as the newly added rule(s) would require a full"},{"line_number":615,"context_line":"       scheduling."},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"Upgrade"},{"line_number":618,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d5948395_0fb7b093","line":615,"range":{"start_line":612,"start_character":0,"end_line":615,"end_character":18},"updated":"2021-09-17 06:54:42.000000000","message":"As above do we need to keep supporting adding min_bw rule? I.e. QoS(pps) -\u003e QoS(pps,bw) case?","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"07c9eb194032f5ce52a24b240b99d448588a824c","unresolved":true,"context_lines":[{"line_number":609,"context_line":"       just minimum packet rate or none of them."},{"line_number":610,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":611,"context_line":"       placement."},{"line_number":612,"context_line":"   * - The new QoS policy adds either minimum bandwidth or packet rate rule or"},{"line_number":613,"context_line":"       both compared to the old policy."},{"line_number":614,"context_line":"     - Not supported. Rejected as the newly added rule(s) would require a full"},{"line_number":615,"context_line":"       scheduling."},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"Upgrade"},{"line_number":618,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c3dc7e62_ae903328","line":615,"range":{"start_line":612,"start_character":0,"end_line":615,"end_character":18},"in_reply_to":"20725569_dccbb1e9","updated":"2021-10-19 09:28:07.000000000","message":"old Qos                       |  new Qos                               |     action\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nminbw\u003dNone monpps\u003d\"something\" |  minbw\u003d\"something\" minpps\u003d\"something\"  |   no res.request for minbw and do for minpps if there\u0027s a change\n                              |                                        |\nminbw\u003d\"something\" minpps\u003dNone |  minbw\u003d\"something\" minpps\u003d\"something\"  |   no res.request for minpps and do for minbw if there\u0027s a change    \n                              |                                        |\nminbw\u003dNone minpps\u003dNone        |  minbw\u003d\"something\" minpps\u003d\"something\"  |   no res.request for minpps and for minbw","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"02d5d974cdddfc861ba5b110dfc5fea2e3dffc2c","unresolved":true,"context_lines":[{"line_number":609,"context_line":"       just minimum packet rate or none of them."},{"line_number":610,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":611,"context_line":"       placement."},{"line_number":612,"context_line":"   * - The new QoS policy adds either minimum bandwidth or packet rate rule or"},{"line_number":613,"context_line":"       both compared to the old policy."},{"line_number":614,"context_line":"     - Not supported. Rejected as the newly added rule(s) would require a full"},{"line_number":615,"context_line":"       scheduling."},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"Upgrade"},{"line_number":618,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d7be9051_1794a5c8","line":615,"range":{"start_line":612,"start_character":0,"end_line":615,"end_character":18},"in_reply_to":"67585fb7_cf97ed37","updated":"2021-10-19 08:47:53.000000000","message":"@Lajos: do you mean no resource request at all, or selectively keeping pps resource request in the port but not adding bw resource request after the Qos policy update?","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f77fd44fef0918de381dca4254c86e3079e1a45d","unresolved":false,"context_lines":[{"line_number":609,"context_line":"       just minimum packet rate or none of them."},{"line_number":610,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":611,"context_line":"       placement."},{"line_number":612,"context_line":"   * - The new QoS policy adds either minimum bandwidth or packet rate rule or"},{"line_number":613,"context_line":"       both compared to the old policy."},{"line_number":614,"context_line":"     - Not supported. Rejected as the newly added rule(s) would require a full"},{"line_number":615,"context_line":"       scheduling."},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"Upgrade"},{"line_number":618,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8303094b_33e45ed6","line":615,"range":{"start_line":612,"start_character":0,"end_line":615,"end_character":18},"in_reply_to":"6b966585_35696140","updated":"2021-10-19 12:29:37.000000000","message":"Done","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e6a4e4fe383321348c98b24cd323284c1451957a","unresolved":true,"context_lines":[{"line_number":609,"context_line":"       just minimum packet rate or none of them."},{"line_number":610,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":611,"context_line":"       placement."},{"line_number":612,"context_line":"   * - The new QoS policy adds either minimum bandwidth or packet rate rule or"},{"line_number":613,"context_line":"       both compared to the old policy."},{"line_number":614,"context_line":"     - Not supported. Rejected as the newly added rule(s) would require a full"},{"line_number":615,"context_line":"       scheduling."},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"Upgrade"},{"line_number":618,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6b966585_35696140","line":615,"range":{"start_line":612,"start_character":0,"end_line":615,"end_character":18},"in_reply_to":"c3dc7e62_ae903328","updated":"2021-10-19 09:48:22.000000000","message":"hm, checking the code and chatting: the resource request is filled every time even if we change from None to \"something\" the QoS for the port","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"11002aa9493296bbec6e48d500bf351037d863fe","unresolved":true,"context_lines":[{"line_number":609,"context_line":"       just minimum packet rate or none of them."},{"line_number":610,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":611,"context_line":"       placement."},{"line_number":612,"context_line":"   * - The new QoS policy adds either minimum bandwidth or packet rate rule or"},{"line_number":613,"context_line":"       both compared to the old policy."},{"line_number":614,"context_line":"     - Not supported. Rejected as the newly added rule(s) would require a full"},{"line_number":615,"context_line":"       scheduling."},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"Upgrade"},{"line_number":618,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"67585fb7_cf97ed37","line":615,"range":{"start_line":612,"start_character":0,"end_line":615,"end_character":18},"in_reply_to":"d5948395_0fb7b093","updated":"2021-10-06 09:31:24.000000000","message":"yes but withou resource request to avoid rescheduling","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e0c51119bc68b1f846cb215124ec72cbedc36f84","unresolved":true,"context_lines":[{"line_number":609,"context_line":"       just minimum packet rate or none of them."},{"line_number":610,"context_line":"     - Supported. The allocation related to the removed rule(s) are deleted in"},{"line_number":611,"context_line":"       placement."},{"line_number":612,"context_line":"   * - The new QoS policy adds either minimum bandwidth or packet rate rule or"},{"line_number":613,"context_line":"       both compared to the old policy."},{"line_number":614,"context_line":"     - Not supported. Rejected as the newly added rule(s) would require a full"},{"line_number":615,"context_line":"       scheduling."},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"Upgrade"},{"line_number":618,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"20725569_dccbb1e9","line":615,"range":{"start_line":612,"start_character":0,"end_line":615,"end_character":18},"in_reply_to":"d7be9051_1794a5c8","updated":"2021-10-19 09:10:31.000000000","message":"No resource request at all, nor for min bw nor for min pps, and that way we will have the same behaviour.","commit_id":"4c2a2ff64c46dd50a73df5dec20d3563144ea8de"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3ceea613ab1d689057f50c3a089525cd387667ca","unresolved":true,"context_lines":[{"line_number":571,"context_line":"     - Accepted but the resource allocation is not adjusted as that would"},{"line_number":572,"context_line":"       require a full scheduling. If the VM later scheduled to another host"},{"line_number":573,"context_line":"       (i.e. migrated, resize, evacuated) then that scheduling will consider"},{"line_number":574,"context_line":"       the new resource request."},{"line_number":575,"context_line":"   * - Update the port.qos_policy_id from a QoS policy without minimum"},{"line_number":576,"context_line":"       bandwidth rule to a QoS policy with minimum bandwidth rule"},{"line_number":577,"context_line":"     - Accepted but the resource allocation is not adjusted. See above."}],"source_content_type":"text/x-rst","patch_set":4,"id":"91d378ce_c187e5d5","line":574,"updated":"2021-11-22 19:59:16.000000000","message":"so it\u0027s kind of \"lazy\" allocation 😊","commit_id":"8f136023f52887e67c0a0d43e2a309c9c41f3c56"}]}