)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"6457be961b52383bdd84504e9622c82ff59f82e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99545e80_d24c8cc6","updated":"2023-11-15 13:34:07.000000000","message":"Sorry for reviewing quite late.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"239940d0cb841ee1414c1dd96b3533b41a8a721a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fcd6971c_29d4c59d","updated":"2023-11-06 13:21:17.000000000","message":"The spec looks ok, thanks for proposing it","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9bc73cde9d6e9c774c25f10aca247e37365a9719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61296c47_96738fcf","updated":"2023-11-03 14:43:05.000000000","message":"There was some resistance to Neutron agents allowing incoming connections earlier because of security concerns. With a pure opt-in approach this may be acceptable, though.\n\nI also want to note that this is completely untested within os-ken currently as well, so maybe adding some better coverage there would also be needed, like verifying that connection conflict resolution does work properly.\n\nAnd as a last remark, I won\u0027t have time to do proper reviews for any of this, so people approving this spec should also commit to reviewing and maintaining this feature.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f49ef98_bab025da","updated":"2023-11-10 15:11:21.000000000","message":"mostly nits","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"239940d0cb841ee1414c1dd96b3533b41a8a721a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"27e2912f_340f1281","in_reply_to":"61296c47_96738fcf","updated":"2023-11-06 13:21:17.000000000","message":"with strong documentation and as optional I also see this can be accepted","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3847f02cd58478a902850fb1b539e75746a0e83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ef242a9_034442cd","updated":"2024-05-06 17:47:30.000000000","message":"I\u0027m fine with this just one nit","commit_id":"ab38b230443deaa524cce5870f126fb70c068f00"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f6459c34e14bcc17a7aa401e5c92fd888ed8dd3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a08b3a62_427f4971","updated":"2024-05-08 14:12:25.000000000","message":"looks good for me. Small issues pointed by Brian and me can be IMO even addressed in the follow up patch.","commit_id":"ab38b230443deaa524cce5870f126fb70c068f00"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"906cee515e1b564771d618b4a9b5d778664b4eae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b1749f99_1518fb61","updated":"2024-05-09 08:32:48.000000000","message":"looks ok, I can live with n-d-r but a section where the full name is written like: Neutron-Dynamic-Routing (n-d-r), let\u0027s wait if there\u0027s other comments","commit_id":"ab38b230443deaa524cce5870f126fb70c068f00"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4ef600567ec107a38a952c57cf81a519829407af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ce3ff36_5a0aeca2","updated":"2024-05-29 08:50:29.000000000","message":"Thanks for working on this item","commit_id":"289028c8e1feb7a24692762612ba2e489248aa82"}],"specs/2024.1/l3bgp-peer-connect-mode.rst":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"6457be961b52383bdd84504e9622c82ff59f82e7","unresolved":true,"context_lines":[{"line_number":42,"context_line":"That is definitely a switch-side issue but when having this situation, we could"},{"line_number":43,"context_line":"allow the Operator to change the default behaviour of n-d-r speaker\u0027s from"},{"line_number":44,"context_line":"ACTIVE and set it as PASSIVE or BOTH using a n-d-r configuration option and"},{"line_number":45,"context_line":"then open the local TCP socket on the TCP 179 port in order to anwser incoming"},{"line_number":46,"context_line":"TCP connections."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d33104e2_d3ceb1cf","line":46,"range":{"start_line":45,"start_character":5,"end_line":46,"end_character":15},"updated":"2023-11-15 13:34:07.000000000","message":"Is it available to a user which IP address a particular bgp speaker listens on? Is it available in the API or is it a well known rule documented somewhere? If none, I think we should cover that in this spec.\n\nAFAIU in the error situation detailed above the remote peer knows our address already. But in general if we allow our speaker to be in PASSIVE mode then our address should be discoverable without us initiating the connection first.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"3d86ad2e87db87ea1366129b09977fa76524a144","unresolved":false,"context_lines":[{"line_number":42,"context_line":"That is definitely a switch-side issue but when having this situation, we could"},{"line_number":43,"context_line":"allow the Operator to change the default behaviour of n-d-r speaker\u0027s from"},{"line_number":44,"context_line":"ACTIVE and set it as PASSIVE or BOTH using a n-d-r configuration option and"},{"line_number":45,"context_line":"then open the local TCP socket on the TCP 179 port in order to anwser incoming"},{"line_number":46,"context_line":"TCP connections."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"be85737d_f2127f91","line":46,"range":{"start_line":45,"start_character":5,"end_line":46,"end_character":15},"in_reply_to":"4ceb4bb4_dd33064e","updated":"2023-11-20 12:19:33.000000000","message":"+1","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"53051f1c99fd7d34f504506b0f483b0882210b46","unresolved":true,"context_lines":[{"line_number":42,"context_line":"That is definitely a switch-side issue but when having this situation, we could"},{"line_number":43,"context_line":"allow the Operator to change the default behaviour of n-d-r speaker\u0027s from"},{"line_number":44,"context_line":"ACTIVE and set it as PASSIVE or BOTH using a n-d-r configuration option and"},{"line_number":45,"context_line":"then open the local TCP socket on the TCP 179 port in order to anwser incoming"},{"line_number":46,"context_line":"TCP connections."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4ceb4bb4_dd33064e","line":46,"range":{"start_line":45,"start_character":5,"end_line":46,"end_character":15},"in_reply_to":"779ad168_61306e7b","updated":"2023-11-20 07:04:00.000000000","message":"This feature has been requested earlier and I think it is a valid topic, although it can be difficult to solve, in particular when there are additional networking layers involved, like the agent running in a container.\n\nThis is also somewhat related to a different common feature request asking for a possibility to query the status of a BGP session, both to verify operation and to aid in debugging.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"b10c3c6fa909134fffc5e648455c49be8993efe8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"That is definitely a switch-side issue but when having this situation, we could"},{"line_number":43,"context_line":"allow the Operator to change the default behaviour of n-d-r speaker\u0027s from"},{"line_number":44,"context_line":"ACTIVE and set it as PASSIVE or BOTH using a n-d-r configuration option and"},{"line_number":45,"context_line":"then open the local TCP socket on the TCP 179 port in order to anwser incoming"},{"line_number":46,"context_line":"TCP connections."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"779ad168_61306e7b","line":46,"range":{"start_line":45,"start_character":5,"end_line":46,"end_character":15},"in_reply_to":"d33104e2_d3ceb1cf","updated":"2023-11-16 11:44:36.000000000","message":"Thanks for your review Bence.\n\nThe BGP speaker driver supports a list of IP addresses `bgp_server_host` to listen on a specific TCP port `bgp_server_port` [1]. The neutron dynamic routing agent uses the default values for these two driver config options, e.g: \u00270.0.0.0\u0027 to listen all IPv4 local addresses, and \u0027::\u0027 to listen all IPv6 local addresses.\n\nIt\u0027s not required to configure a specific IP address used in DRAgent because this information is already configured on the switch side. I mean, the operator needs to configure the neighbor\u0027s IP address in the switch router\u0027s BGP session, like Quagga configuration sample [2]: neighbor \u003cdr_agent IP address\u003e remote-as \u003cBgpSpeaker local_as\u003e\n\nIn this context, the BGP peer address will always be known by the switch because the BGP communication protocol supported by DRAgent is IPv4 unicast and IPv6 unicast (any BGP multicast protocol isn\u0027t implemented in DRAgent).\n\n\n[1] https://docs.openstack.org/os-ken/latest/library_bgp_speaker_ref.html\n[2] https://docs.openstack.org/neutron-dynamic-routing/latest/admin/bgp-speaker.html","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":49,"context_line":"Proposed change"},{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"This proposal implement a configuration option to allow the Operator to change"},{"line_number":53,"context_line":"the n-d-r speaker\u0027s default BGP connect mode from ACTIVE to PASSIVE or BOTH."},{"line_number":54,"context_line":"For Operators who do not have the problem described above, it is not necessary"},{"line_number":55,"context_line":"to change anything as the BGP connection mode will remain as ACTIVE."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b8b8c085_ecd7eb6f","line":52,"range":{"start_line":52,"start_character":14,"end_line":52,"end_character":23},"updated":"2023-11-10 15:11:21.000000000","message":"s/implements","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Proposed change"},{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"This proposal implement a configuration option to allow the Operator to change"},{"line_number":53,"context_line":"the n-d-r speaker\u0027s default BGP connect mode from ACTIVE to PASSIVE or BOTH."},{"line_number":54,"context_line":"For Operators who do not have the problem described above, it is not necessary"},{"line_number":55,"context_line":"to change anything as the BGP connection mode will remain as ACTIVE."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f41fd976_2301c363","line":52,"range":{"start_line":52,"start_character":14,"end_line":52,"end_character":23},"in_reply_to":"b8b8c085_ecd7eb6f","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To change the n-d-r speaker\u0027s default BGP connect mode, a new configuration"},{"line_number":58,"context_line":"option should be enabled via [BGP] section in the n-d-r agent configuration"},{"line_number":59,"context_line":"file to active, passive or both."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code::"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dccf7056_c159fccd","line":59,"range":{"start_line":59,"start_character":5,"end_line":59,"end_character":31},"updated":"2023-11-10 15:11:21.000000000","message":"not sure the values are necessary here","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To change the n-d-r speaker\u0027s default BGP connect mode, a new configuration"},{"line_number":58,"context_line":"option should be enabled via [BGP] section in the n-d-r agent configuration"},{"line_number":59,"context_line":"file to active, passive or both."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code::"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"eaaa8e7b_eb945f42","line":59,"range":{"start_line":59,"start_character":5,"end_line":59,"end_character":31},"in_reply_to":"dccf7056_c159fccd","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"6457be961b52383bdd84504e9622c82ff59f82e7","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  * ``bgp_connect_mode \u003d both``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The `bgp_connect_mode` values supported would be:"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"018d5b40_6fce74a0","line":63,"updated":"2023-11-15 13:34:07.000000000","message":"In the sense of my my previous comment, I believe if we change our public behavior (whether our speaker listens or not), then this information should be available in the API, and not hidden in a config file. Probably as an attribute of the bgp speaker API object. Otherwise we create a config driven interface.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"b10c3c6fa909134fffc5e648455c49be8993efe8","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  * ``bgp_connect_mode \u003d both``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The `bgp_connect_mode` values supported would be:"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8f9ef795_4cb1aa67","line":63,"in_reply_to":"018d5b40_6fce74a0","updated":"2023-11-16 11:44:36.000000000","message":"I\u0027m not sure, this setting is specific to the BGP driver used by DRAgent (currently os-ken) and not to DRAgent itself. I mean, if os-ken removes support for this option or is replaced by another implementation, this could cause a cascading effect to adjust API\u0027s, neutron-lib, etc.\nIf it is a requirement to extend the BGP speaker API, that\u0027s fine, I just can\u0027t see the real benefit of making this option available via API for Neutron.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  * ``bgp_connect_mode \u003d both``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The `bgp_connect_mode` values supported would be:"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1d609748_59b8c1c7","line":63,"in_reply_to":"31c70f86_b7debd31","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"3d86ad2e87db87ea1366129b09977fa76524a144","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  * ``bgp_connect_mode \u003d both``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The `bgp_connect_mode` values supported would be:"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"31c70f86_b7debd31","line":63,"in_reply_to":"721d9140_e8cef325","updated":"2023-11-20 12:19:33.000000000","message":"yeah, it makes sense. My previous point about the operator config is related to exposes \u0027via API\u0027 the local address to listen on BGP port. Talking about the \u0027bgp_connect_mode\u0027 parameter, IMO it could be per DRAgent, as the BGP library will listen to all peers configured on the same DRAgent.\n\nIf it\u0027s per speaker, we can consider that each speaker can be associated with multiple DRAgents (HA), and this could create a potential configuration conflict as all peers of the same DRAgent would have the same config. However, different DRAgents could have a different requirement for the connection mode (as they would be connected to different pairs of switches). \n\nIn summary, it makes sense to me to configure the \u0027bgp_connect_mode\u0027 by DRAgent but I don\u0027t see how to include DRAgent specific configs in the API, I would be happy if someone could help me understand it better to implement it this way.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"53051f1c99fd7d34f504506b0f483b0882210b46","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  * ``bgp_connect_mode \u003d both``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The `bgp_connect_mode` values supported would be:"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"721d9140_e8cef325","line":63,"in_reply_to":"77998aa4_a837ca6f","updated":"2023-11-20 07:04:00.000000000","message":"I think this is still a valid point, it may make sense to set this option per BGP speaker or even per peer?\n\nIf you argue that operator interaction is needed anyway, then you could say that all of the n-d-r API is not needed and should be replaced by static configuration.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"63c59e8bfaec2217592ea0e2b6cac1753fbe262e","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. code::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  * ``bgp_connect_mode \u003d both``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The `bgp_connect_mode` values supported would be:"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"77998aa4_a837ca6f","line":63,"in_reply_to":"8f9ef795_4cb1aa67","updated":"2023-11-17 09:41:22.000000000","message":"Thanks for the reply. It sounds like I was not aware of how an environment using this is usually set up. If an operator to operator interaction was already always needed in the setup then I suppose my comments are moot.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The `bgp_connect_mode` values supported would be:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* `active` initiate the TCP connection to establish the BGP session and does"},{"line_number":68,"context_line":"  not require to open a local TCP socket on port 179. The default value for"},{"line_number":69,"context_line":"  `bgp_connect_mode` must be `active` to keep the current behaviour."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* `passive` open a local TCP socket on port 179 and wait for incoming TCP"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d25575a0_9cbb919b","line":68,"range":{"start_line":67,"start_character":72,"end_line":68,"end_character":21},"updated":"2023-11-10 15:11:21.000000000","message":"s/do not require","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The `bgp_connect_mode` values supported would be:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* `active` initiate the TCP connection to establish the BGP session and does"},{"line_number":68,"context_line":"  not require to open a local TCP socket on port 179. The default value for"},{"line_number":69,"context_line":"  `bgp_connect_mode` must be `active` to keep the current behaviour."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* `passive` open a local TCP socket on port 179 and wait for incoming TCP"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f294fd1_b8505d2b","line":68,"range":{"start_line":67,"start_character":72,"end_line":68,"end_character":21},"in_reply_to":"d25575a0_9cbb919b","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":68,"context_line":"  not require to open a local TCP socket on port 179. The default value for"},{"line_number":69,"context_line":"  `bgp_connect_mode` must be `active` to keep the current behaviour."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* `passive` open a local TCP socket on port 179 and wait for incoming TCP"},{"line_number":72,"context_line":"  connection from the BGP peer."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* `both` open a local TCP socket on port 179 and could initiate the TCP"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d0322893_1419fc8a","line":71,"range":{"start_line":71,"start_character":57,"end_line":71,"end_character":73},"updated":"2023-11-10 15:11:21.000000000","message":"s/for an incoming TCP","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  not require to open a local TCP socket on port 179. The default value for"},{"line_number":69,"context_line":"  `bgp_connect_mode` must be `active` to keep the current behaviour."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* `passive` open a local TCP socket on port 179 and wait for incoming TCP"},{"line_number":72,"context_line":"  connection from the BGP peer."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* `both` open a local TCP socket on port 179 and could initiate the TCP"}],"source_content_type":"text/x-rst","patch_set":1,"id":"97b8ef08_34600fe9","line":71,"range":{"start_line":71,"start_character":57,"end_line":71,"end_character":73},"in_reply_to":"d0322893_1419fc8a","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* `both` open a local TCP socket on port 179 and could initiate the TCP"},{"line_number":75,"context_line":"  connection to establish the BGP session or can wait for incoming TCP"},{"line_number":76,"context_line":"  connection from the BGP peer."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"n-d-r Impact"},{"line_number":79,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e5433669_adb4253d","line":76,"updated":"2023-11-10 15:11:21.000000000","message":"This paragraph is a little confusing, can you re-write a bit? Maybe something like this, but I might have the terminology wrong:\n\n`both` open a local TCP socket on port 179 and wait for an incoming TCP\n connection from the BGP peer. Additionally, a connection could be initiated to establish the BGP session with the peer.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* `both` open a local TCP socket on port 179 and could initiate the TCP"},{"line_number":75,"context_line":"  connection to establish the BGP session or can wait for incoming TCP"},{"line_number":76,"context_line":"  connection from the BGP peer."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"n-d-r Impact"},{"line_number":79,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8e23964f_741c01cc","line":76,"in_reply_to":"e5433669_adb4253d","updated":"2023-11-24 19:35:59.000000000","message":"looks better, thanks!","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"When the n-d-r agent is started:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* if the option `bgp_connect_mode` is ommited or has the value active the BGP"},{"line_number":84,"context_line":"  connection mode will remains as ACTIVE and it will not create a local TCP"},{"line_number":85,"context_line":"  socket on port 179."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0d63f9_385d27fe","line":83,"range":{"start_line":83,"start_character":63,"end_line":83,"end_character":69},"updated":"2023-11-10 15:11:21.000000000","message":"s/``active``","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"When the n-d-r agent is started:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* if the option `bgp_connect_mode` is ommited or has the value active the BGP"},{"line_number":84,"context_line":"  connection mode will remains as ACTIVE and it will not create a local TCP"},{"line_number":85,"context_line":"  socket on port 179."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a4a94d65_2be753b7","line":83,"range":{"start_line":83,"start_character":63,"end_line":83,"end_character":69},"in_reply_to":"ff0d63f9_385d27fe","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":81,"context_line":"When the n-d-r agent is started:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* if the option `bgp_connect_mode` is ommited or has the value active the BGP"},{"line_number":84,"context_line":"  connection mode will remains as ACTIVE and it will not create a local TCP"},{"line_number":85,"context_line":"  socket on port 179."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* if the option `bgp_connect_mode` has the value passive the BGP connection"}],"source_content_type":"text/x-rst","patch_set":1,"id":"aca81e0c_3db2ba8e","line":84,"range":{"start_line":84,"start_character":23,"end_line":84,"end_character":30},"updated":"2023-11-10 15:11:21.000000000","message":"s/remain","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":81,"context_line":"When the n-d-r agent is started:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* if the option `bgp_connect_mode` is ommited or has the value active the BGP"},{"line_number":84,"context_line":"  connection mode will remains as ACTIVE and it will not create a local TCP"},{"line_number":85,"context_line":"  socket on port 179."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* if the option `bgp_connect_mode` has the value passive the BGP connection"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3dca187a_71d94a9e","line":84,"range":{"start_line":84,"start_character":23,"end_line":84,"end_character":30},"in_reply_to":"aca81e0c_3db2ba8e","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":84,"context_line":"  connection mode will remains as ACTIVE and it will not create a local TCP"},{"line_number":85,"context_line":"  socket on port 179."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* if the option `bgp_connect_mode` has the value passive the BGP connection"},{"line_number":88,"context_line":"  mode will be used as PASSIVE and a local TCP socket on port 179 will be"},{"line_number":89,"context_line":"  opened."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a23fc127_2f0af77a","line":87,"range":{"start_line":87,"start_character":49,"end_line":87,"end_character":56},"updated":"2023-11-10 15:11:21.000000000","message":"s/``passive``","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  connection mode will remains as ACTIVE and it will not create a local TCP"},{"line_number":85,"context_line":"  socket on port 179."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* if the option `bgp_connect_mode` has the value passive the BGP connection"},{"line_number":88,"context_line":"  mode will be used as PASSIVE and a local TCP socket on port 179 will be"},{"line_number":89,"context_line":"  opened."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"168f1246_18e7d12d","line":87,"range":{"start_line":87,"start_character":49,"end_line":87,"end_character":56},"in_reply_to":"a23fc127_2f0af77a","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":88,"context_line":"  mode will be used as PASSIVE and a local TCP socket on port 179 will be"},{"line_number":89,"context_line":"  opened."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* if the option `bgp_connect_mode` has the value both the BGP connection mode"},{"line_number":92,"context_line":"  will be used as BOTH and a local TCP socket on port 179 will be opened."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Because n-d-r could starts the agent with an unprivileged user, the systemd"}],"source_content_type":"text/x-rst","patch_set":1,"id":"95d513d5_4174fef8","line":91,"range":{"start_line":91,"start_character":49,"end_line":91,"end_character":53},"updated":"2023-11-10 15:11:21.000000000","message":"s/``both``","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  mode will be used as PASSIVE and a local TCP socket on port 179 will be"},{"line_number":89,"context_line":"  opened."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* if the option `bgp_connect_mode` has the value both the BGP connection mode"},{"line_number":92,"context_line":"  will be used as BOTH and a local TCP socket on port 179 will be opened."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Because n-d-r could starts the agent with an unprivileged user, the systemd"}],"source_content_type":"text/x-rst","patch_set":1,"id":"06cb4a08_4dba5b78","line":91,"range":{"start_line":91,"start_character":49,"end_line":91,"end_character":53},"in_reply_to":"95d513d5_4174fef8","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Because n-d-r could starts the agent with an unprivileged user, the systemd"},{"line_number":95,"context_line":"will require for the n-d-r agent service to have net bind capability to allow"},{"line_number":96,"context_line":"to creation of the local TCP socket on port 179."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Security Impact"},{"line_number":99,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"64737d76_adbe8c3d","line":96,"updated":"2023-11-10 15:11:21.000000000","message":"There are a couple of grammatical issues here, is this better?\n\nBecause n-d-r could start the agent as an unprivileged user, systemd\nwill require for the n-d-r agent service to have net bind capability to allow\nfor creation of the local TCP socket on port 179.","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Because n-d-r could starts the agent with an unprivileged user, the systemd"},{"line_number":95,"context_line":"will require for the n-d-r agent service to have net bind capability to allow"},{"line_number":96,"context_line":"to creation of the local TCP socket on port 179."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Security Impact"},{"line_number":99,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ed696c3d_7b6ee0b8","line":96,"in_reply_to":"64737d76_adbe8c3d","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59ca8095beeaf2683174d935b37721c1506254b8","unresolved":true,"context_lines":[{"line_number":99,"context_line":"---------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The Operator will have to ensure the safety of the n-d-r agent when using"},{"line_number":102,"context_line":"`bgp_connect_mode` as passive or both, and create local firewall rules to only"},{"line_number":103,"context_line":"allow incoming TCP connection from BGP peers."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6d7478b7_dbc5cd2e","line":102,"range":{"start_line":102,"start_character":22,"end_line":102,"end_character":37},"updated":"2023-11-10 15:11:21.000000000","message":"put these in ``","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"91fbe7760b5e6301f26150c8c715242f2e180e79","unresolved":false,"context_lines":[{"line_number":99,"context_line":"---------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The Operator will have to ensure the safety of the n-d-r agent when using"},{"line_number":102,"context_line":"`bgp_connect_mode` as passive or both, and create local firewall rules to only"},{"line_number":103,"context_line":"allow incoming TCP connection from BGP peers."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e351e40c_6ed5866f","line":102,"range":{"start_line":102,"start_character":22,"end_line":102,"end_character":37},"in_reply_to":"6d7478b7_dbc5cd2e","updated":"2023-11-24 19:35:59.000000000","message":"Done","commit_id":"33f1231954f739b6105ce35bca96cde10111af0c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5a116df8913e4ed5ffdb2a4f29065174899f4276","unresolved":true,"context_lines":[{"line_number":99,"context_line":"---------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The Operator will have to ensure the safety of the n-d-r agent when using"},{"line_number":102,"context_line":"`bgp_connect_mode` as `passive` or `both`, and create local firewall rules to"},{"line_number":103,"context_line":"only allow incoming TCP connection from BGP peers."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a02be353_35104eea","line":103,"range":{"start_line":102,"start_character":43,"end_line":103,"end_character":50},"updated":"2024-02-13 08:39:39.000000000","message":"+1 to mention it here.\nthis must be mentioned in the doc for this change","commit_id":"add0009b778a6541b11b23cc65640e685ecbad5e"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"65a55ad617fc6e5a816b2d32afc9e8203fcd4505","unresolved":false,"context_lines":[{"line_number":99,"context_line":"---------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The Operator will have to ensure the safety of the n-d-r agent when using"},{"line_number":102,"context_line":"`bgp_connect_mode` as `passive` or `both`, and create local firewall rules to"},{"line_number":103,"context_line":"only allow incoming TCP connection from BGP peers."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7fe84c70_cca17cdb","line":103,"range":{"start_line":102,"start_character":43,"end_line":103,"end_character":50},"in_reply_to":"a02be353_35104eea","updated":"2024-02-20 21:30:36.000000000","message":"I will do, thanks.","commit_id":"add0009b778a6541b11b23cc65640e685ecbad5e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5a116df8913e4ed5ffdb2a4f29065174899f4276","unresolved":true,"context_lines":[{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Unit/functional tests."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Documentation Impact"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8b57ab_e26e217f","line":131,"updated":"2024-02-13 08:39:39.000000000","message":"I am thinking if it can be tested in tempest at least for the default (bgp_connect_mode\u003dactive).","commit_id":"add0009b778a6541b11b23cc65640e685ecbad5e"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"65a55ad617fc6e5a816b2d32afc9e8203fcd4505","unresolved":true,"context_lines":[{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Unit/functional tests."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Documentation Impact"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"30886a7d_216bdf85","line":131,"in_reply_to":"7a8b57ab_e26e217f","updated":"2024-02-20 21:30:36.000000000","message":"Are you talking about including tests using the bgp_connect_mode in this repository?\nhttps://opendev.org/openstack/neutron-tempest-plugin/src/branch/master/neutron_tempest_plugin/neutron_dynamic_routing/scenario\n\nI believe it\u0027s a good idea! I have to understand how the tempest testing engine works because I haven\u0027t used these tests yet. I will look into including these tempest checks in the two BGP RFEs that I opened (at least the basics with integrated tests).","commit_id":"add0009b778a6541b11b23cc65640e685ecbad5e"}],"specs/2024.2/l3bgp-peer-connect-mode.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3847f02cd58478a902850fb1b539e75746a0e83","unresolved":true,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When using n-d-r, the speaker\u0027s current behaviour is to work in ACTIVE mode"},{"line_number":22,"context_line":"which will not create a local TCP socket on TCP 179 port. Therefore, in the"},{"line_number":23,"context_line":"switch\u0027s BGP session, it needs to be configured as PASSIVE and not initiate"},{"line_number":24,"context_line":"TCP connections."}],"source_content_type":"text/x-rst","patch_set":3,"id":"467b2f1d_ebbe3b80","line":21,"range":{"start_line":21,"start_character":11,"end_line":21,"end_character":16},"updated":"2024-05-06 17:47:30.000000000","message":"The only thing I would change here is to define what n-d-r is the first time you use it, since someone reading this might not know. So here just change this to \u0027Neutron Dynamic Routing (n-d-r)\u0027\n\nIt does eventually say it on L122.","commit_id":"ab38b230443deaa524cce5870f126fb70c068f00"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"252b8fe17f9ef1e1cb52500c75ded73b8c6bd4bb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When using n-d-r, the speaker\u0027s current behaviour is to work in ACTIVE mode"},{"line_number":22,"context_line":"which will not create a local TCP socket on TCP 179 port. Therefore, in the"},{"line_number":23,"context_line":"switch\u0027s BGP session, it needs to be configured as PASSIVE and not initiate"},{"line_number":24,"context_line":"TCP connections."}],"source_content_type":"text/x-rst","patch_set":3,"id":"57ab9abf_28cbf87f","line":21,"range":{"start_line":21,"start_character":11,"end_line":21,"end_character":16},"in_reply_to":"467b2f1d_ebbe3b80","updated":"2024-05-27 12:22:08.000000000","message":"Done","commit_id":"ab38b230443deaa524cce5870f126fb70c068f00"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f6459c34e14bcc17a7aa401e5c92fd888ed8dd3c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  connection from the BGP peer. Additionally, a connection could be initiated"},{"line_number":76,"context_line":"  to establish the BGP session with the peer."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"n-d-r Impact"},{"line_number":79,"context_line":"------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"When the n-d-r agent is started:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4b591b8b_31dcf0b0","line":78,"updated":"2024-05-08 14:12:25.000000000","message":"I agree with Brian\u0027s comment above but also I think that in the title of the section You could use full name also.","commit_id":"ab38b230443deaa524cce5870f126fb70c068f00"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"252b8fe17f9ef1e1cb52500c75ded73b8c6bd4bb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  connection from the BGP peer. Additionally, a connection could be initiated"},{"line_number":76,"context_line":"  to establish the BGP session with the peer."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"n-d-r Impact"},{"line_number":79,"context_line":"------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"When the n-d-r agent is started:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"96a67183_5ca407f5","line":78,"in_reply_to":"418278d2_966b0211","updated":"2024-05-27 12:22:08.000000000","message":"Done","commit_id":"ab38b230443deaa524cce5870f126fb70c068f00"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"906cee515e1b564771d618b4a9b5d778664b4eae","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  connection from the BGP peer. Additionally, a connection could be initiated"},{"line_number":76,"context_line":"  to establish the BGP session with the peer."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"n-d-r Impact"},{"line_number":79,"context_line":"------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"When the n-d-r agent is started:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"418278d2_966b0211","line":78,"in_reply_to":"4b591b8b_31dcf0b0","updated":"2024-05-09 08:32:48.000000000","message":"+1","commit_id":"ab38b230443deaa524cce5870f126fb70c068f00"}]}