)]}'
{"specs/juno/ml2-qos-linuxbridge.rst":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"aef9225d77885feb5a480ba971e39ec20c1b2a67","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"QoS API and its implementation for ML2 openvswitch mechanism driver is"},{"line_number":18,"context_line":"under development."},{"line_number":19,"context_line":"This blueprint proposes QoS for ML2 linuxbridge mechanism driver. "},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The main intention is to control outbound traffic from a router to an"},{"line_number":22,"context_line":"external network. i.e. It is wanted to set QoS to a port of an external"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ae8d1ca_7030c39e","line":19,"updated":"2014-05-29 03:35:35.000000000","message":"whitespace","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"aa0323a5ec34b1d855fb1ba71ab2206055577a85","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"QoS API and its implementation for ML2 openvswitch mechanism driver is"},{"line_number":18,"context_line":"under development."},{"line_number":19,"context_line":"This blueprint proposes QoS for ML2 linuxbridge mechanism driver. "},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The main intention is to control outbound traffic from a router to an"},{"line_number":22,"context_line":"external network. i.e. It is wanted to set QoS to a port of an external"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_75d1a356","line":19,"in_reply_to":"3ae8d1ca_7030c39e","updated":"2014-06-02 06:11:54.000000000","message":"done.","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"4187cf687511f1bdeb1f16a05abc76f8daf04d92","unresolved":false,"context_lines":[{"line_number":21,"context_line":"The main intention is to control outbound traffic from a router to an"},{"line_number":22,"context_line":"external network. i.e. It is wanted to set QoS to a port of an external"},{"line_number":23,"context_line":"network in a router."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_d6b6338a","line":24,"updated":"2014-05-30 13:19:37.000000000","message":"the implementation you describe could apply to every port, not only the external port of a network. Please generalize your description, otherwise you should explain how to constraint the policy to apply only on the external port of a router","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"aa0323a5ec34b1d855fb1ba71ab2206055577a85","unresolved":false,"context_lines":[{"line_number":21,"context_line":"The main intention is to control outbound traffic from a router to an"},{"line_number":22,"context_line":"external network. i.e. It is wanted to set QoS to a port of an external"},{"line_number":23,"context_line":"network in a router."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_b5424b0e","line":24,"in_reply_to":"1ae5cdf2_d6b6338a","updated":"2014-06-02 06:11:54.000000000","message":"\"linuxbridge mechanism driver\" in the \"Proposed change\" added.\n\nAn alternative is added too.","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"change_message_id":"18c6af597273f78f2f8b0ab61e86ad66487d3a8a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"QoS using linux tc(8) command is supported to linuxbridge ports."},{"line_number":30,"context_line":"\u0027ratelimit\u0027 type and policy attributes for the type are supported to"},{"line_number":31,"context_line":"QoS API."},{"line_number":32,"context_line":"neutron-linuxbridge-agent handles QoS setting for ports."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* QoS API"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_ac879860","line":31,"updated":"2014-05-30 13:44:58.000000000","message":"Are these two sentences necessary? Don\u0027t seem relevant to your \"proposed change\".","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"aa0323a5ec34b1d855fb1ba71ab2206055577a85","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"QoS using linux tc(8) command is supported to linuxbridge ports."},{"line_number":30,"context_line":"\u0027ratelimit\u0027 type and policy attributes for the type are supported to"},{"line_number":31,"context_line":"QoS API."},{"line_number":32,"context_line":"neutron-linuxbridge-agent handles QoS setting for ports."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* QoS API"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_755fe3e5","line":31,"in_reply_to":"1ae5cdf2_ac879860","updated":"2014-06-02 06:11:54.000000000","message":"A part of these sentences is moved to \"neutron-linuxbridge-agent\". Does it make sense ?","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"aef9225d77885feb5a480ba971e39ec20c1b2a67","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  DB model change is not necessary."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* ML2 plugin"},{"line_number":39,"context_line":"  Need to include QoS parameters in the response of \u0027get_device_detail\u0027"},{"line_number":40,"context_line":"  RPC call so that neutron-linuxbridge-agent can handle QoS."},{"line_number":41,"context_line":"  QoS RPC call change is not necessary."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ae8d1ca_101bff1b","line":39,"range":{"start_line":39,"start_character":53,"end_line":39,"end_character":70},"updated":"2014-05-29 03:35:35.000000000","message":"get_device_details","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"aa0323a5ec34b1d855fb1ba71ab2206055577a85","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  DB model change is not necessary."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* ML2 plugin"},{"line_number":39,"context_line":"  Need to include QoS parameters in the response of \u0027get_device_detail\u0027"},{"line_number":40,"context_line":"  RPC call so that neutron-linuxbridge-agent can handle QoS."},{"line_number":41,"context_line":"  QoS RPC call change is not necessary."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_9562afab","line":39,"in_reply_to":"3ae8d1ca_101bff1b","updated":"2014-06-02 06:11:54.000000000","message":"done.","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"aef9225d77885feb5a480ba971e39ec20c1b2a67","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  \u0027qos\u0027: {\u0027type\u0027: \u0027ratelimit\u0027,"},{"line_number":75,"context_line":"          \u0027policy\u0027: {\u0027tc_rate\u0027: \u0027100mbit\u0027,"},{"line_number":76,"context_line":"                     \u0027tc_latency\u0027: \u002750ms\u0027,"},{"line_number":77,"context_line":"                     \u0027tc_burst\u0027: \u00273000k\u0027}}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ae8d1ca_30ed5bf0","line":77,"updated":"2014-05-29 03:35:35.000000000","message":"it doesn\u0027t seem a good idea to expose the underlying mechanism (tc) here.","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"aa0323a5ec34b1d855fb1ba71ab2206055577a85","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  \u0027qos\u0027: {\u0027type\u0027: \u0027ratelimit\u0027,"},{"line_number":75,"context_line":"          \u0027policy\u0027: {\u0027tc_rate\u0027: \u0027100mbit\u0027,"},{"line_number":76,"context_line":"                     \u0027tc_latency\u0027: \u002750ms\u0027,"},{"line_number":77,"context_line":"                     \u0027tc_burst\u0027: \u00273000k\u0027}}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_35f2bbd2","line":77,"in_reply_to":"1ae5cdf2_f95fa070","updated":"2014-06-02 06:11:54.000000000","message":"These parameters are very complicated. I think it is better to state clearly the parameters are for tc command for users.\n\nI am waiting for the opinion of other people.","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"change_message_id":"18c6af597273f78f2f8b0ab61e86ad66487d3a8a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  \u0027qos\u0027: {\u0027type\u0027: \u0027ratelimit\u0027,"},{"line_number":75,"context_line":"          \u0027policy\u0027: {\u0027tc_rate\u0027: \u0027100mbit\u0027,"},{"line_number":76,"context_line":"                     \u0027tc_latency\u0027: \u002750ms\u0027,"},{"line_number":77,"context_line":"                     \u0027tc_burst\u0027: \u00273000k\u0027}}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_f95fa070","line":77,"in_reply_to":"3ae8d1ca_30ed5bf0","updated":"2014-05-30 13:44:58.000000000","message":"+1","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"4187cf687511f1bdeb1f16a05abc76f8daf04d92","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          \u0027policy\u0027: {\u0027tc_rate\u0027: \u0027100mbit\u0027,"},{"line_number":76,"context_line":"                     \u0027tc_latency\u0027: \u002750ms\u0027,"},{"line_number":77,"context_line":"                     \u0027tc_burst\u0027: \u00273000k\u0027}}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Security impact"},{"line_number":81,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_1968ccb9","line":78,"updated":"2014-05-30 13:19:37.000000000","message":"adding policy and burst directly in the qos policy extension is not possible?","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"aa0323a5ec34b1d855fb1ba71ab2206055577a85","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          \u0027policy\u0027: {\u0027tc_rate\u0027: \u0027100mbit\u0027,"},{"line_number":76,"context_line":"                     \u0027tc_latency\u0027: \u002750ms\u0027,"},{"line_number":77,"context_line":"                     \u0027tc_burst\u0027: \u00273000k\u0027}}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Security impact"},{"line_number":81,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_75bb63e5","line":78,"in_reply_to":"1ae5cdf2_1968ccb9","updated":"2014-06-02 06:11:54.000000000","message":"Sorry. I don\u0027t understand what you mean.","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"eeaef5b005cbc7a8591f2db1c610710811aac0c4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"          \u0027policy\u0027: {\u0027tc_rate\u0027: \u0027100mbit\u0027,"},{"line_number":76,"context_line":"                     \u0027tc_latency\u0027: \u002750ms\u0027,"},{"line_number":77,"context_line":"                     \u0027tc_burst\u0027: \u00273000k\u0027}}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Security impact"},{"line_number":81,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_b00979df","line":78,"in_reply_to":"1ae5cdf2_75bb63e5","updated":"2014-06-02 06:53:01.000000000","message":"I think I understand what you mean. See patch set 4 (or later).","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"change_message_id":"18c6af597273f78f2f8b0ab61e86ad66487d3a8a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"References"},{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* https://review.openstack.org/#/c/88599"},{"line_number":149,"context_line":"  Neutron QoS API Extension"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_0caface4","line":148,"updated":"2014-05-30 13:44:58.000000000","message":"There\u0027s no place that refer to this review in this spec . Could you add citation or remove this?","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"aa0323a5ec34b1d855fb1ba71ab2206055577a85","unresolved":false,"context_lines":[{"line_number":145,"context_line":"References"},{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* https://review.openstack.org/#/c/88599"},{"line_number":149,"context_line":"  Neutron QoS API Extension"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_b5ac0ba2","line":148,"in_reply_to":"1ae5cdf2_0caface4","updated":"2014-06-02 06:11:54.000000000","message":"Add notes to the beginning.","commit_id":"d597a1f018990e99f8e96337a880414d0bee261d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fea47a3dbb47e993310b145a9521353dc1f02ef4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"QoS API and its implementation for ML2 openvswitch mechanism driver is"},{"line_number":24,"context_line":"under development."},{"line_number":25,"context_line":"This blueprint proposes QoS for ML2 linuxbridge mechanism driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The main intention is to control outbound traffic from a router to an"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b527ab63","line":24,"updated":"2014-06-02 06:09:09.000000000","message":"can you provide a link?","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4dc8490b5cf29b6c670eed81846889f118e55536","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"QoS API and its implementation for ML2 openvswitch mechanism driver is"},{"line_number":24,"context_line":"under development."},{"line_number":25,"context_line":"This blueprint proposes QoS for ML2 linuxbridge mechanism driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The main intention is to control outbound traffic from a router to an"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_d09a8562","line":24,"in_reply_to":"1ae5cdf2_b527ab63","updated":"2014-06-02 07:00:52.000000000","message":"They were developing in Icehouse precisely.\nhttps://review.openstack.org/#/c/28313\nhttps://review.openstack.org/#/c/59970\nhttps://review.openstack.org/#/c/59971","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fea47a3dbb47e993310b145a9521353dc1f02ef4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"QoS API and its implementation for ML2 openvswitch mechanism driver is"},{"line_number":24,"context_line":"under development."},{"line_number":25,"context_line":"This blueprint proposes QoS for ML2 linuxbridge mechanism driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The main intention is to control outbound traffic from a router to an"},{"line_number":28,"context_line":"external network. i.e. It is wanted to set QoS to a port of an external"},{"line_number":29,"context_line":"network in a router."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_f5e77310","line":26,"updated":"2014-06-02 06:09:09.000000000","message":"why api needs to be developed separately for OVS and LB?","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4dc8490b5cf29b6c670eed81846889f118e55536","unresolved":false,"context_lines":[{"line_number":23,"context_line":"QoS API and its implementation for ML2 openvswitch mechanism driver is"},{"line_number":24,"context_line":"under development."},{"line_number":25,"context_line":"This blueprint proposes QoS for ML2 linuxbridge mechanism driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The main intention is to control outbound traffic from a router to an"},{"line_number":28,"context_line":"external network. i.e. It is wanted to set QoS to a port of an external"},{"line_number":29,"context_line":"network in a router."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_f002216e","line":26,"in_reply_to":"1ae5cdf2_f5e77310","updated":"2014-06-02 07:00:52.000000000","message":"Originally only OVS implementation using DSCP existed. API spec mentioned \u0027ratelimit\u0027 but policy key is not suitable for our requirement.","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fea47a3dbb47e993310b145a9521353dc1f02ef4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"From the veiwpoint of realization of our use case;"},{"line_number":60,"context_line":"Extend QoS API to set to a router (QoS is set to an external network"},{"line_number":61,"context_line":"port in the router) is an alternative. l3_agent handles QoS in this"},{"line_number":62,"context_line":"case."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b5596b00","line":59,"range":{"start_line":59,"start_character":9,"end_line":59,"end_character":18},"updated":"2014-06-02 06:09:09.000000000","message":"viewpoint","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4dc8490b5cf29b6c670eed81846889f118e55536","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"From the veiwpoint of realization of our use case;"},{"line_number":60,"context_line":"Extend QoS API to set to a router (QoS is set to an external network"},{"line_number":61,"context_line":"port in the router) is an alternative. l3_agent handles QoS in this"},{"line_number":62,"context_line":"case."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b030999f","line":59,"in_reply_to":"1ae5cdf2_b5596b00","updated":"2014-06-02 07:00:52.000000000","message":"done.","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fea47a3dbb47e993310b145a9521353dc1f02ef4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"port in the router) is an alternative. l3_agent handles QoS in this"},{"line_number":62,"context_line":"case."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"From the veiwpoint of generalization linuxbrdge QoS;"},{"line_number":65,"context_line":"Support ports other than external network too."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_d55c37f0","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":18},"updated":"2014-06-02 06:09:09.000000000","message":"viewpoint\nlinuxbridge","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4dc8490b5cf29b6c670eed81846889f118e55536","unresolved":false,"context_lines":[{"line_number":61,"context_line":"port in the router) is an alternative. l3_agent handles QoS in this"},{"line_number":62,"context_line":"case."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"From the veiwpoint of generalization linuxbrdge QoS;"},{"line_number":65,"context_line":"Support ports other than external network too."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_10214d4d","line":64,"in_reply_to":"1ae5cdf2_d55c37f0","updated":"2014-06-02 07:00:52.000000000","message":"done.","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fea47a3dbb47e993310b145a9521353dc1f02ef4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  \u0027qos\u0027: {\u0027type\u0027: \u0027ratelimit\u0027,"},{"line_number":85,"context_line":"          \u0027policy\u0027: {\u0027tc_rate\u0027: \u0027100mbit\u0027,"},{"line_number":86,"context_line":"                     \u0027tc_latency\u0027: \u002750ms\u0027,"},{"line_number":87,"context_line":"                     \u0027tc_burst\u0027: \u00273000k\u0027}}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_356d5b99","line":87,"range":{"start_line":87,"start_character":22,"end_line":87,"end_character":30},"updated":"2014-06-02 06:09:09.000000000","message":"please stop exposing the underlying mechanism (tc), or explain why it\u0027s desirable.","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4dc8490b5cf29b6c670eed81846889f118e55536","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  \u0027qos\u0027: {\u0027type\u0027: \u0027ratelimit\u0027,"},{"line_number":85,"context_line":"          \u0027policy\u0027: {\u0027tc_rate\u0027: \u0027100mbit\u0027,"},{"line_number":86,"context_line":"                     \u0027tc_latency\u0027: \u002750ms\u0027,"},{"line_number":87,"context_line":"                     \u0027tc_burst\u0027: \u00273000k\u0027}}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_701611f3","line":87,"in_reply_to":"1ae5cdf2_356d5b99","updated":"2014-06-02 07:00:52.000000000","message":"OK. I changed my mind.","commit_id":"416ab447d9ec17844560e89226a5d236f459bd74"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"1f91f02f8cff3e7ce774f68339e645fbfb022ef8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* ML2 plugin"},{"line_number":41,"context_line":"  Need to include QoS parameters in the response of \u0027get_device_details\u0027"},{"line_number":42,"context_line":"  RPC call so that neutron-linuxbridge-agent can handle QoS."},{"line_number":43,"context_line":"  QoS RPC call change is not necessary."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* linuxbridge mechanism driver"},{"line_number":46,"context_line":"  Add validation check whether a port to be set QoS is an external network"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_85f7dcf4","line":43,"updated":"2014-06-02 09:07:31.000000000","message":"This part is not clear to me on this review : \nhttps://review.openstack.org/88599/\n\nYour BP will have to be consistent with the BP above","commit_id":"0d2c4772e73ee12e2aa9c7a1829e88f2d7100f62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f5d24ac02ed8062ca0fdef054d670bc543d03890","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* ML2 plugin"},{"line_number":41,"context_line":"  Need to include QoS parameters in the response of \u0027get_device_details\u0027"},{"line_number":42,"context_line":"  RPC call so that neutron-linuxbridge-agent can handle QoS."},{"line_number":43,"context_line":"  QoS RPC call change is not necessary."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* linuxbridge mechanism driver"},{"line_number":46,"context_line":"  Add validation check whether a port to be set QoS is an external network"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_afc9f879","line":43,"in_reply_to":"1ae5cdf2_85f7dcf4","updated":"2014-06-03 00:27:06.000000000","message":"will do.\n\nFor get_device_details, \"It is covenient\" is right rather than \"Need\".","commit_id":"0d2c4772e73ee12e2aa9c7a1829e88f2d7100f62"}]}