)]}'
{".zuul.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7d24a3e387d0bd5c42fa4325c453ebb579e690c6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        q-dns: True"},{"line_number":78,"context_line":"        tempest: True"},{"line_number":79,"context_line":"      tempest_concurrency: 2"},{"line_number":80,"context_line":"      tempest_test_regex: \u0027^neutron_tempest_plugin\\.scenario\\.\u0027"},{"line_number":81,"context_line":"      tox_venvlist: all"},{"line_number":82,"context_line":"    voting: false"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df87a7cf_70c1c753","line":80,"updated":"2017-12-12 16:25:52.000000000","message":"Please reduce the scope of the regex to just the dns scenario.","commit_id":"38bc42205b6d9761137911f8149bc8c1c59ccdfe"}],"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eec526b382d405aa19433faa6f7d8998084c96fe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jens Harbott (frickler) \u003cj.harbott@x-ion.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-14 10:41:14 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tests for DNS integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test coverage for the integration with designate, confirming that"},{"line_number":10,"context_line":"the correct DNS records are generated for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_6480c947","line":7,"updated":"2017-12-15 19:15:21.000000000","message":"I am thinking about service dependencies here. So the newly added test class assumes neutron, and skips test cases when designate is not configured. The code uses a lot of code from designate_tempest_plugin, but as for neutron api, it seems to rely on generic features available from tempest client code. With that in mind, why don\u0027t we put the scenario tests into designate_tempest_plugin instead? If it\u0027s just to have the integration link validated, we can always inherit the job definition in neutron_tempest_plugin repo without a single line of tempest code for that.\n\nIt seems this would solve the problem of code copy-paste needed to untangle repos. (See comment in the changed file.)","commit_id":"e0219162c4690659a017b99934d81a597d1d69ad"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e359aca1538f52290e518caa88ae4be9c77f80f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jens Harbott (frickler) \u003cj.harbott@x-ion.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-14 10:41:14 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tests for DNS integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test coverage for the integration with designate, confirming that"},{"line_number":10,"context_line":"the correct DNS records are generated for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_3e4c099d","line":7,"in_reply_to":"df87a7cf_6480c947","updated":"2017-12-16 07:35:58.000000000","message":"The reason why these tests are here is that they are intended to test neutron code: the designate driver located in neutron/plugins/ml2/extensions/dns_integration.py. It would seem strange to have code under designate governance that assures neutron is behaving correctly. Anyway I\u0027ll take this up with fellow designate folks and see what they think about it.","commit_id":"e0219162c4690659a017b99934d81a597d1d69ad"}],"neutron_tempest_plugin/scenario/test_dns_integration.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f715a30495557b4d0157844de8436b45104a193b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ipaddress"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bf8cb3f7_dbb7843a","line":16,"updated":"2017-12-20 20:23:19.000000000","message":"shouldn\u0027t this be added as dependency in test-requirements (or requirements)?\nAlso AFAIK it is third party lib in python2 so shouldn\u0027t it be in same group with test tools?","commit_id":"e0219162c4690659a017b99934d81a597d1d69ad"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6844282022bdde2ae20d6b01cd0822741a3f6ba4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ipaddress"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bf8cb3f7_943526dd","line":16,"in_reply_to":"bf8cb3f7_88919055","updated":"2017-12-22 11:04:42.000000000","message":"yes, You\u0027re right about position - I think it should be treated as py3 code IMHO so position of it is fine then","commit_id":"e0219162c4690659a017b99934d81a597d1d69ad"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7cdd6e7561a3cc2c8f6645ab21bcafb7ba1d5b43","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ipaddress"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bf8cb3f7_88919055","line":16,"in_reply_to":"bf8cb3f7_dbb7843a","updated":"2017-12-22 06:58:30.000000000","message":"Good catch, it certainly should be added to requirements, see e.g. http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/requirements.txt#n17. Guess I got lucky that it is some transitive dependency already.\n\nCollecting ipaddress; python_version \u003c \"3\" (from cryptography\u003e\u003d1.5-\u003eparamiko\u003e\u003d2.0.0-\u003etempest\u003e\u003d16.1.0-\u003e-r requirements.txt (line 13))\n\nNot sure about the position, though, probably a matter of taste whether to say this is py2-compatible py3 code or vice versa. I\u0027d tend to prefer the more modern variant, which unless I\u0027m mistaken is what I have here.","commit_id":"e0219162c4690659a017b99934d81a597d1d69ad"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eec526b382d405aa19433faa6f7d8998084c96fe","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d config.CONF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Note(jh): Need to do a bit of juggling here in order to avoid failures"},{"line_number":34,"context_line":"# when designate_tempest_plugin is not available"},{"line_number":35,"context_line":"dns_base \u003d testtools.try_import(\u0027designate_tempest_plugin.tests.base\u0027)"},{"line_number":36,"context_line":"dns_waiters \u003d testtools.try_import(\u0027designate_tempest_plugin.common.waiters\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_4421059f","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":6},"updated":"2017-12-15 19:15:21.000000000","message":"nit: NOTE","commit_id":"e0219162c4690659a017b99934d81a597d1d69ad"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eec526b382d405aa19433faa6f7d8998084c96fe","unresolved":false,"context_lines":[{"line_number":31,"context_line":"CONF \u003d config.CONF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Note(jh): Need to do a bit of juggling here in order to avoid failures"},{"line_number":34,"context_line":"# when designate_tempest_plugin is not available"},{"line_number":35,"context_line":"dns_base \u003d testtools.try_import(\u0027designate_tempest_plugin.tests.base\u0027)"},{"line_number":36,"context_line":"dns_waiters \u003d testtools.try_import(\u0027designate_tempest_plugin.common.waiters\u0027)"},{"line_number":37,"context_line":"if dns_base:"},{"line_number":38,"context_line":"    DNSMixin \u003d dns_base.BaseDnsV2Test"},{"line_number":39,"context_line":"else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_0469bdbc","line":36,"range":{"start_line":34,"start_character":48,"end_line":36,"end_character":77},"updated":"2017-12-15 19:15:21.000000000","message":"This sets a ticking bomb that will blow up whenever designate_tempest_plugin gets a refactoring for the code imported and used here.\n\nI would suggest we avoid this dependency link and instead copy-paste the needed missing bits into neutron_tempest_plugin.\n\nAlso, what\u0027s this mixin class for?","commit_id":"e0219162c4690659a017b99934d81a597d1d69ad"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e359aca1538f52290e518caa88ae4be9c77f80f2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"CONF \u003d config.CONF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Note(jh): Need to do a bit of juggling here in order to avoid failures"},{"line_number":34,"context_line":"# when designate_tempest_plugin is not available"},{"line_number":35,"context_line":"dns_base \u003d testtools.try_import(\u0027designate_tempest_plugin.tests.base\u0027)"},{"line_number":36,"context_line":"dns_waiters \u003d testtools.try_import(\u0027designate_tempest_plugin.common.waiters\u0027)"},{"line_number":37,"context_line":"if dns_base:"},{"line_number":38,"context_line":"    DNSMixin \u003d dns_base.BaseDnsV2Test"},{"line_number":39,"context_line":"else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_7e2e11a6","line":36,"range":{"start_line":34,"start_character":48,"end_line":36,"end_character":77},"in_reply_to":"df87a7cf_0469bdbc","updated":"2017-12-16 07:35:58.000000000","message":"I kind of made sure with designate developers that this would be considered a stable interface. The test will also be run on designate changes, making sure that possible regressions can be noted early.\n\nThe meaning of the class is to have a test environment that provides both neutron and designate API calls in order to be able to set up the scenario properly. If you want to do this unconditionally without depending on designate code, you would have to mostly full copy the client, which I don\u0027t think makes sense.","commit_id":"e0219162c4690659a017b99934d81a597d1d69ad"}],"requirements.txt":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9e3684e2c6ea0510a6644afea60528402c67297a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"pbr\u003e\u003d2.0 # Apache-2.0"},{"line_number":6,"context_line":"neutron-lib\u003e\u003d1.9.0 # Apache-2.0"},{"line_number":7,"context_line":"oslo.config!\u003d4.3.0,!\u003d4.4.0,\u003e\u003d4.0.0 # Apache-2.0"},{"line_number":8,"context_line":"ipaddress\u003e\u003d1.0.16;python_version\u003c\u00273.3\u0027 # PSF"},{"line_number":9,"context_line":"netaddr!\u003d0.7.16,\u003e\u003d0.7.13 # BSD"},{"line_number":10,"context_line":"oslo.log\u003e\u003d3.22.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.serialization!\u003d2.19.1,\u003e\u003d1.10.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":12,"id":"bf8cb3f7_9818f41d","line":8,"updated":"2017-12-22 19:06:13.000000000","message":"I wonder whether it should be in test-reqs. Though tempest plugin may be considered publicly consumable, so maybe that\u0027s ok. We keep tempest dependency here, so at least it doesn\u0027t make it worse.","commit_id":"860b46aa09d15ab475ed27749e642625776cca93"}]}