)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"23a7e3078f61be3f827a7eec64ee7a835008425b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SNAT - Check connectivity to an external IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check connectivity to an extneral IP (Other than the gateway) from"},{"line_number":10,"context_line":"an Instance without Floating IP"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic1e8da08b212a0c0e7d189af81a39fd9c1653b73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f91af0f_55e6c846","line":10,"updated":"2018-01-02 10:03:39.000000000","message":"instance, floating","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"518a6496e263c4d77a0a4b5de5681769c46d3dc8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SNAT - Check connectivity to an external IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check connectivity to an extneral IP (Other than the gateway) from"},{"line_number":10,"context_line":"an Instance without Floating IP"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic1e8da08b212a0c0e7d189af81a39fd9c1653b73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f91af0f_90c53e91","line":10,"in_reply_to":"9f91af0f_55e6c846","updated":"2018-01-02 11:25:24.000000000","message":"Done","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"473ed2c703d4b7474bb40a2cea24799c128196b9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SNAT - Check connectivity to an external IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check connectivity to an extneral IP (Other than the gateway) from"},{"line_number":10,"context_line":"an instance without floating IP"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic1e8da08b212a0c0e7d189af81a39fd9c1653b73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f91af0f_dc908551","line":10,"updated":"2018-01-04 22:21:26.000000000","message":"Can\u0027t you achieve that by connecting from an instance without FIP to an instance with FIP? FIP is an example of an address that, under certain circumstances - instance is up, FIP is associated, security groups configured - is available for checking external connectivity.\n\nHow is this scenario significantly different from non-FIP to FIP connectivity test?","commit_id":"10a0dda650c9a13c7a724fc2919b454b13e5f7da"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8f6feb2657d9188c9a0eba8c41cab7d3c1394b1a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SNAT - Check connectivity to an external IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check connectivity to an extneral IP (Other than the gateway) from"},{"line_number":10,"context_line":"an instance without floating IP"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic1e8da08b212a0c0e7d189af81a39fd9c1653b73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f91af0f_db9cd90f","line":10,"in_reply_to":"9f91af0f_4971f50b","updated":"2018-01-08 13:50:49.000000000","message":"How about the gateway_ip of the subnet on the external network?  That is most likely the next-hop router for external traffic and probably isn\u0027t handled by neutron.","commit_id":"10a0dda650c9a13c7a724fc2919b454b13e5f7da"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"58219a05d20338f7d3784d0515bcfdaaaa6bad2f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SNAT - Check connectivity to an external IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check connectivity to an extneral IP (Other than the gateway) from"},{"line_number":10,"context_line":"an instance without floating IP"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic1e8da08b212a0c0e7d189af81a39fd9c1653b73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f91af0f_97c61368","line":10,"in_reply_to":"9f91af0f_545e4e76","updated":"2018-01-09 03:09:28.000000000","message":"Yes, I think it\u0027s fair to assume it\u0027s working IF it\u0027s set. If it\u0027s not set, skip the test?","commit_id":"10a0dda650c9a13c7a724fc2919b454b13e5f7da"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e23000f98ffc66d55de7b139826936060ec829a3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SNAT - Check connectivity to an external IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check connectivity to an extneral IP (Other than the gateway) from"},{"line_number":10,"context_line":"an instance without floating IP"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic1e8da08b212a0c0e7d189af81a39fd9c1653b73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f91af0f_545e4e76","line":10,"in_reply_to":"9f91af0f_b4423f3d","updated":"2018-01-08 21:51:09.000000000","message":"gateway_ip should be correct if set, and it *should* work - was just a thought to help move this along.","commit_id":"10a0dda650c9a13c7a724fc2919b454b13e5f7da"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"913c2164c7376f74a38e8a9a633d5ed239a3c551","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SNAT - Check connectivity to an external IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check connectivity to an extneral IP (Other than the gateway) from"},{"line_number":10,"context_line":"an instance without floating IP"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic1e8da08b212a0c0e7d189af81a39fd9c1653b73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f91af0f_b4423f3d","line":10,"in_reply_to":"9f91af0f_db9cd90f","updated":"2018-01-08 17:30:36.000000000","message":"Is it guaranteed that gateway_ip is correct / working / set though? Of course, it\u0027s the same issue with any other address. So all I am saying is that if we go with gateway_ip, the test case should be ready for it not be set at all. (I believe you can create an external network without it set.)","commit_id":"10a0dda650c9a13c7a724fc2919b454b13e5f7da"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b6497a84e6f55f69ab18520d85680466ae21e151","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SNAT - Check connectivity to an external IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check connectivity to an extneral IP (Other than the gateway) from"},{"line_number":10,"context_line":"an instance without floating IP"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic1e8da08b212a0c0e7d189af81a39fd9c1653b73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f91af0f_4971f50b","line":10,"in_reply_to":"9f91af0f_dc908551","updated":"2018-01-07 06:53:39.000000000","message":"The only difference is that it\u0027s an external IP which is not handled by Neutron and it\u0027s not the GW.","commit_id":"10a0dda650c9a13c7a724fc2919b454b13e5f7da"}],"neutron_tempest_plugin/config.py":[{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"23a7e3078f61be3f827a7eec64ee7a835008425b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               help\u003d\u0027The availability zone for all agents in the deployment. \u0027"},{"line_number":39,"context_line":"                    \u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027ext_ip\u0027,"},{"line_number":42,"context_line":"               default\u003d\u00278.8.8.8\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The external IP that is used in SNAT connectivity test.\u0027),"},{"line_number":44,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_758e6c79","line":41,"updated":"2018-01-02 10:03:39.000000000","message":"external_ip","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"518a6496e263c4d77a0a4b5de5681769c46d3dc8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               help\u003d\u0027The availability zone for all agents in the deployment. \u0027"},{"line_number":39,"context_line":"                    \u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027ext_ip\u0027,"},{"line_number":42,"context_line":"               default\u003d\u00278.8.8.8\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The external IP that is used in SNAT connectivity test.\u0027),"},{"line_number":44,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_708e7a79","line":41,"in_reply_to":"9f91af0f_758e6c79","updated":"2018-01-02 11:25:24.000000000","message":"Done","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"23a7e3078f61be3f827a7eec64ee7a835008425b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027ext_ip\u0027,"},{"line_number":42,"context_line":"               default\u003d\u00278.8.8.8\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The external IP that is used in SNAT connectivity test.\u0027),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_f5827c4f","line":43,"updated":"2018-01-02 10:03:39.000000000","message":"It\u0027s not for SNAT only I guess","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"518a6496e263c4d77a0a4b5de5681769c46d3dc8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027ext_ip\u0027,"},{"line_number":42,"context_line":"               default\u003d\u00278.8.8.8\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The external IP that is used in SNAT connectivity test.\u0027),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_f0f7eaf4","line":43,"in_reply_to":"9f91af0f_f5827c4f","updated":"2018-01-02 11:25:24.000000000","message":"Done","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"be7e8137e884d2599075d3d49704607513b55fe7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               help\u003d\u0027The availability zone for all agents in the deployment. \u0027"},{"line_number":39,"context_line":"                    \u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027external_ip\u0027,"},{"line_number":42,"context_line":"               default\u003d\u00278.8.8.8\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The external IP that is used for connectivity testing.\u0027),"},{"line_number":44,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_58b59830","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":14},"updated":"2018-01-02 16:46:22.000000000","message":"IPOpt","commit_id":"19936501606fcc40f2d7ec706de3c9fe278c54e9"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"ea06cf171dbb95f627adb4530698d9c1d8ac2670","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               help\u003d\u0027The availability zone for all agents in the deployment. \u0027"},{"line_number":39,"context_line":"                    \u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027external_ip\u0027,"},{"line_number":42,"context_line":"               default\u003d\u00278.8.8.8\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The external IP that is used for connectivity testing.\u0027),"},{"line_number":44,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_562d5f93","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":14},"in_reply_to":"9f91af0f_58b59830","updated":"2018-01-03 08:53:53.000000000","message":"Done","commit_id":"19936501606fcc40f2d7ec706de3c9fe278c54e9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"be7e8137e884d2599075d3d49704607513b55fe7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    \u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027external_ip\u0027,"},{"line_number":42,"context_line":"               default\u003d\u00278.8.8.8\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The external IP that is used for connectivity testing.\u0027),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_38bf74fc","line":42,"updated":"2018-01-02 16:46:22.000000000","message":"Perhaps default should be \u0027\u0027 and test can skip if so, else it will be run when over-ridden.  That way each environment can set it to something that is known to work.","commit_id":"19936501606fcc40f2d7ec706de3c9fe278c54e9"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"ea06cf171dbb95f627adb4530698d9c1d8ac2670","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    \u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027external_ip\u0027,"},{"line_number":42,"context_line":"               default\u003d\u00278.8.8.8\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027The external IP that is used for connectivity testing.\u0027),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_1627d7b5","line":42,"in_reply_to":"9f91af0f_38bf74fc","updated":"2018-01-03 08:53:53.000000000","message":"Done. But then which gate will verify?","commit_id":"19936501606fcc40f2d7ec706de3c9fe278c54e9"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f89909b07e69e2b261a8513b9ae9ff35761d7d51","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"    cfg.IPOpt(\u0027external_ip\u0027,"},{"line_number":42,"context_line":"              default\u003dNone,"},{"line_number":43,"context_line":"              help\u003d\u0027The external IP that is used for connectivity testing.\u0027),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_40511136","line":43,"updated":"2018-01-03 13:34:39.000000000","message":"Are you sure it\u0027s supposed to be under NeutronPluginOptions?\nIt\u0027s not so it should be separated from it","commit_id":"10a0dda650c9a13c7a724fc2919b454b13e5f7da"}],"neutron_tempest_plugin/scenario/test_floatingip.py":[{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"23a7e3078f61be3f827a7eec64ee7a835008425b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    def test_snat_ext_ip(self):"},{"line_number":167,"context_line":"    \"\"\" Check connectivity to an external IP"},{"line_number":168,"context_line":"    \"\"\""},{"line_number":169,"context_line":"        ext_ip \u003d CONF.neutron_plugin_options.ext_ip"},{"line_number":170,"context_line":"        proxy \u003d self._create_server()"},{"line_number":171,"context_line":"        proxy_client \u003d ssh.Client(proxy[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":172,"context_line":"                                  CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_550248b6","line":169,"updated":"2018-01-02 10:03:39.000000000","message":"no need to declare, just use it","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"518a6496e263c4d77a0a4b5de5681769c46d3dc8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    def test_snat_ext_ip(self):"},{"line_number":167,"context_line":"    \"\"\" Check connectivity to an external IP"},{"line_number":168,"context_line":"    \"\"\""},{"line_number":169,"context_line":"        ext_ip \u003d CONF.neutron_plugin_options.ext_ip"},{"line_number":170,"context_line":"        proxy \u003d self._create_server()"},{"line_number":171,"context_line":"        proxy_client \u003d ssh.Client(proxy[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":172,"context_line":"                                  CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_50e6d646","line":169,"in_reply_to":"9f91af0f_550248b6","updated":"2018-01-02 11:25:24.000000000","message":"Done","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"23a7e3078f61be3f827a7eec64ee7a835008425b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f91af0f_f52cbc48","line":181,"updated":"2018-01-02 10:03:39.000000000","message":"Do you need both inheritances?","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"518a6496e263c4d77a0a4b5de5681769c46d3dc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f91af0f_70bc3a05","line":181,"in_reply_to":"9f91af0f_f52cbc48","updated":"2018-01-02 11:25:24.000000000","message":"yes. base is for check_remote_connectivity.","commit_id":"4c1dd7d70c6cbe74aaeefca1724e955da8613dc2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"be7e8137e884d2599075d3d49704607513b55fe7","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class SnatToExternal(FloatingIpTestCasesMixin,"},{"line_number":163,"context_line":"           base.BaseTempestTestCase):"},{"line_number":164,"context_line":"    same_network \u003d True"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_snat_external_ip(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_784adc27","line":163,"updated":"2018-01-02 16:46:22.000000000","message":"nit: indentation different from other two classes above.","commit_id":"19936501606fcc40f2d7ec706de3c9fe278c54e9"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"ea06cf171dbb95f627adb4530698d9c1d8ac2670","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class SnatToExternal(FloatingIpTestCasesMixin,"},{"line_number":163,"context_line":"           base.BaseTempestTestCase):"},{"line_number":164,"context_line":"    same_network \u003d True"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_snat_external_ip(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_f656f306","line":163,"in_reply_to":"9f91af0f_784adc27","updated":"2018-01-03 08:53:53.000000000","message":"Done","commit_id":"19936501606fcc40f2d7ec706de3c9fe278c54e9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"be7e8137e884d2599075d3d49704607513b55fe7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        proxy_client \u003d ssh.Client(proxy[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":170,"context_line":"                                  CONF.validation.image_ssh_user,"},{"line_number":171,"context_line":"                                  pkey\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":172,"context_line":"        src_server \u003d self._create_server(create_floating_ip\u003dFalse)"},{"line_number":173,"context_line":"        src_server_ip \u003d src_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":174,"context_line":"        ssh_client \u003d ssh.Client(src_server_ip,"},{"line_number":175,"context_line":"                                CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_58ffd8a9","line":172,"updated":"2018-01-02 16:46:22.000000000","message":"So no floating IP.  Perhaps test name should be \"DefaultSnatToExternal\" since it is using the default SNAT address in the router.","commit_id":"19936501606fcc40f2d7ec706de3c9fe278c54e9"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"ea06cf171dbb95f627adb4530698d9c1d8ac2670","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        proxy_client \u003d ssh.Client(proxy[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":170,"context_line":"                                  CONF.validation.image_ssh_user,"},{"line_number":171,"context_line":"                                  pkey\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":172,"context_line":"        src_server \u003d self._create_server(create_floating_ip\u003dFalse)"},{"line_number":173,"context_line":"        src_server_ip \u003d src_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":174,"context_line":"        ssh_client \u003d ssh.Client(src_server_ip,"},{"line_number":175,"context_line":"                                CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_b6694bbf","line":172,"in_reply_to":"9f91af0f_58ffd8a9","updated":"2018-01-03 08:53:53.000000000","message":"Done","commit_id":"19936501606fcc40f2d7ec706de3c9fe278c54e9"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f89909b07e69e2b261a8513b9ae9ff35761d7d51","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class DefaultSnatToExternal(FloatingIpTestCasesMixin,"},{"line_number":165,"context_line":"                            base.BaseTempestTestCase):"},{"line_number":166,"context_line":"    same_network \u003d True"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @testtools.skipUnless(CONF.neutron_plugin_options.external_ip,"},{"line_number":169,"context_line":"                          \"Need an external IP for SNAT connectivity test.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_80563929","line":166,"updated":"2018-01-03 13:34:39.000000000","message":"Is needed?","commit_id":"10a0dda650c9a13c7a724fc2919b454b13e5f7da"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384a63268f4276816f1c81101fa1295a9f7f0136","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def _get_external_gateway(self):"},{"line_number":64,"context_line":"        gateway_external_ip \u003d None"},{"line_number":65,"context_line":"        subnets \u003d self.os_admin.network_client.list_subnets("},{"line_number":66,"context_line":"            network_id\u003dCONF.network.public_network_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        for subnet in subnets[\u0027subnets\u0027]:"},{"line_number":69,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_cda17c96","line":66,"range":{"start_line":66,"start_character":23,"end_line":66,"end_character":53},"updated":"2018-01-16 18:36:34.000000000","message":"I think it\u0027s not guaranteed that this is set, so you should also check this, and skip the test if it\u0027s not set.","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"d4f9deb67ca0c2555bc14da76f06077af7e12117","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def _get_external_gateway(self):"},{"line_number":64,"context_line":"        gateway_external_ip \u003d None"},{"line_number":65,"context_line":"        subnets \u003d self.os_admin.network_client.list_subnets("},{"line_number":66,"context_line":"            network_id\u003dCONF.network.public_network_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        for subnet in subnets[\u0027subnets\u0027]:"},{"line_number":69,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_636866b8","line":66,"range":{"start_line":66,"start_character":23,"end_line":66,"end_character":53},"in_reply_to":"7f96bb07_cda17c96","updated":"2018-01-17 08:11:45.000000000","message":"Done","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384a63268f4276816f1c81101fa1295a9f7f0136","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        for subnet in subnets[\u0027subnets\u0027]:"},{"line_number":69,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                break"},{"line_number":72,"context_line":"        return gateway_external_ip"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_4d91ec4d","line":71,"range":{"start_line":70,"start_character":16,"end_line":71,"end_character":21},"updated":"2018-01-16 18:36:34.000000000","message":"just return it right away","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"d4f9deb67ca0c2555bc14da76f06077af7e12117","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        for subnet in subnets[\u0027subnets\u0027]:"},{"line_number":69,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                break"},{"line_number":72,"context_line":"        return gateway_external_ip"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_235ede11","line":71,"range":{"start_line":70,"start_character":16,"end_line":71,"end_character":21},"in_reply_to":"7f96bb07_4d91ec4d","updated":"2018-01-17 08:11:45.000000000","message":"Done","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384a63268f4276816f1c81101fa1295a9f7f0136","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                break"},{"line_number":72,"context_line":"        return gateway_external_ip"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_dest_network(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_cd7c1c21","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":34},"updated":"2018-01-16 18:36:34.000000000","message":"this line, and line 64, won\u0027t be needed if you just return ip in line 70","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"69eb377af1c5cd94e5c56642d30fd05a02430565","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                break"},{"line_number":72,"context_line":"        return gateway_external_ip"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_dest_network(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_409bca16","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":34},"in_reply_to":"7f96bb07_c39cdac1","updated":"2018-01-17 19:06:17.000000000","message":"No, implicit end of method means return","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"d4f9deb67ca0c2555bc14da76f06077af7e12117","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                break"},{"line_number":72,"context_line":"        return gateway_external_ip"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_dest_network(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_c39cdac1","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":34},"in_reply_to":"7f96bb07_cd7c1c21","updated":"2018-01-17 08:11:45.000000000","message":"I can remove the variable but I still need to return","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"384a63268f4276816f1c81101fa1295a9f7f0136","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @decorators.idempotent_id(\u00273d73ea1a-27c6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":180,"context_line":"    def test_snat_external_ip(self):"},{"line_number":181,"context_line":"        \"\"\"Check connectivity to an external IP \"\"\""},{"line_number":182,"context_line":"        gateway_external_ip \u003d self._get_external_gateway()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if not gateway_external_ip:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_4d96cc41","line":181,"range":{"start_line":181,"start_character":47,"end_line":181,"end_character":48},"updated":"2018-01-16 18:36:34.000000000","message":"spurious space","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"d4f9deb67ca0c2555bc14da76f06077af7e12117","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @decorators.idempotent_id(\u00273d73ea1a-27c6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":180,"context_line":"    def test_snat_external_ip(self):"},{"line_number":181,"context_line":"        \"\"\"Check connectivity to an external IP \"\"\""},{"line_number":182,"context_line":"        gateway_external_ip \u003d self._get_external_gateway()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if not gateway_external_ip:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_83a252fb","line":181,"range":{"start_line":181,"start_character":47,"end_line":181,"end_character":48},"in_reply_to":"7f96bb07_4d96cc41","updated":"2018-01-17 08:11:45.000000000","message":"Done","commit_id":"e1f7bbc4d483633a1fe0e9e79860495aac5edd21"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"07561c38101f543e7985efac8fefcbc412d8513a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                    gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                    return gateway_external_ip"},{"line_number":72,"context_line":"        return"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_dest_network(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_9164d123","line":72,"updated":"2018-01-17 15:06:26.000000000","message":"you shouldn\u0027t need the return","commit_id":"a055baa3b17bb736b0036f7d65f260642403ba18"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"69eb377af1c5cd94e5c56642d30fd05a02430565","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                    gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                    return gateway_external_ip"},{"line_number":72,"context_line":"        return"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_dest_network(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_c0011a3a","line":72,"in_reply_to":"7f96bb07_4c322e60","updated":"2018-01-17 19:06:17.000000000","message":"No, it\u0027s not.","commit_id":"a055baa3b17bb736b0036f7d65f260642403ba18"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"2861db3dc1e897aac117e64d7210ae951d5dd167","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                    gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                    return gateway_external_ip"},{"line_number":72,"context_line":"        return"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_dest_network(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_4c322e60","line":72,"in_reply_to":"7f96bb07_9164d123","updated":"2018-01-17 15:25:51.000000000","message":"I think it\u0027s a good practice.","commit_id":"a055baa3b17bb736b0036f7d65f260642403ba18"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a88dbd16231fc230917233b0309568520fea238a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                    gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                    return gateway_external_ip"},{"line_number":72,"context_line":"        return"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_dest_network(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_111ae5ca","line":72,"in_reply_to":"7f96bb07_c0011a3a","updated":"2018-01-18 08:04:31.000000000","message":"Done","commit_id":"a055baa3b17bb736b0036f7d65f260642403ba18"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"69eb377af1c5cd94e5c56642d30fd05a02430565","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        gateway_external_ip \u003d self._get_external_gateway()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if not gateway_external_ip:"},{"line_number":185,"context_line":"            raise self.skipTest(\"Gateway is not configured for public network\")"},{"line_number":186,"context_line":"        proxy \u003d self._create_server()"},{"line_number":187,"context_line":"        proxy_client \u003d ssh.Client(proxy[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":188,"context_line":"                                  CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_20c1dee5","line":185,"updated":"2018-01-17 19:06:17.000000000","message":"I don\u0027t think it\u0027s a fitting message for the case when public_network_id is not configured at all.","commit_id":"a055baa3b17bb736b0036f7d65f260642403ba18"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a88dbd16231fc230917233b0309568520fea238a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        gateway_external_ip \u003d self._get_external_gateway()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if not gateway_external_ip:"},{"line_number":185,"context_line":"            raise self.skipTest(\"Gateway is not configured for public network\")"},{"line_number":186,"context_line":"        proxy \u003d self._create_server()"},{"line_number":187,"context_line":"        proxy_client \u003d ssh.Client(proxy[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":188,"context_line":"                                  CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f96bb07_d16ebdfe","line":185,"in_reply_to":"7f96bb07_20c1dee5","updated":"2018-01-18 08:04:31.000000000","message":"Done","commit_id":"a055baa3b17bb736b0036f7d65f260642403ba18"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2b163f2c6ebb70ec375e47b3427d12c4cf037d04","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            for subnet in subnets[\u0027subnets\u0027]:"},{"line_number":69,"context_line":"                if subnet[\u0027gateway_ip\u0027]:"},{"line_number":70,"context_line":"                    gateway_external_ip \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":71,"context_line":"                    return gateway_external_ip"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_b10be38b","line":70,"updated":"2018-01-18 15:08:03.000000000","message":"nit: could have just returned without the assignment","commit_id":"657eae80d6abb5dc65e66579f1bd1b4266aa434d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"843a48256d65c68dbeb8c9fe8a9d6492cdc897b7","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if not gateway_external_ip:"},{"line_number":184,"context_line":"            raise self.skipTest(\"Gateway is not configured for public network\""},{"line_number":185,"context_line":"                                \" or public_network_id is not configured\")"},{"line_number":186,"context_line":"        proxy \u003d self._create_server()"},{"line_number":187,"context_line":"        proxy_client \u003d ssh.Client(proxy[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":188,"context_line":"                                  CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_1fd423e8","line":185,"updated":"2018-01-18 14:43:30.000000000","message":"that\u0027s good enough, though I would prefer two separate messages. :)","commit_id":"657eae80d6abb5dc65e66579f1bd1b4266aa434d"}]}
