)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"369c6dfb99e0106954717892baf02447de7ede69","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Because of Linux bridge agent not support gre network, we"},{"line_number":10,"context_line":"skips the linuxbridge scenario job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron now supports creates and updates network mtu,"},{"line_number":13,"context_line":"so in tempest we can use same network type for testing"},{"line_number":14,"context_line":"different mtu size."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f96bb07_f7834d03","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":53},"updated":"2018-01-12 09:32:03.000000000","message":"i guess you should skip unless net-mtu-writable is available.","commit_id":"d4d7cbcfb209f745e427fbe29b13cf79eaa72ae5"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"c61b94cb8547f274c973629e3da48f521ea1f988","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Because of Linux bridge agent not support gre network, we"},{"line_number":10,"context_line":"skips the linuxbridge scenario job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron now supports creates and updates network mtu,"},{"line_number":13,"context_line":"so in tempest we can use same network type for testing"},{"line_number":14,"context_line":"different mtu size."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f96bb07_86565529","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":53},"in_reply_to":"7f96bb07_f7834d03","updated":"2018-01-12 13:10:26.000000000","message":"ok, I will add a requires extension.","commit_id":"d4d7cbcfb209f745e427fbe29b13cf79eaa72ae5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"369c6dfb99e0106954717892baf02447de7ede69","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron now supports creates and updates network mtu,"},{"line_number":13,"context_line":"so in tempest we can use same network type for testing"},{"line_number":14,"context_line":"different mtu size."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I328ed3f196498ec597cb06d3684c94719666623f"},{"line_number":17,"context_line":"Closes-Bug: #1742197"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f96bb07_17b039f4","line":14,"updated":"2018-01-12 09:32:03.000000000","message":"so you replace a restriction with another. i\u0027m not sure if it\u0027s an improvement.","commit_id":"d4d7cbcfb209f745e427fbe29b13cf79eaa72ae5"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"c61b94cb8547f274c973629e3da48f521ea1f988","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron now supports creates and updates network mtu,"},{"line_number":13,"context_line":"so in tempest we can use same network type for testing"},{"line_number":14,"context_line":"different mtu size."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I328ed3f196498ec597cb06d3684c94719666623f"},{"line_number":17,"context_line":"Closes-Bug: #1742197"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f96bb07_c13d27bc","line":14,"in_reply_to":"7f96bb07_17b039f4","updated":"2018-01-12 13:10:26.000000000","message":"I think net-mtu-writable extension had already landed in Pike, so we can create or update network with different MTUs, this will more simpler. We\u0027re no need to creating networks with different type_drivers. Moreover this can resolves linuxbridge scenario job.","commit_id":"d4d7cbcfb209f745e427fbe29b13cf79eaa72ae5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"199817851fcbc8595de641d71a5cc6c37dfc3336","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support MTU tests in the same network type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because of Linux bridge agent not support gre network, we"},{"line_number":10,"context_line":"skips the linuxbridge scenario job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron now supports creates and updates network mtu,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f96bb07_5cc1cb2d","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":41},"updated":"2018-01-15 18:46:14.000000000","message":"Becaus agent doesn\u0027t support GRE networks...","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"199817851fcbc8595de641d71a5cc6c37dfc3336","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support MTU tests in the same network type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because of Linux bridge agent not support gre network, we"},{"line_number":10,"context_line":"skips the linuxbridge scenario job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron now supports creates and updates network mtu,"},{"line_number":13,"context_line":"so in tempest we can use same network type for testing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f96bb07_1cbca3b9","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"updated":"2018-01-15 18:46:14.000000000","message":"skip","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"199817851fcbc8595de641d71a5cc6c37dfc3336","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Because of Linux bridge agent not support gre network, we"},{"line_number":10,"context_line":"skips the linuxbridge scenario job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron now supports creates and updates network mtu,"},{"line_number":13,"context_line":"so in tempest we can use same network type for testing"},{"line_number":14,"context_line":"different mtu size."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f96bb07_fcdd3714","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":40},"updated":"2018-01-15 18:46:14.000000000","message":"supports setting MTU when creating or updating a network","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1d6ce66c2fc4c7e46491383da38ed6291b21d16","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Because of Linux bridge agent not support gre network, we"},{"line_number":10,"context_line":"skips the linuxbridge scenario job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron now supports creates and updates network mtu,"},{"line_number":13,"context_line":"so in tempest we can use same network type for testing"},{"line_number":14,"context_line":"different mtu size."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f96bb07_316cc19a","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":40},"in_reply_to":"7f96bb07_fcdd3714","updated":"2018-01-18 07:43:06.000000000","message":"Done","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"}],"neutron_tempest_plugin/scenario/test_mtu.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ce9e9f44aa60a6fd2e8c4fb33702e4013fb1c304","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Update network mtu lower than vxlan default."},{"line_number":76,"context_line":"        self.admin_client.update_network(self.networks[0][\u0027id\u0027], mtu\u003d1445)"},{"line_number":77,"context_line":"        self.networks[0][\u0027mtu\u0027] \u003d ("},{"line_number":78,"context_line":"            self.admin_client.show_network("},{"line_number":79,"context_line":"                self.networks[0][\u0027id\u0027])[\u0027network\u0027][\u0027mtu\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_1d1273b2","line":76,"range":{"start_line":76,"start_character":69,"end_line":76,"end_character":73},"updated":"2018-01-15 08:01:32.000000000","message":"why 1445? what is vxlan default value?","commit_id":"532435e4b180d2eba16c72c5f61274fd6f1b8d74"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"abd40f7f728fd6f6c230931238d02df83ed615f0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Update network mtu lower than vxlan default."},{"line_number":76,"context_line":"        self.admin_client.update_network(self.networks[0][\u0027id\u0027], mtu\u003d1445)"},{"line_number":77,"context_line":"        self.networks[0][\u0027mtu\u0027] \u003d ("},{"line_number":78,"context_line":"            self.admin_client.show_network("},{"line_number":79,"context_line":"                self.networks[0][\u0027id\u0027])[\u0027network\u0027][\u0027mtu\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_248b8f1f","line":76,"range":{"start_line":76,"start_character":69,"end_line":76,"end_character":73},"in_reply_to":"7f96bb07_1d1273b2","updated":"2018-01-15 12:51:39.000000000","message":"In neutron.conf the \"global_physnet_mtu\" default value is 1500, if tunnel type is vxlan we will minus VXLAN_ENCAP_OVERHEAD(30) and IP_HEADER_LENGTH(20), so we will get vxlan network mtu 1450. So here I update a smaller value than 1450.","commit_id":"532435e4b180d2eba16c72c5f61274fd6f1b8d74"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a249484ecc5e8dac498aa2032d496f1f7a9389d1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Update network mtu lower than vxlan default."},{"line_number":76,"context_line":"        self.admin_client.update_network(self.networks[0][\u0027id\u0027], mtu\u003d1445)"},{"line_number":77,"context_line":"        self.networks[0][\u0027mtu\u0027] \u003d ("},{"line_number":78,"context_line":"            self.admin_client.show_network("},{"line_number":79,"context_line":"                self.networks[0][\u0027id\u0027])[\u0027network\u0027][\u0027mtu\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_37d66351","line":76,"range":{"start_line":76,"start_character":69,"end_line":76,"end_character":73},"in_reply_to":"7f96bb07_248b8f1f","updated":"2018-01-15 13:10:39.000000000","message":"IMO it should be at least described in comment here to explain why there is such value of mtu.\nAlso why it\u0027s 1445 and not e.g. 1449 ?","commit_id":"532435e4b180d2eba16c72c5f61274fd6f1b8d74"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"417669c5c5cadc79cd6096c07bd0c12175152ed7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # Update network mtu lower than vxlan default."},{"line_number":76,"context_line":"        self.admin_client.update_network(self.networks[0][\u0027id\u0027], mtu\u003d1445)"},{"line_number":77,"context_line":"        self.networks[0][\u0027mtu\u0027] \u003d ("},{"line_number":78,"context_line":"            self.admin_client.show_network("},{"line_number":79,"context_line":"                self.networks[0][\u0027id\u0027])[\u0027network\u0027][\u0027mtu\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_3793c351","line":76,"range":{"start_line":76,"start_character":69,"end_line":76,"end_character":73},"in_reply_to":"7f96bb07_37d66351","updated":"2018-01-15 13:18:53.000000000","message":"Done, I will update.","commit_id":"532435e4b180d2eba16c72c5f61274fd6f1b8d74"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ce9e9f44aa60a6fd2e8c4fb33702e4013fb1c304","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        # fails when fragmentation is disabled"},{"line_number":127,"context_line":"        self.check_remote_connectivity("},{"line_number":128,"context_line":"            server_ssh_client, fip2[\u0027fixed_ip_address\u0027], should_succeed\u003dFalse,"},{"line_number":129,"context_line":"            mtu\u003dself.networks[0][\u0027mtu\u0027] + 6, fragmentation\u003dFalse)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # ping with max mtu of 2 networks succeeds when"},{"line_number":132,"context_line":"        # fragmentation is enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_9def63af","line":129,"range":{"start_line":129,"start_character":42,"end_line":129,"end_character":43},"updated":"2018-01-15 08:01:32.000000000","message":"what is this magic value? Can You maybe specify it as some constant value?","commit_id":"532435e4b180d2eba16c72c5f61274fd6f1b8d74"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a249484ecc5e8dac498aa2032d496f1f7a9389d1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        # fails when fragmentation is disabled"},{"line_number":127,"context_line":"        self.check_remote_connectivity("},{"line_number":128,"context_line":"            server_ssh_client, fip2[\u0027fixed_ip_address\u0027], should_succeed\u003dFalse,"},{"line_number":129,"context_line":"            mtu\u003dself.networks[0][\u0027mtu\u0027] + 6, fragmentation\u003dFalse)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # ping with max mtu of 2 networks succeeds when"},{"line_number":132,"context_line":"        # fragmentation is enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_f7cf9bad","line":129,"range":{"start_line":129,"start_character":42,"end_line":129,"end_character":43},"in_reply_to":"7f96bb07_6450b75e","updated":"2018-01-15 13:10:39.000000000","message":"same here. IMO it should be at least described in comment","commit_id":"532435e4b180d2eba16c72c5f61274fd6f1b8d74"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"abd40f7f728fd6f6c230931238d02df83ed615f0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        # fails when fragmentation is disabled"},{"line_number":127,"context_line":"        self.check_remote_connectivity("},{"line_number":128,"context_line":"            server_ssh_client, fip2[\u0027fixed_ip_address\u0027], should_succeed\u003dFalse,"},{"line_number":129,"context_line":"            mtu\u003dself.networks[0][\u0027mtu\u0027] + 6, fragmentation\u003dFalse)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # ping with max mtu of 2 networks succeeds when"},{"line_number":132,"context_line":"        # fragmentation is enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_6450b75e","line":129,"range":{"start_line":129,"start_character":42,"end_line":129,"end_character":43},"in_reply_to":"7f96bb07_9def63af","updated":"2018-01-15 12:51:39.000000000","message":"Here we increase the network mtu larger than 1450.","commit_id":"532435e4b180d2eba16c72c5f61274fd6f1b8d74"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"417669c5c5cadc79cd6096c07bd0c12175152ed7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        # fails when fragmentation is disabled"},{"line_number":127,"context_line":"        self.check_remote_connectivity("},{"line_number":128,"context_line":"            server_ssh_client, fip2[\u0027fixed_ip_address\u0027], should_succeed\u003dFalse,"},{"line_number":129,"context_line":"            mtu\u003dself.networks[0][\u0027mtu\u0027] + 6, fragmentation\u003dFalse)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # ping with max mtu of 2 networks succeeds when"},{"line_number":132,"context_line":"        # fragmentation is enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_97a3b79e","line":129,"range":{"start_line":129,"start_character":42,"end_line":129,"end_character":43},"in_reply_to":"7f96bb07_f7cf9bad","updated":"2018-01-15 13:18:53.000000000","message":"Done","commit_id":"532435e4b180d2eba16c72c5f61274fd6f1b8d74"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"199817851fcbc8595de641d71a5cc6c37dfc3336","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @utils.requires_ext(extension\u003dprovider_net.ALIAS, service\u003d\"network\")"},{"line_number":45,"context_line":"    @utils.requires_ext(extension\u003d\"net-mtu-writable\", service\u003d\"network\")"},{"line_number":46,"context_line":"    def resource_setup(cls):"},{"line_number":47,"context_line":"        super(NetworkMtuBaseTest, cls).resource_setup()"},{"line_number":48,"context_line":"        # setup basic topology for servers we can log into it"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_5cd6abf3","line":45,"updated":"2018-01-15 18:46:14.000000000","message":"I wonder if we can live the existing test case intact for those plugins that don\u0027t support the extension. I don\u0027t want them to loose coverage.","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1d6ce66c2fc4c7e46491383da38ed6291b21d16","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @utils.requires_ext(extension\u003dprovider_net.ALIAS, service\u003d\"network\")"},{"line_number":45,"context_line":"    @utils.requires_ext(extension\u003d\"net-mtu-writable\", service\u003d\"network\")"},{"line_number":46,"context_line":"    def resource_setup(cls):"},{"line_number":47,"context_line":"        super(NetworkMtuBaseTest, cls).resource_setup()"},{"line_number":48,"context_line":"        # setup basic topology for servers we can log into it"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_7b246a5e","line":45,"in_reply_to":"7f96bb07_5cd6abf3","updated":"2018-01-18 07:43:06.000000000","message":"Done","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"199817851fcbc8595de641d71a5cc6c37dfc3336","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        net_kwargs \u003d {\u0027tenant_id\u0027: self.client.tenant_id,"},{"line_number":62,"context_line":"                      \u0027provider:network_type\u0027: \u0027vxlan\u0027}"},{"line_number":63,"context_line":"        for sub in (\u002710.100.0.0/16\u0027, \u002710.200.0.0/16\u0027):"},{"line_number":64,"context_line":"            net_kwargs[\u0027name\u0027] \u003d data_utils.rand_name(\u0027net-\u0027)"},{"line_number":65,"context_line":"            network \u003d self.admin_client.create_network(**net_kwargs)["},{"line_number":66,"context_line":"                \u0027network\u0027]"},{"line_number":67,"context_line":"            self.networks.append(network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_fc2bf7e7","line":64,"range":{"start_line":64,"start_character":58,"end_line":64,"end_character":59},"updated":"2018-01-15 18:46:14.000000000","message":"rand_name already adds a dash between the passed prefix and the rest generated chars.","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1d6ce66c2fc4c7e46491383da38ed6291b21d16","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        net_kwargs \u003d {\u0027tenant_id\u0027: self.client.tenant_id,"},{"line_number":62,"context_line":"                      \u0027provider:network_type\u0027: \u0027vxlan\u0027}"},{"line_number":63,"context_line":"        for sub in (\u002710.100.0.0/16\u0027, \u002710.200.0.0/16\u0027):"},{"line_number":64,"context_line":"            net_kwargs[\u0027name\u0027] \u003d data_utils.rand_name(\u0027net-\u0027)"},{"line_number":65,"context_line":"            network \u003d self.admin_client.create_network(**net_kwargs)["},{"line_number":66,"context_line":"                \u0027network\u0027]"},{"line_number":67,"context_line":"            self.networks.append(network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_1bd9a655","line":64,"range":{"start_line":64,"start_character":58,"end_line":64,"end_character":59},"in_reply_to":"7f96bb07_fc2bf7e7","updated":"2018-01-18 07:43:06.000000000","message":"Done","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"199817851fcbc8595de641d71a5cc6c37dfc3336","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.addCleanup(self.client.remove_router_interface_with_subnet_id,"},{"line_number":73,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # The Neutron config \"global_physnet_mtu\" set to 1500 for virtual"},{"line_number":76,"context_line":"        # network MTU. For vxlan network, it will subtracts the overlay"},{"line_number":77,"context_line":"        # protocol overhead, the result is 1450."},{"line_number":78,"context_line":"        # Update network mtu lower than 1450."}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_3c22bf01","line":75,"updated":"2018-01-15 18:46:14.000000000","message":"instead of assuming it\u0027s set to 1500, how about just fetching mtu for one of networks and subtract 1 from it? Tempest tests shouldn\u0027t rely on deployment configuration.","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1d6ce66c2fc4c7e46491383da38ed6291b21d16","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.addCleanup(self.client.remove_router_interface_with_subnet_id,"},{"line_number":73,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # The Neutron config \"global_physnet_mtu\" set to 1500 for virtual"},{"line_number":76,"context_line":"        # network MTU. For vxlan network, it will subtracts the overlay"},{"line_number":77,"context_line":"        # protocol overhead, the result is 1450."},{"line_number":78,"context_line":"        # Update network mtu lower than 1450."}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_5eeabcd7","line":75,"in_reply_to":"7f96bb07_3c22bf01","updated":"2018-01-18 07:43:06.000000000","message":"Done","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"199817851fcbc8595de641d71a5cc6c37dfc3336","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # The Neutron config \"global_physnet_mtu\" set to 1500 for virtual"},{"line_number":76,"context_line":"        # network MTU. For vxlan network, it will subtracts the overlay"},{"line_number":77,"context_line":"        # protocol overhead, the result is 1450."},{"line_number":78,"context_line":"        # Update network mtu lower than 1450."},{"line_number":79,"context_line":"        self.admin_client.update_network(self.networks[0][\u0027id\u0027], mtu\u003d1449)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_3c495fcf","line":76,"range":{"start_line":76,"start_character":50,"end_line":76,"end_character":59},"updated":"2018-01-15 18:46:14.000000000","message":"subtract","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1d6ce66c2fc4c7e46491383da38ed6291b21d16","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # The Neutron config \"global_physnet_mtu\" set to 1500 for virtual"},{"line_number":76,"context_line":"        # network MTU. For vxlan network, it will subtracts the overlay"},{"line_number":77,"context_line":"        # protocol overhead, the result is 1450."},{"line_number":78,"context_line":"        # Update network mtu lower than 1450."},{"line_number":79,"context_line":"        self.admin_client.update_network(self.networks[0][\u0027id\u0027], mtu\u003d1449)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_9ee4c40e","line":76,"range":{"start_line":76,"start_character":50,"end_line":76,"end_character":59},"in_reply_to":"7f96bb07_3c495fcf","updated":"2018-01-18 07:43:06.000000000","message":"Done","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"199817851fcbc8595de641d71a5cc6c37dfc3336","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        # fails when fragmentation is disabled"},{"line_number":131,"context_line":"        self.check_remote_connectivity("},{"line_number":132,"context_line":"            server_ssh_client, fip2[\u0027fixed_ip_address\u0027], should_succeed\u003dFalse,"},{"line_number":133,"context_line":"            mtu\u003dself.networks[0][\u0027mtu\u0027] + 2, fragmentation\u003dFalse)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # ping with max mtu of 2 networks succeeds when"},{"line_number":136,"context_line":"        # fragmentation is enabled"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_3c507f5d","line":133,"range":{"start_line":133,"start_character":42,"end_line":133,"end_character":43},"updated":"2018-01-15 18:46:14.000000000","message":"assuming we leave the current test case intact, I don\u0027t think this change should be present either because we want to make sure that just 1byte overhead results in the correct (failing) behavior.\n\nI think we need to duplicate the test case, make one (existing) flavor using gre and vxlan, while another (new) test case would validate it using vxlan and new writable mtu extension.","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1d6ce66c2fc4c7e46491383da38ed6291b21d16","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        # fails when fragmentation is disabled"},{"line_number":131,"context_line":"        self.check_remote_connectivity("},{"line_number":132,"context_line":"            server_ssh_client, fip2[\u0027fixed_ip_address\u0027], should_succeed\u003dFalse,"},{"line_number":133,"context_line":"            mtu\u003dself.networks[0][\u0027mtu\u0027] + 2, fragmentation\u003dFalse)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # ping with max mtu of 2 networks succeeds when"},{"line_number":136,"context_line":"        # fragmentation is enabled"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_1ec2f459","line":133,"range":{"start_line":133,"start_character":42,"end_line":133,"end_character":43},"in_reply_to":"7f96bb07_3c507f5d","updated":"2018-01-18 07:43:06.000000000","message":"Done","commit_id":"42869b0532299a8e8947bc911701bac9cf2f66f2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aff0d1f12a3dd99d32f9f39d51bd90ef7dbe5082","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return server, fip"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class NetworkMtuBaseTest(NetworkMtuTest):"},{"line_number":51,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":52,"context_line":"    servers \u003d []"},{"line_number":53,"context_line":"    networks \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_f94a90aa","line":50,"updated":"2018-01-22 08:03:33.000000000","message":"Names of those classes are confusing for me and it should be done opposite way. In L31 should be class with \"Base\" in name and here should be class which inherits from this \"Base\" class.","commit_id":"841e189ccc3e2347a2b1b2cd8add2cd4ddbab721"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"516bba53b6eecb22b494489a63b88daf3aea4f58","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return server, fip"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class NetworkMtuBaseTest(NetworkMtuTest):"},{"line_number":51,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":52,"context_line":"    servers \u003d []"},{"line_number":53,"context_line":"    networks \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_edf8437d","line":50,"in_reply_to":"7f96bb07_f94a90aa","updated":"2018-01-23 07:00:45.000000000","message":"Done","commit_id":"841e189ccc3e2347a2b1b2cd8add2cd4ddbab721"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aff0d1f12a3dd99d32f9f39d51bd90ef7dbe5082","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    @classmethod"},{"line_number":156,"context_line":"    @utils.requires_ext(extension\u003d\"net-mtu-writable\", service\u003d\"network\")"},{"line_number":157,"context_line":"    def resource_setup(cls):"},{"line_number":158,"context_line":"        super(NetworkWritableMtuTest, cls).resource_setup()"},{"line_number":159,"context_line":"        # setup basic topology for servers we can log into it"},{"line_number":160,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":161,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":162,"context_line":"        cls.secgroup \u003d cls.os_primary.network_client.create_security_group("},{"line_number":163,"context_line":"            name\u003d\u0027secgroup_mtu\u0027)"},{"line_number":164,"context_line":"        cls.security_groups.append(cls.secgroup[\u0027security_group\u0027])"},{"line_number":165,"context_line":"        cls.create_loginable_secgroup_rule("},{"line_number":166,"context_line":"            secgroup_id\u003dcls.secgroup[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":167,"context_line":"        cls.create_pingable_secgroup_rule("},{"line_number":168,"context_line":"            secgroup_id\u003dcls.secgroup[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _create_setup(self):"},{"line_number":171,"context_line":"        self.admin_client \u003d self.os_admin.network_client"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_99934c01","line":168,"range":{"start_line":158,"start_character":0,"end_line":168,"end_character":61},"updated":"2018-01-22 08:03:33.000000000","message":"isn\u0027t it exactly the same as method in L66? Maybe You could move this code to this \"base\" class also?","commit_id":"841e189ccc3e2347a2b1b2cd8add2cd4ddbab721"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"516bba53b6eecb22b494489a63b88daf3aea4f58","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    @classmethod"},{"line_number":156,"context_line":"    @utils.requires_ext(extension\u003d\"net-mtu-writable\", service\u003d\"network\")"},{"line_number":157,"context_line":"    def resource_setup(cls):"},{"line_number":158,"context_line":"        super(NetworkWritableMtuTest, cls).resource_setup()"},{"line_number":159,"context_line":"        # setup basic topology for servers we can log into it"},{"line_number":160,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":161,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":162,"context_line":"        cls.secgroup \u003d cls.os_primary.network_client.create_security_group("},{"line_number":163,"context_line":"            name\u003d\u0027secgroup_mtu\u0027)"},{"line_number":164,"context_line":"        cls.security_groups.append(cls.secgroup[\u0027security_group\u0027])"},{"line_number":165,"context_line":"        cls.create_loginable_secgroup_rule("},{"line_number":166,"context_line":"            secgroup_id\u003dcls.secgroup[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":167,"context_line":"        cls.create_pingable_secgroup_rule("},{"line_number":168,"context_line":"            secgroup_id\u003dcls.secgroup[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _create_setup(self):"},{"line_number":171,"context_line":"        self.admin_client \u003d self.os_admin.network_client"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_adf23b99","line":168,"range":{"start_line":158,"start_character":0,"end_line":168,"end_character":61},"in_reply_to":"7f96bb07_99934c01","updated":"2018-01-23 07:00:45.000000000","message":"Done","commit_id":"841e189ccc3e2347a2b1b2cd8add2cd4ddbab721"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aff0d1f12a3dd99d32f9f39d51bd90ef7dbe5082","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.admin_client \u003d self.os_admin.network_client"},{"line_number":172,"context_line":"        net_kwargs \u003d {\u0027tenant_id\u0027: self.client.tenant_id,"},{"line_number":173,"context_line":"                      \u0027provider:network_type\u0027: \u0027vxlan\u0027}"},{"line_number":174,"context_line":"        for sub in (\u002710.100.0.0/16\u0027, \u002710.200.0.0/16\u0027):"},{"line_number":175,"context_line":"            net_kwargs[\u0027name\u0027] \u003d data_utils.rand_name(\u0027net\u0027)"},{"line_number":176,"context_line":"            network \u003d self.admin_client.create_network(**net_kwargs)["},{"line_number":177,"context_line":"                \u0027network\u0027]"},{"line_number":178,"context_line":"            self.networks.append(network)"},{"line_number":179,"context_line":"            self.addCleanup(self.admin_client.delete_network, network[\u0027id\u0027])"},{"line_number":180,"context_line":"            cidr \u003d netaddr.IPNetwork(sub)"},{"line_number":181,"context_line":"            subnet \u003d self.create_subnet(network, cidr\u003dcidr)"},{"line_number":182,"context_line":"            self.create_router_interface(self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":183,"context_line":"            self.addCleanup(self.client.remove_router_interface_with_subnet_id,"},{"line_number":184,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Update network mtu."},{"line_number":187,"context_line":"        net_mtu \u003d self.admin_client.show_network("}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_39ad5831","line":184,"range":{"start_line":174,"start_character":8,"end_line":184,"end_character":60},"updated":"2018-01-22 08:03:33.000000000","message":"this part also looks for me that is the same as in class above. Maybe You could extract it to base class and reuse in both places?","commit_id":"841e189ccc3e2347a2b1b2cd8add2cd4ddbab721"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"516bba53b6eecb22b494489a63b88daf3aea4f58","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.admin_client \u003d self.os_admin.network_client"},{"line_number":172,"context_line":"        net_kwargs \u003d {\u0027tenant_id\u0027: self.client.tenant_id,"},{"line_number":173,"context_line":"                      \u0027provider:network_type\u0027: \u0027vxlan\u0027}"},{"line_number":174,"context_line":"        for sub in (\u002710.100.0.0/16\u0027, \u002710.200.0.0/16\u0027):"},{"line_number":175,"context_line":"            net_kwargs[\u0027name\u0027] \u003d data_utils.rand_name(\u0027net\u0027)"},{"line_number":176,"context_line":"            network \u003d self.admin_client.create_network(**net_kwargs)["},{"line_number":177,"context_line":"                \u0027network\u0027]"},{"line_number":178,"context_line":"            self.networks.append(network)"},{"line_number":179,"context_line":"            self.addCleanup(self.admin_client.delete_network, network[\u0027id\u0027])"},{"line_number":180,"context_line":"            cidr \u003d netaddr.IPNetwork(sub)"},{"line_number":181,"context_line":"            subnet \u003d self.create_subnet(network, cidr\u003dcidr)"},{"line_number":182,"context_line":"            self.create_router_interface(self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":183,"context_line":"            self.addCleanup(self.client.remove_router_interface_with_subnet_id,"},{"line_number":184,"context_line":"                            self.router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Update network mtu."},{"line_number":187,"context_line":"        net_mtu \u003d self.admin_client.show_network("}],"source_content_type":"text/x-python","patch_set":8,"id":"7f96bb07_0dfecf37","line":184,"range":{"start_line":174,"start_character":8,"end_line":184,"end_character":60},"in_reply_to":"7f96bb07_39ad5831","updated":"2018-01-23 07:00:45.000000000","message":"IMO, this is more or less different with another class, so I keep it in two parts.","commit_id":"841e189ccc3e2347a2b1b2cd8add2cd4ddbab721"}]}