)]}'
{"neutron_tempest_plugin/scenario/test_floatingip.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b89875f9639a87f64a8624526f6c19813cdc66c5","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        fip \u003d self.client.show_floatingip(fip_id)[\u0027floatingip\u0027]"},{"line_number":297,"context_line":"        self.assertIn(\u0027port_details\u0027, fip)"},{"line_number":298,"context_line":"        port_details \u003d fip[\u0027port_details\u0027]"},{"line_number":299,"context_line":"        status \u003d port_details[\u0027status\u0027]"},{"line_number":300,"context_line":"        start \u003d int(time.time())"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        while status !\u003d \u0027DOWN\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f74ab321","line":299,"updated":"2018-09-20 22:40:28.000000000","message":"This probably also needs to be fixed","commit_id":"a63469c86c2947de07417c1f72e41303007cc4fe"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"461b556d5884e176124dda7928c27651d4334da1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            fip \u003d self.client.show_floatingip(fip_id)[\u0027floatingip\u0027]"},{"line_number":305,"context_line":"            self.assertIn(\u0027port_details\u0027, fip)"},{"line_number":306,"context_line":"            port_details \u003d fip[\u0027port_details\u0027]"},{"line_number":307,"context_line":"            status \u003d port_details[\u0027status\u0027]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            timed_out \u003d int(time.time()) - start \u003e\u003d timeout"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b7ebdb0f","line":307,"updated":"2018-09-20 22:34:03.000000000","message":"Per L291 above, the point of this is to wait for the FIP\u0027s status \"DOWN\", isn\u0027t it? Here you are testing the attached port\u0027s status","commit_id":"a63469c86c2947de07417c1f72e41303007cc4fe"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1d4d7e92d10475385aa8ee9dfc8626c27e1debc7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            fip \u003d self.client.show_floatingip(fip_id)[\u0027floatingip\u0027]"},{"line_number":305,"context_line":"            self.assertIn(\u0027port_details\u0027, fip)"},{"line_number":306,"context_line":"            port_details \u003d fip[\u0027port_details\u0027]"},{"line_number":307,"context_line":"            status \u003d port_details[\u0027status\u0027]"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            timed_out \u003d int(time.time()) - start \u003e\u003d timeout"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4b0d0233","line":307,"in_reply_to":"3f79a3b5_b7ebdb0f","updated":"2018-09-21 03:29:37.000000000","message":"Yeah, the test is a little strange, it checks the details of the attached port (which is why I saw it in BUILD state sometimes).  The only problem is if I check fip[\u0027status\u0027] here then _check_port_details() above could still fail.  Maybe I just need to update the comment on L291 and the commit message?","commit_id":"a63469c86c2947de07417c1f72e41303007cc4fe"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"db050159f73c48d0488faf618673c24b6c031fc6","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        status \u003d port_details[\u0027status\u0027]"},{"line_number":300,"context_line":"        start \u003d int(time.time())"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        while status !\u003d \u0027DOWN\u0027:"},{"line_number":303,"context_line":"            time.sleep(interval)"},{"line_number":304,"context_line":"            fip \u003d self.client.show_floatingip(fip_id)[\u0027floatingip\u0027]"},{"line_number":305,"context_line":"            self.assertIn(\u0027port_details\u0027, fip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_23f05b91","line":302,"updated":"2018-09-28 10:38:44.000000000","message":"there is constant for this status in https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L30 - please use it","commit_id":"554e46af94e4117889642b4f8a66cbc8c4883a13"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"699add2eeeef7c4ef28f377c804e926ecb7693b2","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        status \u003d port_details[\u0027status\u0027]"},{"line_number":300,"context_line":"        start \u003d int(time.time())"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        while status !\u003d \u0027DOWN\u0027:"},{"line_number":303,"context_line":"            time.sleep(interval)"},{"line_number":304,"context_line":"            fip \u003d self.client.show_floatingip(fip_id)[\u0027floatingip\u0027]"},{"line_number":305,"context_line":"            self.assertIn(\u0027port_details\u0027, fip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0d70e908","line":302,"in_reply_to":"3f79a3b5_23f05b91","updated":"2018-09-28 13:35:12.000000000","message":"Done","commit_id":"554e46af94e4117889642b4f8a66cbc8c4883a13"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"8e23ad21299ebf86293615ee79648141e68513ed","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            # API so we have to poll the port until the device_id is unset."},{"line_number":245,"context_line":"            self.delete_interface(server[\u0027server\u0027][\u0027id\u0027], port[\u0027id\u0027])"},{"line_number":246,"context_line":"            port \u003d self._wait_for_port_detach(port[\u0027id\u0027])"},{"line_number":247,"context_line":"            fip \u003d self._wait_for_fip_down(fip[\u0027id\u0027])"},{"line_number":248,"context_line":"            self._check_port_details("},{"line_number":249,"context_line":"                fip, port, status\u003dlib_constants.PORT_STATUS_DOWN,"},{"line_number":250,"context_line":"                device_id\u003d\u0027\u0027, device_owner\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_354e3f39","line":247,"range":{"start_line":247,"start_character":23,"end_line":247,"end_character":41},"updated":"2018-09-28 22:56:04.000000000","message":"Technically, this is not for waiting fip to be down, but for waiting the port that is associated with fip to be down. Therefore, I think rename it to \u0027_wait_for_fip_port_down\u0027 or \u0027_wait_for_port_down\u0027 is better.","commit_id":"82ed4e8808096cc579d1fab62b24c850ea517d1d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f98ad77c2cd0e6143ca6154dfcdec965349ca90a","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        return port"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def _wait_for_fip_down(self, fip_id, timeout\u003d120, interval\u003d10):"},{"line_number":292,"context_line":"        \"\"\"Waits for the fip\u0027s attached port status to be \u0027DOWN\u0027."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :param fip_id: The id of the floating IP."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8fa5aaa2","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":26},"updated":"2018-10-01 09:48:25.000000000","message":"As Hongbin stated this method waits fip port down, so _wait_for_fip_port_down or similar name would fit better.","commit_id":"82ed4e8808096cc579d1fab62b24c850ea517d1d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"707862406219f65cd7c8a9223e651b1faff0b1cd","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        return port"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def _wait_for_fip_down(self, fip_id, timeout\u003d120, interval\u003d10):"},{"line_number":292,"context_line":"        \"\"\"Waits for the fip\u0027s attached port status to be \u0027DOWN\u0027."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :param fip_id: The id of the floating IP."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_83349afb","line":291,"range":{"start_line":291,"start_character":8,"end_line":291,"end_character":26},"in_reply_to":"3f79a3b5_8fa5aaa2","updated":"2018-10-01 18:31:01.000000000","message":"Done","commit_id":"82ed4e8808096cc579d1fab62b24c850ea517d1d"}]}
