)]}'
{".zuul.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ddd1cf1a12bb416e98055a8c72e68a29840c0f93","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        DEFAULT_IMAGE_NAME: cirros-0.3.4-i386-disk"},{"line_number":210,"context_line":"        ADVANCED_IMAGE_NAME: ubuntu-16.04-server-cloudimg-adm64-disk1"},{"line_number":211,"context_line":"        ADVANCED_INSTANCE_TYPE: ds512M"},{"line_number":212,"context_line":"        ADVANCED_INSTANCE_USER: ubuntu"},{"line_number":213,"context_line":"        BUILD_TIMEOUT: 784"},{"line_number":214,"context_line":"      devstack_plugins:"},{"line_number":215,"context_line":"        neutron: git://git.openstack.org/openstack/neutron.git"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_51866167","line":212,"updated":"2018-10-11 21:28:47.000000000","message":"Just getting back to my original question.  If this is the ubuntu image, then the user must be ubuntu, if it\u0027s cirros then that user name won\u0027t work.  Is the fall back to the cirros image in case the ubuntu one doesn\u0027t exist?  Will the tests fail in that case?","commit_id":"60f9a76cc820b129c01849fabd0ea88de9bd9254"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"30aac393ee16b98c9daf77c2ba910fc073afe5b1","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        DEFAULT_IMAGE_NAME: cirros-0.3.4-i386-disk"},{"line_number":210,"context_line":"        ADVANCED_IMAGE_NAME: ubuntu-16.04-server-cloudimg-adm64-disk1"},{"line_number":211,"context_line":"        ADVANCED_INSTANCE_TYPE: ds512M"},{"line_number":212,"context_line":"        ADVANCED_INSTANCE_USER: ubuntu"},{"line_number":213,"context_line":"        BUILD_TIMEOUT: 784"},{"line_number":214,"context_line":"      devstack_plugins:"},{"line_number":215,"context_line":"        neutron: git://git.openstack.org/openstack/neutron.git"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_b1e33506","line":212,"in_reply_to":"3f79a3b5_51866167","updated":"2018-10-11 21:39:35.000000000","message":"if ADVANCED_IMAGE is ubuntu then this user have to be ubuntu, right.\nIt will not work with cirros name for sure.\nIn tests where advanced_image is required (test_mtu, test_trunk) we will not fall back to DEFAULT_IMAGE (cirros) in case if this one will not be configured. In such case test will fail as neutron_plugin_options.advanced_image_ref option will be empty then.","commit_id":"60f9a76cc820b129c01849fabd0ea88de9bd9254"}],"devstack/functions.sh":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd846bec77584dbd7621c5e5c696e3cd5ea3375b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Save IFS"},{"line_number":75,"context_line":"    ifs\u003d$IFS"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    available_flavors\u003d$(nova flavor-list)"},{"line_number":78,"context_line":"    flavors\u003d\"\""},{"line_number":79,"context_line":"    IFS\u003d$\u0027\\r\\n\u0027"},{"line_number":80,"context_line":"    for line in $available_flavors; do"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f79a3b5_641aa16b","line":77,"range":{"start_line":77,"start_character":24,"end_line":77,"end_character":40},"updated":"2018-10-13 00:01:04.000000000","message":"`openstack flavor list` ?","commit_id":"e1229ca057b0a2e8b5601792adbee1335e7850ba"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6a2a14c1ed8b00371974f28a26c5d20da52f8299","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Save IFS"},{"line_number":75,"context_line":"    ifs\u003d$IFS"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    available_flavors\u003d$(nova flavor-list)"},{"line_number":78,"context_line":"    flavors\u003d\"\""},{"line_number":79,"context_line":"    IFS\u003d$\u0027\\r\\n\u0027"},{"line_number":80,"context_line":"    for line in $available_flavors; do"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f79a3b5_32c8601f","line":77,"range":{"start_line":77,"start_character":24,"end_line":77,"end_character":40},"in_reply_to":"3f79a3b5_641aa16b","updated":"2018-10-15 08:44:37.000000000","message":"Done","commit_id":"e1229ca057b0a2e8b5601792adbee1335e7850ba"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd846bec77584dbd7621c5e5c696e3cd5ea3375b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    flavors\u003d\"\""},{"line_number":79,"context_line":"    IFS\u003d$\u0027\\r\\n\u0027"},{"line_number":80,"context_line":"    for line in $available_flavors; do"},{"line_number":81,"context_line":"        f\u003d$(echo $line | awk \"/ $ADVANCED_INSTANCE_TYPE / { print \\$2 }\")"},{"line_number":82,"context_line":"        flavors\u003d\"$flavors $f\""},{"line_number":83,"context_line":"    done"},{"line_number":84,"context_line":"    IFS\u003d\" \""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f79a3b5_04596d27","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":73},"updated":"2018-10-13 00:01:04.000000000","message":"may want to skip beginning and end line +--\n\nif [[ \"$line\" !\u003d +--* ]]; then","commit_id":"e1229ca057b0a2e8b5601792adbee1335e7850ba"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6a2a14c1ed8b00371974f28a26c5d20da52f8299","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    flavors\u003d\"\""},{"line_number":79,"context_line":"    IFS\u003d$\u0027\\r\\n\u0027"},{"line_number":80,"context_line":"    for line in $available_flavors; do"},{"line_number":81,"context_line":"        f\u003d$(echo $line | awk \"/ $ADVANCED_INSTANCE_TYPE / { print \\$2 }\")"},{"line_number":82,"context_line":"        flavors\u003d\"$flavors $f\""},{"line_number":83,"context_line":"    done"},{"line_number":84,"context_line":"    IFS\u003d\" \""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f79a3b5_72f2586b","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":73},"in_reply_to":"3f79a3b5_04596d27","updated":"2018-10-15 08:44:37.000000000","message":"I did it differently now. Should be better :)","commit_id":"e1229ca057b0a2e8b5601792adbee1335e7850ba"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dd846bec77584dbd7621c5e5c696e3cd5ea3375b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    num_flavors\u003d${#flavors[*]}"},{"line_number":87,"context_line":"    echo \"Found $num_flavors flavors for $ADVANCED_IMAGE_NAME\""},{"line_number":88,"context_line":"    if [[ $num_flavors -eq 0 ]]; then"},{"line_number":89,"context_line":"        echo \"Found no valid flavors to use for $ADVANCED_IMAGE_NAME!\""},{"line_number":90,"context_line":"        echo \"Fallback to use $DEFAULT_INSTANCE_TYPE\""},{"line_number":91,"context_line":"        flavor_ref\u003d$(iniget $TEMPEST_CONFIG compute flavor_ref)"},{"line_number":92,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f79a3b5_649dc1b8","line":89,"range":{"start_line":89,"start_character":66,"end_line":89,"end_character":69},"updated":"2018-10-13 00:01:04.000000000","message":"space bewtween NAME and !","commit_id":"e1229ca057b0a2e8b5601792adbee1335e7850ba"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6a2a14c1ed8b00371974f28a26c5d20da52f8299","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    num_flavors\u003d${#flavors[*]}"},{"line_number":87,"context_line":"    echo \"Found $num_flavors flavors for $ADVANCED_IMAGE_NAME\""},{"line_number":88,"context_line":"    if [[ $num_flavors -eq 0 ]]; then"},{"line_number":89,"context_line":"        echo \"Found no valid flavors to use for $ADVANCED_IMAGE_NAME!\""},{"line_number":90,"context_line":"        echo \"Fallback to use $DEFAULT_INSTANCE_TYPE\""},{"line_number":91,"context_line":"        flavor_ref\u003d$(iniget $TEMPEST_CONFIG compute flavor_ref)"},{"line_number":92,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f79a3b5_1293e401","line":89,"range":{"start_line":89,"start_character":66,"end_line":89,"end_character":69},"in_reply_to":"3f79a3b5_649dc1b8","updated":"2018-10-15 08:44:37.000000000","message":"Done","commit_id":"e1229ca057b0a2e8b5601792adbee1335e7850ba"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a9ccb1eb019056077de3780104303c0eb83550e1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return 0"},{"line_number":78,"context_line":"    fi"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    flavor_ref\u003d$(openstack flavor show $ADVANCED_INSTANCE_TYPE -f value -c id)"},{"line_number":81,"context_line":"    echo \"Found $num_flavors flavors for $ADVANCED_IMAGE_NAME\""},{"line_number":82,"context_line":"    if [[ -z $flavor_ref ]]; then"},{"line_number":83,"context_line":"        echo \"Found no valid flavors to use for $ADVANCED_IMAGE_NAME !\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"3f79a3b5_db2ee7f7","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":77},"updated":"2018-10-14 17:06:53.000000000","message":"much better !","commit_id":"29813c1f21c94dc178695b91c7639858fc3d46b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b87a9452b766898cd42f479291ab4fe31263b10","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        fi"},{"line_number":54,"context_line":"    done \u003c \u003c(openstack image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if [[ -z $advanced_image_uuid ]]; then"},{"line_number":57,"context_line":"        echo \"No image with name $ADVANCED_IMAGE_NAME found.\""},{"line_number":58,"context_line":"        return 1"},{"line_number":59,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_45f7435b","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":33},"updated":"2018-10-15 18:21:30.000000000","message":"should this be in \"\" too?  to be safe","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f20b305f6963f895d6719a5f08b7c8642d40cc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        fi"},{"line_number":54,"context_line":"    done \u003c \u003c(openstack image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if [[ -z $advanced_image_uuid ]]; then"},{"line_number":57,"context_line":"        echo \"No image with name $ADVANCED_IMAGE_NAME found.\""},{"line_number":58,"context_line":"        return 1"},{"line_number":59,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_fe2e1ca9","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":33},"in_reply_to":"3f79a3b5_45f7435b","updated":"2018-10-15 21:03:52.000000000","message":"Done","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b87a9452b766898cd42f479291ab4fe31263b10","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return 0"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    if [[ -z $ADVANCED_INSTANCE_TYPE ]]; then"},{"line_number":75,"context_line":"        # if name of flavor for advanced image is not provided, there is no"},{"line_number":76,"context_line":"        # flavor to configure"},{"line_number":77,"context_line":"        return 0"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_a5fc173f","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":36},"updated":"2018-10-15 18:21:30.000000000","message":"this should be in \"\" like above","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f20b305f6963f895d6719a5f08b7c8642d40cc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return 0"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    if [[ -z $ADVANCED_INSTANCE_TYPE ]]; then"},{"line_number":75,"context_line":"        # if name of flavor for advanced image is not provided, there is no"},{"line_number":76,"context_line":"        # flavor to configure"},{"line_number":77,"context_line":"        return 0"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_1e32f80f","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":36},"in_reply_to":"3f79a3b5_a5fc173f","updated":"2018-10-15 21:03:52.000000000","message":"Done","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"db02975844caf7cbbe433c7fe863989fdd5779c0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    fi"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    flavor_ref\u003d$(openstack flavor show $ADVANCED_INSTANCE_TYPE -f value -c id)"},{"line_number":81,"context_line":"    echo \"Found $num_flavors flavors for $ADVANCED_IMAGE_NAME\""},{"line_number":82,"context_line":"    if [[ -z $flavor_ref ]]; then"},{"line_number":83,"context_line":"        echo \"Found no valid flavors to use for $ADVANCED_IMAGE_NAME !\""},{"line_number":84,"context_line":"        echo \"Fallback to use $DEFAULT_INSTANCE_TYPE\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_a80b8e1f","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":62},"updated":"2018-10-15 18:29:51.000000000","message":"this needs to be updated !","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b87a9452b766898cd42f479291ab4fe31263b10","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    fi"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    flavor_ref\u003d$(openstack flavor show $ADVANCED_INSTANCE_TYPE -f value -c id)"},{"line_number":81,"context_line":"    echo \"Found $num_flavors flavors for $ADVANCED_IMAGE_NAME\""},{"line_number":82,"context_line":"    if [[ -z $flavor_ref ]]; then"},{"line_number":83,"context_line":"        echo \"Found no valid flavors to use for $ADVANCED_IMAGE_NAME !\""},{"line_number":84,"context_line":"        echo \"Fallback to use $DEFAULT_INSTANCE_TYPE\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_25f1e76a","line":81,"range":{"start_line":81,"start_character":17,"end_line":81,"end_character":28},"updated":"2018-10-15 18:21:30.000000000","message":"where is num_flavors defined?","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f20b305f6963f895d6719a5f08b7c8642d40cc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    fi"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    flavor_ref\u003d$(openstack flavor show $ADVANCED_INSTANCE_TYPE -f value -c id)"},{"line_number":81,"context_line":"    echo \"Found $num_flavors flavors for $ADVANCED_IMAGE_NAME\""},{"line_number":82,"context_line":"    if [[ -z $flavor_ref ]]; then"},{"line_number":83,"context_line":"        echo \"Found no valid flavors to use for $ADVANCED_IMAGE_NAME !\""},{"line_number":84,"context_line":"        echo \"Fallback to use $DEFAULT_INSTANCE_TYPE\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_9e1da878","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":62},"in_reply_to":"3f79a3b5_a80b8e1f","updated":"2018-10-15 21:03:52.000000000","message":"Yes, my fault. I changed that function and forgot to remove this line. Sorry","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b87a9452b766898cd42f479291ab4fe31263b10","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    flavor_ref\u003d$(openstack flavor show $ADVANCED_INSTANCE_TYPE -f value -c id)"},{"line_number":81,"context_line":"    echo \"Found $num_flavors flavors for $ADVANCED_IMAGE_NAME\""},{"line_number":82,"context_line":"    if [[ -z $flavor_ref ]]; then"},{"line_number":83,"context_line":"        echo \"Found no valid flavors to use for $ADVANCED_IMAGE_NAME !\""},{"line_number":84,"context_line":"        echo \"Fallback to use $DEFAULT_INSTANCE_TYPE\""},{"line_number":85,"context_line":"        flavor_ref\u003d$(iniget $TEMPEST_CONFIG compute flavor_ref)"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_05938b01","line":82,"range":{"start_line":82,"start_character":13,"end_line":82,"end_character":24},"updated":"2018-10-15 18:21:30.000000000","message":"\"\" here too","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f20b305f6963f895d6719a5f08b7c8642d40cc","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    flavor_ref\u003d$(openstack flavor show $ADVANCED_INSTANCE_TYPE -f value -c id)"},{"line_number":81,"context_line":"    echo \"Found $num_flavors flavors for $ADVANCED_IMAGE_NAME\""},{"line_number":82,"context_line":"    if [[ -z $flavor_ref ]]; then"},{"line_number":83,"context_line":"        echo \"Found no valid flavors to use for $ADVANCED_IMAGE_NAME !\""},{"line_number":84,"context_line":"        echo \"Fallback to use $DEFAULT_INSTANCE_TYPE\""},{"line_number":85,"context_line":"        flavor_ref\u003d$(iniget $TEMPEST_CONFIG compute flavor_ref)"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_fe17fc52","line":82,"range":{"start_line":82,"start_character":13,"end_line":82,"end_character":24},"in_reply_to":"3f79a3b5_05938b01","updated":"2018-10-15 21:03:52.000000000","message":"Done","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"}],"devstack/settings":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"20d12e641ef714b2f3a7cfc13c7b8e055b9c22e9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ADVANCED_IMAGE_NAME\u003d${ADVANCED_IMAGE_NAME:-\"\"}"},{"line_number":6,"context_line":"ADVANCED_INSTANCE_TYPE\u003d${ADVANCED_INSTANCE_TYPE:-$DEFAULT_INSTANCE_TYPE}"},{"line_number":7,"context_line":"ADVANCED_INSTANCE_USER\u003d${ADVANCED_INSTANCE_USER:-$DEFAULT_INSTANCE_USER}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_16cf7f28","line":7,"updated":"2018-10-11 21:09:22.000000000","message":"In .zuul.yaml these DEFAULT_* were replaced with ADVANCED_*, why use the DEFAULT variables?  Just wondering since if ADVANCED_IMAGE_NAME isn\u0027t set the other two don\u0027t matter right?  But you would know more than me...","commit_id":"d2b2b14dcfa81cb1994332ac422ebe89a0086be3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"93486186e8060736b8c05360a3ddb7e7c2744d27","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"ADVANCED_IMAGE_NAME\u003d${ADVANCED_IMAGE_NAME:-\"\"}"},{"line_number":6,"context_line":"ADVANCED_INSTANCE_TYPE\u003d${ADVANCED_INSTANCE_TYPE:-$DEFAULT_INSTANCE_TYPE}"},{"line_number":7,"context_line":"ADVANCED_INSTANCE_USER\u003d${ADVANCED_INSTANCE_USER:-$DEFAULT_INSTANCE_USER}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_b60a4b24","line":7,"in_reply_to":"3f79a3b5_16cf7f28","updated":"2018-10-11 21:20:23.000000000","message":"in .zuul.yml I don\u0027t set DEFAULT_ values anymore as for cirros it is not necessary. Here I decided to use those DEFAULT_ values as default for ADVANCED image also because I can imagine the case that user will have different image to use as ADVANCED image but both images will have same user and will work on same flavor.\nFor INSTANCE_TYPE I think that it\u0027s completely fine but for USER I can remove default value and use empty string as default. Do You think it will be better?","commit_id":"d2b2b14dcfa81cb1994332ac422ebe89a0086be3"}],"neutron_tempest_plugin/config.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1f3dbe7508c1798e2d6e12255f153cc73bb2ce88","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               default\u003dNone,"},{"line_number":80,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"},{"line_number":81,"context_line":"                    \u0027It is image that supports features that cirros does not, \u0027"},{"line_number":82,"context_line":"                    \u0027like Ubuntu or CentOS supporting advanced features.\u0027),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027advanced_flavor_ref\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d\u0027Valid flavor to use with advanced image in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_bb620bd8","line":82,"updated":"2018-10-14 15:26:25.000000000","message":"nit: Isn\u0027t it better to use parentheses around the help string? It helps us for editor auto indent.\n\n  help\u003d(\u0027Valid ...\u0027\n        \u0027...\u0027\n        \u0027...\u0027)),","commit_id":"29813c1f21c94dc178695b91c7639858fc3d46b8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6a2a14c1ed8b00371974f28a26c5d20da52f8299","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               default\u003dNone,"},{"line_number":80,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"},{"line_number":81,"context_line":"                    \u0027It is image that supports features that cirros does not, \u0027"},{"line_number":82,"context_line":"                    \u0027like Ubuntu or CentOS supporting advanced features.\u0027),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027advanced_flavor_ref\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d\u0027Valid flavor to use with advanced image in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_0c32e45d","line":82,"in_reply_to":"3f79a3b5_bb620bd8","updated":"2018-10-15 08:44:37.000000000","message":"It is not added to any of those help messages here. And it\u0027s not necessary so I wanted to be consistent with other options and didn\u0027t add it","commit_id":"29813c1f21c94dc178695b91c7639858fc3d46b8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1f3dbe7508c1798e2d6e12255f153cc73bb2ce88","unresolved":false,"context_lines":[{"line_number":80,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"},{"line_number":81,"context_line":"                    \u0027It is image that supports features that cirros does not, \u0027"},{"line_number":82,"context_line":"                    \u0027like Ubuntu or CentOS supporting advanced features.\u0027),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027advanced_flavor_ref\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d\u0027Valid flavor to use with advanced image in tests. \u0027"},{"line_number":86,"context_line":"                    \u0027This is required if advanced image has to be used in \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_7b58f323","line":83,"updated":"2018-10-14 15:26:25.000000000","message":"I am not sure which is a better name advanced_image_flavor_ref or advance_flavor_ref because this config is to specify a flavor used for advanced_image.","commit_id":"29813c1f21c94dc178695b91c7639858fc3d46b8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6a2a14c1ed8b00371974f28a26c5d20da52f8299","unresolved":false,"context_lines":[{"line_number":80,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"},{"line_number":81,"context_line":"                    \u0027It is image that supports features that cirros does not, \u0027"},{"line_number":82,"context_line":"                    \u0027like Ubuntu or CentOS supporting advanced features.\u0027),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027advanced_flavor_ref\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d\u0027Valid flavor to use with advanced image in tests. \u0027"},{"line_number":86,"context_line":"                    \u0027This is required if advanced image has to be used in \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_2c29e0f0","line":83,"in_reply_to":"3f79a3b5_7b58f323","updated":"2018-10-15 08:44:37.000000000","message":"I think that advanced_image_flavor_ref would be better. Changed.","commit_id":"29813c1f21c94dc178695b91c7639858fc3d46b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b87a9452b766898cd42f479291ab4fe31263b10","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":79,"context_line":"               default\u003dNone,"},{"line_number":80,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"},{"line_number":81,"context_line":"                    \u0027It is image that supports features that cirros does not, \u0027"},{"line_number":82,"context_line":"                    \u0027like Ubuntu or CentOS supporting advanced features.\u0027),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027advanced_image_flavor_ref\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_458c23d7","line":81,"range":{"start_line":81,"start_character":61,"end_line":81,"end_character":67},"updated":"2018-10-15 18:21:30.000000000","message":"s/Cirros ?","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b87a9452b766898cd42f479291ab4fe31263b10","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":79,"context_line":"               default\u003dNone,"},{"line_number":80,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"},{"line_number":81,"context_line":"                    \u0027It is image that supports features that cirros does not, \u0027"},{"line_number":82,"context_line":"                    \u0027like Ubuntu or CentOS supporting advanced features.\u0027),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027advanced_image_flavor_ref\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_8586bbb9","line":81,"range":{"start_line":81,"start_character":27,"end_line":81,"end_character":32},"updated":"2018-10-15 18:21:30.000000000","message":"s/an image","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f20b305f6963f895d6719a5f08b7c8642d40cc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":79,"context_line":"               default\u003dNone,"},{"line_number":80,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"},{"line_number":81,"context_line":"                    \u0027It is image that supports features that cirros does not, \u0027"},{"line_number":82,"context_line":"                    \u0027like Ubuntu or CentOS supporting advanced features.\u0027),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027advanced_image_flavor_ref\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_1900d2ff","line":81,"range":{"start_line":81,"start_character":61,"end_line":81,"end_character":67},"in_reply_to":"3f79a3b5_458c23d7","updated":"2018-10-15 21:03:52.000000000","message":"Done","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3f20b305f6963f895d6719a5f08b7c8642d40cc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":79,"context_line":"               default\u003dNone,"},{"line_number":80,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"},{"line_number":81,"context_line":"                    \u0027It is image that supports features that cirros does not, \u0027"},{"line_number":82,"context_line":"                    \u0027like Ubuntu or CentOS supporting advanced features.\u0027),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027advanced_image_flavor_ref\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_b902fe06","line":81,"range":{"start_line":81,"start_character":27,"end_line":81,"end_character":32},"in_reply_to":"3f79a3b5_8586bbb9","updated":"2018-10-15 21:03:52.000000000","message":"Done","commit_id":"cd77c500308b1d35fe4238057cc63573c2c32fcb"}]}