)]}'
{"neutron_tempest_plugin/scenario/test_security_groups.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee4deb3d13c9bf271af1f920adeb3fc282212c7d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":104,"context_line":"            \u0027fixed_ip_address\u0027], should_succeed\u003dshould_succeed)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @utils.unstable_test(\"It is suspected to produce a race condition\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9fe9bf83","line":106,"updated":"2018-11-02 02:31:35.000000000","message":"this decorator is typically used with a bug number, all other occurrences are \"bug #######\".  Also, it would be best to open a bug describing the issue.","commit_id":"a727a4ac44044594f1eaa9722bfe05eaba39e8ad"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"cadc26834b0a2a80651dc682946694fe95aaec35","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":104,"context_line":"            \u0027fixed_ip_address\u0027], should_succeed\u003dshould_succeed)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @utils.unstable_test(\"It is suspected to produce a race condition\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_8b10a15a","line":106,"in_reply_to":"3f79a3b5_9fe9bf83","updated":"2018-11-02 07:27:49.000000000","message":"Done","commit_id":"a727a4ac44044594f1eaa9722bfe05eaba39e8ad"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee4deb3d13c9bf271af1f920adeb3fc282212c7d","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @utils.unstable_test(\"It is suspected to produce a race condition\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"},{"line_number":110,"context_line":"        # Check ssh connectivity when you add sec group rule, enabling ssh"},{"line_number":111,"context_line":"        self.create_loginable_secgroup_rule("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_bfc35b05","line":108,"updated":"2018-11-02 02:31:35.000000000","message":"Does this test suffer from the same issue as the below test?","commit_id":"a727a4ac44044594f1eaa9722bfe05eaba39e8ad"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"cadc26834b0a2a80651dc682946694fe95aaec35","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @utils.unstable_test(\"It is suspected to produce a race condition\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"},{"line_number":110,"context_line":"        # Check ssh connectivity when you add sec group rule, enabling ssh"},{"line_number":111,"context_line":"        self.create_loginable_secgroup_rule("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0b2331bd","line":108,"in_reply_to":"3f79a3b5_4b97e938","updated":"2018-11-02 07:27:49.000000000","message":"Done","commit_id":"a727a4ac44044594f1eaa9722bfe05eaba39e8ad"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"22120e9452f18801a200c2bf751fa2a09714449e","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @utils.unstable_test(\"It is suspected to produce a race condition\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"},{"line_number":110,"context_line":"        # Check ssh connectivity when you add sec group rule, enabling ssh"},{"line_number":111,"context_line":"        self.create_loginable_secgroup_rule("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4b97e938","line":108,"in_reply_to":"3f79a3b5_bfc35b05","updated":"2018-11-02 07:06:10.000000000","message":"These bugs are related: they both use the default security group and change it. Doing it is wrong because it could produce failures in other tests later, so test_default_sec_grp_scenarios shouldn\u0027t been have written at all.\n\nThe second test (test_protocol_number_rule) is not targeted to default security group, but it randomly takes it instead of its security group, so I fixed it and it should stop failing.","commit_id":"a727a4ac44044594f1eaa9722bfe05eaba39e8ad"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b5838850bfd2e8eee4cd079f65db8ec036cc67e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":104,"context_line":"            \u0027fixed_ip_address\u0027], should_succeed\u003dshould_succeed)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @utils.unstable_test(\"Bug #1801306\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1976f60c","line":106,"updated":"2018-11-05 16:46:25.000000000","message":"so if this patch closes this bug, why You still use \"unstable_test\" decorator?","commit_id":"659ec591d6a7d9ede311816cd40ebdec972c192c"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"69043f7250f86be4319654c38debfff330265d33","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":104,"context_line":"            \u0027fixed_ip_address\u0027], should_succeed\u003dshould_succeed)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @utils.unstable_test(\"Bug #1801306\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5971bfde","line":106,"in_reply_to":"3f79a3b5_1976f60c","updated":"2018-11-06 07:57:12.000000000","message":"I realized the actual fix is in the other test, but I am still not sure this test is going to succeed. Anyway is better I refactor it because this test is doing something wrong anyway: changing default security group.","commit_id":"659ec591d6a7d9ede311816cd40ebdec972c192c"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"dfeb67801dba2ccae7a1d5da947cb3c8cb23d797","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":104,"context_line":"            \u0027fixed_ip_address\u0027], should_succeed\u003dshould_succeed)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @testtools.skip(\"Bug #1801306\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_966aaf15","line":106,"range":{"start_line":106,"start_character":15,"end_line":106,"end_character":19},"updated":"2018-11-06 22:05:56.000000000","message":"I have several questions on this:\n\n* Why this is being skipped. Could we at least mention the reason in the commit message?\n* IMHO, it is better to do this in a separated patch so that it can be reverted without touching change in \u0027test_protocol_number_rule\u0027.","commit_id":"b78a311558bb340ac8ddb485e3a9fa1afc508193"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"9380a27b91904e4e14ac2b5240341954708ace23","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":104,"context_line":"            \u0027fixed_ip_address\u0027], should_succeed\u003dshould_succeed)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @testtools.skip(\"Bug #1801306\")"},{"line_number":107,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d764\u0027)"},{"line_number":108,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":109,"context_line":"        server_ssh_clients, fips, _ \u003d self.create_vm_testing_sec_grp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_2b0a5128","line":106,"range":{"start_line":106,"start_character":15,"end_line":106,"end_character":19},"in_reply_to":"3f79a3b5_966aaf15","updated":"2018-11-07 06:35:56.000000000","message":"The operation at line 112 should never be execute because it could alter the result of other tests of the same class. Any test should change the state of shared resources. Default security group is a shared resource created when the project shared by the test cases in this test class. If during test execution it changes, the initial state of test method executed after this could have a different result. This is a potential source of false positive or false negative, even if I didn\u0027t know if it actually happened some error because of this test case. The other test case method (test_protocol_number_rule) instead has been fixed and yes it is know to fail 50% of the time and not because of this one.","commit_id":"b78a311558bb340ac8ddb485e3a9fa1afc508193"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a57d2a30a070e68dc15e25075c27634570683b06","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        security_group_name \u003d data_utils.rand_name(\"test_protocol_number_rule\")"},{"line_number":143,"context_line":"        security_group \u003d self.create_security_group(name\u003dsecurity_group_name)"},{"line_number":144,"context_line":"        _, fips, _ \u003d self.create_vm_testing_sec_grp("},{"line_number":145,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: security_group_name}])"},{"line_number":146,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":147,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":148,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_136c71cd","line":145,"range":{"start_line":145,"start_character":44,"end_line":145,"end_character":73},"updated":"2018-11-06 20:48:47.000000000","message":"nit: You can use id here instead of name also :)","commit_id":"b78a311558bb340ac8ddb485e3a9fa1afc508193"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"a205e2d0b6c54e732893ba45aa5f7ffd7ad3dac8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        security_group_name \u003d data_utils.rand_name(\"test_protocol_number_rule\")"},{"line_number":143,"context_line":"        security_group \u003d self.create_security_group(name\u003dsecurity_group_name)"},{"line_number":144,"context_line":"        _, fips, _ \u003d self.create_vm_testing_sec_grp("},{"line_number":145,"context_line":"            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: security_group_name}])"},{"line_number":146,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":147,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":148,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_6e95b793","line":145,"range":{"start_line":145,"start_character":44,"end_line":145,"end_character":73},"in_reply_to":"3f79a3b5_136c71cd","updated":"2018-11-07 06:50:40.000000000","message":"Using {\u0027id\u0027: security_group[\u0027id\u0027]} I get below error:\n\n  tempest.lib.exceptions.BadRequest: Bad request\n  Details:\n  {\u0027message\u0027: \"Invalid input for field/attribute 0.\n               Value: {u\u0027id\u0027: u\u002754ea1537-3860-4c0f-b7e6-9ea65108bc82\u0027}.\n               Additional properties are not allowed (u\u0027id\u0027 was unexpected)\",\n   \u0027code\u0027: 400}","commit_id":"b78a311558bb340ac8ddb485e3a9fa1afc508193"}]}