)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"d4a77353475c192a4a00eea990cfe3dd54970f3e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"have CI systems which don\u0027t use devstack and don\u0027t have easy way to"},{"line_number":14,"context_line":"load another \"advanced\" image and use it for those tests."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So now this patch adds one ore config option \"default_image_is_advanced\""},{"line_number":17,"context_line":"which has boolean value and defaults to False."},{"line_number":18,"context_line":"If this is set to True, tests which require advanced image will not be"},{"line_number":19,"context_line":"skipped and default image will be used for those tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ffb9cba7_e15f01e3","line":16,"range":{"start_line":16,"start_character":23,"end_line":16,"end_character":30},"updated":"2019-04-23 11:11:34.000000000","message":"nit: one more","commit_id":"fa1081ad9f607b7a45a406eca7fbf48de206409b"}],"neutron_tempest_plugin/config.py":[{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"b2eca4d3c161712ab705dd854f84a57f3a4aad07","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":76,"context_line":"    # used in tests which require some more advanced tool than available in"},{"line_number":77,"context_line":"    # Cirros"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027image_is_advanced\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_eec46744","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":71},"updated":"2018-11-23 07:15:54.000000000","message":"I think this is not necessary as long the user can set the same parameters for both advanced and not advanced images. This is just complicating the things and it could create confusion: which image is advanced? The advanced image or the other? I would rather put something like:\ndefault_image_is_cirros (true by default). The control logic in the code has to interpret it (eventually for example when it has to execute ping command for IPv6 or disable ping message fragmentation or not.","commit_id":"8fcc5fcab0631ce2e2bd23f3df461593dc7efb43"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ddca8ad3cc986802b941a0883048c0cf6568cd48","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":76,"context_line":"    # used in tests which require some more advanced tool than available in"},{"line_number":77,"context_line":"    # Cirros"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027image_is_advanced\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8ea5a1b5","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":71},"in_reply_to":"3f79a3b5_11d30265","updated":"2018-11-25 13:24:56.000000000","message":"On one deployment we are running many tests, better to have simple way to run neutron tests, as Regression w/o ansible adoc commands","commit_id":"8fcc5fcab0631ce2e2bd23f3df461593dc7efb43"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6bd0bf92f57bb0edbb7d85c73d41f03ca33872b7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":76,"context_line":"    # used in tests which require some more advanced tool than available in"},{"line_number":77,"context_line":"    # Cirros"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027image_is_advanced\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_11d30265","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":71},"in_reply_to":"3f79a3b5_eec46744","updated":"2018-11-23 08:21:47.000000000","message":"+1 to what Federico said. I can\u0027t understand why You want to introduce again old option instead of tune tempest.conf file in Your CI job.","commit_id":"8fcc5fcab0631ce2e2bd23f3df461593dc7efb43"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ddca8ad3cc986802b941a0883048c0cf6568cd48","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # Options for special, \"advanced\" image like e.g. Ubuntu. Such image can be"},{"line_number":76,"context_line":"    # used in tests which require some more advanced tool than available in"},{"line_number":77,"context_line":"    # Cirros"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027image_is_advanced\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ce9f1962","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":71},"in_reply_to":"3f79a3b5_eec46744","updated":"2018-11-25 13:24:56.000000000","message":"So, From your words, renaming this parameter from image_is_advanced -\u003e default_image_is_cirros(default True)\n\nAck","commit_id":"8fcc5fcab0631ce2e2bd23f3df461593dc7efb43"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"b2eca4d3c161712ab705dd854f84a57f3a4aad07","unresolved":false,"context_lines":[{"line_number":100,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"},{"line_number":101,"context_line":"# transition to the Tempest plugin architecture"},{"line_number":102,"context_line":"for opt in NeutronPluginOptions:"},{"line_number":103,"context_line":"    if CONF.neutron_plugin_options.image_is_advanced:"},{"line_number":104,"context_line":"        if opt.name \u003d\u003d \u0027advanced_image_ref\u0027 and opt.default is None:"},{"line_number":105,"context_line":"            opt.default \u003d CONF.compute.image_ref"},{"line_number":106,"context_line":"        if opt.name \u003d\u003d \u0027advanced_image_flavor_ref\u0027 and opt.default is None:"},{"line_number":107,"context_line":"            opt.default \u003d CONF.compute.flavor_ref"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    CONF.register_opt(opt, \u0027neutron_plugin_options\u0027)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ceb72bd1","line":107,"range":{"start_line":103,"start_character":4,"end_line":107,"end_character":49},"updated":"2018-11-23 07:15:54.000000000","message":"I don\u0027t think this is required. I would prefer a more intelligent code in test cases that would use non-advanced image or advance image depending on the requirements of the test case. Lets keep configuration as a simple data model and move complexity to the the control side that consumes this data model. I say this because this could create confusion in some tests where it is expected to skip, but it is not skipping.","commit_id":"8fcc5fcab0631ce2e2bd23f3df461593dc7efb43"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"ddca8ad3cc986802b941a0883048c0cf6568cd48","unresolved":false,"context_lines":[{"line_number":100,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"},{"line_number":101,"context_line":"# transition to the Tempest plugin architecture"},{"line_number":102,"context_line":"for opt in NeutronPluginOptions:"},{"line_number":103,"context_line":"    if CONF.neutron_plugin_options.image_is_advanced:"},{"line_number":104,"context_line":"        if opt.name \u003d\u003d \u0027advanced_image_ref\u0027 and opt.default is None:"},{"line_number":105,"context_line":"            opt.default \u003d CONF.compute.image_ref"},{"line_number":106,"context_line":"        if opt.name \u003d\u003d \u0027advanced_image_flavor_ref\u0027 and opt.default is None:"},{"line_number":107,"context_line":"            opt.default \u003d CONF.compute.flavor_ref"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    CONF.register_opt(opt, \u0027neutron_plugin_options\u0027)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_cebab9de","line":107,"range":{"start_line":103,"start_character":4,"end_line":107,"end_character":49},"in_reply_to":"3f79a3b5_ceb72bd1","updated":"2018-11-25 13:24:56.000000000","message":"BTW, no one run this test, as per today in CI AFAIK for z Releases\n\nSecond, this one is non intelligent correct, but avoid extra CI work, before running this test, especially when working out of DevStack\n\nI would prefer to have automatic way if !CONF.neutron_plugin_options.default_image_is_cirros \n\nDo you suggest doing that in test?","commit_id":"8fcc5fcab0631ce2e2bd23f3df461593dc7efb43"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2c7751fe9596c19129da29f6ae55d3068f0c4f77","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_a43c20ea","line":81,"updated":"2018-11-27 08:39:48.000000000","message":"I still can\u0027t understand why You can\u0027t simply set in Your CI advanced_image_ref and advanced_image_flavor_ref to be the same as image and flavor config options but if others will be fine with that change, I will no be strongly against","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"f9c9298ff6f53b49593ef0dacfa08504e061868d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_6cf9ea19","line":81,"in_reply_to":"3f79a3b5_0aa38b9d","updated":"2018-11-28 17:24:37.000000000","message":"@HongbinLu, It took me some time to Understand, but you are actually suggesting work w/ alternate_image, that is cool\n\nbut the test we are dealing requires \n\nCONF.neutron_plugin_options.advanced_image_ref \n    def test_subport_connectivity(self):\n\nWhats your take here? \nThe Decorator should be replaced?\nUse the image_is_advanced? and check if there alt_image_ref\n  alt_flavor_ref are not Empty? in  _create_server_with_fip?","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"9492a615ae6b40e19f662485ab8099a617664c9c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_703a2996","line":81,"in_reply_to":"3f79a3b5_0aa38b9d","updated":"2018-11-28 06:14:45.000000000","message":"Thanks @HongbinLu I think the extra parameter suggested is enough. This way neutron CI stays as is, and since the default_ci_cirros will be set to True in NFV CI, we fulfill all requirements","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e4ef97a982ba93a1a644bef5d5dc6b6a8eb706c8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_37f0f593","line":81,"in_reply_to":"3f79a3b5_0daff4e1","updated":"2018-11-30 08:18:52.000000000","message":"I know. It\u0027s one of the 2 hardest things in programming :)\nAnd I like that idea to rename it to something like \"second_image_ref\" and add flags to point which image is advanced.","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"e723e18aaa7d587065546d72e4656fdec8d97f7f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_676ea366","line":81,"in_reply_to":"3f79a3b5_37f0f593","updated":"2018-12-02 15:20:28.000000000","message":"That\u0027s interesting, one line patch :) cause a real dilemma.\nAny way i would like to use naming convention but from your comment it is just naming issue, since we have it right now.\nFor NFV CI we do not want to use uuid for the \"advances parameters\".\n\nI think that using image_is_advanced with current advanced variables is enough see patch number#2","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"f0d7c061dc0b5a4e45fb7f864539a060900e6ea1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0daff4e1","line":81,"in_reply_to":"3f79a3b5_4067f4ba","updated":"2018-11-29 23:41:12.000000000","message":"I was talking about the second option. You are right. The naming caused confusion. Maybe \"second_image_ref\", \"alternate_image_ref\" or others (I am not really good at naming).","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"03ac1307619fa4e236ed611f1a5cffa392315ce1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4067f4ba","line":81,"in_reply_to":"3f79a3b5_4efbb779","updated":"2018-11-29 21:55:30.000000000","message":"@Hongbin: are You talking about image_ref_alt option from tempest or about introducing new option \"alt_image_ref\" in place of current \"advanced_image_ref\"?\nIf it\u0027s about this first option (using tempest\u0027s \"image_ref_alt\") then I don\u0027t think it\u0027s good idea because this option is used in tempest for some other tests like resize or things like that. So I don\u0027t want to use it here differently to not break something else maybe in some tempest-full job or something like that.\n\nIf You were talking about second option, I think it isn\u0027t bad, but maybe some other name instead of \"alt_image_ref\" should be used to not confuse it with tempest\u0027s image_ref_alt option.","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"588bc72e19cb681711c0d7438f01129cee8d9e26","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_82b9adeb","line":81,"in_reply_to":"3f79a3b5_6cf9ea19","updated":"2018-11-28 18:56:47.000000000","message":"@Yariv,\n\nLet\u0027s wait for the consensus to be made before proceeding with a specific approach. I am not sure if other reviewers will agree with what I was suggesting yet.\n\nThe approach I was thinking is to do a simple renaming (from advanced_image_ref to alt_image_ref) without touching the actual testing logic. Therefore, the test you mentioned would be checking CONF.neutron_plugin_options.alt_image_ref instead. However, keep in mind that there might be a better approach.","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6d0aa2a4f595c1fff3ba53178f5a39f54cd37faf","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4efbb779","line":81,"in_reply_to":"3f79a3b5_82b9adeb","updated":"2018-11-29 09:05:48.000000000","message":"@Fede? @Slawek? @Daniel? whats your take?\nI have to admit i like the idea Yariv +1","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"88b4a70a5d7f492d63f675aaf3b0d07f1f82a346","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027default_image_is_cirros\u0027,"},{"line_number":79,"context_line":"                default\u003dTrue,"},{"line_number":80,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":81,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":83,"context_line":"               default\u003dNone,"},{"line_number":84,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0aa38b9d","line":81,"in_reply_to":"3f79a3b5_a43c20ea","updated":"2018-11-27 23:10:11.000000000","message":"Per my understanding of @Yariv Rachmani\u0027s opinion is that his CI needs one set of such config: image+flavor+ssh_user but the advanced image patch [1] proposes two and also assumes that the first one is for non-advanced image and the second one is for advanced image.\n\nIMHO, a more elegant solution that can satisfy @Yariv Rachmani\u0027s requirement is to avoid making assumption that which one is advanced and which one is not. Therefore, the configs could be:\n\n  image_ref\n  image_flavor_ref\n  image_ssh_user\n  image_is_advanced\n\n  alt_image_ref\n  alt_flavor_ref\n  alt_ssh_user\n  alt_image_is_advanced\n\nIn the case of @Yariv Rachmani, he can set the first set of configs and leave the second empty. In the case of neutron tempest tests, we populate two and mark the first one as non-advanced and the second one as advanced.\n\nThoughts on this?\n\n[1] https://review.openstack.org/#/c/609762/16","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3021d8dfbf75189dc45d4302fb44e8853502eb27","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # Cirros"},{"line_number":89,"context_line":"    cfg.BoolOpt(\u0027default_image_is_advanced\u0027,"},{"line_number":90,"context_line":"                default\u003dFalse,"},{"line_number":91,"context_line":"                help\u003d\u0027Default image that supports is an image which supports \u0027"},{"line_number":92,"context_line":"                     \u0027features that Cirros does not, like Ubuntu or CentOS \u0027"},{"line_number":93,"context_line":"                     \u0027supporting advanced features. \u0027"},{"line_number":94,"context_line":"                     \u0027If this is set to True, \"advanced_image_ref\" option \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_38d9d782","line":91,"range":{"start_line":91,"start_character":22,"end_line":91,"end_character":52},"updated":"2019-04-11 19:20:18.000000000","message":"s/Default image is ...","commit_id":"130a6aae1fea282f518d8466887f63c3144a5347"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e337d8d517b68550155df220187cc2cc769be5d8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # Cirros"},{"line_number":89,"context_line":"    cfg.BoolOpt(\u0027default_image_is_advanced\u0027,"},{"line_number":90,"context_line":"                default\u003dFalse,"},{"line_number":91,"context_line":"                help\u003d\u0027Default image that supports is an image which supports \u0027"},{"line_number":92,"context_line":"                     \u0027features that Cirros does not, like Ubuntu or CentOS \u0027"},{"line_number":93,"context_line":"                     \u0027supporting advanced features. \u0027"},{"line_number":94,"context_line":"                     \u0027If this is set to True, \"advanced_image_ref\" option \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_93dc6c19","line":91,"range":{"start_line":91,"start_character":22,"end_line":91,"end_character":52},"in_reply_to":"3fce034c_38d9d782","updated":"2019-04-11 20:17:07.000000000","message":"Done","commit_id":"130a6aae1fea282f518d8466887f63c3144a5347"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3021d8dfbf75189dc45d4302fb44e8853502eb27","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                     \u0027features that Cirros does not, like Ubuntu or CentOS \u0027"},{"line_number":93,"context_line":"                     \u0027supporting advanced features. \u0027"},{"line_number":94,"context_line":"                     \u0027If this is set to True, \"advanced_image_ref\" option \u0027"},{"line_number":95,"context_line":"                     \u0027is not necessary to be set.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":97,"context_line":"               default\u003dNone,"},{"line_number":98,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_58cb83a4","line":95,"range":{"start_line":95,"start_character":29,"end_line":95,"end_character":38},"updated":"2019-04-11 19:20:18.000000000","message":"s/required","commit_id":"130a6aae1fea282f518d8466887f63c3144a5347"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e337d8d517b68550155df220187cc2cc769be5d8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                     \u0027features that Cirros does not, like Ubuntu or CentOS \u0027"},{"line_number":93,"context_line":"                     \u0027supporting advanced features. \u0027"},{"line_number":94,"context_line":"                     \u0027If this is set to True, \"advanced_image_ref\" option \u0027"},{"line_number":95,"context_line":"                     \u0027is not necessary to be set.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027advanced_image_ref\u0027,"},{"line_number":97,"context_line":"               default\u003dNone,"},{"line_number":98,"context_line":"               help\u003d\u0027Valid advanced image uuid to be used in tests. \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_53e604eb","line":95,"range":{"start_line":95,"start_character":29,"end_line":95,"end_character":38},"in_reply_to":"3fce034c_58cb83a4","updated":"2019-04-11 20:17:07.000000000","message":"Done","commit_id":"130a6aae1fea282f518d8466887f63c3144a5347"}],"neutron_tempest_plugin/scenario/test_mtu.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3021d8dfbf75189dc45d4302fb44e8853502eb27","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if self.use_advanced_image:"},{"line_number":119,"context_line":"            username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"},{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            username \u003d CONF.validation.image_ssh_user"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        server_ssh_client1 \u003d ssh.Client("},{"line_number":124,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_585943fc","line":121,"updated":"2019-04-11 19:20:18.000000000","message":"Is it worth it to set cls.username in resource_setup() ?","commit_id":"130a6aae1fea282f518d8466887f63c3144a5347"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e337d8d517b68550155df220187cc2cc769be5d8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if self.use_advanced_image:"},{"line_number":119,"context_line":"            username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"},{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            username \u003d CONF.validation.image_ssh_user"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        server_ssh_client1 \u003d ssh.Client("},{"line_number":124,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fce034c_73eb00b0","line":121,"in_reply_to":"3fce034c_585943fc","updated":"2019-04-11 20:17:07.000000000","message":"Done","commit_id":"130a6aae1fea282f518d8466887f63c3144a5347"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a2f8d4449a41e38ae98f47197623fe3f75083e03","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        if self.use_advanced_image:"},{"line_number":217,"context_line":"            self.username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            self.username \u003d CONF.validation.image_ssh_user"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        server_ssh_client1 \u003d ssh.Client("},{"line_number":222,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fce034c_ea0da737","line":219,"updated":"2019-04-12 14:00:27.000000000","message":"Isn\u0027t this already set in resource_setup() ?","commit_id":"f286b69d4dbeca0408e6afbc21730d5dccef4eef"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"98220abcfc2ce24df0206feea95e1fb6df7d8f09","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        if self.use_advanced_image:"},{"line_number":217,"context_line":"            self.username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            self.username \u003d CONF.validation.image_ssh_user"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        server_ssh_client1 \u003d ssh.Client("},{"line_number":222,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fce034c_f7ffbc64","line":219,"in_reply_to":"3fce034c_ea0da737","updated":"2019-04-14 08:57:36.000000000","message":"+1, you are correct\nThe hole if is done there","commit_id":"f286b69d4dbeca0408e6afbc21730d5dccef4eef"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fc55dee7aaee7915b9a78f37ec059fe4464bc3da","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        if self.use_advanced_image:"},{"line_number":217,"context_line":"            self.username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            self.username \u003d CONF.validation.image_ssh_user"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        server_ssh_client1 \u003d ssh.Client("},{"line_number":222,"context_line":"            self.floating_ips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fce034c_ee04c27d","line":219,"in_reply_to":"3fce034c_f7ffbc64","updated":"2019-04-18 08:56:17.000000000","message":"Exactly. Too many things doing at once :/ Sorry for that.","commit_id":"f286b69d4dbeca0408e6afbc21730d5dccef4eef"}],"neutron_tempest_plugin/scenario/test_trunk.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"84b6d91f2da354b9254d32da6957ac969f436be7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image:"},{"line_number":73,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":74,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":75,"context_line":"        return ("},{"line_number":76,"context_line":"            self.create_server("},{"line_number":77,"context_line":"                flavor_ref\u003dflavor_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c745f073","side":"PARENT","line":74,"updated":"2018-11-21 11:05:25.000000000","message":"can You explain why You removed that? Some trunk tests needs to use advanced image as they can\u0027t run properly on cirros","commit_id":"6f9bb77d9872a1cac4e1815ce13d97b8a143b3a8"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"1cb3135114bb640eac9afac68b76765ebc9a81f1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image:"},{"line_number":73,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":74,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":75,"context_line":"        return ("},{"line_number":76,"context_line":"            self.create_server("},{"line_number":77,"context_line":"                flavor_ref\u003dflavor_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_abc67a13","side":"PARENT","line":74,"in_reply_to":"3f79a3b5_8a4cdf74","updated":"2018-11-21 16:33:52.000000000","message":"Trunk test are running in our CI and not skipped as per u/s","commit_id":"6f9bb77d9872a1cac4e1815ce13d97b8a143b3a8"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"32d2462ecfccc383c9203d930932adada2b8888c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image:"},{"line_number":73,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":74,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":75,"context_line":"        return ("},{"line_number":76,"context_line":"            self.create_server("},{"line_number":77,"context_line":"                flavor_ref\u003dflavor_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ad03f50a","side":"PARENT","line":74,"in_reply_to":"3f79a3b5_8a4cdf74","updated":"2018-11-21 12:07:25.000000000","message":"You have to configure tempest.conf to use the advanced image you have by setting below options:\n\n[neutron_plugin_options]\nadvanced_image_flavor_ref \u003d \u003cyour flavor ID\u003e\nadvanced_image_ref \u003d \u003cyour image ID\u003e\nadvanced_image_ssh_user \u003d \u003cthe user name for this image\u003e\n\nThe reason is we saw most of the test are fine with using CirrOS images, but really few of them are not. For example trunk ports don\u0027t work with CirrOS images, therefore we do need another more advance distro on this specific case (like RHEL, CentOS, Ubuntu, etc.).","commit_id":"6f9bb77d9872a1cac4e1815ce13d97b8a143b3a8"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"1cb3135114bb640eac9afac68b76765ebc9a81f1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image:"},{"line_number":73,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":74,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":75,"context_line":"        return ("},{"line_number":76,"context_line":"            self.create_server("},{"line_number":77,"context_line":"                flavor_ref\u003dflavor_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0bef6e86","side":"PARENT","line":74,"in_reply_to":"3f79a3b5_ad03f50a","updated":"2018-11-21 16:33:52.000000000","message":"Ack, changing my strategy please see updated comment in next patch","commit_id":"6f9bb77d9872a1cac4e1815ce13d97b8a143b3a8"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"60066ebb539145265b79e4b74888fe86e297ff58","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image:"},{"line_number":73,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":74,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":75,"context_line":"        return ("},{"line_number":76,"context_line":"            self.create_server("},{"line_number":77,"context_line":"                flavor_ref\u003dflavor_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8a4cdf74","side":"PARENT","line":74,"in_reply_to":"3f79a3b5_c745f073","updated":"2018-11-21 11:12:16.000000000","message":"++ We need this for trunk tests :)","commit_id":"6f9bb77d9872a1cac4e1815ce13d97b8a143b3a8"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"1cb3135114bb640eac9afac68b76765ebc9a81f1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image:"},{"line_number":73,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":74,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":75,"context_line":"        return ("},{"line_number":76,"context_line":"            self.create_server("},{"line_number":77,"context_line":"                flavor_ref\u003dflavor_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ebc0f2fb","side":"PARENT","line":74,"in_reply_to":"3f79a3b5_c745f073","updated":"2018-11-21 16:33:52.000000000","message":"Please see patch comment update on next patch","commit_id":"6f9bb77d9872a1cac4e1815ce13d97b8a143b3a8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9f93aa80b27be6d4315db04c558d46303126b1bf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image and CONF.\\"},{"line_number":73,"context_line":"                neutron_plugin_options.advanced_image_flavor_ref:"},{"line_number":74,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":75,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":76,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7a7026dc","line":73,"updated":"2018-11-21 21:23:21.000000000","message":"which exactly test is failing for You?\nSee e.g. in L224 - test which needs this advanced image should be skipped if there is no advanced image. If You provided advanced_image_ref in Your config but You didn\u0027t provide advanced_image_flavor_ref it\u0027s issue in Your config and You should fix it there IMO.","commit_id":"208263a5bad6cfd79bc931f443f2b6339070c273"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"253c17037c6977ac42dfe760ed475d9303b3bb0c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image and CONF.\\"},{"line_number":73,"context_line":"                neutron_plugin_options.advanced_image_flavor_ref:"},{"line_number":74,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":75,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":76,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_532d0943","line":73,"in_reply_to":"3f79a3b5_40ff71b0","updated":"2018-11-22 14:50:05.000000000","message":"Think of automation process, it is dirty,\n1) need to run python. tempest-config, have compute parameters\n2) find the parameters in the tempest.conf\n3) copy value to advanced, param, on the file\n\nIs this how you prefer to build your jobs ;)\n\nI suggest here, \n\n1)restore the deleted parameter from neutron_options.use_advanced_image_ref !\u003d None\nAnd this if status is valid\n\n2)like i suggest, here, -\u003e currently ugly, but more than option 1\n\nThis test is running in OVS+DPDK continuously, it is neutron tests running constantly in NFV CI,\n\nTry collaborating here :)","commit_id":"208263a5bad6cfd79bc931f443f2b6339070c273"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"086c156202e7a9d4cbde35180787e3034561a150","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image and CONF.\\"},{"line_number":73,"context_line":"                neutron_plugin_options.advanced_image_flavor_ref:"},{"line_number":74,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":75,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":76,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d6d34762","line":73,"in_reply_to":"3f79a3b5_532d0943","updated":"2018-11-22 15:57:20.000000000","message":"Adding new patch w/ another solution","commit_id":"208263a5bad6cfd79bc931f443f2b6339070c273"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19ddbe7f30b0d2c15c1f1714c6c27ff40ba8b7dd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image and CONF.\\"},{"line_number":73,"context_line":"                neutron_plugin_options.advanced_image_flavor_ref:"},{"line_number":74,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":75,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":76,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_40ff71b0","line":73,"in_reply_to":"3f79a3b5_6acdb159","updated":"2018-11-22 13:56:28.000000000","message":"IMO more clean solution would be if You would set in config of Your job same image and flavor which You are using in compute images and flavor as \"advanced_image\" and \"advanced_flavor\" in this neutron related settings.","commit_id":"208263a5bad6cfd79bc931f443f2b6339070c273"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"6c66f58d03d1504af7f19047d757de8be3620eb4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":71,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":72,"context_line":"        if use_advanced_image and CONF.\\"},{"line_number":73,"context_line":"                neutron_plugin_options.advanced_image_flavor_ref:"},{"line_number":74,"context_line":"            flavor_ref \u003d CONF.neutron_plugin_options.advanced_image_flavor_ref"},{"line_number":75,"context_line":"            image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":76,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6acdb159","line":73,"in_reply_to":"3f79a3b5_7a7026dc","updated":"2018-11-22 09:20:41.000000000","message":"This test does not take under consideration that compute images and flavors are advanced, this way no need to change a thing but the test could run,\nSince the patch mentioned in the commit message removed the indicator for advanced images and added new attributes, NFV tests running already by defaults w/ Centos/Ubuntu images by default\nAny suggestions here?","commit_id":"208263a5bad6cfd79bc931f443f2b6339070c273"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"b2eca4d3c161712ab705dd854f84a57f3a4aad07","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @testtools.skipUnless("},{"line_number":223,"context_line":"          CONF.neutron_plugin_options.image_is_advanced,"},{"line_number":224,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":225,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":226,"context_line":"    def test_subport_connectivity(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0ec7633f","line":223,"range":{"start_line":223,"start_character":10,"end_line":223,"end_character":55},"updated":"2018-11-23 07:15:54.000000000","message":"Why this test doesn´t checks for advanced image parameters instead of basic image ones? I don\u0027t understand why the solution implemented into master brunch doesn\u0027t work here for you.\n\nYou can duplicate advance image and non advance image parameters into tempest.conf and you have both advanced, if you need. It is a simpler and easy to predict costumer behavior.\n\nI suggest below solution:\n\n- skip if advanced image is not given\n- modify this test to spawn server using advanced image parameters\n- set advanced image parameters in tempest.conf (they can be the same as the other image if you want).\n\nThere is nowhere the assumption default image is not advanced. Only the tests required advance image should care about using advanced image parameters, all the other should use default image, that could be advanced or not (it simply doesn\u0027t matter).","commit_id":"8fcc5fcab0631ce2e2bd23f3df461593dc7efb43"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2c7751fe9596c19129da29f6ae55d3068f0c4f77","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @testtools.skipUnless("},{"line_number":224,"context_line":"          CONF.neutron_plugin_options.advanced_image_ref,"},{"line_number":225,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":226,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":227,"context_line":"    def test_subport_connectivity(self):"},{"line_number":228,"context_line":"        vlan_tag \u003d 10"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2477b0d4","line":225,"updated":"2018-11-27 08:39:48.000000000","message":"So now this skip condition should be also changed as it can run if there is no advanced_image_ref but default_image_is_cirros \u003d\u003d False\n\nAnd same change should be done also for other places where this advanced_image_ref is used","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"1b3dd478f2436f8cc73b207b4a868c644898f490","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @testtools.skipUnless("},{"line_number":224,"context_line":"          CONF.neutron_plugin_options.advanced_image_ref,"},{"line_number":225,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":226,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":227,"context_line":"    def test_subport_connectivity(self):"},{"line_number":228,"context_line":"        vlan_tag \u003d 10"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_d011bdfa","line":225,"in_reply_to":"3f79a3b5_2477b0d4","updated":"2018-11-28 06:25:30.000000000","message":"Ack","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"8dfd908ab7c7421b42c1f0da607b67573925d90c","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @testtools.skipUnless("},{"line_number":224,"context_line":"          CONF.neutron_plugin_options.advanced_image_ref,"},{"line_number":225,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":226,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":227,"context_line":"    def test_subport_connectivity(self):"},{"line_number":228,"context_line":"        vlan_tag \u003d 10"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_e569afbe","line":225,"in_reply_to":"3f79a3b5_2477b0d4","updated":"2018-11-27 12:24:07.000000000","message":"Since tempest is working with flavor-ids and image-ids\nThere is a need to run neutron-tempest only after tempest.config updates,\nNFV CI running in user configuration with many tempest plugins, need a simple way to run neutron tests for verification, without curl init and additional client activation, \n\nNFV CI running tests with many types of images and flavors.\nNo cirros images exist at all, since SRIOV Drivers and vfio drivers enabled bt default.\n\nNFV regression, run on each z Regression, this is how we found tests changes :)","commit_id":"c1f71df74a9a10acc29b18dccd99d4aaaf189991"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1df4f7b574b652ce54d4e529a92ad3ad7ab09e64","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless("},{"line_number":225,"context_line":"          CONF.neutron_plugin_options.image_is_advanced,"},{"line_number":226,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":228,"context_line":"    def test_subport_connectivity(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_2f6992f4","line":225,"updated":"2018-12-12 09:41:28.000000000","message":"this is not correct for sure. For example in our gate we have image_is_advanced\u003dFalse but we have advanced_image_ref so this test shouldn\u0027t be skipped","commit_id":"ccf0ef7a646a8a2a16e590c77436123a4e01923b"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"9c1f6c5b3763eac53b4fd1624b420aa2d696c60f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless("},{"line_number":225,"context_line":"          CONF.neutron_plugin_options.image_is_advanced,"},{"line_number":226,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":228,"context_line":"    def test_subport_connectivity(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_4dc5ec5d","line":225,"in_reply_to":"3f79a3b5_2f6992f4","updated":"2018-12-13 08:57:22.000000000","message":"OK, i was not aware of that,\nSo, i will suggest fressi solution regards cirros usage, \nAck","commit_id":"ccf0ef7a646a8a2a16e590c77436123a4e01923b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"748fdc889985ce58a77c652bdc4287dc586ad336","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless("},{"line_number":225,"context_line":"          CONF.neutron_plugin_options.advanced_image_ref,"},{"line_number":226,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":228,"context_line":"    def test_subport_connectivity(self):"},{"line_number":229,"context_line":"        vlan_tag \u003d 10"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_7a2803eb","line":226,"updated":"2018-12-20 09:23:58.000000000","message":"But still, If You set this new option \"default_image_cirros\" to False You don\u0027t need to skip this test if \"advanced_image_ref\" is not set because in such case You have Your default image as advanced one, right?","commit_id":"dc35f4959962668d16af5781d37fd97ea9292e44"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"835415648a9ae62baa7187c561fc469408bab701","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless("},{"line_number":225,"context_line":"          CONF.neutron_plugin_options.advanced_image_ref,"},{"line_number":226,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":228,"context_line":"    def test_subport_connectivity(self):"},{"line_number":229,"context_line":"        vlan_tag \u003d 10"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f769fc5_9a000d37","line":226,"in_reply_to":"1f769fc5_5a9b5571","updated":"2018-12-27 09:36:15.000000000","message":"IIRC intention of this change was that You didn\u0027t want to \"easily\" put value in advanced_image_ref to workaround Your issue. So I would prefer to not force anyone else to do such things. If we are doing this change, we should do it properly and change those conditions too :)","commit_id":"dc35f4959962668d16af5781d37fd97ea9292e44"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"016e496dbc5d70e785507e088e66da6e93e3a4dc","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless("},{"line_number":225,"context_line":"          CONF.neutron_plugin_options.advanced_image_ref,"},{"line_number":226,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":228,"context_line":"    def test_subport_connectivity(self):"},{"line_number":229,"context_line":"        vlan_tag \u003d 10"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_3da60510","line":226,"in_reply_to":"3f79a3b5_3a4dabc5","updated":"2018-12-20 09:55:20.000000000","message":"But if is in _create_server_with_fip() and _create_server_with_port_and_subport() methods. Problem is that whole test will be skipped so You will not get to this \"if\" condition even.\nYou need to modify condition here too","commit_id":"dc35f4959962668d16af5781d37fd97ea9292e44"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"cc111f749c06cc2384b31b76a1d96d9bd6ab8535","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless("},{"line_number":225,"context_line":"          CONF.neutron_plugin_options.advanced_image_ref,"},{"line_number":226,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":228,"context_line":"    def test_subport_connectivity(self):"},{"line_number":229,"context_line":"        vlan_tag \u003d 10"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f769fc5_5a9b5571","line":226,"in_reply_to":"3f79a3b5_3da60510","updated":"2018-12-27 09:04:45.000000000","message":"Yep, but this can easily solved with putting some value \nCONF.neutron_plugin_options.advanced_image_ref\nto enter the test","commit_id":"dc35f4959962668d16af5781d37fd97ea9292e44"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"1f2d1191e26c33dace82822d9f0c20369723aa9b","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @testtools.skipUnless("},{"line_number":225,"context_line":"          CONF.neutron_plugin_options.advanced_image_ref,"},{"line_number":226,"context_line":"          \"Advanced image is required to run this test.\")"},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-89a2-cce7da66aafb\u0027)"},{"line_number":228,"context_line":"    def test_subport_connectivity(self):"},{"line_number":229,"context_line":"        vlan_tag \u003d 10"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_3a4dabc5","line":226,"in_reply_to":"3f79a3b5_7a2803eb","updated":"2018-12-20 09:32:00.000000000","message":"Yep, correct and there is small if. whether using default or advanced image, KISS :)","commit_id":"dc35f4959962668d16af5781d37fd97ea9292e44"}]}