)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"711e31981266180a332c473e0c09818120f44e7d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest api tests for security groups RBAC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.openstack.org/635313"},{"line_number":10,"context_line":"Change-Id: I806d0c1763a0abc4f07a7c85922949b056ad78d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9fdfeff1_30e5410b","line":9,"updated":"2019-02-21 11:59:00.000000000","message":"You should do depends-on with neutron patch also","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"8cd2f41996fd4ad12ad1214356d252d1c5df821d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest api tests for security groups RBAC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.openstack.org/635313"},{"line_number":10,"context_line":"Change-Id: I806d0c1763a0abc4f07a7c85922949b056ad78d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9fdfeff1_bc8b43be","line":9,"in_reply_to":"9fdfeff1_30e5410b","updated":"2019-02-21 18:28:11.000000000","message":"Ahh, good catch. I flipped the order of the dependency chain, and didn\u0027t fix this one.","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"ca2d30bc9492997e27500a970c9e3c1fe5f20ade","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest api tests for security groups RBAC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.openstack.org/635313"},{"line_number":10,"context_line":"Change-Id: I806d0c1763a0abc4f07a7c85922949b056ad78d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9fdfeff1_4b68b41f","line":9,"in_reply_to":"9fdfeff1_30e5410b","updated":"2019-03-01 03:57:54.000000000","message":"Done","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"}],"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"711e31981266180a332c473e0c09818120f44e7d","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    force_tenant_isolation \u003d True"},{"line_number":125,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]"},{"line_number":126,"context_line":"    required_extensions \u003d [\u0027security-group\u0027]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @classmethod"},{"line_number":129,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_9042ed0e","line":126,"updated":"2019-02-21 11:59:00.000000000","message":"also \"rbac-security-groups\" should be added to this list probably","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"ca2d30bc9492997e27500a970c9e3c1fe5f20ade","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    force_tenant_isolation \u003d True"},{"line_number":125,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]"},{"line_number":126,"context_line":"    required_extensions \u003d [\u0027security-group\u0027]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @classmethod"},{"line_number":129,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_cb658446","line":126,"in_reply_to":"9fdfeff1_9042ed0e","updated":"2019-03-01 03:57:54.000000000","message":"Done","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"8cd2f41996fd4ad12ad1214356d252d1c5df821d","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    force_tenant_isolation \u003d True"},{"line_number":125,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]"},{"line_number":126,"context_line":"    required_extensions \u003d [\u0027security-group\u0027]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @classmethod"},{"line_number":129,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_3cb99378","line":126,"in_reply_to":"9fdfeff1_9042ed0e","updated":"2019-02-21 18:28:11.000000000","message":"Ohh, I wonder if that\u0027ll let me get rid of all the decorators with that. Good.","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"711e31981266180a332c473e0c09818120f44e7d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                \u0027tenant_id\u0027: tenant_id}"},{"line_number":138,"context_line":"        sg \u003d self.admin_client.create_security_group(**args)[\u0027security_group\u0027]"},{"line_number":139,"context_line":"        self.addCleanup(self.admin_client.delete_security_group, sg[\u0027id\u0027])"},{"line_number":140,"context_line":"        return sg"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _make_admin_sg_shared_to_tenant_id(self, tenant_id):"},{"line_number":143,"context_line":"        sg \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_700d09e7","line":140,"updated":"2019-02-21 11:59:00.000000000","message":"using self.create_security_group() from https://github.com/openstack/neutron-tempest-plugin/blob/7eb6725c80615dc0e2b46deb1f892f3af6a38d42/neutron_tempest_plugin/api/base.py#L745 should be enough IMO. It will add it to cleanup for You.","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"ca2d30bc9492997e27500a970c9e3c1fe5f20ade","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                \u0027tenant_id\u0027: tenant_id}"},{"line_number":138,"context_line":"        sg \u003d self.admin_client.create_security_group(**args)[\u0027security_group\u0027]"},{"line_number":139,"context_line":"        self.addCleanup(self.admin_client.delete_security_group, sg[\u0027id\u0027])"},{"line_number":140,"context_line":"        return sg"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _make_admin_sg_shared_to_tenant_id(self, tenant_id):"},{"line_number":143,"context_line":"        sg \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_8b9e9c03","line":140,"in_reply_to":"9fdfeff1_700d09e7","updated":"2019-03-01 03:57:54.000000000","message":"Done","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"8cd2f41996fd4ad12ad1214356d252d1c5df821d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                \u0027tenant_id\u0027: tenant_id}"},{"line_number":138,"context_line":"        sg \u003d self.admin_client.create_security_group(**args)[\u0027security_group\u0027]"},{"line_number":139,"context_line":"        self.addCleanup(self.admin_client.delete_security_group, sg[\u0027id\u0027])"},{"line_number":140,"context_line":"        return sg"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _make_admin_sg_shared_to_tenant_id(self, tenant_id):"},{"line_number":143,"context_line":"        sg \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_bca4a34c","line":140,"in_reply_to":"9fdfeff1_700d09e7","updated":"2019-02-21 18:28:11.000000000","message":"This was copied from qos_policy, but it looks like passing client\u003dNone will select the same admin client, so that might work. I\u0027ll try it.","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"711e31981266180a332c473e0c09818120f44e7d","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            self.admin_client.delete_rbac_policy(res[\u0027rbac_policy\u0027][\u0027id\u0027])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        # cleanup"},{"line_number":184,"context_line":"        self.client2.delete_port(port[\u0027id\u0027])"},{"line_number":185,"context_line":"        self.client2.delete_network(net[\u0027id\u0027])"},{"line_number":186,"context_line":"        self.admin_client.delete_rbac_policy(res[\u0027rbac_policy\u0027][\u0027id\u0027])"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @decorators.idempotent_id(\u00272a81795c-2a35-11e9-9d86-acde48001122\u0027)"},{"line_number":189,"context_line":"    @utils.requires_ext(extension\u003d\"rbac-security-groups\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_7026696b","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":70},"updated":"2019-02-21 11:59:00.000000000","message":"is this cleanup here necessary? If You would use create_ methods from https://github.com/openstack/neutron-tempest-plugin/blob/7eb6725c80615dc0e2b46deb1f892f3af6a38d42/neutron_tempest_plugin/api/base.py#L39 than You would have cleanup \"for free\" IMHO.","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"ca2d30bc9492997e27500a970c9e3c1fe5f20ade","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            self.admin_client.delete_rbac_policy(res[\u0027rbac_policy\u0027][\u0027id\u0027])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        # cleanup"},{"line_number":184,"context_line":"        self.client2.delete_port(port[\u0027id\u0027])"},{"line_number":185,"context_line":"        self.client2.delete_network(net[\u0027id\u0027])"},{"line_number":186,"context_line":"        self.admin_client.delete_rbac_policy(res[\u0027rbac_policy\u0027][\u0027id\u0027])"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @decorators.idempotent_id(\u00272a81795c-2a35-11e9-9d86-acde48001122\u0027)"},{"line_number":189,"context_line":"    @utils.requires_ext(extension\u003d\"rbac-security-groups\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_6bb49882","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":70},"in_reply_to":"9fdfeff1_7026696b","updated":"2019-03-01 03:57:54.000000000","message":"Half done. Using client2 makes it a little weird. Switched one of them.","commit_id":"76156b49285478fe505be64d6cfd38fd3a351d61"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e6310c6e5df2754d1c98c6e5b164873f79f138b5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        super(RbacSharedSecurityGroupTest, cls).resource_setup()"},{"line_number":130,"context_line":"        cls.client2 \u003d cls.os_alt.network_client"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _create_security_group(self, tenant_id\u003dNone):"},{"line_number":133,"context_line":"        return self.create_security_group("},{"line_number":134,"context_line":"            name\u003ddata_utils.rand_name(\u0027test-sg\u0027),"},{"line_number":135,"context_line":"            project\u003d{\u0027id\u0027: self.admin_client.tenant_id})"}],"source_content_type":"text/x-python","patch_set":14,"id":"9fdfeff1_c869058c","line":132,"range":{"start_line":132,"start_character":37,"end_line":132,"end_character":46},"updated":"2019-03-01 09:04:16.000000000","message":"You don\u0027t need this tenant_id here probably as it\u0027s never used. Or maybe You want to use self.admin_client.tenant_id only if this is None? Than You need to change L135 :)","commit_id":"844546b40b9efca91ebf533f24c8fc36822e39c6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fde306cc09d696f8ffaa6235fd1386960e6185c2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_tempest_plugin.api import base"},{"line_number":22,"context_line":"from neutron_tempest_plugin.api import base_security_groups"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import testtools"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SecGroupTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":16,"id":"5fc1f717_2ad98682","line":24,"updated":"2019-03-06 04:12:13.000000000","message":"This should be after L19","commit_id":"e255a07bf9e7237a64d1accf207c0c4844c5874f"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"1c287e1fd429c59a8b5ab1d677b3c3c832b565fe","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_tempest_plugin.api import base"},{"line_number":22,"context_line":"from neutron_tempest_plugin.api import base_security_groups"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import testtools"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SecGroupTest(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":16,"id":"5fc1f717_a52cc999","line":24,"in_reply_to":"5fc1f717_2ad98682","updated":"2019-03-06 05:12:47.000000000","message":"Indeed, what was I smoking. Done.","commit_id":"e255a07bf9e7237a64d1accf207c0c4844c5874f"}]}
