)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a249ae8d0be4f3b433a607b950b128b26d2d014a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"test case for dvr east west traffic cross hosts."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Testing:"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/#/c/639009/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I695e833ccedddafaf9f5b7ccbd4831f02efde733"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bfb3d3c7_98cc818a","line":13,"updated":"2019-05-20 09:18:30.000000000","message":"This patch has -2 from You. So how You want to go with this one then? Is it really depends on https://review.opendev.org/#/c/639009/ ? Or should it be removed from commit message?","commit_id":"782554253f4d7897ae312e4607fad34036f2f5d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4e40e4b535ed821a20c158f393292e5a1437d3d8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"test case for dvr east west traffic cross hosts."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Testing:"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/#/c/639009/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I695e833ccedddafaf9f5b7ccbd4831f02efde733"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bfb3d3c7_a5126e57","line":13,"in_reply_to":"bfb3d3c7_98cc818a","updated":"2019-05-20 23:16:44.000000000","message":"Yes, for now, this patch is testing that 639009, I will remove this.","commit_id":"782554253f4d7897ae312e4607fad34036f2f5d1"}],"neutron_tempest_plugin/scenario/base.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a249ae8d0be4f3b433a607b950b128b26d2d014a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param fragmentation: Flag for packet fragmentation"},{"line_number":253,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":254,"context_line":"        :returns: ping is false if ping failed"},{"line_number":255,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_b8aaa582","line":252,"updated":"2019-05-20 09:18:30.000000000","message":"Please add new parameter to the doc string","commit_id":"782554253f4d7897ae312e4607fad34036f2f5d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4e40e4b535ed821a20c158f393292e5a1437d3d8","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param fragmentation: Flag for packet fragmentation"},{"line_number":253,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":254,"context_line":"        :returns: ping is false if ping failed"},{"line_number":255,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_c56682ee","line":252,"in_reply_to":"bfb3d3c7_b8aaa582","updated":"2019-05-20 23:16:44.000000000","message":"Done, and add doc string for that ``timeout``.","commit_id":"782554253f4d7897ae312e4607fad34036f2f5d1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e49a70d4ebce21b2012f827a42ad6290f21ad04","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        :param dest: and IP to ping against"},{"line_number":249,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param timeout: timeout for all ping packet(s) get succeed"},{"line_number":253,"context_line":"        :param ping_count: Number of ping packet to sent"},{"line_number":254,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_08c0ee4f","line":251,"updated":"2019-05-23 20:04:46.000000000","message":"fragmentation param got dropped","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8927cf67a274ef2ffc85183715a81a1b603d68a9","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        :param dest: and IP to ping against"},{"line_number":249,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param timeout: timeout for all ping packet(s) get succeed"},{"line_number":253,"context_line":"        :param ping_count: Number of ping packet to sent"},{"line_number":254,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_f4668f29","line":251,"in_reply_to":"bfb3d3c7_08c0ee4f","updated":"2019-05-24 01:20:13.000000000","message":"Done","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e49a70d4ebce21b2012f827a42ad6290f21ad04","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param timeout: timeout for all ping packet(s) get succeed"},{"line_number":253,"context_line":"        :param ping_count: Number of ping packet to sent"},{"line_number":254,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":255,"context_line":"        :returns: ping is false if ping failed"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_a8b682f9","line":252,"range":{"start_line":252,"start_character":55,"end_line":252,"end_character":58},"updated":"2019-05-23 20:04:46.000000000","message":"s/to","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8927cf67a274ef2ffc85183715a81a1b603d68a9","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param timeout: timeout for all ping packet(s) get succeed"},{"line_number":253,"context_line":"        :param ping_count: Number of ping packet to sent"},{"line_number":254,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":255,"context_line":"        :returns: ping is false if ping failed"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_946dd305","line":252,"range":{"start_line":252,"start_character":55,"end_line":252,"end_character":58},"in_reply_to":"bfb3d3c7_a8b682f9","updated":"2019-05-24 01:20:13.000000000","message":"Done","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e49a70d4ebce21b2012f827a42ad6290f21ad04","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param timeout: timeout for all ping packet(s) get succeed"},{"line_number":253,"context_line":"        :param ping_count: Number of ping packet to sent"},{"line_number":254,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":255,"context_line":"        :returns: ping is false if ping failed"},{"line_number":256,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_88cb7e70","line":253,"range":{"start_line":253,"start_character":42,"end_line":253,"end_character":48},"updated":"2019-05-23 20:04:46.000000000","message":"s/packet(s)","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e49a70d4ebce21b2012f827a42ad6290f21ad04","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param timeout: timeout for all ping packet(s) get succeed"},{"line_number":253,"context_line":"        :param ping_count: Number of ping packet to sent"},{"line_number":254,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":255,"context_line":"        :returns: ping is false if ping failed"},{"line_number":256,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_48c5865a","line":253,"range":{"start_line":253,"start_character":52,"end_line":253,"end_character":56},"updated":"2019-05-23 20:04:46.000000000","message":"s/send","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8927cf67a274ef2ffc85183715a81a1b603d68a9","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param timeout: timeout for all ping packet(s) get succeed"},{"line_number":253,"context_line":"        :param ping_count: Number of ping packet to sent"},{"line_number":254,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":255,"context_line":"        :returns: ping is false if ping failed"},{"line_number":256,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_54775bd5","line":253,"range":{"start_line":253,"start_character":52,"end_line":253,"end_character":56},"in_reply_to":"bfb3d3c7_48c5865a","updated":"2019-05-24 01:20:13.000000000","message":"Done","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8927cf67a274ef2ffc85183715a81a1b603d68a9","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param timeout: timeout for all ping packet(s) get succeed"},{"line_number":253,"context_line":"        :param ping_count: Number of ping packet to sent"},{"line_number":254,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":255,"context_line":"        :returns: ping is false if ping failed"},{"line_number":256,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_74729fe5","line":253,"range":{"start_line":253,"start_character":42,"end_line":253,"end_character":48},"in_reply_to":"bfb3d3c7_88cb7e70","updated":"2019-05-24 01:20:13.000000000","message":"Done","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9988673b924f1d92ed77a89fca3aef400b4bfdd3","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def _check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":242,"context_line":"                                   nic\u003dNone, mtu\u003dNone, fragmentation\u003dTrue,"},{"line_number":243,"context_line":"                                   timeout\u003dNone,"},{"line_number":244,"context_line":"                                   ping_count\u003dCONF.validation.ping_count):"},{"line_number":245,"context_line":"        \"\"\"check ping server via source ssh connection"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        :param source: RemoteClient: an ssh connection from which to ping"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_292fe28e","line":244,"updated":"2019-05-24 19:15:13.000000000","message":"This method is only called from one place (below), so ping_count can be a required argument right after dest as it\u0027s always passed now.","commit_id":"cc5181ebf6c421597dd8670e46b748f732a81fb2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ba4cc80c13c4825eb9c05c2a659977712602a566","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def _check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":242,"context_line":"                                   nic\u003dNone, mtu\u003dNone, fragmentation\u003dTrue,"},{"line_number":243,"context_line":"                                   timeout\u003dNone,"},{"line_number":244,"context_line":"                                   ping_count\u003dCONF.validation.ping_count):"},{"line_number":245,"context_line":"        \"\"\"check ping server via source ssh connection"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        :param source: RemoteClient: an ssh connection from which to ping"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_b9f8f97a","line":244,"in_reply_to":"bfb3d3c7_292fe28e","updated":"2019-05-26 08:42:52.000000000","message":"Done","commit_id":"cc5181ebf6c421597dd8670e46b748f732a81fb2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9988673b924f1d92ed77a89fca3aef400b4bfdd3","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param fragmentation: Flag for packet fragmentation"},{"line_number":253,"context_line":"        :param timeout: Timeout for all ping packet(s) to succeed"},{"line_number":254,"context_line":"        :param ping_count: Number of ping packet(s) to send"},{"line_number":255,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":256,"context_line":"        :returns: ping is false if ping failed"},{"line_number":257,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_a93f52b2","line":254,"updated":"2019-05-24 19:15:13.000000000","message":"This would just move up then.","commit_id":"cc5181ebf6c421597dd8670e46b748f732a81fb2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ba4cc80c13c4825eb9c05c2a659977712602a566","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":252,"context_line":"        :param fragmentation: Flag for packet fragmentation"},{"line_number":253,"context_line":"        :param timeout: Timeout for all ping packet(s) to succeed"},{"line_number":254,"context_line":"        :param ping_count: Number of ping packet(s) to send"},{"line_number":255,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":256,"context_line":"        :returns: ping is false if ping failed"},{"line_number":257,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_99fbb577","line":254,"in_reply_to":"bfb3d3c7_a93f52b2","updated":"2019-05-26 08:42:52.000000000","message":"Done","commit_id":"cc5181ebf6c421597dd8670e46b748f732a81fb2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9988673b924f1d92ed77a89fca3aef400b4bfdd3","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":256,"context_line":"        :returns: ping is false if ping failed"},{"line_number":257,"context_line":"        \"\"\""},{"line_number":258,"context_line":"        def ping_host(source, host, count\u003dCONF.validation.ping_count,"},{"line_number":259,"context_line":"                      size\u003dCONF.validation.ping_size, nic\u003dNone, mtu\u003dNone,"},{"line_number":260,"context_line":"                      fragmentation\u003dTrue):"},{"line_number":261,"context_line":"            IP_VERSION_4 \u003d neutron_lib_constants.IP_VERSION_4"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_493336f7","line":258,"range":{"start_line":258,"start_character":36,"end_line":258,"end_character":68},"updated":"2019-05-24 19:15:13.000000000","message":"s/count","commit_id":"cc5181ebf6c421597dd8670e46b748f732a81fb2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ba4cc80c13c4825eb9c05c2a659977712602a566","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":256,"context_line":"        :returns: ping is false if ping failed"},{"line_number":257,"context_line":"        \"\"\""},{"line_number":258,"context_line":"        def ping_host(source, host, count\u003dCONF.validation.ping_count,"},{"line_number":259,"context_line":"                      size\u003dCONF.validation.ping_size, nic\u003dNone, mtu\u003dNone,"},{"line_number":260,"context_line":"                      fragmentation\u003dTrue):"},{"line_number":261,"context_line":"            IP_VERSION_4 \u003d neutron_lib_constants.IP_VERSION_4"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_f902f16e","line":258,"range":{"start_line":258,"start_character":36,"end_line":258,"end_character":68},"in_reply_to":"bfb3d3c7_493336f7","updated":"2019-05-26 08:42:52.000000000","message":"Done","commit_id":"cc5181ebf6c421597dd8670e46b748f732a81fb2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9988673b924f1d92ed77a89fca3aef400b4bfdd3","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            try:"},{"line_number":281,"context_line":"                result \u003d ping_host(source, dest, nic\u003dnic, mtu\u003dmtu,"},{"line_number":282,"context_line":"                                   fragmentation\u003dfragmentation,"},{"line_number":283,"context_line":"                                   count\u003dping_count)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"            except lib_exc.SSHExecCommandFailed:"},{"line_number":286,"context_line":"                LOG.warning(\u0027Failed to ping IP: %s via a ssh connection \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_4948165b","line":283,"updated":"2019-05-24 19:15:13.000000000","message":"Then change count to be after dest","commit_id":"cc5181ebf6c421597dd8670e46b748f732a81fb2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ba4cc80c13c4825eb9c05c2a659977712602a566","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            try:"},{"line_number":281,"context_line":"                result \u003d ping_host(source, dest, nic\u003dnic, mtu\u003dmtu,"},{"line_number":282,"context_line":"                                   fragmentation\u003dfragmentation,"},{"line_number":283,"context_line":"                                   count\u003dping_count)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"            except lib_exc.SSHExecCommandFailed:"},{"line_number":286,"context_line":"                LOG.warning(\u0027Failed to ping IP: %s via a ssh connection \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_d9fdad6e","line":283,"in_reply_to":"bfb3d3c7_4948165b","updated":"2019-05-26 08:42:52.000000000","message":"Done","commit_id":"cc5181ebf6c421597dd8670e46b748f732a81fb2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffb88c310e0ad77a3406110c4d61c57a57ddbd80","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        :param source: RemoteClient: an ssh connection from which to ping"},{"line_number":248,"context_line":"        :param dest: and IP to ping against"},{"line_number":249,"context_line":"        :param count: Number of ping packet(s) to send"},{"line_number":250,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":251,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":252,"context_line":"        :param mtu: mtu size for the packet to be sent"}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_c742a33e","line":249,"range":{"start_line":249,"start_character":37,"end_line":249,"end_character":46},"updated":"2019-05-27 06:42:41.000000000","message":"nitty nit: IMO it should be just \"packets\"","commit_id":"68ab245db7731358a97b3fd47ab5458d42e6b7d9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffb88c310e0ad77a3406110c4d61c57a57ddbd80","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":252,"context_line":"        :param mtu: mtu size for the packet to be sent"},{"line_number":253,"context_line":"        :param fragmentation: Flag for packet fragmentation"},{"line_number":254,"context_line":"        :param timeout: Timeout for all ping packet(s) to succeed"},{"line_number":255,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":256,"context_line":"        :returns: ping is false if ping failed"},{"line_number":257,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_e73fa7b1","line":254,"range":{"start_line":254,"start_character":45,"end_line":254,"end_character":54},"updated":"2019-05-27 06:42:41.000000000","message":"same here :)","commit_id":"68ab245db7731358a97b3fd47ab5458d42e6b7d9"}],"neutron_tempest_plugin/scenario/test_connectivity.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a249ae8d0be4f3b433a607b950b128b26d2d014a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            ap1_sshclient, ap2_internal_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027b72c3b77-3396-4144-b05d-9cd3c0099893\u0027)"},{"line_number":114,"context_line":"    def test_connectivity_dvr_east_west_traffic_different_host(self):"},{"line_number":115,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":116,"context_line":"        dvr_net_2 \u003d self.create_network()"},{"line_number":117,"context_line":"        dvr_subnet_1 \u003d self.create_subnet(dvr_net_1, cidr\u003d\"10.10.1.0/24\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_d888b920","line":114,"range":{"start_line":114,"start_character":48,"end_line":114,"end_character":62},"updated":"2019-05-20 09:18:30.000000000","message":"this isn\u0027t always true. Method self._create_servers() will try to create servers on different hosts if there is more than 1 compute node available and if  \"DifferentHostFilter\" scheduler filter is enabled. Otherwise it will just spawn 2 vms on same host.","commit_id":"782554253f4d7897ae312e4607fad34036f2f5d1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4e40e4b535ed821a20c158f393292e5a1437d3d8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            ap1_sshclient, ap2_internal_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027b72c3b77-3396-4144-b05d-9cd3c0099893\u0027)"},{"line_number":114,"context_line":"    def test_connectivity_dvr_east_west_traffic_different_host(self):"},{"line_number":115,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":116,"context_line":"        dvr_net_2 \u003d self.create_network()"},{"line_number":117,"context_line":"        dvr_subnet_1 \u003d self.create_subnet(dvr_net_1, cidr\u003d\"10.10.1.0/24\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_254d1e72","line":114,"range":{"start_line":114,"start_character":48,"end_line":114,"end_character":62},"in_reply_to":"bfb3d3c7_d888b920","updated":"2019-05-20 23:16:44.000000000","message":"Yes, so we have any multi-node testing else? I can move this case to it. : )","commit_id":"782554253f4d7897ae312e4607fad34036f2f5d1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e49a70d4ebce21b2012f827a42ad6290f21ad04","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def test_connectivity_dvr_east_west_traffic_different_host(self):"},{"line_number":115,"context_line":"        if (CONF.compute.min_compute_nodes \u003c\u003d 1 or not"},{"line_number":116,"context_line":"                compute.is_scheduler_filter_enabled(\"DifferentHostFilter\")):"},{"line_number":117,"context_line":"            msg \u003d (\"No enough compute node or DifferentHostFilter is \""},{"line_number":118,"context_line":"                   \"not enabled, skipping dvr east west traffic testing.\")"},{"line_number":119,"context_line":"            raise self.skipTest(msg)"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_88905e50","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":42},"updated":"2019-05-23 20:04:46.000000000","message":"s/Not enough compute nodes","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8927cf67a274ef2ffc85183715a81a1b603d68a9","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def test_connectivity_dvr_east_west_traffic_different_host(self):"},{"line_number":115,"context_line":"        if (CONF.compute.min_compute_nodes \u003c\u003d 1 or not"},{"line_number":116,"context_line":"                compute.is_scheduler_filter_enabled(\"DifferentHostFilter\")):"},{"line_number":117,"context_line":"            msg \u003d (\"No enough compute node or DifferentHostFilter is \""},{"line_number":118,"context_line":"                   \"not enabled, skipping dvr east west traffic testing.\")"},{"line_number":119,"context_line":"            raise self.skipTest(msg)"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_347c27b4","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":42},"in_reply_to":"bfb3d3c7_88905e50","updated":"2019-05-24 01:20:13.000000000","message":"removed","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e49a70d4ebce21b2012f827a42ad6290f21ad04","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        if (CONF.compute.min_compute_nodes \u003c\u003d 1 or not"},{"line_number":116,"context_line":"                compute.is_scheduler_filter_enabled(\"DifferentHostFilter\")):"},{"line_number":117,"context_line":"            msg \u003d (\"No enough compute node or DifferentHostFilter is \""},{"line_number":118,"context_line":"                   \"not enabled, skipping dvr east west traffic testing.\")"},{"line_number":119,"context_line":"            raise self.skipTest(msg)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        dvr_net_1 \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_489a666e","line":118,"range":{"start_line":118,"start_character":42,"end_line":118,"end_character":55},"updated":"2019-05-23 20:04:46.000000000","message":"s/DVR East/West ?","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8927cf67a274ef2ffc85183715a81a1b603d68a9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        if (CONF.compute.min_compute_nodes \u003c\u003d 1 or not"},{"line_number":116,"context_line":"                compute.is_scheduler_filter_enabled(\"DifferentHostFilter\")):"},{"line_number":117,"context_line":"            msg \u003d (\"No enough compute node or DifferentHostFilter is \""},{"line_number":118,"context_line":"                   \"not enabled, skipping dvr east west traffic testing.\")"},{"line_number":119,"context_line":"            raise self.skipTest(msg)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        dvr_net_1 \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_d44cab9f","line":118,"range":{"start_line":118,"start_character":42,"end_line":118,"end_character":55},"in_reply_to":"bfb3d3c7_489a666e","updated":"2019-05-24 01:20:13.000000000","message":"removed","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a103ae79fb3a9c7e455bb87059fc53b67cf58795","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027b72c3b77-3396-4144-b05d-9cd3c0099893\u0027)"},{"line_number":114,"context_line":"    def test_connectivity_dvr_east_west_traffic_different_host(self):"},{"line_number":115,"context_line":"        if (CONF.compute.min_compute_nodes \u003c\u003d 1 or not"},{"line_number":116,"context_line":"                compute.is_scheduler_filter_enabled(\"DifferentHostFilter\")):"},{"line_number":117,"context_line":"            msg \u003d (\"No enough compute node or DifferentHostFilter is \""},{"line_number":118,"context_line":"                   \"not enabled, skipping dvr east west traffic testing.\")"},{"line_number":119,"context_line":"            raise self.skipTest(msg)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":122,"context_line":"        dvr_net_2 \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_abda2314","line":119,"range":{"start_line":115,"start_character":8,"end_line":119,"end_character":36},"updated":"2019-05-22 09:47:18.000000000","message":"Maybe we can remove this check to test same host traffic too.","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8927cf67a274ef2ffc85183715a81a1b603d68a9","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027b72c3b77-3396-4144-b05d-9cd3c0099893\u0027)"},{"line_number":114,"context_line":"    def test_connectivity_dvr_east_west_traffic_different_host(self):"},{"line_number":115,"context_line":"        if (CONF.compute.min_compute_nodes \u003c\u003d 1 or not"},{"line_number":116,"context_line":"                compute.is_scheduler_filter_enabled(\"DifferentHostFilter\")):"},{"line_number":117,"context_line":"            msg \u003d (\"No enough compute node or DifferentHostFilter is \""},{"line_number":118,"context_line":"                   \"not enabled, skipping dvr east west traffic testing.\")"},{"line_number":119,"context_line":"            raise self.skipTest(msg)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":122,"context_line":"        dvr_net_2 \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_f44f6f8f","line":119,"range":{"start_line":115,"start_character":8,"end_line":119,"end_character":36},"in_reply_to":"bfb3d3c7_28c6124a","updated":"2019-05-24 01:20:13.000000000","message":"Done, removed","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1165bc815bb8952548850a6baff0385023bb2904","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027b72c3b77-3396-4144-b05d-9cd3c0099893\u0027)"},{"line_number":114,"context_line":"    def test_connectivity_dvr_east_west_traffic_different_host(self):"},{"line_number":115,"context_line":"        if (CONF.compute.min_compute_nodes \u003c\u003d 1 or not"},{"line_number":116,"context_line":"                compute.is_scheduler_filter_enabled(\"DifferentHostFilter\")):"},{"line_number":117,"context_line":"            msg \u003d (\"No enough compute node or DifferentHostFilter is \""},{"line_number":118,"context_line":"                   \"not enabled, skipping dvr east west traffic testing.\")"},{"line_number":119,"context_line":"            raise self.skipTest(msg)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":122,"context_line":"        dvr_net_2 \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_94b87376","line":119,"range":{"start_line":115,"start_character":8,"end_line":119,"end_character":36},"in_reply_to":"bfb3d3c7_28c6124a","updated":"2019-05-24 01:09:33.000000000","message":"Plz see line 136 _create_servers, and line 44 - 57 for its implemention.","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e49a70d4ebce21b2012f827a42ad6290f21ad04","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @decorators.idempotent_id(\u0027b72c3b77-3396-4144-b05d-9cd3c0099893\u0027)"},{"line_number":114,"context_line":"    def test_connectivity_dvr_east_west_traffic_different_host(self):"},{"line_number":115,"context_line":"        if (CONF.compute.min_compute_nodes \u003c\u003d 1 or not"},{"line_number":116,"context_line":"                compute.is_scheduler_filter_enabled(\"DifferentHostFilter\")):"},{"line_number":117,"context_line":"            msg \u003d (\"No enough compute node or DifferentHostFilter is \""},{"line_number":118,"context_line":"                   \"not enabled, skipping dvr east west traffic testing.\")"},{"line_number":119,"context_line":"            raise self.skipTest(msg)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":122,"context_line":"        dvr_net_2 \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bfb3d3c7_28c6124a","line":119,"range":{"start_line":115,"start_character":8,"end_line":119,"end_character":36},"in_reply_to":"bfb3d3c7_abda2314","updated":"2019-05-23 20:04:46.000000000","message":"Right, plus I don\u0027t see code below to bind each server to a different compute.","commit_id":"c6b36cf0831648bd54a02fcfae430580d64285a1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"10d6f74c6997904d80f1ad3d35eb3357cdba9ae7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        same/different host."},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":121,"context_line":"        dvr_net_2 \u003d self.create_network()"},{"line_number":122,"context_line":"        dvr_subnet_1 \u003d self.create_subnet(dvr_net_1, cidr\u003d\"10.10.1.0/24\")"},{"line_number":123,"context_line":"        dvr_subnet_2 \u003d self.create_subnet(dvr_net_2, cidr\u003d\"10.10.2.0/24\")"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_7b3febb3","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":17},"updated":"2019-05-24 07:12:01.000000000","message":"nit: please change names of those variables. This test can be run on any type of L3 agents so it\u0027s not \"dvr\" network always. Better IMO would be to name it \"net_1\" and \"net_2\" simply.\n\nAnd same comment applies also for subnets below :)","commit_id":"ecd565867e77051a6a7ac981797d5ce575b5f131"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"941492a792af0c11bcba0480ba07fb097c7918c7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        same/different host."},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":121,"context_line":"        dvr_net_2 \u003d self.create_network()"},{"line_number":122,"context_line":"        dvr_subnet_1 \u003d self.create_subnet(dvr_net_1, cidr\u003d\"10.10.1.0/24\")"},{"line_number":123,"context_line":"        dvr_subnet_2 \u003d self.create_subnet(dvr_net_2, cidr\u003d\"10.10.2.0/24\")"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_de904546","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":17},"in_reply_to":"bfb3d3c7_7b3febb3","updated":"2019-05-24 08:34:17.000000000","message":"Done","commit_id":"ecd565867e77051a6a7ac981797d5ce575b5f131"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5a168afcedd6ac18b497428c861c8ff37f07ff2c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        same/different host."},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        dvr_net_1 \u003d self.create_network()"},{"line_number":121,"context_line":"        dvr_net_2 \u003d self.create_network()"},{"line_number":122,"context_line":"        dvr_subnet_1 \u003d self.create_subnet(dvr_net_1, cidr\u003d\"10.10.1.0/24\")"},{"line_number":123,"context_line":"        dvr_subnet_2 \u003d self.create_subnet(dvr_net_2, cidr\u003d\"10.10.2.0/24\")"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_5e96954e","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":17},"in_reply_to":"bfb3d3c7_7b3febb3","updated":"2019-05-24 08:30:28.000000000","message":"Ops... forgot this, thanks.","commit_id":"ecd565867e77051a6a7ac981797d5ce575b5f131"}]}