)]}'
{"neutron_tempest_plugin/config.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7fcadcca37bb0b1d1215473048aaa3f958f7d33","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    CONF.register_opt(opt, \u0027neutron_plugin_options\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"BgpvpnGroup \u003d ["},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027run_bgpvpn_tests\u0027,"},{"line_number":121,"context_line":"                default\u003dTrue,"},{"line_number":122,"context_line":"                help\u003d(\"If it is set to False bgpvpn api and scenario tests \""},{"line_number":123,"context_line":"                      \"will be skipped\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f4539d69","line":120,"updated":"2019-07-17 15:45:47.000000000","message":"nit suggestion: The group is bgpvpn, so \u0027run_tests\u0027 would be okay as an option name (but it is not a blocker)","commit_id":"7af348cad0ffd6b1f6d87c9523945d03799087e2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e5e5c044b9c17580e70416c5f29f024f5367d430","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    CONF.register_opt(opt, \u0027neutron_plugin_options\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"BgpvpnGroup \u003d ["},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027run_bgpvpn_tests\u0027,"},{"line_number":121,"context_line":"                default\u003dTrue,"},{"line_number":122,"context_line":"                help\u003d(\"If it is set to False bgpvpn api and scenario tests \""},{"line_number":123,"context_line":"                      \"will be skipped\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_62bfdda9","line":120,"in_reply_to":"7faddb67_c226d168","updated":"2019-07-18 12:35:19.000000000","message":"My comment means that we have CONF.fwaas.run_tests, CONF.bgpvpn.run_tests and CONF.sfc.run_tests. I don\u0027t think it is confusing but it is a personal preference. Thanks.","commit_id":"7af348cad0ffd6b1f6d87c9523945d03799087e2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"317f4535ff2b2acacc3cf8dec81d97628bf12219","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    CONF.register_opt(opt, \u0027neutron_plugin_options\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"BgpvpnGroup \u003d ["},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027run_bgpvpn_tests\u0027,"},{"line_number":121,"context_line":"                default\u003dTrue,"},{"line_number":122,"context_line":"                help\u003d(\"If it is set to False bgpvpn api and scenario tests \""},{"line_number":123,"context_line":"                      \"will be skipped\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c226d168","line":120,"in_reply_to":"7faddb67_f4539d69","updated":"2019-07-18 12:25:57.000000000","message":"but wouldn\u0027t this be confusing together with same name config option in \"FWaaS\" and \"SFC\" groups? To make it really clear I prefer to stay with names as they are currently.","commit_id":"7af348cad0ffd6b1f6d87c9523945d03799087e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc205b688f6a9a482208807311883089ec9de7b9","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    CONF.register_opt(opt, \u0027neutron_plugin_options\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"BgpvpnGroup \u003d ["},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027run_bgpvpn_tests\u0027,"},{"line_number":121,"context_line":"                default\u003dTrue,"},{"line_number":122,"context_line":"                help\u003d(\"If it is set to False bgpvpn api and scenario tests \""},{"line_number":123,"context_line":"                      \"will be skipped\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027min_asn\u0027,"},{"line_number":125,"context_line":"               default\u003d100,"},{"line_number":126,"context_line":"               help\u003d(\"Minimum number for the range of \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5902ec0b","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":42},"updated":"2019-07-17 14:25:43.000000000","message":"Because this config is temporary option to avoid the bgpvpn tests run on stable branches as they have these tests in-tree, you can add a TODO to remove this config option once stable/stein is EOL.\n\nTODO: This config option is added to avoid running bgpvpn tests twice on stable branches till stable/stein. We need to remove this config option once stable/stein is EOL. bgpvpn tempest plugin has been merged into neutron-tempest-plugin from Train. Train onwards bgpvpn tests will run from neutron-tempest-plugins.","commit_id":"7af348cad0ffd6b1f6d87c9523945d03799087e2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"317f4535ff2b2acacc3cf8dec81d97628bf12219","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    CONF.register_opt(opt, \u0027neutron_plugin_options\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"BgpvpnGroup \u003d ["},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027run_bgpvpn_tests\u0027,"},{"line_number":121,"context_line":"                default\u003dTrue,"},{"line_number":122,"context_line":"                help\u003d(\"If it is set to False bgpvpn api and scenario tests \""},{"line_number":123,"context_line":"                      \"will be skipped\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027min_asn\u0027,"},{"line_number":125,"context_line":"               default\u003d100,"},{"line_number":126,"context_line":"               help\u003d(\"Minimum number for the range of \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a2f635d6","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":42},"in_reply_to":"7faddb67_5902ec0b","updated":"2019-07-18 12:25:57.000000000","message":"Done","commit_id":"7af348cad0ffd6b1f6d87c9523945d03799087e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc205b688f6a9a482208807311883089ec9de7b9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"CONF.register_opts(BgpvpnGroup, group\u003d\"bgpvpn\")"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"FwaasGroup \u003d ["},{"line_number":148,"context_line":"    cfg.BoolOpt(\u0027run_fwaas_tests\u0027,"},{"line_number":149,"context_line":"                default\u003dTrue,"},{"line_number":150,"context_line":"                help\u003d(\"If it is set to False fwaas api and scenario tests \""},{"line_number":151,"context_line":"                      \"will be skipped\")),"},{"line_number":152,"context_line":"]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"fwaas_group \u003d cfg.OptGroup("}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_991b8471","line":151,"range":{"start_line":148,"start_character":0,"end_line":151,"end_character":42},"updated":"2019-07-17 14:25:43.000000000","message":"ditto","commit_id":"7af348cad0ffd6b1f6d87c9523945d03799087e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fc205b688f6a9a482208807311883089ec9de7b9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"CONF.register_opts(FwaasGroup, group\u003d\"fwaas\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"SfcGroup \u003d ["},{"line_number":160,"context_line":"    cfg.BoolOpt(\u0027run_sfc_tests\u0027,"},{"line_number":161,"context_line":"                default\u003dTrue,"},{"line_number":162,"context_line":"                help\u003d(\"If it is set to False SFC api and scenario tests \""},{"line_number":163,"context_line":"                      \"will be skipped\")),"},{"line_number":164,"context_line":"]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"sfc_group \u003d cfg.OptGroup(name\u003d\"sfc\", title\u003d(\"Networking-sfc Service Options\"))"},{"line_number":167,"context_line":"CONF.register_group(sfc_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b9168048","line":164,"range":{"start_line":160,"start_character":0,"end_line":164,"end_character":1},"updated":"2019-07-17 14:25:43.000000000","message":"ditto","commit_id":"7af348cad0ffd6b1f6d87c9523945d03799087e2"}]}