)]}'
{"neutron_tempest_plugin/scenario/test_qos.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0bdf016e43a955e695b5cbd74a3d21d1611fe8e4","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # Open TCP socket to remote VM and download big file"},{"line_number":110,"context_line":"        start_time \u003d time.time()"},{"line_number":111,"context_line":"        socket_timeout \u003d self.FILE_SIZE * self.TOLERANCE_FACTOR / expected_bw"},{"line_number":112,"context_line":"        client_socket \u003d _connect_socket(host, port, socket_timeout)"},{"line_number":113,"context_line":"        total_bytes_read \u003d 0"},{"line_number":114,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_555e8412","line":111,"updated":"2019-07-29 18:17:00.000000000","message":"nit: so here you use self.FILE_SIZE, but other places you still use QoSTestMixin.* - L106/115/116 - would be good to be consistent within a single method.","commit_id":"497cc97fbbe3b8d2855bc9b27a5512b56677e238"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba94eb905c2d9e1772f2c5040273d2ed053ae90a","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # Open TCP socket to remote VM and download big file"},{"line_number":110,"context_line":"        start_time \u003d time.time()"},{"line_number":111,"context_line":"        socket_timeout \u003d self.FILE_SIZE * self.TOLERANCE_FACTOR / expected_bw"},{"line_number":112,"context_line":"        client_socket \u003d _connect_socket(host, port, socket_timeout)"},{"line_number":113,"context_line":"        total_bytes_read \u003d 0"},{"line_number":114,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_eac77f11","line":111,"in_reply_to":"7faddb67_555e8412","updated":"2019-07-30 13:43:36.000000000","message":"You are right. If any other test, inheriting from this class, wants to overwrite those values, it should be able to do it.","commit_id":"497cc97fbbe3b8d2855bc9b27a5512b56677e238"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e53d062f24da1272dd0563d7833a23cccb2f811d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self._kill_nc_process(ssh_client)"},{"line_number":123,"context_line":"            return False"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        client_socket.close()"},{"line_number":126,"context_line":"        self._kill_nc_process(ssh_client)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # Calculate and return actual BW + logging result"},{"line_number":129,"context_line":"        time_elapsed \u003d time.time() - start_time"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_3950b40a","line":126,"range":{"start_line":125,"start_character":8,"end_line":126,"end_character":41},"updated":"2019-07-28 07:55:44.000000000","message":"nit: if You would put this in \"finally\" section, then You wouldn\u0027t need same in L121-122","commit_id":"497cc97fbbe3b8d2855bc9b27a5512b56677e238"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba94eb905c2d9e1772f2c5040273d2ed053ae90a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self._kill_nc_process(ssh_client)"},{"line_number":123,"context_line":"            return False"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        client_socket.close()"},{"line_number":126,"context_line":"        self._kill_nc_process(ssh_client)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # Calculate and return actual BW + logging result"},{"line_number":129,"context_line":"        time_elapsed \u003d time.time() - start_time"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_aa58a789","line":126,"range":{"start_line":125,"start_character":8,"end_line":126,"end_character":41},"in_reply_to":"7faddb67_3950b40a","updated":"2019-07-30 13:43:36.000000000","message":"I was trying to avoid to write everything inside the try/catch context. But it makes sense.","commit_id":"497cc97fbbe3b8d2855bc9b27a5512b56677e238"}]}